GNU bug report logs - #78008
[PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly

Previous Next

Package: emacs;

Reported by: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>

Date: Wed, 23 Apr 2025 08:38:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

To reply to this bug, email your comments to 78008 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#78008; Package emacs. (Wed, 23 Apr 2025 08:38:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 23 Apr 2025 08:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; csharp-ts-mode does not highlight
 string-interpolation expressions correctly
Date: Wed, 23 Apr 2025 10:37:09 +0200
[Message part 1 (text/plain, inline)]
Hey everyone!

Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.

This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.

Attached is a patch which fixes this.

—
Kind Regards
Jostein Kjønigsen


[Message part 2 (text/html, inline)]
[0001-csharp-mode.el-Improve-fontification-of-string-inter.patch (application/octet-stream, attachment)]
[Message part 4 (text/html, inline)]

Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sat, 26 Apr 2025 13:28:03 GMT) Full text and rfc822 format available.

Notification sent to Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>:
bug acknowledged by developer. (Sat, 26 Apr 2025 13:28:03 GMT) Full text and rfc822 format available.

Message #10 received at 78008-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78008-done <at> debbugs.gnu.org
Subject: Re: bug#78008: [PATCH] 31.0.50;
 csharp-ts-mode does not highlight string-interpolation expressions
 correctly
Date: Sat, 26 Apr 2025 16:26:54 +0300
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Wed, 23 Apr 2025 10:37:09 +0200
> 
> Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.
> 
> This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.
> 
> Attached is a patch which fixes this.

Thanks, now installed on the master branch, and closing the bug.




This bug report was last modified 6 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.