GNU logs - #78016, boring messages

Message sent to csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Wed, 23 Apr 2025 15:36:06 +0000
Resent-Message-ID: <handler.78016.B.174542253920293 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78016 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb@HIDDEN>, Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Cayetano Santos <csantosb@HIDDEN>
Date: Wed, 23 Apr 2025 17:34:51 +0200
Message-ID: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=93.190.126.19;
 envelope-from=csantosb@HIDDEN; helo=confino.investici.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

* gnu/packages/electronics.scm (symbiyosys): New variable.

Change-Id: I1a3758e4bf46fc6d57ef63a0c0f5f2e39a862c4d
---
 gnu/packages/electronics.scm | 65 +++++++++++++++++++++++++++++++++++-
 1 file changed, 64 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..7d0dfc3095 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -46,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages fpga)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages graphviz)
@@ -54,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages m4)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
@@ -67,7 +69,8 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
-  #:use-module (gnu packages version-control))
+  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages xml))

 (define-public comedilib
   (package
@@ -635,6 +638,66 @@ (define-public sigrok-firmware-fx2lafw
 them usable as simple logic analyzer and/or oscilloscope hardware.")
       (license license:gpl2+))))

+(define-public symbiyosys
+  (package
+    (name "symbiyosys")
+    (version "0.52")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/YosysHQ/sby/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06nhkmnl9ymp1wxapc0lnj82knj5q43x0s2rmfshwvs4cijzqm7f"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:test-target "test"
+      #:make-flags #~(list (string-append "PREFIX=" #$output))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure)
+                   (delete 'build)
+                   ;; info: requires furo-ys, not yet available
+                   ;; (add-after 'install 'build-info
+                   ;; (lambda _
+                   ;; (invoke "make" "-C" "docs" "info")))
+                   (add-before 'check 'create-git
+                     (lambda _
+                       (invoke "git" "init"))) ;check expects a git repo
+                   (add-after 'create-git 'patch-/usr/bin/env
+                     (lambda _
+                       (substitute* "sbysrc/sby_core.py"
+                         (("\"/usr/bin/env\", ")
+                          ""))
+                       (substitute* "sbysrc/sby.py"
+                         (("/usr/bin/env python")
+                          (which "python3")))))
+                   ;; remove tests which fail
+                   (add-after 'patch-/usr/bin/env 'delete-check-failures
+                     (lambda _
+                       (delete-file "tests/keepgoing/keepgoing_multi_step.sby")
+                       (delete-file-recursively "docs/examples/demos")
+                       (delete-file
+                        "tests/regression/aim_vs_smt2_nonzero_start_offset.sby"))))))
+    (inputs (list yosys abc))
+    (native-inputs (list
+                    ;; python-sphinx python-sphinx-argparse texinfo ; info
+                    python
+                    python-click
+                    python-xmlschema
+                    git-minimal/pinned
+                    boolector
+                    yices
+                    z3))
+    (home-page "https://github.com/YosysHQ/sby/")
+    (synopsis "Formal verification with yosys")
+    (description
+     "SimbyYosys is a front-end program for yosys-based formal hardware verification
+flows.")
+    (license license:isc)))
+
 (define-public uhdm
   (package
     (name "uhdm")

base-commit: 699ce22ed812cf8cfcdd8d0341829f8fac2c864a
-- 
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Cayetano Santos <csantosb@HIDDEN>
Subject: bug#78016: Acknowledgement ([PATCH electronics-team] gnu: Add
 symbiyosys.)
Message-ID: <handler.78016.B.174542253920293.ack <at> debbugs.gnu.org>
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
X-Gnu-PR-Message: ack 78016
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 78016 <at> debbugs.gnu.org
Date: Wed, 23 Apr 2025 15:36:07 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN=
ch>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 78016 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78016: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78016
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 07:00:02 +0000
Resent-Message-ID: <handler.78016.B78016.174556439322841 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78016 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
 (Cayetano Santos's message of "Wed, 23 Apr 2025 17:34:51 +0200")
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
Date: Fri, 25 Apr 2025 15:59:40 +0900
Message-ID: <874iycsp43.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Cayetano Santos <csantosb@HIDDEN> writes:

> * gnu/packages/electronics.scm (symbiyosys): New variable.

Neat!

[...]

> +    (arguments
> +     (list
> +      #:test-target "test"
> +      #:make-flags #~(list (string-append "PREFIX=" #$output))
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (delete 'build)
> +                   ;; info: requires furo-ys, not yet available

I'd use: TODO: build docs, after furo-ys is packaged.

> +                   ;; (add-after 'install 'build-info
> +                   ;; (lambda _
> +                   ;; (invoke "make" "-C" "docs" "info")))
> +                   (add-before 'check 'create-git

nitpick: I'd name the phase to 'git-init or similar.

> +                     (lambda _
> +                       (invoke "git" "init"))) ;check expects a git repo
> +                   (add-after 'create-git 'patch-/usr/bin/env
> +                     (lambda _
> +                       (substitute* "sbysrc/sby_core.py"
> +                         (("\"/usr/bin/env\", ")
> +                          ""))
> +                       (substitute* "sbysrc/sby.py"
> +                         (("/usr/bin/env python")
> +                          (which "python3")))))

It looks like 'sby' is the test runner, so that should be OK, but just
to make sure: are these source used at runtime?  If so, `which` must not
be used to patch the source, as it picks things from the PATH at *build*
time, which in a cross-compilation setting would not point to the same
binaries.

For non-tests sources, the safe way is to find the file names or
commands via e.g. (search-input-file inputs "bin/python3") for example
(with the 'inputs' key exposed via the phase procedure).

> +                   ;; remove tests which fail

Please use complete sentences for standalone comments [0].  Also try to
explain the failures.  When they cannot be explained it's best to report
them to the upstream project and keep a reference to the opened issue so
that resolution can be tracked.

[0]  See (info "(standards) Comments") from the gnu-standards package.

> +                   (add-after 'patch-/usr/bin/env 'delete-check-failures

I'd name this phase 'disable-problematic-tests.  Note that if this uses
the Automake test harness (it seems it does not, using sby instead),
then setting the make variable (flag) XFAIL_TESTS with the
space-separated names of the failing tests could be a better way, see
(info "(automake) Parallel Test Harness").

> +                     (lambda _
> +                       (delete-file "tests/keepgoing/keepgoing_multi_step.sby")
> +                       (delete-file-recursively "docs/examples/demos")
> +                       (delete-file
> +                        "tests/regression/aim_vs_smt2_nonzero_start_offset.sby"))))))
> +    (inputs (list yosys abc))

Please list in lexicographical order.

> +    (native-inputs (list
> +                    ;; python-sphinx python-sphinx-argparse texinfo ; info

Maybe add a standalone

;; TODO: see above build-info phase comment.

instead of the '; info' margin comment.

nitpick: no need for a space between ';' and the margin comment.

> +                    python
> +                    python-click
> +                    python-xmlschema
> +                    git-minimal/pinned
> +                    boolector
> +                    yices
> +                    z3))

Again, please sort :-)

> +    (home-page "https://github.com/YosysHQ/sby/")
> +    (synopsis "Formal verification with yosys")

I'd say 'Formal hardware verification with yosys'

Other than that it looks good to me!  Could you please send a v2?

-- 
Thanks,
Maxim

Message sent to csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78016] [PATCH v2] gnu: Add symbiyosys.
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
In-Reply-To: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 09:32:02 +0000
Resent-Message-ID: <handler.78016.B78016.17455734632506 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78016 <at> debbugs.gnu.org
Cc: csantosb@HIDDEN, Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Cayetano Santos <csantosb@HIDDEN>
Date: Fri, 25 Apr 2025 11:30:33 +0200
Message-ID: <2959c6b6d45577cfd1d6e61a86e2f3be14baf32c.1745573433.git.csantosb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

From: Cayetano Santos via Guix-patches via <guix-patches@HIDDEN>

* gnu/packages/electronics.scm (symbiyosys): New variable.

Change-Id: I1a3758e4bf46fc6d57ef63a0c0f5f2e39a862c4d
Signed-off-by: Cayetano Santos <csantosb@HIDDEN>
---
 gnu/packages/electronics.scm | 67 +++++++++++++++++++++++++++++++++++-
 1 file changed, 66 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..5ca28607b5 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -46,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages fpga)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages graphviz)
@@ -54,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages m4)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
@@ -67,7 +69,8 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
-  #:use-module (gnu packages version-control))
+  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages xml))
 
 (define-public comedilib
   (package
@@ -635,6 +638,68 @@ (define-public sigrok-firmware-fx2lafw
 them usable as simple logic analyzer and/or oscilloscope hardware.")
       (license license:gpl2+))))
 
+(define-public symbiyosys
+  (package
+    (name "symbiyosys")
+    (version "0.52")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/YosysHQ/sby/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06nhkmnl9ymp1wxapc0lnj82knj5q43x0s2rmfshwvs4cijzqm7f"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:test-target "test"
+      #:make-flags #~(list (string-append "PREFIX=" #$output))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure)
+                   (delete 'build)
+                   ;; TODO: build docs, after furo-ys is packaged.
+                   ;; (add-after 'install 'build-info
+                   ;; (lambda _
+                   ;; (invoke "make" "-C" "docs" "info")))
+                   (add-before 'check 'git-init
+                     (lambda _
+                       (invoke "git" "init"))) ;check expects a git repo
+                   (add-after 'git-init 'patch-/usr/bin/env
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (substitute* "sbysrc/sby_core.py"
+                         (("\"/usr/bin/env\", ")
+                          ""))
+                       (substitute* "sbysrc/sby.py"
+                         (("/usr/bin/env python")
+                          (search-input-file inputs "bin/python3")))))
+                   ;; The tests related to abc binary used by yosys produce errors
+                   ;; Disable them
+                   (add-after 'patch-/usr/bin/env 'disable-abc-tests
+                     (lambda _
+                       (delete-file "tests/keepgoing/keepgoing_multi_step.sby")
+                       (delete-file-recursively "docs/examples/demos")
+                       (delete-file
+                        "tests/regression/aim_vs_smt2_nonzero_start_offset.sby"))))))
+    (inputs (list abc yosys))
+    (native-inputs (list
+                    ;; TODO: see above build-info phase comment.
+                    ;; python-sphinx python-sphinx-argparse texinfo
+                    boolector
+                    git-minimal/pinned
+                    python
+                    python-click
+                    python-xmlschema
+                    yices
+                    z3))
+    (home-page "https://github.com/YosysHQ/sby/")
+    (synopsis "Formal hardware verification with yosys")
+    (description
+     "SimbyYosys is a front-end program for yosys-based formal hardware verification
+flows.")
+    (license license:isc)))
+
 (define-public uhdm
   (package
     (name "uhdm")

base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52
-- 
2.49.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 09:39:01 +0000
Resent-Message-ID: <handler.78016.B78016.17455738894680 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78016
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 78016 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
Received: via spool by 78016-submit <at> debbugs.gnu.org id=B78016.17455738894680
          (code B ref 78016); Fri, 25 Apr 2025 09:39:01 +0000
Received: (at 78016) by debbugs.gnu.org; 25 Apr 2025 09:38:09 +0000
Received: from localhost ([127.0.0.1]:47474 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8FVZ-0001DQ-C6
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 05:38:09 -0400
Received: from confino.investici.org ([2a11:7980:1::2:0]:48475)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>)
 id 1u8FVV-0001DA-R0
 for 78016 <at> debbugs.gnu.org; Fri, 25 Apr 2025 05:38:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org;
 s=stigmate; t=1745573882;
 bh=c0dTXwULlZeBrjPaXkrkIbSYXExIi0y3ur1MQckxiRQ=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=dKL9UnJVfy4WVLiZSFMUpp9e2uLSk/ZJyYpoCzGJeUYjAyg7D9xP2/Lu+vtn6ItnH
 TAEcBmjoR6poN5qBilyPGM8Yg9NaatCW+AEiH5kT5SKNbXYWp+1/53RuoSxiZgwRwd
 exiOU6vxcE0RohkgOGLAYuGBldZboUF7TFaE46WI=
Received: from mx1.investici.org (unknown [127.0.0.1])
 by confino.investici.org (Postfix) with ESMTP id 4ZkSSV3mC8z11CG;
 Fri, 25 Apr 2025 09:38:02 +0000 (UTC)
Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19])
 (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix)
 with ESMTPSA id 4ZkSSV27pZz11B9; 
 Fri, 25 Apr 2025 09:38:02 +0000 (UTC)
From: Cayetano Santos <csantosb@HIDDEN>
In-Reply-To: <874iycsp43.fsf@HIDDEN> (Maxim Cournoyer's message of "Fri, 25
 Apr 2025 15:59:40 +0900")
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
 <874iycsp43.fsf@HIDDEN>
User-Agent: mu4e 1.12.9; emacs 29.4
Date: Fri, 25 Apr 2025 11:37:55 +0200
Message-ID: <877c38shsc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


>ven. 25 avril 2025 at 15:59, Maxim Cournoyer <maxim.cournoyer@HIDDEN> w=
rote:

Thanks for the review, I have included all of your comments in v2.

>> +                   ;; remove tests which fail
>
> Please use complete sentences for standalone comments [0].  Also try to
> explain the failures.  When they cannot be explained it's best to report
> them to the upstream project and keep a reference to the opened issue so
> that resolution can be tracked.

The failures come from the fact that yosys uses a version of abc which
differs from the one we package, as a submodule of yosys itself.

Submitting issues upstream is kind of useless in this case: as you may
see from their ci actions pipelines, they=E2=80=99re using completely diffe=
rent
(precompiled) binaries (from their cad suite), even using verific
proprietary plugins. Guix departs from this logic.

Let=E2=80=99s keep things as they are, while I explore more in detail the e=
ffect of
using different abc versions in our packages.

C.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaAtX8xccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgmHjAP9pKNkhEkS8vU8CUTs7C53vxjFS
OjNsTP7RP8blbpfa9QEAvJp1rysDxEeCeRWYCo7Ox9T7Pcpp3CAVVC7l8dFGewA=
=AUwJ
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 12:59:02 +0000
Resent-Message-ID: <handler.78016.B78016.17455859357093 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78016
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 78016 <at> debbugs.gnu.org
Cc: maxim.cournoyer@HIDDEN, ekaitz@HIDDEN, csantosb@HIDDEN
X-Debbugs-Original-To: guix-patches@HIDDEN
X-Debbugs-Original-Cc: maxim.cournoyer@HIDDEN, 78016 <at> debbugs.gnu.org, ekaitz@HIDDEN, csantosb@HIDDEN
Received: via spool by 78016-submit <at> debbugs.gnu.org id=B78016.17455859357093
          (code B ref 78016); Fri, 25 Apr 2025 12:59:02 +0000
Received: (at 78016) by debbugs.gnu.org; 25 Apr 2025 12:58:55 +0000
Received: from localhost ([127.0.0.1]:48745 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8Idq-0001qL-MC
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:58:54 -0400
Received: from devianza.investici.org ([198.167.222.108]:33645)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>)
 id 1u8Idn-0001q6-OX
 for 78016 <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:58:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org;
 s=stigmate; t=1745585929;
 bh=oTcUrfJpJ0RPtTrUrmhprS2+plfolEdeOVxO7y6fkgA=;
 h=From:To:Cc:Subject:In-Reply-To:Date:From;
 b=P2Qz5TPTQkET1hJ2hWUPYIjPW7FZxFMTOjEjUmWnsDmUbYOG9wHcFv+UjKtNmL/S7
 epMHKAwm/t9tA0bxC1mRLH6SULk1R1LrrnmC5JHrpEYVBdi6RkyPwi+Pt04T/L/fVd
 yhJ4UyIllNX0IBmcbvRxRUVOLIQlStwW5e7x2WEY=
Received: from mx2.investici.org (unknown [127.0.0.1])
 by devianza.investici.org (Postfix) with ESMTP id 4ZkXw96NvNz6vP9;
 Fri, 25 Apr 2025 12:58:49 +0000 (UTC)
Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108])
 (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix)
 with ESMTPSA id 4ZkXw93DYZz6vLY; 
 Fri, 25 Apr 2025 12:58:49 +0000 (UTC)
From: Cayetano Santos <csantosb@HIDDEN>
In-Reply-To: <877c38shsc.fsf@HIDDEN>
User-Agent: mu4e 1.12.9; emacs 29.4
Date: Fri, 25 Apr 2025 14:58:48 +0200
Message-ID: <87h62cqtx3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain


Ok, the problem is understood.

#78059 is to be used by yosys, which will fix the testing problems with symbiyosys.

We need then to use abc fork by yosyshq with all of their packages.

C.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaAuHCBccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mghcBAP9WhmghapMm0JXUregb6j0Qmlzy
zNQ8jb/B1E2eDy0nHgEArRqV9G2Axoew/fmFmRe4fqk0ggViTSwnpbFrm2T8xwI=
=Gh/A
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 13:00:02 +0000
Resent-Message-ID: <handler.78016.B.17455859457147 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78016
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 78016 <at> debbugs.gnu.org
Cc: maxim.cournoyer@HIDDEN, ekaitz@HIDDEN, csantosb@HIDDEN
X-Debbugs-Original-To: guix-patches@HIDDEN
X-Debbugs-Original-Cc: maxim.cournoyer@HIDDEN, 78016 <at> debbugs.gnu.org, ekaitz@HIDDEN, csantosb@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.17455859457147
          (code B ref -1); Fri, 25 Apr 2025 13:00:02 +0000
Received: (at submit) by debbugs.gnu.org; 25 Apr 2025 12:59:05 +0000
Received: from localhost ([127.0.0.1]:48749 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8Ie1-0001rB-41
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:59:05 -0400
Received: from lists.gnu.org ([2001:470:142::17]:40768)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>)
 id 1u8Idy-0001qU-UH
 for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:59:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>)
 id 1u8Idr-00036H-6d
 for guix-patches@HIDDEN; Fri, 25 Apr 2025 08:58:55 -0400
Received: from devianza.investici.org ([198.167.222.108])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <csantosb@HIDDEN>)
 id 1u8Idp-0008DM-Bb
 for guix-patches@HIDDEN; Fri, 25 Apr 2025 08:58:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org;
 s=stigmate; t=1745585929;
 bh=oTcUrfJpJ0RPtTrUrmhprS2+plfolEdeOVxO7y6fkgA=;
 h=From:To:Cc:Subject:In-Reply-To:Date:From;
 b=P2Qz5TPTQkET1hJ2hWUPYIjPW7FZxFMTOjEjUmWnsDmUbYOG9wHcFv+UjKtNmL/S7
 epMHKAwm/t9tA0bxC1mRLH6SULk1R1LrrnmC5JHrpEYVBdi6RkyPwi+Pt04T/L/fVd
 yhJ4UyIllNX0IBmcbvRxRUVOLIQlStwW5e7x2WEY=
Received: from mx2.investici.org (unknown [127.0.0.1])
 by devianza.investici.org (Postfix) with ESMTP id 4ZkXw96NvNz6vP9;
 Fri, 25 Apr 2025 12:58:49 +0000 (UTC)
Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108])
 (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix)
 with ESMTPSA id 4ZkXw93DYZz6vLY; 
 Fri, 25 Apr 2025 12:58:49 +0000 (UTC)
From: Cayetano Santos <csantosb@HIDDEN>
In-Reply-To: <877c38shsc.fsf@HIDDEN>
User-Agent: mu4e 1.12.9; emacs 29.4
Date: Fri, 25 Apr 2025 14:58:48 +0200
Message-ID: <87h62cqtx3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=198.167.222.108;
 envelope-from=csantosb@HIDDEN; helo=devianza.investici.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain


Ok, the problem is understood.

#78059 is to be used by yosys, which will fix the testing problems with symbiyosys.

We need then to use abc fork by yosyshq with all of their packages.

C.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaAuHCBccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mghcBAP9WhmghapMm0JXUregb6j0Qmlzy
zNQ8jb/B1E2eDy0nHgEArRqV9G2Axoew/fmFmRe4fqk0ggViTSwnpbFrm2T8xwI=
=Gh/A
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 26 Apr 2025 13:04:02 +0000
Resent-Message-ID: <handler.78016.B78016.174567258317784 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78016
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cayetano Santos <csantosb@HIDDEN>
Cc: GNU Debbugs <control <at> debbugs.gnu.org>, 78016 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
Received: via spool by 78016-submit <at> debbugs.gnu.org id=B78016.174567258317784
          (code B ref 78016); Sat, 26 Apr 2025 13:04:02 +0000
Received: (at 78016) by debbugs.gnu.org; 26 Apr 2025 13:03:03 +0000
Received: from localhost ([127.0.0.1]:59339 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8fBP-0004ce-95
	for submit <at> debbugs.gnu.org; Sat, 26 Apr 2025 09:03:03 -0400
Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:42221)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1u8fBL-0004bg-DU; Sat, 26 Apr 2025 09:03:00 -0400
Received: by mail-pf1-x42c.google.com with SMTP id
 d2e1a72fcca58-7399838db7fso3339304b3a.0; 
 Sat, 26 Apr 2025 06:02:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745672572; x=1746277372; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=pOhXTAbQLaz4ns4ZKaGg2wPYNIfiQG8cPZ2+08Ssj30=;
 b=CHP4it920OFRgcW4F/B/vs4RKngAsql4rqVdhSQEgcghOGwq8aQj1dQAiowekHiOGp
 GwyTzx5w/AdmrHIR/1993Fw9e1S9cYGmgE1aGI5rU0PuayXWk0V5ijXmUecwdXdRLsye
 nNnIXlIQ/fHp1mErG3XDnhLzHXgD6onJ3KcDKnaE4okvWjM60hwWCSrQV0D92kBBosve
 0/G5DB1bRdEE/ULdnixG6eJ50/5u12DCCaRyBSF1+lWAgWRD8gwBQPq+ihOlIwLDz5jx
 2Dy9hq253XIu4DtV88Gd6VXa8Ima6jKnmynDorXIuiv/SNUzHliEueSf1wpgPkmJFUhx
 FbRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745672572; x=1746277372;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=pOhXTAbQLaz4ns4ZKaGg2wPYNIfiQG8cPZ2+08Ssj30=;
 b=nZDp9dWPBx674f4LzjoqsEBnx3Lo7tEkgVgeXTgfXoKuJik7FYAb46ulGrKeH6kqyH
 HLq7KnK7YWfAE7dJRqeKVI0GXAjGUTnJXpTOKeYJ2mPJ50PTUbk4Bs8w3EmM5CZLntkS
 +urGOJpXOVyjyAXxKyju+ButOTpScnHclE5BHYC/WCMfwgc6p3P92bqcwCZ0lepSXUAz
 ZBVYFDYajTJYQrD1IAydsBHhVQi7/ArIsYSQQfl5c5TwdgrL1FYCC48TzzXFgsq6uI0D
 Osd02gCWxJ+Q2q3j4ejrbsDLf9DByfXQAX+J5XS/K1mSNmnvYqdmb1+IYb2zwzMlCY6b
 9kdg==
X-Forwarded-Encrypted: i=1;
 AJvYcCUFCbOmVswzs+9kxETgfu2cg9Y4wwv4tgEvc44IY6kfJ6A/rIyObsaXVLKtj+sW8Ua0QhxosiL+@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzsC+HBNx8RZ6tfDSsqWGPcE6FVNOHLwmURj1K2c1j6EZyde+u2
 2i6FH6BAldVzsnvMWnjRgESp7zXPsdQlbv/W5eQ73We2WRwq5F2nUEvMIQ==
X-Gm-Gg: ASbGncuXbopV73Mjf1Oi1fb6vqt56dRnxeKMH9KIwhkTZsPPZMr2iL5YK+BIotn0AuU
 wG4vn5r/1T64Iy1jGgVbn+jDYpZfKdq7vZLkFy8nj1fVcpR1huRIwHNWn3JP/+76zPT2AsoXopB
 bQgDWVD4O8NnFeumw0qUvGbYYh7hg0RK7QgMOMjrT2lIDMO3awCGm1iOz5/S5iYjEsoRxR3s0g9
 bbCTEZil3nG4pqDnfLoZwQ+amo6SCLuqtUZC5snexbnz0ofip+t5Y8QrHh1rt9yFePmbO6f/sJr
 2DBwKNRW3/X2kjjGqhCt+rLq2aMgeu170kx3B29+nwcABvZeXg==
X-Google-Smtp-Source: AGHT+IFaahRXvwRkr9Z1nxRmiIIi6QhU5pkkv1TQKPj8374XjazRhn0JdipQBXXzdBa/Wlf8xECbsA==
X-Received: by 2002:a05:6a00:2f53:b0:732:706c:c4ff with SMTP id
 d2e1a72fcca58-73e2689e456mr11636956b3a.7.1745672572424; 
 Sat, 26 Apr 2025 06:02:52 -0700 (PDT)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-73e25a6aa52sm4950383b3a.94.2025.04.26.06.02.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 26 Apr 2025 06:02:51 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <877c38shsc.fsf@HIDDEN> (Cayetano Santos's message of
 "Fri, 25 Apr 2025 11:37:55 +0200")
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
 <874iycsp43.fsf@HIDDEN> <877c38shsc.fsf@HIDDEN>
Date: Sat, 26 Apr 2025 22:02:49 +0900
Message-ID: <87wmb7cbye.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tag 78016 + moreinfo
quit

Hi!

Cayetano Santos <csantosb@HIDDEN> writes:

>>ven. 25 avril 2025 at 15:59, Maxim Cournoyer <maxim.cournoyer@HIDDEN> =
wrote:
>
> Thanks for the review, I have included all of your comments in v2.
>
>>> +                   ;; remove tests which fail
>>
>> Please use complete sentences for standalone comments [0].  Also try to
>> explain the failures.  When they cannot be explained it's best to report
>> them to the upstream project and keep a reference to the opened issue so
>> that resolution can be tracked.
>
> The failures come from the fact that yosys uses a version of abc which
> differs from the one we package, as a submodule of yosys itself.

> Submitting issues upstream is kind of useless in this case: as you may
> see from their ci actions pipelines, they=E2=80=99re using completely dif=
ferent
> (precompiled) binaries (from their cad suite), even using verific
> proprietary plugins. Guix departs from this logic.
>
> Let=E2=80=99s keep things as they are, while I explore more in detail the=
 effect of
> using different abc versions in our packages.

Okay, thanks for the explanation.  I've looked at this a bit more
closely, and it seems this is a Python application (I previously assumed
only the tests relied on Python, since everything was added to the
native inputs).

Since this is a python application *and* a command, then all
python/libraries the application uses should be moved to the 'inputs'
field of the package, and the bin/sby command should be wrapped using
the same wrapper used in the python-build-system.  The best way to do
that is to import the python-build-system into this build with a prefix
and use its phase.

See the definition of the 'grass' package for an example of such fusion
of gnu-build-system + python-build-system.

--=20
Thanks,
Maxim

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 26 Apr 2025 13:03:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 26 09:03:03 2025
Received: from localhost ([127.0.0.1]:59337 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8fBO-0004cc-Hr
	for submit <at> debbugs.gnu.org; Sat, 26 Apr 2025 09:03:03 -0400
Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:42221)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1u8fBL-0004bg-DU; Sat, 26 Apr 2025 09:03:00 -0400
Received: by mail-pf1-x42c.google.com with SMTP id
 d2e1a72fcca58-7399838db7fso3339304b3a.0; 
 Sat, 26 Apr 2025 06:02:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745672572; x=1746277372; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=pOhXTAbQLaz4ns4ZKaGg2wPYNIfiQG8cPZ2+08Ssj30=;
 b=CHP4it920OFRgcW4F/B/vs4RKngAsql4rqVdhSQEgcghOGwq8aQj1dQAiowekHiOGp
 GwyTzx5w/AdmrHIR/1993Fw9e1S9cYGmgE1aGI5rU0PuayXWk0V5ijXmUecwdXdRLsye
 nNnIXlIQ/fHp1mErG3XDnhLzHXgD6onJ3KcDKnaE4okvWjM60hwWCSrQV0D92kBBosve
 0/G5DB1bRdEE/ULdnixG6eJ50/5u12DCCaRyBSF1+lWAgWRD8gwBQPq+ihOlIwLDz5jx
 2Dy9hq253XIu4DtV88Gd6VXa8Ima6jKnmynDorXIuiv/SNUzHliEueSf1wpgPkmJFUhx
 FbRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745672572; x=1746277372;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=pOhXTAbQLaz4ns4ZKaGg2wPYNIfiQG8cPZ2+08Ssj30=;
 b=nZDp9dWPBx674f4LzjoqsEBnx3Lo7tEkgVgeXTgfXoKuJik7FYAb46ulGrKeH6kqyH
 HLq7KnK7YWfAE7dJRqeKVI0GXAjGUTnJXpTOKeYJ2mPJ50PTUbk4Bs8w3EmM5CZLntkS
 +urGOJpXOVyjyAXxKyju+ButOTpScnHclE5BHYC/WCMfwgc6p3P92bqcwCZ0lepSXUAz
 ZBVYFDYajTJYQrD1IAydsBHhVQi7/ArIsYSQQfl5c5TwdgrL1FYCC48TzzXFgsq6uI0D
 Osd02gCWxJ+Q2q3j4ejrbsDLf9DByfXQAX+J5XS/K1mSNmnvYqdmb1+IYb2zwzMlCY6b
 9kdg==
X-Forwarded-Encrypted: i=1;
 AJvYcCUFCbOmVswzs+9kxETgfu2cg9Y4wwv4tgEvc44IY6kfJ6A/rIyObsaXVLKtj+sW8Ua0QhxosiL+@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzsC+HBNx8RZ6tfDSsqWGPcE6FVNOHLwmURj1K2c1j6EZyde+u2
 2i6FH6BAldVzsnvMWnjRgESp7zXPsdQlbv/W5eQ73We2WRwq5F2nUEvMIQ==
X-Gm-Gg: ASbGncuXbopV73Mjf1Oi1fb6vqt56dRnxeKMH9KIwhkTZsPPZMr2iL5YK+BIotn0AuU
 wG4vn5r/1T64Iy1jGgVbn+jDYpZfKdq7vZLkFy8nj1fVcpR1huRIwHNWn3JP/+76zPT2AsoXopB
 bQgDWVD4O8NnFeumw0qUvGbYYh7hg0RK7QgMOMjrT2lIDMO3awCGm1iOz5/S5iYjEsoRxR3s0g9
 bbCTEZil3nG4pqDnfLoZwQ+amo6SCLuqtUZC5snexbnz0ofip+t5Y8QrHh1rt9yFePmbO6f/sJr
 2DBwKNRW3/X2kjjGqhCt+rLq2aMgeu170kx3B29+nwcABvZeXg==
X-Google-Smtp-Source: AGHT+IFaahRXvwRkr9Z1nxRmiIIi6QhU5pkkv1TQKPj8374XjazRhn0JdipQBXXzdBa/Wlf8xECbsA==
X-Received: by 2002:a05:6a00:2f53:b0:732:706c:c4ff with SMTP id
 d2e1a72fcca58-73e2689e456mr11636956b3a.7.1745672572424; 
 Sat, 26 Apr 2025 06:02:52 -0700 (PDT)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-73e25a6aa52sm4950383b3a.94.2025.04.26.06.02.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 26 Apr 2025 06:02:51 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Cayetano Santos <csantosb@HIDDEN>
Subject: Re: [bug#78016] [PATCH electronics-team] gnu: Add symbiyosys.
In-Reply-To: <877c38shsc.fsf@HIDDEN> (Cayetano Santos's message of
 "Fri, 25 Apr 2025 11:37:55 +0200")
References: <99dcdda869f525e044ff37098fb0ef95466c9389.1745422491.git.csantosb@HIDDEN>
 <874iycsp43.fsf@HIDDEN> <877c38shsc.fsf@HIDDEN>
Date: Sat, 26 Apr 2025 22:02:49 +0900
Message-ID: <87wmb7cbye.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: GNU Debbugs <control <at> debbugs.gnu.org>, 78016 <at> debbugs.gnu.org,
 Ekaitz Zarraga <ekaitz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tag 78016 + moreinfo
quit

Hi!

Cayetano Santos <csantosb@HIDDEN> writes:

>>ven. 25 avril 2025 at 15:59, Maxim Cournoyer <maxim.cournoyer@HIDDEN> =
wrote:
>
> Thanks for the review, I have included all of your comments in v2.
>
>>> +                   ;; remove tests which fail
>>
>> Please use complete sentences for standalone comments [0].  Also try to
>> explain the failures.  When they cannot be explained it's best to report
>> them to the upstream project and keep a reference to the opened issue so
>> that resolution can be tracked.
>
> The failures come from the fact that yosys uses a version of abc which
> differs from the one we package, as a submodule of yosys itself.

> Submitting issues upstream is kind of useless in this case: as you may
> see from their ci actions pipelines, they=E2=80=99re using completely dif=
ferent
> (precompiled) binaries (from their cad suite), even using verific
> proprietary plugins. Guix departs from this logic.
>
> Let=E2=80=99s keep things as they are, while I explore more in detail the=
 effect of
> using different abc versions in our packages.

Okay, thanks for the explanation.  I've looked at this a bit more
closely, and it seems this is a Python application (I previously assumed
only the tests relied on Python, since everything was added to the
native inputs).

Since this is a python application *and* a command, then all
python/libraries the application uses should be moved to the 'inputs'
field of the package, and the bin/sby command should be wrapped using
the same wrapper used in the python-build-system.  The best way to do
that is to import the python-build-system into this build with a prefix
and use its phase.

See the definition of the 'grass' package for an example of such fusion
of gnu-build-system + python-build-system.

--=20
Thanks,
Maxim

Last modified: Sat, 26 Apr 2025 13:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.