GNU logs - #78052, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#78052] [PATCH] gnu: ungoogled-chromium: Fix WebRTC.
Resent-From: Danny Milosavljevic <dannym@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Apr 2025 23:05:02 +0000
Resent-Message-ID: <handler.78052.B.174553589029443 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78052 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym@HIDDEN>
From: Danny Milosavljevic <dannym@HIDDEN>
Date: Fri, 25 Apr 2025 01:04:29 +0200
Message-ID: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=23.83.223.10;
 envelope-from=dannym@HIDDEN;
 helo=barb.cherry.relay.mailchannels.net
X-Spam_score_int: 12
X-Spam_score: 1.2
X-Spam_bar: +
X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 4.5 (++++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  * gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch:
 New file. * gnu/packages/chromium.scm (%guix-patches): Add reference to it.
 * gnu/local.mk (dist_patch_DATA): Add reference to it. Change-Id:
 I91b7c3243345f6f1eda71aa4ec68faf3ef4a98f4
 --- gnu/local.mk | 1 + gnu/packages/chromium.scm | 3 ++
 .../ungoogled-chromium-fcntl-fix.patch
 | 28 +++++++++++++++++++ 3 files changed, 32 inserti [...] 
 Content analysis details:   (4.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
 [84.115.226.251 listed in zen.spamhaus.org]
 0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
 id=dannym%40friendly-machines.com; ip=2001%3A470%3A142%3A%3A17;
 r=debbugs.gnu.org]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 3.5 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  * gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch:
    New file. * gnu/packages/chromium.scm (%guix-patches): Add reference to it.
    * gnu/local.mk (dist_patch_DATA): Add reference to it. Change-Id: I91b7c3243345f6f1eda71aa4ec68faf3ef4a98f4
    --- gnu/local.mk | 1 + gnu/packages/chromium.scm | 3 ++ .../ungoogled-chromium-fcntl-fix.patch
    | 28 +++++++++++++++++++ 3 files changed, 32 inserti [...] 
 
 Content analysis details:   (3.5 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [2001:470:142:0:0:0:0:17 listed in]
                             [list.dnswl.org]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [84.115.226.251 listed in zen.spamhaus.org]
  0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=dannym%40friendly-machines.com;ip=2001%3A470%3A142%3A%3A17;r=debbugs.gnu.org]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

* gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch: New file.
* gnu/packages/chromium.scm (%guix-patches): Add reference to it.
* gnu/local.mk (dist_patch_DATA): Add reference to it.

Change-Id: I91b7c3243345f6f1eda71aa4ec68faf3ef4a98f4
---
 gnu/local.mk                                  |  1 +
 gnu/packages/chromium.scm                     |  3 ++
 .../ungoogled-chromium-fcntl-fix.patch        | 28 +++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 62cfe230bb..582296e3c9 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -2344,6 +2344,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/uftrace-fix-tests.patch			\
   %D%/packages/patches/ultrastar-deluxe-no-freesans.patch		\
   %D%/packages/patches/ungoogled-chromium-extension-search-path.patch	\
+  %D%/packages/patches/ungoogled-chromium-fcntl-fix.patch	\
   %D%/packages/patches/ungoogled-chromium-ffmpeg-compat.patch	\
   %D%/packages/patches/ungoogled-chromium-RUNPATH.patch		\
   %D%/packages/patches/ungoogled-chromium-system-ffmpeg.patch	\
diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm
index 5da5f10da6..45fd719822 100644
--- a/gnu/packages/chromium.scm
+++ b/gnu/packages/chromium.scm
@@ -385,6 +385,9 @@ (define %guix-patches
   (list (local-file
          (assume-valid-file-name
           (search-patch "ungoogled-chromium-extension-search-path.patch")))
+        (local-file
+         (assume-valid-file-name
+          (search-patch "ungoogled-chromium-fcntl-fix.patch")))
         (local-file
          (assume-valid-file-name
           (search-patch "ungoogled-chromium-RUNPATH.patch")))
diff --git a/gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch b/gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch
new file mode 100644
index 0000000000..e9e8664b6f
--- /dev/null
+++ b/gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch
@@ -0,0 +1,28 @@
+From 7b0d7f48fbffb412f0c485f86ef33b0dea605d1d Mon Sep 17 00:00:00 2001
+From: Jan Grulich <grulja@HIDDEN>
+Date: Fri, 12 May 2023 20:59:06 +0200
+Subject: [PATCH] PipeWire capturer: fix fcntl call when duplicating a file descriptor
+
+The fcntl() call has variable arguments, therefore we need to pass 0 to
+specify there are no other arguments for this call, otherwise we might
+end up with an argument that is random garbage.
+
+Bug: webrtc:15174
+Change-Id: I34f16a942d80913b667d8ade7eed557b0233be01
+Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305120
+Reviewed-by: Alexander Cooper <alcooper@HIDDEN>
+Commit-Queue: Jan Grulich <grulja@HIDDEN>
+Cr-Commit-Position: refs/heads/main@{#40060}
+---
+
+--- ./third_party/webrtc/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc.orig	2024-11-18 21:48:23.280303055 +0100
++++ ./third_party/webrtc/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc	2024-11-18 21:48:24.860287444 +0100
+@@ -447,7 +447,7 @@
+ 
+     if (fd >= 0) {
+       pw_core_ = pw_context_connect_fd(
+-          pw_context_, fcntl(fd, F_DUPFD_CLOEXEC), nullptr, 0);
++          pw_context_, fcntl(fd, F_DUPFD_CLOEXEC, 0), nullptr, 0);
+     } else {
+       pw_core_ = pw_context_connect(pw_context_, nullptr, 0);
+     }

base-commit: a36ff7d51110403295a359e7f40c3eb42ccfd509
-- 
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: bug#78052: Acknowledgement ([PATCH] gnu: ungoogled-chromium: Fix
 WebRTC.)
Message-ID: <handler.78052.B.174553589029443.ack <at> debbugs.gnu.org>
References: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
X-Gnu-PR-Message: ack 78052
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 78052 <at> debbugs.gnu.org
Date: Thu, 24 Apr 2025 23:05:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 78052 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78052: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78052
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#78052] [PATCH] gnu: ungoogled-chromium: Fix WebRTC.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 29 Apr 2025 06:29:01 +0000
Resent-Message-ID: <handler.78052.B78052.174590812529165 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Danny Milosavljevic <dannym@HIDDEN>
Cc: 78052 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
 (Danny Milosavljevic's message of "Fri, 25 Apr 2025 01:04:29 +0200")
References: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
Date: Tue, 29 Apr 2025 15:28:30 +0900
Message-ID: <87o6wfbhwx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Danny,

Danny Milosavljevic <dannym@HIDDEN> writes:

> * gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch: New file.

Is this an upstream patch now included in recent releases?  Our
ungoogled-chromium package is probably ridden with many CVEs at this
point (it's poorly maintained).  If you use it, perhaps you could try
updating it?

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

Subject: [bug#78052] [PATCH] gnu: ungoogled-chromium: Fix WebRTC.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 29 Apr 2025 06:32:01 +0000
Resent-Message-ID: <handler.78052.B78052.17459082845973 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Danny Milosavljevic <dannym@HIDDEN>
Cc: guix-devel <guix-devel@HIDDEN>, 78052 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
 (Danny Milosavljevic's message of "Fri, 25 Apr 2025 01:04:29 +0200")
References: <dde8a839eb121b3ca7e17db5e00ea8c1d0544c40.1744895822.git.dannym@HIDDEN>
Date: Tue, 29 Apr 2025 15:31:11 +0900
Message-ID: <87jz73bhsg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Danny Milosavljevic <dannym@HIDDEN> writes:

> * gnu/packages/patches/ungoogled-chromium-fcntl-fix.patch: New file.
> * gnu/packages/chromium.scm (%guix-patches): Add reference to it.
> * gnu/local.mk (dist_patch_DATA): Add reference to it.

Ouch, the last time ungoogled-chromium was updated was in 2023.  That's
terrible for something is sensitive as a web browser that runs arbitrary
javascript by default.

If nobody champions an update, I'd suggest we remove the package.

What do people think? (+CC guix-devel).

-- 
Thanks,
Maxim

Last modified: Tue, 29 Apr 2025 06:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.