GNU bug report logs - #78059
[PATCH electronics-team] gnu: Add abc-yosyshq.

Previous Next

To reply to this bug, email your comments to 78059 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 25 Apr 2025 14:48:44 +0200

* gnu/packages/fpga.scm (abc-yosyshq): New variable.

https://github.com/YosysHQ/abc is a fork of berkeley abc, used by all
yosyshq projects (yosys, etc.).

Change-Id: I46649e3722ded3faf8c0993d7bebaf649e6297c6
---

There are (at least) two versions of abc:

- https://github.com/berkeley-abc/abc, from berkely, that we currently package
- https://github.com/YosysHQ/abc, a fork by yosyshq

Yosys and remaining yosyshq software we package uses the later, while we are using the former. This produces errors in tests. We need then to package yosyshq version so that we may use it with all of their packages.

 gnu/packages/fpga.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index e1043efc48..a98bca8578 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -156,6 +156,40 @@ (define-public iverilog
     ;; You have to accept both GPL2 and LGPL2.1+.
     (license (list license:gpl2 license:lgpl2.1+))))
 
+(define-public abc-yosyshq
+  (package
+    (name "abc-yosyshq")
+    (version "0.52")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/YosysHQ/abc/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15a7nyk8iqpadp326icnr7rn5pwq44b9lvajqc35hcsvixz4gxsa"))))
+    (build-system gnu-build-system)
+    (inputs
+     (list readline))
+    (arguments
+     (list
+      #:license-file-regexp "copyright.txt"
+      #:tests? #f ; no tests
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (replace 'install
+            (lambda _
+              (install-file "abc" (string-append #$output "/bin")))))))
+    (home-page "https://github.com/YosysHQ/abc/")
+    (synopsis "Sequential logic synthesis and formal verification")
+    (description "ABC is a program for sequential logic synthesis and
+formal verification.")
+    (license
+     (license:non-copyleft
+      "https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm"))))
+
 (define-public yosys
   (package
     (name "yosys")

base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52
--
2.49.0

Message #10 received at 78059-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78059-done <at> debbugs.gnu.org
Subject: Re: [bug#78059] [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 02 May 2025 16:03:05 +0900

Hi Cayetano,,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/fpga.scm (abc-yosyshq): New variable.
>
> https://github.com/YosysHQ/abc is a fork of berkeley abc, used by all
> yosyshq projects (yosys, etc.).

[...]

> +(define-public abc-yosyshq
> +  (package
> +    (name "abc-yosyshq")
> +    (version "0.52")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/YosysHQ/abc/")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "15a7nyk8iqpadp326icnr7rn5pwq44b9lvajqc35hcsvixz4gxsa"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     (list readline))
> +    (arguments
> +     (list
> +      #:license-file-regexp "copyright.txt"
> +      #:tests? #f ; no tests
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (delete 'configure)
> +          (replace 'install
> +            (lambda _
> +              (install-file "abc" (string-append #$output "/bin")))))))
> +    (home-page "https://github.com/YosysHQ/abc/")
> +    (synopsis "Sequential logic synthesis and formal verification")
> +    (description "ABC is a program for sequential logic synthesis and
> +formal verification.")
> +    (license
> +     (license:non-copyleft
> +      "https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm"))))

Since that's almost a 1:1 copy of the original definition, inheritance
is most appropriate:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/fpga.scm
@@ -118,6 +118,24 @@ (define-public abc
        (license:non-copyleft
         "https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm")))))
 
+(define-public abc-yosyshq
+  (package
+    (inherit abc)
+    (name "abc-yosyshq")
+    (version "0.52")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/YosysHQ/abc/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15a7nyk8iqpadp326icnr7rn5pwq44b9lvajqc35hcsvixz4gxsa"))))
+    (home-page "https://github.com/YosysHQ/abc/")
+    (description "ABC is a program for sequential logic synthesis and
+formal verification.  This is the Yosyshq fork of ABC.")))
+
 (define-public iverilog
   (package
     (name "iverilog")
@@ -158,40 +176,6 @@ (define-public iverilog
     ;; You have to accept both GPL2 and LGPL2.1+.
     (license (list license:gpl2 license:lgpl2.1+))))
 
-(define-public abc-yosyshq
-  (package
-    (name "abc-yosyshq")
-    (version "0.52")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/YosysHQ/abc/")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "15a7nyk8iqpadp326icnr7rn5pwq44b9lvajqc35hcsvixz4gxsa"))))
-    (build-system gnu-build-system)
-    (inputs
-     (list readline))
-    (arguments
-     (list
-      #:license-file-regexp "copyright.txt"
-      #:tests? #f ; no tests
-      #:phases
-      #~(modify-phases %standard-phases
-          (delete 'configure)
-          (replace 'install
-            (lambda _
-              (install-file "abc" (string-append #$output "/bin")))))))
-    (home-page "https://github.com/YosysHQ/abc/")
-    (synopsis "Sequential logic synthesis and formal verification")
-    (description "ABC is a program for sequential logic synthesis and
-formal verification.")
-    (license
-     (license:non-copyleft
-      "https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm"))))
-
 (define-public yosys
   (package
     (name "yosys")
--8<---------------cut here---------------end--------------->8---

Unfortunately, reading the README to see if I could expound the
description a bit with the fork's extra features, I read:

--8<---------------cut here---------------start------------->8--- The
source code is provided for research and evaluation only. For commercial
usage, please contact Prof. Chang Wu at wuchang <at> fudan.edu.cn.
--8<---------------cut here---------------end--------------->8---

So, sadly, it seems this fork is derived from another fork which
contains non-free additions... and that's a valid thing to do because of
the permissive license of the original work.

It sucks, but it looks like we won't be able to carry this in our
repository.  It should probably be reported to the yosys project, but it
seems the bug tracker is disabled on their github repo.  I'll let you do
it if you don't mind.

-- 
Thanks,
Maxim

Message #13 received at 78059-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78059-done <at> debbugs.gnu.org
Subject: Re: [bug#78059] [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 02 May 2025 10:40:38 +0200

[Message part 1 (text/plain, inline)]

>ven. 02 mai 2025 at 16:03, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> So, sadly, it seems this fork is derived from another fork which
> contains non-free additions... and that's a valid thing to do because of
> the permissive license of the original work.
>
> It sucks, but it looks like we won't be able to carry this in our
> repository.

Notice that we already package in Guix the original abc code from
Berkeley, also for research and evaluation only, see "gnu packages fpga"
module. And this is the abc used by yosys and yosys-clang, both in the
same module.

C.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 78059-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: ekaitz <at> elenq.tech, maxim.cournoyer <at> gmail.com, csantosb <at> inventati.org,
 78059-done <at> debbugs.gnu.org
Subject: Re: [bug#78059] [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 02 May 2025 12:13:03 +0200

[Message part 1 (text/plain, inline)]

Ok, so after asking people on YosysHq, we have this situation:

- berkeley-abc/abc :: original project; the one currently packaged in
  guix, licensed under:

    https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm

- YosysHQ/abc :: fork of the original; licensed under

    https://github.com/YosysHQ/abc/blob/yosys-experimental/copyright.txt

- yongshiwo/abc :: fork of the original, including new Agdmap; only in
  this case the "for research and evaluation only" applies

Current patch concerns YosysHQ/abc version above.

C.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 78059 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78059 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team v2] gnu: Add abc-yosyshq.
Date: Fri,  2 May 2025 12:27:03 +0200

* gnu/packages/fpga.scm (abc-yosyshq): New variable.

Change-Id: I46649e3722ded3faf8c0993d7bebaf649e6297c6
---
 gnu/packages/fpga.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index 4fcd6a47a6..b00ce4480a 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -118,6 +118,27 @@ (define-public abc
        (license:non-copyleft
         "https://people.eecs.berkeley.edu/~alanmi/abc/copyright.htm")))))
 
+(define-public abc-yosyshq
+  (package
+    (inherit abc)
+    (name "abc-yosyshq")
+    (version "0.52")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/YosysHQ/abc/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15a7nyk8iqpadp326icnr7rn5pwq44b9lvajqc35hcsvixz4gxsa"))))
+    (home-page "https://github.com/YosysHQ/abc/")
+    (description "ABC is a program for sequential logic synthesis and
+formal verification.  This is the Yosyshq fork of ABC.")
+    (license
+     (license:non-copyleft
+      "https://github.com/YosysHQ/abc/blob/yosys-experimental/copyright.txt"))))
+
 (define-public iverilog
   (package
     (name "iverilog")

base-commit: c8efb51982c3099a2a14b8412b2e258c522e94c5
prerequisite-patch-id: 211bd0d1a9e6b293f491eced9e4af9843bf3b287
prerequisite-patch-id: 9883bd0d0c6755d6c4e3e3187d89aa072b0b97af
prerequisite-patch-id: d1157e346fb2aabee7d7c169f44f4ab0bf005c4c
prerequisite-patch-id: 43fd2d4ade95aebf0723d0e5015efd26533617d3
prerequisite-patch-id: 5c4cee47c975c28c734dde626519abc41933b195
prerequisite-patch-id: b18bb968707bfadfe1ecc1487c89dfd436479aee
prerequisite-patch-id: e80367a498f5a20eb853973f611d2f69e5ebc5ee
prerequisite-patch-id: c5fd8e7f7f96c87ea0e3827faffa07fa71304728
prerequisite-patch-id: cfc02bc484870a43f2c804fa849abbc3f0512d50
prerequisite-patch-id: 2e03948dc975c98730ac3814ed5702acca7a6fdf
prerequisite-patch-id: 6cd3353026dafeb79460257c2e60703554a447c5
prerequisite-patch-id: 4111053abab6f41ebda2958d4d7d73ea16eb5283
prerequisite-patch-id: be434332d589b9075b1ac1367c3fd3aa98cf767e
prerequisite-patch-id: eb1ad1c2b4bc1ae02ca7a1d1c4935d5c8e7387db
prerequisite-patch-id: be03d391071cf7080a0bd0e306f5bca71171071b
prerequisite-patch-id: 4174704d944afa67dd97270c34eda6e9e3af8a2b
prerequisite-patch-id: 849103845d254fc50290a02e597e76977cc27bc9
prerequisite-patch-id: e34ea950e22895e60f0c6785a61a26c30f5b5b7c
prerequisite-patch-id: 2901b0d5cc3c44b1a2cac1b0389cc905f552ae73
prerequisite-patch-id: 61f4d2df2b695a9a7bca127e8abb406f87f6bcbd
prerequisite-patch-id: 1c0de8f100ef0d2b0c087cacf3e61d426d17355e
prerequisite-patch-id: c0f22ac952516dc9c92767c1b1362d2c7ecde0f8
prerequisite-patch-id: e945542c050b7792775e301930ee4aca13f19ef5
prerequisite-patch-id: dd90058fdafed0cfabe398f2f4685a9c06f48102
prerequisite-patch-id: 55c89258f5b3aab45902904aab1198994012c546
prerequisite-patch-id: 6bae0c4b7d121accaf1b772fc8eef9011f6290cc
prerequisite-patch-id: d8993f4ad264e89c3e3c8417b309798382532bec
prerequisite-patch-id: 13e40673865c0f57e5b8be99047166ed82250e3f
prerequisite-patch-id: 38c9ea11080cc107addf8eb43fed800fec7e650c
prerequisite-patch-id: 43d07afd567e55d35643c2a59bfd27a88c5b8c33
prerequisite-patch-id: 3a87236411d1231ff88579e2049db124dfb13fbc
prerequisite-patch-id: 0d323a6fdd6b3f4d7ff54eeb161d8d1aec5c3095
--
2.49.0

Message #25 received at 78059-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78059-done <at> debbugs.gnu.org
Subject: Re: [bug#78059] [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 02 May 2025 21:48:55 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

>>ven. 02 mai 2025 at 16:03, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> So, sadly, it seems this fork is derived from another fork which
>> contains non-free additions... and that's a valid thing to do because of
>> the permissive license of the original work.
>>
>> It sucks, but it looks like we won't be able to carry this in our
>> repository.
>
> Notice that we already package in Guix the original abc code from
> Berkeley, also for research and evaluation only, see "gnu packages fpga"
> module. And this is the abc used by yosys and yosys-clang, both in the
> same module.

Thanks for pointing this; I thought that wording was something new
introduced in a fork, but you are correct, it's been there all along.
I've done due diligence, and found that Debian carries the same
source/package as part of their 'yosys' source package [0], and it had
been added in 2015 in the Free Software Directory [1]

I've now pushed a reworked version in 64ab31870c6.  Curiously, the test
suite of symbiyosys still fails if I comment out the phase disabling the
problematic tests.  Could you take a look?

[0]  https://metadata.ftp-master.debian.org/changelogs//main/y/yosys/yosys_0.52-1_copyright
[1]  https://directory.fsf.org/wiki/ABC#tab=Details

-- 
Thanks,
Maxim

Message #28 received at 78059-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78059-done <at> debbugs.gnu.org
Subject: Re: [bug#78059] [PATCH electronics-team] gnu: Add abc-yosyshq.
Date: Fri, 02 May 2025 16:31:16 +0200

[Message part 1 (text/plain, inline)]

>ven. 02 mai 2025 at 21:48, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> I've now pushed a reworked version in 64ab31870c6.  Curiously, the test
> suite of symbiyosys still fails if I comment out the phase disabling the
> problematic tests.  Could you take a look?

Sure. We first need to fix Yosys itself, see #78214; then, we’ll proceed
similarly with Symbiyosys.

C.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.