GNU bug report logs - #78069
[PATCH 0/1] libsecret: Add bin output.

Previous Next

To reply to this bug, email your comments to 78069 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH 0/1] libsecret: Add bin output.
Date: Fri, 25 Apr 2025 20:59:11 -0300

Greetings,

After reading a Reddit post[1], I discovered that I could easily integrate
KeePassXC with msmtp and potentially other command-line tools by using its
Secret Service integration.

This requires the use of the secret-tool command, from the libsecret package.
Since I only need the command, installing the whole package seems a bit
too much.

To solve this, this patch creates a new "bin" output for libsecret. The only
thing missing is the man page, not sure how I would go about adding it to the
output. Please let me know and I'll send a v2.

[1] <https://redlib.freedit.eu/r/linux/comments/ehfhud/keyring_alternative_access_keepassxc_entries_of/>

Gabriel Santos (1):
  gnu: libsecret: Add bin output.

 gnu/packages/gnome.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


base-commit: 7ff20b9e94c429f1160bd8f0db86b153a03e4683
-- 
2.49.0

Message #8 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: 78069 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH 1/1] gnu: libsecret: Add bin output.
Date: Fri, 25 Apr 2025 21:05:23 -0300

* gnu/packages/gnome.scm (libsecret): Add "bin" output.

Change-Id: I4f07c0f040b980b557c72d299fb02e8ccb2cb521
---
 gnu/packages/gnome.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 34162d5138..37a5b1745e 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5355,10 +5355,13 @@ (define-public libsecret
                (base32
                 "081bj59ws08kb261cd1w1mkdkhfbzsjbbkkrm6wllvdyhgbhhg8n"))))
     (build-system meson-build-system)
+    (outputs '("out" "bin"))
     (arguments
      (list
       #:configure-flags
-      #~(list "-Dgtk_doc=false")        ;requires gi-docgen
+      #~(list "-Dgtk_doc=false" ;requires gi-docgen
+              (string-append "--bindir="
+                             #$output:bin "/bin"))
       #:phases
       #~(modify-phases %standard-phases
           (delete 'check)
@@ -5367,7 +5370,7 @@ (define-public libsecret
               (when tests?
                 (setenv "HOME" "/tmp")
                 (setenv "XDG_DATA_DIRS" ;for /org/freedesktop/secrets/collection
-                        (string-append #$output "/share:"
+                        (string-append #$output:out "/share:"
                                        (getenv "XDG_DATA_DIRS")))
                 (apply invoke "dbus-run-session" "--"
                        "meson" "test" "--print-errorlogs" "-t" "0"

base-commit: 7ff20b9e94c429f1160bd8f0db86b153a03e4683
-- 
2.49.0

Message #11 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: 78069 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: Re: [PATCH 0/1] libsecret: Add bin output.
Date: Sat, 26 Apr 2025 08:45:58 -0300

> The only thing missing is the man page, not sure how I would go about
> adding it to the output.

Nevermind, I figured it out. Sending a v2 soon.

Message #14 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: 78069 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH v2 1/1] gnu: libsecret: Add bin output.
Date: Sat, 26 Apr 2025 08:49:09 -0300

* gnu/packages/gnome.scm (libsecret): Add "bin" output.
[phases] add "install-man-to-bin" phase to install the compressed documentation
to the new output.

Change-Id: I4f07c0f040b980b557c72d299fb02e8ccb2cb521
---
 gnu/packages/gnome.scm | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 34162d5138..3f12052079 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5355,10 +5355,13 @@ (define-public libsecret
                (base32
                 "081bj59ws08kb261cd1w1mkdkhfbzsjbbkkrm6wllvdyhgbhhg8n"))))
     (build-system meson-build-system)
+    (outputs '("out" "bin"))
     (arguments
      (list
       #:configure-flags
-      #~(list "-Dgtk_doc=false")        ;requires gi-docgen
+      #~(list "-Dgtk_doc=false" ;requires gi-docgen
+              (string-append "--bindir="
+                             #$output:bin "/bin"))
       #:phases
       #~(modify-phases %standard-phases
           (delete 'check)
@@ -5367,11 +5370,19 @@ (define-public libsecret
               (when tests?
                 (setenv "HOME" "/tmp")
                 (setenv "XDG_DATA_DIRS" ;for /org/freedesktop/secrets/collection
-                        (string-append #$output "/share:"
+                        (string-append #$output:out "/share:"
                                        (getenv "XDG_DATA_DIRS")))
                 (apply invoke "dbus-run-session" "--"
                        "meson" "test" "--print-errorlogs" "-t" "0"
-                       test-options)))))))
+                       test-options))))
+          (add-after 'compress-documentation 'install-man-to-bin
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((out (assoc-ref outputs "out"))
+                    (bin (assoc-ref outputs "bin"))
+                    (man "/share/man/man1"))
+                (mkdir-p (string-append bin man))
+                (copy-file (string-append out man "/secret-tool.1.zst")
+                           (string-append bin man "/secret-tool.1.zst"))))))))
     (native-inputs
      (list dbus
            docbook-xml-4.2

base-commit: 7ff20b9e94c429f1160bd8f0db86b153a03e4683
-- 
2.49.0

Message #17 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: 78069 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH v3 0/1] gnu: libsecret: Add bin output.
Date: Sun, 27 Apr 2025 15:41:43 -0300

v3 because I forgot to add the copyright header.

Gabriel Santos (1):
  gnu: libsecret: Add bin output.

 gnu/packages/gnome.scm | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)


base-commit: 7e5913f90df916d8d9f5c509354d62324f54f481
-- 
2.49.0

Message #20 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: 78069 <at> debbugs.gnu.org
Cc: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Subject: [PATCH v3 1/1] gnu: libsecret: Add bin output.
Date: Sun, 27 Apr 2025 15:41:44 -0300

* gnu/packages/gnome.scm (libsecret): Add "bin" output.

Change-Id: I4f07c0f040b980b557c72d299fb02e8ccb2cb521
---
 gnu/packages/gnome.scm | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 26416df155..a79a8d841f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -82,6 +82,7 @@
 ;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
 ;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
 ;;; Copyright © 2025 Ashvith Shetty <ashvithshetty0010 <at> zohomail.in>
+;;; Copyright © 2025 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5350,10 +5351,13 @@ (define-public libsecret
                (base32
                 "081bj59ws08kb261cd1w1mkdkhfbzsjbbkkrm6wllvdyhgbhhg8n"))))
     (build-system meson-build-system)
+    (outputs '("out" "bin"))
     (arguments
      (list
       #:configure-flags
-      #~(list "-Dgtk_doc=false")        ;requires gi-docgen
+      #~(list "-Dgtk_doc=false" ;requires gi-docgen
+              (string-append "--bindir="
+                             #$output:bin "/bin"))
       #:phases
       #~(modify-phases %standard-phases
           (delete 'check)
@@ -5362,11 +5366,19 @@ (define-public libsecret
               (when tests?
                 (setenv "HOME" "/tmp")
                 (setenv "XDG_DATA_DIRS" ;for /org/freedesktop/secrets/collection
-                        (string-append #$output "/share:"
+                        (string-append #$output:out "/share:"
                                        (getenv "XDG_DATA_DIRS")))
                 (apply invoke "dbus-run-session" "--"
                        "meson" "test" "--print-errorlogs" "-t" "0"
-                       test-options)))))))
+                       test-options))))
+          (add-after 'compress-documentation 'install-man-to-bin
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((out (assoc-ref outputs "out"))
+                    (bin (assoc-ref outputs "bin"))
+                    (man "/share/man/man1"))
+                (mkdir-p (string-append bin man))
+                (copy-file (string-append out man "/secret-tool.1.zst")
+                           (string-append bin man "/secret-tool.1.zst"))))))))
     (native-inputs
      (list dbus
            docbook-xml-4.2
-- 
2.49.0

Message #23 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: Noé Lopez <noelopez <at> free.fr>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 78069 <at> debbugs.gnu.org
Subject: Re: [bug#78069] [PATCH 0/1] libsecret: Add bin output.
Date: Tue, 29 Apr 2025 09:50:16 +0900

Hi Gabriel,

Gabriel Santos <gabrielsantosdesouza <at> disroot.org> writes:

> Greetings,
>
> After reading a Reddit post[1], I discovered that I could easily integrate
> KeePassXC with msmtp and potentially other command-line tools by using its
> Secret Service integration.
>
> This requires the use of the secret-tool command, from the libsecret package.
> Since I only need the command, installing the whole package seems a bit
> too much.
>
> To solve this, this patch creates a new "bin" output for libsecret. The only
> thing missing is the man page, not sure how I would go about adding it to the
> output. Please let me know and I'll send a v2.

I'm not sure if that is worth it; you'd save about 5 megabytes on the
closure of keepassxc, which stands at 1795 MiB according to 'guix size
keepassxc', e.g.:

--8<---------------cut here---------------start------------->8---
$ guix size keepassxc | grep total
total : 1795.7 Mio

$ guix size keepassxc libsecret | grep total
total : 1800.9 Mio
--8<---------------cut here---------------end--------------->8---

On top of potentially surprising users that are used to use 'libsecret'
for the secret-tool command without a bin output, I think you'd need to
also copy the locale data (translated strings for localization) of the
package to the bin output, or keep it in both places.

I personally don't see the value (when compared to the cost), so I think
I'd prefer to keep things as is.  What do you all think?

-- 
Thanks,
Maxim

Message #26 received at 78069 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Noé Lopez <noelopez <at> free.fr>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 78069 <at> debbugs.gnu.org
Subject: Re: [bug#78069] [PATCH 0/1] libsecret: Add bin output.
Date: Mon, 28 Apr 2025 23:01:02 -0300

>I'm not sure if that is worth it; you'd save about 5 megabytes on the
>closure of keepassxc, [...]

Oh, I didn't do it for space reasons, it's just that the thought of
"there's a whole library in my profile when I only what the binary" keeps
annoying me, it's just kind of a nitpick. I wanted my profile to have
as little development-related software as possible (I don't even have
GCC installed) so I could keep this information at the project
level.

>On top of potentially surprising users that are used to use 'libsecret'
>for the secret-tool command without a bin output, [...]

Instead of replacing the binary directory like I did, maybe I could
just copy all the necessary files instead?

>I think you'd need to
>also copy the locale data (translated strings for localization) of the
>package to the bin output, or keep it in both places.

Thanks, I'll also add these to the output.

>I personally don't see the value (when compared to the cost), so I think
>I'd prefer to keep things as is.  What do you all think?

Interested in other's opinion too. I'll wait before sending another
version.

-- 
Gabriel Santos

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.