GNU bug report logs - #78118
[PATCH] ; Isearch: Fix key bindings in documentation string

Previous Next

To reply to this bug, email your comments to 78118 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jake Forster <jakecameron.forster <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Isearch: Fix key bindings in documentation string
Date: Mon, 28 Apr 2025 13:31:55 +0000

[Message part 1 (text/plain, inline)]

Hello

The documentation string for `isearch-allow-motion' describes commands to
be invoked during Isearch, but the key bindings shown are for the
help-key-map, not for the isearch-mode-map.  This patch specifies the
keymap to fix the key bindings.

Kind regards
Jake


In GNU Emacs 30.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: Guix System

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/m0xdsa8cfq6mq1kxgxmpmpg71la4f0b9-bash-minimal-5.1.16/bin/bash
 SHELL=/gnu/store/m0xdsa8cfq6mq1kxgxmpmpg71la4f0b9-bash-minimal-5.1.16/bin/bash
 --prefix=/gnu/store/rk4ayiybm76qz0g96v3wa5xkmzfayryg-emacs-next-30.0.92-0.881d593
 --enable-fast-install --with-cairo --with-modules
 --with-native-compilation=aot --disable-build-details'

<#part type="text/patch"
filename="~/emacs-local/0001-Isearch-Fix-key-bindings-in-documentaion-string.patch"
disposition=attachment>
<#/part>

[Message part 2 (text/html, inline)]

[0001-Isearch-Fix-key-bindings-in-documentaion-string.patch (text/x-patch, attachment)]

Message #8 received at 78118 <at> debbugs.gnu.org (full text, mbox):

From: Jake Forster <jakecameron.forster <at> gmail.com>
To: 78118 <at> debbugs.gnu.org
Subject: Re: bug#78118: [PATCH] ;
 Isearch: Fix key bindings in documentation string
Date: Mon, 28 Apr 2025 14:31:57 +0000

[Message part 1 (text/plain, inline)]

I found another occurrence of this docstring bug in
`isearch-motion-changes-direction'.  I also had to fix the displayed
filling in my patch.
Please disregard the previous patch and see the attached v2 one instead.
Sorry for the noise.

Jake

[Message part 2 (text/html, inline)]

[0001-Isearch-Fix-key-bindings-in-documentaion-string-v2.patch (text/x-patch, attachment)]

Message #13 received at 78118-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Jake Forster <jakecameron.forster <at> gmail.com>
Cc: 78118-done <at> debbugs.gnu.org
Subject: Re: bug#78118: [PATCH] ; Isearch: Fix key bindings in documentation
 string
Date: Tue, 29 Apr 2025 09:10:56 +0800

Hello,

Thanks, installed on emacs-30 and closing the bug.  I added the bug
number to your commit message and fixed some typos.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.