GNU logs - #78188, boring messages

Message sent to liliana.prikler@HIDDEN, ludo@HIDDEN, maxim.cournoyer@HIDDEN, noelopez@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78188] [PATCH] Add KWallet service
Resent-From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: liliana.prikler@HIDDEN, ludo@HIDDEN, maxim.cournoyer@HIDDEN, noelopez@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Thu, 01 May 2025 13:52:02 +0000
Resent-Message-ID: <handler.78188.B.17461074747024 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78188 <at> debbugs.gnu.org
Cc: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, =?UTF-8?Q?No=C3=A9?= Lopez <noelopez@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Date: Thu,  1 May 2025 15:50:24 +0200
Message-ID: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::32d;
 envelope-from=sergio.pastorperez@HIDDEN; helo=mail-wm1-x32d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This patch series adds `kwallet-service-type'. This service serves the same
function as `gnome-keyring-service-type' but for `kwallet'. By default the
service configures PAM for SDDM, since this is the expected greeter to use
with `kwallet-pam'.

The 'libexec/pam_kwallet_init' binary form the `kwallet-pam' package was not
properly wrapped and could not access the `socat' input binary. This patch
series includes the fix which is required for the correct autostart of the
wallet.

Sergio Pastor Pérez (2):
  gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper
    path.
  services: kwallet: New service.

 doc/guix.texi               | 37 ++++++++++++++++++++++
 gnu/packages/kde-plasma.scm | 14 +++++++--
 gnu/services/desktop.scm    | 61 +++++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+), 3 deletions(-)


base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1
-- 
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Subject: bug#78188: Acknowledgement ([PATCH] Add KWallet service)
Message-ID: <handler.78188.B.17461074747024.ack <at> debbugs.gnu.org>
References: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
X-Gnu-PR-Message: ack 78188
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 78188 <at> debbugs.gnu.org
Date: Thu, 01 May 2025 13:52:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Liliana Marie Prikler <liliana.prikler@HIDDEN>, Ludovic Court=C3=A8s <=
ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, No=C3=A9 Lopez =
<noelopez@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 78188 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78188: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78188
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to sughosha@HIDDEN, z572@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78188] [PATCH] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path.
Resent-From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: sughosha@HIDDEN, z572@HIDDEN, guix-patches@HIDDEN
Resent-Date: Thu, 01 May 2025 13:55:01 +0000
Resent-Message-ID: <handler.78188.B78188.17461076697536 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78188 <at> debbugs.gnu.org
Cc: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>, Sughosha <sughosha@HIDDEN>, Zheng Junjie <z572@HIDDEN>
From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Date: Thu,  1 May 2025 15:53:59 +0200
Message-ID: <a73931b2adbba2b1949b30d9d3bf6e63662d0da2.1746106891.git.sergio.pastorperez@HIDDEN>
In-Reply-To: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
References: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not setting
PATH variable to access 'socat' input.

Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c
---
 gnu/packages/kde-plasma.scm | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 679a68cef6..a15f7ad8a2 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -1303,9 +1303,17 @@ (define-public kwallet-pam
                 "0dif5y7qbayb2yfgl7940978ayyir948kpjavczvgkr70czb293k"))))
     (build-system qt-build-system)
     (arguments
-     (list
-      #:qtbase qtbase
-      #:tests? #f)) ;no tests
+     `(#:qtbase ,qtbase
+       #:tests? #f ;no tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((socat (search-input-file inputs "bin/socat")))
+               (wrap-program (search-input-file outputs
+                              "libexec/pam_kwallet_init")
+                 `("PATH" ":" prefix
+                   ,(list (dirname socat))))))))))
     (native-inputs (list extra-cmake-modules pkg-config))
     (inputs (list linux-pam kwallet libgcrypt socat))
     (synopsis "PAM Integration with KWallet")
-- 
2.49.0

Message sent to liliana.prikler@HIDDEN, ludo@HIDDEN, maxim.cournoyer@HIDDEN, noelopez@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78188] [PATCH] services: kwallet: New service.
Resent-From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: liliana.prikler@HIDDEN, ludo@HIDDEN, maxim.cournoyer@HIDDEN, noelopez@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN
Resent-Date: Thu, 01 May 2025 13:55:02 +0000
Resent-Message-ID: <handler.78188.B78188.17461076737559 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78188 <at> debbugs.gnu.org
Cc: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, =?UTF-8?Q?No=C3=A9?= Lopez <noelopez@HIDDEN>, Vivien Kraus <vivien@HIDDEN>
From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= <sergio.pastorperez@HIDDEN>
Date: Thu,  1 May 2025 15:54:00 +0200
Message-ID: <cf6a25f1cbedf15dea0312e49f9427e5de148afb.1746106891.git.sergio.pastorperez@HIDDEN>
In-Reply-To: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
References: <cover.1746106890.git.sergio.pastorperez@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Change-Id: I1330ce5e1648a8ddf6ddd507255a73335d6baa51
---
 doc/guix.texi            | 37 ++++++++++++++++++++++++
 gnu/services/desktop.scm | 61 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 98 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 7b418a4089..c6861b3182 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -27131,6 +27131,43 @@ Desktop Services
 @end table
 @end deftp
 
+@defvar kwallet-service-type
+This is the type of the service that adds the
+@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}.  Its
+value is a @code{kwallet-configuration} object (see below).  Note that,
+contrary to @code{gnome-desktop-service-type},
+@code{plasma-desktop-service-type} does not include this service.
+
+This service adds the @code{kwallet-pam} package to the system profile
+and extends PAM with entries using @code{pam_kwallet5.so},
+unlocking a user's login keyring when they log in or setting its
+password with passwd.
+@end defvar
+
+@deftp {Data Type} kwallet-configuration
+Configuration record for the KWallet Keyring service.
+
+@table @asis
+@item @code{keyring} (default: @code{kwallet-pam})
+The KWallet keyring package to use.
+
+@item @code{pam-services}
+A list of @code{(@var{service} . @var{kind})} pairs denoting PAM
+services to extend, where @var{service} is the name of an existing
+service to extend and @var{kind} is one of @code{login} or
+@code{passwd}.
+
+If @code{login} is given, it adds an optional
+@code{pam_kwallet5.so} to the auth block without arguments and to
+the session block with @code{auto_start}.  If @code{passwd} is given, it
+adds an optional @code{pam_kwallet5.so} to the password block
+without arguments.
+
+By default, this field contains ``sddm'' with the value @code{login}
+and ``passwd'' is with the value @code{passwd}.
+@end table
+@end deftp
+
 @defvar seatd-service-type
 @uref{https://sr.ht/~kennylevinsen/seatd/, seatd} is a minimal seat
 management daemon.
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index a586746cc5..a3cbf3f397 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -197,6 +197,10 @@ (define-module (gnu services desktop)
             gnome-keyring-configuration?
             gnome-keyring-service-type
 
+            kwallet-configuration
+            kwallet-configuration?
+            kwallet-service-type
+
             seatd-configuration
             seatd-service-type
 
@@ -2148,6 +2152,63 @@ (define enlightenment-desktop-service-type
 thumbnails and privileges the programs which enlightenment needs to function
 as expected.")))
 
+
+;;;
+;;; kwallet-service-type
+;;;
+
+(define-record-type* <kwallet-configuration> kwallet-configuration
+  make-kwallet-configuration
+  kwallet-configuration?
+  (wallet kwallet-package (default kwallet-pam))
+  (pam-services kwallet-pam-services (default '(("sddm" . login)
+                                                ("passwd" . passwd)))))
+
+(define (pam-kwallet config)
+  (match config
+    (#f '())                          ;explicitly disabled by user
+    (_
+     (define (%pam-keyring-entry . arguments)
+       (pam-entry
+        (control "optional")
+        (module (file-append (kwallet-package config)
+                             "/lib/security/pam_kwallet5.so"))
+        (arguments arguments)))
+
+     (list
+      (pam-extension
+       (transformer
+        (lambda (service)
+          (case (assoc-ref (kwallet-pam-services config)
+                           (pam-service-name service))
+            ((login)
+             (pam-service
+              (inherit service)
+              (auth (append (pam-service-auth service)
+                            (list (%pam-keyring-entry))))
+              (session (append (pam-service-session service)
+                               (list (%pam-keyring-entry "auto_start"))))))
+            ((passwd)
+             (pam-service
+              (inherit service)
+              (password (append (pam-service-password service)
+                                (list (%pam-keyring-entry))))))
+            (else service)))))))))
+
+;; TODO: consider integrating service in `<plasma-desktop-configuration>' as
+;; done in `<gnome-desktop-configuration>'. This requires rewritting the
+;; `<plasma-desktop-service-type>' as done for `<gnome-desktop-service-type>'.
+(define kwallet-service-type
+  (service-type
+   (name 'kwallet)
+   (extensions (list
+                (service-extension pam-root-service-type pam-kwallet)))
+   (default-value (kwallet-configuration))
+   (description "Return a service, that extends PAM with entries using
+@code{pam_kwallet5.so}, unlocking a user's login keyring when they log in or
+setting its password with passwd.")))
+
+
 ;;;
 ;;; KDE Plasma desktop service.
 ;;;
-- 
2.49.0

Last modified: Thu, 1 May 2025 14:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.