GNU bug report logs - #78205
[PATCH] Recenter for the calendar

Previous Next

To reply to this bug, email your comments to 78205 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Recenter for the calendar
Date: Fri, 02 May 2025 09:50:07 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

This patch adds a "recenter month at point" functionality to the
calendar.  It also mimics what 'recenter-top-bottom' is doing for
regular buffers.



In GNU Emacs 31.0.50 (build 1, x86_64-unknown-openbsd7.7, X toolkit) of
 2025-05-02 built on computer
Repository revision: b9319616ed63dfb2291f6515828ae450aedfe6fa
Repository branch: mgi/cal-recenter
Windowing system distributor 'The X.Org Foundation', version 11.0.12101016
System Description: OpenBSD computer 7.7 GENERIC.MP#626 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Recenter-for-the-calendar.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 78205 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 78205 <at> debbugs.gnu.org
Subject: Re: bug#78205: [PATCH] Recenter for the calendar
Date: Sat, 03 May 2025 12:52:17 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Fri, 02 May 2025 09:50:07 +0200
> 
> This patch adds a "recenter month at point" functionality to the
> calendar.  It also mimics what 'recenter-top-bottom' is doing for
> regular buffers.

Thanks.

The documentation parts should explain more what it means to "center"
a date, and also the meaning of "first place", "last place", etc.
These are not self-evident when describing this kind of "centering".

Message #11 received at 78205 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78205 <at> debbugs.gnu.org
Subject: Re: bug#78205: [PATCH] Recenter for the calendar
Date: Sat, 03 May 2025 13:59:49 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Date: Fri, 02 May 2025 09:50:07 +0200
>> 
>> This patch adds a "recenter month at point" functionality to the
>> calendar.  It also mimics what 'recenter-top-bottom' is doing for
>> regular buffers.
>
> Thanks.
>
> The documentation parts should explain more what it means to "center"
> a date, and also the meaning of "first place", "last place", etc.
> These are not self-evident when describing this kind of "centering".

Thanks for the review.  What do you think of this?

[0001-Recenter-for-the-calendar-bug-78205.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #14 received at 78205 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 78205 <at> debbugs.gnu.org
Subject: Re: bug#78205: [PATCH] Recenter for the calendar
Date: Sat, 03 May 2025 15:53:29 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 78205 <at> debbugs.gnu.org
> Date: Sat, 03 May 2025 13:59:49 +0200
> 
> +@kindex C-l @r{(Calendar mode)}
> +@findex calendar-recenter-first-last
> +  The command @kbd{C-l} (@code{calendar-recenter-first-last}) scrolls
> +the calendar so that the month of the date at point is centered (i.e.,
> +it is placed in second position of the three displayed months).  With a
> +second invocation, this command puts this same month on the left hand
> +side in the calendar view and a third invocation puts it on the right
> +hand side.  This is in analogy with @code{recenter-top-bottom}.

I'd suggest to simplify:

  The command @kbd{C-l} (@code{calendar-recenter-first-last}) scrolls
  the calendar on display so that the month of the date at point is
  centered horizontally.  Next invocation of this command puts that
  month on the leftmost position, and another invocation puts it on
  the rightmost position.  Subsequent invocations reuse the same order
  in a cyclical manner.

Message #17 received at 78205 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78205 <at> debbugs.gnu.org
Subject: Re: bug#78205: [PATCH] Recenter for the calendar
Date: Sat, 03 May 2025 16:58:29 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Cc: 78205 <at> debbugs.gnu.org
>> Date: Sat, 03 May 2025 13:59:49 +0200
>> 
>> +@kindex C-l @r{(Calendar mode)}
>> +@findex calendar-recenter-first-last
>> +  The command @kbd{C-l} (@code{calendar-recenter-first-last}) scrolls
>> +the calendar so that the month of the date at point is centered (i.e.,
>> +it is placed in second position of the three displayed months).  With a
>> +second invocation, this command puts this same month on the left hand
>> +side in the calendar view and a third invocation puts it on the right
>> +hand side.  This is in analogy with @code{recenter-top-bottom}.
>
> I'd suggest to simplify:
>
>   The command @kbd{C-l} (@code{calendar-recenter-first-last}) scrolls
>   the calendar on display so that the month of the date at point is
>   centered horizontally.  Next invocation of this command puts that
>   month on the leftmost position, and another invocation puts it on
>   the rightmost position.  Subsequent invocations reuse the same order
>   in a cyclical manner.

Neat.  Your english is better than mine ;-) But before I do this
modification, do you think that the command name is still appropriate?
-- 
Manuel Giraud

Message #20 received at 78205 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 78205 <at> debbugs.gnu.org
Subject: Re: bug#78205: [PATCH] Recenter for the calendar
Date: Sat, 03 May 2025 18:47:31 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 78205 <at> debbugs.gnu.org
> Date: Sat, 03 May 2025 16:58:29 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I'd suggest to simplify:
> >
> >   The command @kbd{C-l} (@code{calendar-recenter-first-last}) scrolls
> >   the calendar on display so that the month of the date at point is
> >   centered horizontally.  Next invocation of this command puts that
> >   month on the leftmost position, and another invocation puts it on
> >   the rightmost position.  Subsequent invocations reuse the same order
> >   in a cyclical manner.
> 
> Neat.  Your english is better than mine ;-)

Years of practice ;-)

> But before I do this modification, do you think that the command
> name is still appropriate?

I think calendar-recenter is good enough.  (The reason for the
"-top-bottom" part of recenter-top-bottom is historical, because we
already had a primitive called "recenter".)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.