GNU bug report logs - #78222
package-vc-from-checkout generates incorrect package summaries

Previous Next

To reply to this bug, email your comments to 78222 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: package-vc-from-checkout generates incorrect package summaries
Date: Fri, 2 May 2025 20:16:52 -0400

`package-vc-install-from-checkout' fails to generate correct package summaries in the package files it generates, always using "No description available."  

The issue is as follows:

    • `package-vc-install-from-checkout' uses `package-desc-create' to create a description structure based on the directory name of the installed package.
    • This constructor includes a default `summary' slot of `package--default-summary' ("No description available.")
    • During unpacking, `package-vc--generate-description-file' is called with this pre-populated description structure.
    • It notices the existence of the (default) `package-desc-summary', and simply skips reading the main package file to derive the summary from its header line.

The solution may be to alter the test logic in  `package-vc--generate-description-file', or let-bind `package--default-summary=nil' during structure creation.

Message #8 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 78222 <at> debbugs.gnu.org
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 10 May 2025 13:30:39 +0300

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Fri, 2 May 2025 20:16:52 -0400
> 
> `package-vc-install-from-checkout' fails to generate correct package summaries in the package files it generates, always using "No description available."  
> 
> The issue is as follows:
> 
>     • `package-vc-install-from-checkout' uses `package-desc-create' to create a description structure based on the directory name of the installed package.
>     • This constructor includes a default `summary' slot of `package--default-summary' ("No description available.")
>     • During unpacking, `package-vc--generate-description-file' is called with this pre-populated description structure.
>     • It notices the existence of the (default) `package-desc-summary', and simply skips reading the main package file to derive the summary from its header line.
> 
> The solution may be to alter the test logic in  `package-vc--generate-description-file', or let-bind `package--default-summary=nil' during structure creation.

Philip, any comments or suggestions?

Message #11 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78222 <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Fri, 16 May 2025 15:29:56 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Fri, 2 May 2025 20:16:52 -0400
>> 
>> `package-vc-install-from-checkout' fails to generate correct package
>> summaries in the package files it generates, always using "No
>> description available."
>> 
>> The issue is as follows:
>> 
>>     • `package-vc-install-from-checkout' uses `package-desc-create'
>> to create a description structure based on the directory name of the
>> installed package.
>>     • This constructor includes a default `summary' slot of
>> `package--default-summary' ("No description available.")
>>     • During unpacking, `package-vc--generate-description-file' is
>> called with this pre-populated description structure.
>>     • It notices the existence of the (default)
>> `package-desc-summary', and simply skips reading the main package
>> file to derive the summary from its header line.
>> 
>> The solution may be to alter the test logic in
>> `package-vc--generate-description-file', or let-bind
>> `package--default-summary=nil' during structure creation.
>

What version of Emacs are you on?  Ever since bug#76065 we are testing
if the description matches the default description, in which we add a
special case for re-checking the package description if the current
description matches `package--default-summary'.

> Philip, any comments or suggestions?

Message #14 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78222 <at> debbugs.gnu.org
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Fri, 16 May 2025 17:41:16 -0400

> On May 16, 2025, at 11:29 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>>> From: JD Smith <jdtsmith <at> gmail.com>
>>> Date: Fri, 2 May 2025 20:16:52 -0400
>>> 
>>> `package-vc-install-from-checkout' fails to generate correct package
>>> summaries in the package files it generates, always using "No
>>> description available."
>>> 
>>> The issue is as follows:
>>> 
>>>    • `package-vc-install-from-checkout' uses `package-desc-create'
>>> to create a description structure based on the directory name of the
>>> installed package.
>>>    • This constructor includes a default `summary' slot of
>>> `package--default-summary' ("No description available.")
>>>    • During unpacking, `package-vc--generate-description-file' is
>>> called with this pre-populated description structure.
>>>    • It notices the existence of the (default)
>>> `package-desc-summary', and simply skips reading the main package
>>> file to derive the summary from its header line.
>>> 
>>> The solution may be to alter the test logic in
>>> `package-vc--generate-description-file', or let-bind
>>> `package--default-summary=nil' during structure creation.
>> 
> 
> What version of Emacs are you on?  Ever since bug#76065 we are testing
> if the description matches the default description, in which we add a
> special case for re-checking the package description if the current
> description matches `package--default-summary'.

I'm on the Emacs-30 branch.  I don't see a version number in package-vc.el, but it lists:

;;; package-vc.el --- Manage packages from VC checkouts     -*- lexical-binding: t; -*-
;; Copyright (C) 2022-2025 Free Software Foundation, Inc.

Last commit d63b27a416b.

Message #17 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78222 <at> debbugs.gnu.org
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 17 May 2025 09:03:47 +0000

JD Smith <jdtsmith <at> gmail.com> writes:

>> On May 16, 2025, at 11:29 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>>>> From: JD Smith <jdtsmith <at> gmail.com>
>>>> Date: Fri, 2 May 2025 20:16:52 -0400
>>>> 
>>>> `package-vc-install-from-checkout' fails to generate correct package
>>>> summaries in the package files it generates, always using "No
>>>> description available."
>>>> 
>>>> The issue is as follows:
>>>> 
>>>>    • `package-vc-install-from-checkout' uses `package-desc-create'
>>>> to create a description structure based on the directory name of the
>>>> installed package.
>>>>    • This constructor includes a default `summary' slot of
>>>> `package--default-summary' ("No description available.")
>>>>    • During unpacking, `package-vc--generate-description-file' is
>>>> called with this pre-populated description structure.
>>>>    • It notices the existence of the (default)
>>>> `package-desc-summary', and simply skips reading the main package
>>>> file to derive the summary from its header line.
>>>> 
>>>> The solution may be to alter the test logic in
>>>> `package-vc--generate-description-file', or let-bind
>>>> `package--default-summary=nil' during structure creation.
>>> 
>> 
>> What version of Emacs are you on?  Ever since bug#76065 we are testing
>> if the description matches the default description, in which we add a
>> special case for re-checking the package description if the current
>> description matches `package--default-summary'.
>
> I'm on the Emacs-30 branch.  I don't see a version number in package-vc.el, but it lists:
>
> ;;; package-vc.el --- Manage packages from VC checkouts     -*- lexical-binding: t; -*-
> ;; Copyright (C) 2022-2025 Free Software Foundation, Inc.
>
> Last commit d63b27a416b.

That is enough information, the fix I mentioned was applied onto the
master branch.  Do you want to build the master branch yourself and
check if the bug has been resolved, or should we just close the bug
directly as a duplicate?

Message #20 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78222 <at> debbugs.gnu.org
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 17 May 2025 08:53:16 -0400

> On May 17, 2025, at 5:03 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
> 
> That is enough information, the fix I mentioned was applied onto the
> master branch.  Do you want to build the master branch yourself and
> check if the bug has been resolved, or should we just close the bug
> directly as a duplicate?

Unfortunately I don't have a master build setup right now; can you confirm that packages in the package listing with archive "source" say something more interesting than "No description available."?  Can be closed if so.

Message #23 received at 78222 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: philipk <at> posteo.net, JD Smith <jdtsmith <at> gmail.com>
Cc: 78222 <at> debbugs.gnu.org
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 24 May 2025 12:17:15 +0300

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Sat, 17 May 2025 08:53:16 -0400
> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>  78222 <at> debbugs.gnu.org
> 
> 
> 
> > On May 17, 2025, at 5:03 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
> > 
> > That is enough information, the fix I mentioned was applied onto the
> > master branch.  Do you want to build the master branch yourself and
> > check if the bug has been resolved, or should we just close the bug
> > directly as a duplicate?
> 
> Unfortunately I don't have a master build setup right now; can you confirm that packages in the package listing with archive "source" say something more interesting than "No description available."?  Can be closed if so.

Philip, should we close this bug?

Message #28 received at 78222-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78222-done <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 24 May 2025 10:37:58 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Sat, 17 May 2025 08:53:16 -0400
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>>  78222 <at> debbugs.gnu.org
>> 
>> 
>> 
>> > On May 17, 2025, at 5:03 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
>> > 
>> > That is enough information, the fix I mentioned was applied onto the
>> > master branch.  Do you want to build the master branch yourself and
>> > check if the bug has been resolved, or should we just close the bug
>> > directly as a duplicate?
>> 
>> Unfortunately I don't have a master build setup right now; can you
>> confirm that packages in the package listing with archive "source"
>> say something more interesting than "No description available."?
>> Can be closed if so.
>
> Philip, should we close this bug?

Sorry, yes the issue that JD is describing has been resolved.  I am
marking the bug report as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.