GNU bug report logs - #78262
30.1; comint-delchar-or-maybe-eof doesn't respect delete-active-region

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Sebastián Monía <sebastian@HIDDEN>; merged with #73527; Done: Juri Linkov <juri@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug marked as fixed in version 31.0.50, send any further explanations to 78262 <at> debbugs.gnu.org and Sebastián Monía <sebastian@HIDDEN> Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
bug Marked as fixed in versions 31.0.50. Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 14 May 2025 06:11:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 14 02:11:19 2025
Received: from localhost ([127.0.0.1]:38259 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uF5Ko-0001a7-VU
	for submit <at> debbugs.gnu.org; Wed, 14 May 2025 02:11:19 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:34477)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1uF5Kk-0001Zh-7k; Wed, 14 May 2025 02:11:14 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 3526A4396F;
 Wed, 14 May 2025 06:11:05 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= <sebastian@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <87sel83eq6.fsf@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
 <87y0v3rsiq.fsf@HIDDEN>
 <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
 <874ixpiw9c.fsf@HIDDEN>
 <jwvtt5p7hsg.fsf-monnier+emacs@HIDDEN>
 <87sel83eq6.fsf@HIDDEN>
Date: Wed, 14 May 2025 09:06:41 +0300
Message-ID: <8734d7d8um.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftdeivdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeekvdeivdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrgdprhgtphhtthhopehsvggsrghsthhirghnsehsvggsrghsmhhonhhirgdrtghomh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

fixed 78262 31.0.50
close 78262 31.0.50
thanks

>>> Anyway, your latest patch is sufficient for closing this bug report.
>>
>> Indeed, the delsel part is orthogonal.  I pushed it (fixed to obey
>> command remapping), thanks.
>
> Thanks everyone!
> I happened to be AFK for a few days and now I see this was fixed.

So now closing as fixed.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 13 May 2025 11:57:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 13 07:57:49 2025
Received: from localhost ([127.0.0.1]:58436 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uEoGb-0001GX-Fm
	for submit <at> debbugs.gnu.org; Tue, 13 May 2025 07:57:49 -0400
Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]:48037)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <sebastian@HIDDEN>)
 id 1uEoGX-0001GH-LY
 for 78262 <at> debbugs.gnu.org; Tue, 13 May 2025 07:57:47 -0400
Received: from phl-compute-01.internal (phl-compute-01.phl.internal
 [10.202.2.41])
 by mailfhigh.phl.internal (Postfix) with ESMTP id C4E8A11400DD;
 Tue, 13 May 2025 07:57:39 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
 by phl-compute-01.internal (MEProxy); Tue, 13 May 2025 07:57:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com;
 h=cc:cc:content-transfer-encoding:content-type:content-type
 :date:date:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:subject:subject:to:to; s=fm1;
 t=1747137459; x=1747223859; bh=2hJEt+UBvNFs+/GX7ZmQ1VwkuInY3Z1p
 vNuEAPv36yo=; b=NZkD4WKlZAI5j8tQWZGxMX21lQnOZ3JcbXBRqzIkfqxo2TG5
 M3tj/3dGPxQ7ZCmiCD3NRWfne0y9gbVMywena/AZ9mSGh+MDt+JGwe5pm6+3k5/3
 iY9zaZK0G1RIxtDZ9+ksaRi3NNe4Rt0zot5+9XVBc/Ngi7/viwKU2B/ki9yVM88n
 Yrj+Tgk/LPxaZDypmMJDF9cfLroK7cyfWDFgnje0ss6ja2J9Vyh3pcL/sPYMPGmT
 sqHc64Suoe0gAhpV0MSm60oLaQCxytSUVbABjbQB4S5i2Odlir1qkUwxhvREekc5
 kAubn/BNyndyIfyJsbexZ6ISqv1slORNEY5sHg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1747137459; x=
 1747223859; bh=2hJEt+UBvNFs+/GX7ZmQ1VwkuInY3Z1pvNuEAPv36yo=; b=v
 4/Th48j8O4wcdmE1eUvPKtYtHmgivp12yl1mjfu026/cWKNe9qkYSlF/P34zrXe8
 DgbRxK80XHS4DHO/Aqd87lH2VOLD66c7jzX89um5bV60KtUYYiOtuLagr1dusmFV
 aB1ZPSu06SzFt7sGy2dE6EYpoKqlgeIXSFQGHDrbBW1D02h/Gg/QawkZ6nDJqBuj
 q0Z8BbwndMHrMI6NcE2wLjBion/Lv9XvmhXDZajpHMtG23zPZuYiu1nZKNMRvNK+
 3UoAPhB3uNzwdfOIaKvTS1efahR1ZtQR/1ubBShjB1nWKAwbl94Xc7/dehsT94RC
 T1TqR83+muoRAWbp8H8IA==
X-ME-Sender: <xms:szMjaNR5Jf6QO9vKO5fA8hAY8z912EcJFM94OwTTKDdG1fTpzgyUqw>
 <xme:szMjaGxzz1C6SrbcZhZPa2tKwmp34iFcFkk5fVaOcZyKSk6yhib4Q-4WY6qds5u9w
 pCO3cUTTWtpEm2kcgo>
X-ME-Received: <xmr:szMjaC2F99C0Nu2xd6g8QoWkXp2nUx-Q990ZFf_CaENDHXnUbpcL605z0s5RZMCqT1ls6OMBRFMVLYY1mW7EJ6iXCkcvp5MGBCIOeLGNKw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftdegtdegucetufdoteggodetrf
 dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv
 pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih
 gvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddt
 reejnecuhfhrohhmpefuvggsrghsthhijohnucfoohhnvogruceoshgvsggrshhtihgrnh
 esshgvsggrshhmohhnihgrrdgtohhmqeenucggtffrrghtthgvrhhnpeekteetkeegvdeg
 heevledtuefhvefggfekheekfeetveekieehieevtdethfeludenucffohhmrghinhepsh
 gvsggrshhmohhnihgrrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
 pehmrghilhhfrhhomhepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmpd
 hnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejkedv
 iedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurd
 horhhgpdhrtghpthhtohepjhhurhhisehlihhnkhhovhdrnhgvthdprhgtphhtthhopehm
 ohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrg
X-ME-Proxy: <xmx:szMjaFCOaWv_DJqmiZy_GcvBUQUoFcDIpnsKnjPWDaOG9fF3rpvAJg>
 <xmx:szMjaGg80V_FOchva8ITuk0BzVjAkXO6g88HDIHT79q-wf6l46a0cg>
 <xmx:szMjaJrEIim5X9q-oi5yZzPUldXfcY4Yy0oDno-IanQKNyfA8qPSaQ>
 <xmx:szMjaBijBf1GqGGnvcNOCJzkxK55amCTd7YTcdryovExO3WyGAl0-g>
 <xmx:szMjaN7FEe4uzz7v6fc9GRLldCPMzFxlaathdeNLVOvWRaHZeGJfpC9L>
Feedback-ID: iab2c46da:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 13 May 2025 07:57:38 -0400 (EDT)
From: =?utf-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= <sebastian@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <jwvtt5p7hsg.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Mon, 12 May 2025 15:34:47 -0400")
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN> <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
 <87y0v3rsiq.fsf@HIDDEN> <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
 <874ixpiw9c.fsf@HIDDEN> <jwvtt5p7hsg.fsf-monnier+emacs@HIDDEN>
Date: Tue, 13 May 2025 07:57:37 -0400
Message-ID: <87sel83eq6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: Eli Zaretskii <eliz@HIDDEN>, 78262 <at> debbugs.gnu.org,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


Stefan Monnier <monnier@HIDDEN> writes:
>> Anyway, your latest patch is sufficient for closing this bug report.
>
> Indeed, the delsel part is orthogonal.  I pushed it (fixed to obey
> command remapping), thanks.

Thanks everyone!
I happened to be AFK for a few days and now I see this was fixed.

--=20
Sebasti=C3=A1n Mon=C3=ADa
https://site.sebasmonia.com/
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 12 May 2025 19:34:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 12 15:34:58 2025
Received: from localhost ([127.0.0.1]:54930 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uEYvR-0005EX-Ut
	for submit <at> debbugs.gnu.org; Mon, 12 May 2025 15:34:58 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17380)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1uEYvO-0005EJ-UK
 for 78262 <at> debbugs.gnu.org; Mon, 12 May 2025 15:34:56 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2341580823;
 Mon, 12 May 2025 15:34:49 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1747078488;
 bh=IDmjTtgfABpXqURPE24/HhhJQezOK41vdTIuN7A1cQ4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=mt7vvDYKywCmDR+WUzTVi4AuPnIpLzcnJ3nveBK/4WRj3VSwN0kTf31tiE+QNcGwO
 vbHeADv79PgIhUBCMvz+3NbLghS5bLo4SQrUhDklX7iYgJAcTw7qfWqZB0Mowq0tZT
 Nfle6eo65IpwRgjvx3WdDq0BDKgrNwj6tQHEbpfTwVCq0hFwh8/nAIVSeeBkrrdjD7
 vd/1Lu3nWrHm2j2EKCab+PQB7xVH26O74vZ1jpNq/+iAQArVLO0NW1ix90d3UjvrDd
 xmbRTREMuzTVf0/TibDgbiPZ2gzQDtozny5vbhddtoTjpG4Y2b2kUDxaRvWugQ1dHz
 5nLsl/ppojw/Q==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4B151803EA;
 Mon, 12 May 2025 15:34:48 -0400 (EDT)
Received: from alfajor (bras-base-mtrlpq42zf4-grc-13-70-24-234-232.dsl.bell.ca
 [70.24.234.232])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CEDD12022D;
 Mon, 12 May 2025 15:34:48 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <874ixpiw9c.fsf@HIDDEN>
Message-ID: <jwvtt5p7hsg.fsf-monnier+emacs@HIDDEN>
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
 <87y0v3rsiq.fsf@HIDDEN>
 <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
 <874ixpiw9c.fsf@HIDDEN>
Date: Mon, 12 May 2025 15:34:47 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.065 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Ah.  I consider this part of delsel.el to be obsolete (made obsolete
>> back in Emacs-24 by the `delete-active-region` variable).
> It seems the primary reason people are rebinding `C-d` from `delete-char`
> to `delete-forward-char` is to be able to delete the region with it.

Yeah, I can't see what other reason there would be.

>> If `delsel.el` wants to make `C-d` delete the active region, it should
>> preferably do it by remapping `delete-char` to `delete-forward-char`, IMO.
> Not sure if `delsel.el` should rebind the global keybindings.

That would be to preserve its historical behavior w.r.t `C-d` while
making use of the "new" infrastructure.
I'm also not sure if that's important to do.
[ Also, I really meant "remap", not "rebind": it can be done easily and
  non-destructively in a minor mode map, contrary to rebinding.  ]

The way I see it, the only reason why we still want/need `delsel.el` is
to implement the "delete active region upon insertion", i.e. things
like:

    (put 'self-insert-command 'delete-selection #'delete-selection-uses-region-p)
    (put 'yank 'delete-selection 'yank)

> Anyway, your latest patch is sufficient for closing this bug report.

Indeed, the delsel part is orthogonal.  I pushed it (fixed to obey
command remapping), thanks.


        Stefan
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 12 May 2025 17:53:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 12 13:53:57 2025
Received: from localhost ([127.0.0.1]:54624 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uEXLg-0000I7-Ss
	for submit <at> debbugs.gnu.org; Mon, 12 May 2025 13:53:57 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53583)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uEXLd-0000Hi-CX
 for 78262 <at> debbugs.gnu.org; Mon, 12 May 2025 13:53:55 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 8849043955;
 Mon, 12 May 2025 17:53:44 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
 <87y0v3rsiq.fsf@HIDDEN>
 <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
Date: Mon, 12 May 2025 20:46:35 +0300
Message-ID: <874ixpiw9c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftdduleduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejkedviedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggr
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>>> PS: this still requires
>>>>
>>>>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
>>>>
>>>> that could be added later.
>>>
>>> Hmm... sorry my `delete-selection`-fu is rusty, what would this
>>> do/fix, again?
>>
>> This is a copy from delsel.el
>>
>>   ;; delete-backward-char and delete-forward-char already delete the selection by
>>   ;; default, but not delete-char.
>>   (put 'delete-char 'delete-selection 'supersede)
>>
>> that will do the same for 'comint-delchar-or-maybe-eof'
>> that uses 'delete-char' by default.
>
> Ah.  I consider this part of delsel.el to be obsolete (made obsolete
> back in Emacs-24 by the `delete-active-region` variable).

It seems the primary reason people are rebinding `C-d` from `delete-char`
to `delete-forward-char` is to be able to delete the region with it.

> If `delsel.el` wants to make `C-d` delete the active region, it should
> preferably do it by remapping `delete-char` to `delete-forward-char`, IMO.

Not sure if `delsel.el` should rebind the global keybindings.

Anyway, your latest patch is sufficient for closing this bug report.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 12 May 2025 04:28:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 12 00:28:17 2025
Received: from localhost ([127.0.0.1]:48998 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uEKm1-0006Qt-9f
	for submit <at> debbugs.gnu.org; Mon, 12 May 2025 00:28:17 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51770)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1uEKlx-0006QZ-Oz
 for 78262 <at> debbugs.gnu.org; Mon, 12 May 2025 00:28:15 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 767ED8071A;
 Mon, 12 May 2025 00:28:07 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1747024082;
 bh=rsBjvyXqWoUWecmyvgGJPN9Fk32F+VvOUKf9khLv86E=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Tiej+fkcQIcYUPwOGjTxJL3a+s+ldh2A1mfuU18iyacIthPR4H0rpj0RUI1T427Nf
 OAA1hEMLRkkHehld9VMW2fpHRuKK43euQ9eopuKrAwnn31pASYtWoa0seeu1MNF6Qs
 eHbvW8IFmtQ+Q9SRc0LWGK5jpsxqX+ruCMsas/bmiO+yCTcXuKzhtRTM2CxrJLLVjK
 so1IFcv50y99tcxTSXBiE6wjiHP5u3+eGO8/IkvopqxEGk3zApj7NxSRiotwuJO0eR
 4/Zp8pCGxpnuJO9YL7opdZPdIFAxJzLyFj3HB5FALv8R9TUqGRsgGjt9aStk0w+A/l
 x1pburDR5LnVQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 68E73804D9;
 Mon, 12 May 2025 00:28:02 -0400 (EDT)
Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2FE6B12033F;
 Mon, 12 May 2025 00:28:02 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <87y0v3rsiq.fsf@HIDDEN>
Message-ID: <jwvo6vyzcay.fsf-monnier+emacs@HIDDEN>
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
 <87y0v3rsiq.fsf@HIDDEN>
Date: Mon, 12 May 2025 00:28:00 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.090 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> PS: this still requires
>>>
>>>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
>>>
>>> that could be added later.
>>
>> Hmm... sorry my `delete-selection`-fu is rusty, what would this
>> do/fix, again?
>
> This is a copy from delsel.el
>
>   ;; delete-backward-char and delete-forward-char already delete the selection by
>   ;; default, but not delete-char.
>   (put 'delete-char 'delete-selection 'supersede)
>
> that will do the same for 'comint-delchar-or-maybe-eof'
> that uses 'delete-char' by default.

Ah.  I consider this part of delsel.el to be obsolete (made obsolete
back in Emacs-24 by the `delete-active-region` variable).
If `delsel.el` wants to make `C-d` delete the active region, it should
preferably do it by remapping `delete-char` to `delete-forward-char`, IMO.


        Stefan
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 19:40:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 15:40:48 2025
Received: from localhost ([127.0.0.1]:42786 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uECXY-0001Za-09
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 15:40:48 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40778)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uECXV-0001Z9-AA
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 15:40:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uECXP-0001mC-6P; Sun, 11 May 2025 15:40:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=tRqOjEHgrASeF/dc2E1XoUbmyR2nWOBuNuj4ZGJBLTQ=; b=f2PZMDuiMcu4
 mOgnZ2NgGwwlZcyJnmgTwLJL9XN1BugthWI8S8jNFGYgwzKHKqU/Aj58E0uxshxqnLZ7hz5vHaIpa
 h7osWzXZuQRscB2rbQkFmpCfmfHnYhUTnAoxob00QHTvmcSUyFLvnAvTboVq28iq3UU72huSoUKpN
 PqkAjivgGfbT8GtSuEdY255R+p3gfLBIs6JkTYVH5PidoWwEGdCPTVCuv+/clQMiFh5cOzNs44+ll
 HdXDcylpxT9UUcAi5fUsYtA+ThIJMN9HdctpP+tzfncbMtEfMDRUks57Oro/U7mIZofJ9bM1FNMbg
 OG7fW4UQpesxyDaQt6WiCg==;
Date: Sun, 11 May 2025 22:40:33 +0300
Message-Id: <86wman6imm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <87y0v3rsiq.fsf@HIDDEN> (message from Juri Linkov on
 Sun, 11 May 2025 20:53:17 +0300)
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN> <87y0v3rsiq.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, monnier@HIDDEN, 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  sebastian@HIDDEN,
>   78262 <at> debbugs.gnu.org
> Date: Sun, 11 May 2025 20:53:17 +0300
> 
> >> PS: this still requires
> >>
> >>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
> >>
> >> that could be added later.
> >
> > Hmm... sorry my `delete-selection`-fu is rusty, what would this
> > do/fix, again?
> 
> This is a copy from delsel.el
> 
>   ;; delete-backward-char and delete-forward-char already delete the selection by
>   ;; default, but not delete-char.
>   (put 'delete-char 'delete-selection 'supersede)
> 
> that will do the same for 'comint-delchar-or-maybe-eof'
> that uses 'delete-char' by default.

And that's why I questioned the wisdom of doing this.  Deleting the
entire active region is a dangerous operation, and users who don't
expect that will be extremely annoyed, I'm afraid.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 18:14:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 14:14:32 2025
Received: from localhost ([127.0.0.1]:41312 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uEBC3-0002pQ-RC
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 14:14:32 -0400
Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:57997)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uEBBz-0002om-NB
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 14:14:29 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 2690843A5E;
 Sun, 11 May 2025 18:14:19 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
 <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
Date: Sun, 11 May 2025 20:53:17 +0300
Message-ID: <87y0v3rsiq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvleeltdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejkedviedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggr
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> PS: this still requires
>>
>>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
>>
>> that could be added later.
>
> Hmm... sorry my `delete-selection`-fu is rusty, what would this
> do/fix, again?

This is a copy from delsel.el

  ;; delete-backward-char and delete-forward-char already delete the selection by
  ;; default, but not delete-char.
  (put 'delete-char 'delete-selection 'supersede)

that will do the same for 'comint-delchar-or-maybe-eof'
that uses 'delete-char' by default.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 16:34:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 12:34:22 2025
Received: from localhost ([127.0.0.1]:39181 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uE9d7-0002KA-SB
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 12:34:22 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49777)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1uE9d4-0002If-Cy
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 12:34:19 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C5602808A4;
 Sun, 11 May 2025 12:34:12 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1746981247;
 bh=TcRoyTfu+Tyqu1V/NKW/3eVtQZgyTXxCp7uR0mVJtC4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=MhfR/5fkr+q6uA7Z7pZI8bcpfrWoWrKfXsbUV7Th5tBqrBo4VZyaDWhpjRla9rohD
 jnJeAFuEzv+BRZyF5wH8dOAcvbYBNQExxEZaQY3bWB+3D/f1j74t5T9tMPhYECnxJv
 0lD94gkPBm8Jpq0txNrbNHrAOkbEgYCklqVQigZYxlYeVnLH4sDq63+bHWQEdmndG0
 +L1HX/QxGiY9pK6G4b0vTblEShhQHa+bU6nUeediuoU64Lws2MzUJT22s6re/Jtx6n
 hYL7qgq4UAGciIxlKutpgJLDewcxb7aAJRhvObCOR4a6On8Rl4QWl5dyBzoR/PiaQR
 sy5etR7U8jTRw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B527C803EA;
 Sun, 11 May 2025 12:34:07 -0400 (EDT)
Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7E683120588;
 Sun, 11 May 2025 12:34:07 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <878qn3wtw1.fsf@HIDDEN>
Message-ID: <jwvmsbj150z.fsf-monnier+emacs@HIDDEN>
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <878qn3wtw1.fsf@HIDDEN>
Date: Sun, 11 May 2025 12:34:06 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.089 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Since this also will fix bug#73527, merging with it.

Thanks.

> PS: this still requires
>
>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
>
> that could be added later.

Hmm... sorry my `delete-selection`-fu is rusty, what would this
do/fix, again?


        Stefan
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.
Forcibly Merged 73527 78262. Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 06:53:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 02:53:16 2025
Received: from localhost ([127.0.0.1]:56872 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uE0Ym-00007r-2X
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 02:53:16 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59797)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1uE0Yk-00007X-7B; Sun, 11 May 2025 02:53:14 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 4B53E43994;
 Sun, 11 May 2025 06:53:05 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
Date: Sun, 11 May 2025 09:40:30 +0300
Message-ID: <878qn3wtw1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvleejjeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeekvdeivdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsvggsrghsthhirghnsehsvggsrghsmhhonhhirgdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrg
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, Eli Zaretskii <eliz@HIDDEN>,
 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

forcemerge 78262 73527
thanks

> -(defun comint-delchar-or-maybe-eof (arg)
> -  "Delete ARG characters forward or send an EOF to subprocess.
> +(defun comint-delchar-or-maybe-eof ()
> +  "Do like the global binding or send an EOF to subprocess.
>  Sends an EOF only if point is at the end of the buffer and there is no input."
> -  (interactive "p" comint-mode)
> +  (interactive nil comint-mode)
>    (let ((proc (get-buffer-process (current-buffer))))
>      (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
>  	(comint-send-eof)
> -      (delete-char arg))))
> +      (call-interactively (lookup-key global-map (this-command-keys))))))

Since this also will fix bug#73527, merging with it.

PS: this still requires

  (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)

that could be added later.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 06:01:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 02:01:27 2025
Received: from localhost ([127.0.0.1]:56496 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDzkc-0005I8-Ig
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 02:01:27 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42151)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1uDzka-0005Hs-D0
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 02:01:24 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BFBA680037;
 Sun, 11 May 2025 02:01:18 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1746943277;
 bh=FqCEuhXdKGYh0gBIJUzQk0BupGNP4xbwe6cwYaha5TE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Ob1SvCTTb4/VmTKvkA5MopsDvWa1hlITjRvs2rQTSHgPxrFCmyW2weDoUcx+3oq1s
 N5H59aGL4NNvybkCBctnY8axVoMr1zsmr61ZETE82oFcbHQtQhUsShbLBKe7rof5DS
 cUbFTvxhTJO/tIDKeLBngakILe1EM97NlO7ROhd7ZJicGkp54qmrH6HNp10dakWnlR
 v86jpjO6pojIpB62qdI8VWgEM4DlYai5iF6mOkyp5DBWYatEn8lj2jZMfVRSUaFHye
 f/MYE6cN1nH6KAPrfv0uveCz9pVe4ZzNvNGMnINRSqahAmzJ+ojl9NRSvWl56UwJ6o
 udN+gv7Iilpiw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B324C803A3;
 Sun, 11 May 2025 02:01:17 -0400 (EDT)
Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 78F70120387;
 Sun, 11 May 2025 02:01:17 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <86h61r8zdx.fsf@HIDDEN>
Message-ID: <jwvh61r3cyh.fsf-monnier+emacs@HIDDEN>
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
 <86h61r8zdx.fsf@HIDDEN>
Date: Sun, 11 May 2025 02:01:16 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.090 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, 78262 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> > This assumes that everyone will want the same command bound to C-d
>> > globally to be invoked by C-d in comint-mode.  But is that assumption
>> > necessarily true?
>> 
>> It's hard to handle all possible worlds at the same time, so I think
>> we have to presume the answer is "yes".  If they want something
>> different, they'll have to rebind it explicitly in `comint-mode-map`.
>
> The issue here is whether to support active region (which C-d does).
> Are we sure users of comint want that in respective modes?

The default global binding of `C-d` does not obey `delete-active-region`.

>> -(defun comint-delchar-or-maybe-eof (arg)
>> -  "Delete ARG characters forward or send an EOF to subprocess.
>> +(defun comint-delchar-or-maybe-eof ()
>> +  "Do like the global binding or send an EOF to subprocess.
>
> I think we need to leave ARG in place, at least as an optional
> argument, since otherwise this would be a breaking change.

Fair enough,


        Stefan


diff --git a/lisp/comint.el b/lisp/comint.el
index 188989ff8a4..56e18ac829b 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2789,14 +2789,14 @@ comint-kill-input
     (if (> (point) (marker-position pmark))
 	(kill-region pmark (point)))))
 
-(defun comint-delchar-or-maybe-eof (arg)
-  "Delete ARG characters forward or send an EOF to subprocess.
+(defun comint-delchar-or-maybe-eof (&optional _arg)
+  "Do like the global binding or send an EOF to subprocess.
 Sends an EOF only if point is at the end of the buffer and there is no input."
-  (interactive "p" comint-mode)
+  (interactive nil comint-mode)
   (let ((proc (get-buffer-process (current-buffer))))
     (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
 	(comint-send-eof)
-      (delete-char arg))))
+      (call-interactively (lookup-key global-map (this-command-keys))))))
 
 (defun comint-send-eof ()
   "Send an EOF to the current buffer's process."
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 05:55:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 01:55:51 2025
Received: from localhost ([127.0.0.1]:56441 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDzfD-0004uR-Ih
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 01:55:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60602)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uDzfA-0004tj-Q7
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 01:55:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uDzf3-0001mu-3j; Sun, 11 May 2025 01:55:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=a/C8mrxDom0jS2Co3reRoqGQwrNVY9+Y4UpQ1cTFuRk=; b=Ks/t4EdmGg3s
 r2Fxt38JhU0HzVVAsYtcrIo8Pf1hmkF0vR/sZpKO1v3e6d468iFAe4yX/3Kiy4Vim76ERw/G94LSN
 2nABne2xaUKfSx+1e0EZ8e1HNNM6iFfQIlcDo5OTVQ5fTHKGeoAoEuVBQaZnAiwkQHu0k6hwUnnuM
 IVGZyHVpQy2Y/SXva3PZUmlhwqSDpAPweN23TGeQpnjYlntW970uk1Am7atGOLmfG1/uSrPZAA/yD
 8ZqW3PrQG05N0FnQsNVNLxK6l9OLJeSVXULsBcF5y2GZ8SMZPRL97m1Jy0eh/3lVe41WzPIjN8UaH
 c6JDxcBLB21CV1LR9L90dg==;
Date: Sun, 11 May 2025 08:55:38 +0300
Message-Id: <86h61r8zdx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwv34db4x9f.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Sun, 11 May 2025 00:14:16 -0400)
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN> <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, 78262 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Juri Linkov <juri@HIDDEN>,  sebastian@HIDDEN,
>   78262 <at> debbugs.gnu.org
> Date: Sun, 11 May 2025 00:14:16 -0400
> 
> > This assumes that everyone will want the same command bound to C-d
> > globally to be invoked by C-d in comint-mode.  But is that assumption
> > necessarily true?
> 
> It's hard to handle all possible worlds at the same time, so I think
> we have to presume the answer is "yes".  If they want something
> different, they'll have to rebind it explicitly in `comint-mode-map`.

The issue here is whether to support active region (which C-d does).
Are we sure users of comint want that in respective modes?

> -(defun comint-delchar-or-maybe-eof (arg)
> -  "Delete ARG characters forward or send an EOF to subprocess.
> +(defun comint-delchar-or-maybe-eof ()
> +  "Do like the global binding or send an EOF to subprocess.

I think we need to leave ARG in place, at least as an optional
argument, since otherwise this would be a breaking change.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 11 May 2025 04:14:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 11 00:14:29 2025
Received: from localhost ([127.0.0.1]:55444 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDy57-00067U-Dr
	for submit <at> debbugs.gnu.org; Sun, 11 May 2025 00:14:29 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59379)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1uDy54-00066m-5q
 for 78262 <at> debbugs.gnu.org; Sun, 11 May 2025 00:14:26 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 56ACD1000BC;
 Sun, 11 May 2025 00:14:19 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1746936857;
 bh=JzPICyLMblQgvJGYKqrw4x+Wtp9VQLIgJqlX+7bXniY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=hP+mouTVX5FVYM1hptCURQhJID2v5jgYvCZSvEg0qlQdWYN6AWSXOHOun3fqkod/l
 raVyB8yckZ8mZyZkJomysOX4NxQVebODE5sDy70ILYIQ6rOeLZNg5MxbZ1qfe9/aGO
 dWO1l5cHbRE3U7Uu3UV6b4ojYw4pbd8zbGFOBR1eSmhVLi0qC+JCB7hmEMVUi8+Gqr
 3QSdsCkwjo1engU4IStl03S692E5Hihx3nSANKQj54kyOnNH3NyC7ztstLCutg0sT8
 fzMQPQ49br9zZ4hWYxacj2g8KcWevHxlhXHkRkq9CGvwTk5VFvH9rHn8c6uRa65Byq
 Cdl29CZ9YyLpQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CCCA1100034;
 Sun, 11 May 2025 00:14:17 -0400 (EDT)
Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 94234120387;
 Sun, 11 May 2025 00:14:17 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <86zffk90od.fsf@HIDDEN>
Message-ID: <jwv34db4x9f.fsf-monnier+emacs@HIDDEN>
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
 <86zffk90od.fsf@HIDDEN>
Date: Sun, 11 May 2025 00:14:16 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.205 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, 78262 <at> debbugs.gnu.org,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Does the solution proposed by Augusto in bug#73527 fix your use case?
>> 
>> diff --git a/lisp/comint.el b/lisp/comint.el
>> index 188989ff8a4..2189b10e826 100644
>> --- a/lisp/comint.el
>> +++ b/lisp/comint.el
>> @@ -2796,7 +2796,7 @@ comint-delchar-or-maybe-eof
>>    (let ((proc (get-buffer-process (current-buffer))))
>>      (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
>>  	(comint-send-eof)
>> -      (delete-char arg))))
>> +      (funcall-interactively (keymap-lookup global-map "C-d") arg))))

I'd rather not make assumptions about what arguments that command takes
(i.e. use `call-interactively`, as in the code below).

> This assumes that everyone will want the same command bound to C-d
> globally to be invoked by C-d in comint-mode.  But is that assumption
> necessarily true?

It's hard to handle all possible worlds at the same time, so I think
we have to presume the answer is "yes".  If they want something
different, they'll have to rebind it explicitly in `comint-mode-map`.

Similarly, we could worry about the case where `C-d` is globally bound
to something that's completely different from some kind of "delete
char" command, in which case turning it into an "EOF" signal may make
very little sense, but there's not much we can do about that: the usual
way to accommodate that is to rely on `remap` instead but here we can't
do that because we specifically want to handle `C-d` bindings
differently from other bindings (e.g. `delete`) to the same command.


        Stefan


diff --git a/lisp/comint.el b/lisp/comint.el
index 188989ff8a4..35765c8427e 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2789,14 +2789,14 @@ comint-kill-input
     (if (> (point) (marker-position pmark))
 	(kill-region pmark (point)))))
 
-(defun comint-delchar-or-maybe-eof (arg)
-  "Delete ARG characters forward or send an EOF to subprocess.
+(defun comint-delchar-or-maybe-eof ()
+  "Do like the global binding or send an EOF to subprocess.
 Sends an EOF only if point is at the end of the buffer and there is no input."
-  (interactive "p" comint-mode)
+  (interactive nil comint-mode)
   (let ((proc (get-buffer-process (current-buffer))))
     (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
 	(comint-send-eof)
-      (delete-char arg))))
+      (call-interactively (lookup-key global-map (this-command-keys))))))
 
 (defun comint-send-eof ()
   "Send an EOF to the current buffer's process."
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 10 May 2025 11:15:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 10 07:15:43 2025
Received: from localhost ([127.0.0.1]:44549 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDiBC-0006Az-Tw
	for submit <at> debbugs.gnu.org; Sat, 10 May 2025 07:15:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48978)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uDiBA-0006Al-Rd
 for 78262 <at> debbugs.gnu.org; Sat, 10 May 2025 07:15:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uDiB3-0004Sp-Vl; Sat, 10 May 2025 07:15:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=O4TtQUgFGMFesaGPAIg4PlFG+gvsb81ZKUTlQLd806s=; b=HEqYdHoCS+yo
 6z9mC8qUxnEOtpkWWmBEUfHCjRWCMvWyMih04pq0Fus4KkOC9KNooqWN21SKP0OP1F6ptObMtr+7Y
 omAd7PtuNb7BTeY/Lr26JB8ryyqk6OvQ5yd1l+U8OhYNVY9coTL3pnaWaJilAyg7m+AHQQAszL27k
 9gTITXa7hlvsApazc2QFzq4Ce8CSP3aBTQr/KQEa8+Ub845bw7lma8CklpxpfkpIoS9dyX/7Y3HFs
 7Su59PPm0ZME9Fzisfq9+6RzNnzb7TJm0fCxj0MwpzFNkI1FX26kPuvYw38rIyfWxXxi3NHZOZ9Ug
 c9/bXYWiUHj4wLSrGfrHKQ==;
Date: Sat, 10 May 2025 14:15:30 +0300
Message-Id: <86zffk90od.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <87h61ujmy5.fsf@HIDDEN> (message from Juri Linkov on
 Fri, 09 May 2025 09:52:02 +0300)
Subject: Re: bug#78262: 30.1;
 comint-delchar-or-maybe-eof doesn't respect delete-active-region
References: <thqnzffrt8wg.fsf@HIDDEN> <87h61ujmy5.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: sebastian@HIDDEN, 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 78262 <at> debbugs.gnu.org
> From: Juri Linkov <juri@HIDDEN>
> Date: Fri, 09 May 2025 09:52:02 +0300
> 
> > Comint and its derived modes override C-d 'delete-forward-char' with
> > 'comint-delchar-or-maybe-eof'.
> 
> Does the solution proposed by Augusto in bug#73527 fix your use case?
> 
> diff --git a/lisp/comint.el b/lisp/comint.el
> index 188989ff8a4..2189b10e826 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -2796,7 +2796,7 @@ comint-delchar-or-maybe-eof
>    (let ((proc (get-buffer-process (current-buffer))))
>      (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
>  	(comint-send-eof)
> -      (delete-char arg))))
> +      (funcall-interactively (keymap-lookup global-map "C-d") arg))))
>  
>  (defun comint-send-eof ()
>    "Send an EOF to the current buffer's process."

This assumes that everyone will want the same command bound to C-d
globally to be invoked by C-d in comint-mode.  But is that assumption
necessarily true?

Stefan, WDYT?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 9 May 2025 06:53:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 09 02:53:16 2025
Received: from localhost ([127.0.0.1]:34795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uDHbg-0008BV-7P
	for submit <at> debbugs.gnu.org; Fri, 09 May 2025 02:53:16 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:40581)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uDHbd-0008BB-A7
 for 78262 <at> debbugs.gnu.org; Fri, 09 May 2025 02:53:14 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 69D6B1FCE7;
 Fri,  9 May 2025 06:53:03 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= <sebastian@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <thqnzffrt8wg.fsf@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN>
Date: Fri, 09 May 2025 09:52:02 +0300
Message-ID: <87h61ujmy5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvleduleehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejkedviedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhm
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Comint and its derived modes override C-d 'delete-forward-char' with
> 'comint-delchar-or-maybe-eof'.

Does the solution proposed by Augusto in bug#73527 fix your use case?

diff --git a/lisp/comint.el b/lisp/comint.el
index 188989ff8a4..2189b10e826 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2796,7 +2796,7 @@ comint-delchar-or-maybe-eof
   (let ((proc (get-buffer-process (current-buffer))))
     (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
 	(comint-send-eof)
-      (delete-char arg))))
+      (funcall-interactively (keymap-lookup global-map "C-d") arg))))
 
 (defun comint-send-eof ()
   "Send an EOF to the current buffer's process."
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 8 May 2025 17:02:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 08 13:02:50 2025
Received: from localhost ([127.0.0.1]:59466 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uD4e1-0004kg-Pg
	for submit <at> debbugs.gnu.org; Thu, 08 May 2025 13:02:50 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:39105)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uD4dz-0004kR-6x
 for 78262 <at> debbugs.gnu.org; Thu, 08 May 2025 13:02:47 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id C4AB143A4E;
 Thu,  8 May 2025 17:02:39 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= <sebastian@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <thqnzffrt8wg.fsf@HIDDEN>
Organization: LINKOV.NET
References: <thqnzffrt8wg.fsf@HIDDEN>
Date: Thu, 08 May 2025 19:58:07 +0300
Message-ID: <87plgj59ws.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvledtvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejkedviedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhm
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Since comint-delchar-or-maybe-eof is meant for interactive use, maybe we
> should change the command:
>
> (defun comint-delchar-or-maybe-eof (arg)
>   "Delete ARG characters forward or send an EOF to subprocess.
> Sends an EOF only if point is at the end of the buffer and there is no input."
>   (interactive "p" comint-mode)
>   (let ((proc (get-buffer-process (current-buffer))))
>     (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
> 	(comint-send-eof)
>       ;; delete-char ==> delete-forward-char
>       (delete-forward-char arg nil))))

bug#73527 stumbled over this.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 8 May 2025 13:36:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 08 09:36:22 2025
Received: from localhost ([127.0.0.1]:55921 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uD1QE-0004jR-11
	for submit <at> debbugs.gnu.org; Thu, 08 May 2025 09:36:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:58828)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uD1QA-0004j1-HZ
 for 78262 <at> debbugs.gnu.org; Thu, 08 May 2025 09:36:18 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uD1Q3-0003gx-Ln; Thu, 08 May 2025 09:36:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=oj/cUrbxXr+Wkc1ixVQYA3Wua6zygWGc+riRUeE7boc=; b=CqgyCqksTUItBvc01r0K
 nWDfqVey2d3cIrihtVqqNSPKnroHsK0TNuM4/lALvB2J1E4uGRXb+B8AFlJamM3g2Vvb3ULIIlThM
 aEDfQ4hC9fUQWiPeV31bzBY7rFIaso9yWhdM55o/6SdAyzOr7bTnw1M6LdltfKDWT4y/uOh9lfXSM
 lXtEjiiDb0aSWXxvedp7oeSMGPCtOp/I3UDdMfgJXlGyyfu4kimApHaLj5pBWIhHeCqbK5Su2600T
 giTxGYUzjaK7LY28JSaF0XMXm51KK/UPg/EgTEeKJupDq1bH4Uk8Erod7sYIqsvGfE0ibjXx8NEIH
 qhpujqtCjPLhCA==;
Date: Thu, 08 May 2025 16:36:02 +0300
Message-Id: <864ixvdy2l.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: =?utf-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= <sebastian@HIDDEN>
In-Reply-To: <871pszkzg0.fsf@HIDDEN> (message from =?utf-8?Q?Sebas?=
 =?utf-8?Q?ti=C3=A1n_Mon=C3=ADa?= on
 Thu, 08 May 2025 09:24:31 -0400)
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
References: <thqnzffrt8wg.fsf@HIDDEN> <86cycje6eb.fsf@HIDDEN>
 <871pszkzg0.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Sebastián Monía <sebastian@HIDDEN>
> Cc: 78262 <at> debbugs.gnu.org
> Date: Thu, 08 May 2025 09:24:31 -0400
> 
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> >> But maybe there's a reason it works like this, and my limited comint
> >> usage misses the point.
> >
> > I'm not a frequent user of comint-derived modes, but is this indeed
> > consistent with what users expect from interactive shells?  AFAIK,
> > shells don't support the notion of "active region" or
> > "delete-selection" or anything similar.  Wouldn't this change in
> > behavior surprise people?  Should we perhaps have it as an opt-in
> > behavior?
> 
> Well, that is a good point.
> The counterargument (emmm from blogs and reddit :) so take it with a
> grain of salt) is that the point of running shells inside Emacs is to
> have all the same editing capabilities, combined with the shell.
> 
> And another data point: I was suprised/annoyed that it didn't behave the
> same as any buffer.
> 
> But there's no harm in putting the new behavior behing a new defcustom
> comint-delete-active-region? 

Yes, that's what I meant by making it an opt-in behavior.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 8 May 2025 13:24:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 08 09:24:40 2025
Received: from localhost ([127.0.0.1]:55737 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uD1Et-0003aC-QC
	for submit <at> debbugs.gnu.org; Thu, 08 May 2025 09:24:40 -0400
Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:43161)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <sebastian@HIDDEN>)
 id 1uD1Er-0003Zx-Kp
 for 78262 <at> debbugs.gnu.org; Thu, 08 May 2025 09:24:38 -0400
Received: from phl-compute-04.internal (phl-compute-04.phl.internal
 [10.202.2.44])
 by mailfhigh.stl.internal (Postfix) with ESMTP id 2B22B25401A3;
 Thu,  8 May 2025 09:24:32 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
 by phl-compute-04.internal (MEProxy); Thu, 08 May 2025 09:24:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com;
 h=cc:cc:content-transfer-encoding:content-type:content-type
 :date:date:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:subject:subject:to:to; s=fm1;
 t=1746710672; x=1746797072; bh=ViBiYbVCvXab8aJOtCv3j9yZ66CZ/YCs
 uPUB4uomPzE=; b=TWO5V7ar6rjw0xijVg+Zr0uaBJJDbePr5L2FOyZ2bmnXpzFa
 BMMjO8k7SIpivhaON6C0JzN8DrPjRG5MiGs8hmoiLEeGLwwncvL7XTrfBF1XDobF
 uMuUjMrRjj8lWGn6kYZMxCZDNDKnnjZ4sQRqDFotsDRqjeV25G+rSj0t1o/2Jfjd
 k+JGE7U3RgLeXhBFQ5DBzZQSnSxwNsKXcCBTnL7Z9Dsdg2mtFizHtDZ3m33zPGHn
 VrpEqjcug3bHjSxocKYh4UIsqqfXO1+l1EBFx9keNCtV0Djo/eaSGbSgqKZg6zOb
 QnPlzMSGefNt9ayYO0DJrI4a7mBrcWR9EeqdeA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1746710672; x=
 1746797072; bh=ViBiYbVCvXab8aJOtCv3j9yZ66CZ/YCsuPUB4uomPzE=; b=a
 1EItuqYJKQcT/zp4YJdnynv/+ow2OTlGZSXum319QDmxxWW/tQy7peSGnB99NO9v
 Ob8T4kHTgKINNj4538mgTV++E6WtgrP3VMKgDdSJ2/4LmMqdpn69vQ4P5tozm0J1
 pGNcJJMglNwBrG56tJCgYaeCVHPlzfPVtA/X0jka2AylzHaue5hy+A2q31zf2FtX
 MinYL54FczEBhI7uTTdDYeAhSdX2hWHutiXc32+OeCg7SXjphk8Y7/gLkB7HUpwD
 Ijtx42fyvtNWtfU6mWa/ScdjkjaP1uLwVPqKddQ/8+7K8hen7hDiPXUYuBbIwjvV
 1NqlPMf3utm5krm5BTSkg==
X-ME-Sender: <xms:j7AcaNTWM_6h0gd4qQ4i_bg6licsfenRbessY2rpBOsGtGqE1d1TqA>
 <xme:j7AcaGwMe_rIz62gAERQZCEIFhrGEnwg7u1x23Aip8BD5pMpRk7cbCCbllRaYt9Xp
 89tUJzlRPjs8SLm5Vg>
X-ME-Received: <xmr:j7AcaC2qfUYTaF7kLAsNOEvzB1-2fR7ye0Qoim98Q7BhShfciR3JqVrGNbTrHgrZMBADST6Jhb9j18NNJtFMM8i0oO_1lHCn33Gz2HAq6Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvkeelkeehucetufdoteggodetrf
 dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv
 pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih
 gvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddt
 reejnecuhfhrohhmpefuvggsrghsthhijohnucfoohhnvogruceoshgvsggrshhtihgrnh
 esshgvsggrshhmohhnihgrrdgtohhmqeenucggtffrrghtthgvrhhnpeekteetkeegvdeg
 heevledtuefhvefggfekheekfeetveekieehieevtdethfeludenucffohhmrghinhepsh
 gvsggrshhmohhnihgrrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
 pehmrghilhhfrhhomhepshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmpd
 hnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeejkedv
 iedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurd
 horhhg
X-ME-Proxy: <xmx:j7AcaFBPxRbcbW2PKkft8LhlSLu2ff9sjA3rHy3-yCkS8IiXeAqAsA>
 <xmx:j7AcaGhpSLGrD-ugEwFj0Z_T2Z7sDG6Acxo-y8Xar7cfVbob3XuYyg>
 <xmx:j7AcaJrtTmerIn38CQRbeFynLfZ8Bdts1RKsLfgc0xoFoxICSe-uAw>
 <xmx:j7AcaBgYqe5r9-PDapSZ4J-jF0hhGY1YRIGWNvIJQ_w6MHMzp4acKA>
 <xmx:kLAcaG6u9yQ8orouulvgIix7VKyeYNg_IYAg5U5o90sK_bkDC43RN2bq>
Feedback-ID: iab2c46da:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 8 May 2025 09:24:31 -0400 (EDT)
From: =?utf-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= <sebastian@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
In-Reply-To: <86cycje6eb.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 08 May
 2025 13:36:12 +0300")
References: <thqnzffrt8wg.fsf@HIDDEN> <86cycje6eb.fsf@HIDDEN>
Date: Thu, 08 May 2025 09:24:31 -0400
Message-ID: <871pszkzg0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78262
Cc: 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


Eli Zaretskii <eliz@HIDDEN> writes:
>> But maybe there's a reason it works like this, and my limited comint
>> usage misses the point.
>
> I'm not a frequent user of comint-derived modes, but is this indeed
> consistent with what users expect from interactive shells?  AFAIK,
> shells don't support the notion of "active region" or
> "delete-selection" or anything similar.  Wouldn't this change in
> behavior surprise people?  Should we perhaps have it as an opt-in
> behavior?

Well, that is a good point.
The counterargument (emmm from blogs and reddit :) so take it with a
grain of salt) is that the point of running shells inside Emacs is to
have all the same editing capabilities, combined with the shell.

And another data point: I was suprised/annoyed that it didn't behave the
same as any buffer.

But there's no harm in putting the new behavior behing a new defcustom
comint-delete-active-region?=20


--=20
Sebasti=C3=A1n Mon=C3=ADa
https://site.sebasmonia.com/
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at 78262 <at> debbugs.gnu.org:


Received: (at 78262) by debbugs.gnu.org; 8 May 2025 10:36:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 08 06:36:25 2025
Received: from localhost ([127.0.0.1]:54580 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uCyc4-00078b-JG
	for submit <at> debbugs.gnu.org; Thu, 08 May 2025 06:36:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39008)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uCyc1-000786-EW
 for 78262 <at> debbugs.gnu.org; Thu, 08 May 2025 06:36:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uCybv-0006PF-PD; Thu, 08 May 2025 06:36:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=3uyhZtRBvMQCc86itv8Qu7eOwhTwwiPrD93t/D37iMA=; b=On6C4tbU3gR6goGmJsSX
 obU+hBBhaW4V8cD9Dbx+q3cWcrL8WHSaqsMHNAaSJTMDPXsqbbW0y1n270G5PlgVVXxGGqpfVnoTL
 ++OWfwGXA74cshAzpwGAjJB0hjzdVUlK/wbjGJezQmZOxT0uwylQkFtsNDuI25U0a6FfTZuekvfIE
 hkxjknJPENcbyalFJSFJ6W6xmBcZeipwWuibDGlN8Fwo4YMP6d65ySzxwX2uKPqRfPNmOxa1GE3NB
 XEh1pnBoMiQ0M7UN2GSizfkBe610rtmelL39twkTHkv5ejIoPdllVmeYfR/FkEJb/zQgvQm93RMzW
 OYekVsPMWTbo1A==;
Date: Thu, 08 May 2025 13:36:12 +0300
Message-Id: <86cycje6eb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= <sebastian@HIDDEN>
In-Reply-To: <thqnzffrt8wg.fsf@HIDDEN> (sebastian@HIDDEN)
Subject: Re: bug#78262: 30.1;
 comint-delchar-or-maybe-eof doesn't respect delete-active-region
References: <thqnzffrt8wg.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78262
Cc: 78262 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Sebastián Monía
>  <sebastian@HIDDEN>
> Date: Mon, 05 May 2025 10:43:59 -0400
> 
> Noticed this in SQL Interactive mode, but just tested in M-x shell and
> the same thing happens.
> Comint and its derived modes override C-d 'delete-forward-char' with
> 'comint-delchar-or-maybe-eof'.
> 
> The latter internally uses delete-char, which doesn't respect
> delete-active-region. The delete-char docstring states:
> 
> > The command 'delete-forward-char' is preferable for interactive use,
> > e.g. because it respects values of 'delete-active-region' and
> > 'overwrite-mode'.
> 
> Since comint-delchar-or-maybe-eof is meant for interactive use, maybe we
> should change the command:
> 
> (defun comint-delchar-or-maybe-eof (arg)
>   "Delete ARG characters forward or send an EOF to subprocess.
> Sends an EOF only if point is at the end of the buffer and there is no input."
>   (interactive "p" comint-mode)
>   (let ((proc (get-buffer-process (current-buffer))))
>     (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
> 	(comint-send-eof)
>       ;; delete-char ==> delete-forward-char
>       (delete-forward-char arg nil))))
> 
> If we are good with the change, I can send a proper patch with changelog
> etc. But maybe there's a reason it works like this, and my limited
> comint usage misses the point.

I'm not a frequent user of comint-derived modes, but is this indeed
consistent with what users expect from interactive shells?  AFAIK,
shells don't support the notion of "active region" or
"delete-selection" or anything similar.  Wouldn't this change in
behavior surprise people?  Should we perhaps have it as an opt-in
behavior?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 May 2025 14:44:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 05 10:44:21 2025
Received: from localhost ([127.0.0.1]:41428 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uBx3N-0002uq-4v
	for submit <at> debbugs.gnu.org; Mon, 05 May 2025 10:44:21 -0400
Received: from lists.gnu.org ([2001:470:142::17]:54540)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <sebastian@HIDDEN>)
 id 1uBx3K-0002uV-1d
 for submit <at> debbugs.gnu.org; Mon, 05 May 2025 10:44:18 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sebastian@HIDDEN>)
 id 1uBx39-000152-51
 for bug-gnu-emacs@HIDDEN; Mon, 05 May 2025 10:44:08 -0400
Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sebastian@HIDDEN>)
 id 1uBx35-0004YI-Iu
 for bug-gnu-emacs@HIDDEN; Mon, 05 May 2025 10:44:06 -0400
Received: from phl-compute-04.internal (phl-compute-04.phl.internal
 [10.202.2.44])
 by mailfhigh.stl.internal (Postfix) with ESMTP id 8A93A2540289
 for <bug-gnu-emacs@HIDDEN>; Mon,  5 May 2025 10:44:00 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
 by phl-compute-04.internal (MEProxy); Mon, 05 May 2025 10:44:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com;
 h=cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:message-id:mime-version:reply-to
 :subject:subject:to:to; s=fm1; t=1746456240; x=1746542640; bh=r0
 V8Rr4sMuYttEEwa+kracRv5yGRB3iY1cYPGsVmrnU=; b=r63c8UFRR8hUf/HwKD
 XnqsSBknb6xwXJwoEKHwSKFQPtSADJhueOuWKfM6jZq5VpI/t8dXlaNZXRdFV5V1
 y+bRHkCyjr4jOPuvw1qXfneSwxlJWzSNSNn4qedNoENmQdoS7Q8oKgVcQCf9arHW
 xYxi27UlT0MMy7FcNb+vv7ispmcIrTBR6GMdi4oUNgz9VfD7xhJrh8QgPfzBxg9c
 LVyZdNo52tZZqwx3C5b+YT6Axbovw6+kGIq+gT91WwMbV0iE3vlz/brlbhbF2vZT
 DiZXz6+F1+K+uz6G4mOZrJa+Y4aMulUK+0fyggT20L2KIoBd5+82DOV9S/h1A3r9
 EDng==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:message-id:mime-version:reply-to:subject:subject:to
 :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1746456240; x=1746542640; bh=r0V8Rr4sMuYttEEwa+kracRv5yGRB3iY1cY
 PGsVmrnU=; b=Q/lKxgwxz42SCwjTLCUyGeev1AZf9arexVbSiL3E4qkUDWq0o45
 AqMIxXw8h9/m3xSpkZnDFXuQxQt47hDfLE2jMG7xb19DzukrusXOFJkZs9okYBJj
 DFc3kj/slq1N6BfWJmautOTWpHIQQDo1P3txYKWMNglu2H+wFsRpBtkXlgNMuI0e
 MoyBWLBqwAJnGTVXX5wkmnM6aiZ6VCtRE7fGTB/iP4iMpz9rMrx/2/ZndXYJe2Lh
 kK1iLbKmbbrUoy4tstT4YvNEmC5i09v2hcEdn/oykFUJA3ku34fI+Rw2MDjDavu6
 a2Ayc7I6Wrb8IAtWpW1QwZPdBM0IVuLQ6yw==
X-ME-Sender: <xms:sM4YaOsBo3DHQSGdtYUwZmuohJPrLTgP7qA65tcV06Uwzg8sczYR5g>
 <xme:sM4YaDcPuz818LNoXNhQyzAslugeDPas4k23asj-sC4D9v7Cjh7qHVL6wgFaC-xLX
 0N3Nx7SuoRSkkDZHj0>
X-ME-Received: <xmr:sM4YaJw8ZeIJG-lYmK5udyFwYCxqyh7rPAzLazObQkJePGeJXrigBk6YikP12IAZ6Vh->
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvkedufeejucetufdoteggodetrf
 dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv
 pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvf
 fufffkfgggtgfgsehtqhertddtredunecuhfhrohhmpefuvggsrghsthhijohnucfoohhn
 vogruceoshgvsggrshhtihgrnhesshgvsggrshhmohhnihgrrdgtohhmqeenucggtffrrg
 htthgvrhhnpeegudeuvedtlefftdfgvdeujeefvddujeduheejvdeitdeitedtgefgueej
 tdelieenucffohhmrghinhepshgvsggrshhmohhnihgrrdgtohhmnecuvehluhhsthgvrh
 fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgvsggrshhtihgrnhesshgv
 sggrshhmohhnihgrrdgtohhmpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpoh
 huthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg
X-ME-Proxy: <xmx:sM4YaJNiQsb2kJgivuaiU3IHV5jMl0d5GodGLSbJprP8b1jyno7rNw>
 <xmx:sM4YaO_Om6QOR73JphDuGcDD6WraHxALOY7evddNTnfstOjUT_B8cA>
 <xmx:sM4YaBVyfJlc3-Hz4dF9yZkNrEKtX3jb18KTMR7VMk8xipVmMvEsIA>
 <xmx:sM4YaHcCdfwUk3VndW5AvVwjmhzJ-j9n1QRCHbjHDr86c6oWsqqzpQ>
 <xmx:sM4YaDPV8hsTll74x7-RocjopWwSnodjbTWo6lMtDqun4a2Ap5wqtUP8>
Feedback-ID: iab2c46da:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Mon, 5 May 2025 10:44:00 -0400 (EDT)
From: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= <sebastian@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.1; comint-delchar-or-maybe-eof doesn't respect delete-active-region
X-Debbugs-Cc: 
Date: Mon, 05 May 2025 10:43:59 -0400
Message-ID: <thqnzffrt8wg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=202.12.124.153;
 envelope-from=sebastian@HIDDEN; helo=fhigh-b2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)


Hello!

Noticed this in SQL Interactive mode, but just tested in M-x shell and
the same thing happens.
Comint and its derived modes override C-d 'delete-forward-char' with
'comint-delchar-or-maybe-eof'.

The latter internally uses delete-char, which doesn't respect
delete-active-region. The delete-char docstring states:

> The command 'delete-forward-char' is preferable for interactive use,
> e.g. because it respects values of 'delete-active-region' and
> 'overwrite-mode'.

Since comint-delchar-or-maybe-eof is meant for interactive use, maybe we
should change the command:

(defun comint-delchar-or-maybe-eof (arg)
  "Delete ARG characters forward or send an EOF to subprocess.
Sends an EOF only if point is at the end of the buffer and there is no inpu=
t."
  (interactive "p" comint-mode)
  (let ((proc (get-buffer-process (current-buffer))))
    (if (and (eobp) proc (=3D (point) (marker-position (process-mark proc))=
))
	(comint-send-eof)
      ;; delete-char =3D=3D> delete-forward-char
      (delete-forward-char arg nil))))

If we are good with the change, I can send a proper patch with changelog
etc. But maybe there's a reason it works like this, and my limited
comint usage misses the point.

Thanks,
Seb

In GNU Emacs 30.1 (build 2, x86_64-w64-mingw32) of 2025-02-23 built on
 AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.26100
System Description: Microsoft Windows 10 Enterprise (v10.0.2009.26100.3775)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation=3Daot
 --without-compress-install --with-tree-sitter CFLAGS=3D-O2
 prefix=3D/g/rel/install/emacs-30.1'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: Group

Minor modes in effect:
  gnus-undo-mode: t
  global-hl-line-mode: t
  csv-field-index-mode: t
  server-mode: t
  global-so-long-mode: t
  savehist-mode: t
  repeat-mode: t
  delete-selection-mode: t
  override-global-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
~/sourcehut/dotfiles/.config/emacs/custom hides c:/Users/SEBM/home/emacs/sh=
are/emacs/30.1/lisp/custom

Features:
(shadow gnus-cite mail-extr emacsbug nndraft nnmh utf-7 network-stream
nsm nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg
gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig nntp
gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud
nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range
message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader gnus-win cl-print two-column
tramp-cache time-stamp shortdoc help-fns radix-tree reveal epa-file epa
epg rfc6068 dired-aux gnus-dired tramp-sh find-dired yank-media
markdown-mode color noutline outline eglot external-completion jsonrpc
xref ert debug backtrace find-func filenotify flymake sql-datum sql view
smerge-mode diff python compat misearch multi-isearch sh-script smie
treesit executable conf-mode vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs
vc-rcs log-view pcvs-util vc-dir ewoc project appt
display-fill-column-indicator ws-butler comp-run comp-common hl-line
sc-init csv-mode sort tramp trampver tramp-integration files-x
tramp-message tramp-compat shell pcomplete parse-time iso8601
format-spec tramp-loaddefs cus-edit server ispell confluence-reader
derived pyvenv azcli jira-tools rx bookmark pp ghcli site cambalache
vtable mule-util smtpmail sendmail rfc2047 rfc2045 ietf-drums ecomplete
hoagie-theme so-long vundo pcase vc-git diff-mode track-changes vc
vc-dispatcher savehist warnings repeat proced notifications dbus imenu
grep compile cus-load eww xdg url-queue thingatpt shr pixel-fill kinsoku
url-file svg xml dom puny mm-url gnus nnheader gnus-util
text-property-search time-date mail-utils range wid-edit mm-util
mail-prsvr epg-config dired dired-loaddefs diary-lib diary-loaddefs
dabbrev comint ansi-osc ansi-color ring cal-menu calendar cal-loaddefs
advice browse-kill-ring delsel hoagie-notes hoagie-editing edmacro
kmacro cl-extra help-mode use-package use-package-ensure
use-package-delight use-package-diminish use-package-bind-key bind-key
easy-mmode use-package-core browse-kill-ring-autoloads
csv-mode-autoloads debbugs-autoloads markdown-mode-autoloads
package-lint-autoloads restclient-autoloads info sly-autoloads
vundo-autoloads ws-butler-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs icons password-cache json
subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel touch-screen dos-w32 ls-lisp
disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty
move-toolbar make-network-process native-compile emacs)

Memory information:
((conses 16 590368 54839) (symbols 48 29342 3)
 (strings 32 116770 7974) (string-bytes 1 3740680) (vectors 16 59811)
 (vector-slots 8 1491221 178508) (floats 8 584 498)
 (intervals 56 13505 1557) (buffers 992 46))

--=20
Sebasti=E1n Mon=EDa
https://site.sebasmonia.com/
Acknowledgement sent to Sebastián Monía <sebastian@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#78262; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 14 May 2025 06:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.