Received: (at 78273) by debbugs.gnu.org; 6 May 2025 11:20:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 06 07:20:29 2025 Received: from localhost ([127.0.0.1]:53905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uCGLd-000779-8J for submit <at> debbugs.gnu.org; Tue, 06 May 2025 07:20:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55138) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uCGLZ-00076B-S3 for 78273 <at> debbugs.gnu.org; Tue, 06 May 2025 07:20:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uCGLT-0000dj-MK; Tue, 06 May 2025 07:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zs8H2mxUVAgKpLt+1iikdl9Ok67Q56RU5qu3Sn84MT0=; b=BOApvgN7SM6wUxqmMQrO huA2jm1HCksQFdJG+MudioS+QRwD5r1wCiqoav9+Kru/POoBnjuAy4rhsRPY1u+AFZMLRMCFYDUha h0cikyijqmtBMJcTb11UwrVM4j1L12OTylzdyjaEBoPJpMPfiOhrM/Kbf3fjzLJv2s3SUh3W8si63 3mB9IEfVwFFsJtYGjkE7hkybWeiL5J1XVwL+q2tYdbbXv4H7doOJ2Hpxg5aWuIsvoik8ppBKSal79 ixd+fDFijkpyy8AsWYQ9bQOkI8LDjQnGreV2OmFmvaCDH4EoZlaiYrJIf1ve702X2qBvC+8SR8c0f Vo5/xxk3LXAnGA==; Date: Tue, 06 May 2025 14:20:16 +0300 Message-Id: <86ecx2gf4f.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Martin =?utf-8?B?xaBvxaFpxIc=?= <sosic.martin@HIDDEN>, Yuan Fu <casouri@HIDDEN>, Theodor Thornhill <theo@HIDDEN> In-Reply-To: <CAEd8W8xccPogoFi0+6BS+9_DvoSQjPewaa_sN_t1Sj1UQRh4yQ@HIDDEN> (message from Martin =?utf-8?B?xaBvxaFpxIc=?= on Mon, 5 May 2025 21:47:54 +0200) Subject: Re: bug#78273: I would like to contribute: jsdoc support in typescript-ts-mode References: <CAEd8W8xccPogoFi0+6BS+9_DvoSQjPewaa_sN_t1Sj1UQRh4yQ@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78273 Cc: 78273 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Martin Šošić <sosic.martin@HIDDEN> > Date: Mon, 5 May 2025 21:47:54 +0200 > > Hi, > I noticed there is no jsdoc support in typescript-ts-mode, and I would love to add a patch/PR to add it! I > already have a working solution: I found who that same support is implemented in js-ts-mode and slightly > modified it to work with typescript-ts-mode. Currently I apply that extra config in my init.el, but I imagine it > relatively straightforward from here to contribute it to typescript-ts-mode.el itself. > > More info can be found here on reddit where I asked for help, got it, and then I edited the answer to contain > the full solution: > https://www.reddit.com/r/emacs/comments/1kfblch/need_help_with_adding_jsdoc_highlighting_to/ . > > I would appreciate any direction on how to go about this: I have been programming for 20 years but I never > used a mailing list and am not sure what is the etiquette / right way to handle this! Thank you for your interest in Emacs. I think the next steps would be: . post here a patch relative to typescript-ts-mode.el as we have it on the master branch of the Emacs Git repository, so people could review your changes and suggest improvements if needed . start your legal paperwork of assigning to FSF the copyright for your changes -- contributions of this size cannot be accepted without the assignment The last point is actually the first one you should consider. If you are okay with assigning the copyright to the FSF, I will send you the form to fill and the instructions to go with it, so you could start the paperwork rolling; then you can post the patches even before the process is completed (but we will wait for it to complete before we can install your changes). If for some reason you are unwilling or unable to assign the copyright, then your code will have to be a separate package, perhaps part of Non-GNU ELPA, not an integral part of typescript-ts-mode.el that comes with Emacs.
bug-gnu-emacs@HIDDEN:bug#78273; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 6 May 2025 03:43:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 05 23:43:03 2025 Received: from localhost ([127.0.0.1]:45299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uC9Cu-0005gI-G9 for submit <at> debbugs.gnu.org; Mon, 05 May 2025 23:43:02 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51346) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <sosic.martin@HIDDEN>) id 1uC1na-0005mQ-Nf for submit <at> debbugs.gnu.org; Mon, 05 May 2025 15:48:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sosic.martin@HIDDEN>) id 1uC1nR-000187-I2 for bug-gnu-emacs@HIDDEN; Mon, 05 May 2025 15:48:14 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <sosic.martin@HIDDEN>) id 1uC1nO-0004RJ-Lg for bug-gnu-emacs@HIDDEN; Mon, 05 May 2025 15:48:12 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5f728aeedacso7098495a12.2 for <bug-gnu-emacs@HIDDEN>; Mon, 05 May 2025 12:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746474486; x=1747079286; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=F3ixCtowDpGghcE0ZvsntNmcQ8Rnu+O3og8sfSby6L8=; b=SB1X5Q72JulL9Qz+v9AMMxprfQYfdL0fQY9Otyjb8Uf+qPJp8I2IzdS6dAS8qfShsx XAlROFsh4tVrR89tJSZhZIOM7UtyRfF8vS5Xp5YXDo/atu6NwrQq6h7ylt7TYy5Movt2 o6URo5s0XY5yh3gsVWMXfG0WoCsowFDnShJxQ23FFHgtZxXlD4OGUl8njBTSnpaAKaGG EzaDk/rqTBkJzIb7L+bFA54EYGDjM2X4guma4wTXybqAysFP8l9wtE1L9fgst9XuZX1+ AJw/7nH8kOwXjAht3zSfUfxPJXVzZulJSBVF9RACOTOXgNpnBzho9vaBqFOi4KA47mja CVzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746474486; x=1747079286; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=F3ixCtowDpGghcE0ZvsntNmcQ8Rnu+O3og8sfSby6L8=; b=aSwz4cCzP8JQDpOPbkGZ/SKuWMZYSFRQ7dQjyROlhfkGHLDCTo0Fen5UnSWwaixs5m GrUAYC42uRPddN+UdGjVQafdbkNoSTg1GKpuE786jDmJBKVzBs4XxXIol2ElhQTjOt5j ANEe83ObF98tosXitOMPec7Nb3sByg5xzwDNDhwjR0cLhI+JFCr9JqJY6MtiBA/Zf4It nWI1PZnQ0HIDg19IuTA1ccHh9SMMbD3RT4YX13shvdD88hvt4nWTveqwNeTYmm/7jsmg bR/VnMoY9jCso/6Q7nP9+fgWFmtRFsP5aJ8alSp1EFTuwX4sHS6cE96Vi0Ta9lVC+JOn itIA== X-Gm-Message-State: AOJu0YzJdTbt+Y/uPNkq5P5ssz2WBLH3WvIrk6LvoIdwfAL3bwvJW6Oy yiDPV8/gb832EVbujrWcsgmhBnhnhOJCPzIqXH1XB5D8xgkKIIXT8qRyDXm1KcBfsu+81ySRsLC S00iPp1W6VkNkwmMedC3kx6qMl2mhy8Op X-Gm-Gg: ASbGncvhn3BSOXT0AH+HxGjPJRWu8Gw1au5CzYA/UovcQiKzqYoiR7kFcBcAZFwORP4 bCCiRWE42NyQfT52KT9odEdL0DBtS75ZwoaNxmfAhw77pHNdnK5bZcilG+0lTiEGAQnT8pnef2b 4j3m+uqz8Wra6cY6Biex9PlanNbpd6m4s= X-Google-Smtp-Source: AGHT+IG/weIDCMKofXHaF/JV/hWFNNGB4BpBOWxsNreA/r03sbzU7QY9lhv3jnD6pY9hHdxzyAA2ygCLzEcPpbUQjBQ= X-Received: by 2002:a05:6402:4309:b0:5f3:81a0:c3d7 with SMTP id 4fb4d7f45d1cf-5fab05c2652mr7346999a12.22.1746474485605; Mon, 05 May 2025 12:48:05 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?TWFydGluIMWgb8WhacSH?= <sosic.martin@HIDDEN> Date: Mon, 5 May 2025 21:47:54 +0200 X-Gm-Features: ATxdqUFs6hzhyRBZWJWy3c1XqIhUlkTIk5hMF6OpzqJXe2NFm2d6aDRtn4S2EB0 Message-ID: <CAEd8W8xccPogoFi0+6BS+9_DvoSQjPewaa_sN_t1Sj1UQRh4yQ@HIDDEN> Subject: I would like to contribute: jsdoc support in typescript-ts-mode To: bug-gnu-emacs@HIDDEN Content-Type: multipart/alternative; boundary="00000000000052ec93063468c7be" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=sosic.martin@HIDDEN; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 05 May 2025 23:42:59 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --00000000000052ec93063468c7be Content-Type: text/plain; charset="UTF-8" Hi, I noticed there is no jsdoc support in typescript-ts-mode, and I would love to add a patch/PR to add it! I already have a working solution: I found who that same support is implemented in js-ts-mode and slightly modified it to work with typescript-ts-mode. Currently I apply that extra config in my init.el, but I imagine it relatively straightforward from here to contribute it to typescript-ts-mode.el itself. More info can be found here on reddit where I asked for help, got it, and then I edited the answer to contain the full solution: https://www.reddit.com/r/emacs/comments/1kfblch/need_help_with_adding_jsdoc_highlighting_to/ . I would appreciate any direction on how to go about this: I have been programming for 20 years but I never used a mailing list and am not sure what is the etiquette / right way to handle this! Thanks, Martin Sosic --00000000000052ec93063468c7be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi,<div>I noticed there is no jsdoc support in typescript-= ts-mode, and I would love to add a patch/PR to add it! I already have a wor= king solution: I found who that same support is implemented in js-ts-mode a= nd slightly modified it to work with typescript-ts-mode. Currently I apply = that extra config in my init.el, but I imagine it relatively straightforwar= d from here to contribute it to typescript-ts-mode.el itself.<br><br>More i= nfo can be found here on reddit where I asked for help, got it, and then I = edited the answer to contain the full solution:=C2=A0<a href=3D"https://www= .reddit.com/r/emacs/comments/1kfblch/need_help_with_adding_jsdoc_highlighti= ng_to/">https://www.reddit.com/r/emacs/comments/1kfblch/need_help_with_addi= ng_jsdoc_highlighting_to/</a> .</div><div><br></div><div>I would appreciate= any direction on how to go about this: I have been programming for 20 year= s but I never used a mailing list and am not sure what is the etiquette=C2= =A0/ right way to handle this!</div><div><br></div><div>Thanks,</div><div>M= artin Sosic</div></div> --00000000000052ec93063468c7be--
Martin Šošić <sosic.martin@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#78273; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.