Received: (at 78291) by debbugs.gnu.org; 7 Jun 2025 08:33:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 07 04:33:11 2025 Received: from localhost ([127.0.0.1]:46767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uNozG-0005FY-TM for submit <at> debbugs.gnu.org; Sat, 07 Jun 2025 04:33:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44334) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uNozE-0005FF-4O for 78291 <at> debbugs.gnu.org; Sat, 07 Jun 2025 04:33:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uNoz8-0004TL-5T; Sat, 07 Jun 2025 04:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6Ub9SVJ85FVoKLmwoMWqSMb2arCPL1SingpwjjoRByg=; b=o6eliP/o69g0 LYln0Qeb+4N60aPZ4WvcVy8fvmnFQdZ034kIf0aS59ocYJl3oD5jiU3K36pWsgYQuu+mIk0tyqv3m OGhTbxz8loqQawqQHc9hjfMkoL181Noi81UueCxhV33VKgO1GIBRRvE+EI6etluCqTQOamVJ7d1Si VMWBvCXT+GtWT46kiwmgt0xe1fVmaBDu5HxLNTm23scPwOBx3B+B47Qbj5FyrNvhhu80c3cJG6q7p Dgac6A0yYBwt6KvoAQJDwKcBjQk2a2EZXWUBeuFDXIXhX90oIbMu5Zn1VyH3EjMQQcsYk5uGqHIFC iqM7szuzw0hMmcO9fuCHXA==; Date: Sat, 07 Jun 2025 11:32:59 +0300 Message-Id: <864iwsj6is.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: monnier@HIDDEN, Zach Shaftel <zach@HIDDEN> In-Reply-To: <875xhp6yzn.fsf@HIDDEN> (message from Zach Shaftel on Sun, 25 May 2025 01:27:56 -0400) Subject: Re: bug#78291: [PATCH] Add new gv place definitions References: <87ikmdcce1.fsf@HIDDEN> <jwvselg4h5t.fsf-monnier+emacs@HIDDEN> <87jz6kxvfq.fsf@HIDDEN> <86tt5a1iki.fsf@HIDDEN> <875xhp6yzn.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78291 Cc: 78291 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Zach Shaftel <zach@HIDDEN> > Cc: monnier@HIDDEN, 78291 <at> debbugs.gnu.org > Date: Sun, 25 May 2025 01:27:56 -0400 > > an updated patch without the `lookup-key' definition is attached. Stefan, are you okay with this updated version?
bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.Received: (at 78291) by debbugs.gnu.org; 25 May 2025 05:28:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 25 01:28:17 2025 Received: from localhost ([127.0.0.1]:40740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uJ3uD-0001Oc-BB for submit <at> debbugs.gnu.org; Sun, 25 May 2025 01:28:17 -0400 Received: from smtp.forwardemail.net ([149.28.215.223]:14431) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <SRS0=8d4e=YJ=shaf.tel=zach@HIDDEN>) id 1uJ3u7-0001Nx-Mz for 78291 <at> debbugs.gnu.org; Sun, 25 May 2025 01:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shaf.tel; h=Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From; q=dns/txt; s=fe-acc5b42812; t=1748150885; bh=PY1GzNkei1bEhkXsM22yX28VHLDtvSIB47dACBVzi8E=; b=UADfPUuNRDJcVq95PxLkNuvkWRHd6eXYRn8graaRKbhoHHOGc1LGUxCqwpQpLdIyh14rfCcBJ IssL7/7tICBN94P09gtZ74Fnj6xCxCKi04zC2Tveb63ak2yLm0JVfbqU2vSlbiPPfx7UNY7AXxZ 2FVdwPc0VY58L2SZr0lnFtM= X-Forward-Email-ID: 6832aa60381421ad6cb1a82f X-Forward-Email-Sender: rfc822; zach@HIDDEN, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 1.0.3 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@HIDDEN X-Report-Abuse: abuse@HIDDEN X-Report-Abuse-To: abuse@HIDDEN From: Zach Shaftel <zach@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#78291: [PATCH] Add new gv place definitions In-Reply-To: <86tt5a1iki.fsf@HIDDEN> References: <87ikmdcce1.fsf@HIDDEN> <jwvselg4h5t.fsf-monnier+emacs@HIDDEN> <87jz6kxvfq.fsf@HIDDEN> <86tt5a1iki.fsf@HIDDEN> User-Agent: mu4e 1.12.9; emacs 31.0.50 Date: Sun, 25 May 2025 01:27:56 -0400 Message-ID: <875xhp6yzn.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78291 Cc: 78291 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain an updated patch without the `lookup-key' definition is attached. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-new-gv-place-definitions.patch Content-Description: new patch From 6a28665d167af250521bfe64b63bc41dc40b19b2 Mon Sep 17 00:00:00 2001 From: Zach Shaftel <zach@HIDDEN> Date: Sun, 25 May 2025 01:11:27 -0400 Subject: [PATCH] Add new gv place definitions * lisp/emacs-lisp/gv.el (char-table-extra-slot, char-table-parent) (default-toplevel-value, marker-insertion-type, process-plist) (process-query-on-exit-flag, process-thread, lookup-key) (window-prev-buffers, window-next-buffers, window-new-normal, font-get) (charset-plist, get-charset-property): Add gv-setters. (terminal-parameter): Fix the return value. --- lisp/emacs-lisp/gv.el | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el index 6c949f1016b..b6c1f2c9f9f 100644 --- a/lisp/emacs-lisp/gv.el +++ b/lisp/emacs-lisp/gv.el @@ -367,6 +367,8 @@ 'gv-place (gv-define-simple-setter aref aset) (gv-define-simple-setter char-table-range set-char-table-range) +(gv-define-simple-setter char-table-extra-slot set-char-table-extra-slot) +(gv-define-simple-setter char-table-parent set-char-table-parent) (gv-define-simple-setter car setcar) (gv-define-simple-setter cdr setcdr) ;; FIXME: add compiler-macros for `cXXr' instead! @@ -400,10 +402,12 @@ symbol-value ;;; Elisp-specific generalized variables. (gv-define-simple-setter default-value set-default) +(gv-define-simple-setter default-toplevel-value set-default-toplevel-value t) (gv-define-simple-setter frame-parameter set-frame-parameter 'fix) -(gv-define-simple-setter terminal-parameter set-terminal-parameter) +(gv-define-simple-setter terminal-parameter set-terminal-parameter t) (gv-define-simple-setter keymap-parent set-keymap-parent) (gv-define-simple-setter match-data set-match-data 'fix) +(gv-define-simple-setter marker-insertion-type set-marker-insertion-type) (gv-define-simple-setter overlay-get overlay-put) (gv-define-setter overlay-start (store ov) (macroexp-let2 nil store store @@ -415,6 +419,9 @@ process-buffer (gv-define-simple-setter process-filter set-process-filter) (gv-define-simple-setter process-sentinel set-process-sentinel) (gv-define-simple-setter process-get process-put 'fix) +(gv-define-simple-setter process-plist set-process-plist) +(gv-define-simple-setter process-query-on-exit-flag set-process-query-on-exit-flag) +(gv-define-simple-setter process-thread set-process-thread) (gv-define-simple-setter window-parameter set-window-parameter) (gv-define-setter window-buffer (v &optional w) (macroexp-let2 nil v v @@ -427,6 +434,12 @@ window-dedicated-p (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v)) +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v)) +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v)) +(gv-define-simple-setter font-get font-put) +(gv-define-simple-setter charset-plist set-charset-plist) +(gv-define-simple-setter get-charset-property put-charset-property t) (gv-define-setter buffer-local-value (val var buf) (macroexp-let2 nil v val -- 2.49.0 --=-=-= Content-Type: text/plain Eli Zaretskii <eliz@HIDDEN> writes: > Ping! Can we please make some progress with this? > >> Cc: 78291 <at> debbugs.gnu.org >> Date: Tue, 13 May 2025 13:38:33 -0400 >> From: Zach Shaftel via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> >> @@ -427,6 +434,14 @@ window-dedicated-p >> >> (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) >> >> (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) >> >> (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) >> >> +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v)) >> >> +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v)) >> >> +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v)) >> >> +(gv-define-simple-setter font-get font-put) >> >> +(gv-define-simple-setter charset-plist set-charset-plist) >> >> +(gv-define-simple-setter get-charset-property put-charset-property t) >> >> +(gv-define-setter lookup-key (val keymap key &optional _accept-default) >> >> + `(define-key ,keymap ,key ,val)) >> > >> > I'd have to check some of them, but at least the last doesn't look like >> > a good idea to me, because they don't quite match. E.g. if you >> > >> > (define-key MAP KEY '(menu-item TEXT CMD)) >> > >> > The corresponding `lookup-key` will return just CMD rather than >> > (menu-item TEXT CMD). >> > >> > >> > Stefan >> >> yeah I knew that one was questionable, and considering the keymap-* >> functions are now the standard interface to key bindings it probably >> wouldn't get much use anyway. as far as i could tell, the other setters >> all accept the same values that the getter would return, but there may >> be other idiosyncrasies i'm not aware of. let me know what ought to be >> removed and i can submit a new patch. >> >> >> >> --=-=-=--
bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.Received: (at 78291) by debbugs.gnu.org; 24 May 2025 09:09:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 24 05:09:27 2025 Received: from localhost ([127.0.0.1]:56992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uIksh-0007mH-EH for submit <at> debbugs.gnu.org; Sat, 24 May 2025 05:09:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54762) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uIksf-0007lp-K5 for 78291 <at> debbugs.gnu.org; Sat, 24 May 2025 05:09:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uIksZ-0000wr-P9; Sat, 24 May 2025 05:09:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TuoZv/tRPZYs4P4HyZPwyhWYZ3sSA8+wBWyvxandq3s=; b=iOaLEsirwM4i +b/l10Xr4GcmlypciGkXkaurgLtp8nM3p1p7WUxLAl7nK4SsgP1340BEU2nUwBfalhzUYkzEZEcQW qHSg7q9HYmdVSIUyJHkWWcgj1Q97Qoxn2Hq1BqzGkbYP7DC2yG2IbLCIhPaDgJMFGjg9Ji+VLgZw5 02Iyej8BWgzE10THj8NvGDYMxRn8E/MeX97RnyYoBiHUHfweQ8afYEOpSu8B0wzhXc8KG/0UtSw76 MRhMxUcXxKeWlnFryPpBHsB/UxwU+D5RK4MdID3ILdEbpcMCl7w+DkxpbqeOTNLSCPwt0fLEhRIZi Elm9jQtILbcZo6297Yn1Sw==; Date: Sat, 24 May 2025 12:09:17 +0300 Message-Id: <86tt5a1iki.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: monnier@HIDDEN, Zach Shaftel <zach@HIDDEN> In-Reply-To: <87jz6kxvfq.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#78291: [PATCH] Add new gv place definitions References: <87ikmdcce1.fsf@HIDDEN> <jwvselg4h5t.fsf-monnier+emacs@HIDDEN> <87jz6kxvfq.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78291 Cc: 78291 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Can we please make some progress with this? > Cc: 78291 <at> debbugs.gnu.org > Date: Tue, 13 May 2025 13:38:33 -0400 > From: Zach Shaftel via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > >> @@ -427,6 +434,14 @@ window-dedicated-p > >> (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) > >> (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) > >> (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) > >> +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v)) > >> +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v)) > >> +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v)) > >> +(gv-define-simple-setter font-get font-put) > >> +(gv-define-simple-setter charset-plist set-charset-plist) > >> +(gv-define-simple-setter get-charset-property put-charset-property t) > >> +(gv-define-setter lookup-key (val keymap key &optional _accept-default) > >> + `(define-key ,keymap ,key ,val)) > > > > I'd have to check some of them, but at least the last doesn't look like > > a good idea to me, because they don't quite match. E.g. if you > > > > (define-key MAP KEY '(menu-item TEXT CMD)) > > > > The corresponding `lookup-key` will return just CMD rather than > > (menu-item TEXT CMD). > > > > > > Stefan > > yeah I knew that one was questionable, and considering the keymap-* > functions are now the standard interface to key bindings it probably > wouldn't get much use anyway. as far as i could tell, the other setters > all accept the same values that the getter would return, but there may > be other idiosyncrasies i'm not aware of. let me know what ought to be > removed and i can submit a new patch. > > > >
bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.Received: (at 78291) by debbugs.gnu.org; 13 May 2025 17:38:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 13 13:38:49 2025 Received: from localhost ([127.0.0.1]:33184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uEtaa-0006A1-T9 for submit <at> debbugs.gnu.org; Tue, 13 May 2025 13:38:49 -0400 Received: from smtp.forwardemail.net ([149.28.215.223]:7253) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <SRS0=e19a=X6=shaf.tel=zach@HIDDEN>) id 1uEtaX-00069c-Po for 78291 <at> debbugs.gnu.org; Tue, 13 May 2025 13:38:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shaf.tel; h=Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From; q=dns/txt; s=fe-acc5b42812; t=1747157920; bh=fEjrDcYa6j6UvgPuo03oUg5J2d5Yejbgfe7BKN+UGiY=; b=C52AfoIt0Y5vkj/Ez2T2EK5Poj70Skz+p4dXqeKT8Z+qaZfbQzp365KbAAKUqOXsZPZFDsVvV XsgKYCA6tklY0rURaWP+ioWVBRrqZvDBCeyRrf83w200xnHX5abqQCMsq4m/K8WOrf7aVjp+AqH P8KiOVBr/Il+KlkU5KnAk+I= X-Forward-Email-ID: 6823839d8f602e87dfe50ecb X-Forward-Email-Sender: rfc822; zach@HIDDEN, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 1.0.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@HIDDEN X-Report-Abuse: abuse@HIDDEN X-Report-Abuse-To: abuse@HIDDEN From: Zach Shaftel <zach@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#78291: [PATCH] Add new gv place definitions In-Reply-To: <jwvselg4h5t.fsf-monnier+emacs@HIDDEN> References: <87ikmdcce1.fsf@HIDDEN> <jwvselg4h5t.fsf-monnier+emacs@HIDDEN> User-Agent: mu4e 1.12.9; emacs 31.0.50 Date: Tue, 13 May 2025 13:38:33 -0400 Message-ID: <87jz6kxvfq.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78291 Cc: 78291 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) >> @@ -427,6 +434,14 @@ window-dedicated-p >> (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) >> (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) >> (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) >> +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v)) >> +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v)) >> +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v)) >> +(gv-define-simple-setter font-get font-put) >> +(gv-define-simple-setter charset-plist set-charset-plist) >> +(gv-define-simple-setter get-charset-property put-charset-property t) >> +(gv-define-setter lookup-key (val keymap key &optional _accept-default) >> + `(define-key ,keymap ,key ,val)) > > I'd have to check some of them, but at least the last doesn't look like > a good idea to me, because they don't quite match. E.g. if you > > (define-key MAP KEY '(menu-item TEXT CMD)) > > The corresponding `lookup-key` will return just CMD rather than > (menu-item TEXT CMD). > > > Stefan yeah I knew that one was questionable, and considering the keymap-* functions are now the standard interface to key bindings it probably wouldn't get much use anyway. as far as i could tell, the other setters all accept the same values that the getter would return, but there may be other idiosyncrasies i'm not aware of. let me know what ought to be removed and i can submit a new patch.
bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.
Received: (at 78291) by debbugs.gnu.org; 7 May 2025 14:46:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 07 10:46:42 2025
Received: from localhost ([127.0.0.1]:45411 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uCg2k-00081Q-50
for submit <at> debbugs.gnu.org; Wed, 07 May 2025 10:46:42 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32806)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uCg2i-00081C-Du
for 78291 <at> debbugs.gnu.org; Wed, 07 May 2025 10:46:41 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 39AB010013E;
Wed, 7 May 2025 10:46:33 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1746629192;
bh=RVNI2c2okfsrpfyYDO7nr3a1wATeZzKbmtGTZcNnmOc=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=BqRL8M8Y7E8dHI3d+6UuFDTA95r1UnHWuvgLNcb9pQXN2yMPSkKm8AMkMIVxLJkwD
osYkkC9jAGvzSwU3ziEq/4QomycXfG2mL35aIrqmGAnZjFnQn+z1qGfp0n8AWBpnL0
Xf5Ux/vaZAR5OsyotSxZAhFfLY1uhVGWX6kikdzgO+avGdqoM6GqSiUdUJj7gOKfLd
/wd0p5EoJXW0tVAvdSD0B3hcsCXuApu56RbBj24e4fgM9X6qWhAo5PQzxdkMfewsIU
f3rSR54GftDu5OsJtCGnb4pvvD3YIhUVpnTAK55wdpvl/AW/j3qtHvefwWm4QIKy4W
Cx7zD9SNv2ddg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EAF2A100029;
Wed, 7 May 2025 10:46:31 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DAF9A1201A9;
Wed, 7 May 2025 10:46:31 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Zach Shaftel <zach@HIDDEN>
Subject: Re: bug#78291: [PATCH] Add new gv place definitions
In-Reply-To: <87ikmdcce1.fsf@HIDDEN>
Message-ID: <jwvselg4h5t.fsf-monnier+emacs@HIDDEN>
References: <87ikmdcce1.fsf@HIDDEN>
Date: Wed, 07 May 2025 10:46:31 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.101 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78291
Cc: 78291 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> --- a/lisp/emacs-lisp/gv.el
> +++ b/lisp/emacs-lisp/gv.el
> @@ -367,6 +367,8 @@ 'gv-place
>
> (gv-define-simple-setter aref aset)
> (gv-define-simple-setter char-table-range set-char-table-range)
> +(gv-define-simple-setter char-table-extra-slot set-char-table-extra-slot)
> +(gv-define-simple-setter char-table-parent set-char-table-parent)
> (gv-define-simple-setter car setcar)
> (gv-define-simple-setter cdr setcdr)
> ;; FIXME: add compiler-macros for `cXXr' instead!
> @@ -400,10 +402,12 @@ symbol-value
> ;;; Elisp-specific generalized variables.
>
> (gv-define-simple-setter default-value set-default)
> +(gv-define-simple-setter default-toplevel-value set-default-toplevel-value t)
> (gv-define-simple-setter frame-parameter set-frame-parameter 'fix)
> -(gv-define-simple-setter terminal-parameter set-terminal-parameter)
> +(gv-define-simple-setter terminal-parameter set-terminal-parameter t)
> (gv-define-simple-setter keymap-parent set-keymap-parent)
> (gv-define-simple-setter match-data set-match-data 'fix)
> +(gv-define-simple-setter marker-insertion-type set-marker-insertion-type)
> (gv-define-simple-setter overlay-get overlay-put)
> (gv-define-setter overlay-start (store ov)
> (macroexp-let2 nil store store
> @@ -415,6 +419,9 @@ process-buffer
> (gv-define-simple-setter process-filter set-process-filter)
> (gv-define-simple-setter process-sentinel set-process-sentinel)
> (gv-define-simple-setter process-get process-put 'fix)
> +(gv-define-simple-setter process-plist set-process-plist)
> +(gv-define-simple-setter process-query-on-exit-flag set-process-query-on-exit-flag)
> +(gv-define-simple-setter process-thread set-process-thread)
> (gv-define-simple-setter window-parameter set-window-parameter)
> (gv-define-setter window-buffer (v &optional w)
> (macroexp-let2 nil v v
LGTM, thanks.
> @@ -427,6 +434,14 @@ window-dedicated-p
> (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v))
> (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v))
> (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v))
> +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v))
> +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v))
> +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v))
> +(gv-define-simple-setter font-get font-put)
> +(gv-define-simple-setter charset-plist set-charset-plist)
> +(gv-define-simple-setter get-charset-property put-charset-property t)
> +(gv-define-setter lookup-key (val keymap key &optional _accept-default)
> + `(define-key ,keymap ,key ,val))
I'd have to check some of them, but at least the last doesn't look like
a good idea to me, because they don't quite match. E.g. if you
(define-key MAP KEY '(menu-item TEXT CMD))
The corresponding `lookup-key` will return just CMD rather than
(menu-item TEXT CMD).
Stefan
bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 7 May 2025 04:09:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 07 00:09:35 2025 Received: from localhost ([127.0.0.1]:37965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uCW6B-0006LS-1R for submit <at> debbugs.gnu.org; Wed, 07 May 2025 00:09:35 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59910) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <SRS0=4862=XX=shaf.tel=zach@HIDDEN>) id 1uCViq-0004z9-QC for submit <at> debbugs.gnu.org; Tue, 06 May 2025 23:45:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <SRS0=4862=XX=shaf.tel=zach@HIDDEN>) id 1uCVik-0002km-Vi for bug-gnu-emacs@HIDDEN; Tue, 06 May 2025 23:45:23 -0400 Received: from smtp.forwardemail.net ([149.28.215.223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <SRS0=4862=XX=shaf.tel=zach@HIDDEN>) id 1uCVii-0008Cp-QO for bug-gnu-emacs@HIDDEN; Tue, 06 May 2025 23:45:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shaf.tel; h=Content-Type: MIME-Version: Message-ID: Date: Subject: To: From; q=dns/txt; s=fe-acc5b42812; t=1746589516; bh=GILFXU5MELcDCp9SDpQNBU3ZIjd13aegl6Ohob/XWpQ=; b=bbkEanjWhPc8snzP1whsC2v6S2pSqHfP5lXNTi464IuvTJe/t86ixNptahC/dkSIJauk0ZgFd hl2KzjAQdr9vA1i9SA7naWRqSOCW9CHws7BDXnDhPxjZZX+bDmECv2H5Buk8RANvA/WkyGxop16 AXqin7p3aQTSORM6dTeGFBE= X-Forward-Email-ID: 681ad74ab0281deddfb7514b X-Forward-Email-Sender: rfc822; zach@HIDDEN, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 1.0.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@HIDDEN X-Report-Abuse: abuse@HIDDEN X-Report-Abuse-To: abuse@HIDDEN From: Zach Shaftel <zach@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] Add new gv place definitions User-Agent: mu4e 1.12.9; emacs 31.0.50 X-Debbugs-Cc: Stefan Monnier <monnier@HIDDEN> Date: Tue, 06 May 2025 23:45:10 -0400 Message-ID: <87ikmdcce1.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=149.28.215.223; envelope-from=SRS0=4862=XX=shaf.tel=zach@HIDDEN; helo=smtp.forwardemail.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 07 May 2025 00:09:34 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch just a few simple gv definitions. also fixed the return on the `terminal-parameter' gv, since `set-terminal-parameter' returns the previous value of the parameter instead of the new one. In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) of 2025-04-30 built on bigbox Repository revision: dd5ae0f3ba56e762ae1265b0cb0fe9f2a28281ec Repository branch: master System Description: Arch Linux Configured using: 'configure --with-modules --without-xwidgets --with-native-compilation --with-tree-sitter --without-gsettings --without-gconf --without-gpm --with-pgtk --without-compress-install 'CFLAGS=-mtune=native -march=native -O2 -g'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-new-gv-place-definitions.patch From de63c30a0e239817c48698c1fc7f5a793620cdcf Mon Sep 17 00:00:00 2001 From: Zach Shaftel <zshaftel@HIDDEN> Date: Tue, 6 May 2025 22:07:41 -0400 Subject: [PATCH] Add new gv place definitions * lisp/emacs-lisp/gv.el (char-table-extra-slot, char-table-parent) (default-toplevel-value, marker-insertion-type, process-plist) (process-query-on-exit-flag, process-thread, lookup-key) (window-prev-buffers, window-next-buffers, window-new-normal, font-get) (charset-plist, get-charset-property): Add gv-setters. (terminal-parameter): Fix the return value. --- lisp/emacs-lisp/gv.el | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el index 6c949f1016b..1e540926e4a 100644 --- a/lisp/emacs-lisp/gv.el +++ b/lisp/emacs-lisp/gv.el @@ -367,6 +367,8 @@ 'gv-place (gv-define-simple-setter aref aset) (gv-define-simple-setter char-table-range set-char-table-range) +(gv-define-simple-setter char-table-extra-slot set-char-table-extra-slot) +(gv-define-simple-setter char-table-parent set-char-table-parent) (gv-define-simple-setter car setcar) (gv-define-simple-setter cdr setcdr) ;; FIXME: add compiler-macros for `cXXr' instead! @@ -400,10 +402,12 @@ symbol-value ;;; Elisp-specific generalized variables. (gv-define-simple-setter default-value set-default) +(gv-define-simple-setter default-toplevel-value set-default-toplevel-value t) (gv-define-simple-setter frame-parameter set-frame-parameter 'fix) -(gv-define-simple-setter terminal-parameter set-terminal-parameter) +(gv-define-simple-setter terminal-parameter set-terminal-parameter t) (gv-define-simple-setter keymap-parent set-keymap-parent) (gv-define-simple-setter match-data set-match-data 'fix) +(gv-define-simple-setter marker-insertion-type set-marker-insertion-type) (gv-define-simple-setter overlay-get overlay-put) (gv-define-setter overlay-start (store ov) (macroexp-let2 nil store store @@ -415,6 +419,9 @@ process-buffer (gv-define-simple-setter process-filter set-process-filter) (gv-define-simple-setter process-sentinel set-process-sentinel) (gv-define-simple-setter process-get process-put 'fix) +(gv-define-simple-setter process-plist set-process-plist) +(gv-define-simple-setter process-query-on-exit-flag set-process-query-on-exit-flag) +(gv-define-simple-setter process-thread set-process-thread) (gv-define-simple-setter window-parameter set-window-parameter) (gv-define-setter window-buffer (v &optional w) (macroexp-let2 nil v v @@ -427,6 +434,14 @@ window-dedicated-p (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v)) +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v)) +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v)) +(gv-define-simple-setter font-get font-put) +(gv-define-simple-setter charset-plist set-charset-plist) +(gv-define-simple-setter get-charset-property put-charset-property t) +(gv-define-setter lookup-key (val keymap key &optional _accept-default) + `(define-key ,keymap ,key ,val)) (gv-define-setter buffer-local-value (val var buf) (macroexp-let2 nil v val -- 2.49.0 --=-=-=--
Zach Shaftel <zach@HIDDEN>:monnier@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.monnier@HIDDEN, bug-gnu-emacs@HIDDEN:bug#78291; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.