GNU bug report logs - #78297
[PATCH electronics-team] gnu: Add python-pydigitalwavetools.

Previous Next

To reply to this bug, email your comments to 78297 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: Add python-pydigitalwavetools.
Date: Wed,  7 May 2025 10:30:31 +0200

* gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
---
 gnu/packages/electronics.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 4df7064243..db9459ac03 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -551,6 +551,30 @@ (define-public python-edalize
 some tool-specific options are set.")
     (license license:bsd-2)))
 
+(define-public python-pydigitalwavetools
+  (package
+    (name "python-pydigitalwavetools")
+    (version "1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Nic30/pyDigitalWaveTools/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
+    (build-system pyproject-build-system)
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
+    (synopsis "Library to manipulate digital wave files.")
+    (description
+     "Pydigitalwavetools is a python library to parse, write and format VCD and other digital wave files.")
+    (license license:expat)))
+
 (define-public python-surf
   (package
     (name "python-surf")

base-commit: 658dc3ff5efb3f17e66d4f692a45805fae007989
-- 
2.49.0

Message #8 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: [bug#78297] [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Wed, 7 May 2025 15:13:47 +0200

Thanks for the patch!  It LGTM.

Message #11 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Thu, 08 May 2025 16:52:32 +0900

Hi,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>
> Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
> ---
>  gnu/packages/electronics.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
> index 4df7064243..db9459ac03 100644
> --- a/gnu/packages/electronics.scm
> +++ b/gnu/packages/electronics.scm
> @@ -551,6 +551,30 @@ (define-public python-edalize
>  some tool-specific options are set.")
>      (license license:bsd-2)))
>  
> +(define-public python-pydigitalwavetools
> +  (package
> +    (name "python-pydigitalwavetools")
> +    (version "1.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Nic30/pyDigitalWaveTools/")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
> +    (build-system pyproject-build-system)
> +    (native-inputs
> +     (list python-pytest
> +           python-setuptools
> +           python-wheel))
> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
> +    (synopsis "Library to manipulate digital wave files.")
> +    (description
> +     "Pydigitalwavetools is a python library to parse, write and format VCD and other digital wave files.")

Please M-x fill-paragraph (M-q) or equivalent in your editor to meet our
80 columns maximum width guideline.  Also,

s/python/Python/
s/wav/WAV/

I'd also use @acronym{VCD, Video CD}, and @acronym{WAV, Waveform Audio
File Format} in the description.

Could you please send a v2 with these small suggested improvements?

-- 
Thanks,
Maxim

Message #14 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78297 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH v2] gnu: Add python-pydigitalwavetools.
Date: Thu,  8 May 2025 10:41:09 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---

Note that VCD stands for Value Champ Dump, see [0].

[0] https://en.wikipedia.org/wiki/Value_change_dump

 gnu/packages/electronics.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index da37a9fb33..0cff76786b 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -610,6 +610,31 @@ (define-public python-edalize
 some tool-specific options are set.")
     (license license:bsd-2)))
 
+(define-public python-pydigitalwavetools
+  (package
+    (name "python-pydigitalwavetools")
+    (version "1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Nic30/pyDigitalWaveTools/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
+    (build-system pyproject-build-system)
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
+    (synopsis "Library to manipulate digital wave files.")
+    (description
+     "Pydigitalwavetools is a Python library to parse, write and format
+@acronym{VCD, Value Champ Dump} and other digital wave files.")
+    (license license:expat)))
+
 (define-public python-surf
   (package
     (name "python-surf")

base-commit: 01ca654387c64265b310f2887d884cd7ec7c4f0a
--
2.49.0

Message #17 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78297 <at> debbugs.gnu.org
Cc: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH electronics-team v2] gnu: Add python-pydigitalwavetools.
Date: Thu,  8 May 2025 11:26:36 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e

---
 gnu/packages/electronics.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index da37a9fb33..0cff76786b 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -610,6 +610,31 @@ (define-public python-edalize
 some tool-specific options are set.")
     (license license:bsd-2)))
 
+(define-public python-pydigitalwavetools
+  (package
+    (name "python-pydigitalwavetools")
+    (version "1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Nic30/pyDigitalWaveTools/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
+    (build-system pyproject-build-system)
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
+    (synopsis "Library to manipulate digital wave files.")
+    (description
+     "Pydigitalwavetools is a Python library to parse, write and format
+@acronym{VCD, Value Champ Dump} and other digital wave files.")
+    (license license:expat)))
+
 (define-public python-surf
   (package
     (name "python-surf")

base-commit: 01ca654387c64265b310f2887d884cd7ec7c4f0a
--
2.49.0

Message #20 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 78312 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: [bug#78312] [PATCH v2] gnu: Add python-pydigitalwavetools.
Date: Mon, 12 May 2025 14:07:38 +0200

LGTM

Message #23 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Mon, 12 May 2025 21:34:49 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

> From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
>
> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

[...]

> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
> +    (synopsis "Library to manipulate digital wave files.")
> +    (description
> +     "Pydigitalwavetools is a Python library to parse, write and format
> +@acronym{VCD, Value Champ Dump} and other digital wave files.")
> +    (license license:expat)))

Are you sure about VCD being 'Value Champ Dump' and not Video CD as I
thought?  The later seemed more sensical to me, this being about some
digital audio files :-).

You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'.

The synopsis should not end with a '.'; please run './pre-inst-env guix
lint python-pydigitalwavetools' to catch these things.

Could you send a v3?

-- 
Thanks,
Maxim

Message #26 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Mon, 12 May 2025 14:54:19 +0200

[Message part 1 (text/plain, inline)]

>lun. 12 mai 2025 at 21:34, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> Hi Cayetano,
>
> Cayetano Santos <csantosb <at> inventati.org> writes:
>
>> From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
>>
>> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>
> [...]
>
>> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
>> +    (synopsis "Library to manipulate digital wave files.")
>> +    (description
>> +     "Pydigitalwavetools is a Python library to parse, write and format
>> +@acronym{VCD, Value Champ Dump} and other digital wave files.")
>> +    (license license:expat)))
>
> Are you sure about VCD being 'Value Champ Dump' and not Video CD as I
> thought?  The later seemed more sensical to me, this being about some
> digital audio files :-).

Yes. Where exactly do you see any reference to audio in here ?

See, for example

    https://github.com/Nic30/pyDigitalWaveTools/?tab=readme-ov-file#related-open-source

This is what VCD is all about:

    https://pyvcd.readthedocs.io/en/latest/vcd.gtkw.html

> You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'.

Yes, just because this has nothing to do with WAV audio format. Is this
comment still relevant for v3 ?

> The synopsis should not end with a '.'; please run './pre-inst-env guix
> lint python-pydigitalwavetools' to catch these things.

You’re right, my bad !

C.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Tue, 13 May 2025 09:05:13 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

>>lun. 12 mai 2025 at 21:34, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> Hi Cayetano,
>>
>> Cayetano Santos <csantosb <at> inventati.org> writes:
>>
>>> From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
>>>
>>> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>>
>> [...]
>>
>>> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
>>> +    (synopsis "Library to manipulate digital wave files.")
>>> +    (description
>>> +     "Pydigitalwavetools is a Python library to parse, write and format
>>> +@acronym{VCD, Value Champ Dump} and other digital wave files.")
>>> +    (license license:expat)))
>>
>> Are you sure about VCD being 'Value Champ Dump' and not Video CD as I
>> thought?  The later seemed more sensical to me, this being about some
>> digital audio files :-).
>
> Yes. Where exactly do you see any reference to audio in here ?

I simply assumed it was, with all the Wave references in the tool name
and description (I assumed it had to do with the WAV audio format).

> See, for example
>
>     https://github.com/Nic30/pyDigitalWaveTools/?tab=readme-ov-file#related-open-source

Thanks.  I see they define VCD as 'Value Change Dump' though, not 'Value
Champ Dump'.  After reading [0], I now understand that VCDs are "a
standardized ASCII format used to store simulation data from Verilog and
other hardware description languages".  Perhaps that could be added to
the description; as it was useful to provide proper context to me.  We
should assume people reading these package descriptions know nothing
about the local domain jargon.

[0]  https://www.chipverify.com/verilog/verilog-vcd

> This is what VCD is all about:
>
>     https://pyvcd.readthedocs.io/en/latest/vcd.gtkw.html
>
>> You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'.
>
> Yes, just because this has nothing to do with WAV audio format. Is this
> comment still relevant for v3 ?

I see.  Not relevant then.

-- 
Thanks,
Maxim

Message #32 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78297 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH electronics-team v3] gnu: Add python-pydigitalwavetools.
Date: Tue, 13 May 2025 10:25:35 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---
 gnu/packages/electronics.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index da37a9fb33..21c088460c 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -610,6 +610,33 @@ (define-public python-edalize
 some tool-specific options are set.")
     (license license:bsd-2)))
 
+(define-public python-pydigitalwavetools
+  (package
+    (name "python-pydigitalwavetools")
+    (version "1.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Nic30/pyDigitalWaveTools/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0fll8anz3i1j1nngsij1psp8766kvdfpls655lbxn2ykypv3633m"))))
+    (build-system pyproject-build-system)
+    (native-inputs
+     (list python-pytest
+           python-setuptools
+           python-wheel))
+    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
+    (synopsis "Library to manipulate digital wave files")
+    (description
+     "Pydigitalwavetools is a Python library to parse, write and format digital
+wave files in @acronym{VCD, Value Change Dump} format, a standardized ASCII
+format used to store simulation data from Verilog and other hardware description
+languages.")
+    (license license:expat)))
+
 (define-public python-surf
   (package
     (name "python-surf")

base-commit: 8a86f221d4066e7a0df2d07208c817035b98a949
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.