GNU bug report logs - #78309
[PATCH 0/2] Only add guix artwork on a desktop system.

Previous Next

To reply to this bug, email your comments to 78309 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 0/2] Only add guix artwork on a desktop system.
Date: Thu,  8 May 2025 08:55:25 +0300

We don't need guix-icons (and the packages it needs to build) for the
base-system.

Efraim Flashner (2):
  system: Only add guix artwork on a desktop system.
  gnu: %base-packages-artwork: Add guix backgrounds.

 gnu/services/desktop.scm | 7 ++++++-
 gnu/system.scm           | 8 ++++----
 2 files changed, 10 insertions(+), 5 deletions(-)


base-commit: 9d9a6291c4e61f3af71e94e549926bd9905e99db
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #8 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 78309 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 1/2] system: Only add guix artwork on a desktop system.
Date: Thu,  8 May 2025 08:56:45 +0300

* gnu/system.scm (%base-packages): Remove %base-packages-artwork.
* gnu/services/desktop.scm (desktop-services-for-system): Add
guix-artwork profile service.

Change-Id: I4071e8137609dbb7dfdba174d1da2d8811421a00
---
 gnu/services/desktop.scm | 7 ++++++-
 gnu/system.scm           | 3 +--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 2127c2d389c..12560a6249d 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2017, 2020, 2022, 2023, 2025 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2017 Nikita <nikita <at> n0.is>
 ;;; Copyright © 2017, 2019 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
-;;; Copyright © 2018, 2020, 2022 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2018, 2020, 2022, 2025 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2018, 2023 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2017, 2019 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
@@ -2454,6 +2454,11 @@ (define* (desktop-services-for-system #:optional
                               (list (file-append nfs-utils "/sbin/mount.nfs")
                                (file-append ntfs-3g "/sbin/mount.ntfs-3g"))))
 
+         ;; Add some of the artwork niceties for the desktop.
+         (simple-service 'guix-artwork
+                         profile-service-type
+                         %base-packages-artwork)
+
          ;; This is a volatile read-write file system mounted at /var/lib/gdm,
          ;; to avoid GDM stale cache and permission issues.
          gdm-file-system-service
diff --git a/gnu/system.scm b/gnu/system.scm
index bc652b1ce59..2f87b99fce3 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -982,8 +982,7 @@ (define-deprecated %base-packages-disk-utilities #f '())
 (define %base-packages
   ;; Default set of packages globally visible.  It should include anything
   ;; required for basic administrator tasks.
-  (append %base-packages-artwork
-          %base-packages-interactive
+  (append %base-packages-interactive
           %base-packages-linux
           %base-packages-networking
           %base-packages-utils))
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #11 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 78309 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 2/2] gnu: %base-packages-artwork: Add guix backgrounds.
Date: Thu,  8 May 2025 08:56:46 +0300

* gnu/system.scm (%base-packages-artwork): Add guix-backgrounds.

Change-Id: Ia34ec7eb8548aa8bcd9e912089c2835cd3db4157
---
 gnu/system.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 2f87b99fce3..2beca4b6d08 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2020 Florian Pelz <pelzflorian <at> pelzflorian.de>
 ;;; Copyright © 2020, 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2020, 2023 Janneke Nieuwenhuizen <jannek <at> gnu.org>
-;;; Copyright © 2020, 2022 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2020, 2022, 2025 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;; Copyright © 2021 raid5atemyhomework <raid5atemyhomework <at> protonmail.com>
 ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
@@ -930,7 +930,8 @@ (define %base-firmware
 
 (define %base-packages-artwork
   ;; Default set of artwork packages.
-  (list guix-icons))
+  (list guix-backgrounds
+        guix-icons))
 
 (define %base-packages-utils
   ;; Default set of  utilities packages.
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #14 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Noé Lopez <noelopez <at> free.fr>, 78309 <at> debbugs.gnu.org,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#78309] [PATCH 1/2] system: Only add guix artwork on a
 desktop system.
Date: Thu, 08 May 2025 15:40:39 +0900

Hi Efraim,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> * gnu/system.scm (%base-packages): Remove %base-packages-artwork.
> * gnu/services/desktop.scm (desktop-services-for-system): Add
> guix-artwork profile service.

[...]

> +         ;; Add some of the artwork niceties for the desktop.
> +         (simple-service 'guix-artwork
> +                         profile-service-type
> +                         %base-packages-artwork)
> +
>           ;; This is a volatile read-write file system mounted at /var/lib/gdm,
>           ;; to avoid GDM stale cache and permission issues.
>           gdm-file-system-service
> diff --git a/gnu/system.scm b/gnu/system.scm
> index bc652b1ce59..2f87b99fce3 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -982,8 +982,7 @@ (define-deprecated %base-packages-disk-utilities #f '())
>  (define %base-packages
>    ;; Default set of packages globally visible.  It should include anything
>    ;; required for basic administrator tasks.
> -  (append %base-packages-artwork
> -          %base-packages-interactive

I was wondering, aren't the artwork also use to provide a nicer GRUB
background?  That's maybe not super important for servers, but I thought
I'd point it out.

-- 
Thanks,
Maxim

Message #17 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Noé Lopez <noelopez <at> free.fr>, 78309 <at> debbugs.gnu.org,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#78309] [PATCH 1/2] system: Only add guix artwork on a
 desktop system.
Date: Thu, 8 May 2025 11:12:31 +0300

[Message part 1 (text/plain, inline)]

On Thu, May 08, 2025 at 03:40:39PM +0900, Maxim Cournoyer wrote:
> Hi Efraim,
> 
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > * gnu/system.scm (%base-packages): Remove %base-packages-artwork.
> > * gnu/services/desktop.scm (desktop-services-for-system): Add
> > guix-artwork profile service.
> 
> [...]
> 
> > +         ;; Add some of the artwork niceties for the desktop.
> > +         (simple-service 'guix-artwork
> > +                         profile-service-type
> > +                         %base-packages-artwork)
> > +
> >           ;; This is a volatile read-write file system mounted at /var/lib/gdm,
> >           ;; to avoid GDM stale cache and permission issues.
> >           gdm-file-system-service
> > diff --git a/gnu/system.scm b/gnu/system.scm
> > index bc652b1ce59..2f87b99fce3 100644
> > --- a/gnu/system.scm
> > +++ b/gnu/system.scm
> > @@ -982,8 +982,7 @@ (define-deprecated %base-packages-disk-utilities #f '())
> >  (define %base-packages
> >    ;; Default set of packages globally visible.  It should include anything
> >    ;; required for basic administrator tasks.
> > -  (append %base-packages-artwork
> > -          %base-packages-interactive
> 
> I was wondering, aren't the artwork also use to provide a nicer GRUB
> background?  That's maybe not super important for servers, but I thought
> I'd point it out.

guix-icons, currently the only package in %base-packages-artwork,
provides a nice square guix icon.  The bootloaders and login managers
which use the backgrounds from the artwork repository grab their images
directly from the %artwork-repository.  The guix-backgrounds package
takes the %artwork-repository and extracts the desktop backgrounds from
it to make it easier to use them for desktops.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Noé Lopez <noelopez <at> free.fr>, 78309 <at> debbugs.gnu.org,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#78309] [PATCH 1/2] system: Only add guix artwork on a
 desktop system.
Date: Thu, 08 May 2025 20:38:30 +0900

Hi Efraim,

Efraim Flashner <efraim <at> flashner.co.il> writes:

[...]

>> > diff --git a/gnu/system.scm b/gnu/system.scm
>> > index bc652b1ce59..2f87b99fce3 100644
>> > --- a/gnu/system.scm
>> > +++ b/gnu/system.scm
>> > @@ -982,8 +982,7 @@ (define-deprecated %base-packages-disk-utilities #f '())
>> >  (define %base-packages
>> >    ;; Default set of packages globally visible.  It should include anything
>> >    ;; required for basic administrator tasks.
>> > -  (append %base-packages-artwork
>> > -          %base-packages-interactive
>> 
>> I was wondering, aren't the artwork also use to provide a nicer GRUB
>> background?  That's maybe not super important for servers, but I
>> thought
>> I'd point it out.
>
> guix-icons, currently the only package in %base-packages-artwork,
> provides a nice square guix icon.  The bootloaders and login managers
> which use the backgrounds from the artwork repository grab their
> images
> directly from the %artwork-repository.  The guix-backgrounds package
> takes the %artwork-repository and extracts the desktop backgrounds
> from
> it to make it easier to use them for desktops.

I see, thanks for the explanation.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #23 received at 78309 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Noé Lopez <noelopez <at> free.fr>, 78309 <at> debbugs.gnu.org,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#78309] [PATCH 1/2] system: Only add guix artwork on a
 desktop system.
Date: Sun, 11 May 2025 19:21:51 -0700

Hi Efraim,

Thank you for the explanation.  This patch series lookd good to 
me.

 -- Ian

Message #28 received at 78309-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 78309-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/2] Only add guix artwork on a desktop system.
Date: Mon, 12 May 2025 09:36:01 +0300

[Message part 1 (text/plain, inline)]

Patches pushed.

On Thu, May 08, 2025 at 08:55:25AM +0300, Efraim Flashner wrote:
> We don't need guix-icons (and the packages it needs to build) for the
> base-system.
> 
> Efraim Flashner (2):
>   system: Only add guix artwork on a desktop system.
>   gnu: %base-packages-artwork: Add guix backgrounds.
> 
>  gnu/services/desktop.scm | 7 ++++++-
>  gnu/system.scm           | 8 ++++----
>  2 files changed, 10 insertions(+), 5 deletions(-)
> 
> 
> base-commit: 9d9a6291c4e61f3af71e94e549926bd9905e99db
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.