GNU bug report logs - #78316
[PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e.

Previous Next

To reply to this bug, email your comments to 78316 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: python-hdlmake: Update to
 3.4dev1-0.9338e3e.
Date: Thu,  8 May 2025 14:49:32 +0200

* gnu/packages/fpga.scm (python-hdlmake): Update to 3.4dev1-0.9338e3e.

Change-Id: Ied124a3ceb22be427c5255b5d139f5f63031e260
---

[source]: Update URL.
[homepage]: Update URL.

 gnu/packages/fpga.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index 2298dde595..e2a0b19a7d 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -776,26 +776,26 @@ (define-public openfpgaloader
     (license license:asl2.0)))
 
 (define-public python-hdlmake
-  (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54")
+  (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
         (revision "0"))
     (package
       (name "python-hdlmake")
-      (version (git-version "3.3" revision commit))
+      (version (git-version "3.4dev1" revision commit))
       (source
        (origin
          (method git-fetch)
          (uri (git-reference
-               (url "https://ohwr.org/project/hdl-make")
+               (url "https://gitlab.com/ohwr/project/hdl-make/")
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "08ivnhxyp44agmifqb4pjbxj23p43qqcg73s2y2z1hqk2six3fdx"))))
+          (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj"))))
       (build-system pyproject-build-system)
       (arguments
        `(#:tests? #f))
       (native-inputs (list python-setuptools python-wheel))
       (propagated-inputs (list python-six))
-      (home-page "https://ohwr.org/projects/hdl-make")
+      (home-page "https://gitlab.com/ohwr/project/hdl-make/")
       (synopsis "Generate multi-purpose makefiles for HDL projects")
       (description
        "Hdlmake helps manage and share @acronym{HDL, hardware description

base-commit: 4fe484ee7e9d598a9d0a249c375b75a14b95d1b4
--
2.49.0

Message #8 received at 78316 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78316 <at> debbugs.gnu.org
Subject: Re: [bug#78316] [PATCH electronics-team] gnu: python-hdlmake: Update
 to 3.4dev1-0.9338e3e.
Date: Mon, 12 May 2025 14:04:24 +0200

LGTM, but: Does the project officially change their home-page?  If so,
please state that in the commit message.

Thanks for your time and effort!
gabber

Message #13 received at 78316-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Ekaitz Zarraga <ekaitz <at> elenq.tech>,
 78316-done <at> debbugs.gnu.org
Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update
 to 3.4dev1-0.9338e3e.
Date: Mon, 12 May 2025 21:52:46 +0900

Hi,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/fpga.scm (python-hdlmake): Update to 3.4dev1-0.9338e3e.
>
> Change-Id: Ied124a3ceb22be427c5255b5d139f5f63031e260
> ---
>
> [source]: Update URL.
> [homepage]: Update URL.

Ah, these should have appeared in the change log (commit message), not
in this patch metadata/comment area.  I've fixed it locally.

>  gnu/packages/fpga.scm | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
> index 2298dde595..e2a0b19a7d 100644
> --- a/gnu/packages/fpga.scm
> +++ b/gnu/packages/fpga.scm
> @@ -776,26 +776,26 @@ (define-public openfpgaloader
>      (license license:asl2.0)))
>  
>  (define-public python-hdlmake
> -  (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54")
> +  (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
>          (revision "0"))
>      (package
>        (name "python-hdlmake")
> -      (version (git-version "3.3" revision commit))
> +      (version (git-version "3.4dev1" revision commit))

The version here is not correct, according to (info "(guix) Version
Numbers").  The version string of a git snapshot should be based on the
latest upstream version, which is still 3.3.  Since we're not bumping
the version the revision number needs to go up by one.

>        (source
>         (origin
>           (method git-fetch)
>           (uri (git-reference
> -               (url "https://ohwr.org/project/hdl-make")
> +               (url "https://gitlab.com/ohwr/project/hdl-make/")
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 "08ivnhxyp44agmifqb4pjbxj23p43qqcg73s2y2z1hqk2six3fdx"))))
> +          (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj"))))
>        (build-system pyproject-build-system)
>        (arguments
>         `(#:tests? #f))
>        (native-inputs (list python-setuptools python-wheel))
>        (propagated-inputs (list python-six))
> -      (home-page "https://ohwr.org/projects/hdl-make")
> +      (home-page "https://gitlab.com/ohwr/project/hdl-make/")

LGTM.  Applied with the following fix-ups (I also enabled the tests):

--8<---------------cut here---------------start------------->8---
1 file changed, 7 insertions(+), 5 deletions(-)
gnu/packages/fpga.scm | 12 +++++++-----

modified   gnu/packages/fpga.scm
@@ -774,10 +774,10 @@ (define-public openfpgaloader
 
 (define-public python-hdlmake
   (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
-        (revision "0"))
+        (revision "1"))
     (package
       (name "python-hdlmake")
-      (version (git-version "3.4dev1" revision commit))
+      (version (git-version "3.3" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -788,9 +788,11 @@ (define-public python-hdlmake
          (sha256
           (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj"))))
       (build-system pyproject-build-system)
-      (arguments
-       `(#:tests? #f))
-      (native-inputs (list python-setuptools python-wheel))
+      (arguments (list #:phases #~(modify-phases %standard-phases
+                                    (add-before 'check 'chdir
+                                      (lambda _
+                                        (chdir "testsuite"))))))
+      (native-inputs (list python-pytest python-setuptools python-wheel))
       (propagated-inputs (list python-six))
       (home-page "https://gitlab.com/ohwr/project/hdl-make/")
       (synopsis "Generate multi-purpose makefiles for HDL projects")

[back]
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim

Message #16 received at 78316-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Ekaitz Zarraga <ekaitz <at> elenq.tech>,
 78316-done <at> debbugs.gnu.org
Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update
 to 3.4dev1-0.9338e3e.
Date: Mon, 12 May 2025 15:17:08 +0200

[Message part 1 (text/plain, inline)]

>lun. 12 mai 2025 at 21:52, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

>>  (define-public python-hdlmake
>> -  (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54")
>> +  (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
>>          (revision "0"))
>>      (package
>>        (name "python-hdlmake")
>> -      (version (git-version "3.3" revision commit))
>> +      (version (git-version "3.4dev1" revision commit))
>
> The version here is not correct, according to (info "(guix) Version
> Numbers").  The version string of a git snapshot should be based on the
> latest upstream version, which is still 3.3.  Since we're not bumping
> the version the revision number needs to go up by one.

Once built and installed, ‘hdlmake --version’ returns "3.4dev1" as for
"hdlmake/_version.py", which is weird when one installs 3.3.

C.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 78316-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Ekaitz Zarraga <ekaitz <at> elenq.tech>,
 78316-done <at> debbugs.gnu.org
Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update
 to 3.4dev1-0.9338e3e.
Date: Tue, 13 May 2025 10:24:41 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

>>lun. 12 mai 2025 at 21:52, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>>>  (define-public python-hdlmake
>>> -  (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54")
>>> +  (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
>>>          (revision "0"))
>>>      (package
>>>        (name "python-hdlmake")
>>> -      (version (git-version "3.3" revision commit))
>>> +      (version (git-version "3.4dev1" revision commit))
>>
>> The version here is not correct, according to (info "(guix) Version
>> Numbers").  The version string of a git snapshot should be based on the
>> latest upstream version, which is still 3.3.  Since we're not bumping
>> the version the revision number needs to go up by one.
>
> Once built and installed, ‘hdlmake --version’ returns "3.4dev1" as for
> "hdlmake/_version.py", which is weird when one installs 3.3.

I see.  We could always use 3.4dev1 and add a comment telling the next
person updating it where it comes from, e.g.

;; The git snapshot base version is taken from the 'hdlmake/_version.py'
;; source.

It's a small thing though.  I personally wouldn't bother.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.