GNU bug report logs - #78322
[PATCH] Add Konsave

Previous Next

To reply to this bug, email your comments to 78322 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH] Add Konsave
Date: Thu,  8 May 2025 18:42:42 +0200

This patch series adds Konsave[1] and its dependencies

[1] https://github.com/Prayag2/konsave

Sergio Pastor Pérez (3):
  gnu: Add python-pytest-pylint.
  gnu: Add python-aiohttp-cors.
  gnu: Add konsave.

 gnu/packages/check.scm      | 20 ++++++++++++++++++
 gnu/packages/kde-utils.scm  | 42 +++++++++++++++++++++++++++++++++++++
 gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
 3 files changed, 104 insertions(+)


base-commit: 295a35ba20257e965c4eba8488de99fce7bf027f
-- 
2.49.0

Message #8 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH] gnu: Add python-pytest-pylint.
Date: Thu,  8 May 2025 18:46:01 +0200

* gnu/packages/check.scm (python-pytest-pylint): New variable.

Change-Id: Iba326a6fc9cbd333eb63edf2ed61dca45cdf2bc9
---
 gnu/packages/check.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 3fe7214645..9af1bcaef4 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -3105,6 +3105,26 @@ (define-public python-pytest-perf
 each of the environments.")
     (license license:expat)))
 
+(define-public python-pytest-pylint
+  (package
+    (name "python-pytest-pylint")
+    (version "0.21.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pytest-pylint" version))
+       (sha256
+        (base32 "0gjm9qy1rsngvli042szqc45y0q5zk1crq28ja01iyjw3n74nxl8"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-pylint))
+    (native-inputs (list python-pytest python-setuptools python-wheel))
+    (home-page "https://github.com/carsongee/pytest-pylint")
+    (synopsis "Pytest plugin to check source code with Pylint")
+    (description
+     "This plugin allows running Pylint with Pytest and have
+configurable rule types (i.e. Convention, Warn, and Error) fail the build.")
+    (license license:expat)))
+
 (define-public python-pytest-flakes
   (package
     (name "python-pytest-flakes")
-- 
2.49.0

Message #11 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH] gnu: Add konsave.
Date: Thu,  8 May 2025 18:46:03 +0200

* gnu/packages/kde-utils.scm (konsave): New variable.

Change-Id: I975e17f9fa17db0fa22e93798ed5ff2f4011a305
---
 gnu/packages/kde-utils.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-utils.scm b/gnu/packages/kde-utils.scm
index 994597571c..79d81d9ee3 100644
--- a/gnu/packages/kde-utils.scm
+++ b/gnu/packages/kde-utils.scm
@@ -21,6 +21,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages kde-utils)
+  #:use-module (guix build-system pyproject)
   #:use-module (guix build-system qt)
   #:use-module (guix gexp)
   #:use-module (guix download)
@@ -31,6 +32,7 @@ (define-module (gnu packages kde-utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages crypto)
@@ -52,6 +54,9 @@ (define-module (gnu packages kde-utils)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kde-plasma)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-build)
+  #:use-module (gnu packages python-web)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages samba)
   #:use-module (gnu packages xdisorg)
@@ -747,6 +752,43 @@ (define-public kirogi
       (license ;GPL for programs, LGPL for libraries
        (list license:gpl2+ license:lgpl2.0)))))
 
+(define-public konsave
+  (package
+    (name "konsave")
+    (version "2.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Prayag2/konsave")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j5nszy41j4fd6b5w7188gphfk2s0dj44rs7fg55a4izvm0brbx9"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-pyyaml))
+    (native-inputs (list python-aiohttp
+                         python-aiohttp-cors
+                         python-black
+                         python-pylint
+                         python-setuptools
+                         python-wheel))
+    (arguments
+     '(#:tests? #false ; no tests.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'sanity-check 'set-home-directory
+           ;; sanity-check requires a home directory since importing the
+           ;; `const.py' module creates a directory to save configurations.
+           (lambda _ (setenv "HOME" "/tmp") #t)))))
+    (home-page "https://www.github.com/prayag2/konsave")
+    (synopsis "Linux customization saver")
+    (description
+     "Konsave is command line program written in Python to let you backup your
+dotfiles and switch to other ones in an instant.  It officially supports KDE
+Plasma.")
+    (license license:gpl3)))
+
 (define-public kontrast
   (package
     (name "kontrast")
-- 
2.49.0

Message #14 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH] gnu: Add python-aiohttp-cors.
Date: Thu,  8 May 2025 18:46:02 +0200

* gnu/packages/python-web.scm (python-aiohttp-cors): New variable.

Change-Id: Ic94d0b06d787564e20fbe39196d5843af4e9f3a2
---
 gnu/packages/python-web.scm | 42 +++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index c0c9e244f8..909b65b023 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -1123,6 +1123,48 @@ (define-public python-aiohttp
 @end itemize")
     (license license:asl2.0)))
 
+(define-public python-aiohttp-cors
+  (package
+    (name "python-aiohttp-cors")
+    (version "0.8.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiohttp_cors" version))
+       (sha256
+        (base32 "00qlzc2y65bkl1a5f5v83mmjlrhzmx3a2ngq2pm3jjdnhk5zkb6c"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-aiohttp))
+    (native-inputs (list python-pytest-cov
+                         python-pytest-pylint
+                         python-pytest-runner
+                         python-selenium
+                         python-setuptools
+                         python-tox
+                         python-wheel))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'remove-network-dep
+           (lambda _
+             ;; Tests try to install from network even if its available
+             ;; locally.
+             (substitute* "setup.py"
+               (("\"aiohttp>=3.9\",") ""))))
+         ;; Tests run with `py.test' require a GUI browser window.
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (if tests?
+                 (invoke "tox")
+                 (format #t "test suite not run~%"))
+             #t)))))
+    (home-page "https://github.com/aio-libs/aiohttp-cors")
+    (synopsis "CORS support for aiohttp")
+    (description
+     "This library implements Cross Origin Resource Sharing (CORS)
+support for aiohttp asyncio-powered asynchronous HTTP server.")
+    (license license:asl2.0)))
+
 (define-public python-aiohttp-socks
   (package
     (name "python-aiohttp-socks")
-- 
2.49.0

Message #17 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: sergio.pastorperez <at> gmail.com
Subject: [PATCH] Add Konsave
Date: Fri, 09 May 2025 11:53:24 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch.

Please check my review points and prepare updates in v2.

> [PATCH] gnu: Add python-pytest-pylint.
Place to python-check with

  guix import -i gnu/packages/python-check.scm pypi pytest-pylint"

It will import the package and save in the file in alphabetical order.

> [PATCH] gnu: Add konsave.
Do you really want it in kde-utils as it requires to use quite a lot of
new modules, how about python-xyz or python-web or even
configuration-management (more likely according to description of the
project)?

From the upstream:
> It officially supports KDE Plasma but it can be used on all other
> desktop environments too!
I'm not sure it may be a driving point to think it's just for KDE ;-)

> +    (native-inputs (list python-aiohttp
> +                         python-aiohttp-cors
> +                         python-black
> +                         python-pylint
> +                         python-setuptools
> +                         python-wheel))
No need for python-aiohttp python-aiohttp-cors python-black
python-pylint, as tests are disabled and we usually ignore any dev
dependencies (black, flake8, pylint and similar):

setup.py:
  -> install_requires=_REQUIREMENTS,
    -> _REQUIREMENTS: List[str] = _read_reqs(Path("requirements.txt"))
      -> PyYaml>=5.4.1

> +    (synopsis "Linux customization saver")
It sounds miss leading as under "Linux customization" may be any sort of
config files possible for Linux distros, according to farther description
it's "dotfiles manager" so change to
"Dotfiles manager" is more likely to reflect the purpose of the project.

> +    "Konsave is command line program written in Python to let you backup your
> +dotfiles and switch to other ones in an instant.  It officially supports KDE
> +Plasma.")
IMHO to mention which language the final CLI was written is ambiguous, I
would reward it to something reflecting the purpose and a list of
features, if remove "adetersment" we don't have much to have a clue what
this CLI can do.

> +    "Konsave is command line program .................... let you backup your
> +dotfiles and switch to other ones in an instant.  ..........................
> +.......")

> +    (home-page "https://www.github.com/prayag2/konsave")
change to "https://github.com/prayag2/konsave" as permament redirection

> [PATCH] gnu: Add python-aiohttp-cors.

> +    (native-inputs (list python-pytest-cov
> +                         python-pytest-pylint
> +                         python-pytest-runner
> +                         python-selenium
> +                         python-setuptools
> +                         python-tox
> +                         python-wheel))
Pleas remove python-pytest-pylint, python-pytest-runner,
python-selenium and python-tox; add python-pytest it will let
pyproject-build-system to identify test runner automatically

> +         (add-before 'check 'remove-network-dep
> +           (lambda _
> +             ;; Tests try to install from network even if its available
> +             ;; locally.
> +             (substitute* "setup.py"
> +               (("\"aiohttp>=3.9\",") ""))))
> +         ;; Tests run with `py.test' require a GUI browser window.
> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (if tests?
> +                 (invoke "tox")
> +                 (format #t "test suite not run~%"))
> +             #t)))))
You can drop this, see above comment.

> +    (description
> +     "This library implements Cross Origin Resource Sharing (CORS)
> +support for aiohttp asyncio-powered asynchronous HTTP server.")
> +    (license license:asl2.0)))
You can use @acronym{} for styling.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH v2 1/3] gnu: Add python-pytest-pylint.
Date: Fri,  9 May 2025 21:29:03 +0200

* gnu/packages/check.scm (python-pytest-pylint): New variable.

Change-Id: Iba326a6fc9cbd333eb63edf2ed61dca45cdf2bc9
---
 gnu/packages/python-check.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index a0909f6159..8470ba6fa3 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -2694,6 +2694,26 @@ (define-public python-pytest-pydocstyle
 @command{pydocstyle}.")
     (license license:expat)))
 
+(define-public python-pytest-pylint
+  (package
+    (name "python-pytest-pylint")
+    (version "0.21.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pytest-pylint" version))
+       (sha256
+        (base32 "0gjm9qy1rsngvli042szqc45y0q5zk1crq28ja01iyjw3n74nxl8"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-pylint))
+    (native-inputs (list python-pytest python-setuptools python-wheel))
+    (home-page "https://github.com/carsongee/pytest-pylint")
+    (synopsis "Pytest plugin to check source code with Pylint")
+    (description
+     "This plugin allows running Pylint with Pytest and have
+configurable rule types (i.e. Convention, Warn, and Error) fail the build.")
+    (license license:expat)))
+
 (define-public python-pytest-qt
   (package
     (name "python-pytest-qt")

base-commit: 295a35ba20257e965c4eba8488de99fce7bf027f
-- 
2.49.0

Message #23 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH v2 2/3] gnu: Add python-aiohttp-cors.
Date: Fri,  9 May 2025 21:29:04 +0200

* gnu/packages/python-web.scm (python-aiohttp-cors): New variable.

Change-Id: Ic94d0b06d787564e20fbe39196d5843af4e9f3a2
---
 gnu/packages/python-web.scm | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index c0c9e244f8..b5a5a30add 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -1123,6 +1123,44 @@ (define-public python-aiohttp
 @end itemize")
     (license license:asl2.0)))
 
+(define-public python-aiohttp-cors
+  (package
+    (name "python-aiohttp-cors")
+    (version "0.8.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiohttp_cors" version))
+       (sha256
+        (base32 "00qlzc2y65bkl1a5f5v83mmjlrhzmx3a2ngq2pm3jjdnhk5zkb6c"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-aiohttp))
+    (native-inputs (list python-setuptools
+                         python-tox
+                         python-wheel))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'remove-network-dep
+           (lambda _
+             ;; Tests try to install from network even if its available
+             ;; locally.
+             (substitute* "setup.py"
+               (("\"aiohttp>=3.9\",") ""))))
+         ;; Tests run with `py.test' require a GUI browser window.
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (if tests?
+                 (invoke "tox")
+                 (format #t "test suite not run~%"))
+             #t)))))
+    (home-page "https://github.com/aio-libs/aiohttp-cors")
+    (synopsis "CORS support for aiohttp")
+    (description
+     "This library implements @acronym{CORS, Cross Origin Resource Sharing}
+support for aiohttp asyncio-powered asynchronous HTTP server.")
+    (license license:asl2.0)))
+
 (define-public python-aiohttp-socks
   (package
     (name "python-aiohttp-socks")
-- 
2.49.0

Message #26 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: 78322 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
Subject: [PATCH v2 3/3] gnu: Add konsave.
Date: Fri,  9 May 2025 21:29:05 +0200

* gnu/packages/configuration-management.scm (konsave): New variable.

Change-Id: I975e17f9fa17db0fa22e93798ed5ff2f4011a305
---
 gnu/packages/configuration-management.scm | 41 +++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/configuration-management.scm b/gnu/packages/configuration-management.scm
index 36450ad70c..7b3601ce8f 100644
--- a/gnu/packages/configuration-management.scm
+++ b/gnu/packages/configuration-management.scm
@@ -20,6 +20,7 @@
 (define-module (gnu packages configuration-management)
   #:use-module (gnu packages)
   #:use-module (guix build-system go)
+  #:use-module (guix build-system pyproject)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module (gnu packages golang)
@@ -28,6 +29,8 @@ (define-module (gnu packages configuration-management)
   #:use-module (gnu packages golang-vcs)
   #:use-module (gnu packages golang-web)
   #:use-module (gnu packages golang-xyz)
+  #:use-module (gnu packages python-build)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages textutils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -117,3 +120,41 @@ (define-public chezmoi
     (description "This package helps to manage personal configuration files
 across multiple machines.")
     (license license:expat)))
+
+(define-public konsave
+  (package
+    (name "konsave")
+    (version "2.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Prayag2/konsave")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j5nszy41j4fd6b5w7188gphfk2s0dj44rs7fg55a4izvm0brbx9"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-pyyaml))
+    (native-inputs (list python-setuptools
+                         python-wheel))
+    (arguments
+     '(#:tests? #false ; no tests.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'sanity-check 'set-home-directory
+           ;; sanity-check requires a home directory since importing the
+           ;; `const.py' module creates a directory to save configurations.
+           (lambda _ (setenv "HOME" "/tmp") #t)))))
+    (home-page "https://github.com/prayag2/konsave")
+    (synopsis "Dotfiles manager")
+    (description
+     "Konsave is @acronym{CLI, Command Line Program} that lets you backup your dotfiles and
+switch to other ones.  Features:
+@itemize
+@item Storing configurations in profiles.
+@item Exporting profiles to '.knsv' files.
+@item Import profiles from '.knsv' files.
+@item Official support for KDE Plasma.
+@end itemize")
+    (license license:gpl3)))
-- 
2.49.0

Message #29 received at 78322 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 78322 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Konsave
Date: Fri, 09 May 2025 21:36:29 +0200

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:
> Hi,
>
> Thank you for the patch.
>
> Please check my review points and prepare updates in v2.

Done!

>> [PATCH] gnu: Add python-pytest-pylint.
> Place to python-check with
>
>   guix import -i gnu/packages/python-check.scm pypi pytest-pylint"
>
> It will import the package and save in the file in alphabetical order.

Sure.

>> [PATCH] gnu: Add konsave.
> Do you really want it in kde-utils as it requires to use quite a lot of
> new modules, how about python-xyz or python-web or even
> configuration-management (more likely according to description of the
> project)?
>
> From the upstream:
>> It officially supports KDE Plasma but it can be used on all other
>> desktop environments too!
> I'm not sure it may be a driving point to think it's just for KDE ;-)

Fair enough.

>> +    (native-inputs (list python-aiohttp
>> +                         python-aiohttp-cors
>> +                         python-black
>> +                         python-pylint
>> +                         python-setuptools
>> +                         python-wheel))
> No need for python-aiohttp python-aiohttp-cors python-black
> python-pylint, as tests are disabled and we usually ignore any dev
> dependencies (black, flake8, pylint and similar):
>
> setup.py:
>   -> install_requires=_REQUIREMENTS,
>     -> _REQUIREMENTS: List[str] = _read_reqs(Path("requirements.txt"))
>       -> PyYaml>=5.4.1

Removed.

>> +    (synopsis "Linux customization saver")
> It sounds miss leading as under "Linux customization" may be any sort of
> config files possible for Linux distros, according to farther description
> it's "dotfiles manager" so change to
> "Dotfiles manager" is more likely to reflect the purpose of the project.
>
>> +    "Konsave is command line program written in Python to let you backup your
>> +dotfiles and switch to other ones in an instant.  It officially supports KDE
>> +Plasma.")
> IMHO to mention which language the final CLI was written is ambiguous, I
> would reward it to something reflecting the purpose and a list of
> features, if remove "adetersment" we don't have much to have a clue what
> this CLI can do.

Right.

>> +    "Konsave is command line program .................... let you backup your
>> +dotfiles and switch to other ones in an instant.  ..........................
>> +.......")
>
>> +    (home-page "https://www.github.com/prayag2/konsave")
> change to "https://github.com/prayag2/konsave" as permament redirection

Done.

>> [PATCH] gnu: Add python-aiohttp-cors.
>
>> +    (native-inputs (list python-pytest-cov
>> +                         python-pytest-pylint
>> +                         python-pytest-runner
>> +                         python-selenium
>> +                         python-setuptools
>> +                         python-tox
>> +                         python-wheel))
> Pleas remove python-pytest-pylint, python-pytest-runner,
> python-selenium and python-tox; add python-pytest it will let
> pyproject-build-system to identify test runner automatically
>
>> +         (add-before 'check 'remove-network-dep
>> +           (lambda _
>> +             ;; Tests try to install from network even if its available
>> +             ;; locally.
>> +             (substitute* "setup.py"
>> +               (("\"aiohttp>=3.9\",") ""))))
>> +         ;; Tests run with `py.test' require a GUI browser window.
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (if tests?
>> +                 (invoke "tox")
>> +                 (format #t "test suite not run~%"))
>> +             #t)))))
> You can drop this, see above comment.

I've removed the ones not needed but `python-tox' is required. The check
phase needs to be replaced to not run the testsuite that requires a
graphical display and a browser GUI.

>> +    (description
>> +     "This library implements Cross Origin Resource Sharing (CORS)
>> +support for aiohttp asyncio-powered asynchronous HTTP server.")
>> +    (license license:asl2.0)))
> You can use @acronym{} for styling.

I didn't know about that.

Thanks for the review! I've sent the revised patch series with the 3
patches, I guess adding `python-aiohttp-cors' is no longer necessary so
you can drop that patch if you don't like how it is packaged.


Best regards,
Sergio.

Message #34 received at 78322-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 78322-done <at> debbugs.gnu.org
Subject: [PATCH] Add Konsave
Date: Sat, 10 May 2025 16:13:47 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for action on v2!

I've applied some minor modifications and pushed to master as:
ede4079205 * master origin/master gnu: Add konsave.
c64b548a09 * gnu: Add python-aiohttp-cors.
66dd876b50 * gnu: Add python-pytest-pylint.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.