GNU logs - #78390, boring messages

Message sent to csantosb@HIDDEN, ekaitz@HIDDEN, gabriel@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78390] [PATCH electronics-team] gnu: nextpnr: Add ecp5 and himbaechel architectures.
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: csantosb@HIDDEN, ekaitz@HIDDEN, gabriel@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Mon, 12 May 2025 12:17:02 +0000
Resent-Message-ID: <handler.78390.B.17470521923742 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78390 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb@HIDDEN>, Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Gabriel Wicki <gabriel@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Cayetano Santos <csantosb@HIDDEN>
Date: Mon, 12 May 2025 14:10:33 +0200
Message-ID: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=82.94.249.234;
 envelope-from=csantosb@HIDDEN; helo=latitanza.investici.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

* gnu/packages/fpga.scm (nextpnr): Add ecp5 and himbaechel architectures.

Change-Id: Ia4b92f6cd1693b844b35949fdc23369e958e73c1

---

[arguments] <#:configure-flags>: Add Add ecp5 and himbaechel.
<#:phases> {get-prjbeyond-db}: New phase.
{unbundle-sanitizers-cmake}: Simplify lambda.
[native-inputs]: Add prjtrellis.

 gnu/packages/fpga.scm | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index 2019700d72..4d767340cb 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -54,6 +54,7 @@ (define-module (gnu packages fpga)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cpp)
+  #:use-module (gnu packages electronics)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages gawk)
@@ -408,18 +409,36 @@ (define-public nextpnr
      (list
       #:cmake cmake                     ;CMake 3.25 or higher is required.
       #:configure-flags
-      #~(list "-DARCH=generic;ice40"    ;TODO: enable more architectures?
+      ;;TODO: enable more architectures?
+      #~(list "-DARCH=generic;ice40;ecp5;himbaechel"
               "-DBUILD_GUI=ON"
               "-DUSE_OPENMP=ON"
               "-DBUILD_TESTS=ON"
+              "-DHIMBAECHEL_UARCH=ng-ultra" ;gowin requires python-apycula.
+              "-DHIMBAECHEL_NGULTRA_DEVICES=ng-ultra"
+              "-DHIMBAECHEL_PRJBEYOND_DB=/tmp/prjbeyond-db"
               (string-append "-DCURRENT_GIT_VERSION=nextpnr-" #$version)
               (string-append "-DICESTORM_INSTALL_PREFIX="
                              #$(this-package-input "icestorm"))
+              (string-append "-DTRELLIS_INSTALL_PREFIX="
+                             #$(this-package-input "prjtrellis"))
               "-DUSE_IPO=OFF")
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'get-prjbeyond-db
+            (lambda _
+              (copy-recursively
+               #$(origin
+                   (method git-fetch)
+                   (uri (git-reference
+                         (url "https://github.com/yosyshq-GmbH/prjbeyond-db/")
+                         (commit "06d3b424dd0e52d678087c891c022544238fb9e3")))
+                   (sha256
+                    (base32
+                     "17dd3cgms2fy6xvz7magdmvv92km4cqh2kz9dyjrvz5y8caqav4y")))
+               "/tmp/prjbeyond-db")))
           (add-after 'unpack 'unbundle-sanitizers-cmake
-            (lambda* (#:key inputs #:allow-other-keys)
+            (lambda _
               (substitute* "CMakeLists.txt"
                 ;; Use the system sanitizers-cmake module.  This is made
                 ;; necessary 'sanitizers-cmake' installing a FindPackage
@@ -436,6 +455,7 @@ (define-public nextpnr
            corrosion
            eigen
            icestorm
+           prjtrellis
            pybind11
            python
            qtbase-5

base-commit: e4e43cebbacbbb7982d08f691636f3234fd60184
--
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Cayetano Santos <csantosb@HIDDEN>
Subject: bug#78390: Acknowledgement ([PATCH electronics-team] gnu:
 nextpnr: Add ecp5 and himbaechel architectures.)
Message-ID: <handler.78390.B.17470521923742.ack <at> debbugs.gnu.org>
References: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
X-Gnu-PR-Message: ack 78390
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 78390 <at> debbugs.gnu.org
Date: Mon, 12 May 2025 12:17:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN=
ch>, Gabriel Wicki <gabriel@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@g=
mail.com>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 78390 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78390: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78390
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#78390] [PATCH electronics-team] gnu: nextpnr: Add ecp5 and himbaechel architectures.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 15 May 2025 01:50:02 +0000
Resent-Message-ID: <handler.78390.B78390.174727376428261 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78390 <at> debbugs.gnu.org, GNU Debbugs <control <at> debbugs.gnu.org>, Gabriel Wicki <gabriel@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
 (Cayetano Santos's message of "Mon, 12 May 2025 14:10:33 +0200")
References: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
Date: Thu, 15 May 2025 10:49:04 +0900
Message-ID: <87r00qk5in.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

tags 78390 + moreinfo
thanks

Hello!

Cayetano Santos <csantosb@HIDDEN> writes:

> * gnu/packages/fpga.scm (nextpnr): Add ecp5 and himbaechel architectures.
>
> Change-Id: Ia4b92f6cd1693b844b35949fdc23369e958e73c1
>
> ---
>
> [arguments] <#:configure-flags>: Add Add ecp5 and himbaechel.
> <#:phases> {get-prjbeyond-db}: New phase.
> {unbundle-sanitizers-cmake}: Simplify lambda.
> [native-inputs]: Add prjtrellis.
>
>  gnu/packages/fpga.scm | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
> index 2019700d72..4d767340cb 100644
> --- a/gnu/packages/fpga.scm
> +++ b/gnu/packages/fpga.scm
> @@ -54,6 +54,7 @@ (define-module (gnu packages fpga)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages cpp)
> +  #:use-module (gnu packages electronics)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages gawk)
> @@ -408,18 +409,36 @@ (define-public nextpnr
>       (list
>        #:cmake cmake                     ;CMake 3.25 or higher is required.
>        #:configure-flags
> -      #~(list "-DARCH=generic;ice40"    ;TODO: enable more architectures?
> +      ;;TODO: enable more architectures?

punctuation nitpick: should be ';; TODO: Enable more architectures?'

> +      #~(list "-DARCH=generic;ice40;ecp5;himbaechel"
>                "-DBUILD_GUI=ON"
>                "-DUSE_OPENMP=ON"
>                "-DBUILD_TESTS=ON"
> +              "-DHIMBAECHEL_UARCH=ng-ultra" ;gowin requires python-apycula.

Feel free to drop punctuation for margin commits, such as the trailing
dot here.

> +              "-DHIMBAECHEL_NGULTRA_DEVICES=ng-ultra"
> +              "-DHIMBAECHEL_PRJBEYOND_DB=/tmp/prjbeyond-db"
>                (string-append "-DCURRENT_GIT_VERSION=nextpnr-" #$version)
>                (string-append "-DICESTORM_INSTALL_PREFIX="
>                               #$(this-package-input "icestorm"))
> +              (string-append "-DTRELLIS_INSTALL_PREFIX="
> +                             #$(this-package-input "prjtrellis"))
>                "-DUSE_IPO=OFF")
>        #:phases
>        #~(modify-phases %standard-phases
> +          (add-after 'unpack 'get-prjbeyond-db
> +            (lambda _

It'd be nice to add a comment explaining why this is useful here, and
perhaps mentioning which commit should be used when updating (the latest
one?) nextpnr.

Otherwise, LGTM!

-- 
Thanks,
Maxim

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 15 May 2025 01:49:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 14 21:49:23 2025
Received: from localhost ([127.0.0.1]:48071 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uFNis-0007LY-Tz
	for submit <at> debbugs.gnu.org; Wed, 14 May 2025 21:49:23 -0400
Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:57847)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1uFNil-0007JQ-M0; Wed, 14 May 2025 21:49:19 -0400
Received: by mail-pf1-x429.google.com with SMTP id
 d2e1a72fcca58-74019695377so366789b3a.3; 
 Wed, 14 May 2025 18:49:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1747273748; x=1747878548; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=Kl7cSJCqpZcw1Ekd+UeFsKKKOyyzQPJekT6qsFtSZZg=;
 b=KhzKMhpdlgmAFno4r/nLSkxBk51ubD4zrpvFWgbhGKKpxkZls4GAA1AjgVVyuZ4YeO
 feymt378dNf7fs5tC88mnDbtFfkfisCg0/xig7+DX44Phg8Z7oH0U5hikg4PWNS/rxpz
 07jrfYqI36/CvPkGtCYJdl/qgJDGOaIyl/zCck5ZsrtTAC0VoGFXezgLaqiL2BJdoUfq
 M6EA0Lwk/4xVCTKfVjk8USlCA22p4Ze3o6WXIFW3KdldfcI84Aq7si991ZYkL/5eRM7j
 6hk6VZ5uylZkd9Ac4Dx092pr3s+As74voObRxFTQQooazH1kLlL8gCjFv2eRYau9J0rl
 SV2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1747273748; x=1747878548;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=Kl7cSJCqpZcw1Ekd+UeFsKKKOyyzQPJekT6qsFtSZZg=;
 b=FOXPcefLCkvV1DiwyuDcEIyfz6yFnhuI0Uc0o6Oy5Lu+DKFznY6gjgHbpxZxWGt/Zu
 v0T85lEv3zfyxPnoHCScPa9E9uIorf/NEE8zVfIjukRg2gppUOZCy1TmnEbmfFxpj5Ak
 F81eVygQkoGY0A71p3In669hP1sldNyZCkoV9EC7znBO26Ugwt6GLGHXTlJPSE7Izkab
 4Itc9x+F+bQqBmZnnGF6jLNgX6BVZPCYAO9rhsw2mr57lT2H8aiFhCwuv2XqCXfT3AOb
 iSJxPF5dJb9a4+8rA8C/wDofSzncOWxRkoo6S7ZQSq6zIxZuJNwjGbj5+j5lImS0hQdH
 7NEA==
X-Forwarded-Encrypted: i=1;
 AJvYcCV2kY4/3NMQG5EhHZECS1pM/N3PLIWKHf+cYVMI2uoI8OYgt7SbTfbDy4toFtBsFGG6TSE4GScN <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0YwnLAryr0yX2NoWZqKfouj3G+Gv13bZiV74IKFHCu0+HNjaK8vo
 4ZIKnCtPRrd5Mmq7WtRdf+EGowWAXydGEeJd05LTtZjIZ47r1Q0UX1wuZG27
X-Gm-Gg: ASbGncu9Pq4Vjj3lvRBeLI5mPK8jhW0UzI7BiJ938GJEZ2DIVCksWYAojEHdGXeqoY5
 YrKJ3lUtMW5U9rMnXFxas9rVBB2MWlE+Sd957gNtx03rf5SzsMxdSwBZ+EBdjKmlKaajjp7j0OT
 Xe48dkO22a70DQgfKl4LJqWR1rDaSy3p/9r1jzCX0AKmzfp4aeTGKSUknmZ7Un7AFLy3lwlYB0M
 eZV4qj6qTzHNl+/Gfvo8Q2a4U2aszhwQpieK0loRlQPW2Eer/DubDYmPXROYzEbTF9GGQ0bpe3q
 /LBFY1a267qRs6NKJsFk/j2fhIFMaVmv7yG0AgruV9f50dZPcA==
X-Google-Smtp-Source: AGHT+IEbZfDKaAVEyM+jX45zYGkdHbHWwfK2IOy2TI5kUYBYxMTKvhl3ysnegEtUqDoYTglIX/O3Nw==
X-Received: by 2002:a05:6a00:21c4:b0:740:aa31:fe66 with SMTP id
 d2e1a72fcca58-74289263944mr7750438b3a.4.1747273748496; 
 Wed, 14 May 2025 18:49:08 -0700 (PDT)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-7423776109csm10287472b3a.82.2025.05.14.18.49.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 14 May 2025 18:49:07 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Cayetano Santos <csantosb@HIDDEN>
Subject: Re: [bug#78390] [PATCH electronics-team] gnu: nextpnr: Add ecp5 and
 himbaechel architectures.
In-Reply-To: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
 (Cayetano Santos's message of "Mon, 12 May 2025 14:10:33 +0200")
References: <279f0c297865b8963b03dd173d171d4d3fe2eaa7.1747051833.git.csantosb@HIDDEN>
Date: Thu, 15 May 2025 10:49:04 +0900
Message-ID: <87r00qk5in.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 78390 <at> debbugs.gnu.org, GNU Debbugs <control <at> debbugs.gnu.org>,
 Gabriel Wicki <gabriel@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 78390 + moreinfo
thanks

Hello!

Cayetano Santos <csantosb@HIDDEN> writes:

> * gnu/packages/fpga.scm (nextpnr): Add ecp5 and himbaechel architectures.
>
> Change-Id: Ia4b92f6cd1693b844b35949fdc23369e958e73c1
>
> ---
>
> [arguments] <#:configure-flags>: Add Add ecp5 and himbaechel.
> <#:phases> {get-prjbeyond-db}: New phase.
> {unbundle-sanitizers-cmake}: Simplify lambda.
> [native-inputs]: Add prjtrellis.
>
>  gnu/packages/fpga.scm | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
> index 2019700d72..4d767340cb 100644
> --- a/gnu/packages/fpga.scm
> +++ b/gnu/packages/fpga.scm
> @@ -54,6 +54,7 @@ (define-module (gnu packages fpga)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages cpp)
> +  #:use-module (gnu packages electronics)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages gawk)
> @@ -408,18 +409,36 @@ (define-public nextpnr
>       (list
>        #:cmake cmake                     ;CMake 3.25 or higher is required.
>        #:configure-flags
> -      #~(list "-DARCH=generic;ice40"    ;TODO: enable more architectures?
> +      ;;TODO: enable more architectures?

punctuation nitpick: should be ';; TODO: Enable more architectures?'

> +      #~(list "-DARCH=generic;ice40;ecp5;himbaechel"
>                "-DBUILD_GUI=ON"
>                "-DUSE_OPENMP=ON"
>                "-DBUILD_TESTS=ON"
> +              "-DHIMBAECHEL_UARCH=ng-ultra" ;gowin requires python-apycula.

Feel free to drop punctuation for margin commits, such as the trailing
dot here.

> +              "-DHIMBAECHEL_NGULTRA_DEVICES=ng-ultra"
> +              "-DHIMBAECHEL_PRJBEYOND_DB=/tmp/prjbeyond-db"
>                (string-append "-DCURRENT_GIT_VERSION=nextpnr-" #$version)
>                (string-append "-DICESTORM_INSTALL_PREFIX="
>                               #$(this-package-input "icestorm"))
> +              (string-append "-DTRELLIS_INSTALL_PREFIX="
> +                             #$(this-package-input "prjtrellis"))
>                "-DUSE_IPO=OFF")
>        #:phases
>        #~(modify-phases %standard-phases
> +          (add-after 'unpack 'get-prjbeyond-db
> +            (lambda _

It'd be nice to add a comment explaining why this is useful here, and
perhaps mentioning which commit should be used when updating (the latest
one?) nextpnr.

Otherwise, LGTM!

-- 
Thanks,
Maxim

Last modified: Thu, 15 May 2025 02:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.