GNU bug report logs - #78422
[PATCH electronics-team] gnu: Add python-apycula.

Previous Next

To reply to this bug, email your comments to 78422 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: Add python-apycula.
Date: Wed, 14 May 2025 12:30:07 +0200

* gnu/packages/electronics.scm (python-apycula): New variable.

Change-Id: I8e65416c1a555be189e9b8433d1ec7165aee16e9
---
 gnu/packages/electronics.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index da37a9fb33..36e1909d36 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -563,6 +563,39 @@ (define-public pulseview
 for sigrok.")
     (license license:gpl3+)))
 
+(define-public python-apycula
+  (package
+    (name "python-apycula")
+    (version "0.18")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/YosysHQ/apicula/")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0r1qx2q5dyjj3085g4ql41b21108m0s3wb7ylsy7xllvw527798l"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:tests? #f                       ;requires network
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'sanity-check-fix
+            (lambda _
+              (substitute* "setup.py"
+                (("'gowin_bba")
+                 "# 'gowin_bbva")))))))
+    (propagated-inputs (list python-crc))
+    (native-inputs (list python-setuptools python-wheel))
+    (home-page "https://github.com/YosysHQ/apicula/")
+    (synopsis "Gowin FPGA bitstream format")
+    (description
+     "The project Apycula provides tools to support development and
+generating bitstreams with Gowin FPGAs.")
+    (license license:expat)))
+
 (define-public python-edalize
   (package
     (name "python-edalize")

base-commit: 5f5d84beccc180f1b51474c0e47eb6e0d0c9175f
-- 
2.49.0

Message #8 received at 78422 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78422 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: [bug#78422] [PATCH electronics-team] gnu: Add python-apycula.
Date: Wed, 14 May 2025 12:39:31 +0200

On Wed, May 14, 2025 at 12:30:07PM +0200, Cayetano Santos wrote:
> +      #:tests? #f                       ;requires network
This is a pity - any chance we could disable just a single test that
needs networking or do all tests need it?
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'sanity-check-fix
> +            (lambda _
> +              (substitute* "setup.py"
> +                (("'gowin_bba")
> +                 "# 'gowin_bbva")))))))
You (probably) could just substitute with an empty string "" (aka
deleting) instead of commenting it out.  But it doesn't really matter.
Maybe a comment on why this fixes anything could be a nice pointer for
future us on why it is/was necessary?


Apart from these questions this LGTM.

If it builds, works as expected and the linter is happy this could be
merged IMO.


Thanks for your time and effort!
gabber

Message #11 received at 78422 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78422 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH electronics-team v2] gnu: Add python-apycula.
Date: Wed, 14 May 2025 14:24:12 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/electronics.scm (python-apycula): New variable.

Change-Id: I8e65416c1a555be189e9b8433d1ec7165aee16e9
Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---
 gnu/packages/electronics.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index da37a9fb33..4dc9264fbf 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -29,6 +29,7 @@ (define-module (gnu packages electronics)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system pyproject)
+  #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
@@ -563,6 +564,36 @@ (define-public pulseview
 for sigrok.")
     (license license:gpl3+)))
 
+(define-public python-apycula
+  (package
+    (name "python-apycula")
+    (version "0.18")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Apycula" version))
+       (sha256
+        (base32 "167jif24568q5b9d9zdrp60c1qnjxmanhld6q3wx251i3sgrfilx"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:tests? #f                       ;requires network
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'sanity-check-fix
+            (lambda _
+              (substitute* "setup.py"
+                (("'gowin_bba")
+                 "# 'gowin_bbva")))))))
+    (propagated-inputs (list python-crc))
+    (native-inputs (list python-setuptools python-wheel))
+    (home-page "https://github.com/YosysHQ/apicula/")
+    (synopsis "Gowin FPGA bitstream format")
+    (description
+     "The project Apycula provides tools to support development and
+generating bitstreams with Gowin FPGAs.")
+    (license license:expat)))
+
 (define-public python-edalize
   (package
     (name "python-edalize")

base-commit: 5f5d84beccc180f1b51474c0e47eb6e0d0c9175f
-- 
2.49.0

Message #14 received at 78422 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78425 <at> debbugs.gnu.org, 78422 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: [bug#78425] [PATCH electronics-team v2] gnu: Add python-apycula.
Date: Thu, 15 May 2025 08:45:42 +0200

Hi!

It seems like you did neither answer nor address any of my questions
from the previous review.  And I have a hard time finding any
differences between the original patch and this v2 (at least by naked
eye).  Is this by mistake?  Would you mind answering my questions, so we
can find ways for this patch to land optimally?

Thanks - again - for your time and effort!

gabber

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.