GNU logs - #78465, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode
Resent-From: Lin Sun <sunlin7@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 17 May 2025 07:10:02 +0000
Resent-Message-ID: <handler.78465.B.174746576120080 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78465 <at> debbugs.gnu.org
From: Lin Sun <sunlin7@HIDDEN>
Thread-Topic: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened
 in binary mode
Thread-Index: AQHbxvm5gFfKK4jAGkSBPn5hzfYb9w==
Date: Sat, 17 May 2025 07:09:06 +0000
Message-ID: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
msip_labels: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TY3PR01MB11921:EE_
x-ms-office365-filtering-correlation-id: 33d086c0-9e52-4bde-cd53-08dd9511b696
x-microsoft-antispam: BCL:0;
 ARA:14566002|6092099012|461199028|15080799009|19110799006|7092599006|15030799003|8060799009|8062599006|13095399003|440099028|3412199025|102099032;
x-microsoft-antispam-message-info: aKayGXGohAv+Yh/Ys0y1zopkz+QrMQKsO7j4mcWqQmT7ydYIwAO58YtGCSUjoKytQSYEqgtX0H5gHw2sBFDcSshCVZWaPoGFhQI6t584RH+2iFld6XPH5sVCdoOPOmuZREx64PhL/Qyl2Ms0oJHvRokLsrAA1DocGvq6ne+t+m7vPc6/5dJY0nKpp0+piz1DCCSNvGquxOj9zjx0VhrHTj7C5rUgF99a7KTsiJAqMFpeYuaYkpbEdpcIThY6gT6yAwAOXKIcUpSEjnTm53XgQeqObpvn+6cn6ueoD1TNCWYKBYv+pV44o7y0FJVOG4BSKuqPYJWZ85kUOdmXvnaAitwAWK1Tjqi67jy2sbVZPfESI5SC3m8RZRD3vcgmIGqgQ3zgsPLY0H4v83fQ9lYyN0ciL/+7HsA7BitPC4wUi4ZjwgSnB7ceWE7JkTECCqNtAdxe9mFo2hC+RpFsZ+UpHXb0K4dFWhHOUIlW8igZNIRhopGx30DPE1mGLIhgvSBimj8WBSFbzqoA0clvNh20arEvqIgqQk4DNzFjD0c5iTL3eNl4P+nIYIWaA4i63boXAxFs3u4BaMiwCsSd6tdYschAb+g0r+Hcf54BTW8Ue4UduLDMxNxn12IVTRo4xb8MiI6q21qP9MAr4Ed/C7u1Ond3jU4MOBzVnBR/TkSZb7Vss7XzcQNPDAK3MyDJ21+DXJH99iupJ/D+DKDAoGiNF9bD0Obnwh0t15rIANLqKtVEDzOAT1QoEmOiL5wx9KzQUBA+NdN59PXFPChD5amYZV+/PSOzGmVtsOWS/FtT4yWqD0zirVEa94Sv08Us3ehAYc84iqGQM2v+nybNJiLOwm/XbTBiXZoqlcb9mLclJvRVkFrNeZwxDwtFTpxpnfO5ygoyml2uNW6XlMZFyDoQc9IrNnfbHGftfnnWHU9IThzRTnOe6Nfaj0trVlUYggD5XrqH5levZJLx+nmTBZMWYWxgvE0VIQnFKGtE2EFohAEURFp1QEstCp17U22rYpb2qCzP+FIPPVFzy/PJWTol6O+Znezk/VAjmubZtH9TBazbfQIIWjkLrL3SqdNikzEl91kUbqr4L8KhJ4ez+1UJJOPjtj1yUyISegYFe7dKwEHE/lOxdhfDJu3lKC4lWmN5XoKRoYVRA931VGvVQu1bCozalPkOVSLqsy7QSJ/PplUa/fhG8LsBVU+46HM1/OrgG26lk8Zd9lJmcdpz6AlofA==
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: dsxPbFR7vkIksj2BJRU53t5RWnc5BxzAuIjWMA5KUMLo+2MGx7VcwXs4wyKEx54RcdJPQZ+zMdqyvJNmXCDwdLvsplWgTyRpBMc+smgYYkrrGj2rPCxR1xvYssTeaaOAdrI+4gkaoMELzOXWmAIQdtOi0SUu/TGP8YWk47mwLglM7D0s/3PxYOZeZrWfTQGKysnRpqcSDU1SVsV5LA3h+X54mBtieTEI60+N96RnD6p9jLXPx58O6m6oZp5LUzKVYu8hvYhS+lV80ZGEvpG/ohKsZSqoNlSE0t5nfq5C+OPSWznTKulPeF3ipxQxE5UkoJfJ8SZZB3WUdZQYmJvHm7kU/iU9jN5CXD6y32jVh9kABDEM7skDPUjKTjWQx1Ah4/aoPFGUtwdWvqqMHgALvXE9myDEyyqULEv/XLEy1fOCYaExURSa0fc924QtawnfBok6Zcuq2QVwgA8KE7yAks8QJX1a0x/JFaEBlOhzeNSX1MBII/BOh+mUUn5Earu8gjCBA9UuSCubsQZdZbB/wbPKCQFOyuGgx6Vnxbv9SiiF2iNe48QPJvUUhhS5bGzVGTHcUwfW5rm7FqquM8dI4V7AOV5H25bwmnKJ5frmfFZwm9jnNdg1bEGdnMJ6wSHGlhARarJgry7GrcmocXAVTXrt1l8j69e4yNUXnYNvz6/dVSihJdMv6CyWtlOIAeWGQhb1PMJDsG0atXVqqcsZpbJsdngz4eMEIovvwUCboLpRI1ATB0pdewXdFG43l0nhZVlkQaFbNqGttCLcxaBIV5vcW6Hx8S/WFuEeNtkDKU0gc3dVaCbQDHn7EGm8OKYNU5L+u53K2Xx0pOLtUfOEcfMcXlLEELQMNNumGckHhOepACQD0dCNeAuqOgbRVSPXw8K9dZ+1/X8W4RkeRDcixQTKBgQlyD771NB++wYQs1VQGkXXx/z9XsDbz9JJzQLFmxS8RIxfyBtJHQuWcO1XYpRqe77if5slECehbLZSf4l2THmeC9KQk/yRXUPRbLbb3d6JtZ+TNIUzUNlQowsTDlOoJoMQoHnZ9kQhnRhvE92fWSonwKit69Pm4Q9NbOOh1dgMuiWBqZvgLo6SoKWaycttCcU6fFTrJ3/io1bQnG8F7VX6BIF0ZW9tczuN7DoTmS9YZbi4XQxXoSWkSRnbWqs3FfKHD6S2nTfYwfRrCXrenPzCFmFska4tJta759DBOcgWIcfkbEBn7zvDQkqRfA==
Content-Type: multipart/mixed;
 boundary="_002_TYCPR01MB1000491A72E74B80478C1551CFB92ATYCPR01MB10004jp_"
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 33d086c0-9e52-4bde-cd53-08dd9511b696
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2025 07:09:06.6624 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB11921
Received-SPF: pass client-ip=2a01:111:f403:d407::;
 envelope-from=sunlin7@HIDDEN;
 helo=OS0P286CU010.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.

 Content preview:  This patch will let Emacs avoid always close the fd then open
    the file with desired fmode in the "Fload" function on windows. It will reduce
    the counts on calling the "CreateFile"=?UTF-8?Q?=A0api.?= On my dev windows environment,
    Emacs startup time reduces from 4.551s to 4.378s with 352 =?UTF-8?Q?packages.=A0?= 

 Content analysis details:   (1.2 points, 10.0 required)

  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
                              no trust
                             [2001:470:142:0:0:0:0:17 listed in]
                             [list.dnswl.org]
  0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=sunlin7%40hotmail.com;ip=2001%3A470%3A142%3A%3A17;r=debbugs.gnu.org]
  0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
                             in digit (sunlin7[at]hotmail.com)
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (sunlin7[at]hotmail.com)
  0.0 SPOOFED_FREEMAIL       No description available.
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

--_002_TYCPR01MB1000491A72E74B80478C1551CFB92ATYCPR01MB10004jp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

This patch will let Emacs avoid always close the fd then open the file with=
 desired fmode in the "Fload" function on windows. It will reduce the count=
s on calling the "CreateFile"=A0api.=0A=
=0A=
On my dev windows environment, Emacs startup time reduces from 4.551s to 4.=
378s with 352 packages.=A0=0A=

--_002_TYCPR01MB1000491A72E74B80478C1551CFB92ATYCPR01MB10004jp_
Content-Type: text/x-patch;
	name="0001-src-lread.c-load-Try-reuse-the-fd-if-it-was-open-on-.patch"
Content-Description:  0001-src-lread.c-load-Try-reuse-the-fd-if-it-was-open-on-.patch
Content-Disposition: attachment;
	filename="0001-src-lread.c-load-Try-reuse-the-fd-if-it-was-open-on-.patch";
	size=1152; creation-date="Sat, 17 May 2025 07:07:44 GMT";
	modification-date="Sat, 17 May 2025 07:07:44 GMT"
Content-Transfer-Encoding: base64

RnJvbSBmNDI1YWI4ZjZiYmEyYmU3NjVkNjBlZDc2NGVkN2ZhMzBlOThjZGE4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBG
cmksIDE2IE1heSAyMDI1IDA2OjMwOjQ5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gKiBzcmMvbHJl
YWQuYyAobG9hZCk6IFRyeSByZXVzZSB0aGUgZmQgaWYgaXQgd2FzIG9wZW4gb24KIGJpbmFyeSBt
b2RlCgotLS0KIHNyYy9scmVhZC5jIHwgMTUgKysrKysrKysrKystLS0tCiAxIGZpbGUgY2hhbmdl
ZCwgMTEgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvbHJl
YWQuYyBiL3NyYy9scmVhZC5jCmluZGV4IDk1YzllNzEuLjRkM2JkMDIgMTAwNjQ0Ci0tLSBhL3Ny
Yy9scmVhZC5jCisrKyBiL3NyYy9scmVhZC5jCkBAIC0xNjQ1LDEwICsxNjQ1LDE3IEBAIERFRlVO
ICgibG9hZCIsIEZsb2FkLCBTbG9hZCwgMSwgNSwgMCwKICAgZWxzZSBpZiAoIWlzX21vZHVsZSAm
JiAhaXNfbmF0aXZlX2VsaXNwKQogICAgIHsKICNpZmRlZiBXSU5ET1dTTlQKLSAgICAgIGVtYWNz
X2Nsb3NlIChmZCk7Ci0gICAgICBjbGVhcl91bndpbmRfcHJvdGVjdCAoZmRfaW5kZXgpOwotICAg
ICAgZWZvdW5kID0gRU5DT0RFX0ZJTEUgKGZvdW5kKTsKLSAgICAgIHN0cmVhbSA9IGVtYWNzX2Zv
cGVuIChTU0RBVEEgKGVmb3VuZCksIGZtb2RlKTsKKyAgICAgIC8qIGZkb3BlbigpIGEgZmQgd2l0
aCBkaWZmZXJlbnQgZm1vZGUgYXMgdGhlIGZkIHdhcyBvcGVuZWQgaXMKKwkgdW5kZWZpbmVkIGJl
aGF2aW9yIG9uIFdpbmRvd3MuICovCisgICAgICBpZiAoZm1vZGVbMV0gPT0gRk9QRU5fQklOQVJZ
KQorCXN0cmVhbSA9IGVtYWNzX2Zkb3BlbiAoZmQsIGZtb2RlKTsKKyAgICAgIGVsc2UKKwl7CisJ
ICBlbWFjc19jbG9zZSAoZmQpOworCSAgY2xlYXJfdW53aW5kX3Byb3RlY3QgKGZkX2luZGV4KTsK
KwkgIGVmb3VuZCA9IEVOQ09ERV9GSUxFIChmb3VuZCk7CisJICBzdHJlYW0gPSBlbWFjc19mb3Bl
biAoU1NEQVRBIChlZm91bmQpLCBmbW9kZSk7CisJfQogI2Vsc2UKICNpZiAhZGVmaW5lZCBVU0Vf
QU5EUk9JRF9BU1NFVFMKICAgICAgIHN0cmVhbSA9IGVtYWNzX2Zkb3BlbiAoZmQsIGZtb2RlKTsK
LS0gCjIuNDkuMAoK

--_002_TYCPR01MB1000491A72E74B80478C1551CFB92ATYCPR01MB10004jp_--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Lin Sun <sunlin7@HIDDEN>
Subject: bug#78465: Acknowledgement ([PATCH] * src/lread.c (load): Try
 reuse the fd if it was opened in binary mode)
Message-ID: <handler.78465.B.174746576120080.ack <at> debbugs.gnu.org>
References: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
X-Gnu-PR-Message: ack 78465
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 78465 <at> debbugs.gnu.org
Date: Sat, 17 May 2025 07:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 78465 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78465: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78465
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 17 May 2025 07:49:02 +0000
Resent-Message-ID: <handler.78465.B78465.174746810730224 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Lin Sun <sunlin7@HIDDEN>
Cc: 78465 <at> debbugs.gnu.org
Date: Sat, 17 May 2025 10:48:15 +0300
Message-Id: <86y0uvwudc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
 (message from Lin Sun on Sat, 17 May 2025 07:09:06 +0000)
References: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

tags 78465 wontfix
thanks

> From: Lin Sun <sunlin7@HIDDEN>
> Date: Sat, 17 May 2025 07:09:06 +0000
> msip_labels: 
> 
> This patch will let Emacs avoid always close the fd then open the file with desired fmode in the "Fload" function on windows. It will reduce the counts on calling the "CreateFile"�api.
> 
> On my dev windows environment, Emacs startup time reduces from 4.551s to 4.378s with 352 packages.�

Thanks, but I don't think we should install this.  fdopen on Windows
has all kinds of subtleties and idiosyncrasies, which is the reason
why we don't use fdopen here.  This code has seen several changes in
the past due to those problems, and I don't want to risk reintroducing
them again, certainly not for the benefit of a mere 3.8% reduction in
load time.  It just isn't worth the risk.

Sorry.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 May 2025 07:48:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 17 03:48:28 2025
Received: from localhost ([127.0.0.1]:44991 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uGCHT-0007rT-Hy
	for submit <at> debbugs.gnu.org; Sat, 17 May 2025 03:48:27 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:32892)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>)
 id 1uGCHR-0007r0-B8; Sat, 17 May 2025 03:48:25 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1uGCHL-00059Y-3v; Sat, 17 May 2025 03:48:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=asAFRNX0Fpa5LQjEYv0iZLb0HL3AKgsJ7QX6XNq7uKM=; b=i+B6dR/La+WWSpf7Fs5/
 pzT5w0gxNfFamea8gzHfsTDnW0oMLUyVUl5lyXdmjbUoVDRqOczQlzEVUUvXncwpk2Ona06xim6Px
 TIdS8ayLg6jf4hDdrQgzCL+NIqKeQySwuDpt2okPMEIm9jzyN4LCBTl0dJlm0KDHNfhyNWANDsR7x
 K1NZkfStHBWVZ0S2TFrSmspwx/elsAu9wwvydcdu9/giHJlf2XgVWHSplK78EHfyaYSOgw4jY39bW
 2mm4QFNrXl27z48BXRVwGVehMwB0a06tPZnxSh59N1sAPGSYfagkj81g0Qzl3E+yccPUAEjewIqyd
 XuYVroPpsZ7StA==;
Date: Sat, 17 May 2025 10:48:15 +0300
Message-Id: <86y0uvwudc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Lin Sun <sunlin7@HIDDEN>
In-Reply-To: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
 (message from Lin Sun on Sat, 17 May 2025 07:09:06 +0000)
Subject: Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it
 was opened in binary mode
References: <TYCPR01MB1000491A72E74B80478C1551CFB92A@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: 78465 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 78465 wontfix
thanks

> From: Lin Sun <sunlin7@HIDDEN>
> Date: Sat, 17 May 2025 07:09:06 +0000
> msip_labels: 
> 
> This patch will let Emacs avoid always close the fd then open the file with desired fmode in the "Fload" function on windows. It will reduce the counts on calling the "CreateFile"�api.
> 
> On my dev windows environment, Emacs startup time reduces from 4.551s to 4.378s with 352 packages.�

Thanks, but I don't think we should install this.  fdopen on Windows
has all kinds of subtleties and idiosyncrasies, which is the reason
why we don't use fdopen here.  This code has seen several changes in
the past due to those problems, and I don't want to risk reintroducing
them again, certainly not for the benefit of a mere 3.8% reduction in
load time.  It just isn't worth the risk.

Sorry.

Last modified: Sat, 17 May 2025 08:00:06 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.