GNU logs - #78503, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78503: 30.0.92; tree-sitter elixir-ts-mode structural movement broken
Resent-From: Bart Otten <bart.otten85@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 May 2025 04:30:03 +0000
Resent-Message-ID: <handler.78503.B.17477153602706 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78503 <at> debbugs.gnu.org
From: Bart Otten <bart.otten85@HIDDEN>
Date: Tue, 20 May 2025 00:10:54 +0200
Message-ID: <m2wmacdzf5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::534;
 envelope-from=bart.otten85@HIDDEN; helo=mail-ed1-x534.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Greetings and salutions, Trying to use elixir treesit mode, 
 it seems the navigation of defun and lists seems broken. 1.) `defmodule`
 is considered a function definition and so moving up from the first actual
 function definition `def my_fun do` causes the point to jump to 'defmodule
 my_mod do'. Invoking `end-of-defun [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (bart.otten85[at]gmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (bart.otten85[at]gmail.com)
X-Mailman-Approved-At: Tue, 20 May 2025 00:29:16 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

Greetings and salutions,

Trying to use elixir treesit mode, it seems the navigation of defun and lists seems broken.

1.) `defmodule` is considered a function definition and so moving up from the first
actual function definition `def my_fun do` causes the point to jump to
'defmodule my_mod do'. Invoking `end-of-defun` jumps to the end of the defmodule block.
Effectively, you have been ejected from the module body.

;; current scoped workaround
;; does not jump up to defmodule when using `beginning-of-defun`
(defun elixir-ts--defun-p (node)
  "Return non-nil when NODE is a defun."
  (member (treesit-node-text
           (treesit-node-child-by-field-name node "target"))
          (append
           (remove "defmodule" elixir-ts--definition-keywords)
elixir-ts--test-definition-keywords)))


2.) When you use `down-list` while on a function definition line,
nothing happens. I tried to fix it, ony to find out that
`backward-up-list` will jump to `defmodule` when invoked while point is at a
function argument, instead of navigating out of the argument list only.  

Structural movement might need some extra love.

Cheers,
Bart


Major mode: Elixir

Minor modes in effect:
  electric-pair-mode: t
  eglot--managed-mode: t
  exunit-mode: t
  mix-minor-mode: t
  global-org-modern-mode: t
  display-line-numbers-mode: t
  global-treesit-auto-mode: t
  doom-modeline-mode: t
  which-key-mode: t
  org-super-agenda-mode: t
  undo-fu-session-global-mode: t
  undo-fu-session-mode: t
  apprentice-mode: t
  apprentice-hooks-mode: t
  flymake-mode: t
  yas-minor-mode: t
  treesit-inspect-mode: t
  global-visual-wrap-prefix-mode: t
  visual-wrap-prefix-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  prettify-symbols-mode: t

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Bart Otten <bart.otten85@HIDDEN>
Subject: bug#78503: Acknowledgement (30.0.92; tree-sitter elixir-ts-mode
 structural movement broken)
Message-ID: <handler.78503.B.17477153602706.ack <at> debbugs.gnu.org>
References: <m2wmacdzf5.fsf@HIDDEN>
X-Gnu-PR-Message: ack 78503
X-Gnu-PR-Package: emacs
Reply-To: 78503 <at> debbugs.gnu.org
Date: Tue, 20 May 2025 04:30:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 78503 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78503: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78503
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78503: 30.0.92; tree-sitter elixir-ts-mode structural movement broken
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 May 2025 06:56:02 +0000
Resent-Message-ID: <handler.78503.B78503.174772415810302 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Bart Otten <bart.otten85@HIDDEN>
Cc: Wilhelm H Kirschbaum <wkirschbaum@HIDDEN>, 78503 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <m2wmacdzf5.fsf@HIDDEN>
Organization: LINKOV.NET
References: <m2wmacdzf5.fsf@HIDDEN>
Date: Tue, 20 May 2025 09:46:34 +0300
Message-ID: <87bjrnn5r5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Trying to use elixir treesit mode, it seems the navigation of defun and lists seems broken.
>
> 1.) `defmodule` is considered a function definition and so moving up from the first
> actual function definition `def my_fun do` causes the point to jump to
> 'defmodule my_mod do'. Invoking `end-of-defun` jumps to the end of the defmodule block.
> Effectively, you have been ejected from the module body.
>
> ;; current scoped workaround
> ;; does not jump up to defmodule when using `beginning-of-defun`
> (defun elixir-ts--defun-p (node)
>   "Return non-nil when NODE is a defun."
>   (member (treesit-node-text
>            (treesit-node-child-by-field-name node "target"))
>           (append
>            (remove "defmodule" elixir-ts--definition-keywords)
>           elixir-ts--test-definition-keywords)))

This behavior may look logically flawed,
but still it makes sense for user convenience:
while navigating with 'C-M-a' it's handy
to use the same key to move over modules too.

The same navigation exists in other ts-modes as well:
for example, in java-ts-mode 'C-M-a' moves over classes, etc.
OTOH, in ruby-ts-mode it's restricted to methods only.

> 2.) When you use `down-list` while on a function definition line,
> nothing happens. I tried to fix it, ony to find out that
> `backward-up-list` will jump to `defmodule` when invoked while point is at a
> function argument, instead of navigating out of the argument list only.  
>
> Structural movement might need some extra love.

This part is not reproducible.  Do you use the latest master?

Last modified: Tue, 20 May 2025 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.