GNU bug report logs - #78525
[PATCH] test: Skip a test that fails without python enabled.

Previous Next

To reply to this bug, email your comments to 78525 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: automake-patches <at> gnu.org
Subject: [PATCH] test: Skip a test that fails without python enabled.
Date: Tue, 20 May 2025 22:08:56 -0700

[Message part 1 (text/plain, inline)]

On a system without Python 't/py-compile-usage' fails with:

    + ./py-compile --help
    + cat stdout
    py-compile: Invalid python executable (according to -V): python
    py-compile: Python support disabled
    + test -s stderr
    + grep '^Usage: py-compile .' stdout
    + am_exit_trap 1
    + exit_status=1

This occurs after the following commit:

    commit 0ea7ef97493cd88da915d1936e04a6ace5c754d8
    Author: Karl Berry <karl <at> freefriends.org>
    Date:   Sun Feb 9 09:36:24 2025 -0800
    
        python: restore more compatible behavior for $PYTHON.
        
        For https://bugs.gnu.org/74434.
        
        * lib/py-compile: if $PYTHON -V does not include the
        string "python" (case-insensitive), consider the support
        intentionally disabled and exit successfully, unless PYTHON is set
        to false, in which case exit unsuccessfully. This is closer to
        the old behavior. Mention this in the help message.
        * t/py-compile-env.sh: add test for PYTHON=:.
        * NEWS: mention this. (And, en passant, add some past bug#s and
        clarify that only RCS/SCCS pattern rules were disabled, not all.)
    
Simple 1 line fix attached. :)

Collin

[0001-test-Skip-a-test-that-fails-without-python-enabled.patch (text/x-patch, attachment)]

Message #10 received at 78525-done <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: collin.funk1 <at> gmail.com
Cc: 78525 <at> debbugs.gnu.org
Subject: Re: [bug#78525] [PATCH] test: Skip a test that fails without python
 enabled.
Date: Wed, 21 May 2025 14:18:35 -0600

    --- a/t/py-compile-usage.sh
    +++ b/t/py-compile-usage.sh
    @@ -17,6 +17,7 @@
     # Test 'py-compile --help', 'py-compile --version', and that 'py-compile'
     # correctly complains on wrong usage.

    +required=python

Installed and closing. Thanks Collin.

BTW, do you have any idea why the "From " line in your patch is dated
from 2001?
From 5f9001d17fa17088468b650a26a6f876dcdca161 Mon Sep 17 00:00:00 2001

Doesn't matter. Just seemed curious. --thanks, karl.

Message #16 received at 78525 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Karl Berry <karl <at> freefriends.org>
Cc: 78525 <at> debbugs.gnu.org
Subject: Re: [bug#78525] [PATCH] test: Skip a test that fails without python
 enabled.
Date: Wed, 21 May 2025 13:31:22 -0700

Hi Karl,

Karl Berry <karl <at> freefriends.org> writes:

> Installed and closing. Thanks Collin.
>
> BTW, do you have any idea why the "From " line in your patch is dated
> from 2001?
> From 5f9001d17fa17088468b650a26a6f876dcdca161 Mon Sep 17 00:00:00 2001
>
> Doesn't matter. Just seemed curious. --thanks, karl.

I generate my patches using 'git format-patch' [1]. So in this case when I
have one patch I use the command 'git format-patch -1'.

These patches can easily be applied with the correct author and such
with 'git am' [2]. In this case as the Automake maintainer with commit
access you can run:

    $ git am 0001-test-Skip-a-test-that-fails-without-python-enabled.patch
    $ git push

And it will be correct assuming no merge conflicts or other issues. The
date "Mon Sep 17 00:00:00 2001" is a magic date used by git [3].

Hopefully I explained that well enough. :)

Collin

[1] https://git-scm.com/docs/git-format-patch
[2] https://git-scm.com/docs/git-am
[3] https://github.com/git/git/blob/8613c2bb6cd16ef530dc5dd74d3b818a1ccbf1c0/mailinfo.c#L371C50-L371C73

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.