GNU bug report logs - #78550
[PATCH 0/2] gnu: Add go-mtpfs.

Previous Next

To reply to this bug, email your comments to 78550 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: Add go-mtpfs.
Date: Thu, 22 May 2025 21:32:40 +0700

This patchsets adds go-mtpfs (https://github.com/hanwen/go-mtpfs).
Go-mtpfs is a simple FUSE filesystem for mounting Android devices as a MTP device.

Junker (2):
  gnu: Add go-github-com-hanwen-usb.
  gnu: Add go-mtpfs.

 gnu/packages/libusb.scm | 59 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)


base-commit: 11bc17c409d77cd1af91e30b5b9f6a73f873a152
-- 
2.49.0

Message #8 received at 78550 <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: 78550 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add go-github-com-hanwen-usb.
Date: Thu, 22 May 2025 21:39:23 +0700

* gnu/packages/libusb.scm (go-github-com-hanwen-usb): New variable.

Change-Id: I4a70f9adf0b33bd669162cbb8e329ae6c10a6a56
---
 gnu/packages/libusb.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
index a6e24f8c41..ebb3d8a92a 100644
--- a/gnu/packages/libusb.scm
+++ b/gnu/packages/libusb.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2023 Foundation Devices, Inc. <hello <at> foundationdevices.com>
 ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
+;;; Copyright © 2025 Junker <dk <at> junkeria.club>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -209,6 +210,33 @@ (define-public go-github-com-google-gousb
 Go-like binding.")
     (license license:asl2.0)))
 
+(define-public go-github-com-hanwen-usb
+  (let ((commit "69aee4530ac705cec7c5344418d982aaf15cf0b1")
+        (revision "1"))
+    (package
+      (name "go-github-com-hanwen-usb")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/hanwen/usb")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "01k0c2g395j65vm1w37mmrfkg6nm900khjrrizzpmx8f8yf20dky"))))
+      (build-system go-build-system)
+      (inputs (list libusb))
+      (native-inputs (list pkg-config))
+      (arguments
+       (list
+        #:tests? #f ;no tests
+        #:import-path "github.com/hanwen/usb"))
+      (home-page "https://github.com/hanwen/usb")
+      (synopsis "CGO bindings for libusb")
+      (description "These are CGO bindings for libusb")
+      (license license:bsd-3))))
+
 (define-public java-usb4java
   (package
     (name "java-usb4java")
-- 
2.49.0

Message #11 received at 78550 <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: 78550 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add go-mtpfs.
Date: Thu, 22 May 2025 21:40:32 +0700

* gnu/packages/libusb.scm (go-mtpfs): New variable.

Change-Id: I08e5fa08eb1844efa3294be5d2006118c25eb186
---
 gnu/packages/libusb.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
index ebb3d8a92a..9d1b5066e8 100644
--- a/gnu/packages/libusb.scm
+++ b/gnu/packages/libusb.scm
@@ -52,6 +52,7 @@ (define-module (gnu packages libusb)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang-xyz)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
@@ -237,6 +238,36 @@ (define-public go-github-com-hanwen-usb
       (description "These are CGO bindings for libusb")
       (license license:bsd-3))))
 
+(define-public go-mtpfs
+  (package
+    (name "go-mtpfs")
+    (version "1.0.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/hanwen/go-mtpfs")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1k77zglpgb5424hpnc270yj27x1rb2wp4b8y5xchd6h8ygrw2mqx"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:import-path "github.com/hanwen/go-mtpfs"))
+    (inputs (list libusb))
+    (native-inputs (list pkg-config))
+    (propagated-inputs (list go-github-com-hanwen-usb
+                             go-github-com-hanwen-go-fuse-v2
+                             go-github-com-hanwen-go-fuse))
+    (home-page "https://github.com/hanwen/go-mtpfs")
+    (synopsis "Mount MTP devices as a filesystem")
+    (description
+     "Go-mtpfs is a simple FUSE filesystem for mounting Android devices as a MTP
+device.")
+    (license license:bsd-3)))
+
 (define-public java-usb4java
   (package
     (name "java-usb4java")
-- 
2.49.0

Message #14 received at 78550 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 78550 <at> debbugs.gnu.org
Subject: [PATCH 0/2] gnu: Add go-mtpfs.
Date: Mon, 26 May 2025 18:08:31 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the patch.

The project looks like abandoned in GitHub, no updates for the last 6y.
It's the latest commit:
<https://github.com/hanwen/go-mtpfs/commit/42254b1935eb89625d0c8b61bb8128db2cd3c22f>

One note on package placment:
- go-mtpfs this may go to (gnu packages file-systems) to prevent
importing golang-xyz into lower level module.

--8<---------------cut here---------------start------------->8---
+      (description "These are CGO bindings for libusb")
--8<---------------cut here---------------end--------------->8---
It might be not enought for a description, please compile at least a
whole sentence ending with dot (full stop ".") and try to apply
'guix lint' it will highlight issues like that.

--8<---------------cut here---------------start------------->8---
+      (native-inputs (list pkg-config))
+      (arguments
+       (list
+        #:tests? #f ;no tests
--8<---------------cut here---------------end--------------->8---
There are tests  <https://github.com/hanwen/usb/blob/master/usb_test.go>

--8<---------------cut here---------------start------------->8---
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:import-path "github.com/hanwen/go-mtpfs"))
--8<---------------cut here---------------end--------------->8---
There are tests, please try to run them and provide some feedback in
comment why they failed and disabled.

You may send v2 to <https://codeberg.org/guix/guix> as a PR.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.