GNU bug report logs - #78594
[PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify variable-use consistently

Previous Next

To reply to this bug, email your comments to 78594 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify
 variable-use consistently
Date: Mon, 26 May 2025 19:02:04 +0200

[Message part 1 (text/plain, inline)]

Hey everyone!

I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.

Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.

Attached is a patch which seeks to remedy the situation. Let me know what you think :) 



—
Kind Regards
Jostein Kjønigsen

[Message part 2 (text/html, inline)]

[0001-typescrip-ts-mode.el-Fontificatiomn-improvements.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Message #8 received at 78594 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
 Konstantin Kharlamov <Hi-Angel <at> yandex.ru>,
 Yuan Fu <casouri <at> gmail.com>, Juri Linkov <juri <at> linkov.net>
Cc: 78594 <at> debbugs.gnu.org
Subject: Re: bug#78594: [PATCH] 31.0.50;
 typescript-ts-mode & tsx-ts-mode does not fontify variable-use
 consistently
Date: Mon, 26 May 2025 21:29:31 +0300

> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Mon, 26 May 2025 19:02:04 +0200
> 
> Hey everyone!
> 
> I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.
> 
> Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.
> 
> Attached is a patch which seeks to remedy the situation. Let me know what you think :) 

Thanks, I'm adding to the discussion people who lately made changes in
these modes.

Message #11 received at 78594 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>, Jostein Kjønigsen
 <jostein <at> secure.kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>, Juri Linkov
 <juri <at> linkov.net>
Cc: 78594 <at> debbugs.gnu.org
Subject: Re: bug#78594: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode
 does not fontify variable-use consistently
Date: Mon, 26 May 2025 22:44:08 +0300

On Mon, 2025-05-26 at 21:29 +0300, Eli Zaretskii wrote:
> > From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> > Date: Mon, 26 May 2025 19:02:04 +0200
> > 
> > Hey everyone!
> > 
> > I'm an avid user of typescript-ts-mode, and I'm also very
> > interested in seeing expanded use of font-lock-variable-use-face in
> > Emacs. IMO it really helps highlight key structural elements of the
> > code.
> > 
> > Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very
> > good, nor consistent in highlighting variable use using these new
> > faces.
> > 
> > Attached is a patch which seeks to remedy the situation. Let me
> > know what you think :) 
> 
> Thanks, I'm adding to the discussion people who lately made changes
> in these modes.

Sounds interesting, thank you!

Though, I may not be the best person to appreciate this, because I'm
using color-identifiers-mode to highlight variables, along with which I
configure my local typescript-ts color-scheme to be monochrome (to make
colored identifiers stand out).  So I'd leave for others to comment.

Message #16 received at 78594-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78594-done <at> debbugs.gnu.org
Subject: Re: bug#78594: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does
 not fontify variable-use consistently
Date: Sun, 1 Jun 2025 15:48:56 -0700

[Message part 1 (text/plain, inline)]

> On May 26, 2025, at 10:02 AM, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> Hey everyone!
> 
> I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.
> 
> Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.
> 
> Attached is a patch which seeks to remedy the situation. Let me know what you think :) 

Thanks Jostein, these are very nice improvements! I merged the patch to master.

Would be nice to include some screenshots to illustrate the changes visually. But your comment message is very informational, and I was able to make some screenshots myself to see the change (attached).

Also the commit message format is still not quite right, but I fixed it when pushing.

Yuan

[after.png (image/png, inline)]

[before.png (image/png, inline)]

[Message part 4 (text/plain, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.