GNU bug report logs - #78604
[PATCH 0/2] gnu: signond: Fix finding libraries.

Previous Next

To reply to this bug, email your comments to 78604 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH 0/2] gnu: signond: Fix finding libraries.
Date: Tue, 27 May 2025 14:59:06 +0530

This patchset removes duplicate native-input (qtbase, which is added already by
qt-build-system) and then fixes executing signond.

Sughosha (2):
  gnu: signond: Remove qtbase from native-inputs.
  gnu: signond: Fix finding libraries.

 gnu/packages/qt.scm | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)


base-commit: e7d73a08d569904f8a71db5b84f5fafaf0dff188
-- 
2.49.0

Message #8 received at 78604 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 78604 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH 1/2] gnu: signond: Remove qtbase from native-inputs.
Date: Tue, 27 May 2025 15:01:46 +0530

* gnu/packages/qt.scm (signond)[native-inputs]: Remove qtbase-5.
(signond-qt6)[native-inputs]: Remove qtbase.

Change-Id: If83258b2b5d7f93c5f2b7d1fc214ae64d4893bc5
---
 gnu/packages/qt.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 49c014870ba..0bd262341f3 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5888,7 +5888,7 @@ (define-public signond
                (base32
                 "0k6saz5spys4a4p6ws0ayrjks2gqdqvz7zfmlhdpz5axha0gbqq4"))))
     (build-system qt-build-system)
-    (native-inputs (list doxygen pkg-config qtbase-5 qttools-5))
+    (native-inputs (list doxygen pkg-config qttools-5))
     (inputs (list dbus glib libaccounts-glib))
     (arguments
      (list #:tests? #f                  ; Figure out how to run tests
@@ -5938,7 +5938,6 @@ (define-public signond-qt6
                  (base32
                   "13cgdf6hhi2z3c8sax79dwi7450n8h228kpyl2w5lx0xglb2savq"))))
       (native-inputs (modify-inputs (package-native-inputs signond)
-                       (delete "qtbase")
                        (replace "qttools" qttools)))
       (arguments
        (substitute-keyword-arguments (package-arguments signond)
-- 
2.49.0

Message #11 received at 78604 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 78604 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH 2/2] gnu: signond: Fix finding libraries.
Date: Tue, 27 May 2025 15:01:47 +0530

* gnu/packages/qt.scm (signond)[arguments]<#:phases>: Add wrap-with-libs
phase.

Change-Id: Ifef13dfade2cec019fe7615ea43d957fafea2529
---
 gnu/packages/qt.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 0bd262341f3..d1c1f72ef9f 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5913,7 +5913,13 @@ (define-public signond
                                      #$output "/lib/signon")))
                    (invoke "qmake"
                            (string-append "PREFIX=" #$output)
-                           (string-append "LIBDIR=" #$output "/lib")))))))
+                           (string-append "LIBDIR=" #$output "/lib"))))
+               ;; "signond" executable fails to find its own libraries.
+               (add-after 'install 'wrap-with-libs
+                 (lambda _
+                   (wrap-program (string-append #$output "/bin/signond")
+                     `("LD_LIBRARY_PATH" ":" prefix
+                        (,(string-append #$output "/lib")))))))))
     (home-page "https://accounts-sso.gitlab.io/signond/index.html")
     (synopsis "Perform user authentication over D-Bus")
     (description "This package provides a D-Bus service which performs user
-- 
2.49.0

Message #14 received at 78604 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: Sughosha <sughosha <at> disroot.org>
Cc: 78604 <at> debbugs.gnu.org, Zheng Junjie <z572 <at> z572.online>,
 宋文武 <iyzsong <at> envs.net>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#78604] [PATCH 2/2] gnu: signond: Fix finding libraries.
Date: Tue, 27 May 2025 21:37:51 +0200

Hi,

Sughosha <sughosha <at> disroot.org> writes:

> * gnu/packages/qt.scm (signond)[arguments]<#:phases>: Add wrap-with-libs
> phase.
>
> Change-Id: Ifef13dfade2cec019fe7615ea43d957fafea2529
> ---
>  gnu/packages/qt.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 0bd262341f3..d1c1f72ef9f 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -5913,7 +5913,13 @@ (define-public signond
>                                       #$output "/lib/signon")))
>                     (invoke "qmake"
>                             (string-append "PREFIX=" #$output)
> -                           (string-append "LIBDIR=" #$output "/lib")))))))
> +                           (string-append "LIBDIR=" #$output "/lib"))))
> +               ;; "signond" executable fails to find its own libraries.
> +               (add-after 'install 'wrap-with-libs
> +                 (lambda _
> +                   (wrap-program (string-append #$output "/bin/signond")
> +                     `("LD_LIBRARY_PATH" ":" prefix
> +                        (,(string-append #$output "/lib")))))))))


setting LD_LIBRARY_PATH should be the last resort
instead you need to pass the right ldflags:

--8<---------------cut here---------------start------------->8---
(invoke "qmake"
   (string-append "QMAKE_LFLAGS_RPATH=-Wl,-rpath,"
        #$output "/lib -Wl,-rpath,")
   ...
--8<---------------cut here---------------end--------------->8---

and I think you can remove the QMAKE_RPATHDIR substitution, it seems to
be doing nothing (the package builds fine without it)

Message #17 received at 78604 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 78604 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH v2 1/2] gnu: signond: Remove qtbase from native-inputs.
Date: Wed, 28 May 2025 17:30:14 +0530

* gnu/packages/qt.scm (signond)[native-inputs]: Remove qtbase-5.
(signond-qt6): Remove qtbase.

Change-Id: If83258b2b5d7f93c5f2b7d1fc214ae64d4893bc5
---
 gnu/packages/qt.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 49c014870ba..0bd262341f3 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5888,7 +5888,7 @@ (define-public signond
                (base32
                 "0k6saz5spys4a4p6ws0ayrjks2gqdqvz7zfmlhdpz5axha0gbqq4"))))
     (build-system qt-build-system)
-    (native-inputs (list doxygen pkg-config qtbase-5 qttools-5))
+    (native-inputs (list doxygen pkg-config qttools-5))
     (inputs (list dbus glib libaccounts-glib))
     (arguments
      (list #:tests? #f                  ; Figure out how to run tests
@@ -5938,7 +5938,6 @@ (define-public signond-qt6
                  (base32
                   "13cgdf6hhi2z3c8sax79dwi7450n8h228kpyl2w5lx0xglb2savq"))))
       (native-inputs (modify-inputs (package-native-inputs signond)
-                       (delete "qtbase")
                        (replace "qttools" qttools)))
       (arguments
        (substitute-keyword-arguments (package-arguments signond)

base-commit: c15f786f8936502249b639220997094fdbf7f1e8
-- 
2.49.0

Message #20 received at 78604 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 78604 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH v2 2/2] gnu: signond: Fix finding libraries.
Date: Wed, 28 May 2025 17:30:15 +0530

* gnu/packages/qt.scm (signond)[arguments]<#:phases>: In configure phase,
add "QMAKE_LFLAGS_RPATH" variable.

Change-Id: I9cba96e86ee7fe662570a25fe71eddd7af2d22d5
---
 gnu/packages/qt.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 0bd262341f3..850e8a25144 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5913,7 +5913,9 @@ (define-public signond
                                      #$output "/lib/signon")))
                    (invoke "qmake"
                            (string-append "PREFIX=" #$output)
-                           (string-append "LIBDIR=" #$output "/lib")))))))
+                           (string-append "LIBDIR=" #$output "/lib")
+                           (string-append "QMAKE_LFLAGS_RPATH=-Wl,-rpath,"
+                                          #$output "/lib -Wl,-rpath,")))))))
     (home-page "https://accounts-sso.gitlab.io/signond/index.html")
     (synopsis "Perform user authentication over D-Bus")
     (description "This package provides a D-Bus service which performs user
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.