GNU logs - #78680, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78680: typescript-ts-mode "fills" code when using (fill-paragraph)
Resent-From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 03 Jun 2025 13:42:04 +0000
Resent-Message-ID: <handler.78680.B.174895811326052 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78680 <at> debbugs.gnu.org
Message-ID: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Date: Tue, 03 Jun 2025 16:41:26 +0300
Content-Type: multipart/mixed; boundary="=-UjtbdAx+x3Dj1kSVEdMU"
User-Agent: Evolution 3.56.1 
MIME-Version: 1.0
Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:d100;
 envelope-from=hi-angel@HIDDEN; helo=forward100d.mail.yandex.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-UjtbdAx+x3Dj1kSVEdMU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

This is on latest master (50e3bce315e). To reproduce:

1. Create test.ts with this content:

	// test
	console.log("hello world")


2. Open as `emacs -Q test.ts`
3. Evaluate (progn (require 'treesit) (typescript-ts-mode))
4. Put caret at the word `test1`
5. Press M-q

Expected: nothing.
Actual: the code gets moved into the comment

-------------

I investigated the problem, it seems to be because `fill-comment-
function` is nil. From my understanding, it's supposed to be set by
invoking a common helper (c-ts-common-comment-setup), which I
implemented in the attached patch.

I am testing this to make sure there wouldn't be any adverse effects.

What's odd is that I don't seem to remember having this problem before,
and; and as a matter of fact we even have investigated a bug #77727
which wouldn't be possible with this issue. Seems like a regression.

--=-UjtbdAx+x3Dj1kSVEdMU
Content-Disposition: attachment; filename="1.patch"
Content-Type: text/x-patch; name="1.patch"; charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA4NjlkMGI5NWJkNDlkZWQyYzY2MjIyZDZiOGFkMDI0MTZjYTFmNDY1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIEtoYXJsYW1vdiA8SGktQW5nZWxAeWFuZGV4
LnJ1PgpEYXRlOiBUdWUsIDMgSnVuIDIwMjUgMTY6MzI6MTQgKzAzMDAKU3ViamVjdDogW1BBVENI
XSBTZXQgdXAgYy1saWtlIGNvbW1lbnRhcnkgaGVscGVycyBmb3IgdHlwZXNjcmlwdC10cyBtb2Rl
cwoKQ3VycmVudGx5LCBydW5uaW5nIChmaWxsLXBhcmFncmFwaCkgb3ZlciB0eXBlc2NyaXB0IGNv
bW1lbnQgbmV4dCB0byBhCmNvZGUgbWF5IHJlc3VsdCBpbiB0aGUgY29kZSBiZWluZyBzdHVmZmVk
IGludG8gdGhlIGNvbW1lbnQuICBUaGlzIGlzCmJlY2F1c2UgZmlsbC1wYXJhZ3JhcGgtZnVuY3Rp
b24gaXNuJ3Qgc2V0LiAgRml4IHRoYXQgYnkgaW52b2tpbmcKYChjLXRzLWNvbW1vbi1jb21tZW50
LXNldHVwKScsIHNpbWlsYXJseSB0byBvdGhlciBjLWxpa2UgbW9kZXMuCgoqICh0eXBlc2NyaXB0
LXRzLWJhc2UtbW9kZSk6IEludm9rZSBgKGMtdHMtY29tbW9uLWNvbW1lbnQtc2V0dXApJy4KLS0t
CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCAxICsKIDEgZmlsZSBjaGFu
Z2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp
cHQtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbAppbmRl
eCAwYmM2MjljYzgxZS4uMTBiZTAyYjk5OTUgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3R5
cGVzY3JpcHQtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1v
ZGUuZWwKQEAgLTY2MSw2ICs2NjEsNyBAQCB0eXBlc2NyaXB0LXRzLWJhc2UtbW9kZQogICA6c3lu
dGF4LXRhYmxlIHR5cGVzY3JpcHQtdHMtbW9kZS0tc3ludGF4LXRhYmxlCiAKICAgOzsgQ29tbWVu
dHMuCisgIChjLXRzLWNvbW1vbi1jb21tZW50LXNldHVwKQogICAoc2V0cS1sb2NhbCBjb21tZW50
LXNldHVwLWZ1bmN0aW9uICMnanMtLXRyZWVzaXQtY29tbWVudC1zZXR1cCkKIAogICA7OyBFbGVj
dHJpYwotLSAKMi40OS4wCgo=


--=-UjtbdAx+x3Dj1kSVEdMU--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Subject: bug#78680: Acknowledgement (typescript-ts-mode "fills" code when
 using (fill-paragraph))
Message-ID: <handler.78680.B.174895811326052.ack <at> debbugs.gnu.org>
References: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
X-Gnu-PR-Message: ack 78680
X-Gnu-PR-Package: emacs
Reply-To: 78680 <at> debbugs.gnu.org
Date: Tue, 03 Jun 2025 13:42:06 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 78680 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78680: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78680
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78680: typescript-ts-mode "fills" code when using (fill-paragraph)
Resent-From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 03 Jun 2025 16:49:02 +0000
Resent-Message-ID: <handler.78680.B78680.17489693053461 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Juri Linkov <juri@HIDDEN>
Cc: 78680 <at> debbugs.gnu.org
Message-ID: <decdf1cd8224bf0a928246157f440bc37bb12145.camel@HIDDEN>
From: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Date: Tue, 03 Jun 2025 19:14:01 +0300
In-Reply-To: <878qm87ryo.fsf@HIDDEN>
References: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
 <878qm87ryo.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.1 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Tue, 2025-06-03 at 18:41 +0300, Juri Linkov wrote:
> 'c-ts-common-comment-setup' is a too confusing name.
> It does more than just setting comment-related variables.
> So 8bccccedb65a should have retained 'c-ts-common-comment-setup'.
> Therefore I restored it in js-ts-mode and typescript-ts-base-mode.

So you did exactly same thing as my patch, but instead of applying mine
to account for contribution since I researched the problem and wrote
the code, you just wrote same thing yourself. This is not fair.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78680: typescript-ts-mode "fills" code when using (fill-paragraph)
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 03 Jun 2025 16:51:02 +0000
Resent-Message-ID: <handler.78680.B78680.17489694304185 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Cc: 78680 <at> debbugs.gnu.org
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
Organization: LINKOV.NET
References: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
Date: Tue, 03 Jun 2025 18:41:35 +0300
Message-ID: <878qm87ryo.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

close 78680 31.0.50
thanks

> This is on latest master (50e3bce315e). To reproduce:
>
> 1. Create test.ts with this content:
>
> 	// test
> 	console.log("hello world")
>
> 2. Open as `emacs -Q test.ts`
> 3. Evaluate (progn (require 'treesit) (typescript-ts-mode))
> 4. Put caret at the word `test1`
> 5. Press M-q
>
> Expected: nothing.
> Actual: the code gets moved into the comment
>
> -------------
>
> I investigated the problem, it seems to be because `fill-comment-
> function` is nil. From my understanding, it's supposed to be set by
> invoking a common helper (c-ts-common-comment-setup), which I
> implemented in the attached patch.
>
> I am testing this to make sure there wouldn't be any adverse effects.
>
> What's odd is that I don't seem to remember having this problem before,
> and; and as a matter of fact we even have investigated a bug #77727
> which wouldn't be possible with this issue. Seems like a regression.

'c-ts-common-comment-setup' is a too confusing name.
It does more than just setting comment-related variables.
So 8bccccedb65a should have retained 'c-ts-common-comment-setup'.
Therefore I restored it in js-ts-mode and typescript-ts-base-mode.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Jun 2025 16:50:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 03 12:50:33 2025
Received: from localhost ([127.0.0.1]:40847 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uMUqO-00015a-Ti
	for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 12:50:33 -0400
Received: from mslow3.mail.gandi.net ([217.70.178.249]:60529)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1uMUqK-000158-Vr; Tue, 03 Jun 2025 12:50:29 -0400
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
 [217.70.183.195])
 by mslow3.mail.gandi.net (Postfix) with ESMTP id 0E708581A82;
 Tue,  3 Jun 2025 15:42:58 +0000 (UTC)
Received: by mail.gandi.net (Postfix) with ESMTPSA id CA1271FCF0;
 Tue,  3 Jun 2025 15:42:56 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Konstantin Kharlamov <Hi-Angel@HIDDEN>
Subject: Re: bug#78680: typescript-ts-mode "fills" code when using
 (fill-paragraph)
In-Reply-To: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
Organization: LINKOV.NET
References: <d9bfb991daadb3fd134a189dbb21c49af4d60715.camel@HIDDEN>
Date: Tue, 03 Jun 2025 18:41:35 +0300
Message-ID: <878qm87ryo.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: 0
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeifecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeekieektdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopefjihdqtehnghgvlheshigrnhguvgigrdhruh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 78680 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 78680 31.0.50
thanks

> This is on latest master (50e3bce315e). To reproduce:
>
> 1. Create test.ts with this content:
>
> 	// test
> 	console.log("hello world")
>
> 2. Open as `emacs -Q test.ts`
> 3. Evaluate (progn (require 'treesit) (typescript-ts-mode))
> 4. Put caret at the word `test1`
> 5. Press M-q
>
> Expected: nothing.
> Actual: the code gets moved into the comment
>
> -------------
>
> I investigated the problem, it seems to be because `fill-comment-
> function` is nil. From my understanding, it's supposed to be set by
> invoking a common helper (c-ts-common-comment-setup), which I
> implemented in the attached patch.
>
> I am testing this to make sure there wouldn't be any adverse effects.
>
> What's odd is that I don't seem to remember having this problem before,
> and; and as a matter of fact we even have investigated a bug #77727
> which wouldn't be possible with this issue. Seems like a regression.

'c-ts-common-comment-setup' is a too confusing name.
It does more than just setting comment-related variables.
So 8bccccedb65a should have retained 'c-ts-common-comment-setup'.
Therefore I restored it in js-ts-mode and typescript-ts-base-mode.

Last modified: Tue, 3 Jun 2025 17:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.