Received: (at 78685) by debbugs.gnu.org; 9 Jun 2025 11:23:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 09 07:23:28 2025 Received: from localhost ([127.0.0.1]:54085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uOabA-0002Rf-5T for submit <at> debbugs.gnu.org; Mon, 09 Jun 2025 07:23:28 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:56641) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1uOab7-0002RR-G2 for 78685 <at> debbugs.gnu.org; Mon, 09 Jun 2025 07:23:26 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-54b09cb06b0so4865476e87.1 for <78685 <at> debbugs.gnu.org>; Mon, 09 Jun 2025 04:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749468199; x=1750072999; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=K5jX44POKvGSGXnCP+eBsoOI4gqLbPuk1xvSe7A2lHM=; b=E86pDxmz37utRQrIWMxP0ozXI8OEi7z58y4rLN7h0dnrrMyToTTuaq7RUGnosetjZN nu2hxYQ9M9ksUmYkiChmx88BNvzaKKm6DnPJnKjRbGlUP04OA/qZGDmwDP3FLJz9sPtL ZQzqPM3O8W/nTKSzqiJ+z7Bq57dHbVw807PqB1dH2RxvFvzIMk9v5VPuENG3Kyd0Mszk PvOjgCXw1SVEEQeEzDCNUrFDLM+XjwyqHZ1W9jbCHsB00ayvlLEmC7iPhuW4vf6rs5FF aXggTx8eL/sW+riBgSm24KTnU7gW6RZlXpNlXzzA2MX/d507aMhQN3Y26eM2A2gip15C 1MCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749468199; x=1750072999; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K5jX44POKvGSGXnCP+eBsoOI4gqLbPuk1xvSe7A2lHM=; b=V4WEq7rt9+LL7SHWbFmrdJEamJZVg6xCWGesGUsTsKg1aOVEJ3oAKU/wqvTwieTw1r VEX3a8TL+AAhzjIqQOnp7DfYefJo8DpnN04rgzrcpGOVraCZik5YYEMO0RaL04GN0i4o +3X5VK5pD5d1Mv8k+LM4orlWkND7irgNYlnCjBf3ITetbm5cbZ3SfnVyni3PxX+vy5tO 6CZENEdPOaBmGG1LHRNj7cQZI4q2iwwZjxlhfOwsNCgQ0Ca0WvhSAvn3ATuJKhJ53z8y JLtysujCzQy2Brbkflhh0SlFEgnKwmCVPb/T3Jz3Z/zwQmmO4AqJSzXlsdZPZsXmXS1T 6CMg== X-Forwarded-Encrypted: i=1; AJvYcCXYW2jE2xRD5IYEmhjmlWW++dmErzZ2Qk1JoBis0Ng0PvGHu2Gephnv3jGThuI24lPb50v8Eg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx9p+rwh+H6csY2U3psz6ApU/WICiBGoKYCfp7o3NaXPg1ULDMT b3h0HBYPt3LD9IxxEoHAUnGnxRHUH7HfMMdXyVqwCSbOgcg3uMi03Zyk X-Gm-Gg: ASbGncukOcOkD7XRnYsXsv52+KLI9R9j9JL5I/ILjj99GnwdkeW0YiyV8dLLDTG3MyX vKdHP7E9NiDXKrwof6cLMw+5dLI8Q+IYy/p7GnJX5nFRnp2cOeqYato9NgqQ354ZerPGY6mZFYV dGhlwHsqfA6DX8BxDGtSHsmwDMFc4ukgwl9oAciQyzmHqc8dRaC5bwbXxXqwLcFb/e3kYw95flx qyTqxY9ZVWgiuIJDAgrD/3vZRj/VcPU4B1k15DqAA1PNXjs53WZiJ4HLgW0XtVf3mk/sCEylgZw kkMrM2D+HANWxGzMfHE5zw7l1F84vn8obHNZQFwKecjX2zGN4WVr7z2DSuPy+nvICi7iO6l/Nvb +VSC3hPziLD43FcBrTCNCCSFcf8d2Yng6VNlXeRSk98SEC9y6Qb/1 X-Google-Smtp-Source: AGHT+IG7univan6hH7iKdTkDz+sCkXHwk1oWvfY/cInHdpcvkoSCdUrJPO5uto4JwZnl+pvz0sHV9Q== X-Received: by 2002:a05:6512:3d86:b0:553:2fb1:cfe5 with SMTP id 2adb3069b0e04-55366bd40fdmr3343761e87.12.1749468198284; Mon, 09 Jun 2025 04:23:18 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5536772a405sm1105728e87.152.2025.06.09.04.23.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jun 2025 04:23:17 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword., [PATCH] Avoid triggering autoloads in the byte compiler (bug#78685) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <87frg9425e.fsf@HIDDEN> Date: Mon, 9 Jun 2025 13:23:17 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <42EEE68D-B0B4-4909-BFB0-A89F55611B0F@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN> <87wm9m4ol1.fsf@HIDDEN> <m2v7p6zk1w.fsf_-_@HIDDEN> <87frg9425e.fsf@HIDDEN> To: Pip Cet <pipcet@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org, =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Thank you very much for making the analysis that I should have, and = sorry about the debacle. I've backed out the change for now. A clear = understanding is needed.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 9 Jun 2025 10:53:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 09 06:53:38 2025 Received: from localhost ([127.0.0.1]:54052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uOa8I-00016i-DS for submit <at> debbugs.gnu.org; Mon, 09 Jun 2025 06:53:38 -0400 Received: from mail-10630.protonmail.ch ([79.135.106.30]:24885) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1uOa8F-00016R-TQ for 78685 <at> debbugs.gnu.org; Mon, 09 Jun 2025 06:53:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1749466408; x=1749725608; bh=Mx0EEpAF4MM5HFG6YZkt/TOxgVwmbaKvZRODI7uFMJY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=FynvtfUSnxUDrfVjvsOVFqGN4VXBwTMuPVrdVDOfJSDzJogxjjup3y52bykXeG3Vd srXc9+6sx8v3t9IKCg17pWHbQHvCOAWLNqtp+PUP1AWzOuCAQt+J9S1AWQf8IppznD cedSnYQROWJLAmxf3nniLMFPZGqZb1xCkPIiyn5eCZQAny5z+9IdbnRFfgglXFFomU gKAySB7ZWs7R+vLNeR8LOSTkpxg020qx+mR4MOD+m/eP4uEosrGw/3OHfl2D49Gndy bDHPiqN6iqOUi0cB+TYdifgJcwpwu+RDs4uyhhV4d39IMT770FuDulzgd1vpbHeGNb PA+uy2TRrJ48g== Date: Mon, 09 Jun 2025 10:53:22 +0000 To: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword., [PATCH] Avoid triggering autoloads in the byte compiler (bug#78685) Message-ID: <87frg9425e.fsf@HIDDEN> In-Reply-To: <m2v7p6zk1w.fsf_-_@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN> <87wm9m4ol1.fsf@HIDDEN> <m2v7p6zk1w.fsf_-_@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 3d7eaf78e1be6d12be0ce4e8a29c6b91161911ce MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > FWIW. When merging master I noticed that > > 1. A number of new obsolete function warnings appeared I think that is caused by the autoloading, which ends up making functions obsolete before they are compiled (recursive obsolete functions are warned about). Some of the other warnings appear to depend on the order in which an obsolete function and another function calling it appear in the .el file. I'm not sure that always makes sense, but my patch restores the previous warning-free behavior. > 2. Build times from git clean -xdf went up from 1:20m to 1:50m It wasn't that extreme on my machine, but I did see an increase of about 15 s which went away with my patch. So I think those two problems would be fixed by my patch, but there's a new one: 3. We no longer warn about mismatched argument counts in macro redefinitions: (defmacro defun ()) Previously, we printed Warning: macro defun used to take 2 or more arguments, now takes 0 I'm not sure this warning is very useful, but it seems like byte-compile-fdefinition should return the cdr of a macro when that is the (potentially indirect) function of a symbol passed to it. I must confess I don't quite understand what the intended behavior of byte-compile-fdefinition is: for functions and macros, we want the same behavior as indirect-function; for symbols which are ultimately not fboundp, we want to call get-advertised-calling-convention, but on which symbol? The first in the chain or the last one? For autoloads, we want to return nil; for exotically-fbound symbols (not closures, not cons cells, or cons cells with a strange car), does it really matter whether we call get-advertised-calling-convention or not? Pip
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 8 Jun 2025 08:58:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 08 04:58:50 2025 Received: from localhost ([127.0.0.1]:50677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uOBrd-0001ku-Po for submit <at> debbugs.gnu.org; Sun, 08 Jun 2025 04:58:50 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:51479) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1uOBrY-0001ka-QH for 78685 <at> debbugs.gnu.org; Sun, 08 Jun 2025 04:58:47 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so27459725e9.3 for <78685 <at> debbugs.gnu.org>; Sun, 08 Jun 2025 01:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749373118; x=1749977918; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=x/VNHT37vhNiD0N/8R0t4fDqhgk7VPkhbuVPTEqjIzE=; b=TEKhFJGdO1/vyuf/PAwyLsYn0bVi1nc2LblBNEl5z4QYpJpa3JaA9Byp/sL08K+vCz 13GErZToWtaF10g/LHSVo7/r+MCM0mo+oFkhbNdkTP7doqEesUKitxADUNqXuNIgCXzu zUS8WFJj23u8nVnsEV2MVoXztS0f5XuE2uKCMEl4oenr0zlyAk5HpwFxnMqAlcCpVBFl HHlobK31mbJRZOaCAIqmqaFi/qNMfSqxZEEiIVq1v7GqO3xRNfEVm+qDqjQUmP26oH0y xsXcZ25b+ElBaazz5WfN6DW1lYPn27UBLNh7FhgD5GrmVCKsTR83zdrYUUCErJelzn47 R9Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749373118; x=1749977918; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x/VNHT37vhNiD0N/8R0t4fDqhgk7VPkhbuVPTEqjIzE=; b=PyqxUkvGoI6MgIs1mp+43jMb7fz9jmBige02cxDsT0U4pQUYIbie9o1sqG0hhbqPCT FgseQeWsVetn2lfqy1VPq5ykNCZHb2QbhkJMzBXt3LWeDgF9sO7DEhUZS8UV5zf/hfXY XX7ttQ2anRh8BJ19mkS4xltRy9MyaLVBTKbVCpTGIXSywH/CMXp8mDOcVePVX0g5iZZg +MQGseD69CUxr+nyTRDMt7zOsTgsCLetazvAOt90QeBLDaXoH6E2Vfi1lywCMZuvMqna XE0sRTqTyd3k2TdSMfJw2Yr4ygCiCt/GoMnyv3OF1nyZIBiJeACfbAQxEJPqQyLm90gC ecbA== X-Forwarded-Encrypted: i=1; AJvYcCUo0EQifQCoaMlfDwqJ0YuuAwgZkyb1zxtXKbSjJQuvea2RcGuoEWq2Et6kgNau4WgWPF7Lvg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyc29TO/hFf1nGe/9U1VYJdu49JfyOePc/AS1NkhgC2sAxYZa8L X6EZYf9IUipkLRQs7o8Q6CRe1rqrbn8okE/sAZmEYxCwKkusdaduZZQIruJMdnOC X-Gm-Gg: ASbGncsXcutDJclfjKpLXbDl7OQcGZBi8753GrSA1Pu0fToqntLSEU4oSxTicVDz2SG eBJ4YKqJ2VFLfve8WgEBmCMX5nadDBkCFPbE1j5vKIvvMos2vzw5P1mtEqYM4HSVfc3fYZQZnZX jBHSYTbjMMhSbc3dhwkttsz/5MaFGEjMNG7SsoI4T2oWRMVSLhQDkmWA8jgE3hdoK9+A3RGptdM zUOwA04QWzhsT/CLcWcRsuWO+m3OfaZFZLnSxv3GGc3zBfQX3DwNdKhfTtyfBnQGSP8fGaa8KXu l/Z3JhjqwIvotFgz0yR3tCdP+daqydnCX4CNlR489H0YeYM2phFIcDNnR0GKxnIWEzYmCMYqdmB ZD6FZCdBkB5nFG3Io6bef64C93vKlc4ChEAqyzZv8eXkEsQjWNugF/XxqZmkraQO1s5wHDCE= X-Google-Smtp-Source: AGHT+IFaouEtl2e3HEY4ImH/kilJFrMOF5B6v/pbNMgmZI5f3eRh9TgTq4m4+1Av8BCTrQKBlMUyug== X-Received: by 2002:a05:600c:83cf:b0:450:b9c0:c7d2 with SMTP id 5b1f17b1804b1-452014146bamr89226315e9.11.1749373118090; Sun, 08 Jun 2025 01:58:38 -0700 (PDT) Received: from pro2 (p200300e0b72aee005cffa46ecc1e2213.dip0.t-ipconnect.de. [2003:e0:b72a:ee00:5cff:a46e:cc1e:2213]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45213709670sm79107205e9.25.2025.06.08.01.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jun 2025 01:58:36 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword., [PATCH] Avoid triggering autoloads in the byte compiler (bug#78685) In-Reply-To: <87wm9m4ol1.fsf@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN> <87wm9m4ol1.fsf@HIDDEN> Date: Sun, 08 Jun 2025 10:58:35 +0200 Message-ID: <m2v7p6zk1w.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) FWIW. When merging master I noticed that 1. A number of new obsolete function warnings appeared 2. Build times from git clean -xdf went up from 1:20m to 1:50m Bisect shows this is caused by 8b0f5b05976a99e82e54d6c602d47a8668ccd9d5.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 8 Jun 2025 08:36:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 08 04:36:46 2025
Received: from localhost ([127.0.0.1]:50640 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uOBWH-0000lr-BV
for submit <at> debbugs.gnu.org; Sun, 08 Jun 2025 04:36:45 -0400
Received: from mail-24416.protonmail.ch ([109.224.244.16]:38789)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1uOBWE-0000lT-27
for 78685 <at> debbugs.gnu.org; Sun, 08 Jun 2025 04:36:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1749371794; x=1749630994;
bh=o0Zr4Mjm+70W+n7KDB0UxZkHcidIwzM6U3BecoJMFuM=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=eqX1rE8BCaOQv2Okbycx9E0l37mIPiaADlGmnOBATEafX09PTepFgOnkbFf2Cn0QF
UcxD/YENK1w2hF5NrpgIb34JAd1oEDd8ETTjswjeKZebbV9xES0suP5oSpdC/tEXkf
V2yRwhOLF3vV3wwhkcz883B+ecy2dVEwIr7I7KMlE7d+2WvXkfGAQSze7uIjSe+f7K
0DD1j9MO68jeGDNFBad8h1nVASMnF6hMzCVJGdkYB7IB4zjL8CsBAbyMsoHmgtJvFe
9YFaQ5yEFGEVEVpSl+odj73WbT5LVv7p2UAoT20xld89VGf8EPrFkBJtkHGTL0RTHZ
Fi40IRkEh6EDg==
Date: Sun, 08 Jun 2025 08:36:30 +0000
To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#78685: 30.1;
Call to `sort' in lisp/desktop.el is missing a keyword.
Message-ID: <87wm9m4ol1.fsf@HIDDEN>
In-Reply-To: <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
<E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
<DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
<jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN>
<5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN>
<5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 5679d2bf94a647cc6b0cd5563320a70b810a4a30
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org,
tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>,
Michael Albinus <michael.albinus@HIDDEN>,
Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Pip Cet <pipcet@HIDDEN> writes:
> Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
>
>> 5 juni 2025 kl. 18.27 skrev Mattias Engdeg=C3=A5rd <mattias.engdegard@gm=
ail.com>:
>>
>>> That's probably fine and dandy. I pushed something to master, please se=
e if it's what you had in mind.
>>
>> That change (8b0f5b0597) apparently broke one test in eieio-tests, as re=
ported by Michael Albinus.
>>
>> I'm not sure what is going on here; apparently it's changing something
>> in the compilation of eieio-core.el. Stefan, you wouldn't know the
>> weak spots in that code, would you?
>
> This reminds me very much of bug#63288: when compiling eieio-core.el,
> sometimes eieio--class-slots is
>
> #[257 "\211\300H\207" [4] 3 (... . 4773)]
>
> and then it gets called on a cl-defstruct struct and it works.
>
> Sometimes it's
>
> #[(cl-x) ((progn (or (let* ((cl-x cl-x)) (progn (and (memq (type-of cl-x)=
cl-struct-eieio--class-tags) t))) (signal 'wrong-type-argument (list 'eiei=
o--class cl-x))) (aref cl-x 4))) (cl-struct-eieio--class-tags t) nil "Acces=
s slot \"slots\" of `eieio--class' struct X.
>
> And then it doesn't work, because a cl-defstruct isn't an eieio--class.
>
> This depends on whether we're running cl-defstruct with safety bound to
> 3 (in which case the error will occur) or cl--optimize-safety =3D 1 (in
> which case the code will be optimized away and the error won't occur).
>
> So, forcing cl--optimize-safety to 3 makes this problem appear even
> without Mattias's recent change. Similarly, marking eieio-core.el as
> no-byte-compile: t makes the problem appear.
>
> A very tentative suggestion would be to use the super class method:
>
> diff --git a/lisp/emacs-lisp/eieio-core.el b/lisp/emacs-lisp/eieio-core.e=
l
> index a06c36e5b72..8554f48e074 100644
> --- a/lisp/emacs-lisp/eieio-core.el
> +++ b/lisp/emacs-lisp/eieio-core.el
> @@ -707,7 +707,7 @@ eieio--validate-slot-value
> nil
> ;; Trim off object IDX junk added in for the object index.
> (setq slot-idx (- slot-idx (eval-when-compile eieio--object-num-slot=
s)))
> - (let* ((sd (aref (eieio--class-slots class)
> + (let* ((sd (aref (cl--class-slots class)
> slot-idx))
> (st (cl--slot-descriptor-type sd)))
> (cond
>
> Since cl-struct-cl--class-tags contains cl-structure-class, this works
> even if safety is set to 3. But maybe it's intended that all
> cl-defstruct-defined classes are eieio--classes?
>
> As to why this happens after Mattias's change but not before, I don't
> know yet. It seems the byte compiler autoloads more files before the
> change.
... or maybe after the change. The problem, in any case, is an
over-eager autoload after the change:
byte-compile-fdefinition, after the change, returns a symbol for
eieio-defclass-autoload. This causes us to call func-arity on the
symbol, which autoloads the actual definition:
load-with-code-conversion(".../eieio-core.el" ".../eieio-core.el" nil t)
func-arity(eieio-defclass-autoload)
byte-compile--function-signature(eieio-defclass-autoload)
byte-compile-arglist-warn(eieio-defclass-autoload (cname superclasses fil=
ename doc) nil)
This means we load eieio-core.el while trying to compile it, re-evaluate
the cl-defstruct, but without the cl-declaim (which we use only when
compiling), and end up replacing the accessors with the "safe" versions
which signal an error when used on a cl-defstruct rather than an
eieio--class.
So that leaves the reason for byte-compile-fdefinition to return
eieio-defclass-autoload unchanged, even though it is a function:
(functionp 'eieio-defclass-autoload) =3D> t
(functionp (symbol-function 'eieio-defclass-autoload)) =3D> nil
That surprised me, but it suggests a simple fix:
From 447f236610bcccf8d5fd82cfa3ea3936ce27c9e1 Mon Sep 17 00:00:00 2001
From: Pip Cet <pipcet@HIDDEN>
Subject: [PATCH] Avoid triggering autoloads in the byte compiler (bug#78685=
)
Change byte-compile-fdefinition not to return symbols which are fbound
to an autoload form unchanged; return nil instead. Autoload forms
aren't functions, but symbols bound to autoload forms are, so we need
to call functionp on the symbol, not its function cell.
* lisp/emacs-lisp/bytecomp.el (byte-compile-fdefinition): Call
'functionp' on 'fn', not its symbol-function.
---
lisp/emacs-lisp/bytecomp.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 5fa65ff71a6..743403e70de 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1456,7 +1456,7 @@ byte-compile-fdefinition
=09(let ((fn name))
=09 (while (and (symbolp fn)
=09=09 (fboundp fn)
-=09=09 (functionp (symbol-function fn)))
+=09=09 (functionp fn))
=09 (setq fn (symbol-function fn)))
(let ((advertised (get-advertised-calling-convention
(if (and (symbolp fn) (fboundp fn))
--=20
2.48.1
I still think the other change would be appropriate, too, as it would
allow eieio-core.el to be usable when not compiled.
Pip
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 7 Jun 2025 20:21:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 07 16:21:58 2025
Received: from localhost ([127.0.0.1]:49715 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uO03B-0007ik-Ii
for submit <at> debbugs.gnu.org; Sat, 07 Jun 2025 16:21:57 -0400
Received: from mail-24416.protonmail.ch ([109.224.244.16]:24383)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pipcet@HIDDEN>)
id 1uO035-0007iM-81
for 78685 <at> debbugs.gnu.org; Sat, 07 Jun 2025 16:21:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1749327704; x=1749586904;
bh=Z2zcqTv11/CQAH3cZbENTWatiysJ1Ks9/uxoMdkLFAU=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=ibnDaRMcaoigRABFTwbHjboUJRw7TrMzYUkYVgtPfDN+56GCGvff7Rkiv7AYnqyL9
uYaM++5yxlDLYli7bCGaV6sl4mrRtFVU5bcDa+A9VwfFGqZo6dYeyh5AYPAoruQMDp
58+sI17wkmcr5UPMyXhh8uD7K95SNoYw34wS/RFzOocYRuUgvMJC2CVJB81ki+cqak
sckSAHWG15V/AaD1Fi9GqTtyW3+hmR4BQQeJg7y9TuHoehj0GdSCI8/ngl9EBw8tsb
G0biIJQKRnLJbFjf7j3aePepjpM2iK3nnpwUOSpQpw4gA9vvChvbo3ifWFIbfJGTID
LmkVVR0f4UGhA==
Date: Sat, 07 Jun 2025 20:21:39 +0000
To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
From: Pip Cet <pipcet@HIDDEN>
Subject: Re: bug#78685: 30.1;
Call to `sort' in lisp/desktop.el is missing a keyword.
Message-ID: <8734cb5mlt.fsf@HIDDEN>
In-Reply-To: <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
<E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
<DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
<jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN>
<5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN>
<5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN>
Feedback-ID: 112775352:user:proton
X-Pm-Message-ID: 86a4fc94c22d266cb43b6c1fb4da70417d7b2826
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org,
tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>,
Michael Albinus <michael.albinus@HIDDEN>,
Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> 5 juni 2025 kl. 18.27 skrev Mattias Engdeg=C3=A5rd <mattias.engdegard@gma=
il.com>:
>
>> That's probably fine and dandy. I pushed something to master, please see=
if it's what you had in mind.
>
> That change (8b0f5b0597) apparently broke one test in eieio-tests, as rep=
orted by Michael Albinus.
>
> I'm not sure what is going on here; apparently it's changing something
> in the compilation of eieio-core.el. Stefan, you wouldn't know the
> weak spots in that code, would you?
This reminds me very much of bug#63288: when compiling eieio-core.el,
sometimes eieio--class-slots is
#[257 "\211\300H\207" [4] 3 (... . 4773)]
and then it gets called on a cl-defstruct struct and it works.
Sometimes it's
#[(cl-x) ((progn (or (let* ((cl-x cl-x)) (progn (and (memq (type-of cl-x) c=
l-struct-eieio--class-tags) t))) (signal 'wrong-type-argument (list 'eieio-=
-class cl-x))) (aref cl-x 4))) (cl-struct-eieio--class-tags t) nil "Access =
slot \"slots\" of `eieio--class' struct X.
And then it doesn't work, because a cl-defstruct isn't an eieio--class.
This depends on whether we're running cl-defstruct with safety bound to
3 (in which case the error will occur) or cl--optimize-safety =3D 1 (in
which case the code will be optimized away and the error won't occur).
So, forcing cl--optimize-safety to 3 makes this problem appear even
without Mattias's recent change. Similarly, marking eieio-core.el as
no-byte-compile: t makes the problem appear.
A very tentative suggestion would be to use the super class method:
diff --git a/lisp/emacs-lisp/eieio-core.el b/lisp/emacs-lisp/eieio-core.el
index a06c36e5b72..8554f48e074 100644
--- a/lisp/emacs-lisp/eieio-core.el
+++ b/lisp/emacs-lisp/eieio-core.el
@@ -707,7 +707,7 @@ eieio--validate-slot-value
nil
;; Trim off object IDX junk added in for the object index.
(setq slot-idx (- slot-idx (eval-when-compile eieio--object-num-slots)=
))
- (let* ((sd (aref (eieio--class-slots class)
+ (let* ((sd (aref (cl--class-slots class)
slot-idx))
(st (cl--slot-descriptor-type sd)))
(cond
Since cl-struct-cl--class-tags contains cl-structure-class, this works
even if safety is set to 3. But maybe it's intended that all
cl-defstruct-defined classes are eieio--classes?
As to why this happens after Mattias's change but not before, I don't
know yet. It seems the byte compiler autoloads more files before the
change.
Pip
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 7 Jun 2025 18:16:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 07 14:16:48 2025 Received: from localhost ([127.0.0.1]:49545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uNy64-0001wa-DU for submit <at> debbugs.gnu.org; Sat, 07 Jun 2025 14:16:48 -0400 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:53683) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1uNy61-0001wM-QU for 78685 <at> debbugs.gnu.org; Sat, 07 Jun 2025 14:16:46 -0400 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-5533c562608so3065116e87.3 for <78685 <at> debbugs.gnu.org>; Sat, 07 Jun 2025 11:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749320199; x=1749924999; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=HS0xomoU+GJXq2qQ+kGoHOeBAWD2wq2bQoRpxYWx4nw=; b=ijnVw9FGAn845oIjJA1UDxT0pQ5gjlIdcab/R7KUV7fCoyJmpXy4dGVPUlL0iK2TzQ x2WsJM7uaMF5FU9EwVaHBLhvsrZdk/7P7BDX6Zmx9dAF15/4RWhqFANlDDoSbuakvTqY /LPu5qfPLOmsKVzmm0xeU2uiVDztj6V6yrE8aCpb0waHa+iXQgxejXoxtEwOOq4CRni6 JclHdkECigp8X9eLiaoikzUk8q6/RxeKk1lRf5EmLJwrpKBNqoiBjBzjgqH86mWjOLYm ljmnVp6KyKUPJWWBm/h73kRToC/IdVlMb84+xXkiDhDdVs8DEeCP4WR5IX63+ETGEkuQ Vl2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749320199; x=1749924999; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HS0xomoU+GJXq2qQ+kGoHOeBAWD2wq2bQoRpxYWx4nw=; b=rHsuwyiZi4h0v+y6kNV+DJz8PNOIk5RfUXqxUT6pQn5aJHRxsfaQl7G3/cCFIOVDih rHEVtXT42VnjymbuyCq6USSembGOxHmgriGfgqVNkpVjACRjRPrLyoL9JAxOQU9nM/qc J9HzqHDCbWNZjxpr7sqZd/mx1ps5tRzWvitkDSrfIJxwguUj8vxh4uObrRB/rqZ5cCPl 7qh+dkwKPP4Z9L6tIEbtptiVuag2XVSyLT5esETvhrcnr3996X96Zk3KIN0t2Jy2XrIr SYDj5kRaD/DTrCAK3SR15u/nn/P4aTSrcD6v2UovrB7fCcbyPcBrVyVEHway/fhxfMNi wMBg== X-Forwarded-Encrypted: i=1; AJvYcCU4lNlAknUcgBb5caoxi3Yp9y5deDCabyTaYdVJlLj1iXYs+ZRbodEygsDBS7dq9Fmy+dETVQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxKgDxUFuXQgSDdXwUNGMJlxmGyJezVmjMUeu0XOrzxn9n/PylW 8+MRrIHVuuy9aT0jYanJ49AisokbqOp0tYPZFRZLdvN8soyyDZKSoxBl X-Gm-Gg: ASbGnctdav6eA43WaE6YsXVI0zznboQJnqugZ4LkMl2Ql+L506U4/ekc5DAGsl0edaa 0HjwrnEKAifD9OvEaYw5TfOTTy9OUltK4PkqvyVF2Etlg6zDy/5JKVOdR+1cmGGeHEiypsM8HdE Y+cHjwzf5JTPq87wRHio400Fres7Oi+17U6FKaYEgpC1iCoeWuveiNDFVhBlJdy3cSL0ktCLlX5 twEAk98/MlE01urZtCs8O9IOpfQzTQJk5SZw3Nfzzje57jeGnLsEcH3FdEc+2BJ01Tu04PmybbS 9heezV4ASkx6UzpHFudoOsbJFHTgdIi1lwqDhcdJVadNmaMwbTHSiPRav1zKVh+KfH3aWWi+Y3u 9nO3NzjL2P0viNZdg9P3r4nRFeFng9OP/FRa670N2Gqpx4wNlWrMP X-Google-Smtp-Source: AGHT+IHTsdM/0nEKTy9Fjz+Gm1+ToPkvi/onyXUpMALyOCEcW3mXLqQAcxj5GaDnhM3P6nZZyxmuvw== X-Received: by 2002:ac2:4c41:0:b0:553:3514:1a53 with SMTP id 2adb3069b0e04-55366be0b90mr1882111e87.4.1749320198693; Sat, 07 Jun 2025 11:16:38 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553676d7a89sm561670e87.80.2025.06.07.11.16.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jun 2025 11:16:38 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> Date: Sat, 7 Jun 2025 20:16:37 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <5E46E0E8-70BF-420B-9055-31681BB5C00A@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Michael Albinus <michael.albinus@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 5 juni 2025 kl. 18.27 skrev Mattias Engdeg=C3=A5rd = <mattias.engdegard@HIDDEN>: > That's probably fine and dandy. I pushed something to master, please = see if it's what you had in mind. That change (8b0f5b0597) apparently broke one test in eieio-tests, as = reported by Michael Albinus. I'm not sure what is going on here; apparently it's changing something = in the compilation of eieio-core.el. Stefan, you wouldn't know the weak = spots in that code, would you?
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 6 Jun 2025 08:04:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 06 04:04:20 2025 Received: from localhost ([127.0.0.1]:41540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uNS3o-0007bF-3l for submit <at> debbugs.gnu.org; Fri, 06 Jun 2025 04:04:20 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:60627) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1uNS3l-0007aw-Qy for 78685 <at> debbugs.gnu.org; Fri, 06 Jun 2025 04:04:18 -0400 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5534f3722caso2139136e87.0 for <78685 <at> debbugs.gnu.org>; Fri, 06 Jun 2025 01:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749197051; x=1749801851; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Qv0dpMBUWWa+CqWhLGk7NC9a285PZ5Uss3lKSWRk8/0=; b=mODK3uLWpG5tsgtiyz6DWGjErSDsbtgWiOurEQhBoq04OmtCxmOtm4zxu/2OO0WtI2 myBy3DYLQQoB1ZqkeuzHAGh+n7cNnWfocgYnM6ABPypnNC1nT453zjlDPglYlsQip/IP kPJxYdTLIqkVPlGVRdSNx9lj88BzBfxJbbrqI/mZr2XGd8j+ZeFWc72VIwvWZ+MCtbKw 6I1dFfPxIeqmiXdfcz/4MhB3CyJJ8plaUUW2v25i4YdL1gf6l6rmqVSxIdaRm0tPNjN3 Q6YPwSeyh7SIn8G5It6IjC5BcbyR8K0TUcNx9Cp/vLm6znonSm64LnbGiq5lPKtB9ii8 9ifw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749197051; x=1749801851; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Qv0dpMBUWWa+CqWhLGk7NC9a285PZ5Uss3lKSWRk8/0=; b=Fp9PZo249Nvc0a+Ksxsg3u6W5q2HIZqmRvygp116c8zdgwYeN0hXMzneGEMJx+UcVx BAQ9/lbxTu8JkL6Y5Td8BG+pDpLzy/AoKOAUqw2Hu3wL41XF003BGgJke3/RdtTzJFs0 EzpRqWTQ6MupbTgWX2lfIOjUOoejp2KWExaOauL4cjKutW2f1HsRA6hjsmySUOfs+EL0 XDRTfmy37eVcJuXDrw0xVRI33PUx42+9dI8paZujpFV9CMEmHWKm12vu20ojOl6huQHY HIvA9eJnE6++E1FEO+F3WlaBaMx59eq5LO4K08ZkCKWdwER6eR3vEjhTdxQrHWObzAbS Gbrg== X-Forwarded-Encrypted: i=1; AJvYcCUJRKibeHqNN09UONnA07Qmmqxg35PbnCt/C9t2OIAS586SmBx+NXsAuDzSNtC1i+JBMfiQiw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw1Ima6G2aN7bCNhGXZ9RdJ9lfo1031t+y3rLa8V9v6dCHh9q3n A4PvY7elFUzVZSKGo4CLyjPds+/EOIfsFHxlw6LL5fuZeBzrb1+y5u3V X-Gm-Gg: ASbGncvowZ0y997OxsqIFeWMTxlytHUveCM2dIJhIQboc1tZUqgE9TqHSlvQCb0Di71 m9Fk46wkgMG6S11HHUCcnD+D3l+2CxqIrPPjVEWIrpnEuirMUIb1tjxQhH2gRkveCnRTSqAae5T Ia7jTwuBvh065LVCJgwTK1tg/kTjgBv2Dao/RlyUOx63O4tM/4/F7oJdLeQNxKUgPaYH24yTZLy qPfNzgtEYeYiHCnUnPyEUN7leuWy9YF+ZOY/FcYA1uQ1PD1hfWPtgdQ8YTR9EEEO7BS7efjsC1U vRkN32Na7EqKBT1Rpkepp79jzmRj2izOqANBV6NeaP59Y1fL/yc5mQC2Di1lm/OMHB0roy37Ols d77akP7OmziaKvt1g0x5nDhxhVCIuS6RkOPoNaARPowJg5WbxY7yJ X-Google-Smtp-Source: AGHT+IHeD7cqmCkMBR572XsyvF4R13JbBozdDoo62gRlJiDlQGezzn+lkCyt7UnB46SSRK6yXVXGJQ== X-Received: by 2002:a05:6512:3b2a:b0:553:24b7:2f6f with SMTP id 2adb3069b0e04-55366c32d87mr551211e87.51.1749197050764; Fri, 06 Jun 2025 01:04:10 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55367731754sm116895e87.200.2025.06.06.01.04.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jun 2025 01:04:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwv8qm6capu.fsf-monnier+emacs@HIDDEN> Date: Fri, 6 Jun 2025 10:04:09 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9B881F55-C82F-4C6F-A755-6F25936C7A8C@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> <jwv8qm6capu.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 5 juni 2025 kl. 20.21 skrev Stefan Monnier <monnier@HIDDEN>: >> ~/emacs/lisp/register.el:580:40: Warning: the function = =E2=80=98cl-find-class=E2=80=99 is not known to be defined. >>=20 >> but that function is autoloaded so I'm not sure what's wrong. >=20 > It's autoloaded but only after you load `cl-lib`. Ah yes, thank you. Now there's a forward declaration.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 18:21:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 14:21:27 2025
Received: from localhost ([127.0.0.1]:36534 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uNFDT-000160-5z
for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 14:21:27 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29962)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uNFDQ-00015W-AV
for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 14:21:25 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 16FFD80966;
Thu, 5 Jun 2025 14:21:17 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1749147676;
bh=wghKIOFsvBjzQxrjGbbiGKvOjmAJ0dmaYKckCrEPIIA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=FYn3dZ9yglqdrLI0e+USameCVnCWIBnlcsGKcFVyN1lzZnojXsvltulhlsTMpe9zW
lpCtPDa4unl6ZzeeADlYnb15VR9oxBuPeexDDqUcsjG8zC0JS6/9+b2rcetGPq4jVt
Pt0c7fdlFEf7N8gdWfJpc6Zmg0giqdk5sdDdX4vcTEi212l7TngKnvhbmlsUQ/iHRQ
mfxRSZH3gYdYJgW0CrZKWzvWEGNCj4MNOqFEcJCyZtmpmNXTB1AeF/7Mv4ZtAEYPN+
Ulb/JghW7OZbzj1hvg1Ti98i4ZqGN7WAD+ZE8qBWvlpen5Tb/pR/eQFus1fVdWddgf
SetHtyUb8OigA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F3C07801B1;
Thu, 5 Jun 2025 14:21:15 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DB48912034B;
Thu, 5 Jun 2025 14:21:15 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN>
Message-ID: <jwv8qm6capu.fsf-monnier+emacs@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
<E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
<DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
<jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN>
<5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN>
Date: Thu, 05 Jun 2025 14:21:13 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.157 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78685
Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org,
tpeplt@HIDDEN, Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> By the way (and probably unrelated) I get the warning:
>
> In end of data:
> ~/emacs/lisp/register.el:580:40: Warning: the function =E2=80=98cl-find-c=
lass=E2=80=99 is not known to be defined.
>
> but that function is autoloaded so I'm not sure what's wrong.
It's autoloaded but only after you load `cl-lib`.
Stefan
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 16:27:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 12:27:23 2025 Received: from localhost ([127.0.0.1]:35748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uNDR2-0000xl-Vr for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 12:27:23 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:44284) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1uNDQw-0000wI-Br for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 12:27:17 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5532a30ac41so1334543e87.0 for <78685 <at> debbugs.gnu.org>; Thu, 05 Jun 2025 09:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749140828; x=1749745628; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=p5UfjzSl4cqzzrm2dPSb3zNUUj4Utc6LsYe36E1LjJo=; b=gXNn1xdELSiQ93YJM5xUfhl0Htrk4cEucvRGC/0m7oMMfgGuLtBmm9fbBzvv24S4/U P58ZcmfF4m5rDkPJEP48EXo9mExv/LNLfNBcWuYYXE80y04QcZ89Dk//8mHlSfJ4tXim VhM/nVmUpwLy2qai+tsd5evDVQ/i6RvDpwwadMGftO/2j21+QF3RTN0Ui4j6srajASUm KX/F+MJjRfB668MLgMMpUsPuYf5sScn7olWhPiuPkyNn9Wbva6FaloSEce9O6AOnaXxj 2CfZ6QD/8bTdCGEe5T8cLiQwSLOSnVgZwtHMrIDMAEbeRf3cKv0bph9YqJKlgkkSldcy tCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749140828; x=1749745628; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=p5UfjzSl4cqzzrm2dPSb3zNUUj4Utc6LsYe36E1LjJo=; b=aqE0i3BCBMQg21MCeWTv6GOANd37kn1iF+ahPpij4okfKSY8mMMOfuoHXBfiIe1Tx3 sGqQIyNe0jmsu/OPhnGCjbwrgB6Gsw3gLzoaH/56/NRglV7zrXLkF+vMItV/UOlOHI4r ekiKpqNEJTuYQbRzB6Bql/MknQeXJuzmSFHca8R2RYSywReOOyIjRi6Qmngb55founHo ulniARLXH+nsGCHSXNYC//KAuxz46e8N2LnyYCh1GhmoNDodyQ5+d7IK6kgjLydcbamr lGFsJ7znHCEc817t5SeDHn6F6tck97F/dTppoeZDe1gLw/zvWhZYnONdZ3EuJvLHSFLu 9Usw== X-Forwarded-Encrypted: i=1; AJvYcCW8VZYBLVFSIEB4e5IWBP45DdzyKPuuyeOHDbKlkbwMkZphgOL1KcpHe6IX/7+zSHagvJPY6w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwPUm+2WU1dMXU8YSU4Ib4LxLqEmJ6wMPCn/tBeqIEBoVJyelon A5juuyEpiUqOPQA4JsEwLg5yG3q/nYopafO6T2VWclSAXL+8IKWhtxuT X-Gm-Gg: ASbGncsrYG37sAKoOO2OJN4s/khcAKJdkOGdzLDJORQKs3sCNylaTRtCmMVnX8AHc+F NG+T5WZLKZYoNKJEqkYswux+drZd+U1tqCRYxuye2Kw5jmKCxr1+VIPGkdHbEvUZnDihV/iiHS/ ByW2RDqd9nkGmwwvTBDRF8lQ8n9nxMMe+ZIoX0cgZIe+VMIUgUxEe8qnIQE9yOs0fIBWmAJTk4r 7g8/NRqALXpPM0+Zgod/kaC6Q9IUSJjWT8liO9fHVdYlwoRI6gjB3wt6AYW4ug+v2vt1HwB8lPi GEc7CFqya8Azm9Av30R3tHFqKKmgX/XZibw+mFZPVIdRgB+KMgruonf1sTNKul8NdNAz+Ndzdzo L3QlHerkDM3c2S3Q9YBYIlymqei2v2t6oFx4figoH9A== X-Google-Smtp-Source: AGHT+IHdEl5b25NGvtUdFHnQFbeaY1xVX9w/bIOlDQ9ghNlEbBGwtrXW5fgs4txzNCKI6N1m8d1YsA== X-Received: by 2002:a05:6512:1188:b0:553:2868:635c with SMTP id 2adb3069b0e04-55357bd6a2cmr2511273e87.48.1749140827301; Thu, 05 Jun 2025 09:27:07 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5533791cc77sm2635664e87.165.2025.06.05.09.27.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jun 2025 09:27:06 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> Date: Thu, 5 Jun 2025 18:27:06 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <5E74E8D5-532D-4621-BD33-5BB431C1A58D@HIDDEN> References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN> <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN> <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 5 juni 2025 kl. 16.35 skrev Stefan Monnier <monnier@HIDDEN>: > I think this was a regression introduced by the new > `interpreted-function` representation. Yes, good thing we caught it. > I'd be tempted to simplify this to `functionp` (the difference would = be > that it would accept `module-function` objects, but I think that would > be an improvement). That's probably fine and dandy. I pushed something to master, please see = if it's what you had in mind. By the way (and probably unrelated) I get the warning: In end of data: ~/emacs/lisp/register.el:580:40: Warning: the function = =E2=80=98cl-find-class=E2=80=99 is not known to be defined. but that function is autoloaded so I'm not sure what's wrong.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 16:17:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 12:17:29 2025
Received: from localhost ([127.0.0.1]:35694 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uNDHU-0008Cw-2J
for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 12:17:29 -0400
Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:46264)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uNDHQ-0008Bd-Cd
for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 12:17:25 -0400
Received: by mail-ot1-x32f.google.com with SMTP id
46e09a7af769-72ecc0eeb8bso360240a34.0
for <78685 <at> debbugs.gnu.org>; Thu, 05 Jun 2025 09:17:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1749140238; x=1749745038; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=ctzlhHqMUNmFkRAzeGYhZ73x2d6trycpwxvrEuD50ow=;
b=aSUr78cLMARU3IP4DBfe5+E5QBM5COkWP6LOTmlTex/ICt48AFiSAe0vKd6mFoJdlE
8UxOBGzGtGRej5M2QMOkbfTAFVdJReJF8uli9kEl1R7tOWHyZ9YywpWQYGO69Bby8gLQ
HrOgNBBg7ksvT/EwDuBRsu0LfTz5Je6N1IVeJ0n3DhD9KD2dJNP1Z0O4cRIIe93oyi8G
dXlAa1vq/PfThL6TC5fqi3COb5/62Tsn99mOs302Nn7SNA36XSUdSnQyoxSmGPhuHAll
SfKW4m2IC5cLBBMWTh39ewzsh+Gh+Yu2ZReQuJ1IUZzc7uSA8FRx69YfPK0DUl+9Z64o
YSbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749140238; x=1749745038;
h=content-transfer-encoding:mime-version:message-id:date:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=ctzlhHqMUNmFkRAzeGYhZ73x2d6trycpwxvrEuD50ow=;
b=lGk3aj+C7CQFwooufpsXnR+zFfutjO2/SK4RtT/Y1BjYXPhpiM1WKTlX3IQndI4085
lywBEPb032+46KhJ0zjH9QB4Fim+aKNUh/BAjChfnC8EExg6rt7v9jE6gneY727m8hgt
53F6VvLC6TJ0hSRIVj8wWI3Yso1to3CqP+03wIZX8BMEA7DAQ9bq4D6xCeHyzecRxZ0l
CjZQL9qB17HTbBWHBNC3MOY271XDIViLszluwf5PvauzsZN+hbXHpVwQ7FQmMW5uEZWX
kNfdqg1ZKvk0+whijZBLvG78MBJ0ptCQ5kBWx6OBNfji0kZDkR2GUjioKMMSN0odE1vC
G5rg==
X-Forwarded-Encrypted: i=1;
AJvYcCWXuuX++kf/xO74NzPA+JRYFjuCjJ5sUKDWHqINt4JJfqvBaiVcJOhKQaNnoTs3D8uQYO9VvQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw//tMFFSxg5yttSxKdPngczdbHM9/4g/u95SDbg26O9YGVpPlt
cNfyUZ19d0ZnVukXfT3r0FakLHAW/YTI/FQaADEwXDpKl96ulMXRhQa0losrlSRz
X-Gm-Gg: ASbGncu6+zQ7gXvisw0w88BzBPSsa6HWrgYV3Nm9WwQrdGxJ2ZCqKbxeh3w6cgtgrbS
/O9TmHESwpj/25JF89VfNZyj74JQKDsEDM9XGw3xuEcVB2jkIR/GMBtCydOrRw4gEyUsLFXgRbH
OWWPb0fgaI6C/2B/QXYC7eOVM/jZ99OK/xLXT/4URVUZKs7Vy6SL4CAZhEgm/a5H+v/BolmDoNS
BrzRi13ttAOtbQY1b+qnf9Efo0yBUPGsMF7+vxqd1WxDFMkhDYf+mrSHheq2kbKpDjKfB7enXOb
C9H5roBoT+CxG9iY3/HsKERG4+MbiJa716air3bEmX8TH16cBHayRhZS59U7
X-Google-Smtp-Source: AGHT+IHe974g7mgwUA6BpBmbWGLHwVOasUDhYfJGikbljH1q4W+hZEVU5XiTQcrS7ogoy/+s+1GukA==
X-Received: by 2002:a05:6214:21ad:b0:6fa:c41e:ccf0 with SMTP id
6a1803df08f44-6fb08f97fb6mr306016d6.36.1749140227296;
Thu, 05 Jun 2025 09:17:07 -0700 (PDT)
Received: from t530.local ([2600:8806:a600:8260:e575:8453:5794:64aa])
by smtp.gmail.com with ESMTPSA id
6a1803df08f44-6fac6d33abdsm122979486d6.14.2025.06.05.09.17.06
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 05 Jun 2025 09:17:06 -0700 (PDT)
Received: from t530.local (t530 [127.0.0.1])
by t530.local (8.18.1/8.17.2) with ESMTPS id 555GH5xZ109015
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
Thu, 5 Jun 2025 12:17:05 -0400
Received: (from my_login@localhost)
by t530.local (8.18.1/8.18.1/Submit) id 555GH5MV109014;
Thu, 5 Jun 2025 12:17:05 -0400
X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN
using -f
From: tpeplt@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#78685: 30.1;
Call to `sort' in lisp/desktop.el is missing a keyword.
In-Reply-To: <86qzzymwdm.fsf@HIDDEN> (message from Eli Zaretskii on Thu, 05
Jun 2025 11:21:41 +0300)
Date: Thu, 05 Jun 2025 12:17:05 -0400
Message-ID: <87zfem17um.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org,
monnier@HIDDEN, stephen.berman@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> I have not customized that. C-h v says that its value is t.
>
> You need to compile two.el when one.el is already compiled.
>
Yes, that is the source of the discrepancy.
So, consider the following two scenarios:
1. emacs -Q one.el two.el
- C-x C-e on each form in each file, one.el first, then
two.el
- When the expression (one-hello "hello") is evaluated,
then Emacs produces a backtrace that starts with:
> Debugger entered--Lisp error: (wrong-number-of-arguments #f(lambda (greet=
ing who) [t] (print greeting) (print who)) 1)
2. If, instead of evaluating the forms in two.el, we compile
the buffer, then no backtrace, warning, or error is issued.
The compiler *can* produce the warning, as you have
demonstrated, but it can also *not* produce it in the course
of interactively writing and compiling code. Because elint
loads all of the sources and, presumably, evaluates all of
the sources, it produces the warnings.
Since the compiler does not always produce the warnings that
elint produces then the issue of "let=E2=80=99s throw away elint
because the compiler *can* produce the same warnings/errors"
should take that into consideration. How much work is it to
get the compiler to produce these warnings *inside* Emacs so
that users see them when they issue one of Emacs=E2=80=99s several
compilation commands?
This comes up because I have elint-ed various packages that
I have downloaded/installed and found that elint identified
these sorts of problems. Authors of these packages are
presumably compiling them (inside Emacs) and not seeing
the errors.
>> Continuing with emacs -Q:
>>=20
>> 4. M-x byte-compile-file RET on "two.el" gives a fourth
>> compiler command that yields no-warning, no-error result.
>>=20
>> 5. When I ran the M-x compile RET with:
>>=20
>> Compile command: emacs --no-site-file --batch --funcall batch-byte-compi=
le two.el
>
> This command doesn't tell Emacs to add the ~/ directory to load-path.
> you need to say something like
>
> Compile command: emacs --no-site-file --batch -L ~/ --funcall batch-byte=
-compile two.el
>
> Also, one.elc should already be in that directory. Then you should
> get the warning, as Stefan and myself do.
>
Yes, the following two expressions reproduce the problem:
$ rm -f ~/one.elc ~/two.elc && /usr/bin/emacs -Q --batch -L ~/ -f batch-byt=
e-compile ~/one.el
$ /usr/bin/emacs -Q --batch -L ~/ -f batch-byte-compile ~/two.el
In toplevel form:
two.el:8:2: Warning: =E2=80=98one-hello=E2=80=99 called with 1 argument, bu=
t requires 2
Now, remove two.elc and edit two.el using emacs -Q. Issue
the command M-x emacs-lisp-byte-compile, and Emacs responds
that it wrote two.elc, with no warnings. The Emacs user
then thinks, "OK, I compiled the file, no problems, moving
on..."
The assumption, earlier, was that the compiler would
identify the error, but it only does this under certain
(non-interactive) circumstances.
Also, if two.el contains the expression:
(require 'one)
or
(require 'one "~/one.elc")
then the non-interactive compiler generates the warning
message, but if it contains the expression:
(require 'one "~/one.el")
then the non-interactive compiler generates no warning.
--=20
The lyf so short, the craft so long to lerne.
- Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 14:35:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 10:35:56 2025
Received: from localhost ([127.0.0.1]:35013 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uNBhE-0006qN-2T
for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 10:35:56 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6532)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uNBhA-0006pq-75
for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 10:35:53 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ACCB1100029;
Thu, 5 Jun 2025 10:35:45 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1749134144;
bh=1eurWKKCq06Eaz+pKbXBc5SOZ09Xbp/7F1mXSdKIk64=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=gDI4PJv6YVB8d7CQbasy3MqAOz6+fq15bgm/Ux1ZdHpWCHsnPoofUXqrnL0XIkY84
LE9Tntuc4KuW9UKS9Su7D2St/b0XCFbN+7JRSG3v8M4Wiv45LyCDwf1WpEWHrB+srQ
1EqxpyfRX+4AJQl8XOqQJWlFIRWxN0uIgaB6CD2LOPMFlUbtZBe9adIHrd/oQhVGFd
v2cStScYOjtjf7W4UP/XqVUqFnA7+Wb6bZnthww8sQU2dDTmnIM2jgDtbxKh62S6wr
Ylk4AOZbl2SpjhdNtxoAQ++707D1THGEV33xHGMYZZFSnKUUjZDn8AYhXVyPMO0Bz7
gELkIRCWQxBgA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D2F6B100034;
Thu, 5 Jun 2025 10:35:44 -0400 (EDT)
Received: from alfajor (unknown [104.247.225.139])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8ED0C120444;
Thu, 5 Jun 2025 10:35:44 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
Message-ID: <jwvjz5qjmbg.fsf-monnier+emacs@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
<E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
<DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
Date: Thu, 05 Jun 2025 10:35:43 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.336 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78685
Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org,
tpeplt@HIDDEN, Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> Anyway, is there a good reason why we only perform arity checking in the
>> compiler when the callee is already compiled?
I think this was a regression introduced by the new
`interpreted-function` representation.
> - (setq fn (symbol-function fn)))
> + (let ((sf (symbol-function fn)))
> + (and
> + (or (symbolp sf)
> + (consp sf)
> + (and (not macro-p)
> + (or (closurep sf)
> + (compiled-function-p sf))))
> + (progn
> + (setq fn sf)
> + t)))))
I'd be tempted to simplify this to `functionp` (the difference would be
that it would accept `module-function` objects, but I think that would
be an improvement).
> (let ((advertised (get-advertised-calling-convention
> (if (and (symbolp fn) (fboundp fn))
> ;; Could be a subr.
> @@ -1471,7 +1476,8 @@ byte-compile-fdefinition
> (if macro-p
> `(macro lambda ,advertised)
> `(lambda ,advertised)))
> - ((and (not macro-p) (compiled-function-p fn)) fn)
> + ((and (not macro-p) (or (closurep fn) (compiled-function-p fn)))
> + fn)
And maybe here as well? Or `(eq (cl-type-of fn) 'function)` if we care
about excluding symbols and conses (but still include `module-function`s)?
Stefan
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 13:12:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 09:12:48 2025
Received: from localhost ([127.0.0.1]:60615 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uNAOl-0007Hb-EI
for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 09:12:48 -0400
Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:60741)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>)
id 1uNAOi-0007GP-5I
for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 09:12:45 -0400
Received: by mail-lf1-x12f.google.com with SMTP id
2adb3069b0e04-54e98f73850so1080230e87.1
for <78685 <at> debbugs.gnu.org>; Thu, 05 Jun 2025 06:12:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1749129157; x=1749733957; darn=debbugs.gnu.org;
h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
:from:sender:from:to:cc:subject:date:message-id:reply-to;
bh=3r+rpvfYaIsYkj8FSDycC0+5BIckjCw5xVgJm+4baOg=;
b=cu0fkrh5uRqJaPZopTM/tHBgU+gbpynnztQOSgCENYIKJbLf2jf3gDPABGi/2zxOiS
M/r3ZyZxfkXMUClY0jjB+jMgKL7U2iFXIBjEqfh4wU/7NN4jyXS7KcvnRiTqy2zipOEa
PAszxvQ7tC+GIAqdC7az4n4VleQORn5ETAsL0L5E1eMjOpebnWMS/ekL49iEoUVTWlr4
7bkdl3OjWVJwPB7wx4hd0lAGcj3DUGtmUGhbxz3sC6EqbNFQ2zwzpeDfj+LqX8yhnmA6
Rwm1EWpjVBwDuIavBoWNRyggnurIS7hJgI1Ntlg+1lLBRmOmnntYgnZCGIgDJTYn6eKo
3b1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749129157; x=1749733957;
h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
:from:sender:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=3r+rpvfYaIsYkj8FSDycC0+5BIckjCw5xVgJm+4baOg=;
b=bTmVkVkZXxLmiEqqpOYA07TzJDJJRSlnaBcpZhm4HhNHhmChppZf5F62FO4Lk0KTH7
9udTv3JiS+QTeMGM9TI7EwvZ7v7yZgPxDFUH3Y6REomyvHhW27mHscYQBzjDtIwQYytT
+8dbZYwcx2Aep3b4E9uV4OGA83UuE3x8Bt6l2GD36vI2q/66f3DEqYCkc53YP7lPkiB7
TmltWtCpj8d1XzhM1uEzVWGe365pXaPrZOk4yeSE7d3tQL/MwghvdqNcvwaFL4zLChSw
33qTeobCZgI8UkdbzfrK1034R7osDbOvx16GZ0fDXXv7e+Zs36OLN0LkMEuyQQumuLEp
Rdmg==
X-Forwarded-Encrypted: i=1;
AJvYcCVQ8loiimyWX7FYnvbg0EFZk8Ai7riqzr6kTlrEPXYg0ZiBBpbd5avpn/BxmS9crAITJJrirw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyrXvnxP89zf+llAiqxBkWKCQ/oErk4CGOW1Hw5ALviC/E36Tdm
xCGpzfT5W/kpDx3bY54QFU17O7yhSdUxQ/Ft3/zr0kFikgdaLtF+K58n
X-Gm-Gg: ASbGncvzuKVulvCfMJF9fnko8heJ7uvCyqiXtmp+1WAPXP3dvUUXLzMN/Xo+x2vVdc8
U7/vPOakjfVAJFrjCZ5HqFg4fojxBM7ICbvVSAS2XFuBoM9n+FcUYutHfRqblJmPX80ZoFZhovG
qEUiCXJ/sGUxtC69rnbsMoAfz6sa1V19nPoLyqu7hfeQn9FGnoAnLbu5za4yq3/G4QNg3xi2+08
/6WTVVuXJMK1wGCozf2cmmin56gg6Bc81JVybsPx9TnquMvswH+vVd6Fih/WKquwJK61Ibz8X7R
6QwBfqqbgFKBE+jFx3qcfSuxFIowp24iOyJqFAv+Olv3My+po4m4KbCF45gg7mhatfBkpTrrB+5
Z4TFRXtiqeCe6HUOqBUTWlU0WG8izF36/Cv6OLb3qsQ==
X-Google-Smtp-Source: AGHT+IGqDW3wdg4O3icF675NchytyMtj85PZpT+JOJm6eaHtU7CnnoS8VITXibE9bNMgwCimwEHT6g==
X-Received: by 2002:a05:6512:23a1:b0:553:246f:d5cb with SMTP id
2adb3069b0e04-55356dfa60cmr1918109e87.40.1749129156883;
Thu, 05 Jun 2025 06:12:36 -0700 (PDT)
Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se.
[188.150.186.155]) by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-55337937858sm2656215e87.224.2025.06.05.06.12.35
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Thu, 05 Jun 2025 06:12:36 -0700 (PDT)
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Message-Id: <DA308C1A-6A57-462C-AE25-45D55E6C9298@HIDDEN>
Content-Type: multipart/mixed;
boundary="Apple-Mail=_159E8A02-5A19-4E6E-977A-4ED316B72CE2"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
Date: Thu, 5 Jun 2025 15:12:35 +0200
In-Reply-To: <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
<E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: Daniel Mendler <mail@HIDDEN>, 78685 <at> debbugs.gnu.org,
tpeplt@HIDDEN, Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--Apple-Mail=_159E8A02-5A19-4E6E-977A-4ED316B72CE2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
> Anyway, is there a good reason why we only perform arity checking in =
the compiler when the callee is already compiled?
The patch below didn't seem to have immediately disastrous effects. Good =
enough?
--Apple-Mail=_159E8A02-5A19-4E6E-977A-4ED316B72CE2
Content-Disposition: attachment;
filename=interp-callee-arity-check.diff
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="interp-callee-arity-check.diff"
Content-Transfer-Encoding: 7bit
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 0ec8db214bc..17a7b0df6dc 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1456,11 +1456,16 @@ byte-compile-fdefinition
(let ((fn name))
(while (and (symbolp fn)
(fboundp fn)
- (or (symbolp (symbol-function fn))
- (consp (symbol-function fn))
- (and (not macro-p)
- (compiled-function-p (symbol-function fn)))))
- (setq fn (symbol-function fn)))
+ (let ((sf (symbol-function fn)))
+ (and
+ (or (symbolp sf)
+ (consp sf)
+ (and (not macro-p)
+ (or (closurep sf)
+ (compiled-function-p sf))))
+ (progn
+ (setq fn sf)
+ t)))))
(let ((advertised (get-advertised-calling-convention
(if (and (symbolp fn) (fboundp fn))
;; Could be a subr.
@@ -1471,7 +1476,8 @@ byte-compile-fdefinition
(if macro-p
`(macro lambda ,advertised)
`(lambda ,advertised)))
- ((and (not macro-p) (compiled-function-p fn)) fn)
+ ((and (not macro-p) (or (closurep fn) (compiled-function-p fn)))
+ fn)
((not (consp fn)) nil)
((eq 'macro (car fn)) (cdr fn))
(macro-p nil)
--Apple-Mail=_159E8A02-5A19-4E6E-977A-4ED316B72CE2--
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 12:45:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 08:45:59 2025
Received: from localhost ([127.0.0.1]:60427 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uN9yo-00059a-Rn
for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 08:45:59 -0400
Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:61882)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>)
id 1uN9ym-00059C-E5
for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 08:45:57 -0400
Received: by mail-lf1-x12d.google.com with SMTP id
2adb3069b0e04-55324062ea8so1238730e87.3
for <78685 <at> debbugs.gnu.org>; Thu, 05 Jun 2025 05:45:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1749127550; x=1749732350; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:from:to:cc:subject
:date:message-id:reply-to;
bh=N7GIHvbrbIkhh6vp4fW3nS2Wrv63vCjy9Izgk5SOXzs=;
b=ZxIP+noiUpeNdiSaSYAd51ioSnc84O5QF50RK4pqfmnQQmoKY75NPs/oKDvfOXGcX7
sDCdPxQyWGJDc6GdDfE7aOhOzYvawmQ25sggQauHXstqB7ry3YrfUsvjmgcVWKHVIUcc
48bHWWs/y8rdlsU9suv4NWnudwup/QCKUhNL8sOFpolSaBpTeaPxvYZBUa5FE3vfLkFO
pT+fPgEJMWHCWVFu+kD3vQyX4bLoeQfGgDGyHfHt5Ub5cWS+sohAePYmhLZqtTWksplh
8whwLgp0tjasLuW7M8EF6F/5d+VUfBLn9K8zsP4wFjqKBvk0tgvXScCMZzHzckPa+xXi
X8Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749127550; x=1749732350;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=N7GIHvbrbIkhh6vp4fW3nS2Wrv63vCjy9Izgk5SOXzs=;
b=MMS5hjQCwxPp6QVDPOZzNP5TzS2MMcbk3XRaKI5xBk149WunBCuTWtVETpgMTM+4VY
xw2vlPHXDtC9adiKlYZ+kvxpysAehmPoRZxqveJ4LXYlqpJHCk6aUbQXBo1SzWlBiXBu
YRd4YGfRu5gc6D4x5+/WDjJerwenGZ9uBLWKtFSXZSrvUnLdBbrXKz7sASWZAKY611Pw
nHe+XVBD2lmOqMcYNG8WcMESHSNWodJJWZ6B40kNyI52MbKPsWk9yqKEKj1zgR6bErna
fJ+qgfcpQuQLyBBleC2sqndpegAj9S9gjbt73dF6NP+Pi1JUiBOyFzgqXbR/OW4hfZMM
Fd6Q==
X-Forwarded-Encrypted: i=1;
AJvYcCWOeIppSB1RbSS+lKRNzr/BrLivQjJ6ZM+U19/PVWC5gJmFYnQ2eq1sCPAGPeRlRCvraIpXyg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzvBNgsY8UhZ2OEhHIFztluxb5AMX3seuHFYXvC2N6rI/IIVADx
2cSII8qsOv50b/skNH9MdVaPA79C9d3AvM5o3uf3flFd1/MzR3aWvae8
X-Gm-Gg: ASbGncu35qS4nWCsKBZEPg/5CHv+46qdY+g6TbfLoWQ1Kxg90LOu9LXXkArl8edy+7t
f6PpG/UhsLRxwbTgsgZHzAZ3+JPHFcpNKDKNrryPcW3mMgvL6lV7ZtPylvaFy8rUMI1lGn4e/rf
zgL34FgcKbO4EDX+N2pbW0MhkSveioTHHLo246n7cWNhCI8dFpaRksS1yMzwhMaguxo3uvoYgk1
1AxKXfXnCHRsZIQ4SrkaA+Cqcs+eIed0/bbyNnus223FI+MIB8kRPmy0jKUPO4Y3VMDQTKs4nWV
zQbo+/Mc/jK8O3Vd+CMSy+xICFvsDOqrz/R/B4eEVHXrxHE+1B3yF/Vvjjp3l/Km55OiVGmPSFq
KqjnvO7dqFi6o9qlyj60lwraEkfWD6GYIDzC2QfXLwBTKTLO1p36v
X-Google-Smtp-Source: AGHT+IET/f4RmrEEzfJu1J6P1McEoL1VXHDFEgyJBKWPYp2nqWfQl0Wkx868lQjY0suCEJtnvRISHg==
X-Received: by 2002:a05:6512:104a:b0:553:2450:5895 with SMTP id
2adb3069b0e04-55356af64a3mr2260051e87.4.1749127549394;
Thu, 05 Jun 2025 05:45:49 -0700 (PDT)
Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se.
[188.150.186.155]) by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-5533791d0bcsm2629909e87.208.2025.06.05.05.45.48
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Thu, 05 Jun 2025 05:45:48 -0700 (PDT)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
In-Reply-To: <jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
Date: Thu, 5 Jun 2025 14:45:47 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <E7EB17F2-D603-475F-923B-C1D16134B71E@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
<jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN,
Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
4 juni 2025 kl. 17.13 skrev Daniel Mendler <mail@HIDDEN>:
> tpeplt@HIDDEN writes:
>=20
>> 1. =E2=80=98elint=E2=80=99 has its deficiencies (notably, it does not =
know
>> what to do with macros), but this instance is only a false
>> positive because elint is being asked to do something it
>> should not, that is, be knowledgeable about an archaic form
>> ("old-style") of =E2=80=98sort=E2=80=99.
You will probably find that elint won't shut up no matter how you call =
`sort`.
> FWIW I don't consider the (sort SEQ LESSP) form archaic. It is useful =
if
> you want an in-place sort without the additional features provided by
> the keywords. So far this calling convention of sort has not been
> deprecated, and I hope it stays here for a while, also since it is =
used
> by many packages.
Indeed, when the new calling convention was added it was clear that =
warning about old-style calls would not be productive. The old code =
probably works perfectly fine, and cajoling users into changing their =
code would make it incompatible with older Emacs versions.
We may phase out old-style `sort` calls in a future Emacs version, but =
there is little reason for being aggressive about it now.
4 juni 2025 kl. 17.36 skrev Stefan Monnier <monnier@HIDDEN>:
> Maybe a first step would be to remove from `elint.el` the linting =
which
> is already performed better by the compiler?
Maybe, but I'm not sure if there would be anything left, or if it would =
be effort well spent for that matter.
Anyway, is there a good reason why we only perform arity checking in the =
compiler when the callee is already compiled?
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 5 Jun 2025 08:21:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 05 04:21:53 2025 Received: from localhost ([127.0.0.1]:58528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uN5rF-0008Pt-6e for submit <at> debbugs.gnu.org; Thu, 05 Jun 2025 04:21:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53430) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uN5rC-0008PW-Dg for 78685 <at> debbugs.gnu.org; Thu, 05 Jun 2025 04:21:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uN5r6-0003Gs-Dk; Thu, 05 Jun 2025 04:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rbJpxWn6gtKWUhcLVc5/6EMQhnpGmqTW9JJFr7Mr904=; b=afEj+hQgETfc umlgGd2+zHcV7cSXj22fVNz4mkdPfCqrk+Be9FK4aq+MrIJXhbibWGaVeEF3eKErcKNsD6+1RiXoJ q4OU2RpZQLpnzJiYbW8u1fWxut4/+ezS3hZ3aosnpQpMt1eg0PBN35yuMX/SesevJ3GP9CG19+ZPj aqqvuzxikhsjtfDq/YmsbRCbHUOHgJhPGGeifWD7G2CNLH0JdWWkWFfjH0HNaTlqlPqk01nas7da4 307AV6twSOk/vcm+NwAE5t+TBYjN4TPtCdRwDb+mi9uq1QIN2QiaVfjBU2M28xf6fhmsEnpK6pdpL uy+oJes6kKSfxyAFQ3B2Sg==; Date: Thu, 05 Jun 2025 11:21:41 +0300 Message-Id: <86qzzymwdm.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: tpeplt@HIDDEN In-Reply-To: <8734cf2jeb.fsf@HIDDEN> (tpeplt@HIDDEN) Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. References: <87jz5s39il.fsf@HIDDEN> <8734cf2jeb.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78685 Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, monnier@HIDDEN, stephen.berman@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN > From: tpeplt@HIDDEN > Date: Wed, 04 Jun 2025 19:10:04 -0400 > > Stefan Monnier <monnier@HIDDEN> writes: > > > > > "My" makefile is Emacs's, so it comes from `lisp/Makefile.in`: > > > > BYTE_COMPILE_FLAGS = \ > > --eval "(setq load-prefer-newer t byte-compile-warnings 'all)" \ > > --eval "(setq org--inhibit-version-check t)" $(BYTE_COMPILE_EXTRA_FLAGS) > > [...] > > .el.elc: > > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \ > > -l comp -f batch-byte-compile $< > > TZ=UTC0 touch -t 197001010000 $@ > > else > > .el.elc: > > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \ > > -l comp -f batch-byte+native-compile $< > > endif > > else > > .el.elc: > > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile $< > > > > AFAIK the `(setq byte-compile-warnings 'all)` shouldn't make any > > difference in this respect. The same happens if I use > > > > /usr/bin/emacs -Q --batch -f batch-byte-compile two.el > > > > Any chance you have customized `byte-compile-warnings`? > > > > I have not customized that. C-h v says that its value is t. You need to compile two.el when one.el is already compiled. > Continuing with emacs -Q: > > 4. M-x byte-compile-file RET on "two.el" gives a fourth > compiler command that yields no-warning, no-error result. > > 5. When I ran the M-x compile RET with: > > Compile command: emacs --no-site-file --batch --funcall batch-byte-compile two.el This command doesn't tell Emacs to add the ~/ directory to load-path. you need to say something like Compile command: emacs --no-site-file --batch -L ~/ --funcall batch-byte-compile two.el Also, one.elc should already be in that directory. Then you should get the warning, as Stefan and myself do.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 23:10:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 19:10:20 2025 Received: from localhost ([127.0.0.1]:54600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMxFR-0007fm-3s for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 19:10:20 -0400 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]:44175) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMxFM-0007ck-0y for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 19:10:14 -0400 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-6facf4d8ea8so5668706d6.0 for <78685 <at> debbugs.gnu.org>; Wed, 04 Jun 2025 16:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749078606; x=1749683406; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=HcYz1G7lNZYATUG021GivExAKQLZCNeCHV1oWFlNRiE=; b=K8/InJvoTKI+3LXOpMt8BkZvuFBvHRRcT5HuO2hk9Y2B/YWkRJXaC0elGSMEZDqFmF rXSX/B6vff323wuYUggQLXfm+uwq73it+fOlQTzld7UU0SX448XpkS7peoVvZK+k2yI0 Xo1BhE8gHifjLFcQNYZI3zS7Y0lAzecn0yy3vBQ/bBQOUdQewrbz19dfGPciXG6EGGDA 1eKc88Tirn9y7Wyz6w+WdXigzBPQJnPuX11HENBECoeq3+V2R01zA3JKwJeP8p0nZnrn JDaUQe1tRoEGGHQtEpJYiL4p7PD0e/lNhq9Su9MXmU42w98AYvg5TB43KbSGOdT3rm8g kKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749078606; x=1749683406; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HcYz1G7lNZYATUG021GivExAKQLZCNeCHV1oWFlNRiE=; b=eNhDta9+4QBQU00EOVhYlbnop6nidTLof0LpWTMNlDU7BxgaagS8iK81wHUfVWJE4N CQrr9p6h3DWrjGsjLTrJr+GGwmv2+POKnKWlk4xasSTP4tB69zc0h+Ay4wJP41U8Q4kV 4LJ8R8nhoou9ITAL9jKIxJCZIJCEuA7VmhlSLHKbVKhh/8EF3nQFhzc3fe+HxE0O9VAj HorpzrbfSKtlWg+c5LssuZhergLmabkAkI3vc+HFEh4UsDHnBwXRqctdAbRYnPPpk8Ct LYl9m80ZprYZda8R/46jrhGSGaGQ7AOnWoc2Dwu4lg4PDypnE/iw3iwZONd4iJzHSxDE ycvg== X-Forwarded-Encrypted: i=1; AJvYcCWoVACq58vivQALkH6dIuDYl5DiRy40zqvkG2/bKB4vR6Fi9MfA34Lx480Ve+akUUfqrhdoJw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzildVtn9r+DhmvRIvOXuXnCb6+G0MrAduKh7KsslsUiGU8PiAT SpTfj/JjWHPmFx0AzVchYCFfScoSumsAU9Vy3YHr8INIwWRpSmtNOnr8 X-Gm-Gg: ASbGncu4sJnlYM4mLtHPfGhpUJTgCvTrc89wra193kZWQtXeBazoafoH6jWqCb2jvDo 5B4yL9dhQeRMwTete22JrOU6zlN5GNSo6LdvmIozR91oxYwscb0NGG8FTqRhcjSydGJ5iQsJk/q rgvfECIK7IpZk0gkCw9/ApquDcoDFcniXuflZehpV3c1KwysF1cLf0g+RzJHeEJUY5KV6s1NvM9 9GYQjupBZg9o3QR5+EEIro+uYM+emoSC5YPjWSt2CVSOgG36FcpIQesPUHE2fWzrbaOjLqdDr3g OYcoib5lQWqKS6CSSTlEPaf/KE6UWTiQoJCRyLBJ/5RawrNo7QyYw/01N10o X-Google-Smtp-Source: AGHT+IGEap5jeNXbtHmcb8XBMKxMgJe/9TDi25hbytrYNgn03S8bqv0927dFz/dypx9hVXHDXEhn5A== X-Received: by 2002:a05:6214:27cd:b0:6fa:d8bb:2945 with SMTP id 6a1803df08f44-6faf7358619mr72945096d6.17.1749078606061; Wed, 04 Jun 2025 16:10:06 -0700 (PDT) Received: from t530.local ([2600:8806:a600:8260:e575:8453:5794:64aa]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fac6e1a931sm108302726d6.100.2025.06.04.16.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 16:10:05 -0700 (PDT) Received: from t530.local (t530 [127.0.0.1]) by t530.local (8.18.1/8.17.2) with ESMTPS id 554NA4xT093243 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Jun 2025 19:10:05 -0400 Received: (from my_login@localhost) by t530.local (8.18.1/8.18.1/Submit) id 554NA4JI093242; Wed, 4 Jun 2025 19:10:04 -0400 X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN using -f From: tpeplt@HIDDEN To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <jwvh60vkv16.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 04 Jun 2025 18:27:46 -0400) Date: Wed, 04 Jun 2025 19:10:04 -0400 Message-ID: <8734cf2jeb.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: > > "My" makefile is Emacs's, so it comes from `lisp/Makefile.in`: > > BYTE_COMPILE_FLAGS = \ > --eval "(setq load-prefer-newer t byte-compile-warnings 'all)" \ > --eval "(setq org--inhibit-version-check t)" $(BYTE_COMPILE_EXTRA_FLAGS) > [...] > .el.elc: > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \ > -l comp -f batch-byte-compile $< > TZ=UTC0 touch -t 197001010000 $@ > else > .el.elc: > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \ > -l comp -f batch-byte+native-compile $< > endif > else > .el.elc: > $(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile $< > > AFAIK the `(setq byte-compile-warnings 'all)` shouldn't make any > difference in this respect. The same happens if I use > > /usr/bin/emacs -Q --batch -f batch-byte-compile two.el > > Any chance you have customized `byte-compile-warnings`? > I have not customized that. C-h v says that its value is t. I re-ran the three commands under emacs -Q and got the same result as I reported earlier, that is, no warnings, no errors: Continuing with emacs -Q: 4. M-x byte-compile-file RET on "two.el" gives a fourth compiler command that yields no-warning, no-error result. 5. When I ran the M-x compile RET with: Compile command: emacs --no-site-file --batch --funcall batch-byte-compile two.el Result: -*- mode: compilation; default-directory: "~/" -*- Compilation started at Wed Jun 4 19:00:46 emacs --no-site-file --batch --funcall batch-byte-compile two.el Compilation finished at Wed Jun 4 19:00:46, duration 0.23 s ============================== -------- ~/two.el ---------- ;;; -*- lexical-binding: t -*- (require 'one "~/one.el") (one-hello "hello") -------- ~/two.el ---------- -------- ~/one.el ---------- ;;; -*- lexical-binding: t -*- (defun one-hello (greeting who) (print greeting) (print who)) (provide 'one) -------- ~/one.el ---------- -- The lyf so short, the craft so long to lerne. - Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 22:28:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 18:28:02 2025
Received: from localhost ([127.0.0.1]:54255 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMwaX-0003NP-Sl
for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 18:28:02 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41403)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uMwaR-0003MV-CC
for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 18:27:59 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EFB1544167E;
Wed, 4 Jun 2025 18:27:48 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1749076067;
bh=hKOhahEUO2bJJtKIkcUWG9n2zVhlr/yky+pB9012KT4=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=cg5+vpU+p/CHYFyx7l70EWImUQCK3saEH6azj5I5TSMCi608gH/4ZqA5bGMpHqBv+
XmgL5lasZyYCB7y9J88IED4DWVka0ENkNCpoDY+wpiyQEsKR88wpHuLCvWGUedc/7s
uFLrikstfu7T2EH/HaAYdwErj48qguKdTg4B2/n5WOLbjb6V67i2OwpCPR2PJRTQJs
TYVPxHZ86/o3we9dDZ+xA3o7YrU72wNpui3PJgB1iklwXZk1qKqO+sojV+NcbP/xAk
gzlw50X3k2ovkmLFLqxJV6NKcUuOXZsPI8N8UqHRikBb5uVmfsCxbAmqc+RF9lt0vN
7IE9ZY3qvT9xw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E3E944166E;
Wed, 4 Jun 2025 18:27:47 -0400 (EDT)
Received: from alfajor (unknown [104.247.225.139])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5B52E1205D2;
Wed, 4 Jun 2025 18:27:47 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: tpeplt@HIDDEN
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <875xhb2mdz.fsf@HIDDEN>
Message-ID: <jwvh60vkv16.fsf-monnier+emacs@HIDDEN>
References: <875xhb2mdz.fsf@HIDDEN>
Date: Wed, 04 Jun 2025 18:27:46 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.336 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78685
Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
tpeplt@HIDDEN [2025-06-04 18:05:28] wrote:
> Stefan Monnier <monnier@HIDDEN> writes:
>
>>> ----- one.el -----
>>> ;;; -*- lexical-binding: t -*-
>>>
>>> (defun one-hello (greeting who)
>>> (print greeting)
>>> (print who))
>>>
>>> (provide 'one)
>>> ----- end of one.el -----
>>>
>>> ----- two.el -----
>>> ;;; -*- lexical-binding: t -*-
>>>
>>> (require 'one)
>>>
>>> (one-hello "hello")
>>> ----- end of two.el -----
>>>
>>> Assuming that one.el is found on your =E2=80=98load-path=E2=80=99, then
>>> two.el will compile without any problems reported.
>>
>> Really? Here I get:
>>
>> % (cd lisp; make two.elc)
>> ELC two.elc
>>=20=20=20=20=20=20
>> In toplevel form:
>> two.el:29:2: Warning: =E2=80=98one-hello=E2=80=99 called with 1 argu=
ment, but requires 2
>> %
>>
>
> Read two.el into Emacs, C-x C-f.
>
> 1. Compile the buffer using =E2=80=98elisp-byte-compile-buffer=E2=80=99 (=
C-c C-b)
> 2. Compile the buffer using M-x emacs-lisp-byte-compile (or
> via the Emacs-Lisp menu).
> 3. Compile the buffer using M-x emacs-lisp-native-compile
> (or via the Emacs-Lisp menu).
>
> In all three cases, the compiler issues no warning or error.
>
> What does your makefile define for "ELC"?
"My" makefile is Emacs's, so it comes from `lisp/Makefile.in`:
BYTE_COMPILE_FLAGS =3D \
--eval "(setq load-prefer-newer t byte-compile-warnings 'all)" \
--eval "(setq org--inhibit-version-check t)" $(BYTE_COMPILE_EXTRA_FLA=
GS)
[...]
.el.elc:
$(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \
-l comp -f batch-byte-compile $<
TZ=3DUTC0 touch -t 197001010000 $@
else
.el.elc:
$(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) \
-l comp -f batch-byte+native-compile $<
endif
else
.el.elc:
$(AM_V_ELC)$(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile $<
AFAIK the `(setq byte-compile-warnings 'all)` shouldn't make any
difference in this respect. The same happens if I use
/usr/bin/emacs -Q --batch -f batch-byte-compile two.el
Any chance you have customized `byte-compile-warnings`?
Stefan
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 22:05:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 18:05:39 2025 Received: from localhost ([127.0.0.1]:54073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMwEt-0000w0-FF for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 18:05:39 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]:56586) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMwEq-0000vR-0B for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 18:05:36 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-6facf4d8e9eso4944976d6.1 for <78685 <at> debbugs.gnu.org>; Wed, 04 Jun 2025 15:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749074730; x=1749679530; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZXB9uQCj1BoifkhYkWxnf9HnDb7tkDIxHMnFukdXY3E=; b=b3kWPiMpBLO8o/RSaReNqXK9s6z95gc4sHfZ3KZ1cDInY1H10G4Uj4ugmq26UTImUa d5RagiMmHQ/YdpXWk4pe8mBiQLycXkEk0jKVYmkPOupzKuTQDvQTtvuygzb6bWEEutQM /doCh0GWza+1uUaBrYegZm5yV1ni4+E9Umsi6lexo40H9SRUmf0tGR32XYRmhhwUzgSM Z3f2wc11Mhx+C9Ck62v+SnE2O6v3TdDGYl/Q8K/aGJJglrFiKISHMmgm9yTbY0bzJ0WY CdIz6pqzefhQX2jfQ3tw7H2HSt8QHR4bFVU580j9Ufc8+yX7a+9NUOOsiS/mY2DuCbiz SZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749074730; x=1749679530; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZXB9uQCj1BoifkhYkWxnf9HnDb7tkDIxHMnFukdXY3E=; b=hNjGQOS+FsKvO7mGfaejlp45fS+CHO0f2jmBiu0dCQ3yVRTnrtLlFLyyHXaiJal4Y7 QDaVRHOe66PsUCoj23LECPiOLPCC1OQ1rgcQgrnnnCtWfnkF600p8kHwuCpK5bGR0QO2 liGqWURsPsf/d7DhJDabA9756uQpED+Tmzfgoi5JZHpE4ywUH1jPADHTuV195sbAC0Uh jEZ/gy+pIfzd08QkeZM0/TmRqut5aeDYmCDurDaJCj6pprQqR6Rn+8MD77wnvGcs27XA EhNc7aVKO5AS26szxtHq+5zW2Ofid+23haV8SNWxqheLLnA7j3UJ47oj9i/Kzj7kd4vD ImCg== X-Forwarded-Encrypted: i=1; AJvYcCX7HQtcu1U73955ls6xA/0ZtqJvllPLU9l/YHTeOvaiwZF6nB7vAIiNdrp+TlE7M0mxB3oidw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxsJJ4ClG3s3UVei8OqI0byqJb72yiac+miMyXWO2F7JP/KSNHR ucDHQrbbvFMkNHziVKX3AJvp/Y3OLony7HhZIY/wj55hFqFFXO35dz4C X-Gm-Gg: ASbGncsEicC9tNEqmGzG4bgPEoaSY8xlNCX9rkeyxnqSLf2N+JLZGbkobj5PFihs5/f jNoa71Ny6h2xc8iAd7d1Mz4tFBPLt3zHP1LL1uAN07alwN3WIS9EtKmZLH2y+tDYwvZt/OwbdY4 nwmNlglj5PxYGW7Ni5GQEIKkmKQq0Ha4ntbp7fkqMpSzlg6hVMvUeJqe533ZCISi8Mg0qN3A2hm C48+UxS2Z0lCjKth0dsdHjoREW9a712k4qpqP0l4YGa2HKwROEnLYe4tihIVLGtxLVGBHEqzeHe i4e6lBJRIbBxospEp1/UjEbkZiP1XvfQsElL3i+VwulkcWyzEISIrIljnEHH X-Google-Smtp-Source: AGHT+IGuoKXO39LgNwC4aSil3a2kp0bsAV9zWxVDHMfj78qKby2eQfV8iqsaxdUADkqUScjSEK3opw== X-Received: by 2002:a05:6214:5182:b0:6f8:8fdf:f460 with SMTP id 6a1803df08f44-6faf6e988e4mr65504866d6.9.1749074730116; Wed, 04 Jun 2025 15:05:30 -0700 (PDT) Received: from t530.local ([2600:8806:a600:8260:e575:8453:5794:64aa]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fac6e1a90esm106803416d6.105.2025.06.04.15.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 15:05:29 -0700 (PDT) Received: from t530.local (t530 [127.0.0.1]) by t530.local (8.18.1/8.17.2) with ESMTPS id 554M5SOY090854 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Jun 2025 18:05:28 -0400 Received: (from my_login@localhost) by t530.local (8.18.1/8.18.1/Submit) id 554M5Sma090853; Wed, 4 Jun 2025 18:05:28 -0400 X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN using -f From: tpeplt@HIDDEN To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <jwvmsankzja.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 04 Jun 2025 16:45:13 -0400) Date: Wed, 04 Jun 2025 18:05:28 -0400 Message-ID: <875xhb2mdz.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >> ----- one.el ----- >> ;;; -*- lexical-binding: t -*- >> >> (defun one-hello (greeting who) >> (print greeting) >> (print who)) >> >> (provide 'one) >> ----- end of one.el ----- >> >> ----- two.el ----- >> ;;; -*- lexical-binding: t -*- >> >> (require 'one) >> >> (one-hello "hello") >> ----- end of two.el ----- >> >> Assuming that one.el is found on your =E2=80=98load-path=E2=80=99, then >> two.el will compile without any problems reported. > > Really? Here I get: > > % (cd lisp; make two.elc) > ELC two.elc >=20=20=20=20=20=20 > In toplevel form: > two.el:29:2: Warning: =E2=80=98one-hello=E2=80=99 called with 1 argum= ent, but requires 2 > % > Read two.el into Emacs, C-x C-f. 1. Compile the buffer using =E2=80=98elisp-byte-compile-buffer=E2=80=99 (C-= c C-b) 2. Compile the buffer using M-x emacs-lisp-byte-compile (or via the Emacs-Lisp menu). 3. Compile the buffer using M-x emacs-lisp-native-compile (or via the Emacs-Lisp menu). In all three cases, the compiler issues no warning or error. What does your makefile define for "ELC"? --=20 The lyf so short, the craft so long to lerne. - Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 20:45:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 16:45:22 2025
Received: from localhost ([127.0.0.1]:53439 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMuzC-0000uJ-Ax
for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 16:45:22 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12533)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uMuzA-0000tX-N8
for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 16:45:21 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3285744166B;
Wed, 4 Jun 2025 16:45:15 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1749069914;
bh=Lc4NJysmscglu6pteiu+qc+rqTF7mvdyOCvn+ZEBuEI=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=ma2ua1hNIpAaqfti2+gxGO2encvbZNHq6jyEMKc17e1c2SXY99bRWyZ+z/hkTvmSq
RZnkkcsucAw///W6tynl+zUQ6r8GIHYsDQnuEB7dn9cAG9VQ9dlfvaffEU9jQD5VfW
JsjpoLG/tvTRU4beElqb4HMwErZVxExMxvwUwrK+Xx9AN+R0dgiLukBr8RaUtdGamp
aGdNV8N3+6jzsBgyk04nwhftWFHcDI1ZzDaY3MAEZpFk6Jc7sZP/PUCseCTyUQzGl6
1rX8Ay2QzoYMJi+1TZE9o/JAZOKPX2t7xhRO3IizhdNhtHBnLhYPqcbBa1RyYEfHwR
LOFHx4Gi/5luQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4CA5E441651;
Wed, 4 Jun 2025 16:45:14 -0400 (EDT)
Received: from alfajor (unknown [23.233.149.155])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1E68A120206;
Wed, 4 Jun 2025 16:45:14 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: tpeplt@HIDDEN
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <878qm72y12.fsf@HIDDEN>
Message-ID: <jwvmsankzja.fsf-monnier+emacs@HIDDEN>
References: <878qm72y12.fsf@HIDDEN>
Date: Wed, 04 Jun 2025 16:45:13 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.201 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78685
Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> ----- one.el -----
> ;;; -*- lexical-binding: t -*-
>
> (defun one-hello (greeting who)
> (print greeting)
> (print who))
>
> (provide 'one)
> ----- end of one.el -----
>
> ----- two.el -----
> ;;; -*- lexical-binding: t -*-
>
> (require 'one)
>
> (one-hello "hello")
> ----- end of two.el -----
>
> Assuming that one.el is found on your =E2=80=98load-path=E2=80=99, then
> two.el will compile without any problems reported.
Really? Here I get:
% (cd lisp; make two.elc)
ELC two.elc
=20=20=20=20=20
In toplevel form:
two.el:29:2: Warning: =E2=80=98one-hello=E2=80=99 called with 1 argumen=
t, but requires 2
%
- Stefan
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 17:54:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 13:54:13 2025 Received: from localhost ([127.0.0.1]:52053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMsJY-000519-RH for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 13:54:13 -0400 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:43287) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMsJU-0004zh-VZ for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 13:54:10 -0400 Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4772f48f516so13071841cf.1 for <78685 <at> debbugs.gnu.org>; Wed, 04 Jun 2025 10:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749059643; x=1749664443; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ys92k4cCxhhD7Jo2zQwvP4uwk1kVS8vJ2iIMKbh3E4o=; b=E0OEN6uIYb9rSGp11HOZ36radRJfOWEogLX6zE6T6mhWQLFxJoIp8HLj55lWx9+48a d1Qg7xKmbjKVJhNLQlkyWs1eyDZW0HbVnzPMJA/N7N+mcgfoqDWzzGaD3p1q1LFuRnJE DBdhMpwHs69mhNz9FllxZPUpQcwwVLFKXRNseb7YYeizqpEcfOYMX9+PWnwo7CWXWp11 Qw8kNpnu3xHw2hFE5OUeajEMo8kkvjZz9JzHfCpj8N/hrTyrphub5tez6lMAMeNqJtrv LwkCreC62+y99rWd2AWeJ3tpLHZ2RK8woh6P51c63xfqQVNyI986jcD6Z3v+0tOG5U1T MztA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749059643; x=1749664443; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ys92k4cCxhhD7Jo2zQwvP4uwk1kVS8vJ2iIMKbh3E4o=; b=SY6lPFVohWrRQfYubryqbJv54L2AtoK9szNIvQ/zZ0QsWJW1Aj2essR410JukGg/P/ ey5N/igA0dziT3FH9seP884YeTBY78c1fNPHzLDjeqcQYYteVjjntzmpMx6EZklhDn2w dHz40DJ8gkh1Csx8XgAiTwDCKBZ08cmatUoySBF7+25E3vFtNjdHjirhqNxCTmKQXFjr TLXQ8GpS7FVp+LT6LSC6m4AdVeo6kuFOC18I81rPder4ZVATi39OMYH8yyD4FixAdvEe 0hUvITACywtsRWBRNiubXtj4zdD4rr7e7suA46rSVwMkiJP/yn9Y+z30EBAjZ8KMEt8o G7Ww== X-Forwarded-Encrypted: i=1; AJvYcCUgv40LyL9WBO7ZUND/xKxFNkZh+1X3/zvMezJtJi/awDfZSC46ieCXbmcrp1eyptX/fblbCg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwrCLJBmcdGabmQ70RCREbQFwq89bbZ7nrmWxB8GCa6gUcAYJpJ bE5ayXaWAzpdqHq4uHLkhmCdgSOgdncn1nDb9WW7naKwebhHVCoNFMO8 X-Gm-Gg: ASbGncvT34r2KE6+LjzwIihjU81OsXwjoDdmW2MYXEqZijK79Jq5JyTK1hETl8VTT2c UAiiYLkvNNchjBfpNVYOcaDt8FbcGviXKLUuKKztTbo7EEJwnSGC/lVV6hJ87rQ7iRJbBI/Y9g1 pXnkjEN9jluzdxV5Vs3xR1nps/ngimc2pnEme582TqFHhjZgewAaI3bU81ZNpzk1HXmWzQdYk6C OYEtiKvmj1d6PUNYyiEvylRD9irByZisVvZR5/nn5NLg77BuVR4L5/hMqngMmhygGhzHaTXg0DU lqRyV3zNbqC91M9JWKWVF3mQT4h9IgeV0rvZGDMR7zoi6Gde/A== X-Google-Smtp-Source: AGHT+IHJDQAXGDE9JfhC37GrYx4yJiBgQxHq5g3WylWGY6xWYxRcN5iRRKmAm6nLB9Q+U5MS7vSa5g== X-Received: by 2002:a05:622a:1924:b0:494:9d6b:620f with SMTP id d75a77b69052e-4a5ae743e23mr5617421cf.14.1749059642983; Wed, 04 Jun 2025 10:54:02 -0700 (PDT) Received: from t530.local ([2600:8806:a600:8260:e575:8453:5794:64aa]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a5a9230355sm9673851cf.76.2025.06.04.10.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 10:54:02 -0700 (PDT) Received: from t530.local (t530 [127.0.0.1]) by t530.local (8.18.1/8.17.2) with ESMTPS id 554Hs18h086849 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Jun 2025 13:54:01 -0400 Received: (from my_login@localhost) by t530.local (8.18.1/8.18.1/Submit) id 554Hs1RG086848; Wed, 4 Jun 2025 13:54:01 -0400 X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN using -f From: tpeplt@HIDDEN To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <jwv5xhbed16.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Wed, 04 Jun 2025 11:36:34 -0400) Date: Wed, 04 Jun 2025 13:54:01 -0400 Message-ID: <878qm72y12.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org, stephen.berman@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >> How about we declare elint as obsolete and remove it from the elisp-mode >> menus? Of course if someone wants to make it useful again then that's fi= ne, >> but as someone who has written his own share of linters, I wouldn't >> necessarily start with elint.el. > > I don't have a strong opinion either way, but as a data-point I've never > used `elint.el`. > Maybe a first step would be to remove from `elint.el` the linting which > is already performed better by the compiler? > Consider two files, one.el and two.el: ----- one.el ----- ;;; -*- lexical-binding: t -*- (defun one-hello (greeting who) (print greeting) (print who)) (provide 'one) ----- end of one.el ----- ----- two.el ----- ;;; -*- lexical-binding: t -*- (require 'one) (one-hello "hello") ----- end of two.el ----- Assuming that one.el is found on your =E2=80=98load-path=E2=80=99, then two.el will compile without any problems reported. But elint will report: In top level expression: two.el:5:Error: Wrong number of args: (one-hello hello), (greeting who) As I wrote earlier, this is especially useful for programmers who are new to Emacs Lisp who will not see the problem until they run their code and a backtrace is generated for the (one-hello "hello") expression. (It can also be used as a simple-minded sanity check when you install a new package to give you a little more faith that it will have fewer run-time errors.) It would be good if the compiler were to report problems like this so that we can eliminate this use of elint. It was just such a mismatch between the function signature for =E2=80=98sort=E2=80=99 and its use in =E2=80=98desktop.el=E2=80=99 that sta= rted this problem report. Another problem that elint will flag is when packages fail to include a =E2=80=98(provide <package-name>)=E2=80=99 in their source, as recommended by the Emacs Lisp reference manual. It has flagged several such instances in the Emacs packages sources, such as in "lisp/subr.el" and "lisp/textmodes/paragraphs.el". Presumably, elint does not know about autoload. --=20 The lyf so short, the craft so long to lerne. - Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 15:36:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 11:36:46 2025
Received: from localhost ([127.0.0.1]:51016 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMqAX-0003qC-Kk
for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 11:36:46 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42501)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uMqAU-0003pN-P4
for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 11:36:43 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 317B58071A;
Wed, 4 Jun 2025 11:36:36 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1749051395;
bh=42CoIUafzglhLpcfGV4ExDfBRoQ7WHRjLpIxlYayCbk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=PWIgtM6QeQtB2aSXhOEk8Dt6sFv3s+E0zWJ1vU4IQshdxtFVOb0bRSOPduUI39FIC
h5Pk/Nbv8Ijzcgqhx1xtld6LRfXt064Bp+PItKfJyBkQfI3sLEejWq3tNT69nH3fIY
iMuizav1tk9s+09eDxfVxpINPf12UPQjehvwsGuZJMka9YzbsNiLv96tWBRpWrkTs5
tEaiwCw+6hbfOMtbOouRLMMGmTytdyT4svNxkbSVthGMttyqrj380vszZFG6g4G6O5
kcEvN6QF+CkM8nk/ut7kQf/0tgaoZ1lFc3QcFXoDsVOvR2iGGkoEeR2T/hZHe6QU9f
YDMyxLLnnSGvw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 510F6808F6;
Wed, 4 Jun 2025 11:36:35 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3F4EB1206AC;
Wed, 4 Jun 2025 11:36:35 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
Message-ID: <jwv5xhbed16.fsf-monnier+emacs@HIDDEN>
References: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN>
Date: Wed, 04 Jun 2025 11:36:34 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.156 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 78685
Cc: 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN,
Stephen Berman <stephen.berman@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> How about we declare elint as obsolete and remove it from the elisp-mode
> menus? Of course if someone wants to make it useful again then that's fine,
> but as someone who has written his own share of linters, I wouldn't
> necessarily start with elint.el.
I don't have a strong opinion either way, but as a data-point I've never
used `elint.el`.
Maybe a first step would be to remove from `elint.el` the linting which
is already performed better by the compiler?
Stefan
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 15:14:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 11:14:11 2025
Received: from localhost ([127.0.0.1]:50831 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMpog-0006sH-MS
for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 11:14:11 -0400
Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:33851 helo=mail.qxqx.de)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <mail@HIDDEN>)
id 1uMpoc-0006qB-He
for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 11:14:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type:
MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender
:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:
List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=bVfCcgxPDOQS7aKGBv35Jp1FvIy5zD4eAvSI+NcE2pc=; b=SQ0mSvCemDBa0XYr3+yucHijkK
XuDbmtpgiSQl0SARkVCt0UDkNV7ADQihg0htCR3OtKrrWpKKUBgJHMopJfZUfR2QPArp2CjxSmUrS
wOpiH+2uf5/pGZMYeFWPg87awy7UIXjwN5bIIPhHmMQD8UCCb45PANpXJ701zwP1e9Jc=;
From: Daniel Mendler <mail@HIDDEN>
To: tpeplt@HIDDEN
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <87cybj3653.fsf@HIDDEN>
References: <87cybj3653.fsf@HIDDEN>
Date: Wed, 04 Jun 2025 17:13:56 +0200
Message-ID: <87tt4v7d57.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78685
Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org,
monnier@HIDDEN, stephen.berman@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
tpeplt@HIDDEN writes:
> 1. =E2=80=98elint=E2=80=99 has its deficiencies (notably, it does not know
> what to do with macros), but this instance is only a false
> positive because elint is being asked to do something it
> should not, that is, be knowledgeable about an archaic form
> ("old-style") of =E2=80=98sort=E2=80=99.
Yes, but this is a general problem of Elint. Emacs function calling
conventions change occasionally and if Elint has a problem with sort it
has problems with many such changes.
> 2. One significant use for elint at this point is that it helps
> inexperienced Emacs Lisp programmers to include packages
> that their code references (and experienced programmers who
> are rushing). It also points out that not all packages in
> the Emacs sources have the recommended =E2=80=98provide=E2=80=99
> expressions, but thanks to =E2=80=98autoload=E2=80=99 this does not cause
> problems.
As far as I can tell, package-lint does that too. package-lint is on
NonGNU ELPA and provides a Flymake backend, such that one can enable it
when editing Elisp packages. In Elisp buffers in my Emacs
`flymake-reporting-backends' lists these backends: hl-todo-flymake,
elisp-flymake-checkdoc, elisp-flymake-byte-compile and
package-lint-flymake. With these backends the overall Elisp development
experience is quite good, and many errors and linting issues are caught
early on.
> 3. If the =E2=80=98desktop=E2=80=99 code involved here were in a project =
of
> mine, I would respond to the elint report with "Thank you,
> elint, for pointing to one of my archaic calls to =E2=80=98sort=E2=80=99.
> Let me spend 1 minute adding the single keyword, compiling,
> and checking in the change."
FWIW I don't consider the (sort SEQ LESSP) form archaic. It is useful if
you want an in-place sort without the additional features provided by
the keywords. So far this calling convention of sort has not been
deprecated, and I hope it stays here for a while, also since it is used
by many packages.
Daniel
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 14:59:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 10:59:02 2025
Received: from localhost ([127.0.0.1]:50756 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMpa2-0004p5-Be
for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 10:59:02 -0400
Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:44469)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMpa0-0004oI-06
for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 10:59:00 -0400
Received: by mail-oi1-x234.google.com with SMTP id
5614622812f47-400fa6eafa9so4725197b6e.1
for <78685 <at> debbugs.gnu.org>; Wed, 04 Jun 2025 07:58:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1749049134; x=1749653934; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=3TinOifUWAaQYSCJ784Birfmpt23npptUQ2imimNfT4=;
b=jkPiFf3ems8S/XqZSFRqGKOSzFCMeQR8aOE6iZM1KebMvZKQasyIqRdNKWrWoiA3ae
xGwx9d8NnzYvk7DpVUeWFB7pxw6lySS7dPJUjybKjGLXWYEQv42FlykLED0PPEl+7cGp
az6nEoD1U0srEh4KRHuBKqJa5WRhW7Dtpqozx//+PM3hHXznQFO9eRKr1zZRjJ9t+jRE
pA0f6yqdq04zr1PmNli7YovaBr3/8lflM5VkYDss6s89YwD18DKo7LWTTOXzoY8wNYMN
T+Wd0eQFzaxFfYxcRn/J9e+iSsW2m3aYFuFmKdqbPpVRtbjx0p4diYwm8ZPwi1+7y8PH
aX5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749049134; x=1749653934;
h=content-transfer-encoding:mime-version:message-id:date:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=3TinOifUWAaQYSCJ784Birfmpt23npptUQ2imimNfT4=;
b=CvJjwcJn7XJnwIFGL+4tfW9dnxTtgEYCf9SO0r4CgxAmTTGne045EnVZDHuFpIk+zv
QhB0SxW9crbeK/EHrAbhljwwr1u7DeiEE9VnZf1FcyBps6l76Ns0HYO5g40zjCITXt/1
JM1HLlfCjdTXrqKYK8Xbub4t0H6hMkBsei2pAyfmB+rBaUrWQUOxD47Do99/LgIfZIlq
XRiRy83Md/NtNsU8JVDdN9op3SWoNsHex8j0EAWC15utbkkux6cU9N2LLMf3q+8zNP4h
IAmD0++OhaQGaw6BdvI/zgsc6tNJFWLyXfBYFluFP0dVY1ufM43INLPKHhurlF+DZJCr
QBlg==
X-Forwarded-Encrypted: i=1;
AJvYcCV9S+oT5hgIbEysiEQK2DgXzw4WihOrBJABNW8H9d1VLgYDWn9rSCBQA7f19XPc0gGa2BgJIA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yxo311rlfTsPnfHKqLafhkkXjLc+1sQ2NaXRp3SvxrpHQS8Hv71
prTR4trpCo4K9eSxXc1nbMX5bdaRqdCN8jubZd8k//QhjOT9fm+FCj5R
X-Gm-Gg: ASbGncvVly014lTl/KEKm0898fTvoZfSCOlvue8z8Y6GlkYh5vz702VLvoc3JSb7tZt
YntDJMIZqGQxm0PTd50LnyQkOsx17WRpqJyCioxuCy/uzE0+odvfydEhOGZJWZlwvrjKpc0wNZV
ryywWq1i/IjQ1vNGiNYkNcQ7VNYeEUsuwzIpIw7/OLYP3Q5zU1Qq8os/BMw7ndqVoAxOcfDVcPE
zjPLFhBfufOBbOF60b1wrMTDpjJwo2Ll56tQvqPVdwgY5EpJ5keDw9G3sYjtD/atp0s5PXqyFI6
lJP/hQ6gCOLyr21lW9j/J27KkRfiRKw5nj2Ksy1ciewpxTgvoNFNXbWAwqo=
X-Google-Smtp-Source: AGHT+IHqilYY4MbP2Q2kq6GSQCSfn6FNmPXccbOkEPxwaX3VcRHVyrYK5BlhI5LEzkgxY+g6DFxitw==
X-Received: by 2002:a05:6808:4905:b0:406:780c:20ab with SMTP id
5614622812f47-408f2afd652mr1516468b6e.6.1749049133757;
Wed, 04 Jun 2025 07:58:53 -0700 (PDT)
Received: from t530.local ([2600:8806:a600:8260:8e58:3e4:a70c:9e58])
by smtp.gmail.com with ESMTPSA id
5614622812f47-40678ce830fsm2246736b6e.31.2025.06.04.07.58.51
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 04 Jun 2025 07:58:52 -0700 (PDT)
Received: from t530.local (t530 [127.0.0.1])
by t530.local (8.18.1/8.17.2) with ESMTPS id 554EwogD081989
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
Wed, 4 Jun 2025 10:58:50 -0400
Received: (from my_login@localhost)
by t530.local (8.18.1/8.18.1/Submit) id 554Ewm5E081987;
Wed, 4 Jun 2025 10:58:48 -0400
X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN
using -f
From: tpeplt@HIDDEN
To: Daniel Mendler <mail@HIDDEN>
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <87msanpqbj.fsf@HIDDEN> (message from Daniel Mendler
on Wed, 04 Jun 2025 15:52:00 +0200)
Date: Wed, 04 Jun 2025 10:58:48 -0400
Message-ID: <87cybj3653.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 78685
Cc: mattias.engdegard@HIDDEN, 78685 <at> debbugs.gnu.org,
monnier@HIDDEN, stephen.berman@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
1. =E2=80=98elint=E2=80=99 has its deficiencies (notably, it does not know
what to do with macros), but this instance is only a false
positive because elint is being asked to do something it
should not, that is, be knowledgeable about an archaic form
("old-style") of =E2=80=98sort=E2=80=99.
2. One significant use for elint at this point is that it helps
inexperienced Emacs Lisp programmers to include packages
that their code references (and experienced programmers who
are rushing). It also points out that not all packages in
the Emacs sources have the recommended =E2=80=98provide=E2=80=99
expressions, but thanks to =E2=80=98autoload=E2=80=99 this does not cause
problems.
3. If the =E2=80=98desktop=E2=80=99 code involved here were in a project of
mine, I would respond to the elint report with "Thank you,
elint, for pointing to one of my archaic calls to =E2=80=98sort=E2=80=99.
Let me spend 1 minute adding the single keyword, compiling,
and checking in the change."
If the maintainers have a different view, it is not the end
of the world because the archaic form works. But at this
point, there has been more time and brain power used to
discuss this than is worth to consider whether this change
should be made.
--=20
The lyf so short, the craft so long to lerne.
- Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 13:52:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 09:52:14 2025 Received: from localhost ([127.0.0.1]:49058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMoXN-00062R-Gj for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 09:52:14 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:42357 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1uMoXJ-00060j-Bz for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 09:52:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3+QDI30YPqlaX6viZiPSh4eZjsJVvERRo7ak9YWJLyA=; b=N8oKUZL3iHJX/Kq7PE+TVrUkT0 j3IEnVXhMLEkUFF5OJ+M3lgEGe6qJkQ3OtBSpTbix7vCo7qEv72AfFvoDnlUBOgZRczyQHAfh1qQE 92bBXZCYhWnNnRUXoa1FOUgFE0//E/+dk2x47gdd2HS3CWRsRLqmhLzxglKsLT7O/6dc=; From: Daniel Mendler <mail@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> References: <87jz5s39il.fsf@HIDDEN> <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> Date: Wed, 04 Jun 2025 15:52:00 +0200 Message-ID: <87msanpqbj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78685 Cc: 78685 <at> debbugs.gnu.org, tpeplt@HIDDEN, Stefan Monnier <monnier@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes: >> Running =E2=80=98elint-file=E2=80=99 function on lisp/desktop.el >> generated the following error report: >>=20 >> In function desktop-clear: >> desktop.el:759:Error: Wrong number of args: (sort (frame-list) #'framese= t-minibufferless-first-p), (SEQ &key KEY LESSP REVERSE IN-PLACE) > > The bug is arguably in elint, which assumes that all uses of compatibilit= y arguments are worth warning about. (And it doesn't understand &key.) > > Perhaps more to the point, what is elint good for these days, really? It'= s very > much an artefact of the pre-lexbind era. The elisp compiler alone should = do a > better job at issuing warnings now. It is telling that the elisp-mode fly= make > uses the compiler, not elint, and rightly so. > > How about we declare elint as obsolete and remove it from the elisp-mode = menus? > Of course if someone wants to make it useful again then that's fine, but = as > someone who has written his own share of linters, I wouldn't necessarily = start > with elint.el. > > An alternative would be to keep the elint interface, throw out the guts a= nd just > have it run the compiler (in a subprocess, for isolation). That would mak= e it a > bit more useful but I'm not sure it's worth the effort. > > Right now, though, elint seems pretty much to be a dead weight; it purpor= ts to > be more useful than it actually is. Users unfamiliar with the massive Ema= cs code > accretion disc also believe it is useful, because why would it otherwise = exist? +1 From my experience Elint produces many false positives. I use the bytecompiler, checkdoc and package-lint for linting these days. Declaring Elint obsolete seems to be the right step. Daniel
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 4 Jun 2025 13:44:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 04 09:43:59 2025 Received: from localhost ([127.0.0.1]:49000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMoPN-00059D-2x for submit <at> debbugs.gnu.org; Wed, 04 Jun 2025 09:43:59 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:52715) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1uMoPI-00057s-Dy for 78685 <at> debbugs.gnu.org; Wed, 04 Jun 2025 09:43:54 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5534edc6493so3877104e87.1 for <78685 <at> debbugs.gnu.org>; Wed, 04 Jun 2025 06:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749044625; x=1749649425; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=29NLbUw1ZTA14ntl5+AYS6OBU5sW9Q4cD4WiIEsDkB0=; b=YOrLcqgw5LbYjCLCUlFtEkZPbL1/4yW4peXJq/Y1kZnApRJXqLimsiSpWmVQd6Qai+ pN+SHjd7+Kn1WXC+5Y3v7tKP5PTgGfeWoX+u1b02iQ5CsmGODO94FJHTyGJd3PFRctCw KkitHhHNqMAuIaVpcLP6DTu6jtBqCdkWz7aDfbF+0ABbstR8CArMhUKYa+lxB7plMYha Q3rAxHqLkGCl6x4ukz+KTChqCt8u0YXcABBGDFhvazWGpQiC68QRk8rrid30Qa+k5xEz VbOEdNfQoPDDl7+h+7K+qMPr+PiQOvelIOxkRi419ZCkqsoYnYumiPWZM5ojMReyMv4V fxvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749044625; x=1749649425; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=29NLbUw1ZTA14ntl5+AYS6OBU5sW9Q4cD4WiIEsDkB0=; b=Cm+bTTL7qJq+3bHpLRgIqWIhURySqBqoU4H0A41eu1ZMjwhWEC3vYc5YC9Qc0HdLyv hnoP4gfot8oJjqlhp/UhUt9rtlhrVXOYxEA7mW0p72xRrZXTxGHWFvoW3o5tbJIjfRwk D0JGvMJT8g/g2wPBCiLG1oHQ13bC+VX9eOhynqdXjBHCp+ME32lHi+PQpecvROjeDaAn mUn3vJI61CURYVW6pWCYoCVu/Ee6zCCiXqlCEErJqlq0HJh4vhtHCMK8SF8Xfii9hYbu erNhPu1l6ty2Mt+vCN9/oNzJKnFZPT7tztTYUHK8mbWNxlJc2aQGutRnr+kyVF/I2MWq /oHQ== X-Gm-Message-State: AOJu0YyvCmJp9wkSzxlgYSZwghwDy+BCyKHQzD86jovWs22kVi75CqYi ewPRyP0u4/Er8sI+8HonDGwNDBr0+KWx7GDbssIojimrKb/L0Ql7IHQb X-Gm-Gg: ASbGnctSUAfHmq5AvvofuKZ4Mwc9v/+QS/XH7p11VfuZ/D0SSwXWpd3uTBVj/v5A6tC lTcNKsTAtolg0jRoyItFL82BfvFDGp2iAICzXWdxATbF4r8YZBwjpDIS/1wC3DZiVDiKdSvwu4n 4UMJphLdQFIyNOZQ2QJRVafW45Ob+wJNMM7HmhsfKnulYz4+KFGvtbELHaTTDHAjNoMsFo1roaY EgGmtP3McFzJKarqh8qkQS71ZVMCfmb95KKVF/fPMOPYWLFQjfHZCCxc1YTt5GI2LUVquHgMmBy /snmyI1s8jJK1sD2vccEspkP9Z7928A/aDn9bAfY1xYo+E0HE/a6UxmS4JyhyHKuQzztdao6ZJn TarQN8CgqG1PWPje8q5YSTbYZdIqVeVPI6nKinPHXzCwELhFk4MReAXwi60v4ZHM= X-Google-Smtp-Source: AGHT+IG76WOLphWqTbCRI7V0ytFmRTS0fg/513klstHM2CaW+RCBxOWBLJvbNZBw58Eq6j8QSUiMXA== X-Received: by 2002:a05:6512:3ba7:b0:553:268e:5019 with SMTP id 2adb3069b0e04-55356af6e42mr895983e87.11.1749044625048; Wed, 04 Jun 2025 06:43:45 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5533791d166sm2311868e87.207.2025.06.04.06.43.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jun 2025 06:43:44 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. Message-Id: <979859F5-F115-4A7D-8FFE-E72F55D81EDB@HIDDEN> Date: Wed, 4 Jun 2025 15:43:43 +0200 To: tpeplt@HIDDEN X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: 78685 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > Running =E2=80=98elint-file=E2=80=99 function on lisp/desktop.el > generated the following error report: >=20 > In function desktop-clear: > desktop.el:759:Error: Wrong number of args: (sort (frame-list) = #'frameset-minibufferless-first-p), (SEQ &key KEY LESSP REVERSE = IN-PLACE) The bug is arguably in elint, which assumes that all uses of = compatibility arguments are worth warning about. (And it doesn't = understand &key.) Perhaps more to the point, what is elint good for these days, really? = It's very much an artefact of the pre-lexbind era. The elisp compiler = alone should do a better job at issuing warnings now. It is telling that = the elisp-mode flymake uses the compiler, not elint, and rightly so. How about we declare elint as obsolete and remove it from the elisp-mode = menus? Of course if someone wants to make it useful again then that's = fine, but as someone who has written his own share of linters, I = wouldn't necessarily start with elint.el. An alternative would be to keep the elint interface, throw out the guts = and just have it run the compiler (in a subprocess, for isolation). That = would make it a bit more useful but I'm not sure it's worth the effort. Right now, though, elint seems pretty much to be a dead weight; it = purports to be more useful than it actually is. Users unfamiliar with = the massive Emacs code accretion disc also believe it is useful, because = why would it otherwise exist?
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at 78685) by debbugs.gnu.org; 3 Jun 2025 22:43:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 03 18:43:17 2025
Received: from localhost ([127.0.0.1]:43140 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMaLk-0008Di-P1
for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 18:43:17 -0400
Received: from mout.gmx.net ([212.227.15.19]:37253)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <stephen.berman@HIDDEN>)
id 1uMaLh-0008DQ-3S
for 78685 <at> debbugs.gnu.org; Tue, 03 Jun 2025 18:43:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net;
s=s31663417; t=1748990585; x=1749595385; i=stephen.berman@HIDDEN;
bh=0wCCmSiZXIXHd12oZjI/1fB6271K7tv66w23dskHK20=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
content-type:date:from:message-id:mime-version:reply-to:subject:
to;
b=QGoq/9lijqKVpYZgdlwoxlC5TM4qplzlbseDQ3ZLVVD6jkyxswlcW0WpezbH/afv
VK5SILJE+INgfFxGF51GIh8TE3CXHqZNLT7YIpezBpT4RjMhvz+v5uzauLt8weP1V
GgGAYHsj1Cb5gZWtk9SxkBzk7YtIshUNJPHteCleQl6qbZNpKmNYR0hmC8bNJgrA2
rWc+mCeDP5oi7uqeBzAP1ZsQrAOjYZosc9OrlJzJ0qMIoHvRu5F+0Uer0h5i4GYWZ
hu7ITYMj0jXHEg1Vvo6bj/YoYhcJauk3CYrZjjxohSzOvtl19UwzwcxOhqkGvlw/C
3lxIHZAVEzoz4ptMTQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from strobelfs2 ([94.134.94.214]) by mail.gmx.net (mrgmx004
[212.227.17.190]) with ESMTPSA (Nemesis) id 1MfpSl-1up1P62r3R-00gonf; Wed, 04
Jun 2025 00:43:05 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: tpeplt@HIDDEN
Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a
keyword.
In-Reply-To: <87h60w31if.fsf@HIDDEN>
References: <87h60w31if.fsf@HIDDEN>
Date: Wed, 04 Jun 2025 00:43:04 +0200
Message-ID: <87msaola4n.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:LpduWJc2JgA3hA/0RmX5/PMvyDJ8aA7XRZu1JtKgAFW/m1UpSK+
aOCSE1yAi7Hsd4HU4wasEYq3aYFH+4Mx7deELjBvSPIB4J06vMCz5tSM/AYmYII9+1akC7j
K0Ow5vkfJ+w0rZ/R2jlI5CoqhVq5Oyaq6AhRD6SvSLQJispyurQjuknkkakFQccSlPuN74C
F+N4pNZ/gUvV0XxcxOekw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:lYhZTdyyfAA=;Y9rVvPCMFHTxhjHm8FSn9C8ifTG
K55q6Ghcfx7GF0KssA4/OepJCIgb2rjVTl/Wq1ihiI6CDRpAygh4DultihhsNpghKLOuyHtrE
UGJ+1N6OKRvM40HgysPCgpfQRSMUA8J2eKhI54cr+s+cBbmKz9BMagOTvkYWf+zGQOXy8GCND
eZy2Y9auj7ViThn+Cani7EBaUAoVoA4dRrZtbcDKmqi+zTaBP4zoapA46LVa4EkdRL80Hrac3
PUmrjZgqHPlHR5JZj6z5xXG1TLkOAVDRVSwR2IeIWGoCVccMY7vQmCQ1AbSfVVROBArAcpe15
A3Eql2Xy1hy/GJSyzkeea6R28+yWOFd54+YZaMXcDkMvYrgIyvlTW/NIZ/L7znmKMvvB77pFC
AJnTOlzlz9PJhL4WRNwtZDWMX+1akctVfmJcYQQkM9DeDktf5E5hNzWwQx2ZNWH1N/VSaCLPX
WML193W5CPOT27JTNdzcXUH6/Qm8+W71N9WtkzaGUamEqC2mggqNc8odiGBHZGP6nUIfhBFHr
cuOLaNO6DPU9JP4Pn9TpeGGLz0iy+qesQl8GLed83ZvmV9sJJM4G4woPz8IECoMfAfmx1WQRb
kI4i5g+10I8skbanhjTm4WT2Ne/uCuubyW4hdW72OP8v+ldTmt9y/rUGJhFH2mQHMTNEgzOUf
7j9eMCaPTLedLFz/EKpCRKy5wSGXayOaIplCINuxx0tRsKZzlP2CIiec1UmUCDBGJ+hs1EFL/
FEdZD8UhmrNmiXTZMmWjKLjIoHZ+vptp7lHU0w4nCSjZSzIhVBiOoA4OJJiARColSFmo0ABjc
KMqjOg3vqDnjH+L0noQcL/ePLZ5nAxZgdlPKyNeJFLiWuZXfpKvX8ljtPb4YCOpHELpdfQ4Yp
u8F7g+FheowaSt8OzFBCqFaiZ7i2Q8H/Ek6FUZBfpIoQe64UvlmDcqO5KCPlgFBu/ONyR90GF
KfA3MTNz2Jcx886dEQMsxnXmjgs8a03Vcyden57BJe+CVXdgyxlyVCGJv1EDRpt7V+XTh6Mbk
1IsMXA+WnPChNSuqZtgYnVsUHQyxFqK8Sbe0Mwi77gh7CquM7VHIalJ6jHQ4mNYk1cV8Qqvhx
irViTtxzBBguAgIZIvXTBf9cEzt+Rps3Cpwf2L7LGtrUV4c4tcpF/tZ3CuNCs4mgLulBIby2g
gLgbSrmpNUhWE7FdZk9BdZfmHNRt8kaN0bdCtqEUV/lc2ExcMNj0xpFF3OgigzI0I90mfBuju
EmV5SfGUVjiHXHcLhPad/zu9I+Jl/X0jaC9woLhbvz3CGriki7RNauQXs9WleSLKrNxVtGlHc
zToGArOf8hlUQ8Tbbnj4OCCd93F25nqrBT/91Zf/RVDTSi9d5f21QrZihidWcIMM9F2mYMhX4
Aw4yyLeMSyivfsYBdRk4gpiZjNcEK/bpZyCLMMR/q/KMg0sf5BXg/ZTwybO2H9opeWTIsPLLr
KYDbNahCmN+UmfUNOxby0lygzRz1Rvi8YWvnpoOdO1xWvzHEIDAZxCQ+Ne9ZOTKu8cxy03m2c
g0cn83tdegKp2vU0z2aHmRCnSfKc2VROO81rF9GvYJIWB23ZZySiOjqXylGy18zXyDPBxtRs8
+Vnbs4rBswaOs/Bm5Q5ur0lJ2n3g2Yo5FLImQ9bopPY9ltRSmLXPioxHERadUz2OTsmlz8WLy
eX+8RfyyBP3RvUvmBGQEVVq349LX0PJC3EWrGx7G63gFNDOjiqYYHnd6KurKRLOhoPFT8iQwY
OEEn8dFOpTBvoY2P7Y0hKZUXBiukWR8EQ0qNLgAnuAW0Kaz/wfSqfYnMVVt24EYPw8OS3c666
y1T+pPxaY3MzWZAJF3w6Qprh+4bibjOA15Co4t6GGH9mCpkD1+/INC5PVAbqvgb3x+bKtw0VH
oYDO21IZ5Qvey4J2eNuD1gJ7gYmHeUUjj9h9pDBzbyPf+MJLt9PDJeLOELp1ZOLv54d3PM0Fo
ZDWpJBKyyeZX1jKDt/KotPOgTMheRO6kqTt9T2s3wFhh1b/LAgVJJPOg1E6cTc+eyZmhXWWBP
ZOuT+BqK3xQ8rjFFxPpciaROdrZ7dtJxyR8cF9ljc0k6A3jHzA1fZv+JILGbL3OwVfXOgpvAO
sne2wKfetV4ulpVZAemiYfRxoPooW7966cSnwstT+6xEnlspRqjm4oB7yiw2Nu6BU3UNR70DS
WHckSMIJBlGUk2pvbaCW2StKVTlij0YtnfghpNFCOLOQWw93vIkjgEgd6nmPb+57gSPq1FuP4
kiG/5XxfjEl5jG/vU7lIFRAR8hNuLpLaD4qu7YYegoX2rWxd5WHzZG1K/zu+DWRbfO9XoscC2
81LfJP8irFzWaOpiSOCcezaYCKzDsr0kvCiTg75rSAOGGdXt6otD74FnD2UIIIKhda0zYAKrq
spuDOHdRd+Q5r45JedxlafqXmoA9/O5MWIDvSdeYI/WaYtZWVtK2wvTiZdQMFbK0MvKzxXr1a
q2M0qfQBKR6p1AoTnrd19+JSDp8FJunW/8NAtlMwf+huB3vTF87mD2OAjcmwnOBqRP0kif452
+0iFpEo8iNdK7OErPWUHzaqY0fl0u/g/oP10gZJlUbCCimAqze8A6M3VjXJNyGhNU5TXbIucu
m2vRu1GMoOlT6ZQHxWOTDaA8DAPXMO32MvOUYhhVyrgNnjdJsrFbONWpCLZ7wgaWATYo5vDck
95whu6BPmSLZYZJ4LEKXdtkjdW7FkxU15zFN8DBREq2y2PbeNA/VlJvor/v/5MD1OI5aQVzt4
H+QsGJomcaYPAx6n9ToxpdUWGBVZQkDtgJ9OyFvUuv/AoNDSpE9GLAtSk9xHwdHfF1UP+lCiR
4YTRTFwUUp7K2Ef1lmUM9gI6NauPqVHpN4mXqqfsEJSZ2o8sF4kffsFLjQXidmEyBTLKqqE6M
/NLEj0t9X1TEah5PZgZFs4c7wQLsAHLQ1skUApnOc9jdwhgnWcy1LCS1jrKwBt4iXDhAJKLii
FoI/g2rNMdbWgvwvCp51IvE7PyKj7k6iZqFH81TG1xMgqTlQC6DQMtHiFteixQdAkC+j7iIVs
nW2qEOKlTYuSlY8ldGQG2rkI3x3wd3KOPs5yl4PlMuDHo7os6jvTwcD3v7zP3fhBkKAOPl1Cb
sqy4jc8JhVEGhpVZ5l6+cssr8oxzfrNABcYwGzT8Kgfuw9T+HLxtyvLF5+3ETfRjPwrdsU60I
5UlroQyuB20z7V2Kkazf8ShQAR/qlNmwtO2W+G0wM6q0MTQvRfHT71qYG8mTKU3koQbBfovRX
SHSDSIywGMblS+Tj
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 78685
Cc: 78685 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On Tue, 03 Jun 2025 18:26:32 -0400 tpeplt@HIDDEN wrote:
> Stephen Berman <stephen.berman@HIDDEN> writes:
>
>>
>> The doc string of `sort' says: "For compatibility, the calling
>> convention (sort SEQ LESSP) can also be used; in this case, sorting is
>> always done in-place." Are you sure the elint result is not a false
>> positive?
>>
>
> No, I had not considered the possibility that a keyword
> argument could be both optional and supported without
> actually supplying the keyword. Emacs Lisp is an
> "interesting" version of Lisp.
Well, `sort' is implemented in C, and the source has a comment about the
above calling convention:
/* old-style invocation without keywords */
Steve Berman
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 3 Jun 2025 22:26:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 03 18:26:52 2025 Received: from localhost ([127.0.0.1]:43046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMa5o-0006T4-4e for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 18:26:51 -0400 Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]:46394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMa5i-0006Qq-ML for 78685 <at> debbugs.gnu.org; Tue, 03 Jun 2025 18:26:45 -0400 Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-6fad3fdf3aaso48126756d6.1 for <78685 <at> debbugs.gnu.org>; Tue, 03 Jun 2025 15:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748989594; x=1749594394; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Wl48GV4uyVTa1hIKg0ywfaQw5rV2Hs0FfVUHXGQ4IPQ=; b=GSMd9lbHZGI4uArpovE+uFIT9/8uVBBB2lHJqe41XCZZr7lWEdPLW4DZ5w64pWCVMs wc4YbPL1L96cIaYl/Jz3jiQiyriM73UcO4LPw2cg0PCuAoIsrN5b5OjibRGJVTXvt81T CiMZusgE3o1LyHrssvE3W7Cgiy3tm+I69k+cvg1+6lXRBq3Re+Egyo2msnnyk3hiUwpN rkGLq6LgtIOuOdR/UYF1nB2GETqzi1mS5lJROUHvUNtJQxIiHsEFMHEudyHUlfxL5QT3 ghV96gYihSWwDnCBgQghY7oWGAPxmgqDtzwfgqu4tJwFmwEhG/qIFIRKNTV0/EwZXa7p tttA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748989594; x=1749594394; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wl48GV4uyVTa1hIKg0ywfaQw5rV2Hs0FfVUHXGQ4IPQ=; b=inedOjLITD4TCMQGsqFNQE82ujY0l6kcKcPPyMdQ9/qrZ4FSliExEU4Wn1iRRTixEG 70azG7z2n2a/pUbjVynbPH1hmKZHv78EX2CPK12FQcoo6gq53cdjbt4+HVWutFpRczb1 sQKtE1U6Fe6Kf2VPG6Il2Lx+H9j6TU8Z6hcUjb+BEBAFwpOI4TwINuw3NlMBMrPAQgNQ 8Tl4IMStEbvNtTt5UQphWAZ4WSjA20qV8NR6wFLu8yEKpBXrB6pbg4/YOsiJIp5Hq0T4 SWjlLBQGqJQwXCAHD/kq06DM3d2PBY+TDljwJpvW2E/X0vtyAT5qF59o0Teaq8AYNnAB zYLA== X-Gm-Message-State: AOJu0YxdQ/DxqOE2xc0ycT+3Zc2DR1KRdZ7zBZH8z93FZfjzik+75w3g X8/cBxwvCACVjQ88/XQnGTv1FG0Fb8E303aWsTffOpiBKjxw5UkDjJFc X-Gm-Gg: ASbGncvTs/WBKVoKdpn0G+Optoqxe/xLUq5RfxRjCrpZPfapLWdmc4D07I7y8oUzHzH CAtCyOtgT6Eoptw3dXcha9Mo8AsNe7QFoRJ/ElTmX7PAl8bz+QtcO6J0GkgFj4KCrADbDH2OlFk S58AJqDcDiN/FHIOTYurYK55+I/aXJCXbP03wEPDk8gQxM4vJqWdnGzJIZDSzvt/9nPvCuvuf2F pbhHcFE5lfMvdXoxdvz4bQ2ant7i9kgJVcQoGp0w+njAVd8eqSp9rPZIdC4/OMNGrBXJ4G6R/SB POVVkHtC+lhE/nktqZ5hLfuNbEMIH/Uf+6zlp546FKLFWsgXyw== X-Google-Smtp-Source: AGHT+IESj6N01RrMz7Ngfyq+j+UmS/kcqRtJG/HnwTj989VplsLFoVAJ62/BrQZWsE26am/Iooh5gA== X-Received: by 2002:a05:6214:2b0a:b0:6f8:8df1:649 with SMTP id 6a1803df08f44-6faf6e408camr8642606d6.7.1748989593962; Tue, 03 Jun 2025 15:26:33 -0700 (PDT) Received: from t530.local ([2600:8806:a600:8260:e575:8453:5794:64aa]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fac6d4d3bfsm87618756d6.41.2025.06.03.15.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 15:26:33 -0700 (PDT) Received: from t530.local (t530 [127.0.0.1]) by t530.local (8.18.1/8.17.2) with ESMTPS id 553MQWD4066828 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 3 Jun 2025 18:26:32 -0400 Received: (from my_login@localhost) by t530.local (8.18.1/8.18.1/Submit) id 553MQW2L066827; Tue, 3 Jun 2025 18:26:32 -0400 X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN using -f From: tpeplt@HIDDEN To: Stephen Berman <stephen.berman@HIDDEN> Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <87r000lftv.fsf@HIDDEN> (message from Stephen Berman on Tue, 03 Jun 2025 22:39:56 +0200) Date: Tue, 03 Jun 2025 18:26:32 -0400 Message-ID: <87h60w31if.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78685 Cc: 78685 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stephen Berman <stephen.berman@HIDDEN> writes: > > The doc string of `sort' says: "For compatibility, the calling > convention (sort SEQ LESSP) can also be used; in this case, sorting is > always done in-place." Are you sure the elint result is not a false > positive? > No, I had not considered the possibility that a keyword argument could be both optional and supported without actually supplying the keyword. Emacs Lisp is an "interesting" version of Lisp. -- The lyf so short, the craft so long to lerne. - Geoffrey Chaucer, The Parliament of Birds.
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.Received: (at 78685) by debbugs.gnu.org; 3 Jun 2025 20:40:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 03 16:40:08 2025 Received: from localhost ([127.0.0.1]:42272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uMYQa-000878-0i for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 16:40:08 -0400 Received: from mout.gmx.net ([212.227.17.20]:46299) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <stephen.berman@HIDDEN>) id 1uMYQW-00083n-6S for 78685 <at> debbugs.gnu.org; Tue, 03 Jun 2025 16:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1748983197; x=1749587997; i=stephen.berman@HIDDEN; bh=o1Wsg8UgF+AEg4Uupx2ZDLihxk2qZZ73AuWOIsZYrrk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=BJQYgU/k/iGZLNG2okKNgM4iVVJ65m88Wm+CAymIpURQtdY6T9i8a0IqhJ4VD4FV 6wzu+DQYrRItyCvPdndILSCTqKLLY7vGvZsdXjK0QWhYjGVPgL2vJcHlfY0ExQdiK 8xvQ6Uub9egEqTrIZKMuas58/NSwNpG5Opo79zbkTZILwaZzD5CEm+iPopgmbTjPy aSpcebjs0gjy0ky2PVsmth4oBF+lo+hkE9/yc/QxKNlpHdCTsyoDg3Npm5hSVCbb3 HynmCiMk3K9J4aebjI4LQTg1XbNIk52o4ZnBJyP59dAsyQMV0TM8rtvrGsuUIbcGa fyyWao/9gfto1usnOA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.214]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4b1y-1uKtzu3BnK-00Cu0C; Tue, 03 Jun 2025 22:39:56 +0200 From: Stephen Berman <stephen.berman@HIDDEN> To: tpeplt@HIDDEN Subject: Re: bug#78685: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword. In-Reply-To: <87jz5s39il.fsf@HIDDEN> References: <87jz5s39il.fsf@HIDDEN> Date: Tue, 03 Jun 2025 22:39:56 +0200 Message-ID: <87r000lftv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:HGYcQoKPvF+1b7Xl3rO+XkHlsn2KjLcUOuRj7E9xyvQOT/Bo6RS p02+cdSWa4YUxehlE35/GhvzgIgpYmRfBRwJgPwqtbzyBnBDC+yE/HUhpfFBlzuHxrlLTbf dcChop0EVffJcByWGUzLamg46Fp6DVq4auEteruwP19hGWKvXdnk6Hliz0DyTPJpbOVqGGg N8htR83OIYML+A18xTrAA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:OFppwIzNK9w=;p9Vin8NZ4wVsa/zuZOf6DuW5U2z OcxtB3G0Wovq+iihuymeusv36Y9v+MYl/E6lLofXwOYW4hzyaxBzda//p3m7Vg9XnF+fM7Nxy oEoVlQkU4DqGMS3rupRo+/Eu4bFx0bjB3CXZJus5jiBYFyfxUNHOBeeiBtt7u2VhAJqCwtWC1 Yq9F6TXKGtEYVXljHJ1MhfNgJcb5XlSZ+AH5Zh5sloa7nNlKXP3wgPvFGzqqvCyn8cpevos0u NyrhXrjFTFsfbiQ5qXE89TVdC2eHKlJdRyT9r3MFxO78H3sF7FmaQc9qJKe5H2t4queFurWyM snPF5K0GmsEWJYXY5Q816q63m1kAIrHYrBL+h/AsP50/HDfBqZUUKyDthjrdmJvcyQz+OgSUQ 6vwumXgGGdPCTIf/DBGqWwL98Eo8KjAeS4KhAeiUrZbJlIk2rnZFj6t2uSkdbs4EQfjnAk5gP NHn5hhjI4gTjNPJR0HdQvicndFpQAHeQFhR11vNHv7FBv/ua+LN0ttQ61kEeXDGV6ivTb3/cD 2hjS+G9Cr+renI0AjsrGG0KR37wwo0T4CMNqU48jCdhKNe2ojUlknc2XRN9HzBiH2gBPVJDbe mvgfeXtsdDEtesnv4hP46ouTeuCbT3qtNizUrc+KFMnc4IG+zC5JHpAoJBzHip6E9jQcnOzKS mQatHJ+GwtkdTVv4m5Ta44e3Wcvb7MbPy92TSI95uhXY80R9kf+6a5EW/IslR01iG3jzba6Op Lz354VeFVMUPUtNNkx3TcGV2m5oQsTkSzZBWaSGmU8KT6eob6+yNskBrGT9/U//lHXhGZNOLl Dgtoyu73z66YYh9fF74M0+UHnLCUzxI5Uot2TmsxoIbRCasPg6lLLqabf/38jOg0m2NZ34CwL DY/n7IpuhOU5Wyvov8YpRrQwFMVuA5Xou+L7grqn8tgjtmzrvEN9nnr9AaTGHp7sbAEROGD4r swLSXgVAt7xx2x4RZ6KIEeZibQZ3ixDVtw1qkkh46zD6SUDKUe8JAUzJwBvRl1ZKE2ZImVTD+ +3pyiKOF568Duav0xvEvgePJLwBqJa2KOqXWgYCDvVVKbLJobb1upEKzA6yyDJU67y5qAZnQr 5dy+MXQT5j45BmXbt3TSpNBbI+KEyIB8FlY9FnViSuWOqMlSpOHJYmB8Y/eGYZKdrWlb7dSfa 7xyaJmL5lFoIjEM7LElbPxdDnohA/7Z6wZP+DDkd+5VYGHyyc1R/3/OZ3hsQYllD6WO251McL C3B3WUvDcEjVnxjX7dh91SGs09tHdrnRM9+f4I/f88LUwLHnRpAzc3QFEJBtrEFvhTTeoV0NS 76NT2UHNA0k5zV/x+2sCQTvZsd+CUOf9sprqsdG8k+rgMhUy/M6wSgplBDPq3Ul/m/TQlutMD imKQzvNWF/vRvI25LZmz4seFt8oMLP9NfnV8JCmPruwK8UfSqsWnnhHPoG3rgIju314kWBMAz m1ro1rCYGvS6MQb0C9Qxy5nzGxb7McWlrc2zxujkzKKnhppsndxBFvrthLQTgQv7w35PEvQCi rX0+VdCT3AI+3jpucEquoj1qt+MxNZp8Jb3DA5Vylcy3mKmCxKowgX65eCowboPvsN/8Avn4P nG/rBrO9ZR6bKfnWDt38kT0tyK+oHkR+/vOKyz9x/XZT9lN/8xENgBm5oiae9NZe9pDJS5zCp Sl1T8QV7ScCSF1+dJ4R9RfRmPzLfLnWEnyFn2JPiKM+Af+Zoi5rt/bWD5RR9sABtW1R+Vl5ac 4A6vjT+7/EUYWE+OO8kf+Xe90tNzDUUkcTWtL/qEoz3FZF8g1sqePbt7yrDSWg4EqVutXECGP L1BvU0ppM9mHTXgPUYDNg9w07hAzSUwHlyCMF/BQTSJWXIodKLx23xpypRgcNeRY5deDiaXYG vxJEprOa3U6rank1Z+Rd7f4KvkOlT4N1dru61B7tsCdXmRKDzHFx+wFh7Vm8zLPFnkPUbb/Km nQ7Gg2SQgvZFF44ag4ThWi8Y6xsxWPqN9W23ZoyVQwTKONBBmlGsiCEVaxYRJ8HgsO5P2VLo0 GpEoNfa/q/2ufrxqj1CTDpPQQYWdAHZt7DziB0Asroufrd6CkN/HiJrZBCypXHHvyO+dNoQIw fWgwPJXDjc2hm5sb63nDS+9fpw7VKbhT/dcl4/3TOrngxZDnu6fdzeRSHHMFjgvmC0YiBSLzk U4wSUfpmLOpzhXuRGJIG/8r2IHJhC0iVEZmQoHKlA4i0NRDbVsRm0VmQe8SvveVHcNPi98kQ0 J7UDLkyD4sboX+7IIMhOAWZdZGRT2IjpbYomtvhWXI0MG1l43wUuHjBW9ExyQUf8+lVDWo1sq gT9y3cjNWH0KNTh8i4gGNskN8mH0R9MOZvZd9DjL+Kuqrn1bQPOTB7sZRnNcolO6XqGBprvga VVfyT7SkZbdnBOB07cR3SBvuI+nm/b3T+Wl6rvEFrLBk8kk+BbiPLTbelgut4uvooEIy04iqe zY8py4pXk9gZjJ5BW2ELWH8+9pKgSk73PFu8lZ1aZuH+g5brKmmTN4Nd8Xt98twZpEFIJtad4 JkjFuxIRtgegCGIKoQF5VyVKdLm/jAWxSoK4O7MBXgOkEQ5LzeCCCuKEQr/wCjbM3aN2fx5kg KRJfWsqcYLrxxHoJ07WY6FxUbfx4TTL61dUaGDm+KjYLTzQm+6f0/Q5l0pFavUMen0GCaziIY 5N4pcHstWKX/k/Sdep1eDgHmxQvc6e6EwvEjmbL+oRXdGzg5lSUWNcfChTFaS9i9HCmYD2rfI AzRFfylPiLrFPSO1Dy9HjLFS4FL0r9lc3w9O7NHp51x2gTOyr/ayfGlhpjM6W/CvzoiIGvKYS tHPbVZgcZRTF+1n4qc+nYiKsTRtTSNbcO0jwZOSbdZ2VEUR4rMuTCI+bSLiSJI37b5uansx4h nHcnrJffDz6SYcK3qIyHuIA+GBd1yAgbXnw952TaB7zr6ZW5X4tq/prVk0P+qUomzGa0gYyi8 VjSUwKV+gU+L9w+WyaJWVQNduw4gn/9GegGkcwVkttIQ2e1m33s+c7AkrqlDXrmlaCc2BNxcP LJh0Ucp2FGLITnNS2OcDvEUDl7os3KFh5rg2Ygu/Rd08894I3+QFP/Jtg0vEQZ7Di2+rm69g1 VgdpevvQDs+DvdtGQ0UwfuM/kq98M9s2oVZtS5H09DtHC7F63oXhsonDzOfzItFWCvo3YfrMW ueG88B7mkHOaNVztvlnw0Jn0xDgmXRMT7BThq8OrFw177SwtXWb+niV5NepaI+WOpnoi3UdQl rcKe9vaAboPu0evYSgyUhDYYTkxLVhJpxH9YaQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78685 Cc: 78685 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Tue, 03 Jun 2025 15:33:38 -0400 tpeplt@HIDDEN wrote: > Emacs Maintainers, > > In Emacs 30.1, the =E2=80=98desktop=E2=80=99 package contains a call to > the function =E2=80=98sort=E2=80=99 that is missing a keyword (either :key > or :lessp before the function #'frameset-minibufferless-first-p). > > Running =E2=80=98elint-file=E2=80=99 function on lisp/desktop.el > generated the following error report: > > In function desktop-clear: > desktop.el:759:Error: Wrong number of args: (sort (frame-list) > #'frameset-minibufferless-first-p), (SEQ &key KEY LESSP REVERSE IN-PLACE) > > Note that the call to =E2=80=98sort=E2=80=99 is not at line 759 (which= is > the line number at which the function definition starts), > but is at line 793 in a =E2=80=98dolist=E2=80=99 expression: > > ``` > (dolist (frame (sort (frame-list) #'frameset-minibufferless-first-p)) > (condition-case err > (unless (or (eq frame this) > (eq frame mini) > ;; Don't delete daemon's initial frame, or > ;; we'll never be able to close the last > ;; client's frame (Bug#26912). > (if (daemonp) (not (frame-parameter frame 'client))) > (frame-parameter frame 'desktop-dont-clear)) > (delete-frame frame)) > (error > (delay-warning 'desktop (error-message-string err))))) > ``` > > Please let me know which keyword is appropriate in this > call to =E2=80=98sort=E2=80=99 so that I can patch my local =E2=80=98desk= top.el=E2=80=99 > until this is fixed in a later version of Emacs. The doc string of `sort' says: "For compatibility, the calling convention (sort SEQ LESSP) can also be used; in this case, sorting is always done in-place." Are you sure the elint result is not a false positive? Steve Berman
bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 3 Jun 2025 19:34:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 03 15:34:07 2025
Received: from localhost ([127.0.0.1]:41823 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uMXOd-00010P-Lf
for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 15:34:06 -0400
Received: from lists.gnu.org ([2001:470:142::17]:52472)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <tpeplt@HIDDEN>) id 1uMXOV-0000y5-Gp
for submit <at> debbugs.gnu.org; Tue, 03 Jun 2025 15:34:00 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <tpeplt@HIDDEN>) id 1uMXOP-0005dO-9v
for bug-gnu-emacs@HIDDEN; Tue, 03 Jun 2025 15:33:49 -0400
Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <tpeplt@HIDDEN>) id 1uMXOK-0003pE-8L
for bug-gnu-emacs@HIDDEN; Tue, 03 Jun 2025 15:33:49 -0400
Received: by mail-oi1-x230.google.com with SMTP id
5614622812f47-4079f80ff0fso118963b6e.1
for <bug-gnu-emacs@HIDDEN>; Tue, 03 Jun 2025 12:33:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1748979221; x=1749584021; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=tb2dwgQs2Gb9vc0jaUMQFNNW1MjoBwuCxhxOrWtrIcY=;
b=YF3QhnVUJB1/86VaE3kjcLssrc+qKkQmbZSJNkMa90mCYW/aFOCGo+3HRqarv0CuHs
bogZLhCSu7SiKuDvWpESwt+fPqaAo85spEoa5uTj31llhs5PDvc8EJEVbTtDPehcTSj/
MlgLIbZyiBboHLT/uLd37xlArWSc6TGvZw8fqIE4qB3Bw2c56dln6A6sCm04U27Vc07p
INqV6K7sYch4Y+ZYsCMbkFPi1ndnSFF5/FdoiVn031vrTO3e0CRpy92LczQKLcO6HX/8
TtrtL2OMCw6vnFMer+GJyFGG8jS9pqNCnHAnuCJraYbcu0Thjehex67VS8iqyK/DhIDw
rOhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1748979221; x=1749584021;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=tb2dwgQs2Gb9vc0jaUMQFNNW1MjoBwuCxhxOrWtrIcY=;
b=RBJZpixsFu9EE2dsUxlcuz0Q44bqwkJK1qrB7wflp3aOAEYIYkp9N3UFYZ1e9tRx4b
azTPMm4jVwBEEf65p3rM+8Y+IHB+6CYnRWi2derR3xdi2du7klm/Pdhyzo1erLsg9WM5
SBwUZHli3+FNlpazsdD3gwE59uzIwCUoE4nYLRh0nEUZy9BslMln0L1ShXRgReElv8u5
+GoMIaC03gKADVY7e6Gt9IqndC6hQvkmA2Y2MOPkOFmAUV77KBZ6eyha8fhNEZC3Kp/b
8b/4/Z8ut/Ks4XGNNaCd3SCyCnqZBJoLIL1W+IE/vzmdY0UmMbnW7l5fmx6p0m6ZUgGm
S8Sg==
X-Gm-Message-State: AOJu0Yy6y7Jc8PqKbNMQ+eBhzcgGc4zWNrM2OV+3fg4v362zvmxY+4U0
hcwyZV4LS/qwCiWHo3olo2MyD7mZB++yeGnzaQ7vk+IK//PoB9vOBH2OOyYb9g==
X-Gm-Gg: ASbGncup+WsDLGaNt7RQDD60rbDbEuQbB124jyEwY1jzlOtspRKh/UsLyAbl8aYoXfz
hZNJiRfxWb/8Lo7H+MwNSc0maFWvt5QBqn1MEO32VTx0efKQ8af6TDAAXHiBaUnhES4lsx+twHe
C9tYf/GbcufkONIK3jDJ3WWntAjlSjbpz2ua5cWP1wKf73CigW+ivucmf0bE7pK+lkQgpIjAkGT
l7gvldSph2lqHf+i7SH5jQY5kQQUIgDjM4Krcv7ZS4W+D88U6jp05/luMdMqNPW6irMbeLkINKc
hrIHLvIGQhpBVr/Ug3iGHYGQtsNTpDBghtFog1EiKRD3d3Za
X-Google-Smtp-Source: AGHT+IFBHOEcvOxNNdm+QSoPu/n+RU7/12DbO+2Ss3Ql8k48hd/Z9g3J+CBDQSfr9DOi/iRoyP/0uQ==
X-Received: by 2002:a05:6808:6a8a:b0:3fe:fb5b:9466 with SMTP id
5614622812f47-408e34f4ab0mr2768798b6e.1.1748979221013;
Tue, 03 Jun 2025 12:33:41 -0700 (PDT)
Received: from t530.local ([2600:8806:a600:8260:8e58:3e4:a70c:9e58])
by smtp.gmail.com with ESMTPSA id
46e09a7af769-735af82d2f1sm1962807a34.12.2025.06.03.12.33.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 03 Jun 2025 12:33:40 -0700 (PDT)
Received: from t530.local (t530 [127.0.0.1])
by t530.local (8.18.1/8.17.2) with ESMTPS id 553JXctE062741
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
Tue, 3 Jun 2025 15:33:38 -0400
Received: (from my_login@localhost)
by t530.local (8.18.1/8.18.1/Submit) id 553JXcvm062740;
Tue, 3 Jun 2025 15:33:38 -0400
X-Authentication-Warning: t530.local: my_login set sender to tpeplt@HIDDEN
using -f
From: tpeplt@HIDDEN
To: bug-gnu-emacs@HIDDEN
Subject: 30.1; Call to `sort' in lisp/desktop.el is missing a keyword.
X-Debbugs-Cc:
Date: Tue, 03 Jun 2025 15:33:38 -0400
Message-ID: <87jz5s39il.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::230;
envelope-from=tpeplt@HIDDEN; helo=mail-oi1-x230.google.com
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,
DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Emacs Maintainers,
In Emacs 30.1, the =E2=80=98desktop=E2=80=99 package contains a call to
the function =E2=80=98sort=E2=80=99 that is missing a keyword (either :key
or :lessp before the function #'frameset-minibufferless-first-p).
Running =E2=80=98elint-file=E2=80=99 function on lisp/desktop.el
generated the following error report:
In function desktop-clear:
desktop.el:759:Error: Wrong number of args: (sort (frame-list) #'frameset-m=
inibufferless-first-p), (SEQ &key KEY LESSP REVERSE IN-PLACE)
Note that the call to =E2=80=98sort=E2=80=99 is not at line 759 (which is
the line number at which the function definition starts),
but is at line 793 in a =E2=80=98dolist=E2=80=99 expression:
```
(dolist (frame (sort (frame-list) #'frameset-minibufferless-first-p))
(condition-case err
(unless (or (eq frame this)
(eq frame mini)
;; Don't delete daemon's initial frame, or
;; we'll never be able to close the last
;; client's frame (Bug#26912).
(if (daemonp) (not (frame-parameter frame 'client)))
(frame-parameter frame 'desktop-dont-clear))
(delete-frame frame))
(error
(delay-warning 'desktop (error-message-string err)))))
```
Please let me know which keyword is appropriate in this
call to =E2=80=98sort=E2=80=99 so that I can patch my local =E2=80=98deskto=
p.el=E2=80=99
until this is fixed in a later version of Emacs.
--=20
The lyf so short, the craft so long to lerne.
- Geoffrey Chaucer, The Parliament of Birds.
tpeplt@HIDDEN:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#78685; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.