GNU logs - #78742, boring messages

Message sent to juri@HIDDEN, karthikchikmagalur@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#78742: [PATCH] Improve repeat-continue property handling
Resent-From: "Paul D. Nelson" <ultrono@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: juri@HIDDEN, karthikchikmagalur@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 10 Jun 2025 08:08:02 +0000
Resent-Message-ID: <handler.78742.B.17495428393198 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78742 <at> debbugs.gnu.org
Cc: Juri Linkov <juri@HIDDEN>, Karthik Chikmagalur <karthikchikmagalur@HIDDEN>
From: "Paul D. Nelson" <ultrono@HIDDEN>
Date: Tue, 10 Jun 2025 10:07:01 +0200
Message-ID: <uxsg7tcybcf2ai.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::134;
 envelope-from=ultrono@HIDDEN; helo=mail-lf1-x134.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain

This patch adds support for a 'repeat-continue' property value of t to
continue any active repeat map, following a suggestion by Karthik
Chikmagalur on emacs-devel.  Any feedback welcome.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Improve-repeat-continue-property-handling.patch

From 492a34a173cd2404cddf8ac97c98a1f968496d98 Mon Sep 17 00:00:00 2001
From: Paul Nelson <ultrono@HIDDEN>
Date: Tue, 10 Jun 2025 09:21:52 +0200
Subject: [PATCH] Improve repeat-continue property handling

* lisp/repeat.el (repeat-get-map-sym): Support 'repeat-continue'
property value of t to continue any active repeat map (suggested
by Karthik Chikmagalur <karthikchikmagalur@HIDDEN>).
Simplify logic so that repeat-continue does not interfere with
repeat-map activation.
(repeat-check-map): Allow commands with 'repeat-continue'
property value of t to continue without checking the key.
(repeat-mode): Update and tweak docstring.
* lisp/bind-key.el (bind-keys-form): Update handling of
':continue-only' keyword: only add keymap to 'repeat-continue'
if current value is a list.
(bind-keys): Update documentation, mirroring bind-keys-form.
* lisp/keymap.el (defvar-keymap): Update handling of ':continue'
keyword: only add keymap to 'repeat-continue' if current value
is a list.
* test/lisp/repeat-tests.el (repeat-tests-continue)
(repeat-tests-continue-another): Enable previously commented
tests that now work correctly.
* etc/NEWS: Update announcement of 'repeat-continue'.
---
 etc/NEWS                  | 15 +++++++++------
 lisp/bind-key.el          | 15 ++++++++-------
 lisp/keymap.el            |  6 ++++--
 lisp/repeat.el            | 29 +++++++++++++++++++----------
 test/lisp/repeat-tests.el | 12 ++++++------
 5 files changed, 46 insertions(+), 31 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index d5b62b9850a..83e050ebff4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2442,12 +2442,15 @@ will be calculated based on the window width.
 
 +++
 ** New symbol property 'repeat-continue' for 'repeat-mode'.
-A command with this symbol property whose value is a list of repeat
-maps will not activate the repeat map in 'repeat-mode'.  It will only
-continue the already activated repeating sequence.  Also 'defvar-keymap'
-supports a new keyword ':continue' with a list of commands that only
-continue the active repeating sequence, and the 'use-package' and
-'bind-keys' macros support a similar keyword ':continue-only'.
+A command with the 'repeat-continue' symbol property, which can be a
+list of keymaps or t, will continue an already active repeating sequence
+for a keymap in that list (resp. all keymaps).  The new property does
+not affect whether the command starts a repeating sequence, which
+remains governed by the 'repeat-map' property.  'defvar-keymap' supports
+a new keyword ':continue', a list of commands, and adds the keymap to
+the 'repeat-continue' property of each command in that list.  The
+'use-package' and 'bind-keys' macros support a similar keyword
+':continue-only'.
 
 ** New function 'completion-table-with-metadata'.
 It offers a more concise way to create a completion table with metadata.
diff --git a/lisp/bind-key.el b/lisp/bind-key.el
index 12417106783..49f5bd30351 100644
--- a/lisp/bind-key.el
+++ b/lisp/bind-key.el
@@ -402,13 +402,11 @@ bind-keys-form
                           ;; repeat-map is non-nil, map is always
                           ;; non-nil
                           (if (eq repeat-type :continue-only)
-                              `((unless (memq ',repeat-map
-                                              (or (get ,fun 'repeat-continue)
-                                                  '()))
-                                  (put ,fun 'repeat-continue
-                                       (append (or (get ,fun 'repeat-continue)
-                                                   '())
-                                               (list ',repeat-map))))
+                              `((let ((cur (get ,fun 'repeat-continue)))
+                                  (when (and (listp cur)
+                                             (not (memq ',repeat-map cur)))
+                                    (put ,fun 'repeat-continue
+                                         (append cur (list ',repeat-map)))))
                                 (bind-key ,(car form) ,fun ,map ,filter))
                             `(,@(when (and repeat-map (not (eq repeat-type :exit)))
                                   `((put ,fun 'repeat-map ',repeat-map)))
@@ -446,6 +444,9 @@ bind-keys
                          same behavior as if no special keyword had
                          been used (that is, the command is bound, and
                          it's `repeat-map' property set)
+:continue-only BINDINGS - Within the scope of `:repeat-map', will make
+                         the command continue but not enter the repeat
+                         map, via the `repeat-continue' property
 :filter FORM           - optional form to determine when bindings apply
 
 The rest of the arguments are conses of keybinding string and a
diff --git a/lisp/keymap.el b/lisp/keymap.el
index a12084a3ad4..cf4c8d90bb1 100644
--- a/lisp/keymap.el
+++ b/lisp/keymap.el
@@ -754,8 +754,10 @@ defvar-keymap
         (dolist (def (plist-get repeat :enter))
           (push `(put ',def 'repeat-map ',variable-name) props))
         (dolist (def (plist-get repeat :continue))
-          (push `(put ',def 'repeat-continue
-                      (cons ',variable-name (get ',def 'repeat-continue)))
+          (push `(let ((val (get ',def 'repeat-continue)))
+                   (when (listp val)
+                     (put ',def 'repeat-continue
+                          (cons ',variable-name val))))
                 props))
         (while defs
           (pop defs)
diff --git a/lisp/repeat.el b/lisp/repeat.el
index daa53fe7195..9308f972a91 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -427,9 +427,18 @@ repeat-mode
 When Repeat mode is enabled, certain commands bound to multi-key
 sequences can be repeated by typing a single key, after typing the
 full key sequence once.
-The commands which can be repeated like that are those whose symbol
- has the property `repeat-map' which specifies a keymap of single
-keys for repeating.
+
+The commands that can be repeated in this way are those whose symbols
+have the `repeat-map' property, which specifies a keymap of single keys
+for repeating.
+
+Normally, invoking a command outside that keymap terminates the
+repeating sequence.  However, if the command's `repeat-continue'
+property is non-nil, it may instead continue the current repeating
+sequence: if the property is a list of keymaps, then the command
+continues when the current repeat map is in the list; if the property is
+t, the command always continues the sequence.
+
 See `describe-repeat-maps' for a list of all repeatable commands."
   :global t :group 'repeat
   (if (not repeat-mode)
@@ -460,12 +469,11 @@ repeat-get-map-sym
   (when repeat-mode
     (let ((map-sym (or repeat-map (repeat--command-property 'repeat-map)))
           (continue (repeat--command-property 'repeat-continue)))
-      (when continue
-        (if repeat-in-progress
-            (when (and (consp continue)
-                       (memq repeat-in-progress continue))
-              (setq map-sym repeat-in-progress))
-          (setq map-sym nil)))
+      (when (and repeat-in-progress
+                 (or (eq continue t)
+                     (and (consp continue)
+                          (memq repeat-in-progress continue))))
+        (setq map-sym repeat-in-progress))
       map-sym)))
 
 (defun repeat-get-map (map)
@@ -495,7 +503,8 @@ repeat-check-map
        ;; in the middle of repeating sequence (bug#47566).
        (or (< (minibuffer-depth) (car repeat--prev-mb))
            (eq current-minibuffer-command (cdr repeat--prev-mb)))
-       (repeat-check-key last-command-event map)
+       (or (eq (repeat--command-property 'repeat-continue) t)
+           (repeat-check-key last-command-event map))
        t))
 
 (defun repeat-pre-hook ()
diff --git a/test/lisp/repeat-tests.el b/test/lisp/repeat-tests.el
index f96d8df2ebd..6bf9badf31d 100644
--- a/test/lisp/repeat-tests.el
+++ b/test/lisp/repeat-tests.el
@@ -224,9 +224,9 @@ repeat-tests-continue
        "C-M-e c z"
        '((1 e)) "cz")
       ;; 'C-M-o' should also activate
-      ;; (repeat-tests--check
-      ;;  "C-M-o c z"
-      ;;  '((1 o) (1 c)) "z")
+      (repeat-tests--check
+       "C-M-o c z"
+       '((1 o) (1 c)) "z")
       )))
 
 (ert-deftest repeat-tests-continue-another ()
@@ -246,9 +246,9 @@ repeat-tests-continue-another
        "C-M-e t z"
        '((1 e)) "tz")
       ;; 'C-M-u' should also activate
-      ;; (repeat-tests--check
-      ;;  "C-M-u t z"
-      ;;  '((1 u) (1 t)) "z")
+      (repeat-tests--check
+       "C-M-u t z"
+       '((1 u) (1 t)) "z")
       ;; 'C-M-o' shared with another map should continue current map
       (repeat-tests--check
        "C-M-s t C-M-o C-M-o t z"
-- 
2.39.3 (Apple Git-145)


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Paul D. Nelson" <ultrono@HIDDEN>
Subject: bug#78742: Acknowledgement ([PATCH] Improve repeat-continue
 property handling)
Message-ID: <handler.78742.B.17495428393198.ack <at> debbugs.gnu.org>
References: <uxsg7tcybcf2ai.fsf@HIDDEN>
X-Gnu-PR-Message: ack 78742
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 78742 <at> debbugs.gnu.org
Date: Tue, 10 Jun 2025 08:08:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Juri Linkov <juri@HIDDEN>, Karthik Chikmagalur <karthikchikmagalur@gm=
ail.com>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 78742 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78742: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78742
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#78742: [PATCH] Improve repeat-continue property handling
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Jun 2025 06:46:02 +0000
Resent-Message-ID: <handler.78742.B78742.174962435430063 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Paul D. Nelson" <ultrono@HIDDEN>
Cc: 78742 <at> debbugs.gnu.org, Karthik Chikmagalur <karthikchikmagalur@HIDDEN>
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <uxsg7tcybcf2ai.fsf@HIDDEN>
Organization: LINKOV.NET
References: <uxsg7tcybcf2ai.fsf@HIDDEN>
Date: Wed, 11 Jun 2025 09:44:28 +0300
Message-ID: <87qzzqpz7f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

close 78742 31.0.50
thanks

> This patch adds support for a 'repeat-continue' property value of t to
> continue any active repeat map, following a suggestion by Karthik
> Chikmagalur on emacs-devel.  Any feedback welcome.

Thanks, now pushed.

Also added tests for (put 'repeat-tests-call-g 'repeat-continue t)

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Jun 2025 06:45:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 11 02:45:55 2025
Received: from localhost ([127.0.0.1]:45746 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1uPFDe-0007ox-Jn
	for submit <at> debbugs.gnu.org; Wed, 11 Jun 2025 02:45:54 -0400
Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:51813)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <juri@HIDDEN>)
 id 1uPFDb-0007ny-5Y; Wed, 11 Jun 2025 02:45:52 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id A56FA4396B;
 Wed, 11 Jun 2025 06:45:42 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: "Paul D. Nelson" <ultrono@HIDDEN>
Subject: Re: bug#78742: [PATCH] Improve repeat-continue property handling
In-Reply-To: <uxsg7tcybcf2ai.fsf@HIDDEN>
Organization: LINKOV.NET
References: <uxsg7tcybcf2ai.fsf@HIDDEN>
Date: Wed, 11 Jun 2025 09:44:28 +0300
Message-ID: <87qzzqpz7f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdduudekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehkrghrthhhihhktghhihhkmhgrghgrlhhurhesghhmrghilhdrtghomhdprhgtphhtthhopeejkeejgedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepuhhlthhrohhnohesghhmrghilhdrtghomh
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
Cc: 78742 <at> debbugs.gnu.org, Karthik Chikmagalur <karthikchikmagalur@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 78742 31.0.50
thanks

> This patch adds support for a 'repeat-continue' property value of t to
> continue any active repeat map, following a suggestion by Karthik
> Chikmagalur on emacs-devel.  Any feedback welcome.

Thanks, now pushed.

Also added tests for (put 'repeat-tests-call-g 'repeat-continue t)

Last modified: Wed, 11 Jun 2025 07:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.