GNU bug report logs - #78748
31.0.50; Stale Tree-sitter compatibility report

Previous Next

To reply to this bug, email your comments to 78748 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Stale Tree-sitter compatibility report
Date: Tue, 10 Jun 2025 16:51:04 +0100 (BST)

[Message part 1 (text/plain, inline)]

The Tree-sitter parser version compatibility report generated by admin/tree-sitter/treesit-admin.el currently shows stale versions of the parsers.

Attached is a patch to resolve this.

-- 
Peter Oliver

[0001-Don-t-lock-Treesitter-compatibility-report-to-known-.patch (text/plain, attachment)]

Message #8 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 78748 <at> debbugs.gnu.org
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Tue, 10 Jun 2025 19:59:36 +0200

Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:

Hi Peter,

> The Tree-sitter parser version compatibility report generated by admin/tree-sitter/treesit-admin.el currently shows stale versions of the parsers.
>
> Attached is a patch to resolve this.
>
> diff --git a/admin/tree-sitter/treesit-admin.el b/admin/tree-sitter/treesit-admin.el
> index f41c4592039..af39963f8b7 100644
> --- a/admin/tree-sitter/treesit-admin.el
> +++ b/admin/tree-sitter/treesit-admin.el
> @@ -72,33 +72,31 @@ treesit-admin-check-manual-coverage
>  ;;; Query validation
>  
>  (defvar treesit-admin--builtin-language-sources
> -  '((c "https://github.com/tree-sitter/tree-sitter-c" "v0.23.4")
> -    (cpp "https://github.com/tree-sitter/tree-sitter-cpp" "v0.23.4")
> -    (cmake "https://github.com/uyha/tree-sitter-cmake" "v0.5.0")
> -    (dockerfile "https://github.com/camdencheek/tree-sitter-dockerfile" "v0.2.0")
> -    (go "https://github.com/tree-sitter/tree-sitter-go" "v0.23.4")
> -    (ruby "https://github.com/tree-sitter/tree-sitter-ruby" "v0.23.1")
> -    (javascript "https://github.com/tree-sitter/tree-sitter-javascript" "v0.23.1")
> +  '((c "https://github.com/tree-sitter/tree-sitter-c")
> +    (cpp "https://github.com/tree-sitter/tree-sitter-cpp")
> +    (cmake "https://github.com/uyha/tree-sitter-cmake")
> +    (dockerfile "https://github.com/camdencheek/tree-sitter-dockerfile")
> +    (go "https://github.com/tree-sitter/tree-sitter-go")
> +    (ruby "https://github.com/tree-sitter/tree-sitter-ruby")
> +    (javascript "https://github.com/tree-sitter/tree-sitter-javascript")

The same question like in bug#78747: Shouldn't we simply use treesit-language-source-alist?

> Peter Oliver

Best regards, Michael.

Message #11 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 78748 <at> debbugs.gnu.org
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Wed, 11 Jun 2025 01:56:29 +0100 (BST)

[Message part 1 (text/plain, inline)]

On Tue, 10 Jun 2025, Michael Albinus wrote:

> Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:
>
>> The Tree-sitter parser version compatibility report generated by admin/tree-sitter/treesit-admin.el currently shows stale versions of the parsers.
>
> The same question like in bug#78747: Shouldn't we simply use treesit-language-source-alist?

Yes, now that treesit-language-source-alist doesn’t need to be manually set by the user, that seems like a good idea.

Attached is a patch that does this, addressing both bugs 78747 and 78748.

-- 
Peter Oliver

[0001-Eliminate-redundant-variable-treesit-admin-builtin-l.patch (text/plain, attachment)]

Message #14 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 78748 <at> debbugs.gnu.org
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Wed, 11 Jun 2025 02:06:32 +0100 (BST)

[Message part 1 (text/plain, inline)]

On Wed, 11 Jun 2025, Peter Oliver wrote:

> Attached is a patch that does this, addressing both bugs 78747 and 78748.

Oops, forgot part of the fix for 78747.  Here’s an improved patch.

-- 
Peter Oliver

[0001-Eliminate-redundant-variable-treesit-admin-builtin-l.patch (text/plain, attachment)]

Message #17 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 78748 <at> debbugs.gnu.org
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Wed, 11 Jun 2025 17:04:58 +0200

Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:

Hi Peter,

>> Attached is a patch that does this, addressing both bugs 78747 and 78748.
>
> Oops, forgot part of the fix for 78747.  Here’s an improved patch.

I haven't tested, but the patch LGTM.

> Peter Oliver

Best regards, Michael.

Message #20 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 78748 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Wed, 11 Jun 2025 19:44:10 +0300

> diff --git a/test/infra/Dockerfile.emba b/test/infra/Dockerfile.emba
> @@
>      --eval '(setq treesit-admin--builtin-language-sources \
>          treesit-language-source-alist)' \

Since the patch eliminates 'treesit-admin--builtin-language-sources',
it doesn't seem necessary to keep it here.

Message #23 received at 78748 <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: Juri Linkov <juri <at> linkov.net>
Cc: 78748 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#78748: 31.0.50; Stale Tree-sitter compatibility report
Date: Wed, 11 Jun 2025 20:04:20 +0100 (BST)

[Message part 1 (text/plain, inline)]

On Wed, 11 Jun 2025, Juri Linkov wrote:

>> diff --git a/test/infra/Dockerfile.emba b/test/infra/Dockerfile.emba
>> @@
>>      --eval '(setq treesit-admin--builtin-language-sources \
>>          treesit-language-source-alist)' \
>
> Since the patch eliminates 'treesit-admin--builtin-language-sources',
> it doesn't seem necessary to keep it here.

Indeed not.  Updated patch attached.

-- 
Peter Oliver

[0001-Eliminate-redundant-variable-treesit-admin-builtin-l.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.