GNU bug report logs - #78856
30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data' goes missing

Previous Next

To reply to this bug, email your comments to 78856 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data'
 goes missing
Date: Sat, 21 Jun 2025 12:22:51 -0700

[Message part 1 (text/plain, inline)]

Steps to reproduce:

  emacs -Q --eval '(eww "https://en.wikipedia.org/wiki/Sun")'
  RET  ;; Follow the "Jump to content" link at the top of the page
  R    ;; Try to enable readable mode

The result is:

  Wrong type argument: char-or-string-p, nil

That's because when navigating to an in-page anchor, EWW clears 
'eww-data', so the :source property is missing. To fix this, let's just 
copy over all the properties to the new 'eww-data'. That's similar to 
what we already do when toggling readable mode.

Eli, this bug has been present for quite a while (at least since Emacs 
29; I didn't check farther back). It's a simple fix though, so would it 
be ok to install into Emacs 30? If not, that's not a big deal, and it 
can just go on the master branch. No one seems to have noticed this bug 
in the years it's been present.

[0001-When-navigating-to-anchor-targets-in-EWW-retain-eww-.patch (text/plain, attachment)]

Message #8 received at 78856 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 78856 <at> debbugs.gnu.org
Subject: Re: bug#78856: 30.1;
 [PATCH] When navigating to in-page anchors in EWW, 'eww-data' goes
 missing
Date: Sun, 22 Jun 2025 11:20:07 +0300

> Date: Sat, 21 Jun 2025 12:22:51 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> Steps to reproduce:
> 
>    emacs -Q --eval '(eww "https://en.wikipedia.org/wiki/Sun")'
>    RET  ;; Follow the "Jump to content" link at the top of the page
>    R    ;; Try to enable readable mode
> 
> The result is:
> 
>    Wrong type argument: char-or-string-p, nil
> 
> That's because when navigating to an in-page anchor, EWW clears 
> 'eww-data', so the :source property is missing. To fix this, let's just 
> copy over all the properties to the new 'eww-data'. That's similar to 
> what we already do when toggling readable mode.
> 
> Eli, this bug has been present for quite a while (at least since Emacs 
> 29; I didn't check farther back). It's a simple fix though, so would it 
> be ok to install into Emacs 30? If not, that's not a big deal, and it 
> can just go on the master branch. No one seems to have noticed this bug 
> in the years it's been present.

Thanks, I'd prefer to install this on master, indeed.

Message #13 received at 78856-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78856-done <at> debbugs.gnu.org
Subject: Re: bug#78856: 30.1; [PATCH] When navigating to in-page anchors in
 EWW, 'eww-data' goes missing
Date: Sun, 22 Jun 2025 09:36:37 -0700

On 6/22/2025 1:20 AM, Eli Zaretskii wrote:
> Thanks, I'd prefer to install this on master, indeed.

Thanks for taking a look. Merged to the master branch as e5ad9ae1009. 
Closing this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.