GNU bug report logs - #78867
[PATCH] Define dedicated faces for the package.el mode line

Previous Next

To reply to this bug, email your comments to 78867 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <prot <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Define dedicated faces for the package.el mode line
Date: Mon, 23 Jun 2025 09:13:43 +0300

[Message part 1 (text/plain, inline)]

Dear maintainers,

The new mode line format for 'list-packages' reuses existing faces 
instead of defining its own.

This can be a problem for certain themes.

The attached patch defines the relevant faces. Themes can customise 
those to meet their stated goals.

All the best,
Protesilaos (or simple "Prot")

[0001-Define-dedicated-faces-for-the-package.el-mode-line.patch (text/x-diff, attachment)]

Message #8 received at 78867 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Protesilaos Stavrou <prot <at> protesilaos.com>
Cc: 78867 <at> debbugs.gnu.org
Subject: Re: bug#78867: [PATCH] Define dedicated faces for the package.el mode
 line
Date: Mon, 23 Jun 2025 14:38:17 +0300

> Date: Mon, 23 Jun 2025 09:13:43 +0300
> From: Protesilaos Stavrou <prot <at> protesilaos.com>
> 
> Dear maintainers,
> 
> The new mode line format for 'list-packages' reuses existing faces 
> instead of defining its own.
> 
> This can be a problem for certain themes.
> 
> The attached patch defines the relevant faces. Themes can customise 
> those to meet their stated goals.

Thanks.

This kind of input is highly valuable as part of the process of
reviewing the original submissions, so that the author could augment
the patch before it is installed.  What can we do to prompt you to
such changes?  Would it help to CC you on changes that introduce faces
or reuse existing faces for new purposes?  Anything else we could do
to alert you to such changes in time for you to chime in?

Message #11 received at 78867 <at> debbugs.gnu.org (full text, mbox):

From: "Elijah G." <eg642616 <at> gmail.com>
To: Protesilaos Stavrou <prot <at> protesilaos.com>
Cc: 78867 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#78867: [PATCH] Define dedicated faces for the package.el
 mode line
Date: Tue, 24 Jun 2025 20:14:57 -0600

Protesilaos Stavrou <prot <at> protesilaos.com> writes:

> Dear maintainers,
>
> The new mode line format for 'list-packages' reuses existing faces
> instead of defining its own.
> 
> This can be a problem for certain themes.
> 
> The attached patch defines the relevant faces. Themes can customise
> those to meet their stated goals.

Thanks, I was unsure if they needed a new face before making the patch, your patch LGTM.

--
- E.G via GNU Emacs Android port.

Message #16 received at 78867-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Protesilaos Stavrou <prot <at> protesilaos.com>
Cc: 78867-done <at> debbugs.gnu.org
Subject: Re: bug#78867: [PATCH] Define dedicated faces for the package.el mode
 line
Date: Sat, 28 Jun 2025 12:51:46 +0300

> Date: Mon, 23 Jun 2025 09:13:43 +0300
> From: Protesilaos Stavrou <prot <at> protesilaos.com>
> 
> Dear maintainers,
> 
> The new mode line format for 'list-packages' reuses existing faces 
> instead of defining its own.
> 
> This can be a problem for certain themes.
> 
> The attached patch defines the relevant faces. Themes can customise 
> those to meet their stated goals.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.