GNU bug report logs - #78941
feature/igc [PATCH] igc_alloc_handler: use label "handler".

Previous Next

To reply to this bug, email your comments to 78941 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Helmut Eller <eller.helmut <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: feature/igc [PATCH] igc_alloc_handler: use label "handler".
Date: Wed, 02 Jul 2025 14:25:52 +0200

[Message part 1 (text/plain, inline)]

This patch creates a more specific label for handlers.

[0001-src-igc.c-igc_alloc_handler-Create-root-with-label-h.patch (text/x-diff, attachment)]

Message #8 received at 78941 <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Helmut Eller <eller.helmut <at> gmail.com>
Cc: 78941 <at> debbugs.gnu.org
Subject: Re: bug#78941: feature/igc [PATCH] igc_alloc_handler: use label
 "handler".
Date: Wed, 09 Jul 2025 14:40:51 +0000

"Helmut Eller" <eller.helmut <at> gmail.com> writes:

> diff --git a/src/igc.c b/src/igc.c
> index 61886f5cf90..d0bd9eb63e8 100644
> --- a/src/igc.c
> +++ b/src/igc.c
> @@ -4625,7 +4625,9 @@ igc_alloc_blv (void)
>  void *
>  igc_alloc_handler (void)
>  {
> -  struct handler *h = igc_xzalloc_ambig (sizeof *h);
> +  static_assert (sizeof (struct handler) % IGC_ALIGN_DFLT == 0);

I see no reason for that to be true on the less alignmnent-friendly
ABIs.  Is it always true?

> +  struct handler *h = xzalloc (sizeof *h);
> +  root_create_ambig (global_igc, h, h + 1, "handler");

Looking forward to the day we keep our sys_jmp_buf structures on the C
stack so we no longer need an ambiguous root here.

Pip

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.