GNU bug report logs - #78949
[PATCH] Update NEWS with info about `fill-region-as-paragraph-function'

Previous Next

To reply to this bug, email your comments to 78949 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roi Martin <jroi.martin <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Update NEWS with info about
 `fill-region-as-paragraph-function'
Date: Thu, 03 Jul 2025 08:46:54 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

This patch updates the etc/NEWS file with information about the new
`fill-region-as-paragraph-function' variable and how it relates to
`fill-region-as-paragraph-semlf'.

        Roi

[0001-Update-NEWS-with-info-about-fill-region-as-paragraph.patch (text/x-patch, attachment)]

Message #8 received at 78949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Roi Martin <jroi.martin <at> gmail.com>
Cc: 78949 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, juri <at> linkov.net
Subject: Re: bug#78949: [PATCH] Update NEWS with info about
 `fill-region-as-paragraph-function'
Date: Thu, 03 Jul 2025 10:43:35 +0300

> Cc: monnier <at> iro.umontreal.ca, eliz <at> gnu.org, juri <at> linkov.net
> From: Roi Martin <jroi.martin <at> gmail.com>
> Date: Thu, 03 Jul 2025 08:46:54 +0200
> 
> This patch updates the etc/NEWS file with information about the new
> `fill-region-as-paragraph-function' variable and how it relates to
> `fill-region-as-paragraph-semlf'.

Thanks, but this is not the right place for this entry.  You inserted
the new entry in the section named "Editing Changes in Emacs 31.1",
which is the correct place for commands that affect editing.  By
contrast, the variable you want to describe now is of interest to Lisp
programmers who develop or maintain major modes, so it should go to
the section named "Changes in Specialized Modes and Packages in Emacs
31.1", after you create a new subsection there named "Fill".

> ++++
> +** New variable 'fill-region-as-paragraph-function'.
> +The new variable 'fill-region-as-paragraph-function' provides a way to
> +override how functions like 'fill-paragraph' and 'fill-region' fill
> +text.  It defaults to 'fill-region-as-paragraph-default'.

Please add here a sentence saying that major modes can bind this
variable to a function that suits the mode, or something to that
effect.

Message #11 received at 78949 <at> debbugs.gnu.org (full text, mbox):

From: Roi Martin <jroi.martin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78949 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, juri <at> linkov.net
Subject: Re: bug#78949: [PATCH] Update NEWS with info about
 `fill-region-as-paragraph-function'
Date: Thu, 03 Jul 2025 12:31:36 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: monnier <at> iro.umontreal.ca, eliz <at> gnu.org, juri <at> linkov.net
>> From: Roi Martin <jroi.martin <at> gmail.com>
>> Date: Thu, 03 Jul 2025 08:46:54 +0200
>> 
>> This patch updates the etc/NEWS file with information about the new
>> `fill-region-as-paragraph-function' variable and how it relates to
>> `fill-region-as-paragraph-semlf'.
>
> Thanks, but this is not the right place for this entry.  You inserted
> the new entry in the section named "Editing Changes in Emacs 31.1",
> which is the correct place for commands that affect editing.  By
> contrast, the variable you want to describe now is of interest to Lisp
> programmers who develop or maintain major modes, so it should go to
> the section named "Changes in Specialized Modes and Packages in Emacs
> 31.1", after you create a new subsection there named "Fill".
>
>> ++++
>> +** New variable 'fill-region-as-paragraph-function'.
>> +The new variable 'fill-region-as-paragraph-function' provides a way to
>> +override how functions like 'fill-paragraph' and 'fill-region' fill
>> +text.  It defaults to 'fill-region-as-paragraph-default'.
>
> Please add here a sentence saying that major modes can bind this
> variable to a function that suits the mode, or something to that
> effect.

I've attached a new patch with the suggested changes.  Thanks!

        Roi

[0001-Update-NEWS-with-info-about-fill-region-as-paragraph.patch (text/x-patch, attachment)]

Message #16 received at 78949-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Roi Martin <jroi.martin <at> gmail.com>
Cc: 78949-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, juri <at> linkov.net
Subject: Re: bug#78949: [PATCH] Update NEWS with info about
 `fill-region-as-paragraph-function'
Date: Sat, 05 Jul 2025 12:09:49 +0300

> From: Roi Martin <jroi.martin <at> gmail.com>
> Cc: 78949 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, juri <at> linkov.net
> Date: Thu, 03 Jul 2025 12:31:36 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: monnier <at> iro.umontreal.ca, eliz <at> gnu.org, juri <at> linkov.net
> >> From: Roi Martin <jroi.martin <at> gmail.com>
> >> Date: Thu, 03 Jul 2025 08:46:54 +0200
> >> 
> >> This patch updates the etc/NEWS file with information about the new
> >> `fill-region-as-paragraph-function' variable and how it relates to
> >> `fill-region-as-paragraph-semlf'.
> >
> > Thanks, but this is not the right place for this entry.  You inserted
> > the new entry in the section named "Editing Changes in Emacs 31.1",
> > which is the correct place for commands that affect editing.  By
> > contrast, the variable you want to describe now is of interest to Lisp
> > programmers who develop or maintain major modes, so it should go to
> > the section named "Changes in Specialized Modes and Packages in Emacs
> > 31.1", after you create a new subsection there named "Fill".
> >
> >> ++++
> >> +** New variable 'fill-region-as-paragraph-function'.
> >> +The new variable 'fill-region-as-paragraph-function' provides a way to
> >> +override how functions like 'fill-paragraph' and 'fill-region' fill
> >> +text.  It defaults to 'fill-region-as-paragraph-default'.
> >
> > Please add here a sentence saying that major modes can bind this
> > variable to a function that suits the mode, or something to that
> > effect.
> 
> I've attached a new patch with the suggested changes.  Thanks!

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.