GNU bug report logs - #78958
31.0.50; [PATCH] Indicate "readable" state in the EWW modeline

Previous Next

To reply to this bug, email your comments to 78958 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] Indicate "readable" state in the EWW modeline
Date: Fri, 4 Jul 2025 16:34:22 -0700

[Message part 1 (text/plain, inline)]

In EWW, we can show the "readable" form of a page by default, but not 
all pages really *have* such a form. Sometimes, we just can't figure out 
what the readable form would be, so we show the whole page.

To help make this clearer for users, we could change the logic slightly 
so that when there's no readable form, we don't set the :readable 
property to t. Then we can consult that property in the mode line so 
that users are aware of what the current state it. See the attached 
patch, which includes a simple test for this new behavior.

(Another thing we could show in the mode line one day would be if the 
page - or some images on the page - are still loading. That's a bit more 
work though.)

[0001-Show-readable-status-in-the-EWW-mode-line.patch (text/plain, attachment)]

Message #8 received at 78958 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 78958 <at> debbugs.gnu.org
Subject: Re: bug#78958: 31.0.50;
 [PATCH] Indicate "readable" state in the EWW modeline
Date: Sat, 05 Jul 2025 09:57:52 +0300

> Date: Fri, 4 Jul 2025 16:34:22 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> In EWW, we can show the "readable" form of a page by default, but not 
> all pages really *have* such a form. Sometimes, we just can't figure out 
> what the readable form would be, so we show the whole page.
> 
> To help make this clearer for users, we could change the logic slightly 
> so that when there's no readable form, we don't set the :readable 
> property to t. Then we can consult that property in the mode line so 
> that users are aware of what the current state it. See the attached 
> patch, which includes a simple test for this new behavior.

Thanks, but could we also give users a positive feedback when we are
unable to figure out what's the readable form?  AFAIU, currently we
just silently display the same page.

Message #11 received at 78958 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78958 <at> debbugs.gnu.org
Subject: Re: bug#78958: 31.0.50; [PATCH] Indicate "readable" state in the EWW
 modeline
Date: Sat, 5 Jul 2025 10:48:01 -0700

On 7/4/2025 11:57 PM, Eli Zaretskii wrote:
> Thanks, but could we also give users a positive feedback when we are
> unable to figure out what's the readable form?  AFAIU, currently we
> just silently display the same page.

I added some feedback for when users manually turn on readable mode 
(with "R"). If we can't figure out the readable form, it now emits the 
message "Unable to generate readable document". (I'm open to other ways 
to word that.)

I didn't add a message for the case where EWW automatically enables 
readable mode when first loading a page (using 'eww-readable-urls') 
since I thought that would be annoying, especially for users who set 
'eww-readable-urls' to match *any* page. I don't have terribly strong 
views about that though, so if you prefer a message in that case too, I 
could add it.

Message #14 received at 78958 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 78958 <at> debbugs.gnu.org
Subject: Re: bug#78958: 31.0.50; [PATCH] Indicate "readable" state in the EWW
 modeline
Date: Sun, 06 Jul 2025 07:36:03 +0300

> Date: Sat, 5 Jul 2025 10:48:01 -0700
> Cc: 78958 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> On 7/4/2025 11:57 PM, Eli Zaretskii wrote:
> > Thanks, but could we also give users a positive feedback when we are
> > unable to figure out what's the readable form?  AFAIU, currently we
> > just silently display the same page.
> 
> I added some feedback for when users manually turn on readable mode 
> (with "R"). If we can't figure out the readable form, it now emits the 
> message "Unable to generate readable document". (I'm open to other ways 
> to word that.)

"Unable to find readable content" is more accurate, IMO.

> I didn't add a message for the case where EWW automatically enables 
> readable mode when first loading a page (using 'eww-readable-urls') 
> since I thought that would be annoying, especially for users who set 
> 'eww-readable-urls' to match *any* page. I don't have terribly strong 
> views about that though, so if you prefer a message in that case too, I 
> could add it.

If readable page is generated automatically, not per explicit user
command, there's no need for a message.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.