GNU logs - #79036, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79036: [PATCH] Fix pdb tracking for remote filenames
Resent-From: Liu Hui <liuhui1610@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 17 Jul 2025 04:59:01 +0000
Resent-Message-ID: <handler.79036.B.175272829221252 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79036 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Liu Hui <liuhui1610@HIDDEN>
Date: Thu, 17 Jul 2025 12:57:45 +0800
Message-ID: <CAOQTW-PG9jtZfQpQ3dPeMfksewV7UxX-M0R+M6gg20RXSDPRFw@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000005145f6063a18dab5"
Received-SPF: pass client-ip=2a00:1450:4864:20::42a;
 envelope-from=liuhui1610@HIDDEN; helo=mail-wr1-x42a.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hello, The recipe: 1. emacs -Q 2. Create a remote python file
 and start the remote python shell, e.g. M-x find-file /ssh:server:/tmp/test.py
 M-x run-python 3. Insert the following code in test.py and press C-c C-c
 to se [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (liuhui1610[at]gmail.com)
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (liuhui1610[at]gmail.com)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

--0000000000005145f6063a18dab5
Content-Type: text/plain; charset="UTF-8"

Hello,

The recipe:

1. emacs -Q
2. Create a remote python file and start the remote python shell, e.g.
   M-x find-file /ssh:server:/tmp/test.py
   M-x run-python
3. Insert the following code in test.py and press C-c C-c to send it
   to the python shell:

   def f():
       breakpoint()
       return 1

4. Execute f() in the python shell to trigger the pdb

Result: Emacs tries to open /ssh:server:/ssh:server:/tmp/test.py
instead of /ssh:server:/tmp/test.py.

The reason is the filename set by python-shell-send-string may be
remote. The attached patch fixes the issue.

--
Liu Hui

--0000000000005145f6063a18dab5
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Fix-pdb-tracking-for-remote-filenames.patch"
Content-Disposition: attachment; 
	filename="0001-Fix-pdb-tracking-for-remote-filenames.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_md6x36ew0>
X-Attachment-Id: f_md6x36ew0

RnJvbSBiOTc3MGNlYTIwMTg2ZDAyMDUzMTllZmI1NDMyNzA5OTg0OWUzYTIxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog
VGh1LCAxNyBKdWwgMjAyNSAxMjo0MzozNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBwZGIg
dHJhY2tpbmcgZm9yIHJlbW90ZSBmaWxlbmFtZXMKCiogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVs
IChweXRob24tcGRidHJhY2stc2V0LXRyYWNrZWQtYnVmZmVyKToKQ2hlY2sgcmVtb3RlIGZpbGUg
bmFtZXMuCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgNiArKysrLS0KIDEgZmlsZSBj
aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz
cC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCmluZGV4IGY0
ZjA1MThkYmZkLi41OTk3N2ZjYjQ5ZiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9u
LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbApAQCAtNTA3OSw4ICs1MDc5LDEwIEBA
IHB5dGhvbi1wZGJ0cmFjay1zZXQtdHJhY2tlZC1idWZmZXIKICAgIlNldCB0aGUgYnVmZmVyIGZv
ciBGSUxFLU5BTUUgYXMgdGhlIHRyYWNrZWQgYnVmZmVyLgogSW50ZXJuYWxseSBpdCB1c2VzIHRo
ZSBgcHl0aG9uLXBkYnRyYWNrLXRyYWNrZWQtYnVmZmVyJyB2YXJpYWJsZS4KIFJldHVybnMgdGhl
IHRyYWNrZWQgYnVmZmVyLiIKLSAgKGxldCogKChmaWxlLW5hbWUtcHJvc3BlY3QgKGNvbmNhdCAo
ZmlsZS1yZW1vdGUtcCBkZWZhdWx0LWRpcmVjdG9yeSkKLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGZpbGUtbmFtZSkpCisgIChsZXQqICgoZmlsZS1uYW1lLXByb3NwZWN0IChpZiAoZmls
ZS1yZW1vdGUtcCBmaWxlLW5hbWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBm
aWxlLW5hbWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29uY2F0IChmaWxlLXJl
bW90ZS1wIGRlZmF1bHQtZGlyZWN0b3J5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZmlsZS1uYW1lKSkpCiAgICAgICAgICAoZmlsZS1idWZmZXIgKGdldC1maWxlLWJ1
ZmZlciBmaWxlLW5hbWUtcHJvc3BlY3QpKSkKICAgICAodW5sZXNzIGZpbGUtYnVmZmVyCiAgICAg
ICAoY29uZAotLSAKMi4yNS4xCgo=
--0000000000005145f6063a18dab5--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Liu Hui <liuhui1610@HIDDEN>
Subject: bug#79036: Acknowledgement ([PATCH] Fix pdb tracking for remote
 filenames)
Message-ID: <handler.79036.B.175272829221252.ack <at> debbugs.gnu.org>
References: <CAOQTW-PG9jtZfQpQ3dPeMfksewV7UxX-M0R+M6gg20RXSDPRFw@HIDDEN>
X-Gnu-PR-Message: ack 79036
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 79036 <at> debbugs.gnu.org
Date: Thu, 17 Jul 2025 04:59:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79036 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79036: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79036
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79036: [PATCH] Fix pdb tracking for remote filenames
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 17 Jul 2025 06:43:02 +0000
Resent-Message-ID: <handler.79036.B79036.175273453213983 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Liu Hui <liuhui1610@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>
Cc: 79036 <at> debbugs.gnu.org
Date: Thu, 17 Jul 2025 09:41:44 +0300
Message-Id: <86tt3bgvyv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAOQTW-PG9jtZfQpQ3dPeMfksewV7UxX-M0R+M6gg20RXSDPRFw@HIDDEN>
 (message from Liu Hui on Thu, 17 Jul 2025 12:57:45 +0800)
References: <CAOQTW-PG9jtZfQpQ3dPeMfksewV7UxX-M0R+M6gg20RXSDPRFw@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Thu, 17 Jul 2025 12:57:45 +0800
> 
> 1. emacs -Q
> 2. Create a remote python file and start the remote python shell, e.g.
>    M-x find-file /ssh:server:/tmp/test.py
>    M-x run-python
> 3. Insert the following code in test.py and press C-c C-c to send it
>    to the python shell:
> 
>    def f():
>        breakpoint()
>        return 1
> 
> 4. Execute f() in the python shell to trigger the pdb
> 
> Result: Emacs tries to open /ssh:server:/ssh:server:/tmp/test.py
> instead of /ssh:server:/tmp/test.py.
> 
> The reason is the filename set by python-shell-send-string may be
> remote. The attached patch fixes the issue.
> 
> From b9770cea20186d0205319efb54327099849e3a21 Mon Sep 17 00:00:00 2001
> From: Liu Hui <liuhui1610@HIDDEN>
> Date: Thu, 17 Jul 2025 12:43:34 +0800
> Subject: [PATCH] Fix pdb tracking for remote filenames
> 
> * lisp/progmodes/python.el (python-pdbtrack-set-tracked-buffer):
> Check remote file names.
> ---
>  lisp/progmodes/python.el | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> index f4f0518dbfd..59977fcb49f 100644
> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -5079,8 +5079,10 @@ python-pdbtrack-set-tracked-buffer
>    "Set the buffer for FILE-NAME as the tracked buffer.
>  Internally it uses the `python-pdbtrack-tracked-buffer' variable.
>  Returns the tracked buffer."
> -  (let* ((file-name-prospect (concat (file-remote-p default-directory)
> -                              file-name))
> +  (let* ((file-name-prospect (if (file-remote-p file-name)
> +                                 file-name
> +                               (concat (file-remote-p default-directory)
> +                                       file-name)))
>           (file-buffer (get-file-buffer file-name-prospect)))
>      (unless file-buffer
>        (cond

Shouldn't this code use 'expand-file-name' instead?  Using 'concat' to
construct file names is a bug waiting to happen, IME.

Michael, WDYT?

Last modified: Thu, 17 Jul 2025 06:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.