GNU bug report logs - #79041
[PATCH] ; * test/lisp/net/shr-tests.el (shr-test/zoom-image): Fix test.

Previous Next

To reply to this bug, email your comments to 79041 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * test/lisp/net/shr-tests.el (shr-test/zoom-image): Fix
 test.
Date: Thu, 17 Jul 2025 15:46:13 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

Maybe it's just me but without this patch this shr test fails because it
produces a non-parsable dom content.



In GNU Emacs 31.0.50 (build 2, x86_64-unknown-openbsd7.7) of 2025-07-17
 built on computer
Repository revision: ae560ae11c1d4b1ae5e130f3a942364dcaf69b62
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101018
System Description: OpenBSD computer 7.7 GENERIC.MP#52 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no
 --with-toolkit-scroll-bars=no --without-cairo --without-dbus
 --without-gconf --without-gsettings --without-compress-install'

[0001-test-lisp-net-shr-tests.el-shr-test-zoom-image-Fix-t.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 79041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: larsi <at> gnus.org, 79041 <at> debbugs.gnu.org
Subject: Re: bug#79041: [PATCH] ;
 * test/lisp/net/shr-tests.el (shr-test/zoom-image): Fix test.
Date: Thu, 17 Jul 2025 19:37:14 +0300

> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Thu, 17 Jul 2025 15:46:13 +0200
> 
> Maybe it's just me but without this patch this shr test fails because it
> produces a non-parsable dom content.

Thanks.  I didn't get any errors, but the code is clearly wrong.

> --- a/test/lisp/net/shr-tests.el
> +++ b/test/lisp/net/shr-tests.el
> @@ -146,7 +146,7 @@ shr-test/zoom-image
>        (with-temp-buffer
>          (ert-info ((format "image with alt=%S" alt))
>            (let ((attrs (if alt (format " alt=\"%s\"" alt) "")))
> -            (insert (format "<img src=\"%s\" %s" image-url attrs)))
> +            (insert (format "<img src=\"%s\" %s>" image-url attrs)))
>            (cl-letf* (;; Pretend we're a graphical display.
>                       ((symbol-function 'display-graphic-p) #'always)
>                       ((symbol-function 'url-queue-retrieve)

I've now fixed the test in a slightly different manner (since the
above also had an extra blank), please take a look.

Message #13 received at 79041-done <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, 79041-done <at> debbugs.gnu.org
Subject: Re: bug#79041: [PATCH] ; * test/lisp/net/shr-tests.el
 (shr-test/zoom-image): Fix test.
Date: Thu, 17 Jul 2025 20:45:41 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Date: Thu, 17 Jul 2025 15:46:13 +0200
>> 
>> Maybe it's just me but without this patch this shr test fails because it
>> produces a non-parsable dom content.
>
> Thanks.  I didn't get any errors, but the code is clearly wrong.
>
>> --- a/test/lisp/net/shr-tests.el
>> +++ b/test/lisp/net/shr-tests.el
>> @@ -146,7 +146,7 @@ shr-test/zoom-image
>>        (with-temp-buffer
>>          (ert-info ((format "image with alt=%S" alt))
>>            (let ((attrs (if alt (format " alt=\"%s\"" alt) "")))
>> -            (insert (format "<img src=\"%s\" %s" image-url attrs)))
>> +            (insert (format "<img src=\"%s\" %s>" image-url attrs)))
>>            (cl-letf* (;; Pretend we're a graphical display.
>>                       ((symbol-function 'display-graphic-p) #'always)
>>                       ((symbol-function 'url-queue-retrieve)
>
> I've now fixed the test in a slightly different manner (since the
> above also had an extra blank), please take a look.

I see.  The test passes with your version also.  I'm therefore closing
this bug.
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.