GNU bug report logs - #79046
(WIP) [PATCH] tab-line: Change close button appearance for modified tabs

Previous Next

To reply to this bug, email your comments to 79046 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: (WIP) [PATCH] tab-line: Change close button appearance for modified
 tabs
Date: Fri, 18 Jul 2025 19:21:56 -0600

[Message part 1 (text/plain, inline)]

Tags: patch


When editing multiple buffers the `tab-line-tab-modified` face (which
indicates that a buffer has been modified and not saved) is sometimes
barely visible or hard to distinguish from the tab line.

This patch changes the appearance of the close button icon when the
buffer has been modified, similar to other editors.

The patch is not yet finished, this feature is currently "hardcoded"
(the only way to disable this is removing `tab-line-tab-face-modified`
from `tab-line-tab-face-functions`).

I would like any suggestion, if should this have an option for disable
this.

[0001-tab-line-Add-close-button-for-modified-tabs.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via GNU Emacs and Org.

Message #8 received at 79046 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79046 <at> debbugs.gnu.org
Subject: Re: bug#79046: (WIP) [PATCH] tab-line: Change close button
 appearance for modified tabs
Date: Sun, 20 Jul 2025 09:47:08 +0300

> When editing multiple buffers the `tab-line-tab-modified` face (which
> indicates that a buffer has been modified and not saved) is sometimes
> barely visible or hard to distinguish from the tab line.
>
> This patch changes the appearance of the close button icon when the
> buffer has been modified, similar to other editors.

Thanks, I tried it out, and it looks nice.

> The patch is not yet finished, this feature is currently "hardcoded"
> (the only way to disable this is removing `tab-line-tab-face-modified`
> from `tab-line-tab-face-functions`).
>
> I would like any suggestion, if should this have an option for disable
> this.

There is an option `tab-line-tab-name-format-function`,
but it would be too cumbersome for users to override the
whole `tab-line-tab-name-format-default` to be able to
disable only the close button.

Maybe it would be ok for users to customize the icon with

  M-x customize-icon RET tab-line-close-modified RET

and copy attributes from `tab-line-close-button`.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.