Received: (at 79204) by debbugs.gnu.org; 25 Nov 2025 20:22:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:22:19 2025 Received: from localhost ([127.0.0.1]:41892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vNzYJ-00014m-29 for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:22:19 -0500 Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]:44998) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <rahguzar@HIDDEN>) id 1vN8bp-0000ka-Gt for 79204 <at> debbugs.gnu.org; Sun, 23 Nov 2025 06:50:26 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4dDnM9546xz9ss3; Sun, 23 Nov 2025 12:50:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1763898613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jbuRvV1erckV88breOTd1SebsfbxKticDQxIOXEJhoI=; b=kJw4XeYlo0qy/FLaL+0GW+7ObEpHIcc94cjKEzV0XkRZh3euwZ2cVYYRNVZkdo5Nne2tTY 6wjexW4Y435TJI5v6DlBIH1njtwSHZLQySfaYmW98p2of5zCXqaiK0BmUZ5HkldC5sakQB 6JjMmJ2LvzkJ+2CEdpcmdrPFc7D433SKU96eGn4ANeKPYsFe7GcP/uFIMzigoM16RA5RdX 8MUg4kBy/esDsegN4woix83Sgn1vOdiESiPvGx9MFw9vCbfl2tV+/cplQ8R+5iq24bWilx KsgnRjrrYNmxOoMIkaDdl3ueMg+6u4seXDW8e8Ie8kDt77tro5riCxKk1P5/8A== From: Rahguzar <rahguzar@HIDDEN> To: Steven Allen <steven@HIDDEN> Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() In-Reply-To: <873465tj38.fsf@HIDDEN> (Steven Allen's message of "Sat, 22 Nov 2025 21:26:51 -0800") References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> <87ikft46g5.fsf@HIDDEN> <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me> <86o6oufkgk.fsf@HIDDEN> <873465mt9l.fsf@HIDDEN> <873465tj38.fsf@HIDDEN> Date: Sun, 23 Nov 2025 16:50:01 +0500 Message-ID: <87pl990xzq.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-MBO-RS-ID: 00e07802a28540ec09f X-MBO-RS-META: oqoxjrkcfek6ksmhr5yfeyi91qg4gz48 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79204 Cc: Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org, Patryk Wychowaniec <pwychowaniec@HIDDEN>, emacs-devel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Steven Allen <steven@HIDDEN> writes: > I can't speak for everyone, but I'd be VERY happy to pay a 2x memory > cost to have this issue fixed. This issue affects non-PGTK Cairo builds > as well and has been a frequent source of frustration for me. > > I've attached an additional patch that ports the fix in bug#79204 to > apply to non-PGTK Cairo builds as well. It significantly improves Emacs' > responsiveness when working with large images, this time on X+Cairo > (with no toolkit). > > For some context, I submitted [1] a hack to work around this by reducing > the quality of the image scaling algorithm, but this new patch is MUCH > more effective than my hack and doesn't sacrificing quality. > > Rahguzar (author of the pdf-tools continuous scroll patch, CCed) has > also run into these issues [2]. Slow scrolling in the presence of scaled images is a big problem for `pdf-tools` especially with high density screens. Scrolling gets very slow if a scaled images is being displayed. I have not tested the patch but I think twice the amount of memory usage by cache is a trade off worth making.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 25 Nov 2025 20:22:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:22:10 2025 Received: from localhost ([127.0.0.1]:41849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vNzY9-00011Y-V3 for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:22:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35420) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vN2jA-0005yz-4p for 79204 <at> debbugs.gnu.org; Sun, 23 Nov 2025 00:33:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vN2it-0004ti-UI; Sun, 23 Nov 2025 00:33:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BALwn88rXDLWRqIH3XsC4alUZGP269d66TfBopxh/aU=; b=NJTKpKn5PJZJ ofOgEA9/XBSmsip1Pi2h3fwC5LyPmzawNoXspiyIAu8rtVti+xbe5U3OvDyqAq9O/tPL0VlYcIoIi yi/kfUp621jn+zAzGh3nLktJqwW5VMgRFZpECPolor7Ak6amuAiHbiUAFng3C8wc/PTD7DzAxKwFN LZrdB9titBUejpjfutSnU9CcaCIQcO33LBzcKCAYnJc6Oz5JLZNYn+DnrjeV0r09vgGK3UdA9tyxx dlTsIEa8r77Yd2uXaJPh8XqJKwtsjtYkn13s+vlIBRikgRw9BEvM2kut0rEcn8ZAA/MJpXvJbvdpY j2RYHPYMyZstaldnjTzedw==; Date: Sun, 23 Nov 2025 07:33:07 +0200 Message-Id: <86v7j1e2jw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <873465mt9l.fsf@HIDDEN> (message from Po Lu on Sun, 23 Nov 2025 09:28:54 +0800) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> <87ikft46g5.fsf@HIDDEN> <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me> <86o6oufkgk.fsf@HIDDEN> <873465mt9l.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN, emacs-devel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: Patryk Wychowaniec <pwychowaniec@HIDDEN>, 79204 <at> debbugs.gnu.org, > emacs-devel@HIDDEN > Date: Sun, 23 Nov 2025 09:28:54 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> Date: Tue, 11 Nov 2025 15:06:00 +0000 > >> From: Patryk Wychowaniec <pwychowaniec@HIDDEN> > >> Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org > >> > >> Hi, > >> > >> I've adjusted the code to measure surface sizes like so: > >> > >> ``` > >> diff --git a/src/image.c b/src/image.c > >> index c5caaf739e7..7ace960a69a 100644 > >> --- a/src/image.c > >> +++ b/src/image.c > >> @@ -2472,6 +2484,9 @@ image_size_in_bytes (struct image *img) > >> Emacs_Pixmap msk = img->mask; > >> if (msk) > >> size += msk->height * msk->bytes_per_line; > >> + cairo_surface_t *sfc = img->cr_surface; > >> + if (sfc) > >> + size += cairo_image_surface_get_stride (sfc) * cairo_image_surface_get_height (sfc); > >> > >> #elif defined HAVE_X_WINDOWS || defined HAVE_ANDROID > >> /* Use a nominal depth of 24 and a bpp of 32 for pixmap and 1 bpp > >> ``` > >> > >> Then I went through a directory of 80 photos - of mixed size, between 75 KB [800x450 px] to 20 MB [2225x1537 px] - and obtained the following results of `(image-cache-size)`: > >> > >> Emacs 30.2 (without patch): > >> 356836176 =~ 340 MB > >> > >> Emacs 30.2 (with patch): > >> 704778048 =~ 672 MB > >> > >> In both cases the baseline (start measurement without having explicitly opened any images) is < 1 KB. > > > > Thanks. > > > > Po Lu, how to proceed with this? > > A twofold increase in image memory consumption might not be acceptable > to many users. What do you (and the list) think? 300 MB of extra doesn't sound too bad, if the gains are significant. Two orders of magnitude is quite a lot better.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.
Received: (at 79204) by debbugs.gnu.org; 25 Nov 2025 20:22:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:22:10 2025
Received: from localhost ([127.0.0.1]:41846 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vNzY9-00011J-2f
for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:22:09 -0500
Received: from fhigh-b6-smtp.messagingengine.com ([202.12.124.157]:51551)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vN2co-0005Yg-3j
for 79204 <at> debbugs.gnu.org; Sun, 23 Nov 2025 00:27:04 -0500
Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44])
by mailfhigh.stl.internal (Postfix) with ESMTP id 9B65D7A01BC;
Sun, 23 Nov 2025 00:26:54 -0500 (EST)
Received: from phl-mailfrontend-02 ([10.202.2.163])
by phl-compute-04.internal (MEProxy); Sun, 23 Nov 2025 00:26:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:cc:content-type:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:subject:subject:to:to; s=fm2; t=1763875614; x=
1763962014; bh=+qsZtNrfJ0AOliaAiwKM5vrnVj1W7Ep6SCCHST7+R1E=; b=A
aSQcPYm6Y2rol76FHLQGzb5BNvb7BTt9bheRMIiH9FJu/0Yb6eyoYGWfPhoQBYJj
ZgS1ZrUSDgJWW+Qb7YQs1K0Dd1bub5j8HKnNVPFWNNdzF1wAcqhVnQpkgkbWNoh6
gRmQPj9UB3lpHKIUZQUHDOropdQ+mULQ0vxIgtJYQeuPly6cwGDU7Yb4YknB/JnY
1V73Sisw3qn0ULYdns8aucuPhT5ypHG0kgH940R3VMgA5er2IWi/zhy4ufYzn2wG
frqwgIrA/0H3oDbjRF3SkN6NmeRANkLfSkYYXZ92A8FqskCcIjYgnkyVU/TQvDKi
CzbegUAw1DoP/rOxrC+Rw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1763875614; x=1763962014; bh=+qsZtNrfJ0AOliaAiwKM5vrnVj1W7Ep6SCC
HST7+R1E=; b=VsWpcZcRIRCHTgsqNlPoGyj3escUAlDLITDvLh0Z4H2Ia6qTPjT
vUGJh/JhcGe1qPxM0LKbJ5KJ7O1xsjaOOZboLmnk5+qpgZLEHpBoRWfN27mz69Hk
K16/SzGJTaF7tJNZzkDisusvFdKONwlN0AHVjxqrCUqiuVI/bW5lRtQSchkwnCpy
vuukXI85gDJYycgcy1l8JzSnp00VuPQa/Hz+B908nUI+ojbq70JmytQxomBoa7BK
m4yVLgHkg3fOkfSNqwq1wJixNccfV7s7/3JUeA/mu/jeNQOa3ttPEIBJnF9BpBXh
PHbEJCZ8KPa9Rd+q84JJZQHUQFJS+BSrTJQ==
X-ME-Sender: <xms:HZsiaeGfDKQu2q29MjU0d-HI4e2ZkNOCv0EqOpAjS48nhFVdrOhO0w>
<xme:HZsiaTB64anUfqdS7ckU8Ep6EX9drouzZDcClJb6OmCZ_ug7Q2KCGIYN2eo8fM4Vk
6uEgfITwWLn89VfOjTAxDgUR4hRnNjmsvoXWuF4yHauJ_nrqz84ei0y>
X-ME-Received: <xmr:HZsiaR-By3X7hYprHWNhpckS2PrPy3aa5x2yNPbVhXXoFjDQ3CWPLKuz>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvfeegkeekucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurhephffvvefujghffffkgggtsehmtderredttddtnecuhfhrohhmpefuthgvvhgvnhcu
tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth
htvghrnhepieetvdfhffeuhfdtuedtgeefgeeiieetveevgfeufeeivedvheefjefffffg
veejnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc
frrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhm
pdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehluh
grnhhgrhhuoheshigrhhhoohdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhr
ghdprhgtphhtthhopehpfiihtghhohifrghnihgvtgesphhmrdhmvgdprhgtphhtthhope
ejledvtdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghmrggtshdq
uggvvhgvlhesghhnuhdrohhrghdprhgtphhtthhopehrrghhghhuiigrrhesmhgrihhlsg
hogidrohhrgh
X-ME-Proxy: <xmx:HZsiafBDKcxRl9uGKXz640JLJcy6QOKxZ2dBiPGXpLZNTD5A5GvtjQ>
<xmx:HZsiaWRcUSiUJL9wmkGeyhu2c5lG2Y6CKUCWPzZpxs4Sf0Ty9BcXhQ>
<xmx:HZsiaWtNBreWWb_VtHXjpM5pQfGNQJvAlm1gQZVqDM1SHLp1c0-oyA>
<xmx:HZsiaS2P6c3YiPfCTnujONmxor559rNFLFTihV2JazGdL7izkYVBSw>
<xmx:HpsiaSpuUS9WhlR1mIzXNf90MZjqZTU8mDkSGTBqc3PAHMoyzguHaV24>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
23 Nov 2025 00:26:53 -0500 (EST)
From: Steven Allen <steven@HIDDEN>
To: Po Lu <luangruo@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface()
In-Reply-To: <873465mt9l.fsf@HIDDEN>
References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me>
<86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN>
<mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me>
<87ikft46g5.fsf@HIDDEN>
<OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me>
<86o6oufkgk.fsf@HIDDEN> <873465mt9l.fsf@HIDDEN>
Date: Sat, 22 Nov 2025 21:26:51 -0800
Message-ID: <873465tj38.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79204
Cc: Rahguzar <rahguzar@HIDDEN>, 79204 <at> debbugs.gnu.org,
Patryk Wychowaniec <pwychowaniec@HIDDEN>, emacs-devel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
Po Lu <luangruo@HIDDEN> writes:
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>>> Date: Tue, 11 Nov 2025 15:06:00 +0000
>>> From: Patryk Wychowaniec <pwychowaniec@HIDDEN>
>>> Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org
>>>
>>> Hi,
>>>
>>> I've adjusted the code to measure surface sizes like so:
>>>
>>> ```
>>> diff --git a/src/image.c b/src/image.c
>>> index c5caaf739e7..7ace960a69a 100644
>>> --- a/src/image.c
>>> +++ b/src/image.c
>>> @@ -2472,6 +2484,9 @@ image_size_in_bytes (struct image *img)
>>> Emacs_Pixmap msk = img->mask;
>>> if (msk)
>>> size += msk->height * msk->bytes_per_line;
>>> + cairo_surface_t *sfc = img->cr_surface;
>>> + if (sfc)
>>> + size += cairo_image_surface_get_stride (sfc) * cairo_image_surface_get_height (sfc);
>>>
>>> #elif defined HAVE_X_WINDOWS || defined HAVE_ANDROID
>>> /* Use a nominal depth of 24 and a bpp of 32 for pixmap and 1 bpp
>>> ```
>>>
>>> Then I went through a directory of 80 photos - of mixed size, between 75 KB [800x450 px] to 20 MB [2225x1537 px] - and obtained the following results of `(image-cache-size)`:
>>>
>>> Emacs 30.2 (without patch):
>>> 356836176 =~ 340 MB
>>>
>>> Emacs 30.2 (with patch):
>>> 704778048 =~ 672 MB
>>>
>>> In both cases the baseline (start measurement without having explicitly opened any images) is < 1 KB.
>>
>> Thanks.
>>
>> Po Lu, how to proceed with this?
>
> A twofold increase in image memory consumption might not be acceptable
> to many users. What do you (and the list) think?
I can't speak for everyone, but I'd be VERY happy to pay a 2x memory
cost to have this issue fixed. This issue affects non-PGTK Cairo builds
as well and has been a frequent source of frustration for me.
I've attached an additional patch that ports the fix in bug#79204 to
apply to non-PGTK Cairo builds as well. It significantly improves Emacs'
responsiveness when working with large images, this time on X+Cairo
(with no toolkit).
For some context, I submitted [1] a hack to work around this by reducing
the quality of the image scaling algorithm, but this new patch is MUCH
more effective than my hack and doesn't sacrificing quality.
Rahguzar (author of the pdf-tools continuous scroll patch, CCed) has
also run into these issues [2].
[1] https://lists.gnu.org/r/emacs-devel/2025-07/msg00475.html
[2] https://mail.gnu.org/archive/html/emacs-devel/2025-10/msg00630.html
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-x-Use-cairo_set_source_surface-as-well.patch
From 638781283e15edfedd65aea073dc0e96f9286918 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@HIDDEN>
Date: Sat, 22 Nov 2025 20:43:58 -0800
Subject: [PATCH 2/2] x: Use cairo_set_source_surface() as well
This ports the PGTK changes from the previous patch to X/Cairo builds.
* src/xterm.c (x_cr_draw_image): Use cairo_set_source_surface.
(x_draw_fringe_bitmap): Pass no surface to x_cr_draw_image.
(x_draw_image_foreground): Pass a pointer to the surface to x_cr_image.
---
src/xterm.c | 43 ++++++++++++++++++++++++++++++++++++-------
1 file changed, 36 insertions(+), 7 deletions(-)
diff --git a/src/xterm.c b/src/xterm.c
index e47a836713a..7f92f2bb889 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -6287,8 +6287,8 @@ x_cr_destroy_fringe_bitmap (int which)
static void
x_cr_draw_image (struct frame *f, GC gc, cairo_pattern_t *image,
- int src_x, int src_y, int width, int height,
- int dest_x, int dest_y, bool overlay_p)
+ cairo_surface_t **surface, int src_x, int src_y, int width,
+ int height, int dest_x, int dest_y, bool overlay_p)
{
cairo_t *cr = x_begin_cr_clip (f, gc);
@@ -6303,12 +6303,40 @@ x_cr_draw_image (struct frame *f, GC gc, cairo_pattern_t *image,
cairo_translate (cr, dest_x - src_x, dest_y - src_y);
- cairo_surface_t *surface;
- cairo_pattern_get_surface (image, &surface);
- cairo_format_t format = cairo_image_surface_get_format (surface);
+ cairo_surface_t *image_surface;
+ cairo_pattern_get_surface (image, &image_surface);
+ cairo_format_t format = cairo_image_surface_get_format (image_surface);
+
if (format != CAIRO_FORMAT_A8 && format != CAIRO_FORMAT_A1)
{
- cairo_set_source (cr, image);
+ /* Since drawing surfaces is much faster than drawing patterns,
+ let's try to convert this image into a surface and cache it. */
+ if (surface)
+ {
+ if (!*surface)
+ {
+ int image_width = cairo_image_surface_get_width (image_surface);
+ int image_height = cairo_image_surface_get_height (image_surface);
+
+ *surface = cairo_surface_create_similar_image (image_surface,
+ format,
+ image_width,
+ image_height);
+
+ cairo_t *cr2 = cairo_create (*surface);
+
+ cairo_set_source (cr2, image);
+ cairo_paint (cr2);
+ cairo_destroy (cr2);
+ }
+
+ cairo_set_source_surface (cr, *surface, 0, 0);
+ }
+ else
+ {
+ cairo_set_source (cr, image);
+ }
+
cairo_fill (cr);
}
else
@@ -7910,7 +7938,7 @@ x_draw_fringe_bitmap (struct window *w, struct glyph_row *row,
daemon Emacs. Create the missing pattern now. */
gui_define_fringe_bitmap (f, p->which);
}
- x_cr_draw_image (f, gc, fringe_bmp[p->which], 0, p->dh,
+ x_cr_draw_image (f, gc, fringe_bmp[p->which], NULL, 0, p->dh,
p->wd, p->h, p->x, p->y, p->overlay_p);
XSetForeground (display, gc, gcv.foreground);
XSetBackground (display, gc, gcv.background);
@@ -10181,6 +10209,7 @@ x_draw_image_foreground (struct glyph_string *s)
{
x_set_glyph_string_clipping (s);
x_cr_draw_image (s->f, s->gc, s->img->cr_data,
+ (cairo_surface_t **) &s->img->cr_surface,
s->slice.x, s->slice.y, s->slice.width, s->slice.height,
x, y, true);
if (!s->img->mask)
--
2.52.0
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 25 Nov 2025 20:22:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:22:04 2025 Received: from localhost ([127.0.0.1]:41825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vNzY3-0000zV-5P for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:22:04 -0500 Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]:46046) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1vMyuc-0006YC-I4 for 79204 <at> debbugs.gnu.org; Sat, 22 Nov 2025 20:29:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763861342; bh=HxPm4iQPpuGaH5iVYfW6BsI7EWjLYBiaTAapz+gTdck=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Wi+HLe/62G/CNC7KrPdrMiJkBlaEWb65yo6TGfKs14vl3JRwlZpM4L/6WAr/ala6GtcZ3rQc581SX800+AnCO5ag1krRcw4XXmjY4rjHHh8txAjFN9gixSKPtIpP9qxBA3ytxh3d4vNDjB2QSMAS3QpSE8K95q+mcX1OvQTBCJI6c440SxwEw/68QcDpm35Tay5tSppaKO+1nYBPnjBfgPg8Ztj+H6tICG3cYq3H43Ex7qWlUiV7fAp4OxlPd36ojfh7sSYU+gCg3xVOf4vyghy3LhFh5ehvcrrp7aOcPUiQWK22Ma8DpO8gLLvQ4EtZxDBSmjQxNrn4CbYp0kZU/w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763861342; bh=DRqjPS6QNmCbee9K0IsdS/5ZmJU69KmsoAu5nt0KbF3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dHoqFRm9a3k0jYu/qqIT8Pi6Yr7ikbVJ0FIstCZ2a09caGMVkWsgnd3a6+l9YY8YPn5ivTAsVO83YMpevwepLDEVdBLlEkGVqawIAp/vtoehPTZwprc+Wf0gX6RfOebj1i5a1kYNz3REGadGklgtWJlWsqiewpiZR/gpb1gmITzEGw2Tve56kQ9B2SmLOI1PfBhVVOZ349iChc2glmHPAzO0kU4mlpHZ3PR+cV7wD7ADfKLVRBfRvdXG8yVihDYNASSPF26Hv+zdO/l0dH40bIe3RUf6w6XhgwN2AyVVDLatOCGgc3d3PzMqRUM92qV7hVwvl4U9++hOSbpCMwk+FA== X-YMail-OSG: FC1Dst8VM1kt5Du1j8w.S95NmNa4vxyca7CRLI9jLU1vQPQmk0gfHzFRWo2Deft cG60q9nmii7gMq7sjkg5Vl0Nb_7iN7oFN2o3ChSaTlaH1IEW9qvjA7tLypaC3oodHImgkLqqDGsd Rb.NWc2TONYUnQSYmGmpYGBCGEo757ilb3_mH9puqnkeSJcsp6ii1o6YoIWffKv2DNBDVCrP7EFk Q6nuNDigLFSgK2Xtk7Ax55rwaYrdPlS_XdT8PX33xRfYaWrIkE6LlbDjEAUdcmpje4Qbg8zQChNf Ph64klm0fkFJmOslbLlUi94BeAG1CIpAUhjIadS3OqrJxg7bhLK4HWlAACdBWR4Kc3xJBBPA6rUs ehHlkl_p4RcZob1r.4eYvDXLL8sFBJ5YjrbWLJTuUN_jLYfutHedFuwJUxBEE2L.Vdar9WE98dsR nR56Uz1WFc4_9UWWcM_Eex7zbY3yeaAMeFIxJU0BnzHJA1zpm6Ir4q67uZah5x_koCJl6ngI8eXd 5drMhtkLSBrlJJqEoKWEO0779eGOBTbW8e8F3a1RtDfG3y3NrS.uNnqiFvAAr5Yk8vhz60DjvNmo WVRz78R2L7GC8pgq3QHE2y.4wdvqsqTRa1tiiaICrEBHXIaauIdijaNepTjjWfScC5HkxUkBYWZw SYjiEI6Hbw.r2HA4iCfz.pMBb.L8QnzWM4JtlmWAJ5ivbpV8iP6wYjYEXr08oCZgIFtbGJ.LYomK W8bMk.qvCdv8SCsb1W8tCUggEaI.M95xWP9hcqd.WsOwsPu4Qx81So90A_nWuDfD0kjUwxSO0G7S KOKIQlNz0SJH8iGRyobVR7Fl1Pq8GVyf4N3BOXsXxg2yyrf1pj6KhC0iwjoMnGqXvhDQutAmeCXz xeFVe3_2I3B.TC2JNFIZeaJikAAbR_lo_wOi6BZi3X_8zB6pu8C9MxRs8hqif2MT3hwRvJNID5Yi 9jbu1gHUegm8YLuPQEztUWnHTnA11VnROQ.xORi3h8s3i5P3T0gyMQd_jKlSrAQ7pvsHRYdiG_hd fx7W06AlIPwYJaXKRUeatmRyj8FekWZBG6W.IS0TXhhzr9n0LO7pg1ApCpfzHBiG7M9EXownPJqY GXu3TNHKgQaF.B8ArnSEXFhpdspcokpOCiVmx1qNUIdABZ2RA3WBAqS22K7ksOFfBy5uTOfUg1qE seVoZl2JLOMFYGMpiu1FUdcJIFjG_dIDuCLdZETmxxBCQXINKAkXaFI2Y3nWyr.yjxMbPsjLfqmt J5tVVJ9U5LEUdx2cyJ6JzNW2dMyo1V6yj3RPaxsqEmNIJfRTIBvRIrdhliXsR33NOyWvFq4kQL3i O9_krXERRWQ.Yb7PnjxmFU5G4HRuCQHI20pAC7UjZxp7DyMVSfY4O6s6jotIB7PSEmO8up_D94kO w7wkh_JODivOiTMI.LHcUzKFkcyAOvQ1eWqKTn50reVR9xGjE7UZJjTiqHGugPqig8dJSXwfqB42 HYmM_UhHRoX6IaTh2OLlxpAHTrVlqPI.ZF.fUn5SYkWlGiPmfGBNO4.vGiPGjiPmTSjwmGqjHXcL Ir6QcGM1QAG77k0TWRi_0gVAHqZiU0rOWkynXlA8WS48W4YbEu2dbVa.980O9Gg98djHnngva2BJ ZScsUxg5JwpzhrNL5zms4xll38QUw8HiIBU0li71S.FUJfZdFL19xOeX61d9_5Z9Eclt0Q8AA7CN KiU35Js_XOuZX0EwNcyE1TedMIlQkPTCGekSyyyEnOnbj1eGsjsW7AQQPVcQcy_u5hzzISdzBex5 fkPvQNjgZ0bNpgsN0m3.bVpBlQDyGQe89FI6bOmyAKaI6QPrg9Aa9QT7mUkIqmPQyTw_K7RQKyhg 0RfA50YxIYMtv9Uhkw0RqQnOx4a54rKCvp_RE80.OZsSlpiwQtbRHWfmj8OisBN_eYoem3AGCvC8 _VUz1VtVpZAvn9RpN.XFJ6pgD4QBuumsx._ChqL5pRW5ws0.FxoILFdAUMnHS33MHyGSwvjlamIx HPa7aH2ktQsSV7ZJqJdo2V7SW14YCQYmpg8MwYo_GoOzPlb65mi08Gt4p6SN4qwKd2zGWs016Ybd jWf_z6R9E.ecWz_p6q0pvJShjforScZXymdXGfLuXoZcXJhVLqv_rbbX6a6RnjmdiRR6R0Wv__pB iXJAy4v9xY7Dk_lpt6KfGbbtlS6dfdMDvTONxrpq97r67tJy..zL5IGQLTQC3pYQZhTGkSzCiqm2 IhvhDOHL2gnR2Z3TK55HNE4PhXH_aa5XGTYJfzLymyf7fa0e66WNLWLmJV9pV X-Sonic-MF: <luangruo@HIDDEN> X-Sonic-ID: b1784b4e-7234-44a1-9aee-4934c31ff600 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 23 Nov 2025 01:29:02 +0000 Received: by hermes--production-sg3-7d7fc55cbb-vwmbp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1bdd857f5c8c50aae88d2ed22a820f7d; Sun, 23 Nov 2025 01:28:58 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() In-Reply-To: <86o6oufkgk.fsf@HIDDEN> References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> <87ikft46g5.fsf@HIDDEN> <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me> <86o6oufkgk.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sun, 23 Nov 2025 09:28:54 +0800 Message-ID: <873465mt9l.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.24794 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1435 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, Patryk Wychowaniec <pwychowaniec@HIDDEN>, emacs-devel@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Tue, 11 Nov 2025 15:06:00 +0000 >> From: Patryk Wychowaniec <pwychowaniec@HIDDEN> >> Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org >> >> Hi, >> >> I've adjusted the code to measure surface sizes like so: >> >> ``` >> diff --git a/src/image.c b/src/image.c >> index c5caaf739e7..7ace960a69a 100644 >> --- a/src/image.c >> +++ b/src/image.c >> @@ -2472,6 +2484,9 @@ image_size_in_bytes (struct image *img) >> Emacs_Pixmap msk = img->mask; >> if (msk) >> size += msk->height * msk->bytes_per_line; >> + cairo_surface_t *sfc = img->cr_surface; >> + if (sfc) >> + size += cairo_image_surface_get_stride (sfc) * cairo_image_surface_get_height (sfc); >> >> #elif defined HAVE_X_WINDOWS || defined HAVE_ANDROID >> /* Use a nominal depth of 24 and a bpp of 32 for pixmap and 1 bpp >> ``` >> >> Then I went through a directory of 80 photos - of mixed size, between 75 KB [800x450 px] to 20 MB [2225x1537 px] - and obtained the following results of `(image-cache-size)`: >> >> Emacs 30.2 (without patch): >> 356836176 =~ 340 MB >> >> Emacs 30.2 (with patch): >> 704778048 =~ 672 MB >> >> In both cases the baseline (start measurement without having explicitly opened any images) is < 1 KB. > > Thanks. > > Po Lu, how to proceed with this? A twofold increase in image memory consumption might not be acceptable to many users. What do you (and the list) think?
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 25 Nov 2025 20:19:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 25 15:19:08 2025 Received: from localhost ([127.0.0.1]:41687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vNzVD-0000ZJ-I6 for submit <at> debbugs.gnu.org; Tue, 25 Nov 2025 15:19:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45160) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vMkYF-00030K-B8 for 79204 <at> debbugs.gnu.org; Sat, 22 Nov 2025 05:09:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vMkY1-0001cJ-0X; Sat, 22 Nov 2025 05:08:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0DpYpq9TGI17x31fkRIJtLtV5sZZQWKMckK5OmlgoxM=; b=e+n/WOwguRJ1 QP7zX0SV8D8UGOB5fBlhZNhJdemvxJ7BBwtaTJp9ODyLJDiwTPXBic+Carz0tNy1JgGak2reU0kfy G4PliAzY12+ECKE4dyhxbUnlwGujNoOKTHJZDpB+TITTW46jatF50wFihSsWCMEvgQyUklEGJ9JiI yrd9Ldc7zVf9xJRQi7qNwuB/AdK+brbCbflRpdS+utF7Vm9752H1BYOnHrKeynTfrh/zYD9abvLYI 3bBwMHmCmnl4eGpYHGAzSylXIsACkC/fa5yBWxIcq8dX9Py5TWrSLtgwLT08v2JF3iD9suwdq0vRY VahV875r5YNWyPuItqxndA==; Date: Sat, 22 Nov 2025 12:08:43 +0200 Message-Id: <86o6oufkgk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Patryk Wychowaniec <pwychowaniec@HIDDEN> In-Reply-To: <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me> (message from Patryk Wychowaniec on Tue, 11 Nov 2025 15:06:00 +0000) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> <87ikft46g5.fsf@HIDDEN> <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: luangruo@HIDDEN, 79204 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 11 Nov 2025 15:06:00 +0000 > From: Patryk Wychowaniec <pwychowaniec@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org > > Hi, > > I've adjusted the code to measure surface sizes like so: > > ``` > diff --git a/src/image.c b/src/image.c > index c5caaf739e7..7ace960a69a 100644 > --- a/src/image.c > +++ b/src/image.c > @@ -2472,6 +2484,9 @@ image_size_in_bytes (struct image *img) > Emacs_Pixmap msk = img->mask; > if (msk) > size += msk->height * msk->bytes_per_line; > + cairo_surface_t *sfc = img->cr_surface; > + if (sfc) > + size += cairo_image_surface_get_stride (sfc) * cairo_image_surface_get_height (sfc); > > #elif defined HAVE_X_WINDOWS || defined HAVE_ANDROID > /* Use a nominal depth of 24 and a bpp of 32 for pixmap and 1 bpp > ``` > > Then I went through a directory of 80 photos - of mixed size, between 75 KB [800x450 px] to 20 MB [2225x1537 px] - and obtained the following results of `(image-cache-size)`: > > Emacs 30.2 (without patch): > 356836176 =~ 340 MB > > Emacs 30.2 (with patch): > 704778048 =~ 672 MB > > In both cases the baseline (start measurement without having explicitly opened any images) is < 1 KB. Thanks. Po Lu, how to proceed with this?
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.
Received: (at 79204) by debbugs.gnu.org; 11 Nov 2025 15:06:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 11 10:06:15 2025
Received: from localhost ([127.0.0.1]:44149 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vIpwl-0007mk-7p
for submit <at> debbugs.gnu.org; Tue, 11 Nov 2025 10:06:15 -0500
Received: from mail-10631.protonmail.ch ([79.135.106.31]:20235)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <pwychowaniec@HIDDEN>)
id 1vIpwj-0007mY-2z
for 79204 <at> debbugs.gnu.org; Tue, 11 Nov 2025 10:06:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me;
s=protonmail3; t=1762873566; x=1763132766;
bh=OoDejXUfTpM/LD5ix4ZKXVKl6Gipsm+/FXxWwV/xtCs=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector;
b=Sel2F6ESRFnDFgQmKgvg5jmkhe1rjNM7+TBKnlLuePnEks5dmcvk9BwZU/Gf6Rxyb
/lJoZ0u9CpN6gdQEuKyU35wxfHfOOtnuRTrWD8TV5BRD0SRmbMntMklzgKpz7ewo5x
mxy4iZkFkzVnTL6WA3H+PpK2Q59+s2Ygh5iJqR6TRitXjeorJiSg5YhmMK2mMoPAso
myJdkqYDnql9FgxYDaszcEhfFgjFX56v+IHzRlsC8NOk7C8eEXqs2PdldsJsS1p8RL
XhpCSiUu4s/BiDCv6przBVJG5K3THJJhkC6gJsTJjNWMW4h94O+qXOJr/CExxB/dsj
iuvUxN7/GIJ7A==
Date: Tue, 11 Nov 2025 15:06:00 +0000
To: Po Lu <luangruo@HIDDEN>
From: Patryk Wychowaniec <pwychowaniec@HIDDEN>
Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface()
Message-ID: <OUn77YNOXm70Ent1IjdMZa3PP8WWqcX5yTWCOXHGSLLdadFpQQkRn_aFezvP3UVSVYKqjtgZypHTRdP789kfcZLaqb9aB61Pf-X8sMsq81o=@pm.me>
In-Reply-To: <87ikft46g5.fsf@HIDDEN>
References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me>
<86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN>
<mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me>
<87ikft46g5.fsf@HIDDEN>
Feedback-ID: 27022295:user:proton
X-Pm-Message-ID: 567f3a32e315287a4bd0c6a82e8484fe2815cb97
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79204
Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
I've adjusted the code to measure surface sizes like so:
```
diff --git a/src/image.c b/src/image.c
index c5caaf739e7..7ace960a69a 100644
--- a/src/image.c
+++ b/src/image.c
@@ -2472,6 +2484,9 @@ image_size_in_bytes (struct image *img)
Emacs_Pixmap msk =3D img->mask;
if (msk)
size +=3D msk->height * msk->bytes_per_line;
+ cairo_surface_t *sfc =3D img->cr_surface;
+ if (sfc)
+ size +=3D cairo_image_surface_get_stride (sfc) * cairo_image_surface_g=
et_height (sfc);
=20
#elif defined HAVE_X_WINDOWS || defined HAVE_ANDROID
/* Use a nominal depth of 24 and a bpp of 32 for pixmap and 1 bpp
```
Then I went through a directory of 80 photos - of mixed size, between 75 KB=
[800x450 px] to 20 MB [2225x1537 px] - and obtained the following results =
of `(image-cache-size)`:
Emacs 30.2 (without patch):
356836176 =3D~ 340 MB
Emacs 30.2 (with patch):
704778048 =3D~ 672 MB
In both cases the baseline (start measurement without having explicitly ope=
ned any images) is < 1 KB.
Cheers,
Patryk.
On Sunday, November 2nd, 2025 at 01:35, Po Lu <luangruo@HIDDEN> wrote:
>=20
>=20
> Patryk Wychowaniec pwychowaniec@HIDDEN writes:
>=20
> > Hi,
> >=20
> > What kind of evaluation would be satisfactory?
> >=20
> > I don't think Emacs gathers telemetry data - nor I think it should -
> > which means that I cannot reliably predict memory utilization before
> > and after those changes for a typical user.
> >=20
> > What I can say, though, is that I've been using Emacs with this patch
> > applied since August and it seems to work reliably - I haven't noticed
> > any extra crashes, unusually heavy memory utilization, spurious OOM
> > kills etc.
> >=20
> > Of course, I clearly see the potential problem of "load a million huge
> > images, get Emacs OOM-killed" - I just think it's more of a
> > /potential/ problem, not something I'd expect to happen to people over
> > daily usage.
>=20
>=20
> Measures should first be taken to account for the size of each surface
> in `image_size_in_bytes' in image.c. Afterwards, I suggest navigating thr=
ough a large album with image-mode, which will apply image transforms, and =
contrasting the size of the image cache with` M-:
> (image-cache-size) RET' with its size from an unmodified Emacs.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 2 Nov 2025 06:00:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 02 01:00:25 2025 Received: from localhost ([127.0.0.1]:57272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vFR8a-0003r7-DA for submit <at> debbugs.gnu.org; Sun, 02 Nov 2025 01:00:25 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:61329) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pwychowaniec@HIDDEN>) id 1vFFLz-0008DB-Ry for 79204 <at> debbugs.gnu.org; Sat, 01 Nov 2025 13:25:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1762017920; x=1762277120; bh=4IhCzwzZf/29CSBN3vScyRhrKWrX8OmuyRJmlYIZhzo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=YDdvdPC6rlLqNH7+Idm476szJzhhgws51wijcdQCOGZceUsfMeG2oJAI2LT8YEsa7 tOK+9SkxaIhLswHl17tSWqpH38ye0eDtB8K220bjNiud9zz7xJhU9aucV0/mJNSdJ+ dyM14oiBw8RMwEJMwAySynpftzzUB/nuwgt7xSccCU1dW22HHfB217Bw5HTFMKuUkX pQLMfa2RyWjENKu0SrLb//OOqBqNoeZDg1GyGBCMTggsMN8UAttfg9X0dnt+RuN8IG lVwjFKgWuoyo3u3bc74GqIpEGnCZCE4SMnKPznqWFzSWp3L8ryIs8zLqbIjaF608eg Hj+jGrFU2aggQ== Date: Sat, 01 Nov 2025 17:25:14 +0000 To: Po Lu <luangruo@HIDDEN> From: Patryk Wychowaniec <pwychowaniec@HIDDEN> Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() Message-ID: <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> In-Reply-To: <87v7ju488z.fsf@HIDDEN> References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> Feedback-ID: 27022295:user:proton X-Pm-Message-ID: 5af9436bff9b7565bcde814f4089e05bb62ec34a MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79204 X-Mailman-Approved-At: Sun, 02 Nov 2025 01:00:22 -0500 Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, What kind of evaluation would be satisfactory? I don't think Emacs gathers telemetry data - nor I think it should - which = means that I cannot reliably predict memory utilization before and after th= ose changes for a typical user. What I can say, though, is that I've been using Emacs with this patch appli= ed since August and it seems to work reliably - I haven't noticed any extra= crashes, unusually heavy memory utilization, spurious OOM kills etc. Of course, I clearly see the potential problem of "load a million huge imag= es, get Emacs OOM-killed" - I just think it's more of a /potential/ problem= , not something I'd expect to happen to people over daily usage. Cheers, Patryk. =20 On Saturday, November 1st, 2025 at 06:44, Po Lu <luangruo@HIDDEN> wrote: >=20 >=20 > Eli Zaretskii eliz@HIDDEN writes: >=20 > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > > From: pwychowaniec via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" bug-gnu-emacs@HIDDEN > > >=20 > > > I'm submitting a patch that improves performance of previewing large = images in Emacs; more details in the > > > commit message. > >=20 > > Thanks. Po Lu, could you please review and comment? > >=20 > > In any case, Patryk, to accept changes of this size we will need you > > to sign a copyright assignment agreement. If you agree, I will send > > you the form to fill and the instructions to go with it. >=20 >=20 > I think we should first ask whether the OP has evaluated the > implications of creating a new image surface for each scaled image for > memory utilization, because under high-resolution configurations the > allocations required to retain scaled bitmaps in the image cache are > very liable to exceed users' systems' capabilities, while currently the > bottleneck in rendering these images is not so much copying from the > source pattern itself as scaling the smaller patterns to the dimensions > required by the display with rather inefficient code in cairo. I can't > attest whether or not a solution satisfactory in both respects exists > though, at least without sidestepping cairo.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 2 Nov 2025 00:36:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 01 20:36:02 2025 Received: from localhost ([127.0.0.1]:55330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vFM4f-00046j-L4 for submit <at> debbugs.gnu.org; Sat, 01 Nov 2025 20:36:01 -0400 Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:38385) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1vFM4Z-000468-Nh for 79204 <at> debbugs.gnu.org; Sat, 01 Nov 2025 20:35:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1762043749; bh=Xd7II4EH2o5+wG2r5F9hmkvlu0ICPbKEkaevUYGR91k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Pv/vckBqlLxvcnTsTRT/R0RIvbBgynnjygEFJzsi3+0851Yey2Hm1ePSFUXNmB94k2Fz7q/UzzVKSESEAInZx1Z4olB728TI73mvzmJD1p9vPdVOhZJfVTZFsvviMXyXk+Bk+o/TPTJA+oaxWXL80z7SKAfY5Czewa7yXCnZAH7yHqnsnXO1ShLZCQDW6y4ry6z8h3FMHjYBTDE2go4LPsuxHA0Y84+wo+Lbgj8DOszV5PxHd892EEVCyFnp7uR/KNupr++HnJd+LZFSIUCZ7mkZxvWM1UiNbCJSmQjtrENBbKqTQRvCjLJqY0/6T0WLfb/4fY6COpceKQcGmlYENQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1762043749; bh=eWVvZdJn7urEcM9K4HyPBmDiCKCznff/HsJKbpxq8EA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eprs1BghqdfmEeym04EU0e2AEPfN2bYPaW3dSTq6EjLLkl52vCPQvl8cljMFwzd3H1p0up6eOhbu2iKEY7cqwaK4C2dBuKV+4osQTa1ZGvS+WnAkdxl9/1L7T7sx3qFsi3XUKNPBpHMsEQs3O8qjYs9Ch6qc0V4lx9u8ChEN3ZjVFqQle8X5YS0Xi7uzoCMfVDE6/MMMmdGxI6ErpE/0Mbg0gePVoP1W0T16YkJjx03UZAEhXEIYbv+NWMzDuTFHbK9XpdmpOueA6x/21D5l7xJ8matOIGXhD3FKpfJ2xEGtYPueU+/dz6madcevATl7PpOevnAY+MuqAEcKKykShA== X-YMail-OSG: fb4e8vYVM1lIiQhtR4vi1ox6wSJ9P.EA_rF6mBiAxTQ0zVOtGsz5dHSS_dKoOIw eyiKILKcvFDzC9yP89ioE1ZRE7Ov_htW8FxO2kGhSiiAEFRmlbnVca2oM3MYPRXo5jBohjFcKIkf tCLcApWFcehawwwd1WP6ddC0PKboeeuYkVrfATSz3Qn3yzmlSJ8bWuOTXUyDppvyME_4LcVqC_0E 8ZOS2kEkjKOqnd124bpD9WkT1bYk1cYDWABIfK0tidJI_F3mLHT2biFlXn4bNJV9hsNhDEaR74vs c0OIQ.xm0ECWgpzhQg.CzQ_2dAuca.AckKH9BMRHz3a61X1hYskmRnwbcNcsei0SQICgBet55J0n urD7jcekZ_utSpioDgzsQyDXT.nqGTriInUjEu8_B8VdSi__DoYuUZa7RNZE5y2Opmsl2ZTxDbtP btkOfl2xLFk_MCu1JN7yLt7HtX0iXxKQN.UskrVsA1IFpo71j3iZ9D4sovseADGsZgK2fyXxLBxW iLZAUtziVuYXCo97xMutSYN0pBHlCoPUqVRHPUAAkuTXc30avZzGfW_S_Y5PhyMNcJlIu3YZOziq _uRnWWDOG9Y_tuzSumY0x7avGrohvP.sE7we971qiimkx.2Zw7khmDJhVdx8kP0FisKp1tf.DYwW h0rJK.ihsBpQUJSbzr441hEk17PusvUyXdFhzkUkog1jd5mTsUqAqcZ2o7d6MlytNeJvP7kfYKMd _bFicSpw4UvFTbMDX6dE7jXSV45haHhA195JdzuxqM8DyJDsp.4lYIKBUYi6qErT4ecGu1uxdYkL rb.5WEKH0R.uFkL3IzGTic7eBvqgsRttPCGgZ5xnh6cBiia4_dZENysg28GGbG14u_xdMzj1loD. 1hnGOERIMegUtVMth2V95U2TbcZw_D6ey7.nDPpU87FhxDAM0OIrG8FleuWGkSd9is133OXXtMB5 15_UdQrH9r3DGuO2xSDA4CZuVrKZH3y7Sh5hCD3iZgHAq_gBZVuh5DTFQjkaAAHa47rWxfyL4qRi 19Zwqi4D0arLIP.J0_JhNhbj6OqR1Ou_fEB1uo_dEH9KJSOFEfMKQi8m._i1Gk4D8Qhl4al3nHly 3xENy9JCeWzLaD17gclLgOcTQd9CZqxWLPRcU5v0newLcKHTarXe_mv0Xjlk8JumbGMFoD3ovYS3 zYhjHcan33kXXUi5S7bC8e..wjQcW0_06XYVG37Mlk1Y4C5nCP5hnMKtyEeg8_nQRyiAHXmUrNRJ Dcz30bPFs9DT4bNCol53.f2nhYI2UrHqS6ire31ZDvocnVF8kZyMAR3_hxh8yL2ljImfufedSXmq 4bdQmrLDcDGbENEN_dQ.vJk.4setx5PKet.Mf32f1__oF51kOKZMELHCEu.VZzu.Da16wKuNX5Wo GUTuLadGHt8Dlp2wAEJVj0nnYkchwTt4VEdKc_oHtABYzCETqxS2dH0_6IPL0OpfUUbvxFGc0vPs HosC6n6aZZ25A1DcfloHCPm0r.SG.qXzU1o2OJAPjGSdRoc13X.LmnLnwU9_qS_2W1zsdBaTwD1x G6qyCWXUrwxVGQuRMGdJ6A.A_iRmT4esJqKrcqxg_h349rrgyDhAm0AaSd.h.uyIPzfFvObkHaZy 8UGkvd1W91UWrGcek.zk46_IW87q0qiu9f3EcM98sWx08mE1bMk6kBC673Mj8PQweiLAIsnsC3Nv AzkrtfHvZLWWV8TiOrf11SiaAtuUWCa3TWba22jwfuPnf_HS9iHptPc3XUXasOXxni6TlcIfKS7t X3FIfzzPGJQ5yJEF9z.Pk2sZ85kPpm1b8STK01UeVv0b83e6xZYFDkKaI4z8cdjh.d5DQKxCZ6XO d4VfNLDV.AohciXHKYhZd3Otb1tAQE1gX7bu9AJse3lyiwzI8x86iQMhtaiZv9rvzv5hQ1tVBVw8 vwLhMP59Hu8plvaq1M1VViCgCTzHDb508fu.Yi0Rf_w9YcUoyE_wnRJZaQ4E2uZINez0inyhzwzN wCwWfavKHNnqQAzfJUDEuk_CR7oTykTMqyS3bHuppu_g6eCq5svAj4j36iuD330yM7AOJrz_ekz2 _gF8yXSQW1t96FBlcIaFC3wwnVstRjsvZ8jjsWALhYlxi3jHGHvkOmoENYfYTjoEw0xMck0ji4SY tdfoi9kqIuJU7Nd4oIr8Ssf4CWgmyalZPYzRzDG.NCgf6Ly1qFRs7zQXoiNgNcJHQRJ2r_46dGS4 9MgNz6aNNMrhQGORdGiqj2Qvn.f67IHIyvX83yYjYq24BLG65LGIi6fCEedAXSsNx X-Sonic-MF: <luangruo@HIDDEN> X-Sonic-ID: a0c7d2a3-c338-4b51-a366-c1f080cfef8c Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 2 Nov 2025 00:35:49 +0000 Received: by hermes--production-sg3-6d95458c98-dccm9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f923bb82e7be88eba0a54d0d8290b12b; Sun, 02 Nov 2025 00:35:42 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Patryk Wychowaniec <pwychowaniec@HIDDEN> Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() In-Reply-To: <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <87v7ju488z.fsf@HIDDEN> <mXwxWMKvk47s_7Wjp7cnA6IL_tgqwQUcgOfsyHlhRL8_3VC42B5FfggKOYLTT9ybqw5QGYLWSiQ6o9FLBq3jEb6JqwTPZJK16BL2drcMAg4=@pm.me> Date: Sun, 02 Nov 2025 08:35:38 +0800 Message-ID: <87ikft46g5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.24652 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1086 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79204 Cc: Eli Zaretskii <eliz@HIDDEN>, 79204 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Patryk Wychowaniec <pwychowaniec@HIDDEN> writes: > Hi, > > What kind of evaluation would be satisfactory? > > I don't think Emacs gathers telemetry data - nor I think it should - > which means that I cannot reliably predict memory utilization before > and after those changes for a typical user. > > What I can say, though, is that I've been using Emacs with this patch > applied since August and it seems to work reliably - I haven't noticed > any extra crashes, unusually heavy memory utilization, spurious OOM > kills etc. > > Of course, I clearly see the potential problem of "load a million huge > images, get Emacs OOM-killed" - I just think it's more of a > /potential/ problem, not something I'd expect to happen to people over > daily usage. Measures should first be taken to account for the size of each surface in `image_size_in_bytes' in image.c. Afterwards, I suggest navigating through a large album with image-mode, which will apply image transforms, and contrasting the size of the image cache with `M-: (image-cache-size) RET' with its size from an unmodified Emacs.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 1 Nov 2025 05:44:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 01 01:44:50 2025 Received: from localhost ([127.0.0.1]:48477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vF4Py-00042x-2E for submit <at> debbugs.gnu.org; Sat, 01 Nov 2025 01:44:50 -0400 Received: from sonic315-22.consmr.mail.ne1.yahoo.com ([66.163.190.148]:45124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1vF4Pu-00042L-RD for 79204 <at> debbugs.gnu.org; Sat, 01 Nov 2025 01:44:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1761975880; bh=n5n6k/cOgt1VA8jAQ6z+rmzqyFrAFXs1aT6kEttbTw4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=ja+B5njfeAB83VlvdEvL71GVeWNHIZGj1GhMTMakTp7WNquFsDoHGm8Cn0ZtdARPYEJNSwogHgksqinIViI2UExmNWmzC/jOxj7SRkWbS4E7qFxE0e14Bq/dDSM8xryE2tChJxcI8/q198UP+DiaJPC/ytHhvyN7yD8RSb5nKks+Dh/SwKoeW4sqB+3LCcSz7iMiWRyAPTn5LfKLeQn+vHEOr2aVwLvpRSCZkSjOCzsEI6FHZ3hK2dVap7IXENqTgbPySbYU80LLNnElrz4GdKI79BbBSPHedElD2BB7lECDB85sK7UULbc1GVn4G3oIoaDe/qPWokMoLUeChA59Gw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1761975880; bh=0sht1Xfj0Iyo+xLQQYWR+t1od5eMAejPQI8X5wpcyh7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=WEbrNhStIPg82BmQVvcMkcuQMch+l9aDHmbdntg9Nzjzb5XFGRTHVPXbp2Z04C45k8GAzz/6abgLQGtQbrLO8mo8Lo7/yZXX5SATlQhFAC7fpmjKRdEpxNvIRDeHoxaLlaLaS/S24BzjV7alOXmmgE8LWHbE9f1nGe1k3fb7M0a/hLrFpK9bICfbiW+qViEIQg24qCPe4qj+H272KlBHyL0YQf6KSKbID8C7IS3Y8849wml+bddPd5Sdke+b5kBi94/DBjPCyUoQJI034Yj7+Ze5l6vZGDgnUZlb9aib0C1HEOQuqHaIuzNjl4ZEgJ3G7HipPCO0J7Jx+gxKlZEuOw== X-YMail-OSG: q1XfIQsVM1m7kOmTW8N9RwFCJ7ISqT8Qa_.hi8m5HDBJ3wDML.MS.j7P.YjzIzS JgWnxW6epAeMAk3_2btRIBeLu1Mw1zro65M26S4UXHB6R7vWn3BNMBWhl3JEnJwXVcpwwHdaF841 KD713ImM.Wz1TP.FaisZY1ewGjesuoeVWHmNOjSvsI92J6e5YTlhNZeDYvmS7CBhA.NWA0UMACbj LeQOTK2hSG3Y3rmdCWabMNT7iAxQ_COSSJ9DSKCSsehfkVGuA2.7EnHEMaWw3XxBmBfd3J13i4RE bWNb29NxHDzNp.I0MI4jFzoB_L0GSRN7FpN9ae_oxwBhZMpSPNThpK5aHu5bM3uzkvkg4DZQ6RnF ieJpG0pJg6WU8MgRLcbfQcKd0pR98UUtuIP9I86LczJ4g0eRnU_P_SUZPC82dfcWvJGR4DWQyUE. CUpEfBNMWCFR8zoSaASaWDC7sGuKHuyWKvyqMcMfHnjSrgdZ0kdaSFvSQIWbbhQjKOV.5vtxLwbg yPE89_54euyd6yJq_juO45lF.yT_ntff4YxIpanIWHAMgEpgtiRKXTMC4SSTSVEoP9jYkeihzufD bXHOGbdo.ehozpKLkcfTLIdfVkX4lucQESf4F6IxO6fQoU6Nqmal9vrt38.f.s_ESy1B3WNVAD79 HftpSKUCfoVo.NYhkcee8t.dJBBulIbmF3w2ixjUdfW9OyBl_CfOp9CJiCpcU3NSVj34p4Ol1W3U EtoFabpwzc6BSqEa2yUm7IsPIp1vjQUmYBf2Ubr8t0gb2MjXa5m7MbLqK3ixotQdO7TTybS49GCA fCr.8Pn6SFr2GYeOhN.vqqTOSs8pPsvBgJxz4JnRoweEAwfj5F_ffnFHxEfVJnBeGmN8mauUk9e7 VQnRVKp4YHgTsapQulAmRh1hvre8hgrEXu.zg.3r3xKS0v1pE3mLRUwJk0M5ynBfmEwpXeK3tSMO uPBkHZCwWZBWgbrluwcjvsKhZ_eiZDrcVe_wcaHGMXb62knAuNNh1ASLcQkzVCL7IRtqrYsfuqfT 07_7Bka91raRmMIRidItxJNNL5D.EUYQeGc_.GoF91CzJve.QHUV4.JPoR9A9GDjHtXbIE0hLgV3 OBZZ6n4894thwhuSm51MC.nfN7pihFSdaBZD6nf9iSc4lV4_e6Sw_MwoaakxDYY9MO_Pw9IS..Xe S7ONZGXLT7DUNTX1hYZh77HiIxLE9m2f.9x6QTi4qU6pYhmWASfsB_3p_u7mMH7RHgWMBktbUII5 jDvnPvlZM6xJed3NzufpAkcvsP3upAspBodK6MhYhyciL_aZAkl10iGX3T6Varl.RBmrXF8Fk0PM JxMU46n9QCy.wJ_0sws8i2lTylhEkjqyFdGhtWs9TZZeD6HcWT2Sf75IGMBVU3cnnQiOb9T7dmTY H1I9PxRs9aNrv1Ae8TjQtSelDXVNNBqonT2dmaJTiYgV7ONreeG8ScHdUGPBa38gEMvUZeYLcbMh yk2wKuT5SHkxO7fsR3Pvm6aFnjEdY.naCEUDgC9orFLDphtS.Xzdj4SFIB42rpP8UhmmVu_QmqbF h946_eHgin3P67kUoKtEZcWdsxHThEvyfvxkQY3JaECkeK0HwyVtLn4xNPcF7O7qfzyIUBfDr5RQ qTgmSmASJftzVSeQSWARgqFC8ADzGFeN2FZCKs4NSpz0X7yuH4s9ud50RXWqnxPokphB28MRcnhu VwMNqLTVourHDKvSQJLikDWeXVVdP0mXcAf7WutgjetffPVZFQ.xEX6eNAJGO3tAF9QRznsw35bC 0FZgsUPKyjQ7Tl2OtXmz7v_rsqxSEkIlI3CgiyQluVhkWxrFYihImyUIj0GE6Ou9Qfe5Z10lqWSC d66X2QmZVx92AVCA5gDu71IQeHiGy9GnlAgDddBqQKJf6ykb1jTSclyZuhyoy.4CIi3pXMmGiq4F ZBj892PsCRUUpZKduk3TInziWqXVXcAdrYcU7Yh6s_u0_V6UUwDTnRHcFw8jvJTBV1es4lTtHcbs 4iLRMMRNxOS5qUhWLo6QlpeuUpi8AImkmgTJPx2taMamwv_q0afYnapMPd5.o5VxFlUeiaIahVWO AoQjK_1zqQ1NZm8okyzlM_zacB1f84lMjp2BoGHA6d1I13swSL7qChsp9AVEGuBMnZce1VgQxsof bPoZ2UBkDyOtT23a1n.kK11JXktWYolBMR54DfsnxfyvxB1tlQ2ojl7k86knOluSdhro31HgabdO viY3Wp7H.U3stVkmvt6A5XnWRj_eW.Q.WibXZYr9IRyb6gOqdgat4TJNdVGlSxg-- X-Sonic-MF: <luangruo@HIDDEN> X-Sonic-ID: 64134f7e-7af1-4aa6-8c94-1cdf01b00a15 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sat, 1 Nov 2025 05:44:40 +0000 Received: by hermes--production-sg3-6d95458c98-zw6lb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 34e45c75caec42334c031b31bf1a8eaf; Sat, 01 Nov 2025 05:44:33 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() In-Reply-To: <86v7mnk0hx.fsf@HIDDEN> References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> Date: Sat, 01 Nov 2025 13:44:28 +0800 Message-ID: <87v7ju488z.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.24652 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1263 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec <pwychowaniec@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Sat, 09 Aug 2025 12:21:52 +0000 >> From: pwychowaniec via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the >> commit message. > > Thanks. Po Lu, could you please review and comment? > > In any case, Patryk, to accept changes of this size we will need you > to sign a copyright assignment agreement. If you agree, I will send > you the form to fill and the instructions to go with it. I think we should first ask whether the OP has evaluated the implications of creating a new image surface for each scaled image for memory utilization, because under high-resolution configurations the allocations required to retain scaled bitmaps in the image cache are very liable to exceed users' systems' capabilities, while currently the bottleneck in rendering these images is not so much copying from the source pattern itself as scaling the smaller patterns to the dimensions required by the display with rather inefficient code in cairo. I can't attest whether or not a solution satisfactory in both respects exists though, at least without sidestepping cairo.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 25 Oct 2025 10:20:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 25 06:20:04 2025 Received: from localhost ([127.0.0.1]:40106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vCbNT-0002la-UQ for submit <at> debbugs.gnu.org; Sat, 25 Oct 2025 06:20:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54338) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vCbNR-0002kp-0T for 79204 <at> debbugs.gnu.org; Sat, 25 Oct 2025 06:20:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vCbNL-0001ul-Kp; Sat, 25 Oct 2025 06:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=etfoGcyE6rIxP9Ro4OhL7Ftf2NZGfy3MU7Lj7vlGu0k=; b=GYuFoJNfMHuO CEyUu2X9gVc7dJ03pj6zNAwgnB/LnTbR6JPPEY/6H5N4JdP6BBl3nzn4eWreosiX/lfuu8nn5PzKR 98YtLEdPPTHGPBEzhgbonYLjr+cwKzlDgzxIe3cWtj3UFvYjLlgZ6Sfg+szpDHkyXTOCo8XwqCt1V H/k8Vgm7ZtH9oC594BikaeBrLd/GB2kQqsbYiNYGHQ0wH8Swlm7GZkh5afsv4UMnFFaNW5KzmTVv+ ZZ1cl3FoXNMApkvtFk6gwbKxXNFzp/7PH2ibQCM38OAl40jDuK02IZWH/2z5VqUAaFBW2D0iGI8Si 4au3QoIE45zmtZ+U6jGcyA==; Date: Sat, 25 Oct 2025 13:19:51 +0300 Message-Id: <863477s2pk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <86v7kl6dwn.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 11 Oct 2025 11:28:08 +0300) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <86iki5qlw7.fsf@HIDDEN> <86ecsassnf.fsf@HIDDEN> <86seg88ekq.fsf@HIDDEN> <86v7kl6dwn.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Ping! Ping! Ping! Po Lu, are you there? > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > Date: Sat, 11 Oct 2025 11:28:08 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Ping! Ping! Ping! Po Lu, please respond. > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > Date: Sat, 27 Sep 2025 11:49:57 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Ping! Ping! Po Lu, could you please chime in? > > > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > > Date: Sat, 13 Sep 2025 10:44:52 +0300 > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > Ping! Ping! Po Lu, please respond. > > > > > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > > > Date: Sat, 30 Aug 2025 11:00:40 +0300 > > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > > Ping! Po Lu, could you please review the proposed patch? > > > > > > > > > Cc: 79204 <at> debbugs.gnu.org > > > > > Date: Sat, 16 Aug 2025 13:46:18 +0300 > > > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > > > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > > > > > From: pwychowaniec via "Bug reports for GNU Emacs, > > > > > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > > > > > > > > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > > > > > > commit message. > > > > > > > > > > Thanks. Po Lu, could you please review and comment? > > > > > > > > > > In any case, Patryk, to accept changes of this size we will need you > > > > > to sign a copyright assignment agreement. If you agree, I will send > > > > > you the form to fill and the instructions to go with it. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 11 Oct 2025 08:28:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 11 04:28:24 2025 Received: from localhost ([127.0.0.1]:44557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1v7Uxk-0000Yl-FL for submit <at> debbugs.gnu.org; Sat, 11 Oct 2025 04:28:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47408) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1v7Uxf-0000YO-Cs for 79204 <at> debbugs.gnu.org; Sat, 11 Oct 2025 04:28:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1v7UxZ-0000CT-LZ; Sat, 11 Oct 2025 04:28:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4t0QrMTTZqqgVwHgiEaksH13zelWfc3ETkXedHw5pf0=; b=M84ipCQyx0lZ 9N07jes5Ak305G4FkYXaJULASRRRYoSQQVVtAraTEhAZECmSJ9TR+SLteO+pePLt/9IY3aGw5g5dn Io3uGeRUhCRb1ErKHs2HWke7ymT+N5xWdUvIPL+7S57LWn2Qa3m9xhowwF9LZWaYwYH2uTx4+ZKw7 5K19dLAKN4biI3XWV5cyEfk/BVOGrONnM3I26O0OfFui2+j8OTRJ3+REYBo4y9F5pWj+aEsqixVBl DEvB5Vbgn/NeW2re6XzBtQ9Z4fhd3F4tK2yRkIhRQJyZAErM+uMcPsohQIDL8Qe4WI003ABWfYLg9 iQgq0KDGH5ZyarAN38Dt9A==; Date: Sat, 11 Oct 2025 11:28:08 +0300 Message-Id: <86v7kl6dwn.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <86seg88ekq.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 27 Sep 2025 11:49:57 +0300) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <86iki5qlw7.fsf@HIDDEN> <86ecsassnf.fsf@HIDDEN> <86seg88ekq.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Ping! Ping! Po Lu, please respond. > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > Date: Sat, 27 Sep 2025 11:49:57 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Ping! Ping! Po Lu, could you please chime in? > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > Date: Sat, 13 Sep 2025 10:44:52 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Ping! Po Lu, please respond. > > > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > > Date: Sat, 30 Aug 2025 11:00:40 +0300 > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > Ping! Po Lu, could you please review the proposed patch? > > > > > > > Cc: 79204 <at> debbugs.gnu.org > > > > Date: Sat, 16 Aug 2025 13:46:18 +0300 > > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > > > > From: pwychowaniec via "Bug reports for GNU Emacs, > > > > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > > > > > > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > > > > > commit message. > > > > > > > > Thanks. Po Lu, could you please review and comment? > > > > > > > > In any case, Patryk, to accept changes of this size we will need you > > > > to sign a copyright assignment agreement. If you agree, I will send > > > > you the form to fill and the instructions to go with it. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 27 Sep 2025 08:50:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 27 04:50:14 2025 Received: from localhost ([127.0.0.1]:38813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1v2QdB-0000t6-2O for submit <at> debbugs.gnu.org; Sat, 27 Sep 2025 04:50:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48246) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1v2Qd6-0000rH-Hq for 79204 <at> debbugs.gnu.org; Sat, 27 Sep 2025 04:50:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1v2Qd0-0004Po-07; Sat, 27 Sep 2025 04:50:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1t/8duu3sazO1tBQAGD07c81aKXN6JDBVBUESMIbbbI=; b=XuH9kLcOYeei tAyBXkZx0w2oRuRKqlbYiTs/pFm5sVNrx7R2mAzFWqY6y5P5q2cVTtNVFbEYoi+fGNArYlUo40Gum j1X/XwDOVwb8dVremfxKpkAxYCeBAVVqNvUtcfWNxxjj6U7R1wYg9Hz+nmij1GAR2bdaXWf10uRP0 xFfxumYqMiCpxNA6w000s+6I66KXCPOWyAwDhz/3dZMS29EeK9/9jpfaa3d4p03sYxWN0hFQnEVQK io2j0XeEfvC7LKX5bMsRpQZQn7sbhwsnkFuPTeIH1by1GNxUzEjZbA8VucZAkiTpbQp2B12T5XraM RGIp9QrsA7ziN9SqjYx7ew==; Date: Sat, 27 Sep 2025 11:49:57 +0300 Message-Id: <86seg88ekq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <86ecsassnf.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 13 Sep 2025 10:44:52 +0300) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <86iki5qlw7.fsf@HIDDEN> <86ecsassnf.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Ping! Po Lu, could you please chime in? > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > Date: Sat, 13 Sep 2025 10:44:52 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Ping! Po Lu, please respond. > > > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > > Date: Sat, 30 Aug 2025 11:00:40 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > Ping! Po Lu, could you please review the proposed patch? > > > > > Cc: 79204 <at> debbugs.gnu.org > > > Date: Sat, 16 Aug 2025 13:46:18 +0300 > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > > > From: pwychowaniec via "Bug reports for GNU Emacs, > > > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > > > > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > > > > commit message. > > > > > > Thanks. Po Lu, could you please review and comment? > > > > > > In any case, Patryk, to accept changes of this size we will need you > > > to sign a copyright assignment agreement. If you agree, I will send > > > you the form to fill and the instructions to go with it. > > > > > > > > > > > > > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 13 Sep 2025 07:45:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 13 03:45:06 2025 Received: from localhost ([127.0.0.1]:53026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uxKwT-0000KX-MP for submit <at> debbugs.gnu.org; Sat, 13 Sep 2025 03:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45690) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uxKwQ-0000JR-GG for 79204 <at> debbugs.gnu.org; Sat, 13 Sep 2025 03:45:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uxKwJ-0001Gu-VW; Sat, 13 Sep 2025 03:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=buvcPS3BV7gd+Woh6I/BAS5lHiIE0KcnvZHPBLmO85o=; b=QtZ34Tx2EenR 96+ApRUYDflLkcfh07sHl1XukNQY9GWdb+z2kdu1bAdpKksiUvWPAukwngOqXwa06OmK6PAeJ0FAG G9B/41j0xQpjra53oOnauQfVYR3q8TwW3Cu1ap+CLi1M5xUADNupgCn/7N0qfeWZ4y//CFE1BMJUO KwtM7IlT8M5FKR9sHqcn2J2XI9cihaXNu4b3yHIb+KwtJLS4i5qsPTtQtMr2Oti7+W2YN4CysyUzM IltB4rOgPG7D/+sjG9JqpUCHxCGhx5xoMremWj3dpwg4ajf1HPBJQP8xP44LQ71/bCbdxRSPgHybI Tfbj94cIdrppvldGkTpZkQ==; Date: Sat, 13 Sep 2025 10:44:52 +0300 Message-Id: <86ecsassnf.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <86iki5qlw7.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 30 Aug 2025 11:00:40 +0300) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> <86iki5qlw7.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Po Lu, please respond. > Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN > Date: Sat, 30 Aug 2025 11:00:40 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Po Lu, could you please review the proposed patch? > > > Cc: 79204 <at> debbugs.gnu.org > > Date: Sat, 16 Aug 2025 13:46:18 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > > From: pwychowaniec via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > > > commit message. > > > > Thanks. Po Lu, could you please review and comment? > > > > In any case, Patryk, to accept changes of this size we will need you > > to sign a copyright assignment agreement. If you agree, I will send > > you the form to fill and the instructions to go with it. > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 30 Aug 2025 08:00:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 30 04:00:55 2025 Received: from localhost ([127.0.0.1]:44554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1usGW6-0006Pc-LZ for submit <at> debbugs.gnu.org; Sat, 30 Aug 2025 04:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50474) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1usGW4-0006Oc-6W for 79204 <at> debbugs.gnu.org; Sat, 30 Aug 2025 04:00:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1usGVy-00076b-8d; Sat, 30 Aug 2025 04:00:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hZQsWxjlq1PfykbEtYc3n+WU/7t2utJPjQMYY8MmvhY=; b=Y5aIDHioSKZg upwTKSaZVF4RftHtJV3rIb1ooYbfuU7g7K7Ij2QGRLtopOwcRrnvj1R1ApFiWLo++dTUQ7Tn/rNc7 pesU7v1HJx6z8zcuIh5HGFH7nmDJAwblJumooCITyes3jMTwQZf+IonYuYWztn/qy4FmMiHRne6Tt 7DNxTMFvqVD0VW640RBui5EhdaU30P2wwg3SHEfV+hB/it9mPTxhLsPp/5q9SCOYvzoxkvOagI05E Lq0ZknHodeW9oXPic86j1FRIlMv4JmzWSIjtGIxM2W9J1xC7z9WfwUDqwYkVMGKVIlTfRizhfQIA5 6nJTuXzgne40AVMC82F4OQ==; Date: Sat, 30 Aug 2025 11:00:40 +0300 Message-Id: <86iki5qlw7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <86v7mnk0hx.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 16 Aug 2025 13:46:18 +0300) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> <86v7mnk0hx.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org, pwychowaniec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Po Lu, could you please review the proposed patch? > Cc: 79204 <at> debbugs.gnu.org > Date: Sat, 16 Aug 2025 13:46:18 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > Date: Sat, 09 Aug 2025 12:21:52 +0000 > > From: pwychowaniec via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > > commit message. > > Thanks. Po Lu, could you please review and comment? > > In any case, Patryk, to accept changes of this size we will need you > to sign a copyright assignment agreement. If you agree, I will send > you the form to fill and the instructions to go with it. > > > >
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at 79204) by debbugs.gnu.org; 16 Aug 2025 10:46:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 16 06:46:28 2025 Received: from localhost ([127.0.0.1]:41225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1unEQe-0007l3-Dz for submit <at> debbugs.gnu.org; Sat, 16 Aug 2025 06:46:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55776) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1unEQc-0007km-K3 for 79204 <at> debbugs.gnu.org; Sat, 16 Aug 2025 06:46:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1unEQW-0005rm-V4; Sat, 16 Aug 2025 06:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Om14I2kXJXEdgvVSszi36mwObFfGfS8/H4Xg9WVbEI0=; b=Vx/Hn2QxJtr0 Z4moE3ePa5iELd4/T4G7pggjxwuiw5vPso1iCMoKUF/HIMcU4SXj4hqdxfHqCX1tCAxLVg08Fm3X2 a8ncEe/hAkOg+VT1Pm+l+ETv5jEIuGVPoxI+nBRbml7kp9o7pU8yL7N/a+pHeqrL0ODNpkEm0stB+ tid0GTGlx5GJvv+e6m38HJUhjif3bhjh4natOfsGja4W9DJnM/+oYTrJMqXnTDS6sgAiD//xbL2ZB S9j+qO7uHBtuK/GRFAVo/ZvBj054bgMr2GlXbqHsl3jIvnvrc+c3ysEWOd4DY4SdtoXSnvzi3NLVu HTSExdLckz44qgOQI75u8A==; Date: Sat, 16 Aug 2025 13:46:18 +0300 Message-Id: <86v7mnk0hx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: pwychowaniec <pwychowaniec@HIDDEN>, Po Lu <luangruo@HIDDEN> In-Reply-To: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#79204: [PATCH] pgtk: Use cairo_set_source_surface() References: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79204 Cc: 79204 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 09 Aug 2025 12:21:52 +0000 > From: pwychowaniec via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > I'm submitting a patch that improves performance of previewing large images in Emacs; more details in the > commit message. Thanks. Po Lu, could you please review and comment? In any case, Patryk, to accept changes of this size we will need you to sign a copyright assignment agreement. If you agree, I will send you the form to fill and the instructions to go with it.
bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Aug 2025 16:44:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 09 12:44:18 2025 Received: from localhost ([127.0.0.1]:42894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ukmg4-0006zQ-0U for submit <at> debbugs.gnu.org; Sat, 09 Aug 2025 12:44:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:43274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pwychowaniec@HIDDEN>) id 1ukib0-0002Ev-B9 for submit <at> debbugs.gnu.org; Sat, 09 Aug 2025 08:22:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pwychowaniec@HIDDEN>) id 1ukiam-0006GM-1x for bug-gnu-emacs@HIDDEN; Sat, 09 Aug 2025 08:22:33 -0400 Received: from mail-06.mail-europe.com ([85.9.210.45]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pwychowaniec@HIDDEN>) id 1ukiaY-0003Hd-1q for bug-gnu-emacs@HIDDEN; Sat, 09 Aug 2025 08:22:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1754742116; x=1755001316; bh=pVENmC15uF0z/h+z21JRkH/ebmSMNtet7gdffm9jIMI=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=KVmsUiJ/1qFrYDK01PZfJosLiN1G8ovB70DjTel1VfW3DQMVT9yoEDoS1fFil3mnj rREZUwgCvCyrfJ43YxH0nvskuuoRP67xrkfjjz4NPA28dizKFFhiigTmPlNAyImCm+ 9fXd/132k3Zu9zwTeB198uWafoJ8G8kPBStm5ICSytNDfCUwTJNWy77ODoZnv4yn8g RnompzohVFVyBrhRkdFUPWJZV4pl5t3rDWNtmgI4aLAzHwMdn1g4UOpCkAV7WZHbiQ BJ431ADPx8tVYMBkti287sajeshflRAV/U6F2Tb5kJptJpvMO1wVogzenCQ6ErZi1c C+wROBl74lZ8A== Date: Sat, 09 Aug 2025 12:21:52 +0000 To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN> From: pwychowaniec <pwychowaniec@HIDDEN> Subject: [PATCH] pgtk: Use cairo_set_source_surface() Message-ID: <M8yxlqYBNDCtxw7MCi6Ug8tgwI9aJYPbUwmdbjPzeDnGjfFYpfZ5llVP4JaxPEZ7EWzY7H3AqF9F0WSkzAkiAOxl8v5iscbq6Qs1X7NC15o=@pm.me> Feedback-ID: 27022295:user:proton X-Pm-Message-ID: ce452f20ac64a6ccaddfb71555695f5edaa54ca5 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI" Received-SPF: pass client-ip=85.9.210.45; envelope-from=pwychowaniec@HIDDEN; helo=mail-06.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 09 Aug 2025 12:44:14 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --b1=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI Content-Type: multipart/alternative; boundary="b2=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI" --b2=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkhCgpJJ20gc3VibWl0dGluZyBhIHBhdGNoIHRoYXQgaW1wcm92ZXMgcGVyZm9ybWFuY2Ugb2Yg cHJldmlld2luZyBsYXJnZSBpbWFnZXMgaW4gRW1hY3M7IG1vcmUgZGV0YWlscyBpbiB0aGUgY29t bWl0IG1lc3NhZ2UuCgpDaGVlcnMsClBhdHJ5ay4= --b2=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0 cHg7IGNvbG9yOiByZ2IoMCwgMCwgMCk7IGJhY2tncm91bmQtY29sb3I6IHJnYigyNTUsIDI1NSwg MjU1KTsiPkhpITwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBBcmlhbCwgc2Fucy1zZXJp ZjsgZm9udC1zaXplOiAxNHB4OyBjb2xvcjogcmdiKDAsIDAsIDApOyBiYWNrZ3JvdW5kLWNvbG9y OiByZ2IoMjU1LCAyNTUsIDI1NSk7Ij48YnI+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6 IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0cHg7IGNvbG9yOiByZ2IoMCwgMCwgMCk7 IGJhY2tncm91bmQtY29sb3I6IHJnYigyNTUsIDI1NSwgMjU1KTsiPkknbSBzdWJtaXR0aW5nIGEg cGF0Y2ggdGhhdCBpbXByb3ZlcyBwZXJmb3JtYW5jZSBvZiBwcmV2aWV3aW5nIGxhcmdlIGltYWdl cyBpbiBFbWFjczsgbW9yZSBkZXRhaWxzIGluIHRoZSBjb21taXQgbWVzc2FnZS48L2Rpdj48ZGl2 IHN0eWxlPSJmb250LWZhbWlseTogQXJpYWwsIHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogMTRweDsg Y29sb3I6IHJnYigwLCAwLCAwKTsgYmFja2dyb3VuZC1jb2xvcjogcmdiKDI1NSwgMjU1LCAyNTUp OyI+PGJyPjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBBcmlhbCwgc2Fucy1zZXJpZjsg Zm9udC1zaXplOiAxNHB4OyBjb2xvcjogcmdiKDAsIDAsIDApOyBiYWNrZ3JvdW5kLWNvbG9yOiBy Z2IoMjU1LCAyNTUsIDI1NSk7Ij5DaGVlcnMsPC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6 IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0cHg7IGNvbG9yOiByZ2IoMCwgMCwgMCk7 IGJhY2tncm91bmQtY29sb3I6IHJnYigyNTUsIDI1NSwgMjU1KTsiPlBhdHJ5ay48L2Rpdj4= --b2=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI-- --b1=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI Content-Type: text/x-patch; name=0001-pgtk-Use-cairo_set_source_surface.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-pgtk-Use-cairo_set_source_surface.patch RnJvbSA3MjM4MTBkYmU0NjZkZjYxOTFhZWNlZTVhN2ViNTk5NjNmNWNmM2RiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXRyeWsgV3ljaG93YW5pZWMgPHB3eWNob3dhbmllY0BwbS5t ZT4KRGF0ZTogU2F0LCA5IEF1ZyAyMDI1IDE0OjEyOjI4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGd0azogVXNlIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZSgpCgpgY2Fpcm9fc2V0X3NvdXJjZV9z dXJmYWNlKClgIHNlZW1zIHRvIGJlIGFib3V0IHR3byBvcmRlcnMgb2YgbWFnbml0dWRlCmZhc3Rl ciB0aGFuIGBjYWlyb19zZXRfc291cmNlKClgLCBzbyBsZXQncyB1c2UgaXQgdG8gZHJhdyBpbWFn ZXMgd2l0aGluCmBwZ3RrX2NyX2RyYXdfaW1hZ2UoKWAuCgpUb2RheSwgaWYgeW91IG9wZW4gYSBy ZWxhdGl2ZWx5IGxhcmdlIGltYWdlWzFdIGluIGVtYWNzLXBndGssIHRoZSBlbnRpcmUKaW50ZXJm YWNlIHdpbGwgc2xvdyBkb3duIHRvIGEgY3Jhd2wgZXZlcnkgdGltZSBpdCBuZWVkcyB0byBiZSBy ZWRyYXduIC0Kd2l0aCB0aGUgY2hhbmdlcyBoZXJlLCB0aGUgZnJhbWVyYXRlIGlzIHNtb290aCBh bmQgY29uc2lzdGVudC4KClsxXSBzYXksIDE2MDB4MTIwMAotLS0KIHNyYy9kaXNwZXh0ZXJuLmgg fCAgMSArCiBzcmMvaW1hZ2UuYyAgICAgIHwgMTIgKysrKysrKysrKysrCiBzcmMvcGd0a3Rlcm0u YyAgIHwgNDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQogMyBm aWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9kaXNwZXh0ZXJuLmggYi9zcmMvZGlzcGV4dGVybi5oCmluZGV4IDE5YWIxMDRkMmU2 Li5kYjg2M2QwZmFiMCAxMDA2NDQKLS0tIGEvc3JjL2Rpc3BleHRlcm4uaAorKysgYi9zcmMvZGlz cGV4dGVybi5oCkBAIC0zMTgwLDYgKzMxODAsNyBAQCByZXNldF9tb3VzZV9oaWdobGlnaHQgKE1v dXNlX0hMSW5mbyAqaGxpbmZvKQogCiAjaWZkZWYgVVNFX0NBSVJPCiAgIHZvaWQgKmNyX2RhdGE7 CisgIHZvaWQgKmNyX3N1cmZhY2U7CiAjZW5kaWYKICNpZmRlZiBIQVZFX1hfV0lORE9XUwogICAv KiBYIGltYWdlcyBvZiB0aGUgaW1hZ2UsIGNvcnJlc3BvbmRpbmcgdG8gdGhlIGFib3ZlIFBpeG1h cHMuCmRpZmYgLS1naXQgYS9zcmMvaW1hZ2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IGM1Y2FhZjcz OWU3Li5kZmRmYTg0ZTdjYyAxMDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIvc3JjL2ltYWdl LmMKQEAgLTM0OSw3ICszNDksMTMgQEAgY3JfcHV0X2ltYWdlX3RvX2NyX2RhdGEgKHN0cnVjdCBp bWFnZSAqaW1nKQogICAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95IChzdXJmYWNlKTsKICAgICB9 CiAKKyAgaWYgKGltZy0+Y3Jfc3VyZmFjZSkKKyAgICB7CisgICAgICBjYWlyb19zdXJmYWNlX2Rl c3Ryb3kgKGltZy0+Y3Jfc3VyZmFjZSk7CisgICAgfQorCiAgIGltZy0+Y3JfZGF0YSA9IHBhdHRl cm47CisgIGltZy0+Y3Jfc3VyZmFjZSA9IE5VTEw7CiB9CiAKICNlbmRpZgkvKiBVU0VfQ0FJUk8g Ki8KQEAgLTIxMjQsNiArMjEzMCwxMiBAQCBpbWFnZV9jbGVhcl9pbWFnZV8xIChzdHJ1Y3QgZnJh bWUgKmYsIHN0cnVjdCBpbWFnZSAqaW1nLCBpbnQgZmxhZ3MpCiAgICAgICBjYWlyb19wYXR0ZXJu X2Rlc3Ryb3kgKGltZy0+Y3JfZGF0YSk7CiAgICAgICBpbWctPmNyX2RhdGEgPSBOVUxMOwogICAg IH0KKworICBpZiAoaW1nLT5jcl9zdXJmYWNlKQorICAgIHsKKyAgICAgIGNhaXJvX3N1cmZhY2Vf ZGVzdHJveSAoaW1nLT5jcl9zdXJmYWNlKTsKKyAgICAgIGltZy0+Y3Jfc3VyZmFjZSA9IE5VTEw7 CisgICAgfQogI2VuZGlmCS8qIFVTRV9DQUlSTyAqLwogfQogCmRpZmYgLS1naXQgYS9zcmMvcGd0 a3Rlcm0uYyBiL3NyYy9wZ3RrdGVybS5jCmluZGV4IGE3YmUyZDkwODk5Li5hODY5ODdlMTNiNiAx MDA2NDQKLS0tIGEvc3JjL3BndGt0ZXJtLmMKKysrIGIvc3JjL3BndGt0ZXJtLmMKQEAgLTIxNzQs OCArMjE3NCw4IEBAIHBndGtfZHJhd19nbHlwaF9zdHJpbmdfYmdfcmVjdCAoc3RydWN0IGdseXBo X3N0cmluZyAqcywgaW50IHgsIGludCB5LCBpbnQgdywKIAogc3RhdGljIHZvaWQKIHBndGtfY3Jf ZHJhd19pbWFnZSAoc3RydWN0IGZyYW1lICpmLCBFbWFjc19HQyAqZ2MsIGNhaXJvX3BhdHRlcm5f dCAqaW1hZ2UsCi0JCSAgICBpbnQgc3JjX3gsIGludCBzcmNfeSwgaW50IHdpZHRoLCBpbnQgaGVp Z2h0LAotCQkgICAgaW50IGRlc3RfeCwgaW50IGRlc3RfeSwgYm9vbCBvdmVybGF5X3ApCisJCSAg ICBjYWlyb19zdXJmYWNlX3QgKipzdXJmYWNlLCBpbnQgc3JjX3gsIGludCBzcmNfeSwgaW50IHdp ZHRoLAorCQkgICAgaW50IGhlaWdodCwgaW50IGRlc3RfeCwgaW50IGRlc3RfeSwgYm9vbCBvdmVy bGF5X3ApCiB7CiAgIGNhaXJvX3QgKmNyID0gcGd0a19iZWdpbl9jcl9jbGlwIChmKTsKIApAQCAt MjE5MCwxMiArMjE5MCw0MCBAQCBwZ3RrX2NyX2RyYXdfaW1hZ2UgKHN0cnVjdCBmcmFtZSAqZiwg RW1hY3NfR0MgKmdjLCBjYWlyb19wYXR0ZXJuX3QgKmltYWdlLAogCiAgIGNhaXJvX3RyYW5zbGF0 ZSAoY3IsIGRlc3RfeCAtIHNyY194LCBkZXN0X3kgLSBzcmNfeSk7CiAKLSAgY2Fpcm9fc3VyZmFj ZV90ICpzdXJmYWNlOwotICBjYWlyb19wYXR0ZXJuX2dldF9zdXJmYWNlIChpbWFnZSwgJnN1cmZh Y2UpOwotICBjYWlyb19mb3JtYXRfdCBmb3JtYXQgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF9m b3JtYXQgKHN1cmZhY2UpOworICBjYWlyb19zdXJmYWNlX3QgKmltYWdlX3N1cmZhY2U7CisgIGNh aXJvX3BhdHRlcm5fZ2V0X3N1cmZhY2UgKGltYWdlLCAmaW1hZ2Vfc3VyZmFjZSk7CisgIGNhaXJv X2Zvcm1hdF90IGZvcm1hdCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2Zvcm1hdCAoaW1hZ2Vf c3VyZmFjZSk7CisKICAgaWYgKGZvcm1hdCAhPSBDQUlST19GT1JNQVRfQTggJiYgZm9ybWF0ICE9 IENBSVJPX0ZPUk1BVF9BMSkKICAgICB7Ci0gICAgICBjYWlyb19zZXRfc291cmNlIChjciwgaW1h Z2UpOworICAgICAgLyogU2luY2UgZHJhd2luZyBzdXJmYWNlcyBpcyBtdWNoIGZhc3RlciB0aGFu IGRyYXdpbmcgcGF0dGVybnMsCisJIGxldCdzIHRyeSB0byBjb252ZXJ0IHRoaXMgaW1hZ2UgaW50 byBhIHN1cmZhY2UgYW5kIGNhY2hlIGl0LiAgKi8KKyAgICAgIGlmIChzdXJmYWNlKQorCXsKKwkg IGlmICghKnN1cmZhY2UpCisJICAgIHsKKwkgICAgICBpbnQgaW1hZ2Vfd2lkdGggPSBjYWlyb19p bWFnZV9zdXJmYWNlX2dldF93aWR0aCAoaW1hZ2Vfc3VyZmFjZSk7CisJICAgICAgaW50IGltYWdl X2hlaWdodCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2hlaWdodCAoaW1hZ2Vfc3VyZmFjZSk7 CisKKwkgICAgICAqc3VyZmFjZSA9IGNhaXJvX3N1cmZhY2VfY3JlYXRlX3NpbWlsYXJfaW1hZ2Ug KGltYWdlX3N1cmZhY2UsCisJCQkJCQkJICAgICBmb3JtYXQsCisJCQkJCQkJICAgICBpbWFnZV93 aWR0aCwKKwkJCQkJCQkgICAgIGltYWdlX2hlaWdodCk7CisKKwkgICAgICBjYWlyb190ICpjcjIg PSBjYWlyb19jcmVhdGUgKCpzdXJmYWNlKTsKKworCSAgICAgIGNhaXJvX3NldF9zb3VyY2UgKGNy MiwgaW1hZ2UpOworCSAgICAgIGNhaXJvX3BhaW50IChjcjIpOworCSAgICAgIGNhaXJvX2Rlc3Ry b3kgKGNyMik7CisJICAgIH0KKworCSAgY2Fpcm9fc2V0X3NvdXJjZV9zdXJmYWNlIChjciwgKnN1 cmZhY2UsIDAsIDApOworCX0KKyAgICAgIGVsc2UKKwl7CisJICBjYWlyb19zZXRfc291cmNlIChj ciwgaW1hZ2UpOworCX0KKwogICAgICAgY2Fpcm9fZmlsbCAoY3IpOwogICAgIH0KICAgZWxzZQpA QCAtMjIzNSw2ICsyMjYzLDcgQEAgcGd0a19kcmF3X2ltYWdlX2ZvcmVncm91bmQgKHN0cnVjdCBn bHlwaF9zdHJpbmcgKnMpCiAgICAgICBjYWlyb190ICpjciA9IHBndGtfYmVnaW5fY3JfY2xpcCAo cy0+Zik7CiAgICAgICBwZ3RrX3NldF9nbHlwaF9zdHJpbmdfY2xpcHBpbmcgKHMsIGNyKTsKICAg ICAgIHBndGtfY3JfZHJhd19pbWFnZSAocy0+ZiwgJnMtPnhnY3YsIHMtPmltZy0+Y3JfZGF0YSwK KwkJCSAgKGNhaXJvX3N1cmZhY2VfdCAqKikgJnMtPmltZy0+Y3Jfc3VyZmFjZSwKIAkJCSAgcy0+ c2xpY2UueCwgcy0+c2xpY2UueSwgcy0+c2xpY2Uud2lkdGgsIHMtPnNsaWNlLmhlaWdodCwKIAkJ CSAgeCwgeSwgdHJ1ZSk7CiAgICAgICBpZiAoIXMtPmltZy0+bWFzaykKQEAgLTM2NDEsNyArMzY3 MCw3IEBAIHBndGtfZHJhd19mcmluZ2VfYml0bWFwIChzdHJ1Y3Qgd2luZG93ICp3LCBzdHJ1Y3Qg Z2x5cGhfcm93ICpyb3csCiAJCQkgICA6IEZSQU1FX1hfT1VUUFVUIChmKS0+Y3Vyc29yX2NvbG9y KQogCQkJOiBmYWNlLT5mb3JlZ3JvdW5kKTsKICAgICAgIGdjdi5iYWNrZ3JvdW5kID0gZmFjZS0+ YmFja2dyb3VuZDsKLSAgICAgIHBndGtfY3JfZHJhd19pbWFnZSAoZiwgJmdjdiwgZnJpbmdlX2Jt cFtwLT53aGljaF0sIDAsIHAtPmRoLAorICAgICAgcGd0a19jcl9kcmF3X2ltYWdlIChmLCAmZ2N2 LCBmcmluZ2VfYm1wW3AtPndoaWNoXSwgTlVMTCwgMCwgcC0+ZGgsCiAJCQkgIHAtPndkLCBwLT5o LCBwLT54LCBwLT55LCBwLT5vdmVybGF5X3ApOwogICAgIH0KIAotLSAKMi41MC4xCgo= --b1=_q7ePMbqEV5SJbOovdoXL2lzIGPTEW1E1mLmNWtftUI--
pwychowaniec <pwychowaniec@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79204; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.