GNU logs - #79234, boring messages

Message sent to help-debbugs@HIDDEN:

Subject: bug#79234: Global completion without limit arg terminates on first libdb
Resent-From: Ross Bennett <ross@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: help-debbugs@HIDDEN
Resent-Date: Thu, 14 Aug 2025 11:16:02 +0000
Resent-Message-ID: <handler.79234.B.17551701192369 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79234 <at> debbugs.gnu.org
Reply-To: ross@HIDDEN
MIME-Version: 1.0
Date: Thu, 14 Aug 2025 16:16:09 +0800
From: Ross Bennett <ross@HIDDEN>
Mail-Reply-To: ross@HIDDEN
User-Agent: Roundcube Webmail/1.6.11
Message-ID: <604f264264db727ad0dcd5f548325a65@HIDDEN>
Organization: Evermain
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Package: global
Version: 6.6.14

When I have a GTAGSLIBPATH involving multiple directories, a global 
command to find completions of tags in the second path entry fails. It 
works if I give a limit to the completion argument.

e.g. I have 2 library directories, /srv1/source/dir1 and 
/srv1/source/dir2, and dbg_foo() defined in /srv1/source/dir2/file1.c. I 
run gtags in each of these directories. I have 
GTAGSLIBPATH=/srv1/source/dir1/:/srv1/source/dir2/

 From another directory also with GTAGS I run 'global -c dbg_f' and get 
nothing.

It gives completions from the first library fine.

Also, using a limit avoids the issue. Running 'global --completion=1 
dbg_f' and it gives dbg_foo successfully.

On one occasion I think I got this to work initially, but then it failed 
on repeats, I'm not sure why or even if I was doing the tests correctly 
at that point.

Looking at the 6.6.14 code, I think the issue is in global/global.c, 
line 1091: if (total >= limit) break;

Without a completion limit argument, the limit variable is set to 0. So, 
if no entries are found in the first library path, the total is 0, which 
still qualifies for >= 0, which aborts the loop. Having a limit argument 
avoids that problem.

I adjusted the code in a local checkout to be if (total > limit) and the 
compiled binary then worked correctly for dbg_foo with global -c dbg_f.

Hope this helps

Ross
-- 
Ross Bennett

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: ross@HIDDEN
Subject: bug#79234: Acknowledgement (Global completion without limit arg
 terminates on first libdb)
Message-ID: <handler.79234.B.17551701192369.ack <at> debbugs.gnu.org>
References: <604f264264db727ad0dcd5f548325a65@HIDDEN>
X-Gnu-PR-Message: ack 79234
X-Gnu-PR-Package: global
Reply-To: 79234 <at> debbugs.gnu.org
Date: Thu, 14 Aug 2025 11:16:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 help-debbugs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79234 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79234: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79234
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Thu, 14 Aug 2025 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.