Received: (at 79305) by debbugs.gnu.org; 1 Sep 2025 17:20:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 01 13:20:55 2025
Received: from localhost ([127.0.0.1]:58390 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ut8D8-0002ij-M7
for submit <at> debbugs.gnu.org; Mon, 01 Sep 2025 13:20:55 -0400
Received: from mail-vk1-xa34.google.com ([2607:f8b0:4864:20::a34]:55474)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>)
id 1ut8D6-0002iV-C6
for 79305 <at> debbugs.gnu.org; Mon, 01 Sep 2025 13:20:53 -0400
Received: by mail-vk1-xa34.google.com with SMTP id
71dfb90a1353d-544acb1f41dso756224e0c.2
for <79305 <at> debbugs.gnu.org>; Mon, 01 Sep 2025 10:20:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1756747246; x=1757352046; darn=debbugs.gnu.org;
h=cc:to:references:in-reply-to:subject:message-id:date:from
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=DdX6KiiKl1j8BYZYLuYfYXnx+5XDIo9yJCeu2BzP4Jc=;
b=eNbG8XAZ8JsxJ7fLHUKJXzB5FKEnEy6Wp95NRcZreNi0iuDHVj7gI6048JVKRIY69J
SA9iC657Pq5c27uB1t66c53zRta6n0dGEy20qLemd9v64sF2dLT9/SETuooFVHsHAEil
669wgXGhMIr/TWet4BofVBCf3PNwaIHLC09bxmesMl58YfMckgQ8gkcRk80CEHBHP5cQ
5cTSkvcH1lVk3thgysH4YgscJlQIRmfGit9OdMKmimSb/+kOpHr5+YRwZDuSRVQup94F
tYzANQAptjlN2wMab5qE72av+Zunvwo4c/oMmOeyg1b7Cb1McMcJFi7JQYwj7usOalvC
2HEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1756747246; x=1757352046;
h=cc:to:references:in-reply-to:subject:message-id:date:from
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=DdX6KiiKl1j8BYZYLuYfYXnx+5XDIo9yJCeu2BzP4Jc=;
b=T/IsRFAD7yMlYCYBl44EtZwWugUtPDvKbNhHWs/zqhSrxgLnhwWDUt88qGnDunQ5p9
N7o60CwTDXEan9OaP2EL8qLlTQk9Zew26EuRVjr0S/uPV9X6CTZ8KS+puHMWKw+t7zoi
dt/DFxQAdmuUfDfE1jy5YWPfqPFmnji/KVH7QNVZ4aMx9oDehOAQOlAvovKxyDubSFY/
punqmoEpzSrRvI7C3NdNJwuKC53bLhsqeBmZk34tYxD0xFoNkegSioimWJDYnORT6J79
vYtrecfZQn1D2LDI1D5qo/oPN4KtyEUWmG1pCMbWmyGW4SJ6BKCXBV4h5zewvBHPRSLc
UJBA==
X-Forwarded-Encrypted: i=1;
AJvYcCX6+foOslAL+XA+NlF3JGcMuNCPDY1nWL3FkySqRVlD5HHcyw0jJdtTHbpB+YOh1OrHVzKCpQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwaFYNjuwtJpKJs42W3cI04hsNqCa7dY7AJVZnW9hfU+tkw/PH8
WLXXw6aN2xwE+Ls62rvogcw1w5TXDhqbo1Q+wPhP7omM1oe1AsF8QTr/pbTn+A==
X-Gm-Gg: ASbGncsj9gFLE0c6II8qQrCVhyD5cOmYeHWpbN1RHfl5N6yDPp1g68AiwR8rHazQwC8
9r4IN2HoFtEWpjjolmkGllOaLW+q7lLhg4///OPu/cy3CWFusc+McXhnotu7Ze/Xl7wY0RWawl+
c2npBj9RrljOpZoaWfTGg+gWrMw8TLEY7ArDVJMeXWujehE0FuYQVPWiYtqLtKbzSGGWo3+LoSd
ZeNeRfvEB0sW5StO0VklLny/hcatZou4D+jHJO//Osl78ZzwH7dT33uOVF2yfCG1XN5AlrEXMcV
xF1kqTRR5M6XE9zh6tmds2OEiMOBrXg0TW+7UEaRfWK5Zq3m5JbrKOrptke6VExcKlzp6q5c8Jn
vKiSnrUK18THEf7daHgcyn8M1dU8G6yt9Psk2T+BH+mIpBYcZBR3VNsGuJjzfTeqdbLg=
X-Google-Smtp-Source: AGHT+IHX608dmYN/mtZvQ2D9XS3jELSFeSw6e+1XRNFa6ZZqD1e/tK3lhogKhd6WjWsIzpOQ0/m1ng==
X-Received: by 2002:a05:6122:2022:b0:543:88f1:6621 with SMTP id
71dfb90a1353d-544a018f9e2mr2477682e0c.3.1756747245869;
Mon, 01 Sep 2025 10:20:45 -0700 (PDT)
Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0])
by smtp.gmail.com with UTF8SMTPSA id
71dfb90a1353d-5449ed5a91esm3243551e0c.20.2025.09.01.10.20.45
for <79305 <at> debbugs.gnu.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Mon, 01 Sep 2025 10:20:45 -0700 (PDT)
Mime-Version: 1.0
X-Superhuman-ID: mf1dxprd.f71a6db4-21fe-4908-8c29-6335c055aeef
From: "Aaron Jensen" <aaronjensen@HIDDEN>
Date: Mon, 01 Sep 2025 17:20:39 +0000
Message-ID: <mf1dufpf.6ba2c872-7ac4-43dd-9ae1-e0eae3c9e90f@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
X-Mailer: Superhuman Desktop (2025-08-29T23:31:37Z)
X-Superhuman-Draft-ID: draft0081e20984b89797
In-Reply-To: <mf1bq5pb.bcf07cca-6f18-4b0d-95d3-7b4d53d75cd8@HIDDEN>
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
<jwvbjnu945l.fsf-monnier+emacs@HIDDEN>
<87zfbeimvq.fsf@HIDDEN>
<jwv7byi6v1a.fsf-monnier+emacs@HIDDEN>
<mf1bq5pb.bcf07cca-6f18-4b0d-95d3-7b4d53d75cd8@HIDDEN>
To: "Stefan Monnier" <monnier@HIDDEN>
Content-Type: multipart/mixed;
boundary=20ec0e412723b91a06483ece301eb13f215a7d9b5286d7bd70264e36e200
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79305
Cc: Justin Burkett <justin@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>,
79305 <at> debbugs.gnu.org, Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--20ec0e412723b91a06483ece301eb13f215a7d9b5286d7bd70264e36e200
Content-Type: multipart/alternative;
boundary=c1ba3b375aacd12bb91eafd6c9ac428685bce8285581ba035753deeaa7e0
--c1ba3b375aacd12bb91eafd6c9ac428685bce8285581ba035753deeaa7e0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
The attached demonstrates the problem, I believe.
Aaron
On Mon, Sep 01, 2025 at 9:31 AM, Aaron Jensen < aaronjensen@HIDDEN > wro=
te:
>=20
> It's my understanding that=C2=A0the check for set-explicitly is done beca=
use
> given where this hook runs, it's possible=C2=A0that the mode variable is =
not
> yet initialized, which means=C2=A0that even though it eventually will be,=
and
> thus could be relied on, it may not be. Therefore, bind-map relies on
> similar logic as the minor mode itself to determine whether or not the
> minor mode *will eventually* be enabled. It seems like your proposed patc=
h
> to bind-map would be subject to this "hook race".
>=20
>=20
>=20
> Again, this is just an informed guess as I haven't set up the conditions
> to reproduce it yet.
>=20
>=20
>=20
> I have extracted the relevant bind-map code to my own library that
> depended on it:
>=20
>=20
>=20
> https:/ / github. com/ aaronjensen/ emacs-leader-key/ blob/ master/ leade=
r-key.
> el#L109 (
> https://github.com/aaronjensen/emacs-leader-key/blob/master/leader-key.el=
#L109
> )
>=20
>=20
>=20
> Currently, it still relies on set-explicitly (accepting both forms), but
> if there's a way that we can get it to not I'd be happy to try it out.
>=20
>=20
>=20
>=20
> Aaron
>=20
>=20
>=20
> On Mon, Sep 01, 2025 at 8:42 AM, Stefan Monnier < monnier@ iro. umontreal=
.
> ca ( monnier@HIDDEN ) > wrote:
>=20
>>=20
>>>=20
>>>>=20
>>>>=20
>>>> After spending some time looking at the code, its history, and the
>>>> corresponding doc, my conclusion is that `bind-map`s code was probably
>>>> incorrect already with older Emacsen (just in different ways) and its
>>>> intended behavior is far from clear, so I think it's best to leave thi=
s as
>>>> a WONTFIX and let `bind-map`s authors figure out what to do on their s=
ide
>>>> (tho I'd be happy to help them figure that out).
>>>>=20
>>>>=20
>>>=20
>>>=20
>>>=20
>>> You don't think we should even restore it and mark it as obsolete?
>>>=20
>>>=20
>>=20
>>=20
>>=20
>> Since I believe bind-map's code was only half-working to begin with: no,=
I
>> don't think it's worth the trouble. It would just help them muddle
>> through. I'd rather help them fix their code for good.
>>=20
>>=20
>>=20
>> Stefan
>>=20
>>=20
>>=20
>=20
>
--c1ba3b375aacd12bb91eafd6c9ac428685bce8285581ba035753deeaa7e0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head></head><body><div><div><div><div class=3D"">The attached demons=
trates the problem, I believe.=C2=A0<br/></div></div><div><div style=3D"dis=
play: none; border: 0px; width: 0px; height: 0px; overflow: hidden; visibil=
ity: hidden;"><img src=3D"https://r.superhuman.com/Q0V0JNWDGDYdgvl2e1R5wRdx=
JvSBoonC6r9gxJW8_Skk74QX2lbZPRvwmTOiD-uD5RRmDLQRFTmIfGCKIPGRHhqc-ZqclEi9BoU=
11wbES_Ph9nfjPeDez2G0G4CBVJhnTBx7GmXmhsB0pdsX-R151LnMnuHZ5xTKGR14QFFjNgxzX_=
bmnQO9UoI.gif" alt=3D" " width=3D"1" height=3D"0" style=3D"display: none; b=
order: 0px; width: 0px; height: 0px; overflow: hidden; visibility: hidden;"=
/><!-- =
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
--></div><br/><div =
class=3D"gmail_signature"><div><br/>Aaron</div><br/></div></div><br/><div><=
div class=3D"gmail_quote">On Mon, Sep 01, 2025 at 9:31 AM, Aaron Jensen <sp=
an dir=3D"ltr"><<a href=3D"mailto:aaronjensen@HIDDEN" target=3D"_blan=
k">aaronjensen@HIDDEN</a>></span> wrote:<br/><blockquote class=3D"gma=
il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef=
t:1ex"><div class=3D"gmail_extra"><div class=3D"gmail_quote sh-color-black =
sh-color"><div class=3D"sh-color-black sh-color"><div class=3D"sh-color-bla=
ck sh-color"><div class=3D"sh-color-black sh-color"><div class=3D"sh-color-=
black sh-color">It's my understanding that=C2=A0the check for set-expli=
citly is done because given where this hook runs, it's possible=C2=A0th=
at the mode variable is not yet initialized, which means=C2=A0that even tho=
ugh it eventually will be, and thus could be relied on, it may not be. Ther=
efore, bind-map relies on similar logic as the minor mode itself to determi=
ne whether or not the minor mode *will eventually* be enabled. It seems lik=
e your proposed patch to bind-map would be subject to this "hook race&#=
34;.<br/></div><div class=3D"sh-color-black sh-color"><br/></div><div class=
=3D"sh-color-black sh-color">Again, this is just an informed guess as I hav=
en't set up the conditions to reproduce it yet.<br/></div><div class=3D=
"sh-color-black sh-color"><br/></div><div class=3D"sh-color-black sh-color"=
>I have extracted the relevant bind-map code to my own library that depende=
d on it:<br/></div><div class=3D"sh-color-black sh-color"><br/></div><div c=
lass=3D"sh-color-black sh-color"><a href=3D"https://github.com/aaronjensen/=
emacs-leader-key/blob/master/leader-key.el#L109" target=3D"_blank" rel=3D"n=
oopener noreferrer" class=3D"sh-color-blue sh-color">https:/<wbr/>/<wbr/>gi=
thub.<wbr/>com/<wbr/>aaronjensen/<wbr/>emacs-leader-key/<wbr/>blob/<wbr/>ma=
ster/<wbr/>leader-key.<wbr/>el#L109</a><br/></div><div class=3D"sh-color-bl=
ack sh-color"><br/></div><div class=3D"sh-color-black sh-color">Currently, =
it still relies on set-explicitly (accepting both forms), but if there'=
s a way that we can get it to not I'd be happy to try it out.<br/></div=
></div><div class=3D"sh-color-black sh-color"></div><br/><div class=3D"gmai=
l_signature sh-color-black sh-color"><div class=3D"sh-color-black sh-color"=
><br/>Aaron</div><br/></div></div><br/><div class=3D"sh-color-black sh-colo=
r"><div class=3D"gmail_quote sh-color-black sh-color">On Mon, Sep 01, 2025 =
at 8:42 AM, Stefan Monnier <span dir=3D"ltr" class=3D"sh-color-black sh-col=
or"><<a href=3D"mailto:monnier@HIDDEN" target=3D"_blank" rel=
=3D"noopener noreferrer" class=3D"sh-color-blue sh-color">monnier@<wbr/>iro=
.<wbr/>umontreal.<wbr/>ca</a>></span> wrote:<br/><blockquote style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" class=3D"gmail=
_quote sh-color-black sh-color"><div class=3D"gmail_extra sh-color-black sh=
-color"><div class=3D"gmail_quote sh-color-black sh-color"><blockquote clas=
s=3D"sh-color-black sh-color"><blockquote class=3D"sh-color-black sh-color"=
><p class=3D"sh-color-black sh-color">
After spending some time looking at the code, its history, and the
corresponding doc, my conclusion is that `bind-map`s code was probably
incorrect already with older Emacsen (just in different ways) and its
intended behavior is far from clear, so I think it's best to leave this
as a WONTFIX and let `bind-map`s authors figure out what to do on
their side (tho I'd be happy to help them figure that out).
</p></blockquote><p class=3D"sh-color-black sh-color">
You don't think we should even restore it and mark it as obsolete?
</p></blockquote><p class=3D"sh-color-black sh-color">
Since I believe bind-map's code was only half-working to begin with: no=
,
I don't think it's worth the trouble. It would just help them
muddle through. I'd rather help them fix their code for good.
</p><p class=3D"sh-color-black sh-color">
Stefan</p></div></div></blockquote></div></div></div></div></div></blockquo=
te></div></div><br/></div></div></body></html>
--c1ba3b375aacd12bb91eafd6c9ac428685bce8285581ba035753deeaa7e0--
--20ec0e412723b91a06483ece301eb13f215a7d9b5286d7bd70264e36e200
Content-Disposition: attachment; filename="repro-evil-local-override-race.el"
Content-Transfer-Encoding: base64
Content-Type: application/octet-stream; name="repro-evil-local-override-race.el"
Ozs7IHJlcHJvLWV2aWwtbG9jYWwtb3ZlcnJpZGUtcmFjZS5lbCAtLS0gUmVwcm8gcmFjZSB3LyBn
bG9iYWxpemVkIG1pbm9yIG1vZGVzIGFuZCBFdmlsIGxvY2FsIG1hcHMgIC0qLSBsZXhpY2FsLWJp
bmRpbmc6IHQ7IC0qLQoKOzsgUnVuIHdpdGg6Cjs7ICAgZW1hY3MgLVEgLS1iYXRjaCAtbCBzY3Jp
cHRzL3JlcHJvLWV2aWwtbG9jYWwtb3ZlcnJpZGUtcmFjZS5lbAoKKHNldHEgbWVzc2FnZS1sb2ct
bWF4IHQpCihkZWZ1biByZXByby1sb2cgKGZtdCAmcmVzdCBhcmdzKQogIChwcmluYyAoYXBwbHkg
Iydmb3JtYXQgKGNvbmNhdCBmbXQgIlxuIikgYXJncykpKQoKOzsgTG9hZCBFdmlsIGZyb20gZWxw
YWNhL2J1aWxkcyAoYWRqdXN0IGlmIHlvdXIgcGF0aCBkaWZmZXJzKQooYWRkLXRvLWxpc3QgJ2xv
YWQtcGF0aCAoZXhwYW5kLWZpbGUtbmFtZSAiZWxwYWNhL2J1aWxkcy9ldmlsIiB1c2VyLWVtYWNz
LWRpcmVjdG9yeSkpCihyZXF1aXJlICdldmlsKQoKOzsgRGVmaW5lIGEgdHJpdmlhbCBjb21tYW5k
IHdlIGJpbmQgdW5kZXIgU1BDIHgKKGRlZnVuIHJlcHJvLXRlc3QtY29tbWFuZCAoKQogIChpbnRl
cmFjdGl2ZSkKICAobWVzc2FnZSAicmVwcm8tdGVzdC1jb21tYW5kIGludm9rZWQiKSkKCjs7IERl
ZmluZSBhIHBlci1idWZmZXIgbWlub3IgbW9kZSBhbmQgYSBnbG9iYWxpemVkIHRvZ2dsZXIKKGRl
ZmluZS1taW5vci1tb2RlIHJlcHJvLW92ZXJyaWRlLW1vZGUKICAiUGVyLWJ1ZmZlciBvdmVycmlk
ZSBtb2RlIChzaW11bGF0ZXMgbGVhZGVyIG92ZXJyaWRlKS4iKQoKKGRlZnVuIHR1cm4tb24tcmVw
cm8tb3ZlcnJpZGUtbW9kZSAoKQogICh1bmxlc3MgKG1pbmlidWZmZXJwKSAocmVwcm8tb3ZlcnJp
ZGUtbW9kZSAxKSkpCgooZGVmaW5lLWdsb2JhbGl6ZWQtbWlub3ItbW9kZSBnbG9iYWwtcmVwcm8t
b3ZlcnJpZGUtbW9kZQogIHJlcHJvLW92ZXJyaWRlLW1vZGUKICB0dXJuLW9uLXJlcHJvLW92ZXJy
aWRlLW1vZGUpCgo7OyBLZXkgYW5kIHN0YXRlIHdlIHdpbGwgaW5zdGFsbCBpbnRvCihkZWZjb25z
dCByZXByby1rZXkgKGtiZCAiU1BDIHgiKSkKKGRlZmNvbnN0IHJlcHJvLXN0YXRlICdub3JtYWwp
Cgo7OyBIZWxwZXIgdG8gY2hlY2sgaWYga2V5IGlzIGluc3RhbGxlZCBpbiB0aGUgY3VycmVudCBi
dWZmZXIncyBsb2NhbCBtYXAKKGRlZnVuIHJlcHJvLWluc3RhbGxlZC1wICgpCiAgKGxldCAoKG1h
cCAoYW5kIChib3VuZHAgJ2V2aWwtbm9ybWFsLXN0YXRlLWxvY2FsLW1hcCkKICAgICAgICAgICAg
ICAgICAgZXZpbC1ub3JtYWwtc3RhdGUtbG9jYWwtbWFwKSkpCiAgICAoYW5kIChrZXltYXBwIG1h
cCkKICAgICAgICAgKGxldCAoKGIgKGxvb2t1cC1rZXkgbWFwIHJlcHJvLWtleSkpKQogICAgICAg
ICAgIChhbmQgYiAobm90IChudW1iZXJwIGIpKSkpKSkpCgo7OyBCcm9rZW4gaW5zdGFsbGVyOiBy
ZXF1aXJlcyBidWZmZXItbG9jYWwgbW9kZSB0byBiZSBvbiAocmFjZXMgYW5kIHNraXBzKQooZGVm
dW4gcmVwcm8tYnJva2VuLWluc3RhbGwgKCkKICAobGV0KiAoKG1vZGUgJ3JlcHJvLW92ZXJyaWRl
LW1vZGUpCiAgICAgICAgIChnbG9iYWwtbW9kZSAnZ2xvYmFsLXJlcHJvLW92ZXJyaWRlLW1vZGUp
CiAgICAgICAgIChtYXAgKGFuZCAoYm91bmRwICdldmlsLW5vcm1hbC1zdGF0ZS1sb2NhbC1tYXAp
CiAgICAgICAgICAgICAgICAgICBldmlsLW5vcm1hbC1zdGF0ZS1sb2NhbC1tYXApKSkKICAgICh3
aGVuIChhbmQgKGJvdW5kcCBnbG9iYWwtbW9kZSkgKHN5bWJvbC12YWx1ZSBnbG9iYWwtbW9kZSkK
ICAgICAgICAgICAgICAgKGJvdW5kcCBtb2RlKSAoc3ltYm9sLXZhbHVlIG1vZGUpCiAgICAgICAg
ICAgICAgIChrZXltYXBwIG1hcCkpCiAgICAgIChkZWZpbmUta2V5IG1hcCByZXByby1rZXkgIydy
ZXByby10ZXN0LWNvbW1hbmQpKSkpCgo7OyBGaXhlZCBpbnN0YWxsZXI6IHByb2NlZWRzIHdoZW4g
Z2xvYmFsIGlzIG9uIHVubGVzcyBleHBsaWNpdGx5IGRpc2FibGVkCihkZWZ1biByZXByby1maXhl
ZC1pbnN0YWxsICgpCiAgKGxldCogKChtb2RlICdyZXByby1vdmVycmlkZS1tb2RlKQogICAgICAg
ICAoZ2xvYmFsLW1vZGUgJ2dsb2JhbC1yZXByby1vdmVycmlkZS1tb2RlKQogICAgICAgICA7OyBF
bWFjcyAzMSs6IDxtb2RlPi0tc2V0LWV4cGxpY2l0bHk7IG9sZGVyOiA8bW9kZT4tc2V0LWV4cGxp
Y2l0bHkKICAgICAgICAgKHNldC1leHAgKGxldCAoKHYxIChpbnRlcm4gKGZvcm1hdCAiJXMtLXNl
dC1leHBsaWNpdGx5IiBtb2RlKSkpCiAgICAgICAgICAgICAgICAgICAgICAgICh2MiAoaW50ZXJu
IChmb3JtYXQgIiVzLXNldC1leHBsaWNpdGx5IiBtb2RlKSkpKQogICAgICAgICAgICAgICAgICAg
IChjb25kICgoYm91bmRwIHYxKSB2MSkKICAgICAgICAgICAgICAgICAgICAgICAgICAoKGJvdW5k
cCB2MikgdjIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgKHQgbmlsKSkpKQogICAgICAgICAo
bWFwIChhbmQgKGJvdW5kcCAnZXZpbC1ub3JtYWwtc3RhdGUtbG9jYWwtbWFwKQogICAgICAgICAg
ICAgICAgICAgZXZpbC1ub3JtYWwtc3RhdGUtbG9jYWwtbWFwKSkpCiAgICAod2hlbiAoYW5kIChi
b3VuZHAgZ2xvYmFsLW1vZGUpIChzeW1ib2wtdmFsdWUgZ2xvYmFsLW1vZGUpCiAgICAgICAgICAg
ICAgIChrZXltYXBwIG1hcCkKICAgICAgICAgICAgICAgKG5vdCAoYW5kIHNldC1leHAgKHN5bWJv
bC12YWx1ZSBzZXQtZXhwKQogICAgICAgICAgICAgICAgICAgICAgICAgKGJvdW5kcCBtb2RlKSAo
bnVsbCAoc3ltYm9sLXZhbHVlIG1vZGUpKSkpKQogICAgICAoZGVmaW5lLWtleSBtYXAgcmVwcm8t
a2V5ICMncmVwcm8tdGVzdC1jb21tYW5kKSkpKQoKOzsgRW5hYmxlIHRoZSBnbG9iYWxpemVkIG92
ZXJyaWRlIG9uY2UgdXAtZnJvbnQKKGdsb2JhbC1yZXByby1vdmVycmlkZS1tb2RlIDEpCgo7OyBD
b21tb24gc2VxdWVuY2UgZm9yIGJvdGggdGVzdHMgKGlkZW50aWNhbCBvcmRlcik6Cjs7IC0gTmV3
IGJ1ZmZlcgo7OyAtIERvIE5PVCB0b3VjaCB0aGUgcGVyLWJ1ZmZlciBtb2RlIHZhciAoaXQgaXMg
bmF0dXJhbGx5IG5pbCBoZXJlKQo7OyAtIEVuYWJsZSBFdmlsIGxvY2FsbHkgKGhvb2sgZmlyZXMg
d2hpbGUgcGVyLWJ1ZmZlciBtb2RlIGlzIHN0aWxsIG5pbCkKCjs7IFNjZW5hcmlvIDE6IEJyb2tl
biBwYXRoIG1pc3NlcyBpbnN0YWxsIGR1ZSB0byByZXF1aXJpbmcgYnVmZmVyLWxvY2FsIG1vZGUK
KHJlbW92ZS1ob29rICdldmlsLWxvY2FsLW1vZGUtaG9vayAjJ3JlcHJvLWJyb2tlbi1pbnN0YWxs
KQoocmVtb3ZlLWhvb2sgJ2V2aWwtbG9jYWwtbW9kZS1ob29rICMncmVwcm8tZml4ZWQtaW5zdGFs
bCkKKGFkZC1ob29rICdldmlsLWxvY2FsLW1vZGUtaG9vayAjJ3JlcHJvLWJyb2tlbi1pbnN0YWxs
KQoKKHdpdGgtdGVtcC1idWZmZXIKICAoZXZpbC1sb2NhbC1tb2RlIDEpCiAgKHJlcHJvLWxvZyAi
QlJPS0VOIGluc3RhbGxlZD8gJVMiIChyZXByby1pbnN0YWxsZWQtcCkpKQoKOzsgU2NlbmFyaW8g
MjogRml4ZWQgcGF0aCBpbnN0YWxscyBkZXNwaXRlIHJhY2UgKG5vIGV4cGxpY2l0IGRpc2FibGUp
CihyZW1vdmUtaG9vayAnZXZpbC1sb2NhbC1tb2RlLWhvb2sgIydyZXByby1icm9rZW4taW5zdGFs
bCkKKGFkZC1ob29rICdldmlsLWxvY2FsLW1vZGUtaG9vayAjJ3JlcHJvLWZpeGVkLWluc3RhbGwp
Cgood2l0aC10ZW1wLWJ1ZmZlcgogIChldmlsLWxvY2FsLW1vZGUgMSkKICAocmVwcm8tbG9nICJG
SVhFRCBpbnN0YWxsZWQ/ICAlUyIgKHJlcHJvLWluc3RhbGxlZC1wKSkpCgo7OzsgcmVwcm8tZXZp
bC1sb2NhbC1vdmVycmlkZS1yYWNlLmVsIGVuZHMgaGVyZQo=
--20ec0e412723b91a06483ece301eb13f215a7d9b5286d7bd70264e36e200--
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 1 Sep 2025 16:31:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 01 12:31:27 2025
Received: from localhost ([127.0.0.1]:58343 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ut7RG-0000aI-WA
for submit <at> debbugs.gnu.org; Mon, 01 Sep 2025 12:31:27 -0400
Received: from mail-vk1-xa2f.google.com ([2607:f8b0:4864:20::a2f]:59469)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>)
id 1ut7RD-0000a3-Mj
for 79305 <at> debbugs.gnu.org; Mon, 01 Sep 2025 12:31:24 -0400
Received: by mail-vk1-xa2f.google.com with SMTP id
71dfb90a1353d-544a55b84d8so519030e0c.2
for <79305 <at> debbugs.gnu.org>; Mon, 01 Sep 2025 09:31:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1756744277; x=1757349077; darn=debbugs.gnu.org;
h=references:to:subject:message-id:from:in-reply-to:cc:date
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=g0LAB3dChPU4el6HldnygqUBHXJwCk7p0ZYqUhIhSvc=;
b=Jg+ZrGrC19VC6bkFTX5elibkfp1dY+iGZ3pwGoaRZbAdQyKCkEKf/gmz/bnduYu3gB
T0ADEvBVD24+riFmBFzeuQTIfdbGhbNV9Uq3xk9RVRBOvsRYo+FZUbPFsOxM7/vD24um
qKOm8BlN2WRfyopEbfoOYfZ50JWziIElSztmftxxnIE68Jl3lQeQyOEiXBkYSM9oYJYf
T0nSn6MHzgTKvpKmk4aPGEofufK0PEUsjGkR5ReBpFa24W/Zveez5aCPngCxWhvkhcp7
J+PV1JOm8omMkUNIoEywB2IA7AnYVb7QVOI5PRw35TgTJdPu6KzaEWXYkW44XAFw/3jU
miEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1756744277; x=1757349077;
h=references:to:subject:message-id:from:in-reply-to:cc:date
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=g0LAB3dChPU4el6HldnygqUBHXJwCk7p0ZYqUhIhSvc=;
b=vbR0msfRLqQIZDLLE9BZbuSYQQXHl263j5JV/13/kBA2j5E4ftEuWl73wBSAiDWv1f
NG2wAYARmDBGUIpxoMjmXWhUGpK7WBxdUmMvVyYWPivwgKo4+2BPIWMyzRua/n6ZpRUh
usnJd5BzbGXvdH3buzzFZlnbgKL01fsbzak+X9KiyO4j+PiBB8t7+zY/GIitTJOfhvoo
APcw6SEJNXZzK0tXyZjLVKENBrY+hadTWa1ae1K9I4Ffh2Zd26QM3nt9uBUHSCj9Br88
x1QImh5PhGyTwYRR+iBvM0aWI9nZw9NpvtyIijK7OPTEyHpN1T2ZGcXQtAl9WvqraFDn
t0vA==
X-Forwarded-Encrypted: i=1;
AJvYcCVgOHSBLFi+PsBgk0q4rWSWwxN/Y+Hredb2HJ5I9G5gjzSnvLwJR2oecy3vlUW/Yx2osBZetA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyyTeW2oMFVmMCr0bp5GloZfEGkw4Ue5dc7INtmHUIAW7CBayEb
UecYWPFNesWby/l1OyXA0N1ihmWme3qBhtZjb7YTmigjlsjfVBb3V+KYelMpRg==
X-Gm-Gg: ASbGncsdVzTGBL4TAtCBZXUilfXdhJ8WdsK7B2AVNamU91qtjkN9wz4QiSiOPzQXf+k
98xgegAE3NWGQhKAJoru2EOVcDntNvKbdPz8L1p4cHtjxb9EX9SnYBbJ9W91DCdU7KHsveQki2x
wVtd38bV5kPQWHX7pUQu8mkrvIzkbtTmLpsfSD9g2lOVsrl22gyxpxgbvQNwB1MBBAOcxGlKvmS
BPrwJWTqVe1kc7y4RT00yr8htmZzIXKpldnF7j06yjAEWrrHZFSgOjWEnWztN1XnER6W6VRKODD
SYCRWTdMNDTK6m1Z3hx4OXIHHEISVRdfIGFPdCba87JTLry4Nh/pDRUbk56NB6awwcjgVL2hG3W
Ki3yzufY8B72DkclbTOSEHRzKoqd5BPcUOoE5V6Gm/wsw/6X0Y7QBolsJwVzDa3SlN4Y=
X-Google-Smtp-Source: AGHT+IGoh94rqw1Wo5PhqzzCdhyqSbPcJxhQUQ90E7kyToDEqRgJX+SjO3HHqxtq5XWHejzQ/UaBtQ==
X-Received: by 2002:a05:6122:2205:b0:539:3bb5:e4c8 with SMTP id
71dfb90a1353d-544a02dd6f6mr2066122e0c.12.1756744277287;
Mon, 01 Sep 2025 09:31:17 -0700 (PDT)
Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0])
by smtp.gmail.com with UTF8SMTPSA id
71dfb90a1353d-544a666da0csm2540654e0c.28.2025.09.01.09.31.16
for <79305 <at> debbugs.gnu.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Mon, 01 Sep 2025 09:31:17 -0700 (PDT)
Mime-Version: 1.0
Date: Mon, 01 Sep 2025 16:31:13 +0000
X-Superhuman-Draft-ID: draft008fb26a3a81ff7d
In-Reply-To: <jwv7byi6v1a.fsf-monnier+emacs@HIDDEN>
From: "Aaron Jensen" <aaronjensen@HIDDEN>
Message-ID: <mf1bq5pb.bcf07cca-6f18-4b0d-95d3-7b4d53d75cd8@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
To: "Stefan Monnier" <monnier@HIDDEN>
X-Mailer: Superhuman Desktop (2025-08-29T23:31:37Z)
X-Superhuman-ID: mf1c6dqh.874b9838-4008-4cfd-b34f-262534558247
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
<jwvbjnu945l.fsf-monnier+emacs@HIDDEN>
<87zfbeimvq.fsf@HIDDEN>
<jwv7byi6v1a.fsf-monnier+emacs@HIDDEN>
Content-Type: multipart/alternative;
boundary=d5c3b899325be2dc5c2e5327ac045806ca3a43b2d8dfd8029193606a3f42
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79305
Cc: Justin Burkett <justin@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>,
79305 <at> debbugs.gnu.org, Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--d5c3b899325be2dc5c2e5327ac045806ca3a43b2d8dfd8029193606a3f42
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
It's my understanding that=C2=A0the check for set-explicitly is done becaus=
e given where this hook runs, it's possible=C2=A0that the mode variable is =
not yet initialized, which means=C2=A0that even though it eventually will b=
e, and thus could be relied on, it may not be. Therefore, bind-map relies o=
n similar logic as the minor mode itself to determine whether or not the mi=
nor mode *will eventually* be enabled. It seems like your proposed patch to=
bind-map would be subject to this "hook race".
Again, this is just an informed guess as I haven't set up the conditions to=
reproduce it yet.
I have extracted the relevant bind-map code to my own library that depended=
on it:
https://github.com/aaronjensen/emacs-leader-key/blob/master/leader-key.el#L=
109
Currently, it still relies on set-explicitly (accepting both forms), but if=
there's a way that we can get it to not I'd be happy to try it out.
Aaron
On Mon, Sep 01, 2025 at 8:42 AM, Stefan Monnier < monnier@HIDDEN =
> wrote:
>=20
>=20
>>=20
>>>=20
>>>=20
>>> After spending some time looking at the code, its history, and the
>>> corresponding doc, my conclusion is that `bind-map`s code was probably
>>> incorrect already with older Emacsen (just in different ways) and its
>>> intended behavior is far from clear, so I think it's best to leave this=
as
>>> a WONTFIX and let `bind-map`s authors figure out what to do on their si=
de
>>> (tho I'd be happy to help them figure that out).
>>>=20
>>>=20
>>=20
>>=20
>>=20
>> You don't think we should even restore it and mark it as obsolete?
>>=20
>>=20
>=20
>=20
>=20
> Since I believe bind-map's code was only half-working to begin with: no, =
I
> don't think it's worth the trouble. It would just help them muddle
> through. I'd rather help them fix their code for good.
>=20
>=20
>=20
> Stefan
>=20
>=20
>
--d5c3b899325be2dc5c2e5327ac045806ca3a43b2d8dfd8029193606a3f42
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head></head><body><div><div><div><div class=3D"">It's my underst=
anding that=C2=A0the check for set-explicitly is done because given where t=
his hook runs, it's possible=C2=A0that the mode variable is not yet ini=
tialized, which means=C2=A0that even though it eventually will be, and thus=
could be relied on, it may not be. Therefore, bind-map relies on similar l=
ogic as the minor mode itself to determine whether or not the minor mode *w=
ill eventually* be enabled. It seems like your proposed patch to bind-map w=
ould be subject to this "hook race".<br/></div><div class=3D""><br/=
></div><div class=3D"">Again, this is just an informed guess as I haven'=
;t set up the conditions to reproduce it yet.<br/></div><div class=3D""><br=
/></div><div class=3D"">I have extracted the relevant bind-map code to my o=
wn library that depended on it:<br/></div><div class=3D""><br/></div><div><=
a href=3D"https://github.com/aaronjensen/emacs-leader-key/blob/master/leade=
r-key.el#L109">https://github.com/aaronjensen/emacs-leader-key/blob/master/=
leader-key.el#L109</a><br/></div><div><br/></div><div>Currently, it still r=
elies on set-explicitly (accepting both forms), but if there's a way th=
at we can get it to not I'd be happy to try it out.<br/></div></div><di=
v><div style=3D"display: none; border: 0px; width: 0px; height: 0px; overfl=
ow: hidden; visibility: hidden;"><img src=3D"https://r.superhuman.com/oDg4y=
W9ToP51Wnpp8GXYyvvPByHAKNpzyPPCbbgPD38_-7ize8lWcFITb5LYspwBgbpCLOFPoR_nsBib=
UgYKanvkg1YGKVAVFy8e3n5NSdFJAIsK6As25JQz1YSi24Aiu2x_q9gTyBSyCBY2pOOMA9kyP4o=
SeihZ1_1CyctO9g5yQLcO2bBtt1c.gif" alt=3D" " width=3D"1" height=3D"0" style=
=3D"display: none; border: 0px; width: 0px; height: 0px; overflow: hidden; =
visibility: hidden;"/><!-- =
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
--></div><br/><div class=3D"gmail_signature"><div><br/>Aaron</div><br/></d=
iv></div><br/><div><div class=3D"gmail_quote">On Mon, Sep 01, 2025 at 8:42 =
AM, Stefan Monnier <span dir=3D"ltr"><<a href=3D"mailto:monnier@HIDDEN=
treal.ca" target=3D"_blank">monnier@HIDDEN</a>></span> wrote:<=
br/><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef=
t:1px #ccc solid;padding-left:1ex"><div class=3D"gmail_extra"><div class=3D=
"gmail_quote sh-color-black sh-color"><blockquote class=3D"sh-color-black s=
h-color"><blockquote class=3D"sh-color-black sh-color"><p class=3D"sh-color=
-black sh-color">
After spending some time looking at the code, its history, and the
corresponding doc, my conclusion is that `bind-map`s code was probably
incorrect already with older Emacsen (just in different ways) and its
intended behavior is far from clear, so I think it's best to leave this
as a WONTFIX and let `bind-map`s authors figure out what to do on
their side (tho I'd be happy to help them figure that out).
</p></blockquote><p class=3D"sh-color-black sh-color">
You don't think we should even restore it and mark it as obsolete?
</p></blockquote><p class=3D"sh-color-black sh-color">
Since I believe bind-map's code was only half-working to begin with: no=
,
I don't think it's worth the trouble. It would just help them
muddle through. I'd rather help them fix their code for good.
</p><p class=3D"sh-color-black sh-color">
Stefan</p></div></div></blockquote></div></div><br/></div></div></body></ht=
ml>
--d5c3b899325be2dc5c2e5327ac045806ca3a43b2d8dfd8029193606a3f42--
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 1 Sep 2025 15:42:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 01 11:42:19 2025
Received: from localhost ([127.0.0.1]:58247 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ut6fj-0003ut-2H
for submit <at> debbugs.gnu.org; Mon, 01 Sep 2025 11:42:19 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6574)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1ut6fg-0003uf-CK
for 79305 <at> debbugs.gnu.org; Mon, 01 Sep 2025 11:42:16 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 61856100383;
Mon, 1 Sep 2025 11:42:10 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1756741329;
bh=OH1IgFVkElb7RmoQVXqP3EmZNuer4Ww8Rvk1rxlOOOk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=kWDx9ULRc8XWMeXIYWHe+Dn5CdorEv7on/tO7TQcOqGkhvqdzH3q2sE6Xb7mzMHpG
mLpg9U1dVMB2T181VL5ElM6omfh7P38RoHsqbdKBtJegUy+Zv1esZ41UCnEHmhsHkS
83Bs4pyCIqMpJNBf1kKFs6peCVvrWsOev2rShvjc6RyQPf9gUkAgmS6Jkibid2Li8/
MBlk3RGPcd8h4DrWqdEmakvN2CcSfPr5h/xwbdhHwuoP4B7CXV4GuITnomQNhCojEU
mLO3HX4OW1eB/Xcp63UCXQKPRvEgKOEwx2ysmnVOUFZP1HQDbLW0iqMDTE4IDULmFl
zDCwN/IKgXrMw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 801CB10024D;
Mon, 1 Sep 2025 11:42:09 -0400 (EDT)
Received: from alfajor (69-165-161-194.dsl.teksavvy.com [69.165.161.194])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 40B001204B0;
Mon, 1 Sep 2025 11:42:09 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
In-Reply-To: <87zfbeimvq.fsf@HIDDEN>
Message-ID: <jwv7byi6v1a.fsf-monnier+emacs@HIDDEN>
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
<jwvbjnu945l.fsf-monnier+emacs@HIDDEN>
<87zfbeimvq.fsf@HIDDEN>
Date: Mon, 01 Sep 2025 11:42:08 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.102 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79305
Cc: Jonas Bernoulli <jonas@HIDDEN>, 79305 <at> debbugs.gnu.org,
Aaron Jensen <aaronjensen@HIDDEN>, Justin Burkett <justin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> After spending some time looking at the code, its history, and the
>> corresponding doc, my conclusion is that `bind-map`s code was probably
>> incorrect already with older Emacsen (just in different ways) and its
>> intended behavior is far from clear, so I think it's best to leave this
>> as a WONTFIX and let `bind-map`s authors figure out what to do on
>> their side (tho I'd be happy to help them figure that out).
> You don't think we should even restore it and mark it as obsolete?
Since I believe bind-map's code was only half-working to begin with: no,
I don't think it's worth the trouble. It would just help them
muddle through. I'd rather help them fix their code for good.
Stefan
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.Received: (at 79305) by debbugs.gnu.org; 1 Sep 2025 08:43:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 01 04:43:37 2025 Received: from localhost ([127.0.0.1]:56636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ut08X-0003su-9D for submit <at> debbugs.gnu.org; Mon, 01 Sep 2025 04:43:37 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:48674) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1ut08T-0003sg-Gy for 79305 <at> debbugs.gnu.org; Mon, 01 Sep 2025 04:43:34 -0400 DKIM-Signature: a=rsa-sha256; b=AQ1PzPEEO+3YCT+ABqxGLyZ9cbKG5YW9ECdCiIb/H1V1ZEBBQzYrVb/8dwFUQbaXGr0rf7gwFaRJcB2ZBFl5LKVhZWdOaPCZ1jKj1gznZxfEitY3Ay0dQWkpBh/Ttr9rX4ww9jHV3TWByQIh7R4LE7d3umdnLtFt5ipWSbeYvRuBlOBl+wiTzHmGKWnJL5sewEsOLYuh6lNMoMiMWWnebiWE3aNJa6p3oWLgDdXyVHPohLadwzi8IeO8nQXbTORx2tuJt62CGBdQTQgTGEzrsuD6nnsQaDkaW6aNkyjjGShmuwCMcK1RRctu5XZOVJaiSDAUfB07gMZlUpwqvE4X5A==; s=purelymail1; d=spwhitton.name; v=1; bh=k94QPqBDgL77GqTEdU1u0c0W/IsIDRcgHNjSDYdwe1A=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=El0U5MO6RKgwxzN2IYVwaeuGXxgiL6D4tyKznzFouQTOGc4FUm+PU2iNUFb5FfoeM5dMzlClZ/DIiegvXFu4xYsFXfoVFSWc5ubcbt+oP+8xbr942sI7UbhlQh180njcaJrqmFU3wrER3JD4aI2jULOAi3qjJ+iqfbU4vnSuoyq1pnhDV+8PkmDek9UjVUrpA9GBUuYto3qqxA9Q7LddTSS2a91dEHLXao1sQEzRGTLp8d0eT+4zAYS6seXB14CpyRSiaK2Qe015Yi7gffRt7UIZkeWwkrDLkhE6ePLgaoAS9p5KeLUSQfWLorIRfuk8f64sAC3nkyLB+gIP92DOJA==; s=purelymail1; d=purelymail.com; v=1; bh=k94QPqBDgL77GqTEdU1u0c0W/IsIDRcgHNjSDYdwe1A=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79305 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -465763797; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 01 Sep 2025 08:43:21 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 3064D9405FB; Mon, 01 Sep 2025 09:43:21 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused regressions in bind-map In-Reply-To: <jwvbjnu945l.fsf-monnier+emacs@HIDDEN> References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN> <jwvh5xq42cd.fsf-monnier+emacs@HIDDEN> <jwvbjnu945l.fsf-monnier+emacs@HIDDEN> Date: Mon, 01 Sep 2025 09:43:21 +0100 Message-ID: <87zfbeimvq.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 79305 Cc: Jonas Bernoulli <jonas@HIDDEN>, 79305 <at> debbugs.gnu.org, Aaron Jensen <aaronjensen@HIDDEN>, Justin Burkett <justin@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Hello, On Mon 01 Sep 2025 at 12:49am -04, Stefan Monnier wrote: > After spending some time looking at the code, its history, and the > corresponding doc, my conclusion is that `bind-map`s code was probably > incorrect already with older Emacsen (just in different ways) and its > intended behavior is far from clear, so I think it's best to leave this > as a WONTFIX and let `bind-map`s authors figure out what to do on > their side (tho I'd be happy to help them figure that out). You don't think we should even restore it and mark it as obsolete? Thanks for looking into it btw. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 1 Sep 2025 04:50:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 01 00:50:05 2025
Received: from localhost ([127.0.0.1]:56107 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uswUW-0000Ir-Kv
for submit <at> debbugs.gnu.org; Mon, 01 Sep 2025 00:50:05 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30638)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uswUT-0000ID-CZ
for 79305 <at> debbugs.gnu.org; Mon, 01 Sep 2025 00:50:02 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BE43C44030B;
Mon, 1 Sep 2025 00:49:54 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1756702189;
bh=TJjgP+5pKDk0gU2cejdAz0/fCS/BWMxyt26/zL5WcD0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=BCPkTdLiyfj8HAFVX1c574GuEDDBAt3ILo56RmCQifBI+ziCbLkG2Z8ZD2vpKhfId
KRLh9X0xKmRaJIdU0/+IS9lwHZ2Z7eN+Ypvv68k4LSJ2F22o9mDku3/fLYp2DaZBDJ
eRsKBH6IGgA5s9unTLC3AqsZmqE26wfQj2/sA20azmidlwZG1sZgQjfCSNBAVv47CT
SoP+fzpWEBw5Lwi+Wq//NPN1OberV82mml+KFSM6RQUQOH7EJQ8FFqQFStj0NlMP9K
D0ZikVLfdBN2Wdq5m20I37uq7NbEsCdMXVRdHP5Er+uLsvzhYLomKajtO13g2OwT5w
YjfUtnztJJWgg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 539754403DA;
Mon, 1 Sep 2025 00:49:49 -0400 (EDT)
Received: from alfajor (69-165-161-194.dsl.teksavvy.com [69.165.161.194])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 14124120387;
Mon, 1 Sep 2025 00:49:49 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
In-Reply-To: <jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
Message-ID: <jwvbjnu945l.fsf-monnier+emacs@HIDDEN>
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
Date: Mon, 01 Sep 2025 00:49:48 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.061 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79305
Cc: Jonas Bernoulli <jonas@HIDDEN>, 79305 <at> debbugs.gnu.org,
Aaron Jensen <aaronjensen@HIDDEN>, Justin Burkett <justin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> bind-map shouldn't use an internal variable like that.
> +1, tho maybe bind-map has a good reason to do that.
> Does anyone know something about that?
After spending some time looking at the code, its history, and the
corresponding doc, my conclusion is that `bind-map`s code was probably
incorrect already with older Emacsen (just in different ways) and its
intended behavior is far from clear, so I think it's best to leave this
as a WONTFIX and let `bind-map`s authors figure out what to do on
their side (tho I'd be happy to help them figure that out).
The best patch I could come up with is the one below.
Stefan
diff --git a/bind-map.el b/bind-map.el
index 41e6e5b5f0..204748efe8 100644
--- a/bind-map.el
+++ b/bind-map.el
@@ -171,19 +171,17 @@ be activated.")
(when properties (pop properties)))))
(defun bind-map-evil-local-mode-hook ()
- "Called to activate local state maps in a buffer."
+ "Activate local state maps in a buffer." ;; FIXME: Which buffer?
;; format is (OVERRIDE-MODE STATE KEY DEF)
(dolist (entry bind-map-evil-local-bindings)
(let* ((map (intern (format "evil-%s-state-local-map" (nth 1 entry))))
(mode (nth 0 entry))
- (global-mode (intern (format "global-%s" (nth 0 entry))))
- (set-explicitly (intern (format "%s-set-explicitly" mode))))
- (when (and (boundp global-mode) (boundp mode)
- (boundp set-explicitly) (boundp map)
+ ;; FIXME: Why do we care about an associated global mode?
+ (global-mode (intern (format "global-%s" mode))))
+ (when (and (boundp global-mode) (boundp mode) (boundp map)
(keymapp (symbol-value map))
(symbol-value global-mode)
- (not (and (symbol-value set-explicitly)
- (null (symbol-value mode)))))
+ (symbol-value mode))
(define-key (symbol-value map) (nth 2 entry) (nth 3 entry))))))
(add-hook 'evil-local-mode-hook 'bind-map-evil-local-mode-hook)
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 31 Aug 2025 18:22:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 31 14:22:10 2025
Received: from localhost ([127.0.0.1]:55266 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1usmgr-00020X-FU
for submit <at> debbugs.gnu.org; Sun, 31 Aug 2025 14:22:10 -0400
Received: from mail-ua1-x92b.google.com ([2607:f8b0:4864:20::92b]:52337)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>)
id 1usmgm-0001zw-1e
for 79305 <at> debbugs.gnu.org; Sun, 31 Aug 2025 14:22:07 -0400
Received: by mail-ua1-x92b.google.com with SMTP id
a1e0cc1a2514c-8920c579f98so1045066241.0
for <79305 <at> debbugs.gnu.org>; Sun, 31 Aug 2025 11:22:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1756664518; x=1757269318; darn=debbugs.gnu.org;
h=cc:date:from:references:to:subject:message-id:in-reply-to
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=eYNdLmOMRz2bVOClqnuMsxzbD+4Ybmaisym3Nz0gvmw=;
b=Rt8AxRErmaAiAFLhgviM0IVZW8y3wq1DBINBnomv7+n5sGsgtEPllKuoHftm8Gu5yf
PGvCvJIiLKjUEj2ZWRCFC0k2OEjvNb7IR7poGvhaa8vrOfFsFmWWbwQmmctE/fq2+/vg
pnZXYrl71XIB++0/7btyfl4IIlIZ+bBNOL9yHITRLiyCC6kJjEjEeQ6LKZs0JLA63zqL
G/JUyyaOUTfSJ0UhqitUv6OdG0SXy4aICyONjM4zzMBefbPGyrlvIu8nb2lOss2UPa+D
8+75/UXRiMz1wty9TsNHEFLi4U4fBNFWxnVmZciCOiRjJPDfqR39y4x5o8Q1bYdGpQp4
7nzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1756664518; x=1757269318;
h=cc:date:from:references:to:subject:message-id:in-reply-to
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=eYNdLmOMRz2bVOClqnuMsxzbD+4Ybmaisym3Nz0gvmw=;
b=RSS28/rBNdpUgoviyd+rnSqDGHQHpx1fSFv5RCtLnX9NNDI4LD/xQ1o09MiXyWNHWK
tVviO8+R4xaBWlSfBqrP5EulPA+I5c7f/F8GdiaENh346RyNzYgRT+YQl4E1fhCBB8SU
QKjkz3EBRHfs1Xj8hrdwvM0WkHAy4yZ6xuGFInrnCZHVVh8F6aI9O3plXSmfxOVtfO8L
HUuJ9bzpNDQj2GS0JKLFeDu1u/jJF8XRERpI/keMugsCBlYDljutCG8n3gAu9ZGd6S3f
xOqT40yqSYnOZtcnjniDFKLTTSlbsPL6jXZjbSiy7P9X02jgcxuCGVhnaeM+k1ymNvtp
3UyA==
X-Forwarded-Encrypted: i=1;
AJvYcCWw908ZvfkiCRXbhzs6KpMBdLUwKLBK9QY66Z0aGEjIujTtOzgnHtxt5pzPzjUA6iuLnfM5Lg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz9B4g9/LIcIKTKc7Z6KUi4E3jqTujADH82a2zpHiaEy9UO54aD
sYEvG7mY7Q8yzC6baPyQxZbBnfPXaa/xxBKKIeijHdhdztfhmeR20uPN9gTTZQ==
X-Gm-Gg: ASbGnct5dK/s/gU/1jj11vjLjUsR4fvTlgDm8epBX7H2yqHgFian/XISQ/b9EXmG5Dp
quyFHtu+YP432LAEEQ0XCLwSkkX+ztbxYATIJMPBMMql7qq0nzGjBu4NIZPUQIrrvooCb+6b294
FqIROD1wWqTICIShEwpODv0Eu8+BIRT2wYPd+Ru5F9PelK+WskP5JSv/qjMndjRMHNncgqvi5As
y6OcAPwZQkNvgMsr+l2WFiq3RdHYSZIyXn+9n9ULJZHC3xbpSq3U8tICfrAPiJx6yEBKQUHnDbt
n/ZHHpF6ZTdNBJQe/71TpSeCitl6+QVDFmGhicpbgTTCBltG3CHT5kUlKDHL7t8Jva9ohKnDTk0
Q7n0kU3dt2+jkhMzvqUYN/dMwHQPm+Au0yd+mthdEKJLcTO1Zw9HdoBhchK9HHRegTLY=
X-Google-Smtp-Source: AGHT+IGV4MlSxu4oFvplCVW7ZQd0XrL5SrSR1TBj+QX7jhOYk5CTPZ1EN+F54I+y3b9if7TdWJTBzw==
X-Received: by 2002:a05:6102:6889:b0:52a:1ff2:da15 with SMTP id
ada2fe7eead31-52b1a483dddmr1421470137.15.1756664517686;
Sun, 31 Aug 2025 11:21:57 -0700 (PDT)
Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0])
by smtp.gmail.com with UTF8SMTPSA id
ada2fe7eead31-52aef458ebasm2380161137.4.2025.08.31.11.21.56
for <79305 <at> debbugs.gnu.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 31 Aug 2025 11:21:56 -0700 (PDT)
Mime-Version: 1.0
X-Mailer: Superhuman Desktop (2025-08-29T23:31:37Z)
X-Superhuman-Draft-ID: draft005be781a81f160e
In-Reply-To: <87plcbldlr.fsf@HIDDEN>
Message-ID: <mf00i51d.4412a9a2-dbf2-453b-8ed7-e4e1a5344928@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
To: "Sean Whitton" <spwhitton@HIDDEN>
X-Superhuman-ID: mf00ojlb.8604424e-99db-40f4-8fb9-37c2efa7fd9a
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
<mex1jwb5.0186f519-2de4-46a5-84d2-c26902db990f@HIDDEN>
<87plcbldlr.fsf@HIDDEN>
From: "Aaron Jensen" <aaronjensen@HIDDEN>
Date: Sun, 31 Aug 2025 18:21:50 +0000
Content-Type: multipart/alternative;
boundary=46212a15b66f47b7b2bd16e7f491b54df69f33a3ae597eac5d63dad944f1
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79305
Cc: Jonas Bernoulli <jonas@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>, 79305 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--46212a15b66f47b7b2bd16e7f491b54df69f33a3ae597eac5d63dad944f1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Hi Sean,
I believe it's using it only to determine whether or not to apply a key map=
to a minor mode. Specifically, it's attempting to detect the state when th=
e global minor mode is enabled but that it is disabled explicitly=C2=A0in t=
he given buffer. I have no idea why it doesn't just look at the value of th=
e mode variable, which, as far as I understand it, would be made buffer loc=
al and nil in that same case. There must be some circumstance where that va=
riable will not yet be set or buffer local and would have led to false indi=
cations.
Without the original author or specific tests for that scenario, I couldn't=
say anything for sure. I'd be fine with your proposal to restore the varia=
ble and mark it obsolete. I'm not sure that the original author of bind-map=
is very active anymore. I can update this bug if I hear anything from bind=
-map folks.
Thanks,
Aaron
On Sun, Aug 31, 2025 at 8:23 AM, Sean Whitton < spwhitton@HIDDEN > =
wrote:
>=20
>=20
>=20
> Hello,
>=20
>=20
>=20
> On Fri 29 Aug 2025 at 04:23pm GMT, Aaron Jensen wrote:
>=20
>=20
>>=20
>>=20
>> On Fri, Aug 29 , 2025 at 7:43 AM, Stefan Monnier < monnier@ iro. umontre=
al.
>> ca ( monnier@HIDDEN ) > wrote:
>>=20
>>=20
>>=20
>> bind-map shouldn't use an internal variable like that.
>>=20
>>=20
>>=20
>> +1, tho maybe bind-map has a good reason to do that. Does anyone know
>> something about that?
>>=20
>>=20
>>=20
>> It was in a commit with this message:
>>=20
>>=20
>>=20
>> Fix evil-local-mode-hook logic
>> Can't be sure that the override modes are enabled before this hook is ru=
n
>> so we check if the global mode is enabled and if the local mode is set
>> explicitly in a prior hook (presumably a major mode hook).
>>=20
>>=20
>>=20
>> https:/ / github. com/ justbur/ emacs-bind-map/ commit/ 89747f7240e5f510=
84fd94aad502d67f426e03b4
>> (
>> https://github.com/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94a=
ad502d67f426e03b4
>> )
>>=20
>>=20
>=20
>=20
>=20
> Thanks for the link. Unfortunately it seems like it would take a lot of
> evil-mode knowledge to really know what's going on there.
>=20
>=20
>=20
> Let me ask about the original purpose of the -set-explicitly machinery.
> The comments say that the idea is that if the major mode hook has
> (global-foo-mode -1), then our hook in after-change-major-mode-hook won't
> undo that.
>=20
>=20
>=20
> Major mode hooks are generally for the user. So the idea is that this is
> primarily a way for the user to disable the global minor mode in
> particular major modes. Right?
>=20
>=20
>=20
> It looks to me that what emacs-bind-map is trying to use -set-explicitly
> for is not that, but something about hook ordering. So it's using it for
> some other purpose, so it is probably using the wrong mechanism.
>=20
>=20
>=20
> I think therefore in the absence of more information on the evil-mode
> stuff, we should go ahead with restoring the variable but marking it as
> obsolete.
>=20
>=20
>=20
> --
> Sean Whitton
>=20
>=20
>
--46212a15b66f47b7b2bd16e7f491b54df69f33a3ae597eac5d63dad944f1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head></head><body><div><div><div><div class=3D"">Hi Sean,<br/></div>=
<div class=3D""><br/></div><div class=3D"">I believe it's using it only=
to determine whether or not to apply a key map to a minor mode. Specifical=
ly, it's attempting to detect the state when the global minor mode is e=
nabled but that it is disabled explicitly=C2=A0in the given buffer. I have =
no idea why it doesn't just look at the value of the mode variable, whi=
ch, as far as I understand it, would be made buffer local and nil in that s=
ame case. There must be some circumstance where that variable will not yet =
be set or buffer local and would have led to false indications.<br/></div><=
div class=3D""><br/></div><div class=3D"">Without the original author or sp=
ecific tests for that scenario, I couldn't say anything for sure. I'=
;d be fine with your proposal to restore the variable and mark it obsolete.=
I'm not sure that the original author of bind-map is very active anymo=
re. I can update this bug if I hear anything from bind-map folks.<br/></div=
><div class=3D""><br/></div><div class=3D"">Thanks,</div></div><div><div st=
yle=3D"display: none; border: 0px; width: 0px; height: 0px; overflow: hidde=
n; visibility: hidden;"><img src=3D"https://r.superhuman.com/1a-X_dP9G9txNh=
HjVCsdlNBL49LdbskROAO9lPmR5fSnTfyxddZ5NOGNNpy7w5oRxi2A2siaO7UdcbN1JnL5QsHTT=
JTmTyj1i7L7isxAZHfC3wbMH_OR5P1fzfQdBr9ZY-kM8SaJcgQIJy5wYctURKQCh4q_7YjkKuPL=
6ttrmX_NBSyejOvNt0w.gif" alt=3D" " width=3D"1" height=3D"0" style=3D"displa=
y: none; border: 0px; width: 0px; height: 0px; overflow: hidden; visibility=
: hidden;"/><!-- =
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
--></div>=
<br/><div class=3D"gmail_signature"><div><br/>Aaron</div><br/></div></div><=
br/><div><div class=3D"gmail_quote">On Sun, Aug 31, 2025 at 8:23 AM, Sean W=
hitton <span dir=3D"ltr"><<a href=3D"mailto:spwhitton@HIDDEN" ta=
rget=3D"_blank">spwhitton@HIDDEN</a>></span> wrote:<br/><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc s=
olid;padding-left:1ex"><div class=3D"gmail_extra"><div class=3D"gmail_quote=
sh-color-black sh-color"><p class=3D"sh-color-black sh-color">Hello,
</p><p class=3D"sh-color-black sh-color">
On Fri 29 Aug 2025 at 04:23pm GMT, Aaron Jensen wrote:
</p><blockquote class=3D"sh-color-black sh-color"><p class=3D"sh-color-blac=
k sh-color">
<span class=3D"sh-date sh-color-black sh-color" data-date-isostring=3D"2025=
-08-29">On Fri, Aug 29</span>, 2025 at 7:43 AM, Stefan Monnier <<a targe=
t=3D"_blank" rel=3D"noopener noreferrer" href=3D"mailto:monnier@HIDDEN=
al.ca" class=3D"sh-color-blue sh-color">monnier@<wbr/>iro.<wbr/>umontreal.<=
wbr/>ca</a>>
wrote:
</p><p class=3D"sh-color-black sh-color">
bind-map shouldn't use an internal variable like that.
</p><p class=3D"sh-color-black sh-color">
+1, tho maybe bind-map has a good reason to do that. Does anyone know
something about that?
</p><p class=3D"sh-color-black sh-color">
It was in a commit with this message:
</p><p class=3D"sh-color-black sh-color">
Fix evil-local-mode-hook logic
<br/>
Can't be sure that the override modes are enabled before this hook is
run so we check if the global mode is enabled and if the local mode is
set explicitly in a prior hook (presumably a major mode hook).
</p><p class=3D"sh-color-black sh-color">
<a target=3D"_blank" rel=3D"noopener noreferrer" href=3D"https://github.com=
/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94aad502d67f426e03b4" cl=
ass=3D"sh-color-blue sh-color">https:/<wbr/>/<wbr/>github.<wbr/>com/<wbr/>j=
ustbur/<wbr/>emacs-bind-map/<wbr/>commit/<wbr/>89747f7240e5f51084fd94aad502=
d67f426e03b4</a>
</p></blockquote><p class=3D"sh-color-black sh-color">
Thanks for the link. Unfortunately it seems like it would take a lot of
evil-mode knowledge to really know what's going on there.
</p><p class=3D"sh-color-black sh-color">
Let me ask about the original purpose of the -set-explicitly machinery.
The comments say that the idea is that if the major mode hook has
<br/>
(global-foo-mode -1), then our hook in after-change-major-mode-hook
won't undo that.
</p><p class=3D"sh-color-black sh-color">
Major mode hooks are generally for the user. So the idea is that this
is primarily a way for the user to disable the global minor mode in
particular major modes. Right?
</p><p class=3D"sh-color-black sh-color">
It looks to me that what emacs-bind-map is trying to use -set-explicitly
for is not that, but something about hook ordering. So it's using it
for some other purpose, so it is probably using the wrong mechanism.
</p><p class=3D"sh-color-black sh-color">
I think therefore in the absence of more information on the evil-mode
stuff, we should go ahead with restoring the variable but marking it as
obsolete.
</p><p class=3D"sh-color-black sh-color">
--=20
<br/>
Sean Whitton</p></div></div></blockquote></div></div><br/></div></div></bod=
y></html>
--46212a15b66f47b7b2bd16e7f491b54df69f33a3ae597eac5d63dad944f1--
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.Received: (at 79305) by debbugs.gnu.org; 31 Aug 2025 15:23:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 31 11:23:29 2025 Received: from localhost ([127.0.0.1]:54646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1usjtw-0008Bb-Jn for submit <at> debbugs.gnu.org; Sun, 31 Aug 2025 11:23:28 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:49190) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1usjtr-0008BL-Ue for 79305 <at> debbugs.gnu.org; Sun, 31 Aug 2025 11:23:26 -0400 DKIM-Signature: a=rsa-sha256; b=jBuaUpyyINKNjbwRP3v2EPyhn5iJlfM8zMU1RH8xNvfj1R2GzmsNS2bEHZKBSj1JHwe3neGqkF515QBLe3nMHWJ9nFluTcD3B07/pp5S1f/8r+zffZNdxp0ZvejmM4ifmdjGht+AlXDDw9tCOUhTGcliEYuwSX6OcMC5F5qjyYQuubthX1mwEhtvczNUaPhycwO80VhXdkBVCCpg3AIPa57CmFhtyrRUNnNmHsU6Lwooa6Ea4+MPLbMdOwK2qoSrOtk9iaCfQmf0O2WE5p+F63qJVGbzPkYE2hQv7p/MhpvJJxNBARg/DFQmjI/BO6Br6aHcIQ3zupNrS6BS61wrmg==; s=purelymail1; d=spwhitton.name; v=1; bh=l2drehDj32isFKLgEPF3G1N6yk/LVKzGd8gZb5IkvzM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=JebBpbwk+KnHq360oNPTfqXvWhekFHQp/OK7TVY6WHYpLo3RDBNQ2bFgwZ3RZZnnXqaFW1EzQVvyAaLX+aeSCliIhYh8f5Cot1crcQTGIzWUqjzkdyKA2q/KFFnsO3Wjbo3GIQv7+1l3nLw9CF01T+xpZdOy/QOg+1HxKOT0wXLDqziVG4vny3b8jvlkuvgwMYSFyJMYp1vK2e8Me+8AxhOCf7RvgpuX5IjJLQUoc4hl4B3M9QZWgKdrxvHpfy/5LF46fFb3KWn5Lzp1LAh6c8SfUmTA3YGvVhxWc68bwMYFLtwUs+9EqNs2zdrUQWlfa4le0WqBLdgMRSUtyfklxA==; s=purelymail1; d=purelymail.com; v=1; bh=l2drehDj32isFKLgEPF3G1N6yk/LVKzGd8gZb5IkvzM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79305 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1472107988; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 31 Aug 2025 15:23:13 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id D006F94014B; Sun, 31 Aug 2025 16:23:12 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: "Aaron Jensen" <aaronjensen@HIDDEN> Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused regressions in bind-map In-Reply-To: <mex1jwb5.0186f519-2de4-46a5-84d2-c26902db990f@HIDDEN> References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN> <jwvh5xq42cd.fsf-monnier+emacs@HIDDEN> <mex1jwb5.0186f519-2de4-46a5-84d2-c26902db990f@HIDDEN> Date: Sun, 31 Aug 2025 16:23:12 +0100 Message-ID: <87plcbldlr.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 79305 Cc: Jonas Bernoulli <jonas@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 79305 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Hello, On Fri 29 Aug 2025 at 04:23pm GMT, Aaron Jensen wrote: > On Fri, Aug 29, 2025 at 7:43 AM, Stefan Monnier <monnier@HIDDEN> > wrote: > > bind-map shouldn't use an internal variable like that. > > +1, tho maybe bind-map has a good reason to do that. Does anyone know > something about that? > > It was in a commit with this message: > > Fix evil-local-mode-hook logic > Can't be sure that the override modes are enabled before this hook is > run so we check if the global mode is enabled and if the local mode is > set explicitly in a prior hook (presumably a major mode hook). > > https://github.com/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94aad502d67f426e03b4 Thanks for the link. Unfortunately it seems like it would take a lot of evil-mode knowledge to really know what's going on there. Let me ask about the original purpose of the -set-explicitly machinery. The comments say that the idea is that if the major mode hook has (global-foo-mode -1), then our hook in after-change-major-mode-hook won't undo that. Major mode hooks are generally for the user. So the idea is that this is primarily a way for the user to disable the global minor mode in particular major modes. Right? It looks to me that what emacs-bind-map is trying to use -set-explicitly for is not that, but something about hook ordering. So it's using it for some other purpose, so it is probably using the wrong mechanism. I think therefore in the absence of more information on the evil-mode stuff, we should go ahead with restoring the variable but marking it as obsolete. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 29 Aug 2025 16:23:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 29 12:23:47 2025
Received: from localhost ([127.0.0.1]:43015 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1us1tC-0000HK-MU
for submit <at> debbugs.gnu.org; Fri, 29 Aug 2025 12:23:47 -0400
Received: from mail-ua1-x92b.google.com ([2607:f8b0:4864:20::92b]:47484)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>)
id 1us1t8-0000Fh-H1
for 79305 <at> debbugs.gnu.org; Fri, 29 Aug 2025 12:23:43 -0400
Received: by mail-ua1-x92b.google.com with SMTP id
a1e0cc1a2514c-895c4657d34so326121241.3
for <79305 <at> debbugs.gnu.org>; Fri, 29 Aug 2025 09:23:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1756484615; x=1757089415; darn=debbugs.gnu.org;
h=cc:to:message-id:from:references:subject:date:in-reply-to
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=JQR8j7urbPP7zf4modcNE0bAZi22CRb7ZRvck6PUX6Y=;
b=Tx6TjVnOXZTLr3A+8gKSilo+cYX6iusuI6PSUdZcx1EhY/vRmNb+4H2Q1+LZozaELo
QeImzlHkU2mz2dCrSqHqdiE79NwyJt5sALQJULkIZpf5UzYrhAKnwTkVlXmQ5F8UOws8
uhV17jXMoHh0DLDPbGfcWLB6gM6fK6CKVdR7VRKMjMf8ajESPt9BEmdo/cjHFedndr0U
AJnDhXrWDOMC1MbOIzchdxqRnKlhniKzLZieF77QDq0aC436X7L0AhIFAw/IAwPIkBId
O/EveQHX/SFniAY8GA3gMR+OrF8N5qcjpFqWCWYoNH1r3nJ2KC5YIZm8QhbvHM8qkS1a
5RLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1756484615; x=1757089415;
h=cc:to:message-id:from:references:subject:date:in-reply-to
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=JQR8j7urbPP7zf4modcNE0bAZi22CRb7ZRvck6PUX6Y=;
b=JeQmm0E0woZ1GVYJQxFefabVNCGelvTE6NuE6fimVkgob13cl9Mkeg7+lqTUmz5kvl
gMcN3Ftv9vuLmAfKlPaJtefzLCVHXBbrzP60FrtB+yHP5+s/0Pj9HMHztWWP3mLaiVxk
BDkNJmjnmICpIj+xMxEH4t2uontetLXFX6aStVmxZdgqOjYmKpxVNHGU2DFTPqMAr7E5
mZuHhyEdVsKXC1/7NgXasKQ224DuuBU5b7kKoiH6CAYlBuJp7fbM136fkq8TvushR4BC
hc62Q5kPoH1KeB59H1ezvs3CDy4OkhPLEudcdst29FIwS3SCQ+wNcUPA8n9U9tdRjeDh
qnbA==
X-Forwarded-Encrypted: i=1;
AJvYcCWe1oxCr70bf/TxpGaLyCqrQpKD2frgg9pXYUABvSC1sCXuCEzNWmECukeyaDFUIbMa/VPmdQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw3krpIoiKvrRzolmYUtG9D5vKpIbHC0IZUb6GCpNkORzqB9bj3
3HgAqkkFw5YoZlNsY9eURpEMsHYQvPlqVBFhPv1A8DjsNVbcpG4L4P3sLdqHUQ==
X-Gm-Gg: ASbGncvl1BN2SPVNNihUcVJY26THmO4pFfpNcesSL9Kv9fl4GM2c97hN4Mo6RQuSg4T
CIrZj/MP4KAvbtDRsKxAwXJhBqHoBlf4xi3YAhTnSn1R3MyfUIohcRdDTFS/MOXvam2jh28H06x
BWUwJGnPzQia1Y4fJ1tqm/EcX8VjCu95GogPRpovtVRGKD4LwWUeeyXMH3MnpH7JfzYHpgK2LFw
aYOEKpkDC5UUwuIbfp5A+fbMp/79GbKDe/8wUNH2P4tRYbsplU93kHprZLdP/0Zbn/awPBvvLUh
W+oKfvEisjLA+bXoJiSSqPe44vEBrt3f/8msSz9zsT1aC2My7d8KGflgR+Q80gk48hLwnH0OvyE
tMnzqu5byDySOaPqu21mgmLnNX53pyWEBtoyzzeZyBdc1cW0gYLRbn1L8
X-Google-Smtp-Source: AGHT+IEViK3tIocOeDi6I6t0mPT5Ah84Sqr5JCOhBWYQdWvto2SY1GEVLYnSPnzIYI4FDDEv4NK6sg==
X-Received: by 2002:a05:6102:509f:b0:521:b9f2:a5dc with SMTP id
ada2fe7eead31-521b9f2ab59mr7970204137.25.1756484615328;
Fri, 29 Aug 2025 09:23:35 -0700 (PDT)
Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0])
by smtp.gmail.com with UTF8SMTPSA id
ada2fe7eead31-529ac24c6f3sm1238010137.0.2025.08.29.09.23.34
for <79305 <at> debbugs.gnu.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Fri, 29 Aug 2025 09:23:35 -0700 (PDT)
Mime-Version: 1.0
X-Mailer: Superhuman Desktop (2025-08-25T19:06:01Z)
X-Superhuman-ID: mex1kokm.e3fb8841-8884-4776-9f76-875a2cda53a7
In-Reply-To: <jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
Date: Fri, 29 Aug 2025 16:23:31 +0000
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
X-Superhuman-Draft-ID: draft0099ce492dfd4ea2
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
<jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
From: "Aaron Jensen" <aaronjensen@HIDDEN>
Message-ID: <mex1jwb5.0186f519-2de4-46a5-84d2-c26902db990f@HIDDEN>
To: "Stefan Monnier" <monnier@HIDDEN>
Content-Type: multipart/alternative;
boundary=a87264bc87222c1d82ae655842fbece2f9e57c83a01729a72566b45b01ef
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79305
Cc: Jonas Bernoulli <jonas@HIDDEN>, 79305 <at> debbugs.gnu.org,
Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--a87264bc87222c1d82ae655842fbece2f9e57c83a01729a72566b45b01ef
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
On Fri, Aug 29, 2025 at 7:43 AM, Stefan Monnier < monnier@HIDDEN =
> wrote:
>=20
>=20
>>=20
>>=20
>> bind-map shouldn't use an internal variable like that.
>>=20
>>=20
>>=20
>=20
>=20
>=20
> +1, tho maybe bind-map has a good reason to do that. Does anyone know
> something about that?
>=20
>=20
>=20
>=20
It was in a commit with this=C2=A0message:
Fix evil-local-mode-hook logic
Can't be sure that the override modes are enabled before this hook is
run so we check if the global mode is enabled and if the local mode is
set explicitly in a prior hook (presumably a major mode hook).
https://github.com/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94aad5=
02d67f426e03b4
--a87264bc87222c1d82ae655842fbece2f9e57c83a01729a72566b45b01ef
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head></head><body><div><div><div class=3D""><div class=3D""><div cla=
ss=3D""><div class=3D""><span style=3D"background-color: rgba(0, 0, 0, 0); =
color: rgba(0, 0, 0, 0.6);">On Fri, Aug 29, 2025 at 7:43 AM, Stefan Monnier=
</span><span dir=3D"ltr" class=3D""><<a href=3D"mailto:monnier@HIDDEN=
treal.ca" target=3D"_blank" class=3D"">monnier@HIDDEN</a>></sp=
an><span style=3D"background-color: rgba(0, 0, 0, 0); color: rgba(0, 0, 0, =
0.6);"> wrote:</span><br/></div></div></div><div class=3D"sh-quoted-content=
"><div class=3D""><div class=3D"gmail_quote"><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
><div class=3D"gmail_extra"><div class=3D"gmail_quote"><blockquote class=3D=
""><p class=3D"">
bind-map shouldn't use an internal variable like that.
<br/></p></blockquote><p class=3D"">
+1, tho maybe bind-map has a good reason to do that.
Does anyone know something about that?<br/></p></div></div></blockquote></d=
iv></div></div></div><div><div><br/></div><div>It was in a commit with this=
=C2=A0message:<br/></div></div><div><br/></div><div>Fix evil-local-mode-hoo=
k logic<br/></div><div>Can't be sure that the override modes are enable=
d before this hook is<br/></div><div>run so we check if the global mode is =
enabled and if the local mode is<br/></div><div>set explicitly in a prior h=
ook (presumably a major mode hook).<br/></div><div><br/></div><div><a href=
=3D"https://github.com/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94=
aad502d67f426e03b4">https://github.com/justbur/emacs-bind-map/commit/89747f=
7240e5f51084fd94aad502d67f426e03b4</a><br/></div></div><div><div style=3D"d=
isplay: none; border: 0px; width: 0px; height: 0px; overflow: hidden; visib=
ility: hidden;"><img src=3D"https://r.superhuman.com/xzrCATkgySIvNf94RVrk4C=
l5YH2wdJAds8f0NmaGyXacStl8qvIHeI1ukm1TmiuB9qWdl_HZYfEvttEXmkePzFwIykFWpXGFF=
llJSe9dGUlvl5P3pmdTrTqRg95AGl86U4E8UVP1CJukIwwJ7hvKy2D2NBkf0Oat5Xi_wykM0SVN=
807I4U7_1_8.gif" alt=3D" " width=3D"1" height=3D"0" style=3D"display: none;=
border: 0px; width: 0px; height: 0px; overflow: hidden; visibility: hidden=
;"/><!-- =
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
--></div></div></=
div></body></html>
--a87264bc87222c1d82ae655842fbece2f9e57c83a01729a72566b45b01ef--
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at 79305) by debbugs.gnu.org; 29 Aug 2025 14:44:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 29 10:44:09 2025
Received: from localhost ([127.0.0.1]:42755 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1us0Km-0002WL-O4
for submit <at> debbugs.gnu.org; Fri, 29 Aug 2025 10:44:09 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15123)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1us0Ki-0002Uh-8u
for 79305 <at> debbugs.gnu.org; Fri, 29 Aug 2025 10:44:05 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6F1D54415AD;
Fri, 29 Aug 2025 10:43:57 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1756478636;
bh=8Wk3Vgtlb2Cv8FdejoDPl8iX2lHqzfHAFmwmJ3/VQNI=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=augMVzAfh2YWttdNWWMu3o9to+dl3SCemSkwJpSr/nWutMjv29Ci1hsKsBSmfteOm
x5NM5THOIwjymzdSbVDvqBd/ePZNs4bpfA40z12wZA/NidKV2U4vdTeRmrxu6HBLcD
VSuuwbc+tmpKH51jk5pcB9bP37ciGhbd9iT1xM/FVG5k+8JSRsdfK48jlgxYA9ZJl/
4tNcmG1zZ5gps+RTOeDUJUuiprNp6BSCIkhOM7UNZxb9b4qTpQS46YlUtvE/zw9L54
Co7YUo5THd1jqAnhQWEqfU0GlctSbjbIycQhfZWX6ynpV0+dJwBLO3qD0P+rnM/97L
xMfUNfVQ6HVGQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8E4D74415A3;
Fri, 29 Aug 2025 10:43:56 -0400 (EDT)
Received: from asado (unknown [10.35.229.186])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F86312049C;
Fri, 29 Aug 2025 10:43:56 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
regressions in bind-map
In-Reply-To: <87zfbjswpo.fsf@HIDDEN>
Message-ID: <jwvh5xq42cd.fsf-monnier+emacs@HIDDEN>
References: <m2zfbojrec.fsf@HIDDEN> <87zfbjswpo.fsf@HIDDEN>
Date: Fri, 29 Aug 2025 10:43:44 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79305
Cc: Jonas Bernoulli <jonas@HIDDEN>, 79305 <at> debbugs.gnu.org,
Aaron Jensen <aaronjensen@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> bind-map shouldn't use an internal variable like that.
+1, tho maybe bind-map has a good reason to do that.
Does anyone know something about that?
Stefan
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.Received: (at 79305) by debbugs.gnu.org; 28 Aug 2025 07:59:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 28 03:59:50 2025 Received: from localhost ([127.0.0.1]:38180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1urXXw-0003TN-BS for submit <at> debbugs.gnu.org; Thu, 28 Aug 2025 03:59:50 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:45358) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1urXXt-0003SE-Ii for 79305 <at> debbugs.gnu.org; Thu, 28 Aug 2025 03:59:46 -0400 DKIM-Signature: a=rsa-sha256; b=YR+Zej5HIWZIaW8ibvG3VxWZdT86Dicg3bSH6TrLkiVFWVffWpQBxHAC30P8Cie9IR/dGlVcIRkzXvs7R3IXTW2Wzvlo91iE/q0bYSKOVXH2wYX5Hb1z4PB1IfI61jGRNoOFj9OpmVAym4OechrLiuc0pkh7OEIcuZQI/JNLJcGkYK/30C6WHxsMsoZu0rsO/y+A5ojTh1CP0b1kTiIM9WFqiRnrQARXGn8aZpcXHr8PfCeeXs8E1yOPeDp1n5RW+zkNITHTIm8VLD6b/mav3lxtTOTdDpfh51Kdx8zx3PO8cYUNNlUY8s4X3jZnbfxV96jwwWmJkGAROJWP/G9I7g==; s=purelymail1; d=spwhitton.name; v=1; bh=SyHlw8R6rvVuruwWypSFBfhsCWBNZlCoPbE7xbC8HKo=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=f3/yMlf64Rp8TnRasIOuYYTV9bmTMLM+MnZkJKyZIeQDqc1cxStcHqVWWcKZ5AsNxeuUnFYVd1xOs4bp3dHABI1yjSaliHy+YQYnelpHZ5dakOT+Cf6KDcfts/+c79yb0Eb050B+/UoaGnG+dUtpiZmtP4PxdZ4R633Nsw4JPdisALEAsRIaRVn2UW01/0lGWFOim3mqqSOkWtQn6u+7PPI+jzZvfd0prUS0ehByfMIfCNYbau3JrzZwlkz/pNX5vrhkT8VMzebiGxs08Yu/3oRX2UAVO24LmAnmfPARoLKzWgxUOB2IA6kkwls1tZJw7re/AJNENJWax80WgMb4GA==; s=purelymail1; d=purelymail.com; v=1; bh=SyHlw8R6rvVuruwWypSFBfhsCWBNZlCoPbE7xbC8HKo=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79305 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1963478348; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Aug 2025 07:59:32 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 1DCBB940A0F; Thu, 28 Aug 2025 08:59:31 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Aaron Jensen <aaronjensen@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN> Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused regressions in bind-map In-Reply-To: <m2zfbojrec.fsf@HIDDEN> References: <m2zfbojrec.fsf@HIDDEN> Date: Thu, 28 Aug 2025 08:59:31 +0100 Message-ID: <87zfbjswpo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79305 Cc: 79305 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Thanks. This was not intended to be a breaking change. On Sun 24 Aug 2025 at 03:17pm -07, Aaron Jensen wrote: > This may be as expected as it sounds like MODE-set-explicitly is meant > to be internal, but I wanted to report it in case regressions were not > expected. > > The change: > https://github.com/emacs-mirror/emacs/commit/c05ea64d8268315093673f8be29d4ceb92198b81 > > The 3rd-party library's use of *-set-explicitly: > https://github.com/justbur/emacs-bind-map/blob/f23cfc13222a39e686d28a83ff83e9901d8908b2/bind-map.el#L180 > > After the change, bind-map no longer successfully overrides maps. I > don't know the specifics of why it doesn't work, but correcting the > formatting of the name to use the format string "%s--set-explicitly" > restores functionality. > > I've opened an issue in bind-map so that it can be addressed there if > that's appropriate. Please feel free to close this if this is expected > and acceptable. bind-map shouldn't use an internal variable like that. If there is no other way for bind-map to achieve what it needs, and we think what it is trying to do is a reasonable interaction with define-globalized-minor-mode, we should undo the renaming of the variable. Otherwise we should declare the variable obsolete instead of just renaming it outright, so that any other third party package authors have a chance to make updates. Stefan, Jonas, what do you think? -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 26 Aug 2025 15:54:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 26 11:54:12 2025
Received: from localhost ([127.0.0.1]:56224 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uqvzw-0007ck-D2
for submit <at> debbugs.gnu.org; Tue, 26 Aug 2025 11:54:12 -0400
Received: from lists.gnu.org ([2001:470:142::17]:41502)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>)
id 1uqvzp-0007bu-52
for submit <at> debbugs.gnu.org; Tue, 26 Aug 2025 11:54:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <aaronjensen@HIDDEN>)
id 1uqvzY-0004vx-Nt
for bug-gnu-emacs@HIDDEN; Tue, 26 Aug 2025 11:53:48 -0400
Received: from mail-vk1-xa31.google.com ([2607:f8b0:4864:20::a31])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <aaronjensen@HIDDEN>)
id 1uqvzO-0004UC-QG
for bug-gnu-emacs@HIDDEN; Tue, 26 Aug 2025 11:53:47 -0400
Received: by mail-vk1-xa31.google.com with SMTP id
71dfb90a1353d-53b17531009so1762890e0c.3
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Aug 2025 08:53:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1756223609; x=1756828409; darn=gnu.org;
h=date:message-id:cc:to:subject:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=aLKpAQLosQH4tYE8hcpnoLjh9yjSSWubZeTO0cLmLUY=;
b=gLpncEBpTPP4ZowPjDhqQaBq4DwAtn/T0KSLQ1ccOQ0bTX2sJ6pjAZEkOu+aFsjJRQ
B8npopdXas+oQLq1TI5MaqmoGktlpDixI4WPU8sBqV4zUZqcvCtIFN3KHX/FhfT17yAF
uZi8X7FU2kVSAIwyT/GRdzhC95Mtt8b/QqgUA5d21u0HR+/myNbj376RWuX4vYpSVbYN
Hy6o6d78yxcML3sDSj0Z9d/ez1HxaHzC+szXeOJsOnueiQ2qJ5W3AJyKYSKXFGx0hHJc
YRqYM5z6QVEjR4TYmi3ypiiY3ycO4fjvLNTv+/HW4Dx/VXBzXr0KC+xCFd2RNFSMK0dK
hJng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1756223609; x=1756828409;
h=date:message-id:cc:to:subject:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=aLKpAQLosQH4tYE8hcpnoLjh9yjSSWubZeTO0cLmLUY=;
b=bv8OjBCXuKT42WUdx6Iyasn/0+5KiQ/VAMxKf3TXcbCG8IY1QHNpqC3iJzOX+9xWkn
JMwYrvWT+IeLyJmR3yxKPukaAG4LUdiUW+vkY5fdQAYkM7P45b3E6tpc4cFoN1KAUYAB
NltlP85bcaIvqn2XC4lZiupHtg3jJyQKe1ONwScS4GxYXbzE8RWD69IO3VH+3qn0YtaK
TYm4gAs+BaCkZJ1TaNwbX1kSVbeB1L8HdulBsT38brfCLzSzTHwWQVqI2cFJ37fdUNE7
m6fyVQvfn+pCvyt0J39DrVYoxVM1c+q6BXN7rDcpG+RHwuQZCQsQdyORE045pSsL5ddw
pCDw==
X-Gm-Message-State: AOJu0YxNdfqUkoIzBCnu/IXI0WKFbj4sd3ZuVoX9beGXe+4yOJhL/g4n
jhl+AmanoN1ZEq2CrwzbaqjvvsDtD9UFwLnqwLVo2lvXxEqvm7Y3q0kYY72Buw==
X-Gm-Gg: ASbGncvGjOD0sTNkQm1N8Z35wXig00GjTV+4eM1+TrivbWoT9di4hdS0LZyZ93Mh82j
RlE0ZJgLZFdAmgY50nHTcGpkl+YG34ifqLUtb6Ozpnnk55cBlhdOKPG79EHe6Qu+DT0alRT/xnP
W+1KFImAflAzqH3h3rTixASKfGRgjwqQhOZ1r+u9Di5+A+Ipwm49RwQJLvHWWibT2qpczQxgOrD
xHMb9qTO0Ob1FXpPi4k2uEl1TADi7NxMETY71qof+1dlEqO/r2XxNpc6Z9DlGeQsO1OtX1jigvM
idHfmKkVV/1vOlEU9TDwUp/wJqwMKF9+GFSi4xuzQHtyRUcEs7C1rlz5hZntMFVN7kkijg1Tkfw
kqMFD+HdVlwXXhlORUOMUI1f78PU0UCHtckzk7qFrYjLliVrD4wwZ/kw8
X-Google-Smtp-Source: AGHT+IEjJCjvsvB8xTWw9u0+Hj1/ym59Y1t7992N2DwRqYPn/KjftsOXYyUo8z5Eb6nKKmMdOMGaoA==
X-Received: by 2002:a05:6122:510:b0:542:59a2:72e6 with SMTP id
71dfb90a1353d-54259a27774mr1930279e0c.6.1756223608859;
Tue, 26 Aug 2025 08:53:28 -0700 (PDT)
Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0])
by smtp.gmail.com with UTF8SMTPSA id
71dfb90a1353d-54430552516sm40687e0c.22.2025.08.26.08.53.28
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Tue, 26 Aug 2025 08:53:28 -0700 (PDT)
Mime-Version: 1.0
From: "Aaron Jensen" <aaronjensen@HIDDEN>
Subject: bug#79305: 31.0.50; MODE-set-explicitly change caused regressions
in bind-map
To: "Emacs Bugs" <bug-gnu-emacs@HIDDEN>
Message-ID: <mesq47kk.aab2e132-9af6-4a69-bce9-32f67ce6b512@HIDDEN>
X-Mailer: Superhuman Desktop (2025-08-25T19:06:01Z)
X-Superhuman-ID: mesq6fyv.488cc1ec-9691-4b25-a524-573e55f2d190
X-Superhuman-Draft-ID: draft00b3eaa6643c5015
X-Superhuman-Thread-ID: draft00ff033402cddd44
X-Entity-Ref-ID: mesq6fyv.488cc1ec-9691-4b25-a524-573e55f2d190
Date: Tue, 26 Aug 2025 15:53:27 +0000
Content-Type: multipart/alternative;
boundary=a7e5c83e95a71de9308b0d4af71182558baa82a2fa4489a5f52b96ad44a2
Received-SPF: pass client-ip=2607:f8b0:4864:20::a31;
envelope-from=aaronjensen@HIDDEN; helo=mail-vk1-xa31.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: spwhitton@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--a7e5c83e95a71de9308b0d4af71182558baa82a2fa4489a5f52b96ad44a2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Adding Sean, the author of the commit, as I forgot to CC them initially.
Aaron
--a7e5c83e95a71de9308b0d4af71182558baa82a2fa4489a5f52b96ad44a2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head></head><body><div><div><div class=3D""><div class=3D""><div cla=
ss=3D"">Adding Sean, the author of the commit, as I forgot to CC them initi=
ally.</div></div><div class=3D"sh-signature"><div class=3D"gmail_signature"=
><div class=3D""><br/>Aaron<br/></div></div></div></div></div><div><div sty=
le=3D"display: none; border: 0px; width: 0px; height: 0px; overflow: hidden=
; visibility: hidden;"><img src=3D"https://r.superhuman.com/rLDEFAO3WKa93pi=
CC7BnZNm2vz-M4-R469NdfxoCnfKiJpMHbpyxcMuPXzjxilQ3EGC38yE-M-Wt7ra89gatvT6z1n=
eFtt45hgdVJbg2I1W9IaddKpZp4eRtjvKJGpT3_93kwaE9j-w90psE6siQx-nyLgykbX1sd7-VT=
uN7ru0lH8Nk-NLY0t8.gif" alt=3D" " width=3D"1" height=3D"0" style=3D"display=
: none; border: 0px; width: 0px; height: 0px; overflow: hidden; visibility:=
hidden;"/><!-- =
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
=
--></div><=
/div></div></body></html>
--a7e5c83e95a71de9308b0d4af71182558baa82a2fa4489a5f52b96ad44a2--
bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 24 Aug 2025 22:18:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 24 18:18:04 2025 Received: from localhost ([127.0.0.1]:47279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uqJ2J-0005d2-Nm for submit <at> debbugs.gnu.org; Sun, 24 Aug 2025 18:18:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45458) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <aaronjensen@HIDDEN>) id 1uqJ2H-0005cT-5Y for submit <at> debbugs.gnu.org; Sun, 24 Aug 2025 18:18:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <aaronjensen@HIDDEN>) id 1uqJ2A-0004Ph-Re for bug-gnu-emacs@HIDDEN; Sun, 24 Aug 2025 18:17:54 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <aaronjensen@HIDDEN>) id 1uqJ28-00049b-W0 for bug-gnu-emacs@HIDDEN; Sun, 24 Aug 2025 18:17:54 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-76e2ea933b7so3253787b3a.1 for <bug-gnu-emacs@HIDDEN>; Sun, 24 Aug 2025 15:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756073870; x=1756678670; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=i9gvBclr6WDpH9qx6JmIbtjpFSI6ZesB7fltCCfMfaE=; b=OO2RANej6AqWkaY/vaZ5odzQv7r4C+r1lqyN0xf6UMpTg2rwfOLUTdjrJyDUSwTx0j PFocjyBVOqXCVng7nB3YZY/PRPKMfwbscJYyhKImafUkixGtLK2FznLrTZnJ70jTsh/v MhCnNUxIstD0FVtPreizx0l2nScD6CVPWu8k+yb/wfD+uUR0VszWK2GmxvcGez37ctc4 Tu+HR0ROwxHEQ17gZYz21v5X7KQgvsNnDs/I+N3yw/Gtr7WswumWaKf8XEcqsA+evleX /0h1kqKqvMXAqcowB/ltNVvMFi4//fASiAtoOns8mYhV/D0oMMsFZ7xzw8PF6wrOqnik eNug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756073870; x=1756678670; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i9gvBclr6WDpH9qx6JmIbtjpFSI6ZesB7fltCCfMfaE=; b=GyeOkd2ma3KHiVgms7KK+SWjrnq2yC3gKbniErQfPeeLZK/WLUjGuEZJy3wI43PIOf Qi5SmhTLPeITq+tzpkbnPsAt37yXqGExVCP5PtfB3j1XARSmOjYZcKuW1Sppjt61KaSP SbGnrWSuBpCfUS6I/JE4q6rracSmoFCDWtaiapo4ndSL6VmlgSOlkRTKghLQUEZJxp1o D3Dx+AemdGqav39C9LWseh1iusKpurxuKS+B7aiiPkXfSGf9ZDhzPqrBB+HHd5n7e72u dB6R4VvE77RCleA39u8cGSKqRRFvozmjwtyau/AXCQQOye2069YNdankKk9WOzVRbzf5 sXeQ== X-Gm-Message-State: AOJu0YwuG+oOScNfmfy3UNudWNZVIy5KqZX2IJpwg+NiR3Nebhx3d0wZ /v1GCdWqWsgLt7CLykah5vp2GP1M2tb2TT0yGG59aSdn8BuzAbaVw4QsdObh9/K3 X-Gm-Gg: ASbGncvoA82l2ELLfVF4/3ZAf1SGwBSgYMIaj3eTc6UQjgsUTruXcvYslmgBvbvWkXp SJWWoS9SHXFJRZuBXkglyTyGSrJu1SpzjODDOsS5FyFZfwq2SG+uKvRIuHwPsb8l3JMqsl1W3vB YRb3QY4NhnlEbL05Kvxha5rbjC5Nbb+P6g9sUZRJgUTosrUux/7Ak22UTfGpO9wwszY5H62nxAV 6aSCiyMHFqARqXjB1k8bjaENRvmQRQu0pHn2f0s4fkw57r49gfZFwSFAL8KrSRA1aKLbWU2icOC fiDRl/4KprhP/hTffBEC9KcUpHHjcvuF5HB0CHfZU25AQVJqp0A1uqGvhAf3eS6MCeIbapytp1r QoEODeY0ZnC74caNMnFAa8P80Y3WjPZ6WiQ9Gd6dpsKJr3f2Dp5rKtmqLYSP3hen9mB+1o8jZe9 OaTGAoK4UqEAaIhw== X-Google-Smtp-Source: AGHT+IHZBaECkW2Ew8F5zpMPU2jXImZWtAjXAyMfJmAvAoO0ygXo2Bjdc4tNjZDOsNbL8t8KfbOSmA== X-Received: by 2002:a05:6a00:4d09:b0:746:1d29:5892 with SMTP id d2e1a72fcca58-76ea2ff7516mr10931104b3a.4.1756073869466; Sun, 24 Aug 2025 15:17:49 -0700 (PDT) Received: from Aarons-MacBook-Pro-3.local (c-24-16-32-241.hsd1.wa.comcast.net. [24.16.32.241]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-770401afdaesm5434062b3a.53.2025.08.24.15.17.48 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 15:17:48 -0700 (PDT) From: Aaron Jensen <aaronjensen@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 31.0.50; MODE-set-explicitly change caused regressions in bind-map X-Debbugs-Cc: Date: Sun, 24 Aug 2025 15:17:47 -0700 Message-ID: <m2zfbojrec.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=aaronjensen@HIDDEN; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) This may be as expected as it sounds like MODE-set-explicitly is meant to be internal, but I wanted to report it in case regressions were not expected. The change: https://github.com/emacs-mirror/emacs/commit/c05ea64d8268315093673f8be29d4ceb92198b81 The 3rd-party library's use of *-set-explicitly: https://github.com/justbur/emacs-bind-map/blob/f23cfc13222a39e686d28a83ff83e9901d8908b2/bind-map.el#L180 After the change, bind-map no longer successfully overrides maps. I don't know the specifics of why it doesn't work, but correcting the formatting of the name to use the format string "%s--set-explicitly" restores functionality. I've opened an issue in bind-map so that it can be addressed there if that's appropriate. Please feel free to close this if this is expected and acceptable. Thank you, Aaron
Aaron Jensen <aaronjensen@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79305; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.