GNU logs - #79426, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79426: diagnostic with empty range => preceding char is highlighted
Resent-From: Alan Donovan <adonovan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Sep 2025 22:09:01 +0000
Resent-Message-ID: <handler.79426.B.17575421047198 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 79426 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Alan Donovan <adonovan@HIDDEN>
Date: Wed, 10 Sep 2025 18:07:56 -0400
Message-ID: <CAPVWWDWORKGynC=jcq80J2ZJEEwmO=dCtZN8OVvYPH0uEWL7PA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::130;
 envelope-from=adonovan@HIDDEN; helo=mail-il1-x130.google.com
X-Spam_score_int: -175
X-Spam_score: -17.6
X-Spam_bar: -----------------
X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5,
 USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

(from https://github.com/joaotavora/eglot/issues/27#issuecomment-3275571619)

The fix for issue #27 (zero-width ranges) included this code:

                       ;; Fallback to `flymake-diag-region' if server
                       ;; botched the range
                       (when (= beg end)
(if-let* ((st (plist-get range :start))
  (diag-region
   (flymake-diag-region
    (current-buffer) (1+ (plist-get st :line))
    (plist-get st :character))))
    (setq beg (car diag-region) end (cdr diag-region))
  (eglot--widening
   (goto-char (point-min))
   (setq beg
 (eglot--bol
  (1+ (plist-get (plist-get range :start) :line))))
   (setq end
 (line-end-position
  (1+ (plist-get (plist-get range :end) :line)))))))

This causes Emacs to highlight the character before the indicated
range, which is often an irrelevant blank space, instead of the
character after, which is the token of interest. (Gopls' nilness
analyzers publishes zero-width diagnostics.)

Why is that the appropriate fix, as opposed to something as simple as this?

                       (when (= beg end)
                         (setq end (1+ end)))

(Aside: "botched" seems like an unnecessarily pejorative: an empty
range is what it is, and sometimes all the information the server has
is the start point of a token.)

There have been two minor changes to that logic since #27 was fixed,
but neither seems relevant to this question:
- 3d9a6f1 Handle case when diagnostic :character is out of range
- 5b62d00 Enable lsp project-wide diagnostics via flymake

I couldn't check for related issues because
https://lists.gnu.org/archive/html/bug-gnu-emacs/ appears to be down.

thanks
alan

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alan Donovan <adonovan@HIDDEN>
Subject: bug#79426: Acknowledgement (diagnostic with empty range =>
 preceding char is highlighted)
Message-ID: <handler.79426.B.17575421047198.ack <at> debbugs.gnu.org>
References: <CAPVWWDWORKGynC=jcq80J2ZJEEwmO=dCtZN8OVvYPH0uEWL7PA@HIDDEN>
X-Gnu-PR-Message: ack 79426
X-Gnu-PR-Package: emacs
Reply-To: 79426 <at> debbugs.gnu.org
Date: Wed, 10 Sep 2025 22:09:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 79426 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
79426: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79426
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#79426: diagnostic with empty range => preceding char is highlighted
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Sep 2025 04:50:02 +0000
Resent-Message-ID: <handler.79426.B79426.17575662021443 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Alan Donovan <adonovan@HIDDEN>, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 79426 <at> debbugs.gnu.org
Date: Thu, 11 Sep 2025 07:49:52 +0300
Message-Id: <86frctvbin.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAPVWWDWORKGynC=jcq80J2ZJEEwmO=dCtZN8OVvYPH0uEWL7PA@HIDDEN>
 (bug-gnu-emacs@HIDDEN)
References: <CAPVWWDWORKGynC=jcq80J2ZJEEwmO=dCtZN8OVvYPH0uEWL7PA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Wed, 10 Sep 2025 18:07:56 -0400
> From:  Alan Donovan via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> (from https://github.com/joaotavora/eglot/issues/27#issuecomment-3275571619)
> 
> The fix for issue #27 (zero-width ranges) included this code:
> 
>                        ;; Fallback to `flymake-diag-region' if server
>                        ;; botched the range
>                        (when (= beg end)
> (if-let* ((st (plist-get range :start))
>   (diag-region
>    (flymake-diag-region
>     (current-buffer) (1+ (plist-get st :line))
>     (plist-get st :character))))
>     (setq beg (car diag-region) end (cdr diag-region))
>   (eglot--widening
>    (goto-char (point-min))
>    (setq beg
>  (eglot--bol
>   (1+ (plist-get (plist-get range :start) :line))))
>    (setq end
>  (line-end-position
>   (1+ (plist-get (plist-get range :end) :line)))))))
> 
> This causes Emacs to highlight the character before the indicated
> range, which is often an irrelevant blank space, instead of the
> character after, which is the token of interest. (Gopls' nilness
> analyzers publishes zero-width diagnostics.)
> 
> Why is that the appropriate fix, as opposed to something as simple as this?
> 
>                        (when (= beg end)
>                          (setq end (1+ end)))
> 
> (Aside: "botched" seems like an unnecessarily pejorative: an empty
> range is what it is, and sometimes all the information the server has
> is the start point of a token.)
> 
> There have been two minor changes to that logic since #27 was fixed,
> but neither seems relevant to this question:
> - 3d9a6f1 Handle case when diagnostic :character is out of range
> - 5b62d00 Enable lsp project-wide diagnostics via flymake
> 
> I couldn't check for related issues because
> https://lists.gnu.org/archive/html/bug-gnu-emacs/ appears to be down.

Thanks, I added João to the discussion.

Last modified: Thu, 11 Sep 2025 05:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.