GNU bug report logs - #79580
[PATCH] hideshow: Fix cursor when using end-of-line indicators.

Previous Next

To reply to this bug, email your comments to 79580 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] hideshow: Fix cursor when using end-of-line indicators.
Date: Sun, 05 Oct 2025 19:30:08 -0600

[Message part 1 (text/plain, inline)]

Tags: patch


This patch fixes a bug i noticed when using hideshow EOL indicators and
flymake ones together, moving the cursor to end of current line when
both indicators are in the same line, moves the cursor to the next line
for some reason.

This also fixes the display of the indicators, so it should now look
like this:

 (defun my-function (arg1)| v
                          ^
                     cursor

instead of this:

(defun my-function (arg1)v|

[0001-hideshow-Fix-cursor-when-using-end-of-line-indicator.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via Gnus and Org.

Message #8 received at 79580 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79580 <at> debbugs.gnu.org
Subject: Re: bug#79580: [PATCH] hideshow: Fix cursor when using end-of-line
 indicators.
Date: Mon, 06 Oct 2025 09:13:21 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Date: Sun, 05 Oct 2025 19:30:08 -0600
> 
> This patch fixes a bug i noticed when using hideshow EOL indicators and
> flymake ones together, moving the cursor to end of current line when
> both indicators are in the same line, moves the cursor to the next line
> for some reason.
> 
> This also fixes the display of the indicators, so it should now look
> like this:
> 
>  (defun my-function (arg1)| v
>                           ^
>                      cursor
> 
> instead of this:
> 
> (defun my-function (arg1)v|

Thanks, but is it feasible to have tests for these issues?

Message #11 received at 79580 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79580 <at> debbugs.gnu.org
Subject: Re: bug#79580: [PATCH] hideshow: Fix cursor when using end-of-line
 indicators.
Date: Mon, 06 Oct 2025 18:36:40 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Date: Sun, 05 Oct 2025 19:30:08 -0600
>> 
>> This patch fixes a bug i noticed when using hideshow EOL indicators and
>> flymake ones together, moving the cursor to end of current line when
>> both indicators are in the same line, moves the cursor to the next line
>> for some reason.
>> 
>> This also fixes the display of the indicators, so it should now look
>> like this:
>> 
>>  (defun my-function (arg1)| v
>>                           ^
>>                      cursor
>> 
>> instead of this:
>> 
>> (defun my-function (arg1)v|
>
> Thanks, but is it feasible to have tests for these issues?

I think so, I've added one now:

[0001-hideshow-Fix-cursor-when-using-end-of-line-indicator.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Also this bug seems to work only when images are used for the
indicators, here is a code for reproduce this:

(let ((o1 (make-overlay (line-end-position) (1+ (line-end-position))))
      (o2 (make-overlay (line-end-position) (1+ (line-end-position)))))
  (overlay-put o1 'display "!\n")
  (overlay-put o2 'before-string (icon-string 'tab-line-close)))

-- 
- E.G via Gnus and Org.

Message #14 received at 79580 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79580 <at> debbugs.gnu.org
Subject: Re: bug#79580: [PATCH] hideshow: Fix cursor when using end-of-line
 indicators.
Date: Fri, 10 Oct 2025 20:05:44 -0600

[Message part 1 (text/plain, inline)]

Hello, I'm sending a updated patch, I had to remove the ert test from
the patch because it was not correct.

I'm not sure how to add a proper test for this bug but since this is not
a specific hideshow bug I don't think there is a problem with removing
it.

[0001-hideshow-Fix-cursor-when-using-end-of-line-indicator.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
- E.G via Gnus and Org.

Message #19 received at 79580-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 79580-done <at> debbugs.gnu.org
Subject: Re: bug#79580: [PATCH] hideshow: Fix cursor when using end-of-line
 indicators.
Date: Sat, 11 Oct 2025 12:50:46 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: 79580 <at> debbugs.gnu.org
> Date: Fri, 10 Oct 2025 20:05:44 -0600
> 
> Hello, I'm sending a updated patch, I had to remove the ert test from
> the patch because it was not correct.
> 
> I'm not sure how to add a proper test for this bug but since this is not
> a specific hideshow bug I don't think there is a problem with removing
> it.

Thanks, installed, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.