GNU bug report logs - #79594
[PATCH] monad-repl: Add "build-graft" command.

Previous Next

To reply to this bug, email your comments to 79594 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] monad-repl: Add "build-graft" command.
Date: Tue,  7 Oct 2025 11:53:40 +0200

Grafts are not always required when just exploring in the REPL, and they do
take time, so this commit adds easy way to disable them.

* guix/monad-repl.scm (build-graft): New meta command.
* doc/guix.texi (Using Guix Interactively): Document it.
---
 doc/guix.texi       | 5 +++++
 guix/monad-repl.scm | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 7162a5f06b..7e6a0d465a 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13214,6 +13214,11 @@ Using Guix Interactively
 @end example
 @end deffn
 
+@deffn {REPL command} build-graft @var{graft?}
+Set whether grafts should be performed as part of the build.  Equivalent
+to @code{--no-grafts} argument to @code{guix build}.
+@end deffn
+
 @deffn {REPL command} lower @var{object}
 Lower @var{object} into a derivation or store file name and return it.
 @end deffn
diff --git a/guix/monad-repl.scm b/guix/monad-repl.scm
index db4fe3c699..92f015a3b7 100644
--- a/guix/monad-repl.scm
+++ b/guix/monad-repl.scm
@@ -147,6 +147,11 @@ (define-meta-command ((build-options guix) repl (opts))
   (repl-print repl %build-options)
   (set! %build-options (repl-eval repl opts)))
 
+(define-meta-command ((build-graft guix) repl (graft?))
+  "build-graft GRAFT?
+Set whether grafts should be performed."
+  (%graft? (repl-eval repl graft?)))
+
 (define-meta-command ((enter-store-monad guix) repl)
   "enter-store-monad
 Enter a REPL for values in the store monad."
-- 
2.51.0

Message #8 received at 79594 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Maxim Cournoyer <maxim <at> guixotic.coop>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Gabriel Wicki <gabriel <at> erlikon.ch>, 79594 <at> debbugs.gnu.org,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#79594] [PATCH] monad-repl: Add "build-graft" command.
Date: Sat, 29 Nov 2025 18:01:23 +0100

Hi Tomas,

Tomas Volf <~@wolfsden.cz> skribis:

> Grafts are not always required when just exploring in the REPL, and they do
> take time, so this commit adds easy way to disable them.
>
> * guix/monad-repl.scm (build-graft): New meta command.
> * doc/guix.texi (Using Guix Interactively): Document it.

Apologies for the delay!

This sounds like a useful REPL command to me.

> +(define-meta-command ((build-graft guix) repl (graft?))
> +  "build-graft GRAFT?
> +Set whether grafts should be performed."

Nitpicking, but I would tend to call the command “graft”: “Define
whether to graft package replacements.”

WDYT?

Ludo’.

Message #11 received at 79594 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Maxim Cournoyer <maxim <at> guixotic.coop>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Gabriel Wicki <gabriel <at> erlikon.ch>, 79594 <at> debbugs.gnu.org,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#79594] [PATCH] monad-repl: Add "build-graft" command.
Date: Sun, 30 Nov 2025 22:04:58 +0100

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> skribis:
>
>> Grafts are not always required when just exploring in the REPL, and they do
>> take time, so this commit adds easy way to disable them.
>>
>> * guix/monad-repl.scm (build-graft): New meta command.
>> * doc/guix.texi (Using Guix Interactively): Document it.
>
> Apologies for the delay!

No worries, I am aware most of the focus is on Codeberg these days. :)

>
> This sounds like a useful REPL command to me.
>
>> +(define-meta-command ((build-graft guix) repl (graft?))
>> +  "build-graft GRAFT?
>> +Set whether grafts should be performed."
>
> Nitpicking, but I would tend to call the command “graft”: “Define
> whether to graft package replacements.”
>
> WDYT?

The build-graft seemed consistent with already added build-options
command and (still waiting to be sent) build-mode command.  In absence
of any name-spacing support in Guile's meta-commands, I like the common
build- prefix.

But it is your call, so just let me know if I should sent v2 with the
rename.  I care more about getting this merged than what exact name this
does have. :)

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.