GNU bug report logs - #79600
31.0.50; [PATCH] newsticker.el does not escape xml string properly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 79600 in the body.
You can then email your comments to 79600 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: LdBeth <andpuke <at> foxmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] newsticker.el does not escape xml string properly
Date: Wed, 08 Oct 2025 21:12:47 +0800

[Message part 1 (text/plain, inline)]

The `newsticker--unxml' function does not properly handle the case when
the parsed XML string nodes contains characters that could confuse the
HTML parser.

Using `xml-escape-string' from xml.el to fix this.

[patch.diff (text/plain, attachment)]

Message #8 received at 79600 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: LdBeth <andpuke <at> foxmail.com>, Ulf Jasper <ulf.jasper <at> web.de>
Cc: 79600 <at> debbugs.gnu.org
Subject: Re: bug#79600: 31.0.50;
 [PATCH] newsticker.el does not escape xml string properly
Date: Wed, 08 Oct 2025 17:23:30 +0300

> Date: Wed, 08 Oct 2025 21:12:47 +0800
> From: LdBeth <andpuke <at> foxmail.com>
> 
> The `newsticker--unxml' function does not properly handle the case when
> the parsed XML string nodes contains characters that could confuse the
> HTML parser.
> 
> Using `xml-escape-string' from xml.el to fix this.

Thanks.  Ulf, any comments?

> --- newst-backend.el.old	2025-10-08 21:08:58
> +++ newst-backend.el	2025-10-08 21:09:13
> @@ -1110,9 +1110,9 @@
>  (defun newsticker--unxml (node)
>    "Reverse parsing of an xml string.
>  Restore an xml-string from a an xml NODE that was returned by xml-parse..."
> -  (if (or (not node) (stringp node))
> -      node
> -    (newsticker--unxml-node node)))
> +  (cond ((not node) node)
> +        ((stringp node) (xml-escape-string node))
> +        (t (newsticker--unxml-node node))))
>  
>  (defun newsticker--unxml-node (node)
>    "Actually restore xml-string of an xml NODE."

Message #11 received at 79600 <at> debbugs.gnu.org (full text, mbox):

From: Ulf Jasper <ulf.jasper <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: LdBeth <andpuke <at> foxmail.com>, 79600 <at> debbugs.gnu.org
Subject: Re: bug#79600: 31.0.50; [PATCH] newsticker.el does not escape xml
 string properly
Date: Wed, 08 Oct 2025 16:29:02 +0200

Am 08.10.2025 um 17:23 (+0300) schrieb Eli Zaretskii:
>> Date: Wed, 08 Oct 2025 21:12:47 +0800
>> From: LdBeth <andpuke <at> foxmail.com>
>> 
>> The `newsticker--unxml' function does not properly handle the case when
>> the parsed XML string nodes contains characters that could confuse the
>> HTML parser.
>> 
>> Using `xml-escape-string' from xml.el to fix this.
>
> Thanks.  Ulf, any comments?

Looks good to me! 

>> --- newst-backend.el.old	2025-10-08 21:08:58
>> +++ newst-backend.el	2025-10-08 21:09:13
>> @@ -1110,9 +1110,9 @@
>>  (defun newsticker--unxml (node)
>>    "Reverse parsing of an xml string.
>>  Restore an xml-string from a an xml NODE that was returned by xml-parse..."
>> -  (if (or (not node) (stringp node))
>> -      node
>> -    (newsticker--unxml-node node)))
>> +  (cond ((not node) node)
>> +        ((stringp node) (xml-escape-string node))
>> +        (t (newsticker--unxml-node node))))
>>  
>>  (defun newsticker--unxml-node (node)
>>    "Actually restore xml-string of an xml NODE."

Message #16 received at 79600-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ulf Jasper <ulf.jasper <at> web.de>
Cc: andpuke <at> foxmail.com, 79600-done <at> debbugs.gnu.org
Subject: Re: bug#79600: 31.0.50; [PATCH] newsticker.el does not escape xml
 string properly
Date: Wed, 08 Oct 2025 18:08:24 +0300

> From: Ulf Jasper <ulf.jasper <at> web.de>
> Cc: LdBeth <andpuke <at> foxmail.com>,  79600 <at> debbugs.gnu.org
> Date: Wed, 08 Oct 2025 16:29:02 +0200
> 
> Am 08.10.2025 um 17:23 (+0300) schrieb Eli Zaretskii:
> >> Date: Wed, 08 Oct 2025 21:12:47 +0800
> >> From: LdBeth <andpuke <at> foxmail.com>
> >> 
> >> The `newsticker--unxml' function does not properly handle the case when
> >> the parsed XML string nodes contains characters that could confuse the
> >> HTML parser.
> >> 
> >> Using `xml-escape-string' from xml.el to fix this.
> >
> > Thanks.  Ulf, any comments?
> 
> Looks good to me! 

Thanks, installed on the master branch, and closing the bug.

Message #19 received at 79600-done <at> debbugs.gnu.org (full text, mbox):

From: Ulf Jasper <ulf.jasper <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: andpuke <at> foxmail.com, 79600-done <at> debbugs.gnu.org
Subject: Re: bug#79600: 31.0.50; [PATCH] newsticker.el does not escape xml
 string properly
Date: Wed, 08 Oct 2025 17:30:50 +0200

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.