GNU bug report logs - #79607
[PATCH v1] ; Add missing defcustom types in eshell and eww

Previous Next

To reply to this bug, email your comments to 79607 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jacob S. Gordon" <jacob.as.gordon <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH v1] ; Add missing defcustom types in eshell and eww
Date: Thu, 09 Oct 2025 17:09:32 -0400

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

Hey everyone,

I noticed some documented and implemented values for the following
options that aren’t covered by the :type block of the defcustom:

+ eshell-scroll-to-bottom-on-input: missing t,
+ eshell-scroll-to-bottom-on-output: missing t,
+ eww-restore-desktop: missing ‘auto’.

This patch adds the missing types to avoid warnings when using setopt.

[v1-0001-Add-missing-defcustom-types-in-eshell-and-eww.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,

-- 
Jacob S. Gordon
jacob.as.gordon <at> gmail.com
Please avoid sending me HTML emails and MS Office documents.
https://useplaintext.email/#etiquette

In GNU Emacs 30.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.50,
cairo version 1.18.4)
System Description: Arch Linux

Configured using:
 'configure --with-pgtk --sysconfdir=/etc --prefix=/usr
 --libexecdir=/usr/lib --localstatedir=/var --disable-build-details
 --with-cairo --with-harfbuzz --with-libsystemd --with-modules
 --with-native-compilation=aot --with-tree-sitter 'CFLAGS=-march=x86-64
 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3
 -Wformat -Werror=format-security -fstack-clash-protection
 -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto'
 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro
 -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto'
 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
 -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto''

Message #10 received at 79607-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: "Jacob S. Gordon" <jacob.as.gordon <at> gmail.com>
Cc: 79607-done <at> debbugs.gnu.org
Subject: Re: bug#79607: [PATCH v1] ; Add missing defcustom types in eshell
 and eww
Date: Fri, 07 Nov 2025 15:19:45 +0000

Version: 31.1

Hello,

Installed and closing the bug, thanks.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.