X-Loop: help-debbugs@HIDDEN
Subject: bug#79633: Improve color contrast for diff dark backgrounds
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: sbaugh@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 15 Oct 2025 16:29:02 +0000
Resent-Message-ID: <handler.79633.B.17605457258803 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 79633
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 79633 <at> debbugs.gnu.org
Cc: Spencer Baugh <sbaugh@HIDDEN>
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
X-Debbugs-Original-Xcc: Spencer Baugh <sbaugh@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.17605457258803
(code B ref -1); Wed, 15 Oct 2025 16:29:02 +0000
Received: (at submit) by debbugs.gnu.org; 15 Oct 2025 16:28:45 +0000
Received: from localhost ([127.0.0.1]:55884 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1v94Ml-0002Hu-SN
for submit <at> debbugs.gnu.org; Wed, 15 Oct 2025 12:28:44 -0400
Received: from lists.gnu.org ([2001:470:142::17]:50896)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1v94MX-0002HQ-Vr
for submit <at> debbugs.gnu.org; Wed, 15 Oct 2025 12:28:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1v94MR-0005JZ-Dg
for bug-gnu-emacs@HIDDEN; Wed, 15 Oct 2025 12:28:23 -0400
Received: from mout-p-201.mailbox.org ([80.241.56.171])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
(Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1v94MG-00078H-Dl
for bug-gnu-emacs@HIDDEN; Wed, 15 Oct 2025 12:28:23 -0400
Received: from smtp102.mailbox.org (smtp102.mailbox.org
[IPv6:2001:67c:2050:b231:465::102])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4cmxMc3mjDz9tfQ
for <bug-gnu-emacs@HIDDEN>; Wed, 15 Oct 2025 18:27:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001;
t=1760545676;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type;
bh=N2nhqPVaa+MxgQsuLkH5tXyPT/8IdkkBBCG7gGpIXz0=;
b=Pr0Jv6nGPmYTcqRCYWagTrCgaIx78Tsdji50/C3XzNkIL82n/A3H2FFmsVFqKmpjWCgPfW
8YizkV/BJH/uunrsqK9Vpx6pXmDzCc6qLfB6jd4WDpto6099693RqVsR8kDOQ8vnDL033c
ZAI4K1k5WfSq9CVQHrrK0fSo4GmI9lvDoCtu+Qq080M7DZc4EAmuZXPSpEBDJPXp8oOGfc
U4/1TAVmpS+0f0i5b0aYktRp3n73Awv0t37wChaYVBb+RPGShDoi6C/+3JczWi6QIXypwh
IrT9qCeLRDAvMlsfLQHSsjs5wzG3hzOWCByaMSKtiokFXjnW8AvEuWhuS6IQ3Q==
Authentication-Results: outgoing_mbo_mout; dkim=none;
spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates
2001:67c:2050:b231:465::102 as permitted sender)
smtp.mailfrom=juri@HIDDEN
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
Date: Wed, 15 Oct 2025 19:24:54 +0300
Message-ID: <87a51sku95.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Rspamd-Queue-Id: 4cmxMc3mjDz9tfQ
Received-SPF: pass client-ip=80.241.56.171; envelope-from=juri@HIDDEN;
helo=mout-p-201.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01,
T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
Currently diff-refine faces have too low contrast on dark themes because
a color distance between non-refine and refine colors is too large.
This patch improves the readability of diff-refine-added/removed
and related faces:
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=diff-refine-faces.patch
diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el
index 2fb552597fd..c6c6233485f 100644
--- a/lisp/vc/diff-mode.el
+++ b/lisp/vc/diff-mode.el
@@ -2471,7 +2471,7 @@ diff-refine-removed
(((class color) (min-colors 88) (background light))
:background "#ffbbbb")
(((class color) (min-colors 88) (background dark))
- :background "#aa2222"))
+ :background "#882222"))
"Face used for removed characters shown by `diff-refine-hunk'."
:version "24.3")
@@ -2483,7 +2483,7 @@ diff-refine-added
(((class color) (min-colors 88) (background light))
:background "#aaffaa")
(((class color) (min-colors 88) (background dark))
- :background "#22aa22"))
+ :background "#228822"))
"Face used for added characters shown by `diff-refine-hunk'."
:version "24.3")
diff --git a/lisp/vc/ediff-init.el b/lisp/vc/ediff-init.el
index 12b94e81489..7254b32e41e 100644
--- a/lisp/vc/ediff-init.el
+++ b/lisp/vc/ediff-init.el
@@ -856,7 +856,7 @@ ediff-fine-diff-A
'((((class color) (min-colors 88) (background light))
:background "#ffbbbb")
(((class color) (min-colors 88) (background dark))
- :background "#aa2222")
+ :background "#882222")
(((class color) (min-colors 16))
(:foreground "Navy" :background "sky blue"))
(((class color))
@@ -876,7 +876,7 @@ ediff-fine-diff-B
'((((class color) (min-colors 88) (background light))
:background "#aaffaa")
(((class color) (min-colors 88) (background dark))
- :background "#22aa22")
+ :background "#228822")
(((class color) (min-colors 16))
(:foreground "Black" :background "cyan"))
(((class color))
diff --git a/lisp/vc/smerge-mode.el b/lisp/vc/smerge-mode.el
index 0a9e07cf78b..173b67e1983 100644
--- a/lisp/vc/smerge-mode.el
+++ b/lisp/vc/smerge-mode.el
@@ -126,7 +126,7 @@ smerge-refined-removed
(((class color) (min-colors 88) (background light))
:background "#ffbbbb")
(((class color) (min-colors 88) (background dark))
- :background "#aa2222")
+ :background "#882222")
(t :inverse-video t))
"Face used for removed characters shown by `smerge-refine'."
:version "24.3")
@@ -137,7 +137,7 @@ smerge-refined-added
(((class color) (min-colors 88) (background light))
:background "#aaffaa")
(((class color) (min-colors 88) (background dark))
- :background "#22aa22")
+ :background "#228822")
(t :inverse-video t))
"Face used for added characters shown by `smerge-refine'."
:version "24.3")
--=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Juri Linkov <juri@HIDDEN> Subject: bug#79633: Acknowledgement (Improve color contrast for diff dark backgrounds) Message-ID: <handler.79633.B.17605457258803.ack <at> debbugs.gnu.org> References: <87a51sku95.fsf@HIDDEN> X-Gnu-PR-Message: ack 79633 X-Gnu-PR-Package: emacs Reply-To: 79633 <at> debbugs.gnu.org Date: Wed, 15 Oct 2025 16:29:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. As you requested using X-Debbugs-CC, your message was also forwarded to Spencer Baugh <sbaugh@HIDDEN> (after having been given a bug report number, if it did not have one). Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 79633 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 79633: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79633 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#79633: Improve color contrast for diff dark backgrounds
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 16 Oct 2025 17:09:01 +0000
Resent-Message-ID: <handler.79633.B79633.176063449025437 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 79633
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 79633 <at> debbugs.gnu.org
Cc: Spencer Baugh <sbaugh@HIDDEN>
Received: via spool by 79633-submit <at> debbugs.gnu.org id=B79633.176063449025437
(code B ref 79633); Thu, 16 Oct 2025 17:09:01 +0000
Received: (at 79633) by debbugs.gnu.org; 16 Oct 2025 17:08:10 +0000
Received: from localhost ([127.0.0.1]:36928 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1v9RSR-0006c6-Ax
for submit <at> debbugs.gnu.org; Thu, 16 Oct 2025 13:08:10 -0400
Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:39984)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <juri@HIDDEN>)
id 1v9RSI-0006ax-76; Thu, 16 Oct 2025 13:08:01 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org
[IPv6:2001:67c:2050:b231:465::2])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4cnZC517TCz9slY;
Thu, 16 Oct 2025 19:07:45 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001;
t=1760634465;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=21bonwBXFp5Afwz9gduCf2JZEPZTBA7yosz7BQdoKVA=;
b=C5ECfWzU39YBcsoVA2jtLJHnty6cs71zuXhPliOdkZZOQciPxyVEtwBu9clb99g/XPb+IL
It9Wtqp/u8PLfr+vq2fVnTB+Gv9oTfZt93DeTlMP8BtoMBWvbqs8rhMOzATg3TXU6kMVWY
fF3fAL+ceTd4cJxwgqEj9F79L/BPaDUunsX8Z6U7xeWJo8IsK5lAvDh6V2L98bwSW1qKH7
ILP6V28GxcRosGZhcqHrenMNsgxE9i+B2iKvpLuiYglb/8ybF1+LLFNkXvQwvCFMMOyGZE
vua23ks4lO2TchRyf+rTaUKv0vroo9cXtylm7t9JSIba+4upXNMc2oasymhzhg==
Authentication-Results: outgoing_mbo_mout; dkim=none;
spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates
2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=juri@HIDDEN
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <87a51sku95.fsf@HIDDEN>
Organization: LINKOV.NET
References: <87a51sku95.fsf@HIDDEN>
Date: Thu, 16 Oct 2025 20:06:31 +0300
Message-ID: <87ecr2lqso.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 4cnZC517TCz9slY
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
close 79633 31.0.50
thanks
> Currently diff-refine faces have too low contrast on dark themes because
> a color distance between non-refine and refine colors is too large.
> This patch improves the readability of diff-refine-added/removed
> and related faces:
This is now pushed and closed.
Received: (at control) by debbugs.gnu.org; 16 Oct 2025 17:08:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 16 13:08:14 2025 Received: from localhost ([127.0.0.1]:36930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1v9RSX-0006cR-U0 for submit <at> debbugs.gnu.org; Thu, 16 Oct 2025 13:08:14 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:39984) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1v9RSI-0006ax-76; Thu, 16 Oct 2025 13:08:01 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4cnZC517TCz9slY; Thu, 16 Oct 2025 19:07:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1760634465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=21bonwBXFp5Afwz9gduCf2JZEPZTBA7yosz7BQdoKVA=; b=C5ECfWzU39YBcsoVA2jtLJHnty6cs71zuXhPliOdkZZOQciPxyVEtwBu9clb99g/XPb+IL It9Wtqp/u8PLfr+vq2fVnTB+Gv9oTfZt93DeTlMP8BtoMBWvbqs8rhMOzATg3TXU6kMVWY fF3fAL+ceTd4cJxwgqEj9F79L/BPaDUunsX8Z6U7xeWJo8IsK5lAvDh6V2L98bwSW1qKH7 ILP6V28GxcRosGZhcqHrenMNsgxE9i+B2iKvpLuiYglb/8ybF1+LLFNkXvQwvCFMMOyGZE vua23ks4lO2TchRyf+rTaUKv0vroo9cXtylm7t9JSIba+4upXNMc2oasymhzhg== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=juri@HIDDEN From: Juri Linkov <juri@HIDDEN> To: 79633 <at> debbugs.gnu.org Subject: Re: bug#79633: Improve color contrast for diff dark backgrounds In-Reply-To: <87a51sku95.fsf@HIDDEN> Organization: LINKOV.NET References: <87a51sku95.fsf@HIDDEN> Date: Thu, 16 Oct 2025 20:06:31 +0300 Message-ID: <87ecr2lqso.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4cnZC517TCz9slY X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: Spencer Baugh <sbaugh@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 79633 31.0.50 thanks > Currently diff-refine faces have too low contrast on dark themes because > a color distance between non-refine and refine colors is too large. > This patch improves the readability of diff-refine-added/removed > and related faces: This is now pushed and closed.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.