Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 79686) by debbugs.gnu.org; 30 Oct 2025 18:31:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 30 14:31:10 2025 Received: from localhost ([127.0.0.1]:37293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEXQT-0001mo-VQ for submit <at> debbugs.gnu.org; Thu, 30 Oct 2025 14:31:10 -0400 Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]:49296) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1vEXQJ-0001ld-J4; Thu, 30 Oct 2025 14:31:01 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4cyCNS4fjPz9tN2; Thu, 30 Oct 2025 19:30:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1761849048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1a/fvfby3z7tnmZH4CUCU22dzZypTnLgkFXLvmTxIwE=; b=ZxZlbum4AZeDDq04CXmKr0tQS85H1x+m5R8u6zvwYVFt2sAgVlavsWA9rKqfqBU5EGS9Ed F4Z2QMVtn92rDxpHnjGNezSYUwXHKku7xA1ByKMv+uimPWbJlEiz+T+fy6FoFRqGb2dFoi eDQppfvVuHGb3hEunvIrHVJphxYmtY0gVpooOk8UEnu2QuxJUZ3J1XrI1eOrOMlaOhyEBb +mcKYhuubQustBFsifOoVfgJ82FCTqQRyPLugHre6ZThqsWmg/U5ch/LvWsKc1+d3OIv3w 7HnXhFK7RjGpGGDN2M07X1EqH68Zv6J29yNKX/qzfXPiSHOZEgYTHUEImKgVgg== From: Juri Linkov <juri@HIDDEN> To: Steven Allen <steven@HIDDEN> Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake In-Reply-To: <87jz0cs1qu.fsf@HIDDEN> Organization: LINKOV.NET References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> <87h5vix3j2.fsf@HIDDEN> <86sef2omiz.fsf@HIDDEN> <87ms5aizdb.fsf@HIDDEN> <87qzuk5m22.fsf@HIDDEN> <87jz0cs1qu.fsf@HIDDEN> Date: Thu, 30 Oct 2025 20:28:07 +0200 Message-ID: <87cy645jns.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79686 Cc: sbaugh@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 79686 31.0.50 thanks > By the way, is there any form of "lint" make target to catch stuff like this? Compilation is able to catch most such things. > Subject: [PATCH] More reliably check if a frame is the daemon's initial frame > > Frames created when Emacs is running as a daemon may not have the > "client" frame parameter set, e.g., when: > > 1. Created from the user's init file. > 2. Created via "emacsclient -e" (e.g., "emacsclient -e '(make-frame)'"). > > The "client" parameter simply indicates that the frame was created by > emacsclient directly (or recursively from another emacsclient frame). > > Instead, this commit checks if (a) Emacs is running as a daemon and (b) > the target frame is the "terminal frame". When run as a daemon, Emacs's > terminal frame is always the daemon's initial frame. Thanks for fixing this bug. Now your patch is pushed.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at 79686) by debbugs.gnu.org; 30 Oct 2025 18:06:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 30 14:06:55 2025
Received: from localhost ([127.0.0.1]:37172 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vEX30-0000Q9-AN
for submit <at> debbugs.gnu.org; Thu, 30 Oct 2025 14:06:55 -0400
Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]:49255)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vEX2p-0000Pl-6k
for 79686 <at> debbugs.gnu.org; Thu, 30 Oct 2025 14:06:44 -0400
Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45])
by mailfhigh.phl.internal (Postfix) with ESMTP id 1AE681400210;
Thu, 30 Oct 2025 14:06:37 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-05.internal (MEProxy); Thu, 30 Oct 2025 14:06:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:cc:content-type:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:subject:subject:to:to; s=fm2; t=1761847597; x=
1761933997; bh=MO8+Prlu+PEJgF9FoXkOqXuD4SCQqdbL75KsF6Dq82g=; b=C
+ct0s9i0ncDCroRsTge6MpUNn/fIJkZDc5qQWTgD4BG716zoIMYn3C9JKqleRtWV
1s3LAXJVn9a63b50vphxxPDd9h9d1TdeLA1lQ2qv72lTVXKqRpa6/9fiFrMGpxhx
N9VvOMCo2uujAYkyoSnMHI9b4MqBLKIwy37pR285uMkvvHDPsQrsICHZUCI22JjY
IiBIaDga9auoAZxRIKkGDIkASQLnb3dtqm8oifpwqqygM4aKyUgsWKHG1eBZpins
z3+zXzStyS7z2uRwMuGcsFah3ktcBOp/0y/ZLyATRw8DpbFD3uD4Mw3mERMDo0Lr
ML2bJDzyYmNLU2pWlR71A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1761847597; x=1761933997; bh=MO8+Prlu+PEJgF9FoXkOqXuD4SCQqdbL75K
sF6Dq82g=; b=sbmDFxeZxty2scJSvxcv5DUFTvujzsc37q5Hk6HSkS5L+ZNyU0z
3UOR89sYSCCs8XknNZNyQGfCIl7SgCYI6KZhrIGwhhOtr4/AF5BTAQftmAzQ2Mjf
2uiH4LZvAau6zZ18m34t1jEZa4b2DnHiVPWjaRom7ziAVjXyyfcu69k278zi++sW
pOUwEe7xR5wwXM2DvXfr4nguOLK2Gtp5XuViooX8TuKOQ920m7t6GXErvSZTCZOk
HBIsr1vWbqeUXKzl4oKY+sA1Am3w0KDMNcFqoKDSKqkhlM15//DcPlPtBr4bs9w7
yo5+4y16Eumky65TDpVHAVJQpEJrS/ZXiBw==
X-ME-Sender: <xms:LKkDabMg3G5D06VzLj_Bp_oeVp7MK4wve3EQDhGGVyd77sk1yMFRfw>
<xme:LKkDac2kS3M6x7-cEJkwn1LmDl13M4D6gVrg1bx0LM6ZM0BMOZ83Jv7bPLkJKMxXh
kIj42KXmeRqR8griEQeLYT10c7IuXrYRhxI2LxXD3jWYU_TJ9S87jE>
X-ME-Received: <xmr:LKkDaSnsU2PCwOPvXslXUZzV72TPSWPsQoX0J636AyZoYO0G9Z-iL_JVvU4>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduieejvdelucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurhephffvvefujghffffkgggtsehmtderredttddtnecuhfhrohhmpefuthgvvhgvnhcu
tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth
htvghrnhepjedufedvieejueektddtgedugeffveejheehieeulefgfffhleffheefvefh
vdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh
htvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeehpdhmohgu
vgepshhmthhpohhuthdprhgtphhtthhopehjuhhriheslhhinhhkohhvrdhnvghtpdhrtg
hpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepjhhorghothgrvhhorhgr
sehgmhgrihhlrdgtohhmpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvth
drtghomhdprhgtphhtthhopeejleeikeeiseguvggssghughhsrdhgnhhurdhorhhg
X-ME-Proxy: <xmx:LKkDabWNVXqXXzP15z6U0crhAPI7CfL4yorRoqreyAsvDgb4VzbdhQ>
<xmx:LKkDaQuxr8Ft1yrkrEHukCFRXIiSiICYtIFm14ur-E3ZXVvEgg7fxQ>
<xmx:LKkDaWad_hTev24isHNuIQcM3hvF9xys1Z-FQqaDYBXIjniYoP8nCQ>
<xmx:LKkDaXXwE5YQIU7u_mwjvnVVjR6Xb8fYPeWLR5TmeNwqJXtx1C_Xkg>
<xmx:LakDaYHBcRH87et_GDe6Dxqn_Pwv9WS1RpFuY3uDtrAnWQXJBB99RqpG>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
30 Oct 2025 14:06:36 -0400 (EDT)
From: Steven Allen <steven@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible
in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake
In-Reply-To: <87qzuk5m22.fsf@HIDDEN>
References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN>
<87o6pr3qv3.fsf@HIDDEN> <87h5vix3j2.fsf@HIDDEN>
<86sef2omiz.fsf@HIDDEN> <87ms5aizdb.fsf@HIDDEN>
<87qzuk5m22.fsf@HIDDEN>
Date: Thu, 30 Oct 2025 11:06:33 -0700
Message-ID: <87jz0cs1qu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79686
Cc: sbaugh@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 79686 <at> debbugs.gnu.org,
joaotavora@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
Juri Linkov <juri@HIDDEN> writes:
>>>> Checking for (frame-parameter nil 'client) was a common idiom
>>>> used in many places. Now Steven discovered a case where it fails.
>>>> So it would be correct to push the patch created by Steven
>>>> that fixes all these places at once.
>>>
>>> That depends on the purpose of the test. I'm not convinced that all
>>> of the places where the above is used want to test for the daemon's
>>> initial frame.
>>
>> The only cases where this reason is not explicitly documented in the
>> code are:
>>
>> 1. The flymake change where the reason for the check is documented in
>> commit 72255c99925b.
>> 2. The display-fill-column-indicator change, but one seems pretty
>> obvious.
>
> I've tested your patch and found only one problem:
> in 'desktop-restoring-frameset-p' there is
> a reference to free variable `frame'.
Nice catch!
By the way, is there any form of "lint" make target to catch stuff like this?
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-More-reliably-check-if-a-frame-is-the-daemon-s-initi.patch
From 5b760c3a0535bb089dc41bb73b6528c32f3353ce Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@HIDDEN>
Date: Tue, 28 Oct 2025 11:08:53 -0700
Subject: [PATCH] More reliably check if a frame is the daemon's initial frame
Frames created when Emacs is running as a daemon may not have the
"client" frame parameter set, e.g., when:
1. Created from the user's init file.
2. Created via "emacsclient -e" (e.g., "emacsclient -e '(make-frame)'").
The "client" parameter simply indicates that the frame was created by
emacsclient directly (or recursively from another emacsclient frame).
Instead, this commit checks if (a) Emacs is running as a daemon and (b)
the target frame is the "terminal frame". When run as a daemon, Emacs's
terminal frame is always the daemon's initial frame.
* lisp/desktop.el (desktop-clear):
(desktop-restoring-frameset-p):
* lisp/display-fill-column-indicator.el
(display-fill-column-indicator--turn-on):
* lisp/frame.el (frame-notice-user-settings):
* lisp/obsolete/linum.el (linum-on):
* lisp/progmodes/flymake.el (flymake-start):
* lisp/tab-bar.el (tab-bar--update-tab-bar-lines): Fix the "is this the
initial daemon-frame" checks. (Bug#79686)
---
lisp/desktop.el | 4 ++--
lisp/display-fill-column-indicator.el | 2 +-
lisp/frame.el | 2 +-
lisp/obsolete/linum.el | 2 +-
lisp/progmodes/flymake.el | 2 +-
lisp/tab-bar.el | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lisp/desktop.el b/lisp/desktop.el
index b82a9dc9626..21a742c9aad 100644
--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -775,7 +775,7 @@ desktop-clear
;; Don't delete daemon's initial frame, or
;; we'll never be able to close the last
;; client's frame (Bug#26912).
- (if (daemonp) (not (frame-parameter frame 'client)))
+ (and (daemonp) (eq frame terminal-frame))
(frame-parameter frame 'desktop-dont-clear))
(delete-frame frame))
(error
@@ -1255,7 +1255,7 @@ desktop-restoring-frameset-p
(and desktop-restore-frames desktop-saved-frameset
;; Don't restore frames when the selected frame is the daemon's
;; initial frame.
- (not (and (daemonp) (not (frame-parameter nil 'client))))
+ (not (and (daemonp) (eq (selected-frame) terminal-frame)))
t))
(defun desktop-restore-frameset ()
diff --git a/lisp/display-fill-column-indicator.el b/lisp/display-fill-column-indicator.el
index dbd067f5f3d..4598b659341 100644
--- a/lisp/display-fill-column-indicator.el
+++ b/lisp/display-fill-column-indicator.el
@@ -102,7 +102,7 @@ display-fill-column-indicator-mode
(defun display-fill-column-indicator--turn-on ()
"Turn on `display-fill-column-indicator-mode'."
(unless (or (minibufferp)
- (and (daemonp) (null (frame-parameter nil 'client))))
+ (and (daemonp) (eq (selected-frame) terminal-frame)))
(display-fill-column-indicator-mode)))
;;;###autoload
diff --git a/lisp/frame.el b/lisp/frame.el
index b6641ca716a..6e18ba65d9a 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -493,7 +493,7 @@ frame-notice-user-settings
(setq parms (append initial-frame-alist window-system-frame-alist
default-frame-alist parms nil))
;; Don't enable tab-bar in daemon's initial frame.
- (when (and (daemonp) (not (frame-parameter nil 'client)))
+ (when (and (daemonp) (eq (selected-frame) terminal-frame))
(setq parms (delq (assq 'tab-bar-lines parms) parms)))
parms))
(if (null initial-window-system) ;; MS-DOS does this differently in pc-win.el
diff --git a/lisp/obsolete/linum.el b/lisp/obsolete/linum.el
index e0782258716..75cb1199927 100644
--- a/lisp/obsolete/linum.el
+++ b/lisp/obsolete/linum.el
@@ -129,7 +129,7 @@ linum-on
;; Note that nowadays, this actually doesn't show line
;; numbers in client frames at all, because we visit the
;; file before creating the client frame. See bug#35726.
- (and (daemonp) (null (frame-parameter nil 'client))))
+ (and (daemonp) (eq (selected-frame) terminal-frame)))
(linum-mode 1)))
(defun linum-delete-overlays ()
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 7af4ea334d6..60a6bacf640 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1390,7 +1390,7 @@ flymake-start
(cl-labels
((visible-buffer-window ()
(and (or (not (daemonp))
- (not (null (frame-parameter nil 'client))))
+ (not (eq (selected-frame) terminal-frame)))
(get-buffer-window (current-buffer))))
(start-post-command ()
(remove-hook 'post-command-hook #'start-post-command
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index db16775d884..6653d12f634 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -282,7 +282,7 @@ tab-bar--update-tab-bar-lines
(and (eq auto-resize-tab-bars 'grow-only)
(> (frame-parameter frame 'tab-bar-lines) 1))
;; Don't enable tab-bar in daemon's initial frame.
- (and (daemonp) (not (frame-parameter frame 'client))))
+ (and (daemonp) (eq frame terminal-frame)))
(set-frame-parameter frame 'tab-bar-lines
(tab-bar--tab-bar-lines-for-frame frame)))))
;; Update `default-frame-alist'
--
2.51.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 30 Oct 2025 17:41:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 30 13:41:47 2025 Received: from localhost ([127.0.0.1]:37072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEWeg-0007Nl-F9 for submit <at> debbugs.gnu.org; Thu, 30 Oct 2025 13:41:47 -0400 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:44080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1vEWeY-0007Mi-3c for 79686 <at> debbugs.gnu.org; Thu, 30 Oct 2025 13:41:39 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4cyBHW5nhnz9t1Z; Thu, 30 Oct 2025 18:41:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1761846087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cAkycGjR4raGUmMxID7aRTAik4LoCnHkZog09+nl+Ck=; b=NRVFiWT5oEOw1VKH8DKWhQTUhYIpK58rzyQyt6OsX6ydgjzYm5YjLqzZWCnWpKA5wTaXS6 Amm5VX3Tb+Wf4hvzWpnFOx0mYQoDppc1FDQbD8BH5kkjbAHoAfVAYQpGYF2ejGapY/hHgb IduOA74F0fd4RHwtttoiqHZ26mOrleuh9xl0tane2mxJII7h6tm9yWyypaHOGegJgSdn4Z qPGocQxVe3joGfU5ObzhNNRPHfGopmhRCuDGbR3qmjiLCRB/QR3gR0tq8TjIDCPdmCX/aJ TNH6KATcVs6WEqjdnleWAdXmwTZRWOM7nnrXLKKiVWOUljDlQ2dz6JglP/ZShg== From: Juri Linkov <juri@HIDDEN> To: Steven Allen <steven@HIDDEN> Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake In-Reply-To: <87ms5aizdb.fsf@HIDDEN> Organization: LINKOV.NET References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> <87h5vix3j2.fsf@HIDDEN> <86sef2omiz.fsf@HIDDEN> <87ms5aizdb.fsf@HIDDEN> Date: Thu, 30 Oct 2025 19:36:21 +0200 Message-ID: <87qzuk5m22.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79686 Cc: sbaugh@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> Checking for (frame-parameter nil 'client) was a common idiom >>> used in many places. Now Steven discovered a case where it fails. >>> So it would be correct to push the patch created by Steven >>> that fixes all these places at once. >> >> That depends on the purpose of the test. I'm not convinced that all >> of the places where the above is used want to test for the daemon's >> initial frame. > > The only cases where this reason is not explicitly documented in the > code are: > > 1. The flymake change where the reason for the check is documented in > commit 72255c99925b. > 2. The display-fill-column-indicator change, but one seems pretty > obvious. I've tested your patch and found only one problem: in 'desktop-restoring-frameset-p' there is a reference to free variable `frame'.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 19:46:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 15:46:08 2025 Received: from localhost ([127.0.0.1]:54570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vDpdv-0003f9-CU for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:46:07 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:43137) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <steven@HIDDEN>) id 1vDpdp-0003ds-4f for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:46:02 -0400 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0A81A1400384; Tue, 28 Oct 2025 15:45:55 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 28 Oct 2025 15:45:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1761680755; x= 1761767155; bh=ntNPCpXUEnXoWfgQQwuxacrbezhAs15pSINb2WNncYE=; b=B m5b7Q2Z1V80ibP1uQecJfqYXyYBIJmObJ0y5kJqIG97YSXF2n1JG2CFG0BH2H9Y7 o2fp11XFoXGnrC+kZjMFUdpjtwzaKCABkvFeJ/zu0WCjbe2tWMA8xFSEgIyrxH1f 4Uf04o/Nl8ka92eT9XoRPiIWFC75r8sJOZjEYnPGi9GkPmDmktyjvRaG6DA7Ma/v n/hRntQwLNSqvp4R3nIlUr5+clsA0jtYyuQSzwk7/rEdwpAEBWcfDuBSde/k6oKA nVo/QD6fEoej8kE33WA7U5PI3EmXPSUPt7SD6vE0so4wU5E+mQv9yvGWkSWsVli3 YpgB+ukixZLA+1a4KGi8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1761680755; x=1761767155; bh=ntNPCpXUEnXoWfgQQwuxacrbezhAs15pSIN b2WNncYE=; b=F3z8eqUJ7rzMWIwl1XGQVbYo7BqP/5bCPmTRhTpnujLHZgDJlD0 K2gBITfbz7kmlONZ3uA85g3ZF6pR2Qp48AnLIHXYPK5w/OVLfEEhmEoslJak/iWh IB0HPakbOpCFxQPPuwXGAw0rmiEAx43KclIBLl8kDEMwFjGlGXwzzn/vW/ok6eUy MoBJXMjaags31ramHdYKnfiVShs6kNpMKk+elb3I5Q9aI0AdC+hSdSwt6j3vuxg1 0g14rMnt9wqPJDvhVnC3GKNoEq0gJFq5hKLycAJ8gbYVoepCVWE50DkfIIzA0P24 G2PglC6iQW8I0MUKAUOJtwzUxCCXtHu4B2w== X-ME-Sender: <xms:ch0BaTaWSWHv-9vaUXQrjitmfszo1TQP05kIc8bVymPPBVEmN8R2UA> <xme:ch0BaZRfPvLK01I_x3X-KXLCX2YWuOe9ZjSRI4XsOD43M4fSjn7Kon_LMZXlVuDnm Cpe-uNdafmJsaCgXGXmqPAAdjSkDK41mu28DDRKHoZOf2XUPVEAWf0> X-ME-Received: <xmr:ch0BaeQ88EUXk7zD3VMkkoCwiGRDTOeDfJmvY-AyzgcsS2us3snZJ2jKAfZbtQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduiedujedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcu tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth htvghrnhepvdekheekgeelheehgefgudelkeethffhgfeuffetkeegtddvfeduuddttdej jedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh htvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeehpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtth hopehjuhhriheslhhinhhkohhvrdhnvghtpdhrtghpthhtohepjhhorghothgrvhhorhgr sehgmhgrihhlrdgtohhmpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvth drtghomhdprhgtphhtthhopeejleeikeeiseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: <xmx:ch0BaVTvz_04up2T7i6mLfiRmTf_-XHrsK3mq8AlxRJGu7zbLIigNw> <xmx:ch0Bab4bFJGIG0jU_rrwybBNCeFrGv05a_f4GSq7zsKMjj6_XCjtNg> <xmx:ch0BaZ3doDEz1SY8mR_bLQBrWt2ksHZiqPskQGuYwvH2W5r3TbnRvw> <xmx:ch0BaeCxjnGSkuUMbLxSWNRHvBxh3zNW_-S21O_foGe75Zu56s0feA> <xmx:cx0BadjLS9rkbzEqBTL2rQGBNX1aLz2VX2_RI4tAp0heYHk-O2_YVog-> Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Oct 2025 15:45:53 -0400 (EDT) From: Steven Allen <steven@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Juri Linkov <juri@HIDDEN> Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake In-Reply-To: <86sef2omiz.fsf@HIDDEN> References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> <87h5vix3j2.fsf@HIDDEN> <86sef2omiz.fsf@HIDDEN> Date: Tue, 28 Oct 2025 12:45:52 -0700 Message-ID: <87ms5aizdb.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79686 Cc: sbaugh@HIDDEN, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: Spencer Baugh <sbaugh@HIDDEN>, 79686 <at> debbugs.gnu.org, >> Steven Allen <steven@HIDDEN> >> From: Juri Linkov <juri@HIDDEN> >> Date: Tue, 28 Oct 2025 20:52:17 +0200 >> >> >>> The attached patch checks if the selected frame is a daemon's >> >>> "terminal-frame" instead. >> >> >> >> Joao, since you just wrote this code, could you say whether this matches >> >> your intention? >> > >> > I've tried that patch and it works. By "it works"", I mean it passes >> > the four tests I listed in bug#77313. So at first glance it should be >> > good to push. >> > >> > However, I don't understand how, to be honest. And that should be >> > written somewhere. I do't understand how/when the current code (which I >> > think was suggested by Juri) doesn't work. >> >> Checking for (frame-parameter nil 'client) was a common idiom >> used in many places. Now Steven discovered a case where it fails. >> So it would be correct to push the patch created by Steven >> that fixes all these places at once. > > That depends on the purpose of the test. I'm not convinced that all > of the places where the above is used want to test for the daemon's > initial frame. The only cases where this reason is not explicitly documented in the code are: 1. The flymake change where the reason for the check is documented in commit 72255c99925b. 2. The display-fill-column-indicator change, but one seems pretty obvious.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 19:33:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 15:33:49 2025
Received: from localhost ([127.0.0.1]:54547 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vDpS1-0002xj-7W
for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:33:49 -0400
Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]:55125)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vDpRq-0002x0-F2
for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:33:39 -0400
Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48])
by mailfhigh.phl.internal (Postfix) with ESMTP id 80EF2140033A;
Tue, 28 Oct 2025 15:33:32 -0400 (EDT)
Received: from phl-mailfrontend-02 ([10.202.2.163])
by phl-compute-08.internal (MEProxy); Tue, 28 Oct 2025 15:33:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:cc:content-type:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:subject:subject:to:to; s=fm2; t=1761680012; x=
1761766412; bh=L/ZLCac8zM1f41kDL+lGTEIXfO29C9ue/XWWYmvxh2I=; b=n
W2dHgPQ3vtyBtO/BGeLZrAxc9UPMQZ0DtxjRvTYQtEj82wSzDrHjRFe8zx8esvRR
SrJItvpfkitcsujjKgYnoOQCVUkmryoTFY1orB0laqcxkPyJz7fOJT3bNzBv4lQ+
4moKcTGl3c5p+GA4VsC40wxSPgy/R+zRo9YqUFE0F633kfItUvpqj5GPFnH33dyr
A7fmCEzuLEBkYv/0fCukgjU6vuPYyHKvww7CGFAcs1YlQc+C7CiXd0ZX0BOIigyD
auE7X4vr3iq0KigVesJfeY0ss/GCZ6c5neW0nIdaDlCUWiYzmnVSpco4gOiEPl9k
zTTnqBxq/TMMndRvCQ5cg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1761680012; x=1761766412; bh=L/ZLCac8zM1f41kDL+lGTEIXfO29C9ue/XW
WYmvxh2I=; b=JY9X1DQXzshiBblW4TiOUffFU5MG1EPrDW6JX1rlLHro4LGKKYS
uL+FZc/uu4e2sLhrrRo21t/NJgKkh39TaIPYHhWmPviaetTC0Yzqsoadm66p5ehe
gH2X0ffeTWZZxS7RlMn4AeIaiN5Fs+U8JRClfZOKpuH4EmcRXGcTm7GzHwPLBW0q
VRJw/lMtajecyOgWFZ75iCj8WB8R+WfV58V0Tbpi1f8krL8b4seTgSGoKWKuc7JX
0G6MYbtUYZ9cv9TgQLLovJsFrlmBlGo2QYT9D+Ua5TxWox+v4ssSl7ykD74YTlbA
5IOxgSv2A94bHf7HWRnS/VCP/JffZDwLwRQ==
X-ME-Sender: <xms:ixoBaWURCh2CzpdXfA_sUU2mllHjEM5FEPLKodPwTwIuT8Q-u5fA1Q>
<xme:ixoBaZnmNGsA-ToY0UR_9YYUUTgS1xT_vGZRZrW4k7uvMVrwrhpU8KO6beLCBpgvB
1ZJ-UFGtAUtGX9504uqHuVE4A7CyuAi2R5QBMcAkgLl8C2-Lf80onaJ>
X-ME-Received: <xmr:ixoBafayqd1Lwn-_dCGarn3BMWFst6xtDRPS8YFkWFST0c1OCl6Y6mSAc8v7bQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduiedujedtucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcu
tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth
htvghrnhepvdekheekgeelheehgefgudelkeethffhgfeuffetkeegtddvfeduuddttdej
jedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh
htvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohgu
vgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtth
hopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhdprhgtphhtthhopehssggruhhg
hhesjhgrnhgvshhtrhgvvghtrdgtohhmpdhrtghpthhtohepjeelieekieesuggvsggsuh
hgshdrghhnuhdrohhrgh
X-ME-Proxy: <xmx:ixoBacNE8v9rUJCHqPa6m1CfjSr2hyDOcSTji8hTfSdfRbjmp3MN-g>
<xmx:ixoBacau886uqEy_seFzys-kQVxe9vHYUh2_-dygl5FwzGB7bZjKlg>
<xmx:ixoBaS2c5S3aTgV0VgqGG2w8iY-ZLqHuc_oz5y2KjiGYwiGEfpLztQ>
<xmx:ixoBaacAe1x9hsiqRlWL1vOf0jimsrm_3IOxeIFmi1SdmMsdYL68JA>
<xmx:jBoBaTZdardPMInNzjmUlg9Twb8cItdY_oX9AbxuopjmRJr0z9B1hE-l>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Oct 2025 15:33:31 -0400 (EDT)
From: Steven Allen <steven@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible
in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake
In-Reply-To: <86tszion3j.fsf@HIDDEN>
References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN>
<87o6pr3qv3.fsf@HIDDEN> <87y0ougbk4.fsf@HIDDEN>
<86tszion3j.fsf@HIDDEN>
Date: Tue, 28 Oct 2025 12:33:29 -0700
Message-ID: <87pla6izxy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79686
Cc: sbaugh@HIDDEN, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 79686 <at> debbugs.gnu.org
>> Date: Tue, 28 Oct 2025 10:50:51 -0700
>> From: Steven Allen via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> 1. Start Emacs as a daemon under X, display :0.
>> 2. Then, open a terminal outside of Emacs and run:
>>
>> emacsclient -e '(with-selected-frame terminal-frame (make-frame `((window-system . x) (display . ":0"))))'
>>
>> This new frame will not have the `client' frame parameter set.
>
> Which is correct? Why is that a problem?
This behavior is correct. The frame created here CORRECTLY does not have
the `client' frame parameter set.
The issue is that there are several checks (see my latest patch) that
assume that all frames except the initial daemon frame will have this
`client' frame parameter set when Emacs is started as a daemon. Those
checks are making an incorrect assumption. That is, the following is not
a valid way to check if FRAME is the initial daemon frame:
(and (daemonp) (not (frame-parameter frame 'client)))
The correct check is:
(and (daemonp) (eq terminal-frame frame))
These checks are fixed in the provided patch.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 19:27:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 15:27:31 2025 Received: from localhost ([127.0.0.1]:54515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vDpLu-0002US-Bm for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:27:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33712) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vDpLR-0002TB-H3 for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:27:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vDpLE-0004WS-EI; Tue, 28 Oct 2025 15:26:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IujOw186sIYk9oDcGMGjctfKsLx4SH30cXfgxf7Hya8=; b=MJjX5OFNeZRq mEwsq/9M0zmOsBPxADtzRFUb0jYghXIeqw2tmowA0K+TKLCfzNn8jsE9KTKFQMz5v9SbrBkz/DOTM 0N4KtB6vCzy1SvnJ0Xnjykxv02pr3nxdhhKDmxCK4IukvsNlqgjrEk2yhT3LLfMvxxC36Vwt35g7P fcNeB01GgxErfreigJEuOzjDjhtWFebqwIuDdtF9qRi7rnwIhlxYDznntAnPugkVFotD/dbu5jzMK 7+zdxcXQMz7jOQfJKa79rgg99NbiDjZ11AlQ/Fu0frwHbT+baCL7FHmODQGSTQbrrRmf0AdTvowK7 V0LAjXjk+V9syCHFyY7FXA==; Date: Tue, 28 Oct 2025 21:26:44 +0200 Message-Id: <86sef2omiz.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Juri Linkov <juri@HIDDEN> In-Reply-To: <87h5vix3j2.fsf@HIDDEN> (message from Juri Linkov on Tue, 28 Oct 2025 20:52:17 +0200) Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> <87h5vix3j2.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79686 Cc: sbaugh@HIDDEN, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN, steven@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Spencer Baugh <sbaugh@HIDDEN>, 79686 <at> debbugs.gnu.org, > Steven Allen <steven@HIDDEN> > From: Juri Linkov <juri@HIDDEN> > Date: Tue, 28 Oct 2025 20:52:17 +0200 > > >>> The attached patch checks if the selected frame is a daemon's > >>> "terminal-frame" instead. > >> > >> Joao, since you just wrote this code, could you say whether this matches > >> your intention? > > > > I've tried that patch and it works. By "it works"", I mean it passes > > the four tests I listed in bug#77313. So at first glance it should be > > good to push. > > > > However, I don't understand how, to be honest. And that should be > > written somewhere. I do't understand how/when the current code (which I > > think was suggested by Juri) doesn't work. > > Checking for (frame-parameter nil 'client) was a common idiom > used in many places. Now Steven discovered a case where it fails. > So it would be correct to push the patch created by Steven > that fixes all these places at once. That depends on the purpose of the test. I'm not convinced that all of the places where the above is used want to test for the daemon's initial frame.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 19:15:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 15:15:08 2025 Received: from localhost ([127.0.0.1]:54452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vDp9v-0001nH-Kg for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:15:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47518) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vDp9p-0001jn-Uj for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 15:15:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vDp9i-000214-1c; Tue, 28 Oct 2025 15:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bZHFAUH9xq696ZgaS/ePzfsZczLf/rofBve6FFFcM4c=; b=TRYj9OXVg6sZ LZjOr51jVmLqlCUUW5CBx846JzbhfmS7I4QAYlACzBtuvx54zcxmLYM2//bFmpq+5qGJEDhxzfpRP kgdbLnD7h4lvpgDdgsxW0IM+9ksGEtr1jykZnmZW3d/LNJao76MWftU2H+2pMOSRtx7vi7jkS4gqx PD1ohu7amEGSf/03IVmK1pBNHKnoHC6EYD5K7cHt9a3KhNtzxYvSO0dziwyVFkyAufV1ak5hRZ8RU W6kP9C1RLqWXIQcKblsPxc8a7+J9DGr1Qh9hsikMA9ltpNt+8Fk3SFBExYUE+fNGvRCY4Y8yYEvE+ b3z+k463aK368RhtyE4dMw==; Date: Tue, 28 Oct 2025 21:14:24 +0200 Message-Id: <86tszion3j.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Steven Allen <steven@HIDDEN> In-Reply-To: <87y0ougbk4.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> <87y0ougbk4.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79686 Cc: sbaugh@HIDDEN, 79686 <at> debbugs.gnu.org, joaotavora@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 79686 <at> debbugs.gnu.org > Date: Tue, 28 Oct 2025 10:50:51 -0700 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > 1. Start Emacs as a daemon under X, display :0. > 2. Then, open a terminal outside of Emacs and run: > > emacsclient -e '(with-selected-frame terminal-frame (make-frame `((window-system . x) (display . ":0"))))' > > This new frame will not have the `client' frame parameter set. Which is correct? Why is that a problem?
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 18:56:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 14:56:14 2025 Received: from localhost ([127.0.0.1]:54424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vDore-0000n4-0p for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 14:56:14 -0400 Received: from mout-p-201.mailbox.org ([2001:67c:2050:0:465::201]:39764) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1vDorR-0000lv-Bw for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 14:56:07 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4cx02F6ylnz9svd; Tue, 28 Oct 2025 19:55:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1761677750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+2dktiJvYg1i4UdfK2jBc1Nm5uJnJzV/f0hQFCm05Uk=; b=N1/7FSKELc4VLBBuqMlbH4rOPa36flH/N/k/lAi0rDrU0rIxVk6a62WEnI9e75ks1koerS TK4pgGW9MUnJ41/3kvcGoI1Qf0kErACfWh077nIQ2xz1YQoIzA83qqOmhkp1rUAWNx5Oi4 obBbnVT/aWXPJKsj+/EzZBIcGMij2ElPO/q11KgIxpSKBeuaUzlQRUHZgDSCwrdFcWsSM/ uIKdFBqE61VUsEYvr0laPQByRd+iUyrYl/aaVuoOmXni7VMKX3TcbeU19yVZx+aA/gjrxD UrOKgLl0e3nya2FSMq8uo2S/8ad7lLonYECItXRHe4fEXsPDD7o5RnMWmuxwGw== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@HIDDEN designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=juri@HIDDEN From: Juri Linkov <juri@HIDDEN> To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= <joaotavora@HIDDEN> Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake In-Reply-To: <87o6pr3qv3.fsf@HIDDEN> Organization: LINKOV.NET References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN> <87o6pr3qv3.fsf@HIDDEN> Date: Tue, 28 Oct 2025 20:52:17 +0200 Message-ID: <87h5vix3j2.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4cx02F6ylnz9svd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79686 Cc: Spencer Baugh <sbaugh@HIDDEN>, 79686 <at> debbugs.gnu.org, Steven Allen <steven@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> The attached patch checks if the selected frame is a daemon's >>> "terminal-frame" instead. >> >> Joao, since you just wrote this code, could you say whether this matches >> your intention? > > I've tried that patch and it works. By "it works"", I mean it passes > the four tests I listed in bug#77313. So at first glance it should be > good to push. > > However, I don't understand how, to be honest. And that should be > written somewhere. I do't understand how/when the current code (which I > think was suggested by Juri) doesn't work. Checking for (frame-parameter nil 'client) was a common idiom used in many places. Now Steven discovered a case where it fails. So it would be correct to push the patch created by Steven that fixes all these places at once.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 18:21:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 14:21:55 2025
Received: from localhost ([127.0.0.1]:54338 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vDoKQ-0007DE-Kw
for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 14:21:55 -0400
Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]:43381)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vDoKI-0007Ck-Di
for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 14:21:50 -0400
Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45])
by mailfhigh.phl.internal (Postfix) with ESMTP id 1DB3D1400207;
Tue, 28 Oct 2025 14:21:39 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-05.internal (MEProxy); Tue, 28 Oct 2025 14:21:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:cc:content-type:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:subject:subject:to:to; s=fm2; t=1761675699; x=
1761762099; bh=A7skIu9HdiEr42BkyxMKRsp5zGPkwbifM3BGaA0Knks=; b=F
CR+5V1rf5s3CgGYo0PG3SlvQHgh5q5bhPrZnqKPg/RL9P5hok7STKxuZ7a2KhBeK
FeuFIwiR1Qf+44xt2qv+ZMgH3RtoGgId14F5boqjGE1kkk4ZB3crhQ/KC2evSKO7
lKouzGVVM+qxUFACLo12+pB5nXQisWApDV4XPe0GGhUlyaF0oeuAG1Ncr4OgVPIt
Rpqw0R6Llz/eew/rmBqWlBZBytsXDg8DxVEwcrg9jYV+FO0d98xftlqeVBcPMql2
1/IEnQptdGApJ5uks/5ao73mqarl/DASKgI0nhL7OLubVW8IM5T+aRH5sB38YJGz
eWIRd4sNHopPQN3WYQ7wQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1761675699; x=1761762099; bh=A7skIu9HdiEr42BkyxMKRsp5zGPkwbifM3B
GaA0Knks=; b=AYzdfPeuT410AcIJSG802a4hiRT4e8UcZHVGKBSbP/VL9Pz00Dg
tIq2k4Vd9ZR7AqU5aqBvh2ltodtfO7jx1aPlrPgrgroE+qDgEAd6w6DBc4tIVWTl
3zm6uwMpCsQIAQpgwfc9/1T5hWLLvT235nRWxnsxT9aYzxcL21Xgo0giA9/FaJoF
G3ihz9J2xR2rOiWNoO4hJIqaFyVlsVo5LL0Frp8uTJgmQn8KDW7WN39HGNwrr1K/
VW4E8MNSlBWLFMblgiqvyejheKY4i6SnbLWmWxocDS95D6diCKjvy3HF0yP0rzuR
xQUuERb4SU9pFgHxFbAQUPmnCbhMGRYYd3g==
X-ME-Sender: <xms:sgkBaRLubUMH6rcNlNkUFSmKFjr0CXFZVbOwC9vqZ1ynxiRBAnw2bg>
<xme:sgkBaUmBHEAewYfw0WshwL70tmS6z1K7zu1RHEGyCyTnccvvcs28E3NvncdsGy7g-
O4hYGXtIY_0enFk68mAesKQT9d4qIG8Y65gr3UyFO_BnTxlAkvlWwI>
X-ME-Received: <xmr:sgkBaXGqFJpkIo3T8ROAOP6ayLsvf5Z4vnAZUHkXSEKNWEw-FeOhOlRKtEAieQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduieduheeiucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurhephffvvefujghffffkgggtsehmtderredttdejnecuhfhrohhmpefuthgvvhgvnhcu
tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth
htvghrnhepudekvdekueehueeltdeivdfhkeffgeeggfeltdeileelteeftdetudelieeh
gfegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh
htvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohgu
vgepshhmthhpohhuthdprhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtg
homhdprhgtphhtthhopehssggruhhghhesjhgrnhgvshhtrhgvvghtrdgtohhmpdhrtghp
thhtohepjeelieekieesuggvsggsuhhgshdrghhnuhdrohhrgh
X-ME-Proxy: <xmx:sgkBacGb5DLpfqvLcsJam1-XFXiCHIl7q7Qd9Lzh2koWCB-JD8ZaCw>
<xmx:sgkBacMyk23ENJTu2VsiywSXgDhnwBJf1iZhMkcYsxaYDuAnTOrhGw>
<xmx:sgkBaTFQnddBoTxKmkNJVa8LLXMAobAZDsDul1kMtCpnZeQbAwhlSw>
<xmx:sgkBabM0Bv1rtkb-GyDonQQPmQUPhP-KwdOqeh5U5OO8-YOB_pkHuQ>
<xmx:swkBaSEEo-XINceUwkjd6IhQk92_dmQU5HHOSCYlF3HmNnTBhpIk5-F4>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Oct 2025 14:21:38 -0400 (EDT)
From: Steven Allen <steven@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>, Spencer Baugh
<sbaugh@HIDDEN>
Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible
in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake
In-Reply-To: <87y0ougbk4.fsf@HIDDEN>
References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN>
<87o6pr3qv3.fsf@HIDDEN> <87y0ougbk4.fsf@HIDDEN>
Date: Tue, 28 Oct 2025 11:21:36 -0700
Message-ID: <87v7jyga4v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79686
Cc: 79686 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Steven Allen <steven@HIDDEN> writes:
> Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
>
>> Spencer Baugh <sbaugh@HIDDEN> writes:
>>
>>> Steven Allen <steven@HIDDEN> writes:
>>>> Tags: patch
>>>>
>>>>
>>>> Flymake does not start automatically when:
>>>>
>>>> 1. Emacs is started as a daemon.
>>>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>>>>
>>>> This is because the (frame-parameter nil 'client) check fails, because
>>>> the frame wasn't created by emacsclient.
>>>>
>>>> The attached patch checks if the selected frame is a daemon's
>>>> "terminal-frame" instead.
>>>
>>> Joao, since you just wrote this code, could you say whether this matches
>>> your intention?
>>
>> I've tried that patch and it works. By "it works"", I mean it passes
>> the four tests I listed in bug#77313. So at first glance it should be
>> good to push.
>>
>> However, I don't understand how, to be honest. And that should be
>> written somewhere. I do't understand how/when the current code (which I
>> think was suggested by Juri) doesn't work.
>>
>> To quote Steven
>>
>>>> 1. Emacs is started as a daemon.
>>
>> Well, that's the point. But I suspect Steven knows this?
>> 'flymake-start' is supposed to be called, but defer itself.
>>
>>>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>>
>> I need better instrutions. All the 'make-frame' I've tried work
>> correctly.
>
> I see. It looks like `client' is inherited from the selected frame when
> you create a new frame.
>
> To reproduce:
>
> 1. Start Emacs as a daemon under X, display :0.
> 2. Then, open a terminal outside of Emacs and run:
>
> emacsclient -e '(with-selected-frame terminal-frame (make-frame `((wi=
ndow-system . x) (display . ":0"))))'
>
> This new frame will not have the `client' frame parameter set.
I've attached a more complete patch that fixes all cases of this.
For some context, I'm running into this because I create my initial
GUI frame programatically by evaluating an s-expression with emacsclient.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-More-reliably-check-if-a-frame-is-the-daemon-s-initi.patch
From da25b3997a483634a8f6cba8e40df3d10af86f14 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@HIDDEN>
Date: Tue, 28 Oct 2025 11:08:53 -0700
Subject: [PATCH] More reliably check if a frame is the daemon's initial frame
Frames created when Emacs is running as a daemon may not have the
"client" frame parameter set, e.g., when:
1. Created from the user's init file.
2. Created via "emacsclient -e" (e.g., "emacsclient -e '(make-frame)'").
The "client" parameter simply indicates that the frame was created by
emacsclient directly (or recursively from another emacsclient frame).
Instead, this commit checks if (a) Emacs is running as a daemon and (b)
the target frame is the "terminal frame". When run as a daemon, Emacs's
terminal frame is always the daemon's initial frame.
* lisp/desktop.el (desktop-clear):
(desktop-restoring-frameset-p):
* lisp/display-fill-column-indicator.el
(display-fill-column-indicator--turn-on):
* lisp/frame.el (frame-notice-user-settings):
* lisp/obsolete/linum.el (linum-on):
* lisp/progmodes/flymake.el (flymake-start):
* lisp/tab-bar.el (tab-bar--update-tab-bar-lines): Fix the "is this the
initial daemon-frame" checks. (Bug#79686)
---
lisp/desktop.el | 4 ++--
lisp/display-fill-column-indicator.el | 2 +-
lisp/frame.el | 2 +-
lisp/obsolete/linum.el | 2 +-
lisp/progmodes/flymake.el | 2 +-
lisp/tab-bar.el | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lisp/desktop.el b/lisp/desktop.el
index b82a9dc9626..f85b56d0e61 100644
--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -775,7 +775,7 @@ desktop-clear
;; Don't delete daemon's initial frame, or
;; we'll never be able to close the last
;; client's frame (Bug#26912).
- (if (daemonp) (not (frame-parameter frame 'client)))
+ (and (daemonp) (eq frame terminal-frame))
(frame-parameter frame 'desktop-dont-clear))
(delete-frame frame))
(error
@@ -1255,7 +1255,7 @@ desktop-restoring-frameset-p
(and desktop-restore-frames desktop-saved-frameset
;; Don't restore frames when the selected frame is the daemon's
;; initial frame.
- (not (and (daemonp) (not (frame-parameter nil 'client))))
+ (not (and (daemonp) (eq frame terminal-frame)))
t))
(defun desktop-restore-frameset ()
diff --git a/lisp/display-fill-column-indicator.el b/lisp/display-fill-column-indicator.el
index dbd067f5f3d..4598b659341 100644
--- a/lisp/display-fill-column-indicator.el
+++ b/lisp/display-fill-column-indicator.el
@@ -102,7 +102,7 @@ display-fill-column-indicator-mode
(defun display-fill-column-indicator--turn-on ()
"Turn on `display-fill-column-indicator-mode'."
(unless (or (minibufferp)
- (and (daemonp) (null (frame-parameter nil 'client))))
+ (and (daemonp) (eq (selected-frame) terminal-frame)))
(display-fill-column-indicator-mode)))
;;;###autoload
diff --git a/lisp/frame.el b/lisp/frame.el
index b6641ca716a..6e18ba65d9a 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -493,7 +493,7 @@ frame-notice-user-settings
(setq parms (append initial-frame-alist window-system-frame-alist
default-frame-alist parms nil))
;; Don't enable tab-bar in daemon's initial frame.
- (when (and (daemonp) (not (frame-parameter nil 'client)))
+ (when (and (daemonp) (eq (selected-frame) terminal-frame))
(setq parms (delq (assq 'tab-bar-lines parms) parms)))
parms))
(if (null initial-window-system) ;; MS-DOS does this differently in pc-win.el
diff --git a/lisp/obsolete/linum.el b/lisp/obsolete/linum.el
index e0782258716..75cb1199927 100644
--- a/lisp/obsolete/linum.el
+++ b/lisp/obsolete/linum.el
@@ -129,7 +129,7 @@ linum-on
;; Note that nowadays, this actually doesn't show line
;; numbers in client frames at all, because we visit the
;; file before creating the client frame. See bug#35726.
- (and (daemonp) (null (frame-parameter nil 'client))))
+ (and (daemonp) (eq (selected-frame) terminal-frame)))
(linum-mode 1)))
(defun linum-delete-overlays ()
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 7af4ea334d6..60a6bacf640 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1390,7 +1390,7 @@ flymake-start
(cl-labels
((visible-buffer-window ()
(and (or (not (daemonp))
- (not (null (frame-parameter nil 'client))))
+ (not (eq (selected-frame) terminal-frame)))
(get-buffer-window (current-buffer))))
(start-post-command ()
(remove-hook 'post-command-hook #'start-post-command
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index db16775d884..6653d12f634 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -282,7 +282,7 @@ tab-bar--update-tab-bar-lines
(and (eq auto-resize-tab-bars 'grow-only)
(> (frame-parameter frame 'tab-bar-lines) 1))
;; Don't enable tab-bar in daemon's initial frame.
- (and (daemonp) (not (frame-parameter frame 'client))))
+ (and (daemonp) (eq frame terminal-frame)))
(set-frame-parameter frame 'tab-bar-lines
(tab-bar--tab-bar-lines-for-frame frame)))))
;; Update `default-frame-alist'
--
2.51.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 17:51:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 13:51:12 2025
Received: from localhost ([127.0.0.1]:54228 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vDnqh-00056w-Uz
for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 13:51:12 -0400
Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:54013)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vDnqZ-00056C-5u
for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 13:51:08 -0400
Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44])
by mailfout.stl.internal (Postfix) with ESMTP id 07B3E1D000BB;
Tue, 28 Oct 2025 13:50:55 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-04.internal (MEProxy); Tue, 28 Oct 2025 13:50:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:cc:content-transfer-encoding:content-type:content-type
:date:date:from:from:in-reply-to:in-reply-to:message-id
:mime-version:references:reply-to:subject:subject:to:to; s=fm2;
t=1761673854; x=1761760254; bh=uwH9BxRCoH0sKm5c+8/drFF5Qt+ttJG/
T4L24eo5Fn8=; b=SMNLsn39aV+Z7LU/nV1AjToOZ4RUDaZ2x6ScvEGm99cNRBTd
SuEyQqayUUfuoHI9CcU+AVpMuJ4TB+u9IT213rbVCzMUg1GzgLch/65fQ0IxFLKp
NZhqouuqRT7MraOPOkY1FoQaqOcefcW8aK7eaVc3aLf5piV5lyr7jQNeBgAiX/9y
ZTFBUpDttZGXnzUqzmdskjOb/SCMhTlw2rWDJHA/n+gt3ts+A3Rxx0i/vjVaQSoV
sWw61nHuzC0Gafu6VKKLkWHhKc1QmC0gdZX/FAxcYcYZOXLmB04i61yEkTPXAsdy
YaYuweB0u6IuQDDITQKZedhRCYnkqX4z3sFM/Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1761673854; x=
1761760254; bh=uwH9BxRCoH0sKm5c+8/drFF5Qt+ttJG/T4L24eo5Fn8=; b=S
RJxtFJ248JVyNVhQYrsA9MDF1UTDQGX91BCN/6lfyC7o2wduZ3TTafSlZb+6p6xA
OyaZOUrt4BKEBjp8A8edXMC4W5L7zd79muiFnGARW33nTrJL3TeFRToRbZdKOeH+
oC4/zUbUpU6zLLJhBbSpGnExBm3iNyFkJ9tvuo8MU04rRN+HTiMCbHTjd53+ftx/
ejxd5G+2pbdxlKt5FN+66fQO3w4sp08+jcZym6RR6Z4bPOS14JOIDS0InuY+LLsX
4kjKs0/PALtT93d4Xc1GcxBRG8dkuq1vTsWnLo1UT3Kq10IHh+wlyQEBgPZvBxne
S3KzMHgMCCuLP2WSzn++w==
X-ME-Sender: <xms:fgIBaT_k_RVNs0J4Bse68LpPVfw72m0qNi7vbZiqipJp5_EV12fSpQ>
<xme:fgIBaXLAEDbJzy8IuJ7NbIxn5ESX07aVbFpfPTPNdt2FMaMCpphJ9msUDgy4ve01b
DRO5_JMEjTBZd4EIl3SM-eOvaTL0nvdqgExhsPh4sXdzCxbx1CfABk>
X-ME-Received: <xmr:fgIBaeZknoseaQjyvbvta2EkZ84qGLyrnI0nEb0SlbPd-OCXWb9rl5Dttyny_g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduiedugeelucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf
gurhephffvvefujghffffkgggtgfesthhqredttddtjeenucfhrhhomhepufhtvghvvghn
ucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrg
htthgvrhhnpeefvdduheefuedvteevteeiveejgedtteeghfelgfegueehvefhffeliedv
teeiudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
hsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgspghrtghpthhtohepfedpmhho
uggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrd
gtohhmpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgt
phhtthhopeejleeikeeiseguvggssghughhsrdhgnhhurdhorhhg
X-ME-Proxy: <xmx:fgIBaZId6iGerzwqwXS_mgzFaQuGMKmR-Yk_wJBBHmbo7V3jHB8-5Q>
<xmx:fgIBacA-ORD92BqfY2l3FnqUuVBUCckSNmTU9c_q4IK-gXk27naAOQ>
<xmx:fgIBaeq4UbrhRJP6zb1B1_H0aV1stx9Azs0uvM3RXFUYvp1qP1aVeA>
<xmx:fgIBaXgBeZLw-DnAjhBVcxYdyeyQ8-ZsUl508uTafKJvSBOV-njjpA>
<xmx:fgIBaXL792JufSJpFq82MSDDUAY3QX6IwpVwABMkwyKd3WwVkJOBevkx>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
28 Oct 2025 13:50:54 -0400 (EDT)
From: Steven Allen <steven@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>, Spencer Baugh
<sbaugh@HIDDEN>
Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible
in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake
In-Reply-To: <87o6pr3qv3.fsf@HIDDEN>
References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN>
<87o6pr3qv3.fsf@HIDDEN>
Date: Tue, 28 Oct 2025 10:50:51 -0700
Message-ID: <87y0ougbk4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 79686
Cc: 79686 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:
> Spencer Baugh <sbaugh@HIDDEN> writes:
>
>> Steven Allen <steven@HIDDEN> writes:
>>> Tags: patch
>>>
>>>
>>> Flymake does not start automatically when:
>>>
>>> 1. Emacs is started as a daemon.
>>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>>>
>>> This is because the (frame-parameter nil 'client) check fails, because
>>> the frame wasn't created by emacsclient.
>>>
>>> The attached patch checks if the selected frame is a daemon's
>>> "terminal-frame" instead.
>>
>> Joao, since you just wrote this code, could you say whether this matches
>> your intention?
>
> I've tried that patch and it works. By "it works"", I mean it passes
> the four tests I listed in bug#77313. So at first glance it should be
> good to push.
>
> However, I don't understand how, to be honest. And that should be
> written somewhere. I do't understand how/when the current code (which I
> think was suggested by Juri) doesn't work.
>
> To quote Steven
>
>>> 1. Emacs is started as a daemon.
>
> Well, that's the point. But I suspect Steven knows this?
> 'flymake-start' is supposed to be called, but defer itself.
>
>>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>
> I need better instrutions. All the 'make-frame' I've tried work
> correctly.
I see. It looks like `client' is inherited from the selected frame when
you create a new frame.
To reproduce:
1. Start Emacs as a daemon under X, display :0.
2. Then, open a terminal outside of Emacs and run:
emacsclient -e '(with-selected-frame terminal-frame (make-frame `((wind=
ow-system . x) (display . ":0"))))'
This new frame will not have the `client' frame parameter set.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 16:57:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 12:57:29 2025
Received: from localhost ([127.0.0.1]:54097 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vDn0i-0001dx-RT
for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 12:57:29 -0400
Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:60907)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1vDn0e-0001dS-52
for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 12:57:25 -0400
Received: by mail-wm1-x32c.google.com with SMTP id
5b1f17b1804b1-46e6a689bd0so62387375e9.1
for <79686 <at> debbugs.gnu.org>; Tue, 28 Oct 2025 09:57:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1761670636; x=1762275436; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=yUo2uezMiqmsg3tyLo+MqiVB41kcd4coLPVRNBD8ZY4=;
b=l9Xu6akQsGjnmBhR6LcoDaZhRa5nJAdAYrkLCSGbgmS/Uy+89gRX2MiYG95/FUni0T
Nf+ttqEvEBr8KZZG9/xH0UHYdNSPqmyqm1TIIOZapGp/mIT77QkNA+1evgGir3sNHt1u
KgqfFM9KxvJPMb3xp9XR5xDHKBDL5F7EuLrwzfzAmDpgCu3KfVNwIizc2zXMmHNYuOQn
vIOSJgP49NKpMlM843fOeDhTQT9ChzXHQlMGHZVTXXXPAPyYTkPYw3OY6Qc1NHZHI33h
Bx9CxM0RFEAfUIcITFmrGr/Vi+4pZ2Nq+w94xOFeWAxzeuYSlrF/AjlMfT5B/rm1Vwg7
xeMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1761670636; x=1762275436;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=yUo2uezMiqmsg3tyLo+MqiVB41kcd4coLPVRNBD8ZY4=;
b=pwn+TzoZRpHWuGJkNcR8Z0uHdaTzuU4/qbFroJnjah6FNoEVttpeDamnTNTFD9J7jo
xjYhtmJskOzlZonDU9h/i864stwrg2fqSN/hn3U9NOrbh4xrJbzIbqolaCRNn95j5KFr
Yu4rhJahV4klrveOPTiuH+jzKlG19LNEE3gL6nEwlhHid/nsVKzXrJ5YrDNKD4NUM/Kk
0KlIgp7ZSh0GTCNA0qHZJgn6X0QR+kO0MO1NrA2AsQkpeVETC4x4Cxny+hbVGj4bJlAO
e+nNZY+xNkzt+q/4a9ATCgiuT/8xSO0Vex8vbSYx6yAy5Io7NF5veeiRvceLyAcM+iey
Twnw==
X-Forwarded-Encrypted: i=1;
AJvYcCU4lmNt0A0OFRurqHNAS4m0zhSEMigjK6Mc7yx/LTiMxWAZdAHKl+Xlv6djHJnoruE0PEX3qg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yx6XO347x31UZJwves8JsYI7WorVVZrO0dNDVjdhVtAXMHAgG6/
Qh+LTx5eCNZc3yQZ6cAQ2HjHs6VGzKzl9bbiv3tO90YlUcd4WkbV/HBXyHQHLQ==
X-Gm-Gg: ASbGnct667ZPyYRyEUjrySI1ydpMiUTCe9/of1D7g2OuogwoqXtpCusHe3745DHsSog
t82+iLCHip8HlF9yAtTCze9lV5DU7S7H5UPK6Nvzu0jexmwpAzo9R1pIW/n8uAPe2kFiUAdiVvV
jj8GWVN8SuvY7EeRbAcvrqWSW1TsYjVDD/tm7B1uiqxf6vA9kjxtwU0wUdtT3LhEFhnSSKA69jI
l+ClJvxsP7KmXqHEghXwH+kMbiU48sCmKhAdN9mmXKBvJF8Cyz4J3zYXhMzcL5sZpHVRe7EgHvz
J0hPAfbzAp81jYCOoJrtqQG1k0xsOYcZL+hlYqiJ+IqddPqM1LjroxqCPiA+TWiLfJmeAYUHEl+
xxjQnl6WSiaakP2kxnPd2QGJ8umvk3XSM8txYIrDtFmokH+49fwyqipzWVucNdRO2pfuwSXbbYe
Ua/zBZy59gtsd/yeC5wA==
X-Google-Smtp-Source: AGHT+IE7bTj8Zwe8Qkygz3lyftG08xQ0Exoic/D5o5BigyaSYwG8Zwumh2b/S8Fh3/ASojFJ8m7IEQ==
X-Received: by 2002:a05:600c:8b71:b0:46e:3d41:6001 with SMTP id
5b1f17b1804b1-4771e1e267cmr1523435e9.34.1761670635820;
Tue, 28 Oct 2025 09:57:15 -0700 (PDT)
Received: from krug (87-196-72-166.net.novis.pt. [87.196.72.166])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-4771e196b27sm2372635e9.8.2025.10.28.09.57.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 28 Oct 2025 09:57:15 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible
in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake
In-Reply-To: <ierqzun6phz.fsf@HIDDEN>
References: <874irpcfr9.fsf@HIDDEN> <ierqzun6phz.fsf@HIDDEN>
Date: Tue, 28 Oct 2025 16:58:40 +0000
Message-ID: <87o6pr3qv3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Spencer Baugh writes: > Steven Allen writes: >> Tags: patch
>> >> >> Flymake does not start automatically when: >> >> 1. Emacs is started
as a daemon. >> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>> >> [...]
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (joaotavora[at]gmail.com)
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [2a00:1450:4864:20:0:0:0:32c listed in]
[list.dnswl.org]
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[87.196.72.166 listed in zen.spamhaus.org]
X-Debbugs-Envelope-To: 79686
Cc: 79686 <at> debbugs.gnu.org, Steven Allen <steven@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Spencer Baugh writes: > Steven Allen writes: >> Tags: patch
>> >> >> Flymake does not start automatically when: >> >> 1. Emacs is started
as a daemon. >> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>> >> [...]
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS
[87.196.72.166 listed in zen.spamhaus.org]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2a00:1450:4864:20:0:0:0:32c listed in]
[list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (joaotavora[at]gmail.com)
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Spencer Baugh <sbaugh@HIDDEN> writes:
> Steven Allen <steven@HIDDEN> writes:
>> Tags: patch
>>
>>
>> Flymake does not start automatically when:
>>
>> 1. Emacs is started as a daemon.
>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
>>
>> This is because the (frame-parameter nil 'client) check fails, because
>> the frame wasn't created by emacsclient.
>>
>> The attached patch checks if the selected frame is a daemon's
>> "terminal-frame" instead.
>
> Joao, since you just wrote this code, could you say whether this matches
> your intention?
I've tried that patch and it works. By "it works"", I mean it passes
the four tests I listed in bug#77313. So at first glance it should be
good to push.
However, I don't understand how, to be honest. And that should be
written somewhere. I do't understand how/when the current code (which I
think was suggested by Juri) doesn't work.
To quote Steven
>> 1. Emacs is started as a daemon.
Well, that's the point. But I suspect Steven knows this?
'flymake-start' is supposed to be called, but defer itself.
>> 2. The frame is created with (make-frame) and/or "C-x 5 2".
I need better instrutions. All the 'make-frame' I've tried work
correctly.
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.Received: (at 79686) by debbugs.gnu.org; 28 Oct 2025 15:00:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 28 11:00:06 2025 Received: from localhost ([127.0.0.1]:53743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vDlB8-0003LP-Ia for submit <at> debbugs.gnu.org; Tue, 28 Oct 2025 11:00:06 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:53477) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <sbaugh@HIDDEN>) id 1vDlB3-0003Hm-Ds for 79686 <at> debbugs.gnu.org; Tue, 28 Oct 2025 11:00:03 -0400 From: Spencer Baugh <sbaugh@HIDDEN> To: Steven Allen <steven@HIDDEN> Subject: Re: bug#79686: [PATCH] Correctly determine if a buffer is visible in Flymake, [PATCH] Correctly determine if a buffer is visible in Flymake In-Reply-To: <874irpcfr9.fsf@HIDDEN> (Steven Allen's message of "Thu, 23 Oct 2025 17:20:10 -0700") References: <874irpcfr9.fsf@HIDDEN> Date: Tue, 28 Oct 2025 10:59:52 -0400 Message-ID: <ierqzun6phz.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1761663592; bh=X1eloR//fOamPAmad/mhJrxToI+bF77F9EaJmH+9Sl4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=m9zNVfz9b//JzjhKyq04FsBbENi7HvzrkHZj4AwfKaMPQq5yjVP5W40t0PR8aKPrW N/s/XvI46JpzFFuvKg2lfTCPZtlSGIlp36JGoobxcc8QUbGI3cap6LUYE1rE21HFa8 U9xcM74He4N6rHA/GLfxVsfAr3rgKO0HGEgWPYJaKJAL/fdk3SafdLpeP7L7eqKJAj p7bE7R3dq8809DTp+fH3PVYeYFiioB+ApUgqOC+Ux3xTKXh2KecHT1HaKiPthPvGFI JHegqWG/INc7jyVcSyGLrly+Mh6jqzM3txJR17zV5qfDXxPEc8kFlf978g1eAGxnMq PKi2JXTZ3/pyw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79686 Cc: 79686 <at> debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Steven Allen <steven@HIDDEN> writes: > Tags: patch > > > Flymake does not start automatically when: > > 1. Emacs is started as a daemon. > 2. The frame is created with (make-frame) and/or "C-x 5 2". > > This is because the (frame-parameter nil 'client) check fails, because > the frame wasn't created by emacsclient. > > The attached patch checks if the selected frame is a daemon's > "terminal-frame" instead. Joao, since you just wrote this code, could you say whether this matches your intention?
bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 24 Oct 2025 00:20:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 23 20:20:38 2025
Received: from localhost ([127.0.0.1]:34234 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vC5Xq-0000e5-Dg
for submit <at> debbugs.gnu.org; Thu, 23 Oct 2025 20:20:38 -0400
Received: from lists.gnu.org ([2001:470:142::17]:50968)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <steven@HIDDEN>)
id 1vC5Xm-0000dg-I3
for submit <at> debbugs.gnu.org; Thu, 23 Oct 2025 20:20:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <steven@HIDDEN>)
id 1vC5Xg-0001UW-Vk
for bug-gnu-emacs@HIDDEN; Thu, 23 Oct 2025 20:20:29 -0400
Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <steven@HIDDEN>)
id 1vC5Xc-0006Sv-A2
for bug-gnu-emacs@HIDDEN; Thu, 23 Oct 2025 20:20:28 -0400
Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50])
by mailfout.phl.internal (Postfix) with ESMTP id 234A2EC0209
for <bug-gnu-emacs@HIDDEN>; Thu, 23 Oct 2025 20:20:13 -0400 (EDT)
Received: from phl-mailfrontend-01 ([10.202.2.162])
by phl-compute-10.internal (MEProxy); Thu, 23 Oct 2025 20:20:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com;
h=cc:content-type:content-type:date:date:from:from:in-reply-to
:message-id:mime-version:reply-to:subject:subject:to:to; s=fm1;
t=1761265213; x=1761351613; bh=/4fHU3z0mgLC6NEZz9BzwPNjdGarKAQX
MSrZwememK4=; b=AqEvlqXkJX33Eq+mHwOrVek7o/AIbgi/mDj/owRPG5I5e+1y
o0yu3gpiRdu8CcmxVvksSNrMSIOYHNJaXV3jUsqePpTWejhysJugg2TTSDJIDq8U
aKU48t0V+X7IZuTN70j05L7fwmQRqTRomteuBx6KuHPP3prDTSA17xPMIaU5uKjv
q9puW6e45d48RqeMTKbG04eU9dNJmgtiZzOkQzQkdnz2rNyS+ubju+EoS2KZddXX
8i8KAkiCfSKEPmISPC6RKgd8Uur9CdvQts2LCVUzcIOyVyTIXyGzz4BKohZWb232
oUVxEVgkXM4wUe/SCo0mbDd4fPZHCLrVSJAATQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:message-id
:mime-version:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1761265213; x=
1761351613; bh=/4fHU3z0mgLC6NEZz9BzwPNjdGarKAQXMSrZwememK4=; b=i
WI+7AlOyxG7PCvRCwnipjoIRtZXHVCfSbttu6lzT147iKlvzOu1s0EOLm8EIFKk6
A5n5Ey1JRBzDmLTIWmK1F9CkV2xv7rWb4yiRwH/MWmj2RYAxNoeMntj3xMAxe5c7
BNLQLHVBfYl9+CJ/YzHeYyoANil+7dz0Mg9i9ZhIouQUHdOIDpb3zvev4fsdJZFn
r0hLJqzuP8czXiLyVsjoh1Awj8Iu/rUsJlKzWdRKfl4J3Mq7RerRrM+Gx5X9+n0B
ZWiwlBO49IMcsB9kLId1utDvZTLpzgTmJtwyGElbiW6otSPqdioc+2K7tyqIkFte
/2vockyd+AJfMlFhTFGfg==
X-ME-Sender: <xms:PMb6aHsqsGz4OJ8ETaVKKYmTZP1jAgobWQ2czOXz4Wp6hp4me_iL6Q>
<xme:PMb6aOUpLtN19snvxm4hZKKDLexZDX_Duwqv8J4mWCanmkZoMarvBgp0ibranTtEa
WJHVqa4jjbOGw7k6kTyu3l6ksHFXDM7KesvFemDSPsH7epHAK8Kpl8>
X-ME-Received: <xmr:PMb6aF1hGKJEwR51o-wcf4KXNfoflGNZkbz6oNqeaheKqtYVu1fULwZaQLFagw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddugeejkeekucetufdoteggodetrf
dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu
rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttddtne
cuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgv
nhdrtghomheqnecuggftrfgrthhtvghrnhepkefffffgveethedtieffleffgeekvdeiie
egheeftdetjeekfefhvedttdekfeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
rghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsg
gprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhg
nhhuqdgvmhgrtghssehgnhhurdhorhhg
X-ME-Proxy: <xmx:PMb6aDAXN_oKMXy12MngEHD96lydGB7B4DXzkq7ew34Gw1RR3cBMBg>
<xmx:PMb6aLhqrIRof_iNFZjkufQHBPfAaqcPFSmwpl9nwPXHELNeFo9Kqw>
<xmx:PMb6aH9BYL_wH0UsA2URoABIbIzFdn8advFrOK7aRi5LNAW-S78QZQ>
<xmx:PMb6aH_yDBve8PltRpzPvrE-ZykrcFuWkH5w-kCpKj-ZvciFdUlsIQ>
<xmx:Pcb6aINtfH3wuC99uCnGPUwsaVbd2nW6A1_NV5TH65ECs6KsGJYDSXzV>
Feedback-ID: ie8a146a7:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
<bug-gnu-emacs@HIDDEN>; Thu, 23 Oct 2025 20:20:12 -0400 (EDT)
From: Steven Allen <steven@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Correctly determine if a buffer is visible in Flymake
X-Debbugs-Cc: Spencer Baugh <sbaugh@HIDDEN>, =?utf-8?B?Sm/Do28g?=
=?utf-8?B?VMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Thu, 23 Oct 2025 17:20:10 -0700
Message-ID: <874irpcfr9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=103.168.172.144;
envelope-from=steven@HIDDEN; helo=fout-a1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
Flymake does not start automatically when:
1. Emacs is started as a daemon.
2. The frame is created with (make-frame) and/or "C-x 5 2".
This is because the (frame-parameter nil 'client) check fails, because
the frame wasn't created by emacsclient.
The attached patch checks if the selected frame is a daemon's
"terminal-frame" instead.
In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version
1.18.4) of 2025-10-20 built on Laptop
Repository revision: c589bd5cc27c4885ada4d88f533a2ffb1d0dbb95
Repository branch: merged
Windowing system distributor 'The X.Org Foundation', version 11.0.12101018
System Description: Arch Linux
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
--with-modules --without-m17n-flt --without-selinux --without-pop
--without-gconf --disable-gc-mark-trace --with-mps=yes
--enable-autodepend --enable-link-time-optimization
--with-native-compilation=yes --with-xinput2 --with-x-toolkit=no
--without-toolkit-scroll-bars --without-xaw3d --without-gsettings
--with-cairo-xcb --without-xft --with-sound=no --with-tree-sitter
--without-gpm --without-compress-install
'--program-transform-name=s/\([ec]tags\)/\1.emacs/'
'CFLAGS=-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -fomit-frame-pointer
-fno-math-errno -fno-trapping-math -Os -fno-math-errno
-fno-trapping-math -Os -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common
-Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs
-flto=auto''
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Correctly-determine-if-a-buffer-is-visible-in-Flymak.patch
From d076515d0a6ef830d09e5c2a3c3d6f3161737b3d Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@HIDDEN>
Date: Thu, 23 Oct 2025 17:13:45 -0700
Subject: [PATCH] Correctly determine if a buffer is visible in Flymake
The previous code only started flymake on emacsclient, not explicitly
created frames, when Emacs was running as a daemon. This patch fixes
this by inverting the check and checking of the selected frame is the
daemon frame.
* lisp/progmodes/flymake.el (flymake-start): Check if the selected frame
is the "terminal" (daemon) frame instead of checkinf if it's not a
client frame.
---
lisp/progmodes/flymake.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 0585d128d31..224501327be 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1390,7 +1390,7 @@ flymake-start
(cl-labels
((visible-buffer-window ()
(and (or (not (daemonp))
- (not (null (frame-parameter nil 'client))))
+ (not (eq (selected-frame) terminal-frame)))
(get-buffer-window (current-buffer))))
(start-post-command ()
(remove-hook 'post-command-hook #'start-post-command
--
2.51.1
--=-=-=--
Steven Allen <steven@HIDDEN>:sbaugh@HIDDEN, joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.sbaugh@HIDDEN, joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN:bug#79686; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.