GNU bug report logs - #79697
[patch] eglot: fix eldoc composed reporting

Previous Next

To reply to this bug, email your comments to 79697 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lua Viana Reis <me <at> lua.blog.br>
To: bug-gnu-emacs <at> gnu.org
Subject: [patch] eglot: fix eldoc composed reporting
Date: Sun, 26 Oct 2025 03:26:06 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Eglot sets "eldoc-documentation-strategy" to 
"eldoc-documentation-compose", which means that the eldoc echo area only 
gets displayed after *all* the documentation functions call the callback.

The problem is that some language servers may return an error or timeout 
for specific requests, in which case the other eldoc functions never 
have a chance to appear.

This patch simply calls the eldoc callback with "nil" in the case of an 
error or timeout. This tells eldoc that the documentation function 
produced no output, and therefore the compose strategy can proceed to 
show the other functions.


Lua

[0001-eglot-call-eldoc-callback-on-errors-or-timeouts.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lua Viana Reis <me <at> lua.blog.br>
To: bug-gnu-emacs <at> gnu.org, João Távora
 <joaotavora <at> gmail.com>
Subject: Re: [patch] eglot: fix eldoc composed reporting
Date: Mon, 27 Oct 2025 15:56:59 +0000 (UTC)

copying João :)

Em 26/10/2025 00:26, Lua Viana Reis escreveu:
> Eglot sets "eldoc-documentation-strategy" to 
> "eldoc-documentation-compose", which means that the eldoc echo area 
> only gets displayed after *all* the documentation functions call the 
> callback.
>
> The problem is that some language servers may return an error or 
> timeout for specific requests, in which case the other eldoc functions 
> never have a chance to appear.
>
> This patch merely calls the eldoc callback with "nil" in the case of 
> an error or timeout. This tells eldoc that the documentation function 
> produced no output, and therefore the compose strategy can proceed to 
> show the other functions.
>
>
> Lua

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.