GNU bug report logs - #79718
package-upgrade-all should upgrade built-in packages when package-install-upgrade-built-in

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 29 Oct 2025 11:18:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 29 07:18:36 2025
Received: from localhost ([127.0.0.1]:57938 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1vE4CJ-0006rT-Ht
	for submit <at> debbugs.gnu.org; Wed, 29 Oct 2025 07:18:36 -0400
Received: from lists.gnu.org ([2001:470:142::17]:45780)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mekeor@HIDDEN>) id 1vE4CC-0006qs-PW
 for submit <at> debbugs.gnu.org; Wed, 29 Oct 2025 07:18:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mekeor@HIDDEN>) id 1vE4C2-0003z0-EC
 for bug-gnu-emacs@HIDDEN; Wed, 29 Oct 2025 07:18:20 -0400
Received: from mout02.posteo.de ([185.67.36.66])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mekeor@HIDDEN>) id 1vE4BF-0006JO-FQ
 for bug-gnu-emacs@HIDDEN; Wed, 29 Oct 2025 07:18:15 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 360FC240101
 for <bug-gnu-emacs@HIDDEN>; Wed, 29 Oct 2025 12:16:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017;
 t=1761736619; bh=a2OB4hs2SqInlgHOAk6Z2pbT+Oo9PQKeV1Hx8lyYwmw=;
 h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From;
 b=MNJiyi1U/smRkelT+T7mhElEDKh5s4BfLTjFxFT8IfZ5JTvKiosZCqMNYjw/bBN0m
 T5AYr3OaHNX6bBlbKr1j2JFfBTCxNdJqtUh82IcwbjCckXjA1NVGn/m7nigrhSW7EF
 n8InfySu1ThnnMIFEx/XjoOqKuGkPlxTcBoZ0YbJJ8oGuEjvJIVPEoKQsl/koT76aE
 j8ftMUnvt3I91DSMLrJ7oVjnHy7NM6RX3jQlM2qACNWBVoR26iqkiufNrUD6uyfh9u
 sypI7VQ+vAic5cnAk4qrgp7ci3kQZlwlnhNuFZo4ZUEt0C7lxHKNrfMO2q0x8f0VJJ
 DNIrW/WcIBexA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4cxPpL31Syz9rxM;
 Wed, 29 Oct 2025 12:16:58 +0100 (CET)
From: Mekeor Melire <mekeor@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: package-upgrade-all should upgrade built-in packages when
 package-install-upgrade-built-in
X-Debbugs-Cc: tromey@HIDDEN, dan@HIDDEN, philipk@HIDDEN
Date: Wed, 29 Oct 2025 11:16:58 +0000
Message-ID: <87zf9ax8m2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.66; envelope-from=mekeor@HIDDEN;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

As a user of the most recently released stable version of Emacs,
for packages that are both built into Emacs core as well as
distributed via GNU- or NonGNU-Elpa, I prefer to use their
Elpa-versions (which should be more recent than the versions built
into stable-release Emacs). How do I tell Emacs to install the
Elpa-versions of these packages? Today I realized that the
following snippet as init.el does not that:

    (require 'package)
    (setopt package-install-upgrade-built-in t)
    (package-refresh-contents)
    (package-upgrade-all)

This is because package-upgrade-all determines upgradeable
packages with (package--upgradeable-packages), i.e. it never
passes a non-nil value as the optional INCLUDE-BUILTINS argument
to that function.

I've implemented a personal workaround for this problem with the
following advice but I'm not sure if it's the right approach:

(define-advice package--upgradeable-packages (:filter-args (args))
  (list (or package-install-upgrade-built-in (car-safe args))))

As this advice suggests, I propose as a solution to this issue,
to:

    1. Either edit package-upgrade-all so that it uses the
    package-install-upgrade-built-in option when calling
    package--upgradeable-packages: (package--upgradeable-packages
    package-install-upgrade-built-in)

    2. Or define a new user option that is used as
    INCLUDE-BUILTINS parameter.

What do you think?