Received: (at 79733) by debbugs.gnu.org; 31 Oct 2025 08:20:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 04:20:15 2025 Received: from localhost ([127.0.0.1]:40215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEkMo-0005d9-2m for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:20:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43800) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vEkMh-0005bE-7G for 79733 <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:20:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vEkMY-0000tK-Ee; Fri, 31 Oct 2025 04:19:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zmuKg4Pte4umMJAzdSUQew6ECNQyG2nEXkWiHImoOxk=; b=YHO0uOpHmuA/MNHYA/SN 10UL41bVyLm8r/VVknkONad51C15ub0EIaCWLJLwbh30/hw1j9MnfwBtdMEQos0XwatpvvcYbHU6S 00uUxDwSeK5jfFejuFa1yhPlyJdyTbgSO0OZjG4Hw1EIFC8myy2l3/rT5PzS2Agsu4flreGwMSsuI Cap5irLyNDILGWjU5t3j1wyTbfsP/4Kcb0Br4Aolkmnxl+xHZcF7VfCK3+PzukzUv6i9TmZkyWEss Pu8hc3wyRpJ7fvtpL+PYNvNdLN+KZM7rgbEEkXESqcDJypLpb0aV75i1WylYgYzv1qBuLsHbKWtXM 82XcK+ud2MbJmw==; Date: Fri, 31 Oct 2025 10:19:52 +0200 Message-Id: <86o6pnlbyv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> In-Reply-To: <m2ms57a4t0.fsf@HIDDEN> (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Fri, 31 Oct 2025 08:50:03 +0100) Subject: Re: bug#79733: [PATCH] igc: Make size of charset_table_init changeable at build time References: <m2ecqjbooy.fsf@HIDDEN> <86wm4blexb.fsf@HIDDEN> <m2ms57a4t0.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79733 Cc: 79733 <at> debbugs.gnu.org, eller.helmut@HIDDEN, pipcet@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gerd Möllmann <gerd.moellmann@HIDDEN> > Cc: 79733 <at> debbugs.gnu.org, pipcet@HIDDEN, eller.helmut@HIDDEN > Date: Fri, 31 Oct 2025 08:50:03 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN> > >> From: Gerd Möllmann <gerd.moellmann@HIDDEN> > >> Date: Fri, 31 Oct 2025 06:55:09 +0100 > >> > >> I've merged feature/igc into my Emacs and the 'mac' build aborted. > >> Reason was that charset_table_init is too small for the mac build, which > >> dumps ca. 280 charsets. > > > > Why doesn't this happen on the master branch? Did the igc branch > > somehow enlarged the number of characters to dump on macOS? > > As it says above it's in my Emacs which has ns and mac. Which is different from the "normal" build of the master branch?
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Received: (at 79733) by debbugs.gnu.org; 31 Oct 2025 08:15:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 04:15:10 2025 Received: from localhost ([127.0.0.1]:40193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEkHu-0005Hk-36 for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45602) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vEkHd-0005G7-BH for 79733 <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:14:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vEkHX-00088p-9g; Fri, 31 Oct 2025 04:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=W53UC0cPvx9rYaRbL8FRsjkpF+J2VW+30nlNIKT+JFA=; b=YDpgyEIZc0MCw/v9rvSS L7YaJL8wxOxZIHf+1g0T15uLr0GAUy96G3NxqZXZMni/JkwkK6EfLFMhggVdMGb1KmaRI8mLzba5D bJDfOyVk38sqBzPW9BWQancTbD7S4ezWnfBU4jP08n/AfDI/jBTo9D+Lk3ndUKNAUtIoArenwMYpg 9Rctyz1PNkUDx/pTQHzLjpGO8APYDcRpuib/PspAT8edhlCKo77sF8xCk4eBKEL6/MS2CSYdCWEUt GwouQ0DtjvLLwkKNgqvVhNK9D3ltA3qsv69gLlMmhruoTqkJLZCkaFSt0pCBabFah7H3DwpDBIzTF CKEu6UBw2qOUIA==; Date: Fri, 31 Oct 2025 10:14:37 +0200 Message-Id: <86qzujlc7m.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Helmut Eller <eller.helmut@HIDDEN> In-Reply-To: <87seezo6u8.fsf@HIDDEN> (message from Helmut Eller on Fri, 31 Oct 2025 08:42:23 +0100) Subject: Re: bug#79733: [PATCH] igc: Make size of charset_table_init changeable at build time References: <m2ecqjbooy.fsf@HIDDEN> <87seezo6u8.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79733 Cc: gerd.moellmann@HIDDEN, 79733 <at> debbugs.gnu.org, pipcet@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 79733 <at> debbugs.gnu.org, pipcet@HIDDEN > From: Helmut Eller <eller.helmut@HIDDEN> > Date: Fri, 31 Oct 2025 08:42:23 +0100 > > On Fri, Oct 31 2025, Gerd Möllmann wrote: > > > Tags: patch > > > > I've merged feature/igc into my Emacs and the 'mac' build aborted. > > Reason was that charset_table_init is too small for the mac build, which > > dumps ca. 280 charsets. > > > > The attached patch makes the sizeof of charset_table_init changeable at > > build time, and prints the reason before aborting in the pdumper. > > > > WDYT Helmut and Pip? > > The comment before charset_table_init says that it is large enough to > handle Emacs while it is bootstrapping. Evidently the comment doesn't > describe reality. It would probably better to remove charset_table_init > and always allocate charset_table dynamically. You mean, allocate it both while dumping and after the dump? Could be a good idea, provided that it doesn't slow down Emacs' startup and doesn't require loading files we don't want to load after dump. IOW, I would like to see the patch, so we could discuss it.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Gerd Möllmann <gerd.moellmann@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 79733) by debbugs.gnu.org; 31 Oct 2025 08:13:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 04:13:06 2025 Received: from localhost ([127.0.0.1]:40177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEkFo-0005C6-2j for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34656) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vEkFh-0005Bo-EM for 79733 <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:12:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1vEkFa-00084q-Up; Fri, 31 Oct 2025 04:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ycbmqBIyHJz9FPzaV7qHCMWzSR9iC/MWafyBnXDm224=; b=gKCCidVGPLy4tjUJ3Xe3 1BgGIe/EELX4nGdENm4Lc9VRxKUopecdv5zxS39zEZBHU8hVpB4IEonnQRm0ACrsLnyKkUAnJXBdN jcbKAEiV0T1Aafof31NXRDGBnS9liCqoG3jvODO5iUfSlwZ65HugTrdDHrEKjZ7gakfH1uW4Ttap7 pruaI4jFqSyD//wrQBiCyUA0Z8HnoskmaISKoeHbCON4swnNn0ixn49BjwV6W5P+GUvG7ek9998h0 SofuGCD7GIc2uDd5q2ObDRsdoSoZSWmv1TqYNwW2IrromqgbqWQe3UqVD+uNyCiTSY0ZQwncsJgLI eP1935hsDw8g9Q==; Date: Fri, 31 Oct 2025 10:12:38 +0200 Message-Id: <86seezlcax.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Pip Cet <pipcet@HIDDEN> In-Reply-To: <87tszf8rj3.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#79733: [PATCH] igc: Make size of charset_table_init changeable at build time References: <m2ecqjbooy.fsf@HIDDEN> <87tszf8rj3.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79733 Cc: gerd.moellmann@HIDDEN, 79733 <at> debbugs.gnu.org, eller.helmut@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 79733 <at> debbugs.gnu.org, eller.helmut@HIDDEN > Date: Fri, 31 Oct 2025 07:24:01 +0000 > From: Pip Cet via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Gerd Möllmann <gerd.moellmann@HIDDEN> writes: > > > Tags: patch > > > > I've merged feature/igc into my Emacs and the 'mac' build aborted. > > The only reason it aborted was that last-minute emacs_abort > change. Without that change, you would have seen silent data corruption > and a tricky bug. > > > Reason was that charset_table_init is too small for the mac build, which > > dumps ca. 280 charsets. > > Not surprised. That's why I immediately and loudly objected to the idea > when it was proposed, and again when it was merged, particularly since > the merge happened without addressing any of my concerns. Please identify the merge, so we could be on the same page discussing it. > > The attached patch makes the sizeof of charset_table_init changeable at > > build time, and prints the reason before aborting in the pdumper. > > NOOOO! > > There is NO reason for charset_table_init. charset_table should be > allocated dynamically, and then we could remove a lot of code. > > There is no reason not to allocate charset_table dynamically. > > There was a reason once, unexec, but it's gone. > > We can argue about statically allocating fixed-sized objects (which is > usually a bad idea with MPS), but statically allocating > dynamically-resized objects is wrong. Period. > > There's a patch to remove charset_table_init in the archives. Just apply > it. Please point to that patch as well, so that we could revisit the issue.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Oct 2025 08:13:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 04:13:31 2025 Received: from localhost ([127.0.0.1]:40180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEkGI-0005DF-DV for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:13:31 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36198) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkGB-0005Cn-JJ for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:13:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkG6-0007WZ-3G for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 04:13:18 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkG2-00085s-Mu for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 04:13:17 -0400 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-64074f01a6eso1979869a12.2 for <bug-gnu-emacs@HIDDEN>; Fri, 31 Oct 2025 01:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761898389; x=1762503189; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EsN7dm3g5GNOA9vSGxeNaTOFLtBNkmjy1sNCZbghe1M=; b=MqXtaaeCQDZoWBjIQmiLQ91a6EsyHUAh+bkZdcRKG2NgF5H6jJtuSzavbkiDFumNyP LUM7a9BJI/L+4VzVKmIDAnRycn++KwJzjC4bkAZLvfF9GGC8+JJDb7paZLz9ek+oqmQg 0OKVCxxikAU0uk0DS+fRyBC/YbRdQqer5wXPbSbxqO79TLss3yJBC5bkZoCLysVouamT 3AWrUUWctNKxQ6fuHzT6c8zlKZ2PHc6znWQI2i5bovQsiLiTAPZT23dfLCDyz+1eVkEW SwxhzpH6bPxRfNnx7FpHjFlnEFLD6t6U/yd6NDOpbfbcKy00I0n+yLM2V4tDGQDfcEGe fw/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761898389; x=1762503189; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EsN7dm3g5GNOA9vSGxeNaTOFLtBNkmjy1sNCZbghe1M=; b=GFs2MvaPyxonXErNILlSkI8JAnHWlQ+ifpn4dLTbaoEFSZVqpQjAVfHFogLQo6yBjl YViDStx+bdg25BVOPOrMF3f9DMm5R2G6b3CFXMMjEnKFKZBE4PihCDsBCcx7Lkw1LrIk t69rZ85NvrHmmV5LgPShkQGNaXJqXmrz2d7+F5G/7rCoYyxuxeA5qq4wYnp+b82OIz7g CE8ixcviAk6xeWFpi0f0UR28UpOXUC7fbNk/d9NHMk9SWHflRMck46ryVfkE4MLjf190 9KZCdH0V7Lbk9FhAxFsd3AkLNjbvx6TRqQu5Jxfn0x9yZmi1jKY4WV1tFaZXXae/wL5x wObg== X-Gm-Message-State: AOJu0YyT43uCd7bdIEAbXyI+dxpZ3hm3RdGONvs7eg5j55f6ZrWK/8VP JaMu05HeeOJaUzD0KCb7jPSnm068PrPHU/D7dklDMFeUPwml4mZEzBNl X-Gm-Gg: ASbGncsHM4UHc5O6oq4/od0VtWX9d91OagklZu9oc2neKurITx+FsqsKZSLGZy9Q61f a5dDFRydPXvCpWyug/j4jr9uFUZ6gf9m5c2vLszg1eKSEaOgrFBEKKw2dqcf62NuvzSABmUDm8s I1ZDerTk0kQbXi+O559cxm4VIYmtFNsMkIgYWJ0rZ+y0uVcW559bk9TLMJxb0g3CxCN0T8eM46M YWS2t1gcSwfho8t8HhlhtW8D8oQehm9H1TVv7Q/rwdh/xgMywH52ybGCoc+kvKDZnykaN1+FroM xzC50A0FJTPkSN0pG9rxuCVnlRQhkYsAnTzUOTBaKtmQs1g7Fzf4QLK2x+dZUu4svnF3Xc306bL 7OTjEBQDWJ22ifDhBhNtShfYw03hhReCETA3lIztmEnWYX6DlkDBLhr2w7y+9GhFgUjqckMC7kR erFm+Zda4IZs2AmvQoZgL0Cm9ead067QKc/EbDMskGTCmU7PMasW+LEDEDqh6yfjr0xXdOqY0MR ZBM+tLx2YXR X-Google-Smtp-Source: AGHT+IFokvoGXdcRdeclrFwI1l5fWNpqDZ970ZhybyGdbep3Dv8PecNTty/sdtJM7KCHicwLwiZauA== X-Received: by 2002:a05:6402:5341:20b0:640:6650:9170 with SMTP id 4fb4d7f45d1cf-64077025304mr1749422a12.25.1761898389295; Fri, 31 Oct 2025 01:13:09 -0700 (PDT) Received: from pro4 (p200300e0b738df00b42a37bac059b60a.dip0.t-ipconnect.de. [2003:e0:b738:df00:b42a:37ba:c059:b60a]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6407b427fb9sm1005748a12.23.2025.10.31.01.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:13:08 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> To: Helmut Eller <eller.helmut@HIDDEN> Subject: Re: [PATCH] igc: Make size of charset_table_init changeable at build time In-Reply-To: <87seezo6u8.fsf@HIDDEN> References: <m2ecqjbooy.fsf@HIDDEN> <87seezo6u8.fsf@HIDDEN> Date: Fri, 31 Oct 2025 09:13:07 +0100 Message-ID: <m2ecqja3qk.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=gerd.moellmann@HIDDEN; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@HIDDEN, Pip Cet <pipcet@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Helmut Eller <eller.helmut@HIDDEN> writes: > On Fri, Oct 31 2025, Gerd M=C3=B6llmann wrote: > >> Tags: patch >> >> I've merged feature/igc into my Emacs and the 'mac' build aborted. >> Reason was that charset_table_init is too small for the mac build, which >> dumps ca. 280 charsets. >> >> The attached patch makes the sizeof of charset_table_init changeable at >> build time, and prints the reason before aborting in the pdumper. >> >> WDYT Helmut and Pip? > > The comment before charset_table_init says that it is large enough to > handle Emacs while it is bootstrapping. Evidently the comment doesn't > describe reality. It would probably better to remove charset_table_init > and always allocate charset_table dynamically. OK, then I'll close this issue because I'm good in my Emacs for now, and I don't really have the energy for more. I'll put that on my todo though, just in case.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Oct 2025 08:08:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 04:08:23 2025 Received: from localhost ([127.0.0.1]:40167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEkBK-0004x6-MZ for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:08:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54212) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkBF-0004wZ-HZ for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 04:08:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkB7-00060T-Qw for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 04:08:10 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>) id 1vEkB4-0007VC-4F for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 04:08:09 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-429c48e05aeso1378f8f.1 for <bug-gnu-emacs@HIDDEN>; Fri, 31 Oct 2025 01:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761898082; x=1762502882; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XoNu2V90uUXpJ5KkDFs5dKGcRvuGiXvTS8XjpMqsO4M=; b=hEMvrJ1ZTu6KoLhL4GropSEBAVHpovoXBqp0s3lnYoBZ1e0o4dVKLqf4Q1cqKeumfO RM0EBZYH/R7mmMsmh239ANIVdGwXSAv1P3uXqlKZ3lShZMa54lc1c2XRHmvZdk8ZAeEf DwpUoHFaB/Y1Zm3iFX8xEdNE8gzb83ztiTD6tqblbYv/2wlbqp0aN7T3Hn9P0fd9lUGQ HWi8Bl2+lBFz29elfcmERiYY+plGke8ohczAoiZb5tnm4L41AfdPcHkoaerJOaWKQqRZ p1HWIkfpeUPlq4/IVhbS4LeCUaZqTTiX4frmYunuhXQhQVmFFhvrLfzHp+wHZldzC8rI 0nWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761898082; x=1762502882; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XoNu2V90uUXpJ5KkDFs5dKGcRvuGiXvTS8XjpMqsO4M=; b=KpylVXFgJ/PdbIkrQzyOc5lcZ4N0G8aBQycc/lEU/ZBKffAaz1/p6HUEG8TNPAgGBU oIxl9nBTgzHT7C3YFBglKhbnUY2YPdnsIUlxz+gL30NCMvSWjxz63Emdhj+d1PpDYJNJ KIj8LtN89SGgSd87XADhv+RtuEpXDLT0EKb0QTgBvDNQY1I3bmHAhBFLr+rNkOlepFhp qHO35I5uuG6BZqJKWFp0uxxRUaDex+0GaIs79LWbVKKHJdJkcPNas8NbHyBSAV3/b4e5 gyImkfP1g3Q2FICI7S1Pa6uGcFyQeDbf+3j0dC5/FCbXSzFPaePkJXntnxkN9vI2yJ/2 VgXQ== X-Gm-Message-State: AOJu0YwacOlShiHRr6vzeh4DQ1jTm9WCh4SlL22h+wsf/HSkAaR59cUc na02UBxFKzN9ZAmVFzIjIes5o1xS7Ag4bbBvknJEz1zEbc7p9m5U5aWm X-Gm-Gg: ASbGncuOSsNvL6hxEmsNiWfiTdD3ahG7tE/q9JZ1+zYqn8PK6ZqHEnOg0d75ROoFA8x dQAiCQf9xwx6mgilzKK1v4DYwLE+nqT8uGXJrdlDfBHtiw8ySbQomVV/PkFY4n0ko5Dwx7DxPVc lmPBIWZR/Aa8x0icmuZEkWA87trh3jNG2lLh1nYr+fPiPWzoTRYbBhir1TGsOKXjEoM0Ssjtve5 kiNJChucFG2g6DfvbKPHmZdOE/tIs8r/pTchfZUZUr/qzMRv4CE6E1xNDKnuinYf4i7vNoJWy83 QCufmJb292Lxws7dOJ2HbD+kDXkLetlB1wZo0c2u+ES/5xnMpB0SHq24OGJNGna2Z/tNFVIvdJl YVdFt/bEusc0aPRVf4q3JlkWXPJifOm0khhi0lGZuP5UmQ5lbH9Ysf+h81UIUr+DZgA8N+OcmWT yJSWbnkwGwZxhVuW1r3TpAHJRzmbVpOiJMjZnU9FQroZQ803Rj+y95j0NZ8XwDSO5rqJM90Rp6X Vke+JH/B0wgPkOk+DKLnNc= X-Google-Smtp-Source: AGHT+IGQxWc1GIWdAUnJOFMWHo3MMy19vSEFqk2I+zLxwl1Y2PEOnB2To2arT4rznqdlTj128hbRtw== X-Received: by 2002:a5d:5f47:0:b0:429:8b4a:c3a0 with SMTP id ffacd0b85a97d-429b4c0f3f3mr5711604f8f.2.1761898082004; Fri, 31 Oct 2025 01:08:02 -0700 (PDT) Received: from pro4 (p200300e0b738df00b42a37bac059b60a.dip0.t-ipconnect.de. [2003:e0:b738:df00:b42a:37ba:c059:b60a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c1405fffsm2050521f8f.45.2025.10.31.01.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:08:01 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> To: Pip Cet <pipcet@HIDDEN> Subject: Re: [PATCH] igc: Make size of charset_table_init changeable at build time In-Reply-To: <87tszf8rj3.fsf@HIDDEN> References: <m2ecqjbooy.fsf@HIDDEN> <87tszf8rj3.fsf@HIDDEN> Date: Fri, 31 Oct 2025 09:08:00 +0100 Message-ID: <m2ikfva3z3.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=gerd.moellmann@HIDDEN; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@HIDDEN, Helmut Eller <eller.helmut@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Pip Cet <pipcet@HIDDEN> writes: > Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > >> Tags: patch >> >> I've merged feature/igc into my Emacs and the 'mac' build aborted. > > The only reason it aborted was that last-minute emacs_abort > change. Without that change, you would have seen silent data corruption > and a tricky bug. Been there yesterday, weird error when building, enabled checking, et voila :-). >> Reason was that charset_table_init is too small for the mac build, which >> dumps ca. 280 charsets. > > Not surprised. That's why I immediately and loudly objected to the idea > when it was proposed, and again when it was merged, particularly since > the merge happened without addressing any of my concerns. > >> The attached patch makes the sizeof of charset_table_init changeable at >> build time, and prints the reason before aborting in the pdumper. > > NOOOO! > > There is NO reason for charset_table_init. charset_table should be > allocated dynamically, and then we could remove a lot of code. > > There is no reason not to allocate charset_table dynamically. > > There was a reason once, unexec, but it's gone. > > We can argue about statically allocating fixed-sized objects (which is > usually a bad idea with MPS), but statically allocating > dynamically-resized objects is wrong. Period. > > There's a patch to remove charset_table_init in the archives. Just apply > it. > >> WDYT Helmut and Pip? > > I'm assuming it does what it says on the label, so I'm just going to > move this to my pile of obvious bugs that I can only fix locally and > stop spending time on this. This isn't even the worst one (equal still > crashes when called on a perfectly valid sub-char-table, for example), > but it makes me seriously doubt that working on the savannah branches is > a good idea right now. Interesting. Is that in igc or master? I'm asking because I'm seeing another weird problem after I merged igc: an AOT native-comp build hangs when building js.el. That's in my Emacs. > It's very frustrating. Sometimes it is, yeah.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.
Received: (at 79733) by debbugs.gnu.org; 31 Oct 2025 07:50:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 03:50:21 2025
Received: from localhost ([127.0.0.1]:40049 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vEjtt-0003hN-1I
for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:50:21 -0400
Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:47285)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
id 1vEjtl-0003bK-8j
for 79733 <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:50:17 -0400
Received: by mail-wm1-x32f.google.com with SMTP id
5b1f17b1804b1-4770e7062b5so13741895e9.2
for <79733 <at> debbugs.gnu.org>; Fri, 31 Oct 2025 00:50:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1761897006; x=1762501806; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=rss1+EXiXczlnJ3T04wVRLF2MQg1twgjsIsDLY9g0vc=;
b=DRq3OfUkX4KIxEjvfLpjAq+jEfWqIndwrqdi581OFRhsu5/n2/k8A3AoRArEZS9m1E
oyLJm9P4j5wuz2Yg0kjLosOfRpt0IBRplTLzxp45XX7MJr0fE3j/GPDq9o54ELea1tkc
6qdcD0lo64gP59cbzTqcPYDoDd4zRjWtsO/1grIVweaOvNUIFypKLXakN0lSmK0uALIx
Cv7d97+w5jvDhBVPBjnzj9dFRDt7ULfvEwd2sCSNwhCjihe+hRgRCQ69vjwoMxs/MEsl
YYDsQzMi70oRpChim+Mp1NNClWvEpMRzVoY9UJQ/Y/spEskPJMEun9dLL+WjnOmfUu1q
cVfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1761897006; x=1762501806;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=rss1+EXiXczlnJ3T04wVRLF2MQg1twgjsIsDLY9g0vc=;
b=lUqdlLtJEw3z5aeD+wLqR+gjjelyjHnPaWznR8Pt2r/C3niJRNZNXKy5pY+KVNb760
i3RTFuOoyACgnxc5PXU+320dG5EdAsTkLdllxyHJOXsmuX4ig7cInGjSa76Ifiu0thoh
RKY+OU7rE5gpFzDDt5nQiD0DGGSZOHzkmSg/dAkiU7722T2ypAusr3oFId30weOI7OaC
/9/k1C4AMsEsoxlyt0dp4fi1cOrXhM0WPFASrqVJafWupSD+Hm3SJ9uNrga88nUGbkRt
sem2Sd1oETuxqVMHtU5jTEltdnvqKWm81F3AMI45J7UWJl+/TA2d6ymyl8hq5s/Hrsbo
dAfA==
X-Gm-Message-State: AOJu0Yz3DpjG8qwyBRFW+CzWPsoZp3xZtB5Yvq2W4TU2tMWulrZjCqog
eynBJigBTHZuSeVXUq8VG1XUkcexMEa92Kq3tLW67mXGN10vfMHNPd6A
X-Gm-Gg: ASbGncvO6G8pXJp3Z+PFPqF8f7T/CTP9O3hJ2iSupRylsE0uR4rFcdWREqZG1I95my+
SVeFBkMDZsZaBVfaqk6Anej/50fUVKVFaB2Uy97ptsuJRE5quCD+eary+GkV2SawhHtTbiOmL77
BsU51XG0N9g4htsIWFo2RszQeCe018UhimSBF5WRDB+S5W14CL8UWvetjw2Z9njADoHPn8O/aZt
SOORjV7OWnABHHBnHxAc7sP407TWMsOEpZxT/38b+C2uEoU0wXuGPCqHqPQSUnHUnXWxtTXftV8
75MQmBSm1XC9Z14GmTjusGt9OpN7kDSSvX+Hin3stvdHj7hvhOGoYi7d4sbfm+xfjVwYDVMcEoM
Oddw5WCka0CK1LSKbTDrqyxD27de+8qhS0quu26bSFLBoNB53+98VN6rzKzUmjPgOF4x/8w3oiB
HAnJLRn1hkgsIL3O3Dks5mCr19TLEhqadS7JU1QjtuXwSht3fPIDMAXynY4PDr3lIsJogW7KJkB
gUPLPWAls8catA9ILz2zp0FECI0I6R3NQ==
X-Google-Smtp-Source: AGHT+IEKpgihTG165IfaNl+mgM6PLNOMl2atJAqTsacKIaPXbrPwYVBOC4f3wmsKuQibTWRnPnL9mg==
X-Received: by 2002:a05:6000:4014:b0:429:8d28:4079 with SMTP id
ffacd0b85a97d-429bd6be60amr2173418f8f.62.1761897005383;
Fri, 31 Oct 2025 00:50:05 -0700 (PDT)
Received: from pro4 (p200300e0b738df00b42a37bac059b60a.dip0.t-ipconnect.de.
[2003:e0:b738:df00:b42a:37ba:c059:b60a])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-429c10ff1besm2069281f8f.9.2025.10.31.00.50.04
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 31 Oct 2025 00:50:05 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#79733: [PATCH] igc: Make size of charset_table_init
changeable at build time
In-Reply-To: <86wm4blexb.fsf@HIDDEN>
References: <m2ecqjbooy.fsf@HIDDEN> <86wm4blexb.fsf@HIDDEN>
Date: Fri, 31 Oct 2025 08:50:03 +0100
Message-ID: <m2ms57a4t0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 79733
Cc: 79733 <at> debbugs.gnu.org, eller.helmut@HIDDEN, pipcet@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN=
m>
>> From: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN>
>> Date: Fri, 31 Oct 2025 06:55:09 +0100
>>=20
>> I've merged feature/igc into my Emacs and the 'mac' build aborted.
>> Reason was that charset_table_init is too small for the mac build, which
>> dumps ca. 280 charsets.
>
> Why doesn't this happen on the master branch? Did the igc branch
> somehow enlarged the number of characters to dump on macOS?
As it says above it's in my Emacs which has ns and mac.
>
>> - emacs_abort ();
>> + {
>> + fprintf (stderr,
>> + "CHARSET_TABLE_INIT_SIZE is %zu, need at least %zu\n",
>> + sizeof charset_table_init / sizeof *charset_table_init,
>> + size / sizeof *charset_table_init);
>> + emacs_abort ();
>> + }
>
> Why do you need to use %zu here?
IIUC, Helmut and Pip want to remove charset_table_init, so this is not
relevant anymore.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Oct 2025 07:42:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 03:42:56 2025 Received: from localhost ([127.0.0.1]:39994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEjmh-00030Q-HB for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:42:56 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52842) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eller.helmut@HIDDEN>) id 1vEjmU-0002yP-HK for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:42:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eller.helmut@HIDDEN>) id 1vEjmN-0007QR-SJ for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 03:42:35 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <eller.helmut@HIDDEN>) id 1vEjmL-0003nn-1R for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 03:42:35 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-63c3c7d3d53so3735597a12.2 for <bug-gnu-emacs@HIDDEN>; Fri, 31 Oct 2025 00:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761896546; x=1762501346; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S+5fO9UI3RQztD0dBF0rqFi9ZAYwg3iSOcjIsnJIBf0=; b=ja44GlJuUtOoR8fCjo1yHoavw2CXPKxR1/CoV+1Kxo9NqzSlt4n5XwHgjj+MK4qS7g M+YR1uZnBy+19Qq+E/KIKUfsmQqDmaBYzYlR8VkfMZWZRimVbe3lR79NTZMJkcXe6uS3 0W6/waQ9NqQvilfHJFt1O7RUhRUrw7uALH2FoSqX1Hn2w7JQBKIHVu42oW7g+qOG8riZ GmxazQsE62jKNVJDqWqIcVf0d4LZyDpje3o7ZKjTXBCjuWtfW8e+iSsdFchuVhGlzKGV ACk4jIOcQ3ys+/DuWxfZJXOfBBrZfPKC6o2m9sxazo6cH60hLvVKw0/js89Y9GR6mu6a JE3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761896546; x=1762501346; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S+5fO9UI3RQztD0dBF0rqFi9ZAYwg3iSOcjIsnJIBf0=; b=XgHOxA3bkk8BTfp/yPaTfnIWYpm8VmhBTrJb/PMv3PGsLkM51tqhgyznfaNhQUE+Ap 4BWMyayZSxcEnHHnVjDrJ/A6SsiM5UL1ursPpCyNK6klA3IMxxwFQkiGD6vdlC5IUmNI twVC9COXby2tmSQy8uegQltq97rjbuz63rIEbz6PF2CVGX8ZTKjY7/WwKyzrHFdVHmZb wfntQAbCyk+gpNHihs6C+KyomEPBRJzvglPltr4/SmTqXP9dhGQqF7ObyXanpXQstFLH aUcxr7KzaNvJfFyodtVMGCnm9f+b2wC+ilXe0DtSFyuz1984I7LyVTjVJ9J59xJf0KO3 rXtw== X-Gm-Message-State: AOJu0YxARTuUVm9tp88EMaiC0R3O6IHgoiugK2BjsO67GxXgH3iGAFg0 lC3MIO1LcePn5GrlK8DYrJGe/v2BQii0WzqR8Pj91mL7rDFmFZum8KH4 X-Gm-Gg: ASbGnct+lOHEEklg7gE4ImtwR6bZ94i59YwcEv9EHB0J0XzxoImN3sEI7dmcrH/QVLM umkj2vzMd8oB6bnMfoJ7ZMV+89d1XmbRrNZ2iDrH31tF2AK6SxwtsdRYqFeaor7KQO8gT1xF3TJ Wd9Les3sInyjK1vCdnmDp0+FGcT8Q5q32MFOves3BkvGg5nyLH2McwMUTS38FDpvOSx9saCGEoK C/anRrhAg9RuDDSCGW3njrXX19XTdpXcNs567V8so1E7SIjFDQEpneZmaavzxnz1RiFRMOfOXPF hF28v09Or0qrVupz5QMmpGaMyoCxIpCBGyqGPwwtrtTUnKAoFyM5yE9CrwAx5hqG+OR9dwY9m5I 3AEucJ1JXH+uqTlnxUAmcKKuc8HBJXvOW67K/NT9qNXjwZ+NRxrS+WkLo6syCtXqsQ4XtLe3nfw == X-Google-Smtp-Source: AGHT+IG6zWTg0FD4N8C78DFoRQGYaQ52j+G9zHAph4LlNwb0BQP9SddE/5LotQv/P3FQFPnWvFzi9Q== X-Received: by 2002:a17:907:96a9:b0:b3f:e1e9:22c7 with SMTP id a640c23a62f3a-b70708dd0a5mr175257366b.65.1761896545862; Fri, 31 Oct 2025 00:42:25 -0700 (PDT) Received: from caladan ([31.177.112.212]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7077975cfesm107774066b.4.2025.10.31.00.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 00:42:25 -0700 (PDT) From: Helmut Eller <eller.helmut@HIDDEN> To: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN> Subject: Re: [PATCH] igc: Make size of charset_table_init changeable at build time In-Reply-To: <m2ecqjbooy.fsf@HIDDEN> References: <m2ecqjbooy.fsf@HIDDEN> Date: Fri, 31 Oct 2025 08:42:23 +0100 Message-ID: <87seezo6u8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=eller.helmut@HIDDEN; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@HIDDEN, Pip Cet <pipcet@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) On Fri, Oct 31 2025, Gerd M=C3=B6llmann wrote: > Tags: patch > > I've merged feature/igc into my Emacs and the 'mac' build aborted. > Reason was that charset_table_init is too small for the mac build, which > dumps ca. 280 charsets. > > The attached patch makes the sizeof of charset_table_init changeable at > build time, and prints the reason before aborting in the pdumper. > > WDYT Helmut and Pip? The comment before charset_table_init says that it is large enough to handle Emacs while it is bootstrapping. Evidently the comment doesn't describe reality. It would probably better to remove charset_table_init and always allocate charset_table dynamically. Helmut
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Oct 2025 07:24:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 03:24:47 2025 Received: from localhost ([127.0.0.1]:39881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1vEjV7-0001HC-LZ for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:24:46 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60138) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <pipcet@HIDDEN>) id 1vEjUt-0001Gi-To for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:24:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1vEjUm-0002gB-VO for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 03:24:25 -0400 Received: from mail-08.mail-europe.com ([57.129.93.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pipcet@HIDDEN>) id 1vEjUj-0001nE-G9 for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 03:24:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1761895447; x=1762154647; bh=2n3XIjpFxcbxM8iRWGMvEs0g3voNgxs3CUHKR43RD5g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=eSdbE4ZpAJCTCn1lHmMzaZDMcvwdsaWAL+eBPYER0a7OYAccvL5lEdW7T6h4NTiIp TiwGbiZZh9OP3qFM5EAEN/7mgjlxf/penNKJG5j//R2clgrUb1+FxO/vBAqo0zFbCp M2qwNEqH8/bQroC5snG5JTXK3EEG5atrn85V07ycjYG4QfGi9P7PuMdu6BJTyCkPi6 JFHDpmkzl/AZnmlnCZv7JR2pt0I9yyiIB3kdNcHdGv3Ryidaqo9jk52s4diBBQhhro evdgrpn29bDQ2Mo08tlLqg8EpWzpUk+Hi/nkO2kFF91juwvIueUPKBG8VprS+IN0RJ s201S1LIujkDg== Date: Fri, 31 Oct 2025 07:24:01 +0000 To: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> From: Pip Cet <pipcet@HIDDEN> Subject: Re: [PATCH] igc: Make size of charset_table_init changeable at build time Message-ID: <87tszf8rj3.fsf@HIDDEN> In-Reply-To: <m2ecqjbooy.fsf@HIDDEN> References: <m2ecqjbooy.fsf@HIDDEN> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 17a77605dbfcaf8df8bb71c45b612cfd1b9f1165 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=57.129.93.249; envelope-from=pipcet@HIDDEN; helo=mail-08.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@HIDDEN, Helmut Eller <eller.helmut@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN> writes: > Tags: patch > > I've merged feature/igc into my Emacs and the 'mac' build aborted. The only reason it aborted was that last-minute emacs_abort change. Without that change, you would have seen silent data corruption and a tricky bug. > Reason was that charset_table_init is too small for the mac build, which > dumps ca. 280 charsets. Not surprised. That's why I immediately and loudly objected to the idea when it was proposed, and again when it was merged, particularly since the merge happened without addressing any of my concerns. > The attached patch makes the sizeof of charset_table_init changeable at > build time, and prints the reason before aborting in the pdumper. NOOOO! There is NO reason for charset_table_init. charset_table should be allocated dynamically, and then we could remove a lot of code. There is no reason not to allocate charset_table dynamically. There was a reason once, unexec, but it's gone. We can argue about statically allocating fixed-sized objects (which is usually a bad idea with MPS), but statically allocating dynamically-resized objects is wrong. Period. There's a patch to remove charset_table_init in the archives. Just apply it. > WDYT Helmut and Pip? I'm assuming it does what it says on the label, so I'm just going to move this to my pile of obvious bugs that I can only fix locally and stop spending time on this. This isn't even the worst one (equal still crashes when called on a perfectly valid sub-char-table, for example), but it makes me seriously doubt that working on the savannah branches is a good idea right now. It's very frustrating. > [2. text/x-patch; 0001-Make-size-of-charset_table_init-changeable-at-buil= d-.patch]... Sorry, not going to open that one. Pip
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.
Received: (at 79733) by debbugs.gnu.org; 31 Oct 2025 07:16:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 03:16:21 2025
Received: from localhost ([127.0.0.1]:39867 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vEjMz-0000xL-BU
for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:16:21 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59738)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1vEjMr-0000ws-FJ
for 79733 <at> debbugs.gnu.org; Fri, 31 Oct 2025 03:16:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1vEjMk-0008Er-Jy; Fri, 31 Oct 2025 03:16:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=fEE2zuj//Hm0LyPIJ17QEvzeIJ+rsZYedjF8qVpkb5A=; b=JWDHVXqukmQ5rlImTsRu
QUPJZLcBJMKWLRtfIAXtnhECjYM0/iRtoRGsxto5PWYsgo3I5T18EmoGf7AlT4jg6Gt3K2YCmA/ik
VZNpCZYtC41yATbJmEZkTdBwluTQaQil0PjebhvthIzuW+sr7Wj1N5PlAUARe+/ab5zcpoRWHYhS8
8BVDx8P8CU3Pds5zIEMU3gT+4W9lajrNlbZQIj1iwtkm01p4YQy7SjpknGQVtjjGhY1AZW2rYYrEL
IXDGZeKotwjOQK/Y3bzuH7W1sLa3l93+7YcEJRg9pW6zbmzomGpTocNab6AMCBl1szDhsdMgv5kcd
hIw0TCgqe6fHmg==;
Date: Fri, 31 Oct 2025 09:16:00 +0200
Message-Id: <86wm4blexb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <m2ecqjbooy.fsf@HIDDEN> (message from Gerd =?utf-8?Q?M?=
=?utf-8?Q?=C3=B6llmann?= on Fri, 31 Oct 2025 06:55:09 +0100)
Subject: Re: bug#79733: [PATCH] igc: Make size of charset_table_init
changeable at build time
References: <m2ecqjbooy.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 79733
Cc: 79733 <at> debbugs.gnu.org, eller.helmut@HIDDEN, pipcet@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN>
> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> Date: Fri, 31 Oct 2025 06:55:09 +0100
>
> I've merged feature/igc into my Emacs and the 'mac' build aborted.
> Reason was that charset_table_init is too small for the mac build, which
> dumps ca. 280 charsets.
Why doesn't this happen on the master branch? Did the igc branch
somehow enlarged the number of characters to dump on macOS?
> - emacs_abort ();
> + {
> + fprintf (stderr,
> + "CHARSET_TABLE_INIT_SIZE is %zu, need at least %zu\n",
> + sizeof charset_table_init / sizeof *charset_table_init,
> + size / sizeof *charset_table_init);
> + emacs_abort ();
> + }
Why do you need to use %zu here? The 'enum's type is signed integer,
AFAIR, so %d should be enough. And for the second argument, we could
use a ptrdiff_t value instead.
We avoid using unsigned data types in Emacs, because they cause
trouble when mixed with the predominantly signed integer types we use.
bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 31 Oct 2025 05:55:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 31 01:55:41 2025
Received: from localhost ([127.0.0.1]:39587 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1vEi6u-0003wB-Re
for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 01:55:41 -0400
Received: from lists.gnu.org ([2001:470:142::17]:38008)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <gerd.moellmann@HIDDEN>)
id 1vEi6g-0003va-K6
for submit <at> debbugs.gnu.org; Fri, 31 Oct 2025 01:55:31 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1vEi6Z-0000fB-TD
for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 01:55:19 -0400
Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1vEi6W-0004DM-Ei
for bug-gnu-emacs@HIDDEN; Fri, 31 Oct 2025 01:55:19 -0400
Received: by mail-wm1-x329.google.com with SMTP id
5b1f17b1804b1-475dd559b0bso24198625e9.1
for <bug-gnu-emacs@HIDDEN>; Thu, 30 Oct 2025 22:55:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1761890111; x=1762494911; darn=gnu.org;
h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=3nsxOq6uA4aC7lwi8jCXQqHMALrxUKEtzIXsYyfGrYI=;
b=F3R0JfnXQy/6nv7CF8CH9FjLChGQQ3ddUv4SdvI+rPKp8+SA+ua4TL5fU605aeQb8k
s8qXJK3UbaajsALH1aSvyPumQOEMpRsKPXwbRyLv0Fu0GBLseeAQsWg4KGLQPuEL+wwN
rEfEiT5kVLQxjyxMsuDXdFFhRcD7sdfmufIy7iPkOUUoxnK51SBTChu2WfBmHhhSNA0q
xNs84/XoZIYBgjZYO+Wvr1ZAd+n2cV/8M+vHZBY0LV7hH+Od7ZoGJlR6roEdIgueMlR7
wRN4rlj6myuaYOQmYGZN7SwdEYJztJl33Sw6Etgi9AfAAwggdgTIbFip78gsJOfShEUT
j/Lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1761890111; x=1762494911;
h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=3nsxOq6uA4aC7lwi8jCXQqHMALrxUKEtzIXsYyfGrYI=;
b=HmbMCiYkBGKOdnmwPRBVRrfdMooYxW8IKv00s9nYQhqzaxvbcaSX5afEL0imgvzsVm
5cQdVhnlZSp4IHlc8whceaAl1Tb2sw1rroUf4ABVvZI4UmJQnB1kUsqCwRurG8hjneQi
ofLPwqjao0/fpqQ/OPbJUY2lTztSGsQlrODm/JFCofhgOJXZacllA7dOuBl5h1IvSATC
tzZpo7hBJHm02eiRPlwqUJttHMdK+SCuue8Y9qj5hvbZu0szV/7YrQClWhvUx6UcbmRk
UgKNqoZhfs+41TvZt96n5uMxwbIvbmP7J6zhprSFT4VEfJ8uNvdYP6sX5/M8JXqinO7v
otOA==
X-Gm-Message-State: AOJu0YxgDzfRpAPOREJQHFSH8Jy/HMcxCTykVIOztV/NsTQfKdpV2L+u
o6dCwxT8hgeYM77QvWF3kembAn9UhW6/oxcBBbXmiaNYvUAoab2RFUX0
X-Gm-Gg: ASbGncseJUbUhzjuHqx0wM3O0iw3VDav0Dqm1ExQCBzYsaPpL1B9Pkj3M5/06r7TmZj
XrFMwo48c3gLqopowiQ8GXbQkF3zHGb6K/EttzWI1F0p3SF57lv8yKiKlhYmwEdKO3yTiQM72Vp
dYgjFFBRnoRZOGyTqRGPYGUzTg0mRMPRGmJ5gio4M1xW7vlQbodZqzwRZZIiJblQqD+clcu8mjR
Ip0SmTEG1z3+pdxViosbVBxJx40rJujFFa5ud4yCV/GyyZK1fuh4S+/X4x9Yr46BRMU7OpPWNFf
8GG4ymH9DYK3AcxApv9m/FhWcorZa1mTiEQHdl1jJWpXfrDv/LgsZXNffGyxlE4zUcKEN9aigYw
q4h0Jmfkl7LPhjKIgOQOXchDcbO3kYxBNztxxyofVU+0jxmL/nqtBEVRf5iHh+c+kI+o+yKgjqb
7msfpkQGkpjAro9Ql8Bub7FuQg2yyorDz3AbtVPe+MXYMvI58EyvFJNDa+4yuITZJUd9GBPdrVx
swTJb3p32kv
X-Google-Smtp-Source: AGHT+IHpkH19Aq/1b9KreZsM2zvRG5GddacxiFmEvU+rjlja6DQGp6I3Yiwz2B3wdnNefH+X9h1yrA==
X-Received: by 2002:a05:600c:8418:b0:475:df91:de03 with SMTP id
5b1f17b1804b1-477308ec666mr16984485e9.39.1761890111346;
Thu, 30 Oct 2025 22:55:11 -0700 (PDT)
Received: from pro4 (p200300e0b738df0084449d7ceb59c631.dip0.t-ipconnect.de.
[2003:e0:b738:df00:8444:9d7c:eb59:c631])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-429c13f4732sm1505626f8f.43.2025.10.30.22.55.10
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 30 Oct 2025 22:55:10 -0700 (PDT)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] igc: Make size of charset_table_init changeable at build time
X-Debbugs-Cc:
Date: Fri, 31 Oct 2025 06:55:09 +0100
Message-ID: <m2ecqjbooy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::329;
envelope-from=gerd.moellmann@HIDDEN; helo=mail-wm1-x329.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Pip Cet <pipcet@HIDDEN>, Helmut Eller <eller.helmut@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
I've merged feature/igc into my Emacs and the 'mac' build aborted.
Reason was that charset_table_init is too small for the mac build, which
dumps ca. 280 charsets.
The attached patch makes the sizeof of charset_table_init changeable at
build time, and prints the reason before aborting in the pdumper.
WDYT Helmut and Pip?
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Make-size-of-charset_table_init-changeable-at-build-.patch
From 9e239f2df1fd26f0d48c5739b7827167ae5e93c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Date: Fri, 31 Oct 2025 06:45:07 +0100
Subject: [PATCH] Make size of charset_table_init changeable at build time
* src/charset.h (CHARSET_TABLE_INIT_SIZE): New.
* src/charset.c (charset_table_init): Use CHARSET_TABLE_INIT_SIZE.
* src/pdumper.c (dump_charset_table): Print why we abort.
---
src/charset.c | 2 +-
src/charset.h | 3 ++-
src/pdumper.c | 10 ++++++++--
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/charset.c b/src/charset.c
index 898cdd9d4d4..a24884624e3 100644
--- a/src/charset.c
+++ b/src/charset.c
@@ -2355,7 +2355,7 @@ init_charset_once (void)
during an initial bootstrap wreak havoc after dumping; see the
M_MMAP_THRESHOLD value in alloc.c, plus there is an extra overhead
internal to glibc malloc and perhaps to Emacs malloc debugging. */
-struct charset charset_table_init[180];
+struct charset charset_table_init[CHARSET_TABLE_INIT_SIZE];
void
syms_of_charset (void)
diff --git a/src/charset.h b/src/charset.h
index 54e2d1c437b..3908a29e5ff 100644
--- a/src/charset.h
+++ b/src/charset.h
@@ -546,7 +546,8 @@ #define EMACS_MULE_LEADING_CODE_PRIVATE_22 0x9D /* 2/2 */
Lisp_Object, Lisp_Object,
struct charset *, unsigned, unsigned);
-extern struct charset charset_table_init[180];
+enum { CHARSET_TABLE_INIT_SIZE = 300 };
+extern struct charset charset_table_init[CHARSET_TABLE_INIT_SIZE];
INLINE_HEADER_END
diff --git a/src/pdumper.c b/src/pdumper.c
index 7ec61d46f15..52c63e189ed 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -3404,10 +3404,16 @@ dump_charset_table (struct dump_context *ctx)
dump_clear_referrer (ctx);
#ifndef HAVE_MPS
dump_emacs_reloc_to_dump_ptr_raw (ctx, &charset_table, offset);
-#else
+# else
size_t size = ctx->offset - offset;
if (size > sizeof charset_table_init)
- emacs_abort ();
+ {
+ fprintf (stderr,
+ "CHARSET_TABLE_INIT_SIZE is %zu, need at least %zu\n",
+ sizeof charset_table_init / sizeof *charset_table_init,
+ size / sizeof *charset_table_init);
+ emacs_abort ();
+ }
dump_emacs_reloc_copy_from_dump (ctx, offset, &charset_table_init,
size);
#endif
--
2.51.2
--=-=-=--
Gerd Möllmann <gerd.moellmann@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#79733; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.