GNU bug report logs - #79757
[PATCH] eglot: eglot-rename, use symbol at point as default input

Previous Next

To reply to this bug, email your comments to 79757 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] eglot: eglot-rename, use symbol at point as default input
Date: Sun, 2 Nov 2025 14:46:09 +0100

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-eglot-eglot-rename-use-symbol-at-point-as-default-in.patch (text/x-patch, attachment)]

Message #8 received at 79757 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: zarkonesmall <at> gmail.com, João Távora
 <joaotavora <at> gmail.com>
Cc: 79757 <at> debbugs.gnu.org
Subject: Re: bug#79757: [PATCH] eglot: eglot-rename,
 use symbol at point as default input
Date: Mon, 03 Nov 2025 14:01:58 +0200

> From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
> Date: Sun, 2 Nov 2025 14:46:09 +0100
> 
> From 0ec7beeb713f39e6d4fc6ac7e5482d316a51dd0e Mon Sep 17 00:00:00 2001
> From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
> Date: Sun, 2 Nov 2025 14:39:09 +0100
> Subject: [PATCH] eglot: eglot-rename, use symbol at point as default input
> 
> ---
>  lisp/progmodes/eglot.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 27e79b2f816..3039a2e2ebc 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -4007,7 +4007,7 @@ edit proposed by the server."
>            (eglot--format "Rename `%s' to: "
>                           (or (thing-at-point 'symbol t)
>                               "unknown symbol"))
> -          nil nil nil nil
> +          (thing-at-point 'symbol t) nil nil nil
>            (symbol-name (symbol-at-point)))))
>    (eglot-server-capable-or-lose :renameProvider)
>    (eglot--apply-workspace-edit
> -- 

João, any comments?

Message #11 received at 79757 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: zarkonesmall <at> gmail.com, 79757 <at> debbugs.gnu.org
Subject: Re: bug#79757: [PATCH] eglot: eglot-rename, use symbol at point as
 default input
Date: Mon, 3 Nov 2025 13:23:32 +0000

[Message part 1 (text/plain, inline)]

I think this looks good.  Let's hope it doesn't annoy people.
I think it won't...

Just needs some micro-adjustments to these micro-nits.

In the commit message

- should start with capital 'Eglot:'.  Probably should be
'Eglot: use symbol at point as default in eglot-rename'

- Needs the usual. * list/progmodes/eglot.el (eglot-rename): Tweak.

- Needs the bug number

- Needs the Copyright-paperwork-exempt: yes in case Anatolii doesn't
have an assignment.

Additionally, I think this should be called out in etc/EGLOT-NEWS.

I'll try to do these things later if noone beats me to it.

João



On Mon, Nov 3, 2025 at 12:02 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
> > Date: Sun, 2 Nov 2025 14:46:09 +0100
> >
> > From 0ec7beeb713f39e6d4fc6ac7e5482d316a51dd0e Mon Sep 17 00:00:00 2001
> > From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
> > Date: Sun, 2 Nov 2025 14:39:09 +0100
> > Subject: [PATCH] eglot: eglot-rename, use symbol at point as default
> input
> >
> > ---
> >  lisp/progmodes/eglot.el | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 27e79b2f816..3039a2e2ebc 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -4007,7 +4007,7 @@ edit proposed by the server."
> >            (eglot--format "Rename `%s' to: "
> >                           (or (thing-at-point 'symbol t)
> >                               "unknown symbol"))
> > -          nil nil nil nil
> > +          (thing-at-point 'symbol t) nil nil nil
> >            (symbol-name (symbol-at-point)))))
> >    (eglot-server-capable-or-lose :renameProvider)
> >    (eglot--apply-workspace-edit
> > --
>
> João, any comments?
>


-- 
João Távora

[Message part 2 (text/html, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Schlatte <rudi <at> constantly.at>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#79757: [PATCH] eglot: eglot-rename,
 use symbol at point as default input
Date: Mon, 03 Nov 2025 16:02:00 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
>> Date: Sun, 2 Nov 2025 14:46:09 +0100
>> 
>> From 0ec7beeb713f39e6d4fc6ac7e5482d316a51dd0e Mon Sep 17 00:00:00 2001
>> From: Anatolii Smolianinov <zarkonesmall <at> gmail.com>
>> Date: Sun, 2 Nov 2025 14:39:09 +0100
>> Subject: [PATCH] eglot: eglot-rename, use symbol at point as default input
>> 
>> ---
>>  lisp/progmodes/eglot.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
>> index 27e79b2f816..3039a2e2ebc 100644
>> --- a/lisp/progmodes/eglot.el
>> +++ b/lisp/progmodes/eglot.el
>> @@ -4007,7 +4007,7 @@ edit proposed by the server."
>>            (eglot--format "Rename `%s' to: "
>>                           (or (thing-at-point 'symbol t)
>>                               "unknown symbol"))
>> -          nil nil nil nil
>> +          (thing-at-point 'symbol t) nil nil nil
>>            (symbol-name (symbol-at-point)))))
>>    (eglot-server-capable-or-lose :renameProvider)
>>    (eglot--apply-workspace-edit
>> -- 
>
> João, any comments?

(Not João, but) this calculates the symbol at point twice, once via
(thing-at-point 'symbol t) for the initial value and once via
(symbol-name (symbol-at-point)) for the default value.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.